Ah alright.

Successful build - Chance fights ever on the side of the prudent.

In D3823#166178, @Stan wrote:

The changes in Xeromyces.cpp look a bit hacky?

it's not entirely clean yet, but it's just a JS->XMB instead of XML->XMB parse, nothing too weird.

The changes in Xeromyces.cpp look a bit hacky? Also that means we're gonna be creating a bunch of new files even in release builds which seems a bit counterintuitive?

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Update. This no longer uses ParamNode, instead I generate an XMB file directly from JS. This has the advantage of requiring fewer fundamental changes in the GUI & possibly being fast overall.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Rebased. Will commit the images from the forum post alongside.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

In D3554#156531, @OptimusShepard wrote:

I'm not sure if there is something bugged, or if we need to modify or create a new function. Currently the toggle(), or as you said a enable/disable() doesn't effect anything. You can remove this function and the saveToFile() function will work anyway.

That's because profiler2 is always initialised. What you're toggling is just the HTTP server.

Rebased. Improved.

The issue has been around since at least 2019 and perhaps even 2017, so I'm not very eager to try and find that out ;)

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Is there a revision that introduced this ?

Glad to be able to ditch that tech now :)
I saw no wrong inf/cav.

It seems like the diff is mostly for formations - I'd rather use a different constant for those.

Successful build - Chance fights ever on the side of the prudent.

In D3835#166054, @wraitii wrote:

I think that could actually be rP25229 maybe?

In D3835#166051, @Langbart wrote:

I think that could actually be rP25229 maybe?

Actually it's even worse, it broke every single decal in the game. The field doesn't work, cause it's decal only.

In rP25224#50631, @Stan wrote:

What field is this ? Open it in atlas. )

What field is this ? Open it in atlas. )

In rP25224#50622, @Stan wrote:

Apparently (According to @Langbart it broke fields)

I could not apply this patch via Arcanist, it showed me this error

Apparently (According to @Langbart it broke fields)

That broke --without-pch.

Build failure - The Moirai have given mortals hearts that can endure.

Probably gonna put this on the back-burner, I don't actually need it for D3823 -> all I need is to parse JS into XMB, and that's just one function.
I'm not sure it would ever make too much sense to have arbitrary-named paramnodes, perhaps just an "array" node type would suffice.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

This fixes a few interface woes & cleans code up.

Compile, run tests. Open the game, notice specific names still work alright. Load the unit demo > all OK.

In D3831#165975, @Stan wrote:

I'm not sure how the builder merge works here ?

I'm not sure how the builder merge works here ?

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

You probably forgot a few includes. namely vector and memory :)

Address inlines. Rename to "Mouse event mask".