We merged the other GL loader.

icon ideas:
level 1 have 'I' in the top right, level two have 'II' in the top right.

@vladislavbelov asked me to clarify more things before committing this, because it might lead to a 6 months Feature Freeze or a painful revert.
We need to make sure it doesn't cause more spikes in other cases.

In D4758#203957, @Stan wrote:

I the meantime can you keep testing it with different loads and replays to make sure there isn't something unstable ? :)

EG. The custom combat huge demo or a 4v4 with ais on big maps etc.

I the meantime can you keep testing it with different loads and replays to make sure there isn't something unstable ? :)

Nah, this looks alright, will see about committing it after the release comes out.

No worries, do you need me to upload again?

Sorry about that, ZFS keeps failing these days, and the VM gets stuck.

Build was aborted.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Looks good to go. Wonder if they should have a copyright header. According to https://trac.wildfiregames.com/browser/ps/trunk/source/tools/LICENSE.txt it's MIT.
Won't commit because we reached CF, but will be nice after the release.

Added time units (seconds, milliseconds) to variable names.

Made Relese NG entity file an optional argument

In D4698#203936, @Stan wrote:

Just realised I'm an idiot and you need a way to specify the location because you don't want to put the rng in the mod folder (since you're probably gonna zip it afterwards) and it won't be there on the CI either.

Just realised I'm an idiot and you need a way to specify the location because you don't want to put the rng in the mod folder (since you're probably gonna zip it afterwards) and it won't be there on the CI either.
Sorry, that's what happens when I do too much things at once.

Deleted the middle directory scripts in entity.rng's location. Didn't made it eligible, by argument, to avoid directory creation in case of not existence.

In D4698#203928, @Stan wrote:

~~ Sadly I'm not sure I can set you as author. There seem to be a way but I dunno if trac and phab support it https://stackoverflow.com/questions/2107719/how-to-set-author-for-svn#2107898 ~~

EDIT: Seems it's only for files.

~~ Sadly I'm not sure I can set you as author. There seem to be a way but I dunno if trac and phab support it https://stackoverflow.com/questions/2107719/how-to-set-author-for-svn#2107898 ~~

It's been a complete overhaul of the file, but it is working. Now it receives the modules' location and name as parameters.

Added a new diff with the flag -U3000 as suggested on IRC.

As there haven't been any more feedback on this revision and we had various cases where people got confused which code is the current one, I went ahead and committed the changes now.

Fix year and LGTM.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

• Make config variable naming consistent
• Check whether the passed in upgrade at least exists

That commit leads to an out of bounds access on each match start. I'm not sure there is no other bugs in the code.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

• Minor lint changes
• Set plan ID
• Move damage priorities to config

Maybe try this flag https://github.com/7wells/0ad/blob/master/binaries/system/readme.txt#L75

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build was aborted.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

change parameter order of PushTask
add context

In D4425#203777, @Stan wrote:

Can't you make it the responsibility of the receiver to destroy objects instead of adding the extra overhead of a unique ptr?

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Revert to the one that worked

Note to self/anyone else interested: One could also use this in the army manager to upgrade units as well. If the army composition is more melee, the persian champions could instead be switched to archer variants to balance it out and whatnot.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

@Mister if you have still time for this patch there are a few things left:

• We'd like a unit test (like the one I edited) for the new behaviour. (Basically a copy-pasta from one of the tests, but ensure that the entity to repair/construct is not in the cmpBuilder.Entities list.)
• Our GUI needs some change, you probably need to take a look at unit_actions.js (https://code.wildfiregames.com/source/0ad/browse/ps/trunk/binaries/data/mods/public/gui/session/unit_actions.js) and especially in the function around L437 (https://code.wildfiregames.com/source/0ad/browse/ps/trunk/binaries/data/mods/public/gui/session/unit_actions.js$437-448).

Fix tests (from Diff 20734).

One could consider making Petra a bit more chatty in debug mode. I.e. add some debug chat about trying to upgrade.

Makes sense.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build is unstable, some tests have failed - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

In D4425#203777, @Stan wrote:

Can't you make it the responsibility of the receiver to destroy objects instead of adding the extra overhead of a unique ptr?

I guess an overkill solution could also be to have a destruction queue that's emptied when trying to push new tasks.

fix the actual memory leak bug

Can't you make it the responsibility of the receiver to destroy objects instead of adding the extra overhead of a unique ptr?

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

fix the memory leak