Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Made the command line interface simpler by removing parsing of --identifiertype, --effecttype, and --responsetype switches.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

• Added source/network/NetModerationTables.h
• Added binaries/data/mods/public/gui/common/moderation/parse_moderation_commands.js
• Added binaries/data/mods/public/gui/common/moderation/decode_moderation_response.js
• Added binaries/data/mods/public/gui/common/moderation/moderation_tables.js

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Changed colors to: green to enable feedback, red to disable it.

I agree that a red button looks like people shouldn't interact with it, or interact only in emergency.

In retrospect, red makes it look like you can't interact with it, maybe green would be better. I'm not sure.

Fine for me. I'll try to commit this this week, unless objected.

@Freagarach @bb is the proposed fix acceptable for FF?

... and provide context to your patch.

Yes @Angen, will do!

(With context I meant like described here: https://trac.wildfiregames.com/wiki/SubmittingPatches#Makingsomechanges.)

*JSDoc

Hi,
while waiting for review, could you please transform comments above functions and classes into javadoc style?
https://trac.wildfiregames.com/wiki/Coding_Conventions#Documentation

Thanks for making time and adding this. @Freagarach I believe from this https://wildfiregames.com/forum/topic/51086-popup-choices-for-scenario-scripts/?tab=comments#comment-446466 discussion you wanted to add this. BTW is it not similar to https://github.com/AlexanderOlkhovskiy/0ad-civ-choices-mod ? which also would be nice to add.

Freagarach means using token modifiers to change the templates, instead of adding new templates. You can look at the tests I think for some examples.

In D4196#178358, @Freagarach wrote:

I think it is cleaner to disable stuff using triggers.

I think it is cleaner to disable stuff using triggers.

Yeah icons need rework.

works, but does not look neat:
Long yellow text by default: "[Unassigned hotkey: session.queueinit.autoqueueon]" (expected "[ ]")
The icon on the right overshadows the gray border (the adjacent icons, on the contrary, are one pixel less than the black square)

Congratz on landing your first patch, @azayrahmad!

Some slight adaptations, added a unit test.

In D3865#168881, @Freagarach wrote:

This is a nice feature.
There are some minor code-style issues, but I'll handle those when comittting.

@azayrahmad, can you upload a .zip with the images here?

This is a nice feature.
There are some minor code-style issues, but I'll handle those when comittting.

I don't think they are great, but I suppose they could work as placeholders. If I read this patch correctly, the feature cannot be disabled, right? So we're introducing a significant gameplay change.
Is everything translated as it should?