Page MenuHomeWildfire Games
Feed Advanced Search

Wed, Jul 17

vladislavbelov added inline comments to rP22487: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions..
Wed, Jul 17, 12:04 AM

Tue, Jul 16

vladislavbelov added inline comments to D2084: Remove CMapGeneratorWorker struct AutoFree.
Tue, Jul 16, 11:59 PM
vladislavbelov added a comment to D2079: Adds snapping to edges for buildings.

Why put this behind a hotkey?

Tue, Jul 16, 5:18 PM
vladislavbelov added inline comments to D2030: Update wxWidgets readme [VS2013 -> VS2015].
Tue, Jul 16, 11:56 AM
vladislavbelov updated subscribers of D2076: Make wxWidgets 3.0 build requirement more explicit.

What's about Ubuntu 14.04? We still have such audience (judging by feedback statistics).

Tue, Jul 16, 2:00 AM

Mon, Jul 15

asterix awarded D2079: Adds snapping to edges for buildings a Party Time token.
Mon, Jul 15, 9:49 PM
nani awarded D2079: Adds snapping to edges for buildings a Party Time token.
Mon, Jul 15, 12:59 AM
elexis awarded D2079: Adds snapping to edges for buildings a Orange Medal token.
Mon, Jul 15, 12:53 AM
vladislavbelov created D2079: Adds snapping to edges for buildings.
Mon, Jul 15, 12:20 AM

Sat, Jul 13

vladislavbelov updated the diff for D2020: Refactors Camera aspect ratio and calculation of plane points.

Fixes @elexis's notes from IRC (2019-07-03#0ad-dev):

Sat, Jul 13, 9:54 PM

Fri, Jul 12

vladislavbelov added inline comments to D2058: FixedVector2D CompareLengthSquared.
Fri, Jul 12, 12:34 PM

Tue, Jul 9

vladislavbelov committed rP22445: Adds an tool to pick water high by terrain click in Atlas..
Adds an tool to pick water high by terrain click in Atlas.
Tue, Jul 9, 8:17 PM
vladislavbelov closed D2037: [ATLAS] Adds a tool to pick water high by terrain click.
Tue, Jul 9, 8:17 PM
vladislavbelov added inline comments to D2055: Fix 4500 gcc 8, gcc 9 compile warnings.
Tue, Jul 9, 1:44 AM
vladislavbelov accepted D2055: Fix 4500 gcc 8, gcc 9 compile warnings.
Tue, Jul 9, 1:33 AM
vladislavbelov added inline comments to D2055: Fix 4500 gcc 8, gcc 9 compile warnings.
Tue, Jul 9, 1:26 AM
vladislavbelov added inline comments to D2055: Fix 4500 gcc 8, gcc 9 compile warnings.
Tue, Jul 9, 12:54 AM

Mon, Jul 8

vladislavbelov added inline comments to D2055: Fix 4500 gcc 8, gcc 9 compile warnings.
Mon, Jul 8, 11:59 PM

Sun, Jul 7

vladislavbelov added a comment to D2043: Fix build without precompiled headers following Atlas UTF8 fix rP22335 and ThreadUtil fix rP22344.

Reviewed on IRC (from few days).

Sun, Jul 7, 11:45 PM
vladislavbelov accepted D2043: Fix build without precompiled headers following Atlas UTF8 fix rP22335 and ThreadUtil fix rP22344.
Sun, Jul 7, 11:45 PM

Sat, Jul 6

vladislavbelov added a comment to D2019: [ATLASUI] Main Thread Checker: UI API called on a background thread: -[NSView initWithFrame:].

Did someone test it with an old platform?

Sat, Jul 6, 2:30 AM

Fri, Jul 5

vladislavbelov added a comment to D2043: Fix build without precompiled headers following Atlas UTF8 fix rP22335 and ThreadUtil fix rP22344.

Why you didn't change implementation too?

Fri, Jul 5, 7:55 PM
vladislavbelov added a comment to D2040: Improve performance Object List Filter Atlas.

What's the minimal wxWidgets version that supports wxListView?

Fri, Jul 5, 12:37 PM

Thu, Jul 4

elexis awarded D2037: [ATLAS] Adds a tool to pick water high by terrain click a Like token.
Thu, Jul 4, 9:29 AM
vladislavbelov added a comment to D2029: Fix for rP22314 - call IdleTask in Atlas and swap buffers only once.

needs some investigation.

Have you some results? Did you reproduce Stan's issue?

Thu, Jul 4, 2:51 AM
vladislavbelov retitled D2037: [ATLAS] Adds a tool to pick water high by terrain click from Adds a tool to pick water high by terrain click to [ATLAS] Adds a tool to pick water high by terrain click.
Thu, Jul 4, 2:32 AM
vladislavbelov created D2037: [ATLAS] Adds a tool to pick water high by terrain click.
Thu, Jul 4, 2:31 AM
vladislavbelov planned changes to D2020: Refactors Camera aspect ratio and calculation of plane points.
Thu, Jul 4, 12:05 AM

Wed, Jul 3

vladislavbelov updated the diff for D2020: Refactors Camera aspect ratio and calculation of plane points.
Wed, Jul 3, 11:53 PM
vladislavbelov updated the diff for D2020: Refactors Camera aspect ratio and calculation of plane points.

Adds CCamera::Quad.

Wed, Jul 3, 11:51 PM
vladislavbelov committed rP22432: Adds a possibility to disable saving of replay in autostart mode..
Adds a possibility to disable saving of replay in autostart mode.
Wed, Jul 3, 11:37 PM
vladislavbelov closed D2017: Allows replays in autostart-nonvisual mode.
Wed, Jul 3, 11:36 PM

Tue, Jul 2

vladislavbelov accepted rP12300: ao/parallax/normal/specular/emissive mapping; windy trees; time manager; render….
Tue, Jul 2, 3:45 PM

Sat, Jun 29

vladislavbelov added a comment to D2019: [ATLASUI] Main Thread Checker: UI API called on a background thread: -[NSView initWithFrame:].

So, I think we may have only a workaround solution here. Because we have 2 independent libraries each of them thinks that it process all events lonely and calls OS API directly.

Sat, Jun 29, 8:06 PM
vladislavbelov added inline comments to D2024: Avoid VertexPathfinder pointer in rP22253.
Sat, Jun 29, 8:01 PM
vladislavbelov added a comment to D2020: Refactors Camera aspect ratio and calculation of plane points.

Suggestion: wouldn't it be better to rename "Get[Near/Far]Plane" to "Get[Near/Far]PlaneDistance"

I don't mind, only note that the distance in the camera space.

Sat, Jun 29, 7:54 PM
elexis awarded rP22401: Fix missing slash in common-api of entity. The mistype was introduced in… a Like token.
Sat, Jun 29, 12:15 AM

Fri, Jun 28

vladislavbelov updated the diff for D2020: Refactors Camera aspect ratio and calculation of plane points.

Fixes styles.

Fri, Jun 28, 8:59 PM
vladislavbelov updated the diff for D2020: Refactors Camera aspect ratio and calculation of plane points.
Fri, Jun 28, 1:43 AM
vladislavbelov created D2020: Refactors Camera aspect ratio and calculation of plane points.
Fri, Jun 28, 1:42 AM

Thu, Jun 27

vladislavbelov updated the diff for D2017: Allows replays in autostart-nonvisual mode.

Renames to autostart-disable-replay by @elexis suggestion.

Thu, Jun 27, 10:48 PM
vladislavbelov added inline comments to D1988: Workaround differences between libc and libstd string stream parsing of float/doubles.
Thu, Jun 27, 9:53 AM
elexis awarded D2017: Allows replays in autostart-nonvisual mode a Like token.
Thu, Jun 27, 2:01 AM
vladislavbelov committed rP22404: Refactors camera projections - makes projection functions of camera more clear..
Refactors camera projections - makes projection functions of camera more clear.
Thu, Jun 27, 12:54 AM
vladislavbelov closed D2012: Refactors Camera projections.
Thu, Jun 27, 12:54 AM
vladislavbelov committed rP22403: Removes unused and obsolete LightingModel..
Removes unused and obsolete LightingModel.
Thu, Jun 27, 12:30 AM
vladislavbelov closed D2011: Removes unused LightingModel.
Thu, Jun 27, 12:30 AM
vladislavbelov created D2017: Allows replays in autostart-nonvisual mode.
Thu, Jun 27, 12:13 AM

Wed, Jun 26

vladislavbelov added a comment to rP22401: Fix missing slash in common-api of entity. The mistype was introduced in….

Also there are occurrences in rP14865 and rP15153.

Wed, Jun 26, 11:11 PM
vladislavbelov added inline comments to D1988: Workaround differences between libc and libstd string stream parsing of float/doubles.
Wed, Jun 26, 11:04 PM
vladislavbelov added a comment to D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].
In D1396#83410, @Angen wrote:

as we are now compiling game with vs15, this is not needed

Wed, Jun 26, 9:32 PM
vladislavbelov committed rP22402: Update the minimap, range overlay renderer, and status bars when a player's….
Update the minimap, range overlay renderer, and status bars when a player's…
Wed, Jun 26, 9:17 PM
vladislavbelov closed D1261: Update the minimap, range overlay renderer, and status bars when a player's color is changed in Atlas.
Wed, Jun 26, 9:17 PM
vladislavbelov accepted D1261: Update the minimap, range overlay renderer, and status bars when a player's color is changed in Atlas.

I tested the patch, it works well. I checked the linked commit and made a search over our repo, and it seems that the patch covers all missed color updates.

Wed, Jun 26, 9:16 PM
vladislavbelov committed rP22401: Fix missing slash in common-api of entity. The mistype was introduced in….
Fix missing slash in common-api of entity. The mistype was introduced in…
Wed, Jun 26, 8:05 PM
vladislavbelov closed D1994: Fix missing slash in common-api.
Wed, Jun 26, 8:05 PM
vladislavbelov accepted D1994: Fix missing slash in common-api.
In D1994#84008, @Angen wrote:

@vladislavbelov no steps to reproduce needed it is look and see situation

I figured out. It's not used at all. It was added in rP12343, and its usage was removed in rP13687.

Wed, Jun 26, 7:57 PM
vladislavbelov added a comment to D2013: Fix incorrect use of setlocale() in cppformat CStr tests.

I don't think we have a use for it right now, no. So it could be seen as being too much future-proofing.

Wed, Jun 26, 7:40 PM
vladislavbelov added inline comments to D2012: Refactors Camera projections.
Wed, Jun 26, 7:15 PM
vladislavbelov updated the diff for D2012: Refactors Camera projections.

Renames SetPerspective to SetPerspectiveProjection.

Wed, Jun 26, 7:14 PM
vladislavbelov added a comment to D2013: Fix incorrect use of setlocale() in cppformat CStr tests.

Indeed, which is why I would lock this behind a global mutex, so it goes

  1. locale=default
  2. T1::ScopedLocale::ctor(L1), locale=L1
  3. T2::ScopedLocale::ctor(L2) - blocked
  4. T1::ScopedLocale::dtor(), locale=default
  5. resuming of T2::ScopedLocale::ctor(L2) - locale=L2
  6. T2::ScopedLocale::dtor(), locale=default

Yeah. By the way where it can be useful? Do we have such cases?

Wed, Jun 26, 12:33 PM
vladislavbelov added a comment to D2013: Fix incorrect use of setlocale() in cppformat CStr tests.

Agreed, I think we should also protect these calls behind a global mutex, so that it actually becomes threadsafe.

If you'd use the current implementation of ScopedLocale in multiple threads, then it highly likely wouldn't work. For ex (T1 - thread N1, T2 - thread N2, L1 - locale N1, L2 - locale N2):

Wed, Jun 26, 10:39 AM
vladislavbelov added a comment to D2013: Fix incorrect use of setlocale() in cppformat CStr tests.

I think the following helper could be helpful, at least it may prevent such bugs in reusing:

class ScopedLocale
{
public:
    ScopedLocale(int category, char* newLocale)
        : m_Category(category), m_OldLocale(setlocale(category, NULL))
    {
        TS_ASSERT(setlocale(m_Category, newLocale) != nullptr);
    }
    ~ScopedLocale()
    {
        setlocale(m_Category, m_OldLocale);
    }
private:
    int m_Category;
    char* m_OldLocale;
};
Wed, Jun 26, 9:30 AM
vladislavbelov added inline comments to D2012: Refactors Camera projections.
Wed, Jun 26, 1:08 AM
vladislavbelov created D2012: Refactors Camera projections.
Wed, Jun 26, 1:04 AM
elexis awarded rP22395: Makes rendering helpers (culling camera, frustums) be available through the… a Like token.
Wed, Jun 26, 12:57 AM

Tue, Jun 25

vladislavbelov added a comment to D1994: Fix missing slash in common-api.

Could you attach steps to reproduce the bug?

Tue, Jun 25, 11:55 PM
vladislavbelov added inline comments to D2011: Removes unused LightingModel.
Tue, Jun 25, 11:36 PM
vladislavbelov created D2011: Removes unused LightingModel.
Tue, Jun 25, 10:40 PM
vladislavbelov added a comment to D1492: Abort instead of throwing an error when dealing with empty areas..
In D1492#83849, @smiley wrote:

(most of those posts were removed)

I'm not aware of it, could you post some links to the topics where it happened, if you don't mind.

Tue, Jun 25, 10:30 PM
vladislavbelov accepted rP22297: Water GLSL shader improvements around reflections and whitespace fixes..

It would be much cleaner with: Reflections: None, Sky, Everything.

That'd be cool!

Tue, Jun 25, 9:40 PM
vladislavbelov added a comment to D1492: Abort instead of throwing an error when dealing with empty areas..
In D1492#83837, @smiley wrote:
  1. Look at the date on which this was uploaded
  2. Look at what was changed
  3. Try to come up with a reason
Tue, Jun 25, 9:38 PM
vladislavbelov added a comment to D1492: Abort instead of throwing an error when dealing with empty areas..
In D1492#83822, @smiley wrote:

Nobody cares about tiny maps anyway.

Tue, Jun 25, 8:35 PM

Sun, Jun 23

vladislavbelov committed rP22395: Makes rendering helpers (culling camera, frustums) be available through the….
Makes rendering helpers (culling camera, frustums) be available through the…
Sun, Jun 23, 10:18 PM
vladislavbelov closed D1972: Makes some rendering helpers be available through the developer overlay..
Sun, Jun 23, 10:18 PM
vladislavbelov raised a concern with rP22351: Prevent UnitMotion from stopping on its own, and rename "MoveCompleted" to….
Sun, Jun 23, 2:49 AM

Sat, Jun 22

vladislavbelov added inline comments to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.
Sat, Jun 22, 12:24 PM
vladislavbelov updated subscribers of D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Did you reproduce @Itms steps before the patch?

Sat, Jun 22, 2:34 AM

Fri, Jun 21

vladislavbelov added a comment to D1988: Workaround differences between libc and libstd string stream parsing of float/doubles.

I would certainly hope none otherwise MacOS has been behaving wrong for years.
The only place I can think of that parses strings to number is GUI sizes, which would previously parse things like "3b" as "0" instead of the 'correct' "3". I don't think there's mods or 0 A.D. code that relied on that - and I'm not sure we want that code to live.

Do we really need that behaviour for wrong strings?

Fri, Jun 21, 10:24 PM
vladislavbelov requested changes to D1988: Workaround differences between libc and libstd string stream parsing of float/doubles.

How many lines of our code depend on this behaviour (that wrong strings are still parsed)?

Fri, Jun 21, 9:11 PM
vladislavbelov accepted D1985: Skybox calculation - fix regression of rP22039 introduced in rP22297.

I tested, now the reflection works as after my commit.

Fri, Jun 21, 6:00 PM
vladislavbelov added inline comments to rP22297: Water GLSL shader improvements around reflections and whitespace fixes..
Fri, Jun 21, 5:50 PM

Jun 15 2019

vladislavbelov added a reviewer for D1985: Skybox calculation - fix regression of rP22039 introduced in rP22297: vladislavbelov.
Jun 15 2019, 10:06 PM
vladislavbelov raised a concern with rP22297: Water GLSL shader improvements around reflections and whitespace fixes..
Jun 15 2019, 9:49 PM
vladislavbelov added inline comments to D1978: tests: Fix cppformat failures on osx (locale-related).
Jun 15 2019, 8:09 PM
vladislavbelov added inline comments to D1978: tests: Fix cppformat failures on osx (locale-related).
Jun 15 2019, 7:48 PM
vladislavbelov added a comment to D1976: Remove gamma ramp setting..
In D1976#82463, @Stan wrote:

custom color space might be weird, since the following code would be messing it up :P

It depends, because color correction may present on each side: os, gpu driver, monitor.

Jun 15 2019, 4:49 PM
vladislavbelov added a comment to D1976: Remove gamma ramp setting..

I think the patch should be tested on multi-monitor environment and with a custom color space.

Jun 15 2019, 4:45 PM

Jun 12 2019

Stan awarded D1972: Makes some rendering helpers be available through the developer overlay. a Love token.
Jun 12 2019, 10:41 PM
vladislavbelov created D1972: Makes some rendering helpers be available through the developer overlay..
Jun 12 2019, 10:39 PM
vladislavbelov committed rP22372: Cleanups BoundingBoxAxisAligned and fixes coding styles a bit..
Cleanups BoundingBoxAxisAligned and fixes coding styles a bit.
Jun 12 2019, 10:23 PM
vladislavbelov closed D1951: Cleanups BoundingBoxAxisAligned before refactoring.
Jun 12 2019, 10:23 PM
vladislavbelov committed rP22371: Fixes includes and forward declarations in CPatchRData..
Fixes includes and forward declarations in CPatchRData.
Jun 12 2019, 10:03 PM
vladislavbelov closed D1952: Fixes includes and forward declarations in CPatchRData.
Jun 12 2019, 10:03 PM
vladislavbelov committed rP22370: Refactors Developer Overlay using an object instead of global functions..
Refactors Developer Overlay using an object instead of global functions.
Jun 12 2019, 9:22 PM
vladislavbelov closed D1928: Refactors Developer Overlay.
Jun 12 2019, 9:22 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Jun 12 2019, 2:53 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Jun 12 2019, 12:28 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Jun 12 2019, 1:01 AM

Jun 11 2019

nani awarded D1928: Refactors Developer Overlay a Dat Boi token.
Jun 11 2019, 11:25 PM