Page MenuHomeWildfire Games
Feed Advanced Search

Sun, Oct 6

vladislavbelov updated the diff for D2357: Adds ScreenshotWriter to minimise code duplication.

Fixes @Stan `s notes.

Sun, Oct 6, 5:20 PM
vladislavbelov updated the diff for D2357: Adds ScreenshotWriter to minimise code duplication.

Adds if ( space and moves destructor to header.

Sun, Oct 6, 5:17 PM

Sat, Oct 5

vladislavbelov updated the summary of D2356: Adds BMPBlockWriter to prevent huge memory allocation.
Sat, Oct 5, 9:02 PM
vladislavbelov added inline comments to D2357: Adds ScreenshotWriter to minimise code duplication.
Sat, Oct 5, 6:50 PM
vladislavbelov created D2357: Adds ScreenshotWriter to minimise code duplication.
Sat, Oct 5, 6:28 PM
vladislavbelov updated the diff for D2356: Adds BMPBlockWriter to prevent huge memory allocation.
Sat, Oct 5, 4:49 PM
vladislavbelov added inline comments to D2356: Adds BMPBlockWriter to prevent huge memory allocation.
Sat, Oct 5, 4:37 PM
vladislavbelov updated the diff for D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Removes unused variables.

Sat, Oct 5, 4:26 PM
vladislavbelov added inline comments to D2356: Adds BMPBlockWriter to prevent huge memory allocation.
Sat, Oct 5, 4:17 PM
vladislavbelov updated the diff for D2356: Adds BMPBlockWriter to prevent huge memory allocation.
Sat, Oct 5, 4:02 PM
vladislavbelov updated the diff for D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Fixes @elexis `s notes.

Sat, Oct 5, 3:52 PM
vladislavbelov added inline comments to D2356: Adds BMPBlockWriter to prevent huge memory allocation.
Sat, Oct 5, 2:46 PM
vladislavbelov created D2356: Adds BMPBlockWriter to prevent huge memory allocation.
Sat, Oct 5, 2:45 PM
vladislavbelov awarded D2354: Correct button hovering following rP23020 / D2325, clarify difference between IsMouseOver and IsMouseHovering following rP74 a Like token.
Sat, Oct 5, 11:52 AM
vladislavbelov added inline comments to D825: Atlas: Allow map to recenter during resize.
Sat, Oct 5, 12:13 AM
vladislavbelov committed rP23046: Removes unused variables after rP23031 and rP23036. Reported by elexis..
Removes unused variables after rP23031 and rP23036. Reported by elexis.
Sat, Oct 5, 12:07 AM

Fri, Oct 4

vladislavbelov committed rP23044: Adds containers serialization tests, std::set serialization and movement….
Adds containers serialization tests, std::set serialization and movement…
Fri, Oct 4, 11:31 PM
vladislavbelov closed D2352: Adds containers serialization tests, std::set serialization and movement semantics.
Fri, Oct 4, 11:31 PM
vladislavbelov updated the diff for D2352: Adds containers serialization tests, std::set serialization and movement semantics.
Fri, Oct 4, 10:55 PM
vladislavbelov updated the diff for D2352: Adds containers serialization tests, std::set serialization and movement semantics.
Fri, Oct 4, 10:40 PM
vladislavbelov updated the diff for D2352: Adds containers serialization tests, std::set serialization and movement semantics.
Fri, Oct 4, 10:31 PM
vladislavbelov updated the diff for D2352: Adds containers serialization tests, std::set serialization and movement semantics.

Reverts vector changes.

Fri, Oct 4, 10:18 PM
vladislavbelov updated the diff for D2352: Adds containers serialization tests, std::set serialization and movement semantics.
Fri, Oct 4, 8:36 PM
vladislavbelov updated the diff for D2352: Adds containers serialization tests, std::set serialization and movement semantics.
Fri, Oct 4, 7:49 PM
vladislavbelov updated the diff for D2352: Adds containers serialization tests, std::set serialization and movement semantics.

Fixes @elexis `s note.

Fri, Oct 4, 6:39 PM
vladislavbelov added a comment to D2352: Adds containers serialization tests, std::set serialization and movement semantics.

I was trying to load a saved game with this patch enabled, but all I get when the game has loaded is a white screen where I can select units (whilst not seeing them). When I move an entity I get the following error: CCmpObstructionManager.cpp(877): Assertion failed: "it != m_UnitShapes.end()".
If you need more information, please let me know :)

Fri, Oct 4, 11:36 AM
vladislavbelov updated the diff for D2352: Adds containers serialization tests, std::set serialization and movement semantics.

Removes resize.

Fri, Oct 4, 11:36 AM

Thu, Oct 3

vladislavbelov added inline comments to D2352: Adds containers serialization tests, std::set serialization and movement semantics.
Thu, Oct 3, 9:21 PM
vladislavbelov updated the diff for D2352: Adds containers serialization tests, std::set serialization and movement semantics.

Fixes @elexis`s notes.

Thu, Oct 3, 9:21 PM
vladislavbelov committed rP23036: Adds projection type to CCamera to control usages of projection dependent….
Adds projection type to CCamera to control usages of projection dependent…
Thu, Oct 3, 8:52 PM
vladislavbelov closed D2351: Adds projection type to CCamera to control usages of projection dependent properties.
Thu, Oct 3, 8:51 PM
Stan awarded D2352: Adds containers serialization tests, std::set serialization and movement semantics a Like token.
Thu, Oct 3, 7:17 PM
elexis awarded D2352: Adds containers serialization tests, std::set serialization and movement semantics a Like token.
Thu, Oct 3, 7:12 PM
vladislavbelov updated the diff for D2352: Adds containers serialization tests, std::set serialization and movement semantics.
Thu, Oct 3, 6:41 PM
vladislavbelov created D2352: Adds containers serialization tests, std::set serialization and movement semantics.
Thu, Oct 3, 6:39 PM
vladislavbelov added a comment to D2351: Adds projection type to CCamera to control usages of projection dependent properties.
In D2351#98299, @elexis wrote:

Not particularly a fan of ENSURE, usually it reads like TODO and it has the issue that the user can click on "continue" (thats what the average player does if he triggers one).

Yeah, I can call it TODO, because I want to remove it after new projection type will be added.

Thu, Oct 3, 5:43 PM
vladislavbelov created D2351: Adds projection type to CCamera to control usages of projection dependent properties.
Thu, Oct 3, 4:22 PM
vladislavbelov added a comment to rP23034: Cleanup Camera related code and uses constant references where possible, fixes….

Wrong commit message, the right one is "Fixed assert fails in Actor Editor".

Thu, Oct 3, 3:23 PM
vladislavbelov added a comment to D1784: Fixed assert fails in Actor Editor.

@shh thank you for the patch! Sorry for long reviewing.

Thu, Oct 3, 3:22 PM · Windows Developers
vladislavbelov committed rP23034: Cleanup Camera related code and uses constant references where possible, fixes….
Cleanup Camera related code and uses constant references where possible, fixes…
Thu, Oct 3, 3:21 PM
vladislavbelov closed D1784: Fixed assert fails in Actor Editor.
Thu, Oct 3, 3:21 PM · Windows Developers
vladislavbelov committed rP23033: Cleanup Camera related code and uses constant references where possible..
Cleanup Camera related code and uses constant references where possible.
Thu, Oct 3, 2:59 PM
vladislavbelov closed D2350: Cleanup Camera related code..
Thu, Oct 3, 2:59 PM
vladislavbelov added inline comments to rP23029: Cleanup CCmpRallyPointRenderer.
Thu, Oct 3, 2:37 PM
vladislavbelov added a comment to rP23029: Cleanup CCmpRallyPointRenderer.

My result on macOS (clang-11.0.0) for https://code.wildfiregames.com/P184:

Thu, Oct 3, 2:33 PM
vladislavbelov added inline comments to D2350: Cleanup Camera related code..
Thu, Oct 3, 11:19 AM
vladislavbelov added inline comments to rP23031: Splits Camera control from CGameView to separate file..
Thu, Oct 3, 11:14 AM
vladislavbelov created D2350: Cleanup Camera related code..
Thu, Oct 3, 12:32 AM

Wed, Oct 2

vladislavbelov committed rP23031: Splits Camera control from CGameView to separate file..
Splits Camera control from CGameView to separate file.
Wed, Oct 2, 10:56 PM
vladislavbelov closed D2347: Splits Camera control from CGameView to separate file.
Wed, Oct 2, 10:55 PM
vladislavbelov updated the diff for D2347: Splits Camera control from CGameView to separate file.
Wed, Oct 2, 8:05 PM
vladislavbelov accepted rP10704: Rendering marker lines between buildings and rally points.
Wed, Oct 2, 5:06 PM
vladislavbelov accepted D1784: Fixed assert fails in Actor Editor.

The patch seems ok to me. I'm going to commit that if nobody has objections.

Wed, Oct 2, 4:31 PM · Windows Developers
vladislavbelov accepted D1682: Cleanup RallyPointRenderer.

I tested it on VS2015, it works for me. The movement looks ok, the old code has some issues, but it'd be better to fix them in a separate diff.

Wed, Oct 2, 3:26 PM
vladislavbelov added a comment to rP23028: Sort GUI Object types, GUI Object bases and GUI Setting value types into three….

When you spoke about object_bases I have immediately corrected you that it should be ObjectBases.

I didn't talk about underscores, only about name semantic.

Wed, Oct 2, 2:10 PM
vladislavbelov added a comment to rP23028: Sort GUI Object types, GUI Object bases and GUI Setting value types into three….

I claim this to be a lie unless you cite a rule from the CC that I broke https://trac.wildfiregames.com/wiki/Coding_Conventions
If you refer to the consistency argument, the consistency goes from bottom to top, first there is consistency in this folder, as I quoted above.

I refer to this line: "Then, try to match the style of the other code in the subdirectory you're editing.".

Wed, Oct 2, 12:39 PM
vladislavbelov added a comment to rP23028: Sort GUI Object types, GUI Object bases and GUI Setting value types into three….

Before your change there were 100 folders with lower case name underscore and 2 with upper case. After your change there are 99 folders with lower case name underscore and 6 with upper case

Wed, Oct 2, 12:19 PM
vladislavbelov added a comment to rP23028: Sort GUI Object types, GUI Object bases and GUI Setting value types into three….

If you do a find in source/gui/ you will see that its more consistent if that folder uses the same style as the filenames.

See my comment above.

Wed, Oct 2, 12:13 PM
vladislavbelov added a comment to rP23028: Sort GUI Object types, GUI Object bases and GUI Setting value types into three….

Citation of the CC or you cant claim its in the CC. It actually says:

Well, before the change we didn't have such name in the folders, but we have tests and scripting. So you broke the rules from CC.

Well its not like I didnt mentioned the folder names or the reasoning several times in the discussion we had http://irclogs.wildfiregames.com/2019-10/2019-10-01-QuakeNet-%230ad-dev.log

20:02 < Vladislav> I agree with most, I just can't call it object_base.

It was in context of your patch https://code.wildfiregames.com/P183, and it contains only underscores.

Wed, Oct 2, 12:11 PM
vladislavbelov added a comment to rP23028: Sort GUI Object types, GUI Object bases and GUI Setting value types into three….

I think Scripting has a wrong case, it's out of repo CC. Object* and SettingTypes are not so "out of rules", but I'd prefer underscore to fit into all other folder names.

Wed, Oct 2, 11:49 AM
vladislavbelov added a comment to D2347: Splits Camera control from CGameView to separate file.
In D2347#98146, @elexis wrote:

When moving code around, one should check that one splits into helper functions or classes where benefiital (taking the opportunity to chose the cleaner alternative if already moving those lines).

I agree that the code should be refactored, but at the same time I want to keep the diff as small as possible (only movement).

Wed, Oct 2, 11:24 AM
vladislavbelov retitled D2347: Splits Camera control from CGameView to separate file from Splits Camera control to separate file to Splits Camera control from CGameView to separate file.
Wed, Oct 2, 1:56 AM
vladislavbelov created D2347: Splits Camera control from CGameView to separate file.
Wed, Oct 2, 1:55 AM
vladislavbelov committed rP23026: Moves CSmoothedValue to separate file..
Moves CSmoothedValue to separate file.
Wed, Oct 2, 12:43 AM
vladislavbelov closed D2346: Moves CSmoothedValue to separate file..
Wed, Oct 2, 12:43 AM
vladislavbelov updated the diff for D2346: Moves CSmoothedValue to separate file..
Wed, Oct 2, 12:34 AM
vladislavbelov created D2346: Moves CSmoothedValue to separate file..
Wed, Oct 2, 12:23 AM

Tue, Oct 1

vladislavbelov committed rP23025: Removes unused methods and hides private member..
Removes unused methods and hides private member.
Tue, Oct 1, 11:11 PM
vladislavbelov closed D2342: Removes unused methods and hides private member.
Tue, Oct 1, 11:11 PM
vladislavbelov added a comment to D2342: Removes unused methods and hides private member.
In D2342#98054, @elexis wrote:

No objections. Sounded like they were unused following rP22404, but doesn't seem so. Happen to know which commit introduced that? (perhaps there is even more unused stuff?)

Unused after rP22940. I didn't remove methods there, because I had some thoughts about how I can use them. Introduced in rP10548.

Tue, Oct 1, 6:26 PM
vladislavbelov created D2342: Removes unused methods and hides private member.
Tue, Oct 1, 6:02 PM

Thu, Sep 26

vladislavbelov committed rP23002: Removes duplication of Clamp function..
Removes duplication of Clamp function.
Thu, Sep 26, 11:15 PM
vladislavbelov closed D1763: Removes duplication of Clamp function.
Thu, Sep 26, 11:14 PM
vladislavbelov added a comment to D825: Atlas: Allow map to recenter during resize.

Also the code doesn't support square maps.

Thu, Sep 26, 4:25 PM

Mon, Sep 23

vladislavbelov added inline comments to D2079: Adds snapping to edges for buildings.
Mon, Sep 23, 1:15 PM

Fri, Sep 20

vladislavbelov requested verification of rP22939: Adds a helper function to pick entities with a given component and a given….
Fri, Sep 20, 9:46 PM
vladislavbelov committed rP22950: Fixes compilation errors about missed include and unused argument introduced in….
Fixes compilation errors about missed include and unused argument introduced in…
Fri, Sep 20, 9:45 PM
elexis awarded rP22939: Adds a helper function to pick entities with a given component and a given… a Like token.
Fri, Sep 20, 1:09 PM
vladislavbelov committed rP22940: Fixes values of clip planes in PostProcManager..
Fixes values of clip planes in PostProcManager.
Fri, Sep 20, 9:55 AM
vladislavbelov closed D2196: Fixes values of clip planes in PostProcManager.
Fri, Sep 20, 9:55 AM
vladislavbelov committed rP22939: Adds a helper function to pick entities with a given component and a given….
Adds a helper function to pick entities with a given component and a given…
Fri, Sep 20, 9:46 AM
vladislavbelov closed D2207: Adds a function to pick entities with obstructions on screen.
Fri, Sep 20, 9:46 AM

Thu, Sep 19

vladislavbelov updated the diff for D2207: Adds a function to pick entities with obstructions on screen.
Thu, Sep 19, 9:48 PM
vladislavbelov added inline comments to D1763: Removes duplication of Clamp function.
Thu, Sep 19, 8:53 PM
vladislavbelov added a comment to D2304: Delete GUI.h umbrella include.

The patch looks good to me. Though I didn't test it.

Thu, Sep 19, 9:22 AM

Wed, Sep 18

vladislavbelov updated the diff for D1763: Removes duplication of Clamp function.

Updates after last commits.

Wed, Sep 18, 5:56 PM
vladislavbelov committed rP22927: Removes usages of duplication of Clamp function in simulation and atlas. Refs….
Removes usages of duplication of Clamp function in simulation and atlas. Refs…
Wed, Sep 18, 5:02 PM
vladislavbelov committed rP22926: Removes usages of duplication of Clamp function in gui, ps and renderer. Refs….
Removes usages of duplication of Clamp function in gui, ps and renderer. Refs…
Wed, Sep 18, 4:45 PM

Sep 18 2019

vladislavbelov added a comment to D2207: Adds a function to pick entities with obstructions on screen.
In D2207#96066, @Stan wrote:
Sep 18 2019, 3:06 PM
vladislavbelov added inline comments to D2207: Adds a function to pick entities with obstructions on screen.
Sep 18 2019, 1:32 PM
vladislavbelov added inline comments to D2207: Adds a function to pick entities with obstructions on screen.
Sep 18 2019, 12:30 PM
vladislavbelov committed rP22925: Removes usages of duplication of Clamp function in graphics. Refs D1763..
Removes usages of duplication of Clamp function in graphics. Refs D1763.
Sep 18 2019, 10:34 AM
vladislavbelov updated the diff for D2207: Adds a function to pick entities with obstructions on screen.

Adds template function.

Sep 18 2019, 9:45 AM
vladislavbelov added a comment to D1763: Removes duplication of Clamp function.

I will commit it in separate commits, grouped by folders.

Sep 18 2019, 9:39 AM

Sep 16 2019

vladislavbelov added inline comments to D2293: Allow code to register hooks which get called whenever a function value changes, use this to clean rendering options further..
Sep 16 2019, 9:37 PM
vladislavbelov added inline comments to D2293: Allow code to register hooks which get called whenever a function value changes, use this to clean rendering options further..
Sep 16 2019, 8:57 PM
vladislavbelov added inline comments to D2293: Allow code to register hooks which get called whenever a function value changes, use this to clean rendering options further..
Sep 16 2019, 8:06 PM
vladislavbelov added inline comments to D2293: Allow code to register hooks which get called whenever a function value changes, use this to clean rendering options further..
Sep 16 2019, 7:53 PM

Sep 3 2019

vladislavbelov added a comment to rP22037: Add an error message for crashes without required UV sets..
In rP22037#37300, @Stan wrote:

Ah then the ticket is not fixed...

No, it's fixed. As I created the ticket only for logs.

Sep 3 2019, 10:02 AM
vladislavbelov added a comment to rP22037: Add an error message for crashes without required UV sets..
In rP22037#37291, @Stan wrote:
Sep 3 2019, 3:23 AM