Simulation Play, Pause and Stop actions was added.

this patch get AI Data, Civilization Data, Save Map and retrieve InitAttributes

GetAIData
GetCivData
SaveMap

In D4923#210278, @Freagarach wrote:

So we're hardcoding that we cannot give control to livestock to a player?

In D4923#210278, @Freagarach wrote:

So we're hardcoding that we cannot give control to livestock to a player?

my proposal => https://code.wildfiregames.com/D4923

Actually I would like to understand from ICmpIdentity the attribute "Controllable" can we reuse that?

Speaking about editor I would like to suggest one way to allow any modder to introduce any "GAIA" only template. I would like to suggest to expand ICmpIdentity to have something like "IsGaia" usable from C++ code (but also usable from wxWidget).

Hi nwtour, Im going to review this patch but also the support for dark mode and "remove/change" hardcoded colors with wxSystemSettings::GetColour, are you able to continue with this?

In D4915#209896, @vladislavbelov wrote:

Does the bandbox select correct elements? Does the world selection bounds match the bandbox?

In D4915#209896, @vladislavbelov wrote:

Does the bandbox select correct elements? Does the world selection bounds match the bandbox?

Fix previous diff

ClearCommands was added

In D4900#209242, @Langbart wrote:

it solves the problem described in the ticket. Thanks, but I do not know if it is the "right" solution, hence the change of reviewer.

In D4900#209225, @Stan wrote:

Do we also do this when loading a new map?

Rebased for A27

More elegant and clean code

This patch use a more elegant way to randomized tips, and dont introduce another variables

In rP27384#59639, @Silier wrote:

For future:

Patch by: @Grapjas
Differential revision: D4857
Reviewed by: @phosit @trompetin17

Now you need to link differential revision manually and manually close it

Sure, I was asking that on IRC because I made the mistake but looks like i cant close the ticket :(

Some picture

I made this patch with the idea:

In D1525#69475, @mmoanis wrote:

@Stan @Dunedan I will work on it, Currently I am about to start my exams so I will be delayed for a bit of time.

In D4859#207440, @Stan wrote:

Question, do we need a i32 for something that has two values? Maybe three is 0 is no sort.

In D4385#207227, @Grapjas wrote:

So far this has been a huge waste of time (like all other patches), would something like this ever get committed even if the code would be perfect?

Fix a problem with GetMapSettings

fixed Missing file from last patch

trying to fix link errors/warnings

thx for sharing me your thoughts. Im going to propose this new patch that allow us:

use "/" instead of "\" for #include
UNUSED was added

In rP27277#59332, @vladislavbelov wrote:

The commit makes impossible to change colors and algorithm to pick a more distant one separately.

In D4813#206265, @vladislavbelov wrote:

In D4813#206258, @Stan wrote:

After a lengthy discussion I'm convinced this is better than the json solution.

Pros for json

• more familiar
• easier to find

Pros for js

• easier to extend using other js files (add remove update)
• better mod support you can have multiple mods changing it
• @trompetin17 said he'd write wiki documentation for it
• simpler code
• no dependency for gamesettings.

I don’t see profits of the current solution over JSON. Storing data inside code is a bad practice and makes nodding worse, because you can’t change data and code separately.

Based on internal chat with Stan we convey that our game can run multiple mods and the same time. So with Prototype and JS we allow to be more moddable for multiple mods

Based on your request Stan.

Hi!, do you agree guys to have this patch apply in svn? this is going to be the first step ahead, later we can expand this even more.

Cleaning the code

With this patch we are enabled to extend the PlayerColor control in game setup but also enabled from mod to extend for more color. this patch doesnt affect anything else and remove dependencies from other components

Hi Iyv, first at all thx for help to improve different stuff in atlas.

Is there any objection?, Im going to push this ticket if we dont have any other objection.

Added missing endling line

Use "const" instead of "var"

Well in my case MSBuild.exe doesnt exists in PATH, thats why I use this script, but you can use "last" instead of "first" or something different because we need to use toolset that allow to build xp suport build.

Stan I was testing the script and I would suggest this:

this implementaiton allow to have a json file with colors,
also I used g_Settings to have this information in consistency way

Use a different Implementation.

this patch allow to have more color in match setup but also fix a bug find by Vladislav in Atlas

New Diff with context in the patch

Fixing problem (different line endings).

In this patch I'm trying to fix the next use cases:

In D2042#124775, @Angen wrote:

First, this is great feature to have. But it needs a bit of work.

1.) It should be possible to set none variant in a group as in some cases they compete with variants of other groups and one will never see the variants from another groups.
2.) Variant menu needs to be visible in actor viewer too as mostly that is the place where people try animations and stuff.