Page MenuHomeWildfire Games
Feed Advanced Search

Sun, Feb 9

Gallaecio accepted D2620: use non-breaking space in 0 A.D..
Sun, Feb 9, 3:09 PM
Gallaecio updated subscribers of D2620: use non-breaking space in 0 A.D..

@elexis Can we disable the “nonbsp” check in Vulcan? I don’t think it applies to us. I think the only non-UTF-8 part we have was the editor or some parts of it, and this check seems to be for JavaScript files.

Sun, Feb 9, 3:07 PM
Gallaecio accepted D2610: standardize bonus attack tooltips.
Sun, Feb 9, 3:03 PM

Mon, Jan 27

Gallaecio added inline comments to D2578: update structure template tooltips.
Mon, Jan 27, 9:36 AM

Sun, Jan 26

Gallaecio added inline comments to D2578: update structure template tooltips.
Sun, Jan 26, 11:27 AM

Jan 22 2020

Gallaecio accepted D2591: Javelinist → Javelineer.
Jan 22 2020, 12:13 PM

Jan 19 2020

Gallaecio accepted D2578: update structure template tooltips.
Jan 19 2020, 8:39 PM
Gallaecio accepted D2579: standardize armor technology tooltips.
Jan 19 2020, 9:46 AM
Gallaecio added a comment to D2578: update structure template tooltips.

I’ve left one more comment, but overall this is an amazing change for the better, great work!

Jan 19 2020, 9:44 AM

Jan 18 2020

Gallaecio added inline comments to D2578: update structure template tooltips.
Jan 18 2020, 11:50 AM

Jan 15 2020

Gallaecio accepted D2570: gui/manual/intro.txt use toggle.
Jan 15 2020, 8:45 PM
Gallaecio committed rP23397: gui/manual/intro.txt interpunction.
gui/manual/intro.txt interpunction
Jan 15 2020, 10:42 AM
Gallaecio closed D2560: gui/manual/intro.txt interpunction.
Jan 15 2020, 10:42 AM

Jan 11 2020

Gallaecio accepted D2560: gui/manual/intro.txt interpunction.
Jan 11 2020, 8:20 PM
Gallaecio requested changes to D2560: gui/manual/intro.txt interpunction.
Jan 11 2020, 1:14 PM
Gallaecio committed rP23368: reduce excessive capitalization in game options.
reduce excessive capitalization in game options
Jan 11 2020, 1:08 PM
Gallaecio closed D2437: reduce excessive capitalization in game options.
Jan 11 2020, 1:08 PM
Gallaecio added a comment to rP23366: [gui] building → structure.
In rP23366#40710, @Stan wrote:

Patch by: @Nescio

Jan 11 2020, 1:03 PM
Gallaecio committed rP23367: main menu item tooltip corrections..
main menu item tooltip corrections.
Jan 11 2020, 1:00 PM
Gallaecio closed D2428: main menu item tooltip corrections..
Jan 11 2020, 1:00 PM
Gallaecio committed rP23366: [gui] building → structure.
[gui] building → structure
Jan 11 2020, 11:59 AM
Gallaecio closed D2429: [gui] building → structure.
Jan 11 2020, 11:58 AM

Nov 24 2019

Gallaecio accepted D2437: reduce excessive capitalization in game options.
Nov 24 2019, 11:02 AM

Nov 23 2019

Gallaecio committed rP23177: remove "Goods" from trade window stings.
remove "Goods" from trade window stings
Nov 23 2019, 9:26 AM
Gallaecio closed D2306: remove "Goods" from trade window stings.
Nov 23 2019, 9:26 AM
Gallaecio updated the diff for D2306: remove "Goods" from trade window stings.

Rebase changes.

Nov 23 2019, 9:24 AM
Gallaecio committed rP23176: Single Player → single-player.
Single Player → single-player
Nov 23 2019, 9:10 AM
Gallaecio closed D2312: Single Player → single-player.
Nov 23 2019, 9:10 AM
Gallaecio added a comment to D2226: Use standarized phrasing and terminology for the Patriot aura description.

Shall I merge the changes as is, then?

Nov 23 2019, 9:00 AM
Gallaecio accepted D2428: main menu item tooltip corrections..
Nov 23 2019, 8:58 AM
Gallaecio accepted D2429: [gui] building → structure.
Nov 23 2019, 8:57 AM

Nov 16 2019

Gallaecio added a comment to D1613: Improve the plural translation of the "<players> have won" string.

You are right, it looks like i18n-aware list-building is more complex than I though. On the bright side, it looks like ICU 50 provides a function for this, so we should be able to solve the issue without exposing any list-building string to our translators. I’ll try to work on this next weekend, and improve Player.prototype.SubtractResourcesOrNotify as well as part of these changes.

Nov 16 2019, 2:12 PM
Gallaecio accepted D2312: Single Player → single-player.

Yeah, you are right. It’s just that I’m not used to seing “Single-player” on its own in a button, but it’s correct, the noun (game mode) is just omitted. I’ve left a couple of suggestions, but I’m OK with merging as is. I’ll probably merge it next weekend.

Nov 16 2019, 2:07 PM
Gallaecio added a comment to D2226: Use standarized phrasing and terminology for the Patriot aura description.

In favour of specifying the type of attack:

  • In the tooltip, capture is mentioned explicitly as Capture Attack. So not specifying the types may confuse people into thinking that capture is affected.
  • Auras specifies the type of attack which is modified (see D1808/rP22905).
Nov 16 2019, 1:34 PM
Gallaecio added a comment to D2305: more gui/manual/intro.txt improvements.

it's not obvious to me which changes are straightforward and which are potentially controversial.

Nov 16 2019, 1:31 PM
Gallaecio added a comment to D2312: Single Player → single-player.
Nov 16 2019, 1:26 PM

Nov 2 2019

Gallaecio added a comment to D2226: Use standarized phrasing and terminology for the Patriot aura description.

I agree with @Polakrity here, I think “attack” should not be used to refer to capture in user-visible strings, and assuming melee and ranged attacks are the only possible attack types of potentially affected units, removing the attack type mention makes sense. I’m not sure is that assumption is correct, though. Can someone confirm that?

Nov 2 2019, 3:59 PM
Gallaecio updated the diff for D1613: Improve the plural translation of the "<players> have won" string.

Use a more flexible approach which also make the code more readable

Nov 2 2019, 8:01 AM
Gallaecio added reviewers for D2226: Use standarized phrasing and terminology for the Patriot aura description: Freagarach, Polakrity, fatherbushido.
Nov 2 2019, 7:33 AM
Gallaecio updated the diff for D2226: Use standarized phrasing and terminology for the Patriot aura description.

Rename ‘attack speed’ to ‘attack rate’ based on community feedback

Nov 2 2019, 7:30 AM
Gallaecio added a comment to D2305: more gui/manual/intro.txt improvements.

I’m worried that discussing so many different changes may take some time. @Nescio what would you think about creating separate patches instead? Some of the changes should be pretty straightforward to apply that way.

Nov 2 2019, 7:26 AM
Gallaecio added a comment to D1674: Check translations for sprintf errors.

Where can I find the run time logs of https://trac.wildfiregames.com/browser/ps/trunk/build/jenkins/lint-translations.sh?

Nov 2 2019, 7:20 AM

Oct 20 2019

Gallaecio added a comment to D1674: Check translations for sprintf errors.

Should we get this script merged, to make it easier to use it next time?

Oct 20 2019, 1:50 PM
Gallaecio added a comment to D2226: Use standarized phrasing and terminology for the Patriot aura description.

I’ve just posted https://wildfiregames.com/forum/index.php?/topic/27150-wording-attack-repeat-time-vs-attack-time-vs-time-between-attacks-vs-attack-speed/ to discuss this, and CC’d people both from here and from https://trac.wildfiregames.com/ticket/3600

Oct 20 2019, 1:41 PM
Gallaecio committed rP23083: Rephrase the tooltip of Reload Cache to avoid confusion.
Rephrase the tooltip of Reload Cache to avoid confusion
Oct 20 2019, 1:21 PM
Gallaecio closed D2294: Rephrase the tooltip of Reload Cache to avoid confusion.
Oct 20 2019, 1:21 PM
Gallaecio retitled D2294: Rephrase the tooltip of Reload Cache to avoid confusion from [WIP] Rephrase the tooltip of Reload Cache to avoid confusion to Rephrase the tooltip of Reload Cache to avoid confusion.
Oct 20 2019, 1:20 PM
Gallaecio updated the diff for D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

Restore the previous tooltip wording

Oct 20 2019, 1:19 PM
Gallaecio updated the diff for D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

Reload → Rebuild

Oct 20 2019, 1:18 PM
Gallaecio added inline comments to D2306: remove "Goods" from trade window stings.
Oct 20 2019, 1:11 PM
Gallaecio accepted D2306: remove "Goods" from trade window stings.

I’m not against the use of ‘goods’ in the context of trade, where it’s the right word to refer to “tradeable resources”, but since in 0 A.D. all resources are tradeable, I’m OK with the change.

Oct 20 2019, 1:09 PM
Gallaecio added a comment to D2312: Single Player → single-player.

Single-player is proper English, single player and singleplayer are less correct.

Oct 20 2019, 1:04 PM
Gallaecio committed rP23082: list heroes after champions and correct some structure tooltips.
list heroes after champions and correct some structure tooltips
Oct 20 2019, 12:57 PM
Gallaecio closed D2324: list heroes after champions and correct some structure tooltips.
Oct 20 2019, 12:57 PM
Gallaecio accepted D2324: list heroes after champions and correct some structure tooltips.
Oct 20 2019, 12:56 PM

Sep 18 2019

Gallaecio committed rP22928: Update translations after fixing sprintf issues.
Update translations after fixing sprintf issues
Sep 18 2019, 7:12 PM
Gallaecio accepted D1674: Check translations for sprintf errors.
Sep 18 2019, 6:55 PM

Sep 17 2019

Gallaecio retitled D2294: Rephrase the tooltip of Reload Cache to avoid confusion from Rephrase the tooltip of Reload Cache to avoid confusion to [WIP] Rephrase the tooltip of Reload Cache to avoid confusion.
Sep 17 2019, 10:02 AM
Gallaecio added a comment to D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

I’m just looking for using the same wording. If “Rebuild” works on both strings, I’ll switch both to “Rebuild”.

Sep 17 2019, 10:02 AM

Sep 15 2019

Gallaecio created D2294: Rephrase the tooltip of Reload Cache to avoid confusion.
Sep 15 2019, 2:16 PM
Gallaecio retitled D2226: Use standarized phrasing and terminology for the Patriot aura description from [WIP] Use standarized phrasing and terminology for the Patriot aura description to Use standarized phrasing and terminology for the Patriot aura description.
Sep 15 2019, 1:57 PM
Gallaecio updated the diff for D2226: Use standarized phrasing and terminology for the Patriot aura description.

Rebased

Sep 15 2019, 1:57 PM
Gallaecio committed rP22907: -ise → -ize.
-ise → -ize
Sep 15 2019, 1:53 PM
Gallaecio closed D2246: -ise → -ize.
Sep 15 2019, 1:53 PM
Gallaecio committed rP22906: standardize gather technology tooltips.
standardize gather technology tooltips
Sep 15 2019, 1:52 PM
Gallaecio closed D2253: standardize gather technology tooltips.
Sep 15 2019, 1:52 PM
Gallaecio committed rP22905: standardized hero aura descriptions.
standardized hero aura descriptions
Sep 15 2019, 1:49 PM
Gallaecio closed D1808: standardized hero aura descriptions.
Sep 15 2019, 1:49 PM
Gallaecio accepted D1808: standardized hero aura descriptions.
Sep 15 2019, 1:48 PM
Gallaecio committed rP22904: manual/intro.txt corrections.
manual/intro.txt corrections
Sep 15 2019, 1:45 PM
Gallaecio closed D2110: manual/intro.txt corrections.
Sep 15 2019, 1:45 PM
Gallaecio accepted D2246: -ise → -ize.
Sep 15 2019, 1:35 PM
Gallaecio accepted D2253: standardize gather technology tooltips.
Sep 15 2019, 1:34 PM

Sep 1 2019

Gallaecio added a comment to D2248: restore legionary scutum.

I’ve just restored the file with its previous content in https://code.wildfiregames.com/rP22830

Sep 1 2019, 9:29 PM
Gallaecio committed rP22830: legionnaire → legionary (4).
legionnaire → legionary (4)
Sep 1 2019, 9:24 PM
Gallaecio added a comment to rP22818: legionnaire → legionary.

art/actors/props/shields/rome_scutum_legionnaire.xml should have been moved to rome_scutum_legionary.xml but wasn't.

Sep 1 2019, 2:00 PM
Gallaecio committed rP22823: legionnaire → legionary (3).
legionnaire → legionary (3)
Sep 1 2019, 2:00 PM
Gallaecio added a comment to D1808: standardized hero aura descriptions.

@Freagarach May I merge?

Sep 1 2019, 12:58 PM
Gallaecio committed rP22821: standardize resource tooltips.
standardize resource tooltips
Sep 1 2019, 12:58 PM
Gallaecio closed D2006: standardize resource tooltips.
Sep 1 2019, 12:58 PM
Gallaecio added a comment to D2110: manual/intro.txt corrections.

@elexis May I merge?

Sep 1 2019, 12:57 PM
Gallaecio committed rP22820: standardize civ bonus technology tooltips.
standardize civ bonus technology tooltips
Sep 1 2019, 12:57 PM
Gallaecio closed D2187: standardize civ bonus technology tooltips.
Sep 1 2019, 12:56 PM
Gallaecio added a comment to D1780: legionnaire → legionary.

Note: Patching was a bit messy due to the renaming and spaces in files. I ended up having to push a second commit that deleted the renamed files.

Sep 1 2019, 12:54 PM
Gallaecio committed rP22819: legionnaire → legionary (2).
legionnaire → legionary (2)
Sep 1 2019, 12:54 PM
Gallaecio committed rP22818: legionnaire → legionary.
legionnaire → legionary
Sep 1 2019, 12:53 PM
Gallaecio closed D1780: legionnaire → legionary.
Sep 1 2019, 12:53 PM
Gallaecio accepted D2006: standardize resource tooltips.
Sep 1 2019, 12:28 PM

Aug 25 2019

Gallaecio retitled D2226: Use standarized phrasing and terminology for the Patriot aura description from Use standarized phrasing and terminology for the Patriot aura description to [WIP] Use standarized phrasing and terminology for the Patriot aura description.
Aug 25 2019, 12:59 PM
Gallaecio added a comment to D2226: Use standarized phrasing and terminology for the Patriot aura description.
In D2226#92500, @Nescio wrote:

However, I strongly believe D1808 should be committed first; afterwards this one could change time to speed, if deemed necessary.

Aug 25 2019, 12:58 PM
Gallaecio added a comment to D2226: Use standarized phrasing and terminology for the Patriot aura description.

I assume the example I added to the English style guide, that 0.5 attack repeat time would mean (1/0.5=2) +100% attack speed, will make it more obvious that the math works: half the time = twice the speed.

Aug 25 2019, 12:44 PM
Gallaecio updated the summary of D2226: Use standarized phrasing and terminology for the Patriot aura description.
Aug 25 2019, 12:21 PM
Gallaecio created D2226: Use standarized phrasing and terminology for the Patriot aura description.
Aug 25 2019, 12:17 PM
Gallaecio committed rP22784: standardized structure aura descriptions.
standardized structure aura descriptions
Aug 25 2019, 11:21 AM
Gallaecio closed D1806: standardized structure aura descriptions.
Aug 25 2019, 11:21 AM
Gallaecio committed rP22783: correct descriptions and tooltips of siege technologies.
correct descriptions and tooltips of siege technologies
Aug 25 2019, 11:19 AM
Gallaecio closed D2186: correct descriptions and tooltips of siege technologies.
Aug 25 2019, 11:19 AM
Gallaecio committed rP22782: update fortress tooltips.
update fortress tooltips
Aug 25 2019, 11:18 AM
Gallaecio closed D2189: update fortress tooltips.
Aug 25 2019, 11:18 AM
Gallaecio committed rP22781: update workshop tooltip.
update workshop tooltip
Aug 25 2019, 11:17 AM