Page MenuHomeWildfire Games
Feed Advanced Search

Sep 19 2019

Silier accepted D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

Builds, tests passed, jenkins tests are ok, feature looks good, I do not see more problems in code

Sep 19 2019, 5:06 PM
Silier added a comment to D2304: Delete GUI.h umbrella include.

builds in debug and without pch release

Sep 19 2019, 2:56 PM
Silier added a comment to D825: Atlas: Allow map to recenter during resize.

From Debug build

Sep 19 2019, 1:57 PM
Silier added a comment to D2304: Delete GUI.h umbrella include.

I see two cases when to add header to precompiled.

  1. It is included in a lot of files ( what means more than 15 with small files)
  2. It is big file in terms of code and other includes and is used more than 5 times.
Sep 19 2019, 11:45 AM

Sep 18 2019

Silier added inline comments to D1674: Check translations for sprintf errors.
Sep 18 2019, 7:07 PM
Silier updated the diff for D2276: Add build order to unit commands to play different sounds for build and repair.
Sep 18 2019, 5:06 PM
Silier accepted D2111: [PetraAI] - Do not try to attack entities which can't be attacked..

looks good to me

Sep 18 2019, 11:42 AM
Silier added inline comments to D1946: Windows Differential testing.
Sep 18 2019, 7:28 AM

Sep 17 2019

Silier planned changes to D1946: Windows Differential testing.

try to fail after timeout

Sep 17 2019, 10:33 PM
Silier updated the diff for D1946: Windows Differential testing.

add timeout
fix robocopy

Sep 17 2019, 10:32 PM
Silier updated the diff for D2021: Fix AtlasUI.dll windows autobuild.

fix robocopy

Sep 17 2019, 10:26 PM
Silier accepted rP22909: Fix hotkey events synching with hotkey state..
Sep 17 2019, 9:59 PM
Silier updated the diff for D1946: Windows Differential testing.

robocopy

Sep 17 2019, 9:06 PM
Silier added inline comments to D2281: Status Effects v2 - More cleanup, allow modifiers..
Sep 17 2019, 9:41 AM
Silier updated the Trac tickets for D2276: Add build order to unit commands to play different sounds for build and repair.
Sep 17 2019, 7:12 AM
Silier updated the summary of D2299: Fix test.exe build failing with --jenkins-tests flag.
Sep 17 2019, 6:33 AM

Sep 16 2019

Silier created D2299: Fix test.exe build failing with --jenkins-tests flag.
Sep 16 2019, 9:25 PM
Silier raised a concern with rP22909: Fix hotkey events synching with hotkey state..

broke test.exe build with --jenkins-tests and so jenkins

Sep 16 2019, 9:01 PM
Silier requested changes to D2111: [PetraAI] - Do not try to attack entities which can't be attacked..
Sep 16 2019, 12:04 PM
Silier updated the diff for D2286: Notify renamed entities about value modifications when created.
Sep 16 2019, 10:00 AM

Sep 15 2019

Silier added a comment to D1946: Windows Differential testing.

no, but might be interesting improvement

Sep 15 2019, 6:53 PM
Silier requested changes to D2111: [PetraAI] - Do not try to attack entities which can't be attacked..
Sep 15 2019, 2:43 PM
Silier updated the diff for D2286: Notify renamed entities about value modifications when created.
Sep 15 2019, 1:44 PM
Silier changed the visibility for D1946: Windows Differential testing.
Sep 15 2019, 1:34 PM
Silier updated the diff for D1946: Windows Differential testing.

add flags for gloox and collada
split testing so release tests follow right after build of release version so in case they do not pass, there will be no build of debug version

Sep 15 2019, 1:32 PM
Silier added a comment to D1988: Workaround differences between libc and libstd string stream parsing of float/doubles.

Tests passed

file: source\ps\CStr.cpp
line 195 : [C-style cast]: 		return (long)Pos;
line 206 : [C-style cast]: 		return (long)Pos;
line 217 : [C-style cast]: 		return (long)Pos;
line 232 : [C-style cast]: 		return (long)Pos;
line 242 : [a++ -> ++a]: 	for (size_t i = 0; i < length(); i++)
line 243 : [C-style cast]: 		NewString[i] = (tchar)_totlower((*this)[i]);
line 251 : [a++ -> ++a]: 	for (size_t i = 0; i < length(); i++)
line 252 : [C-style cast]: 		NewString[i] = (tchar)_totupper((*this)[i]);
line 349 : [a++ -> ++a]: 	for (size_t i = 0; i < length(); i++)
line 365 : [C-style cast]: 			ss << "\\u" << std::hex << std::setfill('0') << std::setw(4) << (int)(unsigned char)ch;
line 381 : [a++ -> ++a]: 			for (Left = 0; Left < length(); Left++)
line 396 : [a++ -> ++a]: 			for (Left = 0; Left < length(); Left++)
line 447 : [C-style cast]: 	return (size_t)fnv_hash(data(), length()*sizeof(value_type));
line 448 : Comments should start with capital: 		// janwas 2005-03-18: now use 32-bit version; 64 is slower and
line 461 : [a++ -> ++a]: 	for (i = 0; i < len; i++)
line 483 : [C-style cast]: 		*(str++) = (tchar)native;
line 503 : [C-style cast]: 	Serialize_int_4(buffer, (u32)len);
line 505 : [a++ -> ++a]: 	for (i = 0; i < len; i++)
file: source\ps\tests\test_CStr.h
line 82 : a+ -> a +: 		u8* buf = new u8[len+1];
line 158 : [WARNING]: File is missing include guard
Sep 15 2019, 1:10 PM

Sep 14 2019

Silier added inline comments to D2290: Unify load game and savegame screen.
Sep 14 2019, 6:16 PM

Sep 13 2019

Silier updated the summary of D2286: Notify renamed entities about value modifications when created.
Sep 13 2019, 5:55 PM
Silier added inline comments to rP22767: Add a system component to handle stat modifiers, make technologies and auras….
Sep 13 2019, 5:55 PM
Silier updated subscribers of D2287: Support glooxwrapper::MUCRoom for muc events.
In D2287#95144, @Vulcan wrote:

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/154/display/redirect

Sep 13 2019, 5:32 PM
Silier updated the diff for D2286: Notify renamed entities about value modifications when created.

less code

Sep 13 2019, 5:26 PM
Silier updated the diff for D2286: Notify renamed entities about value modifications when created.

address comment by wraitii so this fixes also scenario where unit changes ownership and technologies change Health values based on player

Sep 13 2019, 2:27 PM
Silier added a comment to D2175: Select formations as a whole by default..

Do we want only one type of units in a battalion?

yes, that is one of the basic idea of batalions, but there would be allowed special units like banner carrier, hero, commander.

Sep 13 2019, 2:20 PM
Silier updated the test plan for D2286: Notify renamed entities about value modifications when created.
Sep 13 2019, 2:09 PM
Silier created D2286: Notify renamed entities about value modifications when created.
Sep 13 2019, 2:03 PM

Sep 12 2019

Silier accepted rP21113: Allow random map scripts to load heightmap image files, fixes #5018..

fixed in rP22892

Sep 12 2019, 9:48 PM
Silier updated the diff for D1816: Use all three color channels when loading heightmaps following rP21113.

static cast to ensure u16 result

Sep 12 2019, 9:19 PM
Silier added inline comments to D2285: Inform player that second market is too close to setup trade route and use disabled action.
Sep 12 2019, 7:50 AM

Sep 11 2019

Silier created D2285: Inform player that second market is too close to setup trade route and use disabled action.
Sep 11 2019, 9:18 PM
Silier added inline comments to D2284: Actually dont compile lobby code if building --without-lobby.
Sep 11 2019, 7:58 PM

Sep 10 2019

Silier added inline comments to D2281: Status Effects v2 - More cleanup, allow modifiers..
Sep 10 2019, 7:32 PM
Silier added inline comments to D2281: Status Effects v2 - More cleanup, allow modifiers..
Sep 10 2019, 7:28 PM
Silier added inline comments to D2188: Allow Promotion to add arbitrary modifiers when a unit reaches the next rank instead of changing entities..
Sep 10 2019, 7:06 PM

Sep 9 2019

Stan awarded D2276: Add build order to unit commands to play different sounds for build and repair a 100 token.
Sep 9 2019, 7:50 PM
Silier updated the diff for D2276: Add build order to unit commands to play different sounds for build and repair.

add entry to template, fix repair command back

Sep 9 2019, 7:48 PM
Silier created D2276: Add build order to unit commands to play different sounds for build and repair.
Sep 9 2019, 7:35 PM
Silier added inline comments to D2111: [PetraAI] - Do not try to attack entities which can't be attacked..
Sep 9 2019, 6:16 PM
Silier added inline comments to D2175: Select formations as a whole by default..
Sep 9 2019, 6:03 PM
Silier added inline comments to D2175: Select formations as a whole by default..
Sep 9 2019, 3:53 PM
Silier added a comment to D1496: Combat Variant.

yes possibly but first it would be better just have this one as it is a lot faster than computing squares and this just changes unitai code in minimal scale

Sep 9 2019, 3:11 PM

Sep 8 2019

Silier added a comment to D2218: Status Effects v1 - GUI support and fix following rP22754.

yes icons should have own folder

Sep 8 2019, 9:19 AM
Silier awarded D2218: Status Effects v1 - GUI support and fix following rP22754 a Love token.
Sep 8 2019, 9:08 AM

Sep 6 2019

Silier added a comment to P169 Repairable class.

@Stan
units have different sound for order_repair and order_build at least in templates
issue is that i unit_actions.js is only command repair and so always is used and played order_repair even if target is just foundation and not damaged building

Sep 6 2019, 7:13 PM

Sep 3 2019

Silier added inline comments to D2251: [ai/petra] replace Cavalry with new FastMoving class.
Sep 3 2019, 9:46 AM

Aug 27 2019

Silier awarded rP22773: Fix L10n::FormatMillisecondsIntoDateString memory leak following rP18725, refs… a Like token.
Aug 27 2019, 10:04 AM

Aug 17 2019

Silier awarded rP22682: Use shared_ptr to avoid copying and deleting SGUIImageEffects, 2.5x faster in a… a Love token.
Aug 17 2019, 3:59 PM

Aug 16 2019

Silier added a comment to D1921: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.

builds without-pch

Aug 16 2019, 12:03 PM

Aug 15 2019

Silier added inline comments to D1721: Wind speed computation speed-up.
Aug 15 2019, 10:58 AM
Silier added inline comments to D2176: Give an option to allow multiple controls groups share same entities..
Aug 15 2019, 8:57 AM

Aug 9 2019

Silier updated subscribers of rP22608: Pthread -> std::thread (2/7) - Remove pthread in Profilers.
Aug 9 2019, 11:04 PM

Jul 28 2019

Silier added a comment to rP22425: UnitMotion - Explicit handling of movement errors (such as target death) in….

Fixed in rP22567

Jul 28 2019, 2:08 PM
Silier accepted rP22425: UnitMotion - Explicit handling of movement errors (such as target death) in….
Jul 28 2019, 2:08 PM
Silier added a comment to rP22314: Fix a crash on some system when Alt-tabbing during game setup..

@Stan can you please check if it works for you?

Jul 28 2019, 9:44 AM

Jul 27 2019

Silier added a comment to D2115: Improve support of classes of bonuses..

just for record there is already similar logic:
Hero Elephant = Hero or Elephant
Hero+Elephant = Hero and Elephant
!Hero = no Hero

Jul 27 2019, 6:50 PM

Jul 26 2019

Silier added inline comments to D2115: Improve support of classes of bonuses..
Jul 26 2019, 9:23 AM
Silier added inline comments to D2125: VS2013 Grid.h memset fallback.
Jul 26 2019, 7:15 AM
Silier added a comment to rP22511: Fix the -Wclass-memaccess compiler warning in the pathfinders Grid.h, refs….
In rP22511#35454, @Angen wrote:

This introduced Access violation reading from ticket: https://trac.wildfiregames.com/ticket/5539 not fixed by later patch.

Sure it was this commit? As I understand it's the placement new in rP22545 that is not supported by VS2013?

Jul 26 2019, 7:05 AM

Jul 25 2019

Silier added a comment to rP22511: Fix the -Wclass-memaccess compiler warning in the pathfinders Grid.h, refs….

Reason for this issue with VS2013 is that memset was removed and looks like vs13 does not do default initialisation of that values.
If vs13 is only compiler having that problem, then we should cut off vs13 build already with D1396 since this is making vs13 builds not functional at all.

Jul 25 2019, 4:02 PM
Silier added a comment to rP22511: Fix the -Wclass-memaccess compiler warning in the pathfinders Grid.h, refs….

Grid.h(234): Assertion failed: "0 <= i && i < m_W && 0 <= j && j < m_H"

Jul 25 2019, 3:16 PM
Silier raised a concern with rP22511: Fix the -Wclass-memaccess compiler warning in the pathfinders Grid.h, refs….

This introduced Access violation reading from ticket: https://trac.wildfiregames.com/ticket/5539 not fixed by later patch.

Jul 25 2019, 3:08 PM

Jul 24 2019

Silier added inline comments to D1961: Let animals be able to garrison..
Jul 24 2019, 7:34 PM
Silier added a comment to rP22314: Fix a crash on some system when Alt-tabbing during game setup..

Fixed in rP22544

Jul 24 2019, 6:43 PM
Silier accepted rP22314: Fix a crash on some system when Alt-tabbing during game setup..
Jul 24 2019, 6:42 PM
Silier added inline comments to D2029: Alt+tab fix for rP22314 - call IdleTask in Atlas and swap buffers only once.
Jul 24 2019, 6:35 PM
Silier accepted D2029: Alt+tab fix for rP22314 - call IdleTask in Atlas and swap buffers only once.

Build on windows is green, no crashes related to glsl or postprocessing, sound plays in atlas as should.

Jul 24 2019, 6:30 PM
Silier added inline comments to D2029: Alt+tab fix for rP22314 - call IdleTask in Atlas and swap buffers only once.
Jul 24 2019, 6:05 PM
Silier requested changes to D2029: Alt+tab fix for rP22314 - call IdleTask in Atlas and swap buffers only once.
Jul 24 2019, 6:05 PM
Silier added a comment to D2121: Fix memory leak introduced by rP22511 in SparseGrid.

My RAM usage for replay from https://trac.wildfiregames.com/ticket/5530

Jul 24 2019, 1:44 PM
Silier added inline comments to D2121: Fix memory leak introduced by rP22511 in SparseGrid.
Jul 24 2019, 1:07 PM
Silier awarded D2121: Fix memory leak introduced by rP22511 in SparseGrid a Like token.
Jul 24 2019, 12:54 PM
Silier added inline comments to rP22425: UnitMotion - Explicit handling of movement errors (such as target death) in….
Jul 24 2019, 10:54 AM
Silier added inline comments to rP22429: Ensure units do get in attacking range since that range can change over time….
Jul 24 2019, 10:45 AM
Silier added inline comments to rP22429: Ensure units do get in attacking range since that range can change over time….
Jul 24 2019, 10:42 AM
Silier awarded rP22542: New Roman Units Texture a Like token.
Jul 24 2019, 9:10 AM
Silier created D2117: Do not enable rated game if game is singleplayer or has not exactly 2 players.
Jul 24 2019, 8:43 AM

Jul 23 2019

Silier planned changes to D2114: Do not fail if some mod is broken [Mod Io].
Jul 23 2019, 8:32 PM
Silier updated the diff for D2114: Do not fail if some mod is broken [Mod Io].
Jul 23 2019, 8:28 PM
Silier planned changes to D2114: Do not fail if some mod is broken [Mod Io].

I think we should never fail in case some mod has wrong data anyway, unless it is fail of whole mod io.
After that, I try to come with some not downlandable mod line for mods with wrong data.

Jul 23 2019, 6:33 PM
Silier added a comment to D2056: Resupport more garrisoned slots per entity..

Also do not forget \public\gui\reference\viewer\viewer.js for right click window (encyclopedia or whatever is it name)

Jul 23 2019, 6:22 PM
Silier added a comment to D2114: Do not fail if some mod is broken [Mod Io].
In D2114#88408, @elexis wrote:

Would it be cleaner to only push valid elements rather than adding all elements and removing the invalid?

I think it would.

In D2114#88408, @elexis wrote:

Are there reasons to inform the users that a mod was not signed?

At first: Users should not be able to download not signed mods or mods with outdated signature.
And they cannot do much about it, so spamming them with the messages about all unsigned mods would not be kind.

In D2114#88408, @elexis wrote:

Is it considered a mistake if such an element appears, and if it is, would it be reasonable to inform the user so as to have it reported to the mod signers?

If you mean that there is no information about signature, what means there is no object, it is error, because that metadata contains information also about dependencies.
But in the first place ingame downloander permits users to downloand not - signed mods, because that means that mod is not trusted.

Jul 23 2019, 5:19 PM
Silier updated the diff for D2114: Do not fail if some mod is broken [Mod Io].
Jul 23 2019, 4:34 PM
Silier updated the diff for D2114: Do not fail if some mod is broken [Mod Io].

also remove test assert as we ignore mod silently

Jul 23 2019, 4:01 PM
Silier created D2114: Do not fail if some mod is broken [Mod Io].
Jul 23 2019, 3:51 PM
Silier added a comment to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

Builds and tests are green on windows.

Jul 23 2019, 2:10 PM
Silier added a comment to D2081: Add status effects support to splash, melee and death damage..

I do not fully agree with restricted classes for splash damage. As was said restricted classes and preferred classes are something for unitai and petra to choose better target and do not waist attack at something it should not attack.
If there will be in future real time detection for projectiles collision, the fact if that projectile or splash damage, death damage will deal some damage to the given entity should be based on damage type vs armour type and not restricted classes. But this is just my personal opinion. :)

Jul 23 2019, 1:25 PM
Silier added a comment to D2104: Unify usage of mouse buttons for preselected action and hotkey modifications.

if we allow left and right how would one cancel preselected action?

Jul 23 2019, 11:49 AM

Jul 22 2019

Silier awarded rP22527: Easier introduction of new damage types. a Love token.
Jul 22 2019, 8:41 PM
Silier added a comment to D2056: Resupport more garrisoned slots per entity..

selection details that part i posted is when you hover over that sword and shield when selected entity, it takes data from entity state so uses cmpGarrisonHolder

Jul 22 2019, 6:59 PM
Silier added a comment to D2056: Resupport more garrisoned slots per entity..

@Nescio
in selection_details

Engine.GetGUIObjectByName("attackAndArmorStats").tooltip = [
		getAttackTooltip,
		getSplashDamageTooltip,
		getHealerTooltip,
		getArmorTooltip,
		getGatherTooltip,
		getSpeedTooltip,
		getGarrisonTooltip,
		getProjectilesTooltip,
		getConsumerTooltip,
		getPayedTooltip,
		getResourceTrickleTooltip,
		getLootTooltip
	].map(func => func(entState)).filter(tip => tip).join("\n");

vs
selection_panels

let template = GetTemplateData(data.item);
let tooltips = [
			getEntityNamesFormatted,
			getVisibleEntityClassesFormatted,
			getAurasTooltip,
			getEntityTooltip,
			getEntityCostTooltip,
			getGarrisonTooltip,
			getPopulationBonusTooltip,
			showTemplateViewerOnRightClickTooltip
		].map(func => func(template));
Jul 22 2019, 6:45 PM
Silier added a comment to D2056: Resupport more garrisoned slots per entity..

it displays chosen tooltip and formulate it based on data it gets. It does not gets data by itslef, data are given to it.

Jul 22 2019, 6:30 PM