Page MenuHomeWildfire Games
Feed Advanced Search

Sat, May 9

badosu added inline comments to D2727: IGUIObject ScriptEvent return value.
Sat, May 9, 8:06 PM

Fri, May 8

badosu added a comment to D1639: Rmgen new type constraint DensityConstraint.

For smoothly changing tree density dependent on distance to area and/or height I suggest to use a painter rather than a constraint ;)

Fri, May 8, 5:02 PM
badosu added a comment to D1639: Rmgen new type constraint DensityConstraint.

This constraint is not deterministic since the random number is rolled in .allows.
That means if you use this to paint trees on an area and do this over and over again you will get increasing densities though that was nowhere specified by the user.

Fri, May 8, 3:37 PM

May 3 2020

badosu added a comment to D2720: remove misinformation from {civ}.json files.

Well, the question is, do we have intention to have these implemented? If yes then I'm fine with this change, otherwise we should remove all the unimplemented stuff we have in-game right now.

May 3 2020, 1:54 PM
badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

@elexis @Stan Any additional feedback?

May 3 2020, 12:17 AM
badosu added a comment to D1751: [WIP] Map ping.

We could. current plan was to add a keybinding so you can click anywhere on the minimap or map to do the ping.

May 3 2020, 12:14 AM

May 2 2020

badosu added a comment to D1751: [WIP] Map ping.

This is great! Can we add a keybinding to ping on the center of the current camera view?

May 2 2020, 12:01 AM

May 1 2020

badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

So speaking about creating lots of vectors causing perf impact, those could also become the same temporary vector and use the set method to change the coordinates.

May 1 2020, 8:06 PM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.
Style fixes for tests
May 1 2020, 4:39 AM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Style fixes for tests

May 1 2020, 4:31 AM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Style fixes for tests

May 1 2020, 4:30 AM
badosu updated the summary of D2715: Fail test suite when map tests throw errors.
May 1 2020, 4:25 AM
badosu updated the test plan for D2715: Fail test suite when map tests throw errors.
May 1 2020, 4:24 AM
badosu updated the test plan for D2715: Fail test suite when map tests throw errors.
May 1 2020, 4:22 AM
badosu updated the test plan for D2715: Fail test suite when map tests throw errors.
May 1 2020, 4:22 AM
badosu updated the diff for D2715: Fail test suite when map tests throw errors.

Style fixes

May 1 2020, 4:20 AM
badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

With https://code.wildfiregames.com/D2715 sent I am confident that we can catch any regression tested by the tests introduced in this change. I am confident on the state of this patch. cc @elexis

May 1 2020, 4:19 AM
badosu updated the diff for D2715: Fail test suite when map tests throw errors.

Style fixes

May 1 2020, 4:18 AM
badosu created D2715: Fail test suite when map tests throw errors.
May 1 2020, 4:16 AM
badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

Is that correct? The map has |mapSize| tiles which makes |mapSize+1| vertices on the heightgrid.
The values returned by a Placer should be locations of tiles I think and then if a Painter like the HeightPainters operate on vertices of tiles, its their responsibility to work on all four vertices of the given tile.
So actually seems correct then to go from 0 to N-1 making up for N tiles.

May 1 2020, 12:18 AM

Apr 30 2020

badosu added a comment to D880: Ballistics..

One thing to notice though, is that as the game currently stands, units can perfectly estimate the position of their target, i.e. perfect "ballistics".

Apr 30 2020, 11:33 AM
badosu added a comment to D880: Ballistics..

One thing to notice though, is that as the game currently stands, units can perfectly estimate the position of their target, i.e. perfect "ballistics". This patch introduces an option to change that behaviour from the templates.

Apr 30 2020, 11:15 AM

Apr 29 2020

badosu added a comment to D880: Ballistics..

I like the idea of ballistics inclusion, one issue I find often is that chasing units with ranged units (e.g. skirm cav against archer cav) is very inefficient while it shouldn't in terms of gameplay.

Apr 29 2020, 11:44 PM
badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

Well I guess best way to test there are no errors is to add unit tests for those cases and fix the code :)

Apr 29 2020, 9:16 AM
badosu updated the test plan for D2710: DiskPlacer: avoid scanning whole map.
Apr 29 2020, 6:29 AM
badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

One important remark, I noticed the build does not fail if there was a javascript error (as it happens when there's an invalid cache access on Area). Is there a way I can assert there were no javascript errors?

Apr 29 2020, 6:25 AM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Remove redundant initializer

Apr 29 2020, 6:24 AM
badosu added inline comments to D2710: DiskPlacer: avoid scanning whole map.
Apr 29 2020, 6:23 AM
badosu added inline comments to D2710: DiskPlacer: avoid scanning whole map.
Apr 29 2020, 5:24 AM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Properly handle map edge

Apr 29 2020, 5:22 AM
badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

I performed some tests on gear normal for 8 players, times are in seconds and retrieved from the map logger:

Apr 29 2020, 3:55 AM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Handle floating radius properly for DiskPlacer

Apr 29 2020, 3:36 AM
badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

Ok, I performed the style fixes, I'll make some profiling and testing and we should be good to land.

Apr 29 2020, 2:58 AM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Style fixes

Apr 29 2020, 2:57 AM
badosu added inline comments to D2710: DiskPlacer: avoid scanning whole map.
Apr 29 2020, 2:55 AM

Apr 28 2020

badosu added inline comments to D2710: DiskPlacer: avoid scanning whole map.
Apr 28 2020, 4:50 AM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Removed the map boundaries condition, this is in effect already for the actual map grid boundaries. For circular maps we allow points outside the map range but inside the map grid boundaries

Apr 28 2020, 4:48 AM
badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

As an additional remark, I suspect RandomMap.inMapBounds needs to be refactored to exclude points outside map disk range when map is circular.

Apr 28 2020, 4:21 AM
badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

I am not sure why the build has failed, it says there was a segmentation fault in the compiler?

Apr 28 2020, 4:15 AM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Style changes to DiskPlacer tests

Apr 28 2020, 4:13 AM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Constrain point iterator inside map boundaries

Apr 28 2020, 4:10 AM
badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

I am not sure I'd like to add the iterator helper to the scope of this changeset, I refactored the code to be similar to what you shared though.

Apr 28 2020, 4:04 AM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Add tests for DiskPlacer, refactor iterator

Apr 28 2020, 3:59 AM

Apr 27 2020

badosu added inline comments to D2710: DiskPlacer: avoid scanning whole map.
Apr 27 2020, 11:06 PM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Add to credits

Apr 27 2020, 11:04 PM
badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

@Angen Did it work?

Apr 27 2020, 11:02 PM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Include file context

Apr 27 2020, 11:01 PM

Apr 26 2020

badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

@elexis @asterix How can I run a javascript test on a single file? I'd like to add tests for this placer, like binaries/data/mods/public/maps/random/tests/test_RectPlacer

Apr 26 2020, 11:35 PM
badosu added a comment to D2710: DiskPlacer: avoid scanning whole map.

We only allocate now when cloning the point to fill the area. Also check map boundaries with RandomMap.validTile

Apr 26 2020, 10:55 PM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Check map boundaries and clone the vector properly

Apr 26 2020, 10:54 PM
badosu added inline comments to D2710: DiskPlacer: avoid scanning whole map.
Apr 26 2020, 9:11 PM
badosu updated the diff for D2710: DiskPlacer: avoid scanning whole map.

Avoid allocating on every tile scan

Apr 26 2020, 9:10 PM
badosu added a comment to D2682: [gameplay] unify hero health.

I am not sure about this change, balancing heroes is a hard task: other factors are as or more relevant than health, e.g. walk speed: in regicide having a cavalry hero is much easier to protect, cavalry heroes can be used to harass unsuspecting farmlands and escape easily, etc...

Apr 26 2020, 7:43 AM
badosu updated the summary of D2710: DiskPlacer: avoid scanning whole map.
Apr 26 2020, 5:54 AM
badosu created D2710: DiskPlacer: avoid scanning whole map.
Apr 26 2020, 5:48 AM

Apr 16 2020

badosu added a comment to D2674: [gameplay]: make foundations not ConquestCritical.

If the win condition is to kill all units and structures, this looks like a worthy improvement to avoid foundation placement abuse (e.g. a player with a lot of wood can place outpost foundations and delay his defeat considerably), with a safe worker (e.g. with hill abuse) can delay much by cancelling an outpost while having another and placing somewhere else and so on.

Apr 16 2020, 10:19 PM

Mar 26 2020

badosu added a comment to D2669: [gameplay] new Gaul team bonus.
Mar 26 2020, 2:09 AM

Feb 24 2020

badosu added a comment to D2585: [gameplay] Cavalry archer speed adjustment.

@elexis

If its easier, one could also just upload replays and perhaps a link to the mod.

Feb 24 2020, 9:34 PM

Feb 2 2020

badosu added a comment to D2612: [gameplay] Balance ranged infantry citizen soldiers.

Again doesnt state whether that were 2 1v1s or 8 4v4s.

Feb 2 2020, 6:13 PM