Page MenuHomeWildfire Games
Feed Advanced Search

Dec 4 2020

nephele added inline comments to D3183: Redo D2399.
Dec 4 2020, 10:04 PM
nephele added inline comments to D3183: Redo D2399.
Dec 4 2020, 9:49 PM
nephele added a comment to D1594: [BSD] FreeBSD does not have MAP_NORESERVE.

@Stan Your patch looks alright, but this flag seems to refer to reserving swap space, not memory overcommit (which linux also does per default afaik)

Dec 4 2020, 7:16 PM

Jun 26 2020

nephele added a comment to D2689: Update fmt to the most recent release.

My change was merged, i tested it again now with the newest git gave me.
It builds and runs fine on alpine linux for me.

Jun 26 2020, 9:30 PM

Jun 23 2020

nephele added a comment to D2671: Build: include libexecinfo on musl system.

Ah, i did not know about -o, otherwise i might have done that myself.

Jun 23 2020, 5:48 PM

Jun 5 2020

nephele commandeered D2674: [gameplay] make foundations not ConquestCritical.
Jun 5 2020, 12:01 PM

May 23 2020

nephele added a comment to D2689: Update fmt to the most recent release.

I've build this with D2671 aplied beforehand on alpine linux, afterwards i was able to run the game (i had some js errors in game setup view, but likely not related, wasn't on the highest revision but could do that if needed)

May 23 2020, 8:06 PM
nephele updated the diff for D2671: Build: include libexecinfo on musl system.

Moved the comment, moved the if bsd conditionals to the variable asignment for readability

May 23 2020, 8:03 PM

Apr 29 2020

nephele added a comment to D2674: [gameplay] make foundations not ConquestCritical.

rP20471 purposely added foundations to the conquest queries, since with a single foundation (of a conquest critical building) an ally can build it and you can rebuild your army.

I would still argue that this makes little since, if an ally is supposed to be able to rebuild your civ then hey should just be able to rebuild your civ.
Regardless I don't think marking foundations conquestcritical is a good solution for allowing allies to rebuild your (obviously destroyed) civ, the code should rather treat the entire teams dead or alive status as one and allow allies to build new buildings for you.

Apr 29 2020, 2:31 AM

Apr 16 2020

nephele added a comment to D2674: [gameplay] make foundations not ConquestCritical.

Just make sure that you don't get defeated like this in a teamgame until all allies don't have any units. As it would be very annoying to get defeated whilst an ally is building your Civic center.

Apr 16 2020, 6:01 PM

Mar 28 2020

nephele added a comment to D2671: Build: include libexecinfo on musl system.

Alright, i can move the test to line 92 cache the result and then retest. (with apropriate comments)

Mar 28 2020, 7:45 PM
nephele added a comment to D2671: Build: include libexecinfo on musl system.

Would it be easy to detect musl?

No, it wouldn't, and detecting musl does not seem desireable either since the libc is supposed to be useable anyway.
We basically only need to figure out if the symbol is available in the system libc or not, which this test does.

Mar 28 2020, 7:38 PM
nephele added a comment to D2671: Build: include libexecinfo on musl system.

and waiting for the test compilation would slow down the pre-build process.

Atleast for my (by now low-to-medium end) system it's a negligable ammount of time.

Mar 28 2020, 7:19 PM

Mar 26 2020

nephele added a comment to D2674: [gameplay] make foundations not ConquestCritical.

I've never player Conquest only units or only structures, so no clue what is supposed to happen there.

Mar 26 2020, 10:59 PM
nephele abandoned D2678: [simulation2] remove warning in removing token in xml via filter.

Not needed with the differing aproach in D2674.

Mar 26 2020, 8:23 PM
nephele added a comment to D2674: [gameplay] make foundations not ConquestCritical.

The new patch looks to work fine, just tested it.

Mar 26 2020, 8:20 PM
nephele commandeered D2674: [gameplay] make foundations not ConquestCritical.

This looks to be unrelated changes aswell? Should i just test the ConquestCritical -> ConquestCritical+!Foundation part?

Mar 26 2020, 7:36 PM
nephele added a comment to D2678: [simulation2] remove warning in removing token in xml via filter.

The only other option I see would be to introduce a new token that can be removed without a warning, The commit that introduced the warning fixed a crash when removing the token anyhow.

Mar 26 2020, 7:30 PM
nephele added a comment to D2674: [gameplay] make foundations not ConquestCritical.

Please see D2678 for the patch to remove the warning.

Mar 26 2020, 6:53 PM
nephele created D2678: [simulation2] remove warning in removing token in xml via filter.
Mar 26 2020, 6:52 PM
nephele created D2674: [gameplay] make foundations not ConquestCritical.
Mar 26 2020, 5:38 PM
nephele created D2671: Build: include libexecinfo on musl system.
Mar 26 2020, 2:59 AM