Page MenuHomeWildfire Games
Feed Advanced Search

Dec 16 2023

Dunedan updated the diff for D5216: Check for source of XMPP stanzas.
Dec 16 2023, 3:53 PM
Dunedan added a comment to D5217: Fix deferred sending of game updates via XMPP.

(02:39:02) scythetwirler: anything dealing with having enough/not enough space for joining should be instaupdate
(02:39:14) scythetwirler: anything else should be second priority
(02:39:21) scythetwirler: is that good enough? :P

Dec 16 2023, 3:49 PM

Dec 15 2023

Dunedan added a comment to D5217: Fix deferred sending of game updates via XMPP.

This diff only reduces messages when the playerassignment changes. That aren't that much. compared to scroling through the maps.

Dec 15 2023, 8:52 PM
Dunedan updated the diff for D5217: Fix deferred sending of game updates via XMPP.
Dec 15 2023, 8:45 PM

Dec 10 2023

Dunedan added a comment to D5217: Fix deferred sending of game updates via XMPP.

As mentioned in #6740 it might have already been rP24686 which introduced the problem.

Dec 10 2023, 6:44 AM
Dunedan updated the Trac tickets for D5217: Fix deferred sending of game updates via XMPP.
Dec 10 2023, 6:40 AM

Dec 9 2023

Dunedan requested review of D5217: Fix deferred sending of game updates via XMPP.
Dec 9 2023, 9:51 PM

Dec 7 2023

Dunedan added a reviewer for D5216: Check for source of XMPP stanzas: wraitii.
Dec 7 2023, 9:24 AM

Dec 6 2023

Dunedan added a comment to D5039: Allow changing lobby password inside 0 A.D..

@wraitii: Can we get that merged?

Dec 6 2023, 2:23 PM
Dunedan requested review of D5216: Check for source of XMPP stanzas.
Dec 6 2023, 8:36 AM

Jul 8 2023

Dunedan added a comment to D4987: Access Control Lists (ACLs) for hosted games.

Consider that ACLs currently work with non-lobby hosted games as well as lobby hosted games.

Jul 8 2023, 5:27 PM

Jun 8 2023

Dunedan closed D4999: Update the rules for new lobby usernames.
Jun 8 2023, 6:50 PM
Dunedan committed rP27670: Update the rules for new lobby usernames.
Update the rules for new lobby usernames
Jun 8 2023, 5:23 PM

Jun 7 2023

Dunedan accepted D5039: Allow changing lobby password inside 0 A.D..

Un-comment essential line.

Jun 7 2023, 10:25 PM
Dunedan requested changes to D5039: Allow changing lobby password inside 0 A.D..

I tried it out with a lobby instance running locally and unfortunately it doesn't work yet. All I get is a "Error: Request timed out." message when trying to change the password, while no password change related message is being sent to the XMPP server.

Jun 7 2023, 5:44 PM

May 20 2023

Dunedan added a comment to D4999: Update the rules for new lobby usernames.

Might be slightly better form to do the check in a separate match clause, for explicitness (and simplifies the regex somewhat, and we don't really care that much about performance).

May 20 2023, 10:59 AM
Dunedan published D4999: Update the rules for new lobby usernames for review.
May 20 2023, 10:11 AM

Apr 9 2023

Dunedan abandoned D1661: lobby bots systemd service.

We now publish the infrastructure code used to deploy the lobby (https://github.com/0ad/lobby-infrastructure) and this code includes the systemd unit files to run the bots as well: https://github.com/0ad/lobby-infrastructure/tree/master/roles/lobby_bots/templates

Apr 9 2023, 2:11 PM

Oct 23 2022

Dunedan added a comment to D1663: Display lobby bots differently in the lobby.
In D1663#204741, @Stan wrote:

@lyv @Dunedan @user1 @defc0n this pretty nice what do you think?

Oct 23 2022, 8:32 AM

Sep 11 2022

Dunedan added a comment to rP27093: Remove code for the lobby bots from SVN.

As there haven't been any more feedback on this revision and we had various cases where people got confused which code is the current one, I went ahead and committed the changes now.

Sep 11 2022, 3:26 PM
Dunedan committed rP27094: Remove code for the lobby bots from SVN.
Remove code for the lobby bots from SVN
Sep 11 2022, 3:22 PM
Dunedan committed rP27093: Remove code for the lobby bots from SVN.
Remove code for the lobby bots from SVN
Sep 11 2022, 3:15 PM
Dunedan closed D4155: Remove code for the lobby bots from SVN.
Sep 11 2022, 3:15 PM

Sep 2 2022

Dunedan accepted D4783: Amend ToU to disallow account sharing.

I am in a bit of a pickle. Should this be committed regardless of string freeze?

Sep 2 2022, 5:13 PM

Jul 6 2022

Dunedan added a comment to rP15813: Makes the bot more lenient on case sensitivity due to inconsistencies in case….

Yes, that's still relevant. I just opened a PR with a fix for that: https://github.com/0ad/lobby-bots/pull/10

Jul 6 2022, 9:09 PM

Mar 7 2022

Dunedan added a comment to D1661: lobby bots systemd service.
In D1661#193330, @Stan wrote:

@Dunedan anything still useful here?

Mar 7 2022, 8:40 PM

Sep 14 2021

Dunedan added a comment to D4262: Restoring the colored profile name with the ranking and using the leaderboard names for autocompletion in the profile player search field..
20:51 < Langbart> @tell Dunedan In D4262 I would like to include "Engine.SendGetBoardList();" to get the top100 players for autocompletion. Is this an idea that causes more stress on network traffic and should not be included?
Sep 14 2021, 6:28 PM

Jun 12 2021

Dunedan updated the diff for D4155: Remove code for the lobby bots from SVN.

Found the lobby bots mentioned in the licensing information for the tools and removed it there as well.

Jun 12 2021, 7:11 AM
Dunedan requested review of D4155: Remove code for the lobby bots from SVN.
Jun 12 2021, 7:01 AM

Jun 1 2020

Dunedan added a comment to D2771: Remove "domestic" attribute for wolves on polar sea.

And in case it wasn't clear from the code, the trigger script spawns wolves, the wolves receive Move orders making the wolves attack the players units - so basically zombie wolves. It was added to make the map less boring. The wolves are Domestic because currently only Domestic animals can follow move orders […]

Jun 1 2020, 9:57 AM

May 31 2020

Dunedan added a comment to D2771: Remove "domestic" attribute for wolves on polar sea.

Sorry, but I don't get your point. Clearly non-domestic animals are as controllable right now as are domestic animals. So what's the problem with this patch from your point of view?

May 31 2020, 12:03 PM

May 30 2020

Dunedan created D2771: Remove "domestic" attribute for wolves on polar sea.
May 30 2020, 6:29 PM

May 20 2020

Dunedan added a comment to D2747: Make password hashing case-insensitive to comply with jabberd specification..

If it needs to be a breaking change anyway, why not to remove the whole logic for generating the actual password by hashing the username and password and instead just using the password as password? Wouldn't this result in the same logic as other XMPP clients use as well?

May 20 2020, 7:25 PM

May 18 2020

Dunedan accepted D2747: Make password hashing case-insensitive to comply with jabberd specification..

Looks good given the current constraints for the password generation logic. 👍

May 18 2020, 9:06 PM

May 7 2020

Dunedan added a comment to D2630: Major improvements to the lobby bots XpartaMuPP and EcheLOn..

@user1 : Did you verify the code now doesn't just apply but also works with this patch?

May 7 2020, 2:38 PM

Mar 7 2020

Dunedan added a comment to D2630: Major improvements to the lobby bots XpartaMuPP and EcheLOn..
In D2630#111282, @Stan wrote:

I believe the patch doesn't have the correct root folder. I assume those files are in source/tools/lobby?

Mar 7 2020, 12:24 PM
Dunedan added a comment to D2630: Major improvements to the lobby bots XpartaMuPP and EcheLOn..

I can't apply the patch to current SVN. Am I doing something wrong or is it incomplete?

Mar 7 2020, 11:20 AM

Feb 29 2020

Dunedan added a comment to D2630: Major improvements to the lobby bots XpartaMuPP and EcheLOn..

I would suggest to rename "utils" to LimitedDict or similar, otherwise it invites developers to add many unrelated things. We can see in binaries/data/mods/public/gui/common/functions_utility.js an example of this, and then the difficulty to split it into logically cohesive components accumulates.

Feb 29 2020, 2:59 PM

Feb 28 2020

Dunedan added a comment to D2630: Major improvements to the lobby bots XpartaMuPP and EcheLOn..

The following revisions are lost because of this:

r22460 | 2019-07-12 13:40:40 -0400 (Fri, 12 Jul 2019) Fix lineendings. (partially lost)
r21927 | 2018-11-07 12:32:21 -0500 (Wed, 07 Nov 2018) The files in this path were not marked as moved in rP21926...

Feb 28 2020, 8:02 AM

Nov 11 2018

Dunedan added a comment to D1661: lobby bots systemd service.

As already mentioned I don't see a benefit in using a sysvinit script. I'd just use one systemd service template for each bot and one systemd service instance per bot instance.
Such a systemd template would look like:

[Unit]
Description=XPartaMuPP Pyrogenesis/0 A.D. Lobby Bot %i
Documentation=https://trac.wildfiregames.com/
After=network.target ejabberd.service
Nov 11 2018, 10:11 AM

Nov 7 2018

Dunedan added a comment to D1661: lobby bots systemd service.

Why to use systemd services to call sysvinit init scripts? Why not just using systemd services? That'd make everything easier.

Nov 7 2018, 11:00 PM
Dunedan added a comment to D1659: Correct and complete lobby server readme.
In D1659#65939, @elexis wrote:

We need two bots per room, not two bots per server.

Nov 7 2018, 10:59 PM
Dunedan added a comment to D1659: Correct and complete lobby server readme.
In D1659#65912, @elexis wrote:

The pid/logfile is handled by systemd.
There is one logfile and pidfile per bot, at least one bot per room, but one systemd service handling all bots.
I don't see a better place to put them rather than the directory for that room for that bot, do you know one?
(Every bot instance needs an own code copy to provide the correct version for everyroom).

Nov 7 2018, 8:23 PM

Nov 6 2018

Dunedan added a comment to D1659: Correct and complete lobby server readme.
In D1659#65867, @elexis wrote:

Perhaps it makes sense to have the bots in the same python installation package.

Nov 6 2018, 7:39 PM

Nov 3 2018

Dunedan added a comment to D1659: Correct and complete lobby server readme.
In D1659#65858, @elexis wrote:

A folder named XpartaMuPP should not contain EcheLOn.
I propose to use a separate folder for XPartaMupp and EcheLOn. The directory is becoming quite messy. Not going to upload a diff with moved files, but I do propose:

Nov 3 2018, 7:28 PM

Sep 30 2018

Dunedan added a comment to rP21719: Send rating related requests directly to EcheLOn..

@user1: Do you have any more details regarding this?

Sep 30 2018, 7:28 PM

Jul 8 2018

Dunedan accepted D1570: Fix typo in lobby server README.
Jul 8 2018, 8:17 PM
Dunedan added inline comments to D1525: Add a lobby server port config option .
Jul 8 2018, 2:20 PM

Mar 31 2018

Dunedan added a comment to D1177: Send rating related requests directly to EcheLOn.
In D1177#58260, @elexis wrote:

Does this throw any kind of error if EcheLOn is offline? (Guess not, given how few code this diff changes)

Mar 31 2018, 1:22 PM
Dunedan updated the diff for D1177: Send rating related requests directly to EcheLOn.

Rebased to account for some lobby changes in SVN.

Mar 31 2018, 12:46 PM

Mar 17 2018

Dunedan awarded D1366: Don't add the period outside a translated string a Like token.
Mar 17 2018, 9:42 PM

Mar 11 2018

Dunedan created D1378: Address concerns of rP20321.
Mar 11 2018, 6:49 PM

Feb 3 2018

Dunedan accepted D897: Secure lobby authentication - prevent joins as a different player.
In D897#52116, @Imarok wrote:

If we recieve an unexpected lobbyauth token, we should just ignore it. Everything else will be far too complicated for no benefit.

Feb 3 2018, 8:05 PM
Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#51842, @Imarok wrote:

Reply with an empty result.

Feb 3 2018, 1:35 PM

Jan 27 2018

Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#51174, @Imarok wrote:

So this would be ok for you?:

The stanza currently sent will become a request of the type set.
The servers xmpp client will respond over xmpp with an ack or whatever that the receiver will just accept and ignore.

Jan 27 2018, 10:45 PM

Jan 26 2018

Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#50538, @Dunedan wrote:
  • The child element of IQ-stanzas should be named query, instead of auth.
Jan 26 2018, 8:46 AM

Jan 24 2018

Dunedan added a comment to D978: Add XSDs for the custom XMPP IQ stanzas.

Easy to answer:

  • I wasn't aware that there are already other schemas for XML documents in 0ad (I might have searched for XSD only).
  • XMPP extensions are usually defined using XSD (e.g. here is a random example: https://xmpp.org/extensions/xep-0092.html#schema)
Jan 24 2018, 6:22 PM
Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#50757, @Imarok wrote:

Could you show me the part of the standard that says a response always must be a answer to a query? I couldn' t find it the last time I looked into it.

Jan 24 2018, 6:17 PM
Dunedan planned changes to D978: Add XSDs for the custom XMPP IQ stanzas.

XSD for game results is still missing.

Jan 24 2018, 1:36 PM

Jan 23 2018

Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#50646, @Imarok wrote:

Then most of our code is not valid. I think it's valid enough...

Jan 23 2018, 8:27 PM
Dunedan requested changes to D897: Secure lobby authentication - prevent joins as a different player.
Jan 23 2018, 8:01 PM
Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.

It's intended that he stanza sent is a response and not a request. Exactly to follow this request-response rule. (With the exception, that the request from the server wasn't sent via xmpp but via enet)

Jan 23 2018, 7:57 PM

Jan 22 2018

Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#50427, @Imarok wrote:

It's missing cause the stanza is printed before gloox adds it.

Jan 22 2018, 9:44 PM

Jan 21 2018

Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#50124, @Imarok wrote:

Edit: This is how an iq-stanza sent for lobby auth should look like:

SendIqLobbyAuth [<iq to='imarok@lobby.wildfiregames.com/0ad' id='uid-1f75c630-00000005' type='result'><auth xmlns='jabber:iq:lobbyauth'><token>CABE93B117739A47</token></auth></iq>]
Jan 21 2018, 6:09 PM

Jan 15 2018

Dunedan added a comment to D791: Lobby reconnect dialog on disconnected.

An alternative is to connect using a regular XMPP client instead of a second instance of 0ad. As the second XMPP client uses another resource identifier it's not causing any problems.

Jan 15 2018, 10:20 PM
Dunedan added a comment to D791: Lobby reconnect dialog on disconnected.
In D791#49737, @mapkoc wrote:

Dunedan, I see a problem with that. If you open a second window and join multiplayer, both windows would fight to auto reconnect. Maybe it's best to give the user the decision.

Jan 15 2018, 8:38 PM
Dunedan updated the diff for D1182: Make XMPP-bots work with newer SleekXMPP versions.

For whatever reason the changes for EcheLOn were missing. This update to the patch adds them

Jan 15 2018, 7:23 PM

Jan 14 2018

Dunedan added a comment to D791: Lobby reconnect dialog on disconnected.

Why showing a dialog in the first place at all and not automatically reconnecting in the background (with exponential back-off, ...) and only showing a dialog of that continues to fail?

Jan 14 2018, 8:27 PM
Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.

For me this patch doesn't work applied to current master. When setting up a new game with enabled "Require lobby authentication" the game setup page never opens and instead it gets stuck at the "Registering with server" dialog. What I can see in the background is that there is a IQ-stanza sent via XMPP, but this stanza doesn't even contain a recipient (and might have some other problems, but more on that once it works). For me it looks like the game tries to authenticate the hosting player as well. Is that intented?

Jan 14 2018, 6:07 PM
Dunedan created D1222: Fix crash in lobby.
Jan 14 2018, 4:04 PM

Jan 12 2018

Dunedan added a comment to D628: Escape underscore(and other characters) in like clauses in echelon ratings bot..

Step 1. Apply the patch and install python3-sqlalchemy-utils on the server.

Jan 12 2018, 6:34 PM

Jan 9 2018

Dunedan added a comment to D1208: Update mod_ipstamp for current ejabberd versions.
In D1208#49232, @Itms wrote:

I'm facing a blocking issue before even testing this: I cannot install ejabberd from the backports on a fresh Debian VM...

Jan 9 2018, 11:02 PM

Jan 8 2018

Dunedan updated the summary of D1208: Update mod_ipstamp for current ejabberd versions.
Jan 8 2018, 8:20 PM
Dunedan created D1208: Update mod_ipstamp for current ejabberd versions.
Jan 8 2018, 8:19 PM

Jan 7 2018

Dunedan accepted D280: Convert Lobby README to markdown.

@Itms: Apparently there is already a note in the README about the supported ejabberd versions. Enough for you to continue to review or even approve this patch?

Jan 7 2018, 8:51 PM
Dunedan added inline comments to D206: Lobby Bot Optimizations and Upgrade to SleekXMPP 1.3.1+ (Merge from github branch).
Jan 7 2018, 7:15 PM
Dunedan added a comment to D280: Convert Lobby README to markdown.

I feel like this patch is in some kind of dead-lock right now.

Jan 7 2018, 3:12 PM

Jan 6 2018

Dunedan updated the diff for D1197: Fix timestamps in lobby for delayed messages with microseconds.

Improved docstrings

Jan 6 2018, 5:00 PM
Dunedan updated the diff for D1197: Fix timestamps in lobby for delayed messages with microseconds.

Fix diff

Jan 6 2018, 8:42 AM
Dunedan updated the diff for D1197: Fix timestamps in lobby for delayed messages with microseconds.

As suggested changed the if to a for loop.

Jan 6 2018, 8:40 AM

Jan 5 2018

Dunedan added a comment to D1197: Fix timestamps in lobby for delayed messages with microseconds.
In D1197#48522, @elexis wrote:

Can you try to take a look to unify that, preferably by just updating the pattern?

Jan 5 2018, 9:12 PM
Dunedan added a comment to D1197: Fix timestamps in lobby for delayed messages with microseconds.
In D1197#48513, @elexis wrote:

XEP numbers and links should be documented in the code (see ticket, see documentation of the function).

Jan 5 2018, 8:28 PM
Dunedan created D1197: Fix timestamps in lobby for delayed messages with microseconds.
Jan 5 2018, 6:51 PM

Jan 3 2018

Dunedan added a comment to D1153: Optional lobby chat presence brightness and dot, player ratings.

I like the idea of optional message for created/finished games, but I'm not a big fan of the other two. What I'd rather like to see a brightness change get used for is for the message backlog when joining the room.
I think the dots and brightness per status add to much clutter to the chat window, especially as they dynamically adjust to the current player status. They also don't provide any information which isn't already available from the nick list.

Jan 3 2018, 9:40 PM

Jan 1 2018

Dunedan added a comment to D1188: Allow different ingame name with real username revelation.

I tried it out and it works as advertised. While I like the idea in general I find the two-names-per-chat-message a bit too much. What about showing the lobby-username only in the summary screen and using the multiplayer name for the chat messages, no matter how the multiplayer game was set up?

Jan 1 2018, 2:32 PM

Dec 30 2017

Dunedan awarded D1162: Gather near dropsite rather than current position after finishing construction a Yellow Medal token.
Dec 30 2017, 8:23 AM

Dec 29 2017

Dunedan added a comment to D280: Convert Lobby README to markdown.
In D280#47719, @elexis wrote:

Dunedan if you have any code updates, please upload them.

Dec 29 2017, 10:08 AM

Dec 28 2017

Dunedan created D1182: Make XMPP-bots work with newer SleekXMPP versions.
Dec 28 2017, 2:48 PM
Dunedan added a comment to D280: Convert Lobby README to markdown.

The README instructions are correct for ejabberd version 2.x but not later. I think we can start work on that in a trac ticket discussing changes (code and readme changes) needed for upgrading ejabberd.

Dec 28 2017, 10:54 AM
Dunedan accepted D828: Unselect lobby game if the selected player isn't present in any game.

I tried it out and it works like a charm. A little, but a really nice improvement. ?

Dec 28 2017, 9:14 AM

Dec 27 2017

Dunedan added a comment to D1010: introduce subfolders for geology templates.

The following commands should work:

Dec 27 2017, 9:52 PM
Dunedan added a comment to D1009: introduce subfolders for flora templates.

The following commands should work:

Dec 27 2017, 9:48 PM

Dec 26 2017

Dunedan created D1177: Send rating related requests directly to EcheLOn.
Dec 26 2017, 1:30 PM
Dunedan added a comment to D1172: Lobby chat spam filter.

+1 for min_message_interval for the lobby, because that does enforce such a limit on server side, thus not allowing a player to remove it.

Dec 26 2017, 12:29 PM

Oct 26 2017

Dunedan awarded D937: Town bell - use matching classes, add a market alert a Like token.
Oct 26 2017, 5:37 PM
Dunedan awarded D965: Show fauna silhouettes a Like token.
Oct 26 2017, 5:36 PM
Dunedan accepted D975: Fix typo in log message: occured.
Oct 26 2017, 5:35 PM
Dunedan accepted D973: Fix typo in log message.
Oct 26 2017, 5:34 PM
Dunedan accepted D974: Fix typo in log message: recieved.
Oct 26 2017, 5:33 PM

Oct 25 2017

Dunedan awarded rP14162: Increasing the generation speed of the maps: Unknown Land a Like token.
Oct 25 2017, 10:32 PM