Page MenuHomeWildfire Games
Feed Advanced Search

Mon, May 13

bb added a comment to D1860: Rename pers_stables to pers_stable as rest of {civ}_stable to simplify check done by Petra.

Upload RIP again, well patch easy enough to review without context. I guess arc is complaining about the spaces in the mapfile names, also committer needs to be careful with the file move...

Mon, May 13, 10:25 PM
bb added inline comments to rP22280: Make the ai aware ranges no longer have the barracks class.
Mon, May 13, 9:14 PM
bb accepted D1878: [CChart] Add a percentage format.

looks like all summary percentages have a symbol now

Mon, May 13, 9:00 PM
bb committed rP22280: Make the ai aware ranges no longer have the barracks class.
Make the ai aware ranges no longer have the barracks class
Mon, May 13, 8:53 PM
bb closed D1857: Correct detected number of Barracks by Petra when building training facilities.
Mon, May 13, 8:53 PM
bb accepted D1857: Correct detected number of Barracks by Petra when building training facilities.

No other cases of "archery" in code

Mon, May 13, 8:41 PM
bb created D1883: Use arrow functions in ai filters.
Mon, May 13, 7:46 PM
bb added a comment to D1865: Unit Motion / AI - check ranges explicitly, move in the the State handlers instead of the orders..

I don't think this patch helps D981 a great deal, since consider a unit that is asked to attack something and unitmotion drops it of (with a moveToRange function) just outside the area an IsInRange function thinks it is in range. With this patch unitAI will now think the unit can't move and thus do nothing, meaning we will get idlers.

Mon, May 13, 5:13 PM

Thu, May 2

bb added a comment to D1857: Correct detected number of Barracks by Petra when building training facilities.

Thanks for noticing this, didn't we also rename the archery class in the commit?

Thu, May 2, 1:51 PM

Sat, Apr 27

bb added a comment to D1737: Slight cleanup of fogging OnDestroy and some comments.

comment I had laying around:

Sat, Apr 27, 11:37 PM

Fri, Apr 26

bb added a comment to D1843: ProductionQueue - Refactor the remove item function.

Among other things we should be able to spawn units in autogarnison if free slots but it's not the diff for that)

Careful with Extinct volcano OP-ness (on that map autogarrison would give a significant advantage to some civs)

Fri, Apr 26, 9:23 PM · Contributors

Wed, Apr 24

bb requested verification of rP22203: Communicate field diminishing returns to the player in the fields tooltip.
Wed, Apr 24, 9:17 PM
bb committed rP22220: Correct the grammer of rP22203.
Correct the grammer of rP22203
Wed, Apr 24, 9:16 PM
bb closed D1841: efficient -> efficiently in rP22203.
Wed, Apr 24, 9:16 PM
bb accepted D1841: efficient -> efficiently in rP22203.
Wed, Apr 24, 9:16 PM

Apr 21 2019

bb added a comment to D1613: Improve the plural translation of the "<players> have won" string.

k, now I understand the problem, gaelic hardcodes that 1 and 11 must always be the singular form, however that isn't the case in this string.

Apr 21 2019, 10:32 PM
bb accepted D1663: Display lobby bots differently in the lobby.

Patch still applies correctly, reads correct, front doesn't fall => accept

Apr 21 2019, 9:39 PM
bb added inline comments to D1727: Update auras when a formation member renames.
Apr 21 2019, 6:53 PM
bb added a comment to D1840: RunSpeedMultiplier cleanup: improve variable names and reuse a duplicated function (rP22197).
In D1840#75562, @elexis wrote:

If the value that SetSpeedRatio computes differs from the serialized value, by definition it's OOS?

Yes.
However, that value can only differ if m_SpeedRatio > std::min(ratio, m_RunSpeedMultiplier).
Which is impossible because the only place modifying m_SpeedRatio is SetSpeedRatio, which does m_SpeedRatio = std::min(ratio, m_RunSpeedMultiplier).

consider modifiying m_RunSpeedMultiplier too, which is only done on ownershipchange and valuemodification (afaik), where we set the value too

Apr 21 2019, 6:46 PM
bb committed rP22203: Communicate field diminishing returns to the player in the fields tooltip.
Communicate field diminishing returns to the player in the fields tooltip
Apr 21 2019, 6:26 PM
bb closed D1803: Communicate field diminishing returns to the player.
Apr 21 2019, 6:26 PM
bb accepted D1803: Communicate field diminishing returns to the player.

when someone decides to have something other than a grain field, one can always change it in the parent.

Apr 21 2019, 6:24 PM
bb added inline comments to D1829: Fix Pathgoal::RectContainsGoal family of function for SQUARE goals, reduce ambiguities, improve coherence among the different functions..
Apr 21 2019, 5:51 PM
bb added inline comments to rP22197: Change Run Speed into a Run multiplier..
Apr 21 2019, 5:34 PM
bb added a comment to D438: Change Run Speed into a Run multiplier.
In D438#75520, @elexis wrote:
In D438#74992, @bb wrote:

(we also need to do an OOS test on this btw)
did a quick rejoin test, which did not oos

What does quick rejoin test mean? Which steps did you perform?

Host a game and join with another player (both with the patch ofc), load the game and move stuff around (in formation, guard, attack a deer, do a tech etc.), leave with the joiner, and rejoin. Now move some more stuff and wait a little.

UnitMotion cannot know if this speed is on purpose or not so always adjust and let unitAI and such adapt

Assume this comment is true,
then UnitAI changes the runmultiplier and it yields an OOS, correct?

How will UnitAI change the runMultiplier? it is a template value, maybe modified by some tech...

Isn't serialization of the run multiplier so that UnitMotion can know if this speed is on purpose?

Where is it serialized? It is desirialized such that the rejoiner knows that a tech is researched, further it is a template value.

Is the deserialized runmultiplier read from? It looks like it's overwritten with a different value before it's read from.

The only other place I see it is set, is the init, which should be earlier right?

Apr 21 2019, 5:31 PM
bb committed rP22202: Bring the palisade templates under their own parent (instead of the stone wall)..
Bring the palisade templates under their own parent (instead of the stone wall).
Apr 21 2019, 4:55 PM
bb closed D1796: create template_defensive_palisade.xml.
Apr 21 2019, 4:55 PM
bb accepted D1796: create template_defensive_palisade.xml.

I noticed that some structures have smaller cost than loot, which looks a bit weird. Leaving that as is for now, this patch doesn't change this.

Apr 21 2019, 4:51 PM

Apr 20 2019

bb added inline comments to D1829: Fix Pathgoal::RectContainsGoal family of function for SQUARE goals, reduce ambiguities, improve coherence among the different functions..
Apr 20 2019, 6:55 PM
bb added inline comments to D1828: Health.js cleanup: add tests, add an "IsInjured" function, use GetHitpoints everywhere.
Apr 20 2019, 6:13 PM

Apr 16 2019

bb added inline comments to rP20939: Garrisoned units are lost after an upgrade towards a non garrison holder.
Apr 16 2019, 11:16 PM
bb accepted rP20393: Move out of world promoted, packed and upgraded entity as they are not….

concern fixed by rP20939

Apr 16 2019, 11:16 PM
bb accepted D1826: Fix missing parenthesis in the AI.
Apr 16 2019, 6:14 PM
bb added inline comments to D1737: Slight cleanup of fogging OnDestroy and some comments.
Apr 16 2019, 2:06 PM

Apr 15 2019

bb committed rP22191: align the footprint an obstruction size with the model size for the kush range.
align the footprint an obstruction size with the model size for the kush range
Apr 15 2019, 11:46 PM
bb committed rP22190: unparent the range from the barracks, and reduce the duplication in the civs'….
unparent the range from the barracks, and reduce the duplication in the civs'…
Apr 15 2019, 11:40 PM
bb closed D1791: Separate range from barracks.
Apr 15 2019, 11:40 PM
bb accepted D1791: Separate range from barracks.

Cav got removed from ranges (which makes sense)

Apr 15 2019, 11:35 PM
bb updated the diff for D1398: Implement a press action to be called upon the first keyDown message of a hotkey and use keydown for current press.

years

Apr 15 2019, 10:06 PM
bb accepted D438: Change Run Speed into a Run multiplier.

Some bot is complaining that this patch is rotting to long and needs a license year update

Apr 15 2019, 9:35 PM
bb added a comment to D1815: match unit classes with templates.

Renamings of spear => spearman and co is good imo (wasn't there some earlier revision where it was discussed?)

Apr 15 2019, 8:57 PM

Apr 14 2019

bb added a comment to rP22188: Move tooltips on gamesetup dropdowns from xml to js, since by current gamestup….

Comments By: elexis, Imarok

Apr 14 2019, 10:30 PM
bb committed rP22188: Move tooltips on gamesetup dropdowns from xml to js, since by current gamestup….
Move tooltips on gamesetup dropdowns from xml to js, since by current gamestup…
Apr 14 2019, 10:29 PM
bb closed D594: Fix tooltips not used in gamesetup.
Apr 14 2019, 10:29 PM · Contributors
bb accepted D594: Fix tooltips not used in gamesetup.

proofreading the gamesetup xml and global objects says the patch is complete (did not read the full file for any hidden tooltip in the code)

Apr 14 2019, 10:23 PM · Contributors
bb added inline comments to D1776: Cleanup Timer.js and update documentation.
Apr 14 2019, 10:00 PM
bb committed rP22187: Handle orderone hotkey also for the minimap.
Handle orderone hotkey also for the minimap
Apr 14 2019, 9:30 PM
bb closed D1822: Handle hotkey to order only one unit on minimap.
Apr 14 2019, 9:29 PM · Contributors
bb accepted D1822: Handle hotkey to order only one unit on minimap.

Thx for the patch

Apr 14 2019, 9:12 PM · Contributors

Apr 12 2019

bb committed rP22182: Add ConquestCritical to structures that want it, instead of removing it from….
Add ConquestCritical to structures that want it, instead of removing it from…
Apr 12 2019, 5:05 PM
bb closed D1626: -ConquestCritical clear-up.
Apr 12 2019, 5:05 PM
bb accepted D1626: -ConquestCritical clear-up.

Reading it again, the actual question is how to treat special (the rest looks good)

Apr 12 2019, 5:04 PM
bb committed rP22181: Reduce duplication in template_structure_military*.
Reduce duplication in template_structure_military*
Apr 12 2019, 4:12 PM
bb closed D1793: reduce template_structure_military* duplication.
Apr 12 2019, 4:12 PM
bb accepted D1793: reduce template_structure_military* duplication.

Changes to trivial to not accept,

Apr 12 2019, 3:58 PM
bb added a comment to D1796: create template_defensive_palisade.xml.
In D1796#74399, @Nescio wrote:

Maybe build time, wood cost, and loot ought to be made proportional to health, e.g. health/50?

Whatever makes sense compared to the other palisade structures. e.g cost wise a rocks_curve is pretty similar to a rocks_long, right?

Apr 12 2019, 3:29 PM
bb added a comment to D1803: Communicate field diminishing returns to the player.

I assume agricultural products would be the most general term? Do we want that in game?

Apr 12 2019, 3:19 PM
bb added inline comments to D1822: Handle hotkey to order only one unit on minimap.
Apr 12 2019, 3:15 PM · Contributors

Apr 7 2019

bb added a comment to D1810: Improvements to the translators credits script.

I get that ppl can choose whatever name they want, but who is named 4c905de7e2c9950b7d83273a8070b072 (second one in the german list)? I tried finding him/her in transifex but no luck.

Apr 7 2019, 10:12 PM
bb added inline comments to D1651: aiTips gamesetup cleanup.
Apr 7 2019, 10:11 PM · Contributors
bb added a comment to D1819: Make capture attack work with units with BuildingAI..

I won't stop anyone for making/commiting a temporal fix, but the underlying problem is that we have two components (buidlingAI and unitAI) on the same unit trying to achieve the same thing (attack something). In the end that is the thing we need to fix (as in subunits)

Apr 7 2019, 6:15 PM
bb committed rP22169: recieve -> receive.
recieve -> receive
Apr 7 2019, 6:06 PM
bb committed rP22166: Remove an unused variable.
Remove an unused variable
Apr 7 2019, 12:04 AM
bb closed D1813: Remove unused variable from CInput.
Apr 7 2019, 12:04 AM

Apr 6 2019

bb committed rP22165: Update the wonder victory timer in case the wonder renames..
Update the wonder victory timer in case the wonder renames.
Apr 6 2019, 11:58 PM
bb closed D1732: Wondervictory entity rename.
Apr 6 2019, 11:58 PM
bb added a comment to D1732: Wondervictory entity rename.

Calling the traders out of scope of this patch

Apr 6 2019, 11:58 PM
bb added inline comments to D1765: Gaia templates' <Selectable> clean-up.
Apr 6 2019, 11:48 PM
bb requested changes to D1796: create template_defensive_palisade.xml.

Checked the difference between the templates as they are loading in game (by printing them out), it resulted in a number of actual changes, giving them below, some of them are not a problem (or actually make sense), a few need to be addressed.

Apr 6 2019, 11:13 PM
elexis awarded rP22163: Remove unneeded death sounds from structure templates, as they inherit from… a Like token.
Apr 6 2019, 5:48 PM
bb accepted D1813: Remove unused variable from CInput.

That must be a copy-pasta, text.delete.right doesn't have it, so completeness in that sense

Apr 6 2019, 4:56 PM
bb added a comment to D1803: Communicate field diminishing returns to the player.

changing vegetables to grain wouldn't work since f.e. the Chinese mod has rise fields instead. One could consider "crops" though.

Apr 6 2019, 4:48 PM
bb committed rP22163: Remove unneeded death sounds from structure templates, as they inherit from….
Remove unneeded death sounds from structure templates, as they inherit from…
Apr 6 2019, 4:36 PM
bb closed D1795: remove unnecessary building_collapse_large sounds.
Apr 6 2019, 4:36 PM
bb accepted D1795: remove unnecessary building_collapse_large sounds.

reads correct, greps complete, unit demo works => accept

Apr 6 2019, 4:27 PM
bb added inline comments to D1806: standardized structure aura descriptions.
Apr 6 2019, 4:02 PM

Apr 5 2019

bb requested changes to D1702: GUI addon to animate objects proprieties.

As elexis mentioned the color animation would in the vanilla game be dead code, thus that shouldn't be there. Ofcourse it could be useful later, so I would propose to implement the system for the size only, but keep it extendable so the color could easily be added when required.

Apr 5 2019, 12:56 PM
bb added inline comments to D1810: Improvements to the translators credits script.
Apr 5 2019, 12:23 PM

Mar 18 2019

bb committed rP22132: seige to siege .
seige to siege
Mar 18 2019, 3:57 PM
bb closed D1797: seige → siege.
Mar 18 2019, 3:56 PM
bb accepted D1797: seige → siege.

Grepping says these are all cases of seige, so correct and complete

Mar 18 2019, 3:40 PM

Mar 17 2019

bb committed rP22129: Add "At Least" to the front of the disabledTooltips.
Add "At Least" to the front of the disabledTooltips
Mar 17 2019, 9:02 PM
bb closed D1792: X units required -> At least X units required.
Mar 17 2019, 9:02 PM
bb accepted D1792: X units required -> At least X units required.

Reads correct, checked all formation templates => accept

Mar 17 2019, 8:53 PM
bb added a comment to D1613: Improve the plural translation of the "<players> have won" string.

I get that some languages use singular for every other prime number, so to speak. But isn't exactly that the reason why we have markForPluralTranslation, so a translation can choose for which values it takes whatever form. If that isn't the case in the current code, we might have found a bug in our code. Stating the same problem more concretely: how is this particular call different from all the other markForPluralTranslation calls? or are all of them just wrong? (there are some in buildrestriction, wonderVictory, CaptureTheRelic, triggerHelper and Treasure Island)

Mar 17 2019, 8:51 PM
bb added a comment to D1613: Improve the plural translation of the "<players> have won" string.

Code should stand on itself, not referring to a phabricator revision. But isn't markForPluralTranslation designed to cover this case? So how does this solve the issue?
Furthermore markForPlural expects 3 arguments, now it only has 2.

Mar 17 2019, 6:53 PM
bb added a comment to D1613: Improve the plural translation of the "<players> have won" string.

Is that lengthy comment really required? Seems obvious from the code (or it is me who has such a language as mother tongue)

Mar 17 2019, 6:09 PM
bb added a comment to D1792: X units required -> At least X units required.

Period complaint while at it

Mar 17 2019, 4:52 PM
bb added a comment to D1791: Separate range from barracks.

Candidate != must be moved, I guess those should be in the children then...

Mar 17 2019, 4:41 PM
bb added a comment to D1791: Separate range from barracks.

GarrisonHolder: change the Max attribute in the childs, put the rest in the parent

Mar 17 2019, 4:25 PM
bb added a comment to D1791: Separate range from barracks.

That is a good point indeed, so we should be looking at which properties we can move to the military parent. Territoy, Vision, GarrsionHolder and Sound seem to be the biggest candidates

Mar 17 2019, 4:07 PM
bb added a comment to D1791: Separate range from barracks.

Can I propose to make a template_structure_military_training (or find better name) template as a parent of barracks, stable and range? That would solve the duplication of this patch and D1790

Mar 17 2019, 3:49 PM
bb committed rP22120: Change structure_defense to structure_defensive so it is consistent with the….
Change structure_defense to structure_defensive so it is consistent with the…
Mar 17 2019, 2:05 PM
bb closed D1788: rename template_structure_defense* to *defensive*.
Mar 17 2019, 2:05 PM
bb accepted D1788: rename template_structure_defense* to *defensive*.

Patch reads correct, unit demo test succeeded, grep gives translate hate=> accept

Mar 17 2019, 1:56 PM

Mar 16 2019

bb added a comment to D1788: rename template_structure_defense* to *defensive*.

Idea is ok, but patch is inclomplete: your grep doesn't seem to have found the skirmish buildings (the templates under skirmish/structures/)

Mar 16 2019, 11:25 PM
bb committed rP22118: Remove a misleading unit_fauna_decorative from the bird template.
Remove a misleading unit_fauna_decorative from the bird template
Mar 16 2019, 10:18 PM
bb closed D1787: rename template_unit_fauna_decorative to template_bird.
Mar 16 2019, 10:18 PM
bb accepted D1787: rename template_unit_fauna_decorative to template_bird.

Indeed inconsistent and misleading naming. Patch correct and complete, front doens't fall, also not in atlas

Mar 16 2019, 10:15 PM
bb committed rP22116: Nuke the misleading Structure_Defence from the wallset template name.
Nuke the misleading Structure_Defence from the wallset template name
Mar 16 2019, 10:03 PM