Page MenuHomeWildfire Games
Feed Advanced Search

Mon, Mar 18

bb committed rP22132: seige to siege .
seige to siege
Mon, Mar 18, 3:57 PM
bb closed D1797: seige → siege.
Mon, Mar 18, 3:56 PM
bb accepted D1797: seige → siege.

Grepping says these are all cases of seige, so correct and complete

Mon, Mar 18, 3:40 PM

Sun, Mar 17

bb committed rP22129: Add "At Least" to the front of the disabledTooltips.
Add "At Least" to the front of the disabledTooltips
Sun, Mar 17, 9:02 PM
bb closed D1792: X units required -> At least X units required.
Sun, Mar 17, 9:02 PM
bb accepted D1792: X units required -> At least X units required.

Reads correct, checked all formation templates => accept

Sun, Mar 17, 8:53 PM
bb added a comment to D1613: Improve the plural translation of the "<players> have won" string.

I get that some languages use singular for every other prime number, so to speak. But isn't exactly that the reason why we have markForPluralTranslation, so a translation can choose for which values it takes whatever form. If that isn't the case in the current code, we might have found a bug in our code. Stating the same problem more concretely: how is this particular call different from all the other markForPluralTranslation calls? or are all of them just wrong? (there are some in buildrestriction, wonderVictory, CaptureTheRelic, triggerHelper and Treasure Island)

Sun, Mar 17, 8:51 PM
bb added a comment to D1613: Improve the plural translation of the "<players> have won" string.

Code should stand on itself, not referring to a phabricator revision. But isn't markForPluralTranslation designed to cover this case? So how does this solve the issue?
Furthermore markForPlural expects 3 arguments, now it only has 2.

Sun, Mar 17, 6:53 PM
bb added a comment to D1613: Improve the plural translation of the "<players> have won" string.

Is that lengthy comment really required? Seems obvious from the code (or it is me who has such a language as mother tongue)

Sun, Mar 17, 6:09 PM
bb added a comment to D1792: X units required -> At least X units required.

Period complaint while at it

Sun, Mar 17, 4:52 PM
bb added a comment to D1791: Separate range from barracks.

Candidate != must be moved, I guess those should be in the children then...

Sun, Mar 17, 4:41 PM
bb added a comment to D1791: Separate range from barracks.

GarrisonHolder: change the Max attribute in the childs, put the rest in the parent

Sun, Mar 17, 4:25 PM
bb added a comment to D1791: Separate range from barracks.

That is a good point indeed, so we should be looking at which properties we can move to the military parent. Territoy, Vision, GarrsionHolder and Sound seem to be the biggest candidates

Sun, Mar 17, 4:07 PM
bb added a comment to D1791: Separate range from barracks.

Can I propose to make a template_structure_military_training (or find better name) template as a parent of barracks, stable and range? That would solve the duplication of this patch and D1790

Sun, Mar 17, 3:49 PM
bb committed rP22120: Change structure_defense to structure_defensive so it is consistent with the….
Change structure_defense to structure_defensive so it is consistent with the…
Sun, Mar 17, 2:05 PM
bb closed D1788: rename template_structure_defense* to *defensive*.
Sun, Mar 17, 2:05 PM
bb accepted D1788: rename template_structure_defense* to *defensive*.

Patch reads correct, unit demo test succeeded, grep gives translate hate=> accept

Sun, Mar 17, 1:56 PM

Sat, Mar 16

bb added a comment to D1788: rename template_structure_defense* to *defensive*.

Idea is ok, but patch is inclomplete: your grep doesn't seem to have found the skirmish buildings (the templates under skirmish/structures/)

Sat, Mar 16, 11:25 PM
bb committed rP22118: Remove a misleading unit_fauna_decorative from the bird template.
Remove a misleading unit_fauna_decorative from the bird template
Sat, Mar 16, 10:18 PM
bb closed D1787: rename template_unit_fauna_decorative to template_bird.
Sat, Mar 16, 10:18 PM
bb accepted D1787: rename template_unit_fauna_decorative to template_bird.

Indeed inconsistent and misleading naming. Patch correct and complete, front doens't fall, also not in atlas

Sat, Mar 16, 10:15 PM
bb committed rP22116: Nuke the misleading Structure_Defence from the wallset template name.
Nuke the misleading Structure_Defence from the wallset template name
Sat, Mar 16, 10:03 PM
bb closed D1733: Rename wallset template.
Sat, Mar 16, 10:03 PM
bb committed rP22115: Move the fish template under template_gaia since fish is a resource like trees….
Move the fish template under template_gaia since fish is a resource like trees…
Sat, Mar 16, 9:57 PM
bb closed D1774: Change fish parent to gaia.
Sat, Mar 16, 9:57 PM
bb accepted D1774: Change fish parent to gaia.

Game works, Atlas works changes make sense => accept

Sat, Mar 16, 9:28 PM
bb added a comment to D1774: Change fish parent to gaia.

Idea seems good.

Sat, Mar 16, 6:22 PM
bb added inline comments to D1765: Gaia templates' <Selectable> clean-up.
Sat, Mar 16, 5:52 PM
bb accepted D1543: Don't require application restart to change the pauseonfocusloss option.

The option doesn't do anything outside the in-game so I suppose in-Game is the place...

Sat, Mar 16, 5:41 PM
bb accepted D1171: Move more things in the projectile part of the Attack component.
Sat, Mar 16, 5:26 PM
bb added a comment to D1171: Move more things in the projectile part of the Attack component.

One fairly trivial change required => accept

Sat, Mar 16, 5:25 PM
bb committed rP22114: Also align the chat, refs rP22111.
Also align the chat, refs rP22111
Sat, Mar 16, 5:07 PM
bb added inline comments to D438: Change Run Speed into a Run multiplier.
Sat, Mar 16, 4:56 PM
bb added a comment to D438: Change Run Speed into a Run multiplier.

Something in the lioness changed, small rebase

Sat, Mar 16, 4:47 PM
bb added a comment to rP22111: Align the settingspanel with its background, fixing te misalignment itroduced….

Broke the mp while at it, fix incoming

Sat, Mar 16, 4:12 PM
bb committed rP22113: Fix a broken early return from rP21378.
Fix a broken early return from rP21378
Sat, Mar 16, 3:40 PM
bb added a comment to rP21378: Allow units to be positioned with freehand placement.

@smiley: what would you think a "toFixed" would do on a vector? What we wanted to achieve is reducing the size of the command.txt for positioning units, thus dropping the precision after the 3rd decimal (as who cares about that?). To avoid duplication for any further such request a toFixed was added in the vector file. Regarding your example: if you use toFixed you expect a string, thus + gets a certain definition, so I don't see anything wrong....

Sat, Mar 16, 3:36 PM
bb requested verification of rP21474: Implement combine victory conditions.
Sat, Mar 16, 3:21 PM
bb committed rP22112: Add autostart conquest default description to readme.txt and add endless….
Add autostart conquest default description to readme.txt and add endless…
Sat, Mar 16, 3:20 PM
bb requested verification of rP21957: Only update the gamesetup settings panel position when it actually changes..
Sat, Mar 16, 3:16 PM
bb committed rP22111: Align the settingspanel with its background, fixing te misalignment itroduced….
Align the settingspanel with its background, fixing te misalignment itroduced…
Sat, Mar 16, 3:15 PM
bb closed D1755: Fix line misaligment in gamesetup settings..
Sat, Mar 16, 3:15 PM
bb accepted D1755: Fix line misaligment in gamesetup settings..

The horizontal size indeed is computed in js, since that size can change when you click on another tab, however the vertical size is the same always so coded in the xml. What went wrong in the initial slide panel commit (so it's not you who broke things nani, I did) is that the xml value or the background and front panel got different value. This was then masked by the ontick, but when that was removed, the real bug came out. However notice that the bug only happens when the panel width is maximal: in a small window everything is just aligned (Probably the reason I didn't find it....).

Sat, Mar 16, 2:32 PM

Jan 19 2019

elexis awarded rP21957: Only update the gamesetup settings panel position when it actually changes. a Manufacturing Defect? token.
Jan 19 2019, 11:03 PM

Jan 6 2019

bb added a comment to D1732: Wondervictory entity rename.

well from a ownershipchange we can't see if it will be a rename, so when the new ent is brought up, we don't know it actually replaces another (one could change the entitylimits and allow two wonders, so an owners check wouldn't work), so the new timer will always be activated, which afterwards needs to be removed. Also from the destroy we don't know if it is a rename (one could very well create and destroy different wonders at the same turn), so we have to do it with the ent rename.

Jan 6 2019, 2:27 PM

Jan 5 2019

bb added inline comments to D1727: Update auras when a formation member renames.
Jan 5 2019, 11:25 PM
bb accepted D1733: Rename wallset template.

grepped for completeness, agreeing on the change, translators will hate
(note to self: be careful with file move)

Jan 5 2019, 11:01 PM
bb requested verification of rP21378: Allow units to be positioned with freehand placement.

should be fixed now: rP22030

Jan 5 2019, 9:47 PM
bb committed rP22030: Fix missing assignment from rP21378.
Fix missing assignment from rP21378
Jan 5 2019, 9:47 PM
bb closed D1656: Bugfix rP21378.
Jan 5 2019, 9:46 PM
bb accepted D1656: Bugfix rP21378.

see revision, proposed the same

Jan 5 2019, 9:29 PM
bb created D1732: Wondervictory entity rename.
Jan 5 2019, 8:54 PM
bb requested changes to D1702: GUI addon to animate objects proprieties..
Jan 5 2019, 12:12 AM
bb added a comment to D1702: GUI addon to animate objects proprieties..

I guess every gui page should be able to access this file, also the mod-selection, thus mods/mod/gui/common should be the correct place

Jan 5 2019, 12:11 AM

Jan 4 2019

bb added a comment to D1537: playername → player name.

Isn't that what I say too? (notice the capital letter N)

Jan 4 2019, 9:57 PM
bb committed rP22020: Improve fishing net description.
Improve fishing net description
Jan 4 2019, 9:51 PM
bb closed D1549: Slightly rephrase the description of fishing nets.
Jan 4 2019, 9:51 PM
bb added a comment to D1727: Update auras when a formation member renames.

Don't be fooled by those two extra calls D997 tries to do, 1 of the function got removed by rP21243, and the other seems a phab bug

Jan 4 2019, 9:46 PM
bb committed rP22019: Handle entity renames in regicide.
Handle entity renames in regicide
Jan 4 2019, 9:09 PM
bb closed D1694: Handle entity renaming properly in regicide mode.
Jan 4 2019, 9:09 PM
bb accepted D1694: Handle entity renaming properly in regicide mode.

Tested against DE, correctness forces me to press accept

Jan 4 2019, 9:00 PM
bb accepted D1690: Fix Danubius ownershipchange subscription following rP21445.

Accepting because it is correct and complete for Danubius, but while looking at D1694, I guess the same bug can happen in (most of) the victory conditions, and potentially the other trigger scripts too (SotF, JB etc.)

Jan 4 2019, 4:00 PM
bb added a comment to D1694: Handle entity renaming properly in regicide mode.

Excuses for not replying to previous comments, and making you do an extra iteration...

Jan 4 2019, 3:53 PM

Jan 3 2019

bb added a comment to D1727: Update auras when a formation member renames.

reffing D997

Jan 3 2019, 9:32 PM

Dec 27 2018

bb added inline comments to D1386: Allied chat opens with t bug on linux.
Dec 27 2018, 3:00 PM
bb added a comment to D1693: Avoid unnecessary updates from updateSettingsPanelPosition.

Even better: the error wasn't introduced there

Dec 27 2018, 12:51 PM

Dec 26 2018

bb committed rP21957: Only update the gamesetup settings panel position when it actually changes..
Only update the gamesetup settings panel position when it actually changes.
Dec 26 2018, 11:35 PM
bb closed D1693: Avoid unnecessary updates from updateSettingsPanelPosition.
Dec 26 2018, 11:35 PM
bb accepted D1693: Avoid unnecessary updates from updateSettingsPanelPosition.

That should work

Dec 26 2018, 11:30 PM
bb requested changes to D1693: Avoid unnecessary updates from updateSettingsPanelPosition.

While committing thought of the programming.json: @nani please put your nick and if you want name in there and upload in a new patch on the revision so you are credited

Dec 26 2018, 10:16 PM
bb added a comment to D1693: Avoid unnecessary updates from updateSettingsPanelPosition.

introduced in rP20945 (code got shuffled a bit afterwards)

Dec 26 2018, 9:37 PM
bb accepted D1693: Avoid unnecessary updates from updateSettingsPanelPosition.

And here the guy to blame :S, can't even put off the blame by saying it was copied from the main-menu or ingame menu...

Dec 26 2018, 9:20 PM
bb updated the diff for D1469: Conquest structures fails on nomad.

fix the edgy case when only nonConquestCritical structures/units remain

Dec 26 2018, 9:05 PM
bb added inline comments to D1690: Fix Danubius ownershipchange subscription following rP21445.
Dec 26 2018, 5:58 PM
bb added a comment to D1463: Unit for summary charts time axis.

Was about to commit it, but the time displayed is minutes : seconds, so shouldn't the unit be something like minutes:ss?

Dec 26 2018, 5:52 PM
bb added a comment to D1626: -ConquestCritical clear-up.

15 removed cases, 10 added ones (if counting holds, the 15 goes down to 13 given the structure_defense_* comment)

Dec 26 2018, 5:42 PM
bb added inline comments to D1694: Handle entity renaming properly in regicide mode.
Dec 26 2018, 5:31 PM
bb added inline comments to rP21378: Allow units to be positioned with freehand placement.
Dec 26 2018, 5:02 PM

Nov 24 2018

bb added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

Testing on fedora 28: patch doesn't solve the segfault, with or without the patch both segfault on lobby join. If required I could get access to a fedora 29 machine for testing.

Nov 24 2018, 3:08 PM

Oct 17 2018

bb added inline comments to rP21378: Allow units to be positioned with freehand placement.
Oct 17 2018, 7:58 PM

Aug 5 2018

bb updated the diff for D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport).

Don't use a common/ global outside common/

Aug 5 2018, 5:53 PM

Aug 3 2018

bb updated the test plan for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Aug 3 2018, 12:53 AM
bb added a parent revision for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy: D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport).
Aug 3 2018, 12:52 AM
bb added a child revision for D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport): D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Aug 3 2018, 12:52 AM
bb updated the diff for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.

Reflect the duplication avoid

Aug 3 2018, 12:52 AM
bb created D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport).
Aug 3 2018, 12:52 AM

Jul 30 2018

bb updated the diff for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.

fix an elexis' irc comment

Jul 30 2018, 2:34 PM

Jul 26 2018

bb accepted D1535: Remove quotes made unnecessary by capitalization.

complete as in all quotes around I and II are gone => accept

Jul 26 2018, 9:42 PM
bb accepted D1527: rally-point → rally point.

If that is so => accept

Jul 26 2018, 9:41 PM
bb added inline comments to D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 4:40 PM
bb updated the diff for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 4:40 PM
bb added inline comments to D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 1:32 AM
bb updated the test plan for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 1:17 AM
bb created D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 1:16 AM

Jul 16 2018

bb added a comment to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.
In D1590#63984, @Stan wrote:

What if as per article 18 one says he doesn't want his data processed for ratings. Do we delete the account ? Or do we force him not to go on rated games ? He might want to play with a fixed rating or no rating at all with player who want to get rated. How does it go

Which clause of art 18.1 applies?

Jul 16 2018, 6:39 PM
bb added inline comments to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.
Jul 16 2018, 5:19 PM

Jul 9 2018

bb added a comment to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.

Some digging in the GDPR leads me to two concerns (I am in no position to say if these are fixed everything is ok but would doubt if there are more problems)

Jul 9 2018, 11:29 PM

Jul 2 2018

bb added a comment to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.

Read the code and comments, but as having very limited knowledge about these matter (nor an urgent will to become an expert), can't say anything about the completeness.

Jul 2 2018, 9:53 PM
bb added a comment to rP21441: Create winning teams for relic and wonder victory instead of letting all allies….

Objectives should be as straightforward as possible, as simple as possible, so I'd rather have went with only the first rule as was the case before (which doesn't mean that there might be a simple alternative satisfying more).

The objective is straightforward now, as the timer is reset on every event that the "winning team" changes

If my allies were defeated or declared war on me, that shouldn't make me lose the victory timer.

Certainly agree for lms, but in an allied victory game loosing a team member for me is enough reason to say the "team" is defeated. But as there is a new team meeting the victory conditions, a new timer is set for that team.

Jul 2 2018, 9:32 PM

Jul 1 2018

bb requested verification of rP21441: Create winning teams for relic and wonder victory instead of letting all allies….

The trick here is defining when the counter needs to be reset, to me defeating a player defending a wonder is enough reason to reset the countdown, one can argue differently however. But as the case is specifically named in the commit message Reset counters on playerDefeat requesting verification, further discussion should be in a trac ticket imo.

Jul 1 2018, 11:34 PM