Page MenuHomeWildfire Games
Feed Advanced Search

Today

elexis added inline comments to rP22909: Fix hotkey events synching with hotkey state..
Sun, Sep 15, 3:23 PM
elexis added a comment to rP22909: Fix hotkey events synching with hotkey state..

(I don't remember what was up with that hotkey behavior)

Sun, Sep 15, 3:02 PM
elexis committed rP22903: Fix glooxwrapper::Message::when() memory leak in rP16507, refs #3156..
Fix glooxwrapper::Message::when() memory leak in rP16507, refs #3156.
Sun, Sep 15, 12:29 PM
elexis closed D2291: Fix glooxwrapper Message::when() leak in rP16507.
Sun, Sep 15, 12:29 PM
elexis added a comment to D2151: Use "setStringTags"-function more often..

Rest looks correct.

Sun, Sep 15, 12:27 PM
elexis retitled D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851 from Fix structree / history civ button rebase error in D2240 / rP22854 to Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.
Sun, Sep 15, 11:20 AM
elexis updated the diff for D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.

The dialog was reopened because the global hotkeys from rP22851 also trigger upon hotkey release -.-
Rename the hotkeys that toggle consistently from "show" to "toggle" and from "window" or "page" to "dialog" to distinguish it from the windows that are not dialogs (i.e. not opened on top of other pages).
Summary page should not continue to the next page for a "toggle dialog" hotkey (since entering a different page is not the task description of toggling a dialog).

Sun, Sep 15, 11:18 AM

Yesterday

elexis updated the diff for D1676: Embed zpl-c's version of enet library.

Rebase

Sat, Sep 14, 9:23 PM
elexis added inline comments to D1676: Embed zpl-c's version of enet library.
Sat, Sep 14, 9:23 PM
elexis added inline comments to D2292: Remove GUI object property values redundant with the default, and duplicate default style.
Sat, Sep 14, 7:32 PM
elexis added inline comments to rP11976: Recenter GUI and update unit details section..
Sat, Sep 14, 7:32 PM
elexis created D2292: Remove GUI object property values redundant with the default, and duplicate default style.
Sat, Sep 14, 7:28 PM
elexis created D2291: Fix glooxwrapper Message::when() leak in rP16507.
Sat, Sep 14, 6:49 PM
elexis added inline comments to rP16507: Fix a number of issues related to historical messages and initial join in the….
Sat, Sep 14, 6:28 PM
elexis added inline comments to D2290: Unify load game and savegame screen.
Sat, Sep 14, 6:17 PM
elexis added a comment to D2290: Unify load game and savegame screen.

There is the question how this will scale in the future in case the two dialogs receive different new features.

Sat, Sep 14, 6:02 PM
elexis updated the summary of D2290: Unify load game and savegame screen.
Sat, Sep 14, 5:45 PM
elexis created D2290: Unify load game and savegame screen.
Sat, Sep 14, 5:43 PM
elexis committed rP22900: Allow JS GUI pages to find out if the game is running..
Allow JS GUI pages to find out if the game is running.
Sat, Sep 14, 5:34 PM
elexis closed D2289: Allow JS pages to find out if the game is running.
Sat, Sep 14, 5:34 PM
elexis created D2289: Allow JS pages to find out if the game is running.
Sat, Sep 14, 5:17 PM
elexis added inline comments to D2151: Use "setStringTags"-function more often..
Sat, Sep 14, 2:45 PM
elexis added inline comments to D284: lobby: Display observer count in gameslist.
Sat, Sep 14, 2:31 PM
elexis added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sat, Sep 14, 2:21 PM
elexis updated the diff for D1667: Lobby ScriptConversion to remove stanza property name hardcoding and duplication.

Everything except JS changes.

Sat, Sep 14, 1:54 PM
elexis added a comment to D1667: Lobby ScriptConversion to remove stanza property name hardcoding and duplication.

Since this guarantee the properties to exist anymore (wicked client inserting prepared game), the JS code needs to account for that, meh.
Still seems better to do that in JS than hardcoding all JS properties in C++.
Each time JS side wanted to add a new property, it had to change C++ code.
Mods would be allowed to pass their own JS, without having to hijack one of the existing properties.
(The mods can already send the custom properties, they just can't be received solely due to the C++ hardcoding.)
For example maxnbp in the afore mentioned rP18534.

Sat, Sep 14, 1:50 PM
elexis added inline comments to D2288: XmppClient gloox message subtype specific JS message handlers.
Sat, Sep 14, 12:01 PM
elexis created D2288: XmppClient gloox message subtype specific JS message handlers.
Sat, Sep 14, 11:57 AM
elexis added inline comments to D1918: Move pathfinder work to a worker (not yet threaded - D14 prerequisite).
Sat, Sep 14, 10:49 AM

Fri, Sep 13

elexis committed rP22898: Implement glooxwrapper::MUCRoom argument for muc event handlers..
Implement glooxwrapper::MUCRoom argument for muc event handlers.
Fri, Sep 13, 5:24 PM
elexis closed D2287: Support glooxwrapper::MUCRoom for muc events.
Fri, Sep 13, 5:24 PM
elexis removed a reviewer for D2287: Support glooxwrapper::MUCRoom for muc events: Itms.

Apparently it's not a good idea to start svn commit, start typing a commit message, then deciding to run another arc diff --update, that had uploaded more than 1000 files for some reason.

Fri, Sep 13, 5:09 PM
elexis updated the diff for D2287: Support glooxwrapper::MUCRoom for muc events.

Don't run arc diff --update while svn is locked.

Fri, Sep 13, 5:02 PM
elexis updated the diff for D2287: Support glooxwrapper::MUCRoom for muc events.

Remove const to allow setNick and alike.

Fri, Sep 13, 5:01 PM
elexis updated the test plan for D2287: Support glooxwrapper::MUCRoom for muc events.
Fri, Sep 13, 4:52 PM
elexis created D2287: Support glooxwrapper::MUCRoom for muc events.
Fri, Sep 13, 4:42 PM
elexis added a comment to D2272: Translate XmppClient::TLSErrorToString.

If you fail to install pology because there are no repositories available, compare this piece of code against the other translated strings, and in case this is committed, check the next autobuild committed pology files to verify.

Check:
https://code.wildfiregames.com/rP22896#change-yysGWEA7AmCF

Fri, Sep 13, 11:58 AM
elexis added a comment to D2261: lobby,gamesetup: Fix remaining ESLint warnings.

Something like that:

var g_RoleMessages = {
	"visitor": (me, oldrole) =>
		me ?
			translate("You have been muted.") :
			translate("%(nick)s has been muted."),
	"moderator":
		 (me, oldrole) =>
			translate("You are now a moderator.") :
			translate("%(nick)s is now a moderator.") :
	},
	"participant":
		(me, oldrole) =>
			oldrole == "visitor" ?
				translate("You have been unmuted.") :
				translate("%(nick)s has been unmuted.") :
			me ?
				translate("You are not a moderator anymore.") :
				translate("%(nick)s is not a moderator anymore.")
	}
};

But I suppose it still complains about the last object, but indenting there would be less painful than here.

Fri, Sep 13, 11:57 AM
elexis updated the diff for D1667: Lobby ScriptConversion to remove stanza property name hardcoding and duplication.

Rebase following rP22891 and 2019.

Fri, Sep 13, 4:05 AM
elexis committed rP22894: Use ScriptInterface::CreateObject for ToJSVal<CColor>, and for ToJSVal<Grid<u8>….
Use ScriptInterface::CreateObject for ToJSVal<CColor>, and for ToJSVal<Grid<u8>…
Fri, Sep 13, 2:57 AM
elexis closed D2128: Use CreateObject in EngineScriptConversions.
Fri, Sep 13, 2:57 AM
elexis updated the diff for D2128: Use CreateObject in EngineScriptConversions.
../../../source/scriptinterface/ScriptConversions.cpp:292:120: error: parameter 'val' includes reference to array of unknown bound 'const wchar_t []'
 template<> void ScriptInterface::ToJSVal<wchar_t[N]>(JSContext* cx, JS::MutableHandleValue ret, const wchar_t (&val)[N]) \
../../../source/scriptinterface/ScriptConversions.cpp:301:1: note: in expansion of macro 'TOJSVAL_CHAR'
 TOJSVAL_CHAR()
 ^
Fri, Sep 13, 2:23 AM
elexis updated the diff for D2128: Use CreateObject in EngineScriptConversions.

Rebase following lobby excursion.

Fri, Sep 13, 1:34 AM
elexis added a comment to D284: lobby: Display observer count in gameslist.

Keep translate() call inline (this means it isn't cached, but I guess that's fine?).

If you look at the definition of that function you see it's cached.
Theres also a cache in C++.
I dont remember what this referred to, but the python extract script needs either translate("string") or markForTranslation("string"), otherwise will not extract the string (especially it cant evaluate expressions).

Fri, Sep 13, 12:17 AM

Thu, Sep 12

elexis added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Thu, Sep 12, 11:59 PM
elexis added inline comments to D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Thu, Sep 12, 11:45 PM
elexis committed rP22893: Enable no-caller and no-irregular-whitespace in ESLint, refs #5524..
Enable no-caller and no-irregular-whitespace in ESLint, refs #5524.
Thu, Sep 12, 11:37 PM
elexis closed D2237: Linting: Enable no-caller and no-irregular-whitespace in ESLint.
Thu, Sep 12, 11:36 PM
elexis accepted D2237: Linting: Enable no-caller and no-irregular-whitespace in ESLint.

When running ESLint over the whole of data/binaries/ with eslint.json reduced to just these new keys, it finds zero existing violations of this rule.

I did not verify this, but from my experience you are accurate about these things.

Thu, Sep 12, 11:34 PM
elexis added inline comments to D2151: Use "setStringTags"-function more often..
Thu, Sep 12, 10:14 PM
elexis committed rP22892: Use all three color channels when loading heightmaps following rP21113, refs….
Use all three color channels when loading heightmaps following rP21113, refs…
Thu, Sep 12, 9:33 PM
elexis closed D1816: Use all three color channels when loading heightmaps following rP21113.
Thu, Sep 12, 9:32 PM
elexis requested verification of rP21113: Allow random map scripts to load heightmap image files, fixes #5018..
Thu, Sep 12, 9:31 PM
elexis accepted D1816: Use all three color channels when loading heightmaps following rP21113.

As mentioned in https://code.wildfiregames.com/rP21113#inline-2823, I can only imagine that this was a debug line that I left over that wasn't noticed because the code produces the same result for our heightmap data.

Thu, Sep 12, 9:19 PM
elexis committed rP22891: Fix missing wstring_from_utf8 for multi-user-chat messages and translated….
Fix missing wstring_from_utf8 for multi-user-chat messages and translated…
Thu, Sep 12, 7:24 PM
elexis closed D2271: Fix lobby utf8 conversion following rP22856 / D2264.
Thu, Sep 12, 7:24 PM
elexis added a comment to D2271: Fix lobby utf8 conversion following rP22856 / D2264.

So I found an UTF8 dependent STUN segfault described in #5587 while testing this diff. I can reproduce it in my a23 copy, and svn without this commit. Others reported no segfault but that it simply doesnt connect after nickchange.
It seems all the JIDs used in the XmppClient misss proper UTF8 encoding / decoding.
And that issue should be orthogonal to this patch, since this patch only changes the CreateGUIMessage calls and PlayerMap, but nothing relating to the STUN stack or hostJID member.

Thu, Sep 12, 6:20 PM
elexis updated the diff for D2271: Fix lobby utf8 conversion following rP22856 / D2264.

I don't even know what I updated, but it's better, and I found #5587.

Thu, Sep 12, 5:01 PM
elexis updated the test plan for D2271: Fix lobby utf8 conversion following rP22856 / D2264.
Thu, Sep 12, 4:01 PM
elexis abandoned D1668: Rely on copy-elision / return-value-optimization for lobby string getters.
In D1668#66513, @elexis wrote:

Smart, but the (N)RVO isn't guaranteed. Only since C++17.

https://de.cppreference.com/w/cpp/language/copy_elision looks more like C++11, only some other features C++17?

Yeah, compilers started optimize these cases a long time ago. But there're many nuances.

Thu, Sep 12, 12:06 PM
elexis updated the diff for D2284: Actually dont compile lobby code if building --without-lobby.

Remove any config2 from source/lobby/ since premake should exclude it already.
Update JS functions to account for the removed HasXmppClient function.

Thu, Sep 12, 11:38 AM
elexis retitled D2284: Actually dont compile lobby code if building --without-lobby from Actually dont compile lobby classes if building --without-lobby to Actually dont compile lobby code if building --without-lobby.
Thu, Sep 12, 11:17 AM
elexis updated the summary of D2284: Actually dont compile lobby code if building --without-lobby.
Thu, Sep 12, 11:12 AM
elexis added a comment to D2284: Actually dont compile lobby code if building --without-lobby.

A backup of the patch where the macro is present in every source/lobby/ file, which ought to be unneeded since premake excludes the folder due to the diff

.

Thu, Sep 12, 11:11 AM
elexis added inline comments to D2271: Fix lobby utf8 conversion following rP22856 / D2264.
Thu, Sep 12, 11:01 AM
elexis added a comment to D2199: Add RPC interface for Reinforcement Learning.

See discussion on http://irclogs.wildfiregames.com/2019-09/2019-09-11-QuakeNet-%230ad-dev.log

Thu, Sep 12, 10:19 AM

Wed, Sep 11

elexis added a comment to D2284: Actually dont compile lobby code if building --without-lobby.

flag is fraud, because most of the lobby code (especially XmppClient and half of the JSInterface) are still compiled, the flag only unsubscribes few JSinterface functions.

So that is false in fact.
The XmppClient.cpp has not been compiled if --without-lobby was passed, because the source directories for the lobby project if --without-lobby was enabled excluded the lobby/ folder but included the lobby/scripting/ folder.
It still seems correct to exclude all lobby code (including IXmppClient.cpp), since that is what the two words --without-lobby mean, what the user may reasonably expect.

Wed, Sep 11, 11:30 PM
elexis updated the summary of D2284: Actually dont compile lobby code if building --without-lobby.
Wed, Sep 11, 11:23 PM
elexis added a comment to D2162: Do not stack fleeing orders..

From the lobby:
(07:58:44 PM) faction02: there is something different with women but I can't say exactly what yet
(07:59:36 PM) faction02: it seems that when they run, they can't be catched
(08:00:00 PM) faction02: they keep running even when they don't see who is running after them I think

Wed, Sep 11, 8:10 PM
elexis updated the diff for D2284: Actually dont compile lobby code if building --without-lobby.

Have precompiled.h prior to #if CONFIG2_LOBBY as proposed by Angen on #0ad-dev.

Wed, Sep 11, 7:52 PM
elexis updated the diff for D2284: Actually dont compile lobby code if building --without-lobby.

Fix build without pch.

Wed, Sep 11, 7:09 PM
elexis updated the summary of D2284: Actually dont compile lobby code if building --without-lobby.
Wed, Sep 11, 6:55 PM
elexis added a comment to rP14113: Fix building with --without-lobby. Fixes #2249..

Comment

Wed, Sep 11, 6:55 PM
elexis updated the test plan for D2284: Actually dont compile lobby code if building --without-lobby.
Wed, Sep 11, 6:49 PM
elexis updated the diff for D2284: Actually dont compile lobby code if building --without-lobby.

Drop StunClient thing change.

Wed, Sep 11, 6:23 PM
elexis added inline comments to D2284: Actually dont compile lobby code if building --without-lobby.
Wed, Sep 11, 6:11 PM
elexis created D2284: Actually dont compile lobby code if building --without-lobby.
Wed, Sep 11, 5:58 PM
elexis updated the diff for D2271: Fix lobby utf8 conversion following rP22856 / D2264.

Rebase following 22887, 22888

Wed, Sep 11, 3:07 PM
elexis added inline comments to D2271: Fix lobby utf8 conversion following rP22856 / D2264.
Wed, Sep 11, 3:07 PM
elexis committed rP22888: Fix lobby playerlist rebuild following presence update message removal in….
Fix lobby playerlist rebuild following presence update message removal in…
Wed, Sep 11, 1:51 PM
elexis closed D2283: Fix lobby playerlist rebuild following presence update message removal in rP22855/D2265.
Wed, Sep 11, 1:51 PM
elexis created D2283: Fix lobby playerlist rebuild following presence update message removal in rP22855/D2265.
Wed, Sep 11, 1:15 PM
elexis committed rP22887: Fix historic lobby kick messages following arbitrary CreateGUIMessage arguments….
Fix historic lobby kick messages following arbitrary CreateGUIMessage arguments…
Wed, Sep 11, 12:15 PM
elexis closed D2282: Fix lobby GUI Kick messages historic property following arbitrary CreateGUIMessage arguments in rP22856/D2264.
Wed, Sep 11, 12:15 PM
elexis updated the summary of D2282: Fix lobby GUI Kick messages historic property following arbitrary CreateGUIMessage arguments in rP22856/D2264.
Wed, Sep 11, 12:05 PM
elexis added inline comments to rP22856: Support creating lobby GUI messages with arbitrary arguments instead of forcing….
Wed, Sep 11, 11:59 AM
elexis created D2282: Fix lobby GUI Kick messages historic property following arbitrary CreateGUIMessage arguments in rP22856/D2264.
Wed, Sep 11, 11:56 AM
elexis added inline comments to D2271: Fix lobby utf8 conversion following rP22856 / D2264.
Wed, Sep 11, 10:37 AM
elexis added a comment to D2278: Fix uninitialized XmppClient members.
In D2278#94794, @Stan wrote:

Add "This may be because of one of the following reasons:" and a few bullet points and it's solved.

Wed, Sep 11, 10:24 AM
elexis added a comment to D2271: Fix lobby utf8 conversion following rP22856 / D2264.

m_Ratingtype:
There's also the question whether glooxwrapper::string is the best type for m_Rating, since it's a number in the average case. But:

  • It can be empty string if Ratings is offline
  • JS code will/would have to be changed, which I would prfer to not do in the same diff (after all this is a regression fix and already changing something)
Wed, Sep 11, 10:11 AM
elexis updated the diff for D2271: Fix lobby utf8 conversion following rP22856 / D2264.

https://www.youtube.com/watch?v=UZDcDJda3qg

Wed, Sep 11, 10:08 AM
elexis added a comment to D2278: Fix uninitialized XmppClient members.

(Here another example disconnect msg by nani that really looks like the strings are random.)

Wed, Sep 11, 10:04 AM

Tue, Sep 10

elexis added a comment to D1781: Fix lobby chat performance issue..

Other than the problem that the entire chattext is rebuilt instead of partially rebuilt (only appended line built), there is another effect, similar to the one in #3386:
If there are N different GUI messages in the queue (that will then be pulled on the same onTick), there will be N updates to that GUIObject, but the GUI object only needs to be updated once per frame.
With this patch, only the N addList consecutive entries are built, so that's good.

Tue, Sep 10, 9:34 PM
elexis retitled D1781: Fix lobby chat performance issue. from Fix chat performance issue. to Fix lobby chat performance issue..
Tue, Sep 10, 9:21 PM
elexis added a comment to D2271: Fix lobby utf8 conversion following rP22856 / D2264.

The player struct was mentioned during the quick talk with Josh on http://irclogs.wildfiregames.com/2019-09/2019-09-06-QuakeNet-%230ad-dev.log

22:46 < elexis> std::map<std::string, std::vector<std::string> > m_PlayerMap;
22:46 < elexis> I guess that might be more readable as a struct intead of string vector
22:46 < Josh`> Maybe add a flag "sentToGui" or something alongside each player in m_PlayerMap
22:46 < Josh`> Yeah
Tue, Sep 10, 2:39 PM
elexis added a comment to D2197: Add support for recording replay metadata when in nonvisual mode.

This patch should be good to go, but the problem is that it depends on Freezing that initattributes, at least it sounds very fragile if we already had many previous code that changed the simulation state unintentionally which was fixed by freezing.
So the patch depends on D2213, and for that one I dont know yet (A) if its a good idea (and even correct) to remove the second persistentrooted value, and (B) at which place to call the freeze function.
(I'm not so familiar with that code either, so it's something new to learn for any of us looking at that.)
It's actually quite annoying to not have this patch committed, because it fixes an important defect (removing g_Game && g_Game->IsGameStarted() && !g_Game->IsVisualReplay() && g_AtlasGameLoop && !g_AtlasGameLoop->running && CRenderer::IsInitialised())).

Tue, Sep 10, 11:45 AM
elexis added inline comments to D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.
Tue, Sep 10, 11:28 AM
elexis added a comment to D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.

Don't worry, I was more wondering why you said that the cache erasure fixed it. Also why I said that I couldnt reproduce. Also why I was sure that I had tested this. I hope space time continuum isn't broken x)
https://wildfiregames.com/forum/index.php?/topic/26274-breaking-changes-following-22379/page/2/&tab=comments#comment-384668

Tue, Sep 10, 11:26 AM
elexis added a comment to rP22878: Fix issues with MakeGoalReachable when the goal wasn't reachable following….

Fixed issue reported by faction02 in a forum PM and analyzed by Freagarach, thank you!!
https://wildfiregames.com/forum/index.php?/messenger/10014/

Tue, Sep 10, 11:20 AM
elexis updated the summary of D2277: Fix issues with MakeGoalReachable when the goal wasn't reachable following D1882/rP22817.
Tue, Sep 10, 11:20 AM