Page MenuHomeWildfire Games
Feed Advanced Search

Sep 10 2019

elexis updated the diff for D2271: Fix lobby utf8 conversion following rP22856 / D2264.

Update following rP22880, rP22875.

Sep 10 2019, 12:11 AM

Sep 9 2019

elexis committed rP22880: Pass XmppClient CertificateErrorToString independent of ConnectionErrorToString….
Pass XmppClient CertificateErrorToString independent of ConnectionErrorToString…
Sep 9 2019, 11:27 PM
elexis closed D2274: Pass lobby certificate status as a separate value and allow Xmpp error strings to become static.
Sep 9 2019, 11:27 PM
elexis committed rP22879: Fix missing XmppClient m_certStatus and m_PresenceUpdate member initialization….
Fix missing XmppClient m_certStatus and m_PresenceUpdate member initialization…
Sep 9 2019, 10:50 PM
elexis closed D2278: Fix uninitialized XmppClient members.
Sep 9 2019, 10:50 PM
elexis added inline comments to D2278: Fix uninitialized XmppClient members.
Sep 9 2019, 10:44 PM
elexis added a comment to D2278: Fix uninitialized XmppClient members.

I've tested more, I surrender.

Sep 9 2019, 10:40 PM
elexis updated the summary of D2278: Fix uninitialized XmppClient members.
Sep 9 2019, 10:38 PM
elexis added a comment to P170 Conditional jump or move depends on uninitialised value IGUIObject::SendEvent IXmppClient::create JS_CallFunctionValue.

Nope, that still doesn't fix the conditional jump.

Sep 9 2019, 10:20 PM
elexis updated the summary of D2278: Fix uninitialized XmppClient members.
Sep 9 2019, 9:43 PM
elexis created D2278: Fix uninitialized XmppClient members.
Sep 9 2019, 9:40 PM
elexis added a comment to P170 Conditional jump or move depends on uninitialised value IGUIObject::SendEvent IXmppClient::create JS_CallFunctionValue.

It seems this is my fault for not initializing XmppClient primitive members m_certStatus and m_PresenceUpdate in rP21901 and rP22855...
Good news is that valgrind reveals stupidity systematically.
The conditional jump warning is gone after initializing all members of XmppClient properly.

Sep 9 2019, 9:31 PM
elexis updated subscribers of rP21901: Display lobby TLS certificate verification errors from gloox, refs #4705..
Sep 9 2019, 9:27 PM
elexis updated the diff for D2274: Pass lobby certificate status as a separate value and allow Xmpp error strings to become static.

Missing file, also init m_CertStatus

Sep 9 2019, 8:56 PM
elexis updated the test plan for D2274: Pass lobby certificate status as a separate value and allow Xmpp error strings to become static.
Sep 9 2019, 8:55 PM
elexis committed rP22876: Beautify civinfo page with bullet points..
Beautify civinfo page with bullet points.
Sep 9 2019, 8:41 PM
elexis closed D2221: [gui] use bullets in civ history window.
Sep 9 2019, 8:41 PM
elexis added a comment to P170 Conditional jump or move depends on uninitialised value IGUIObject::SendEvent IXmppClient::create JS_CallFunctionValue.

After commenting out the create XmppClient call, the conditional jump warning is gone.

Sep 9 2019, 8:35 PM
elexis created P176 gloox::DNS::resolve leak.
Sep 9 2019, 8:19 PM
elexis added a comment to P175 CTextRenderer::Render() possible leak.

Affected line:

glDrawElements(GL_TRIANGLES, indexes.size(), GL_UNSIGNED_SHORT, &indexes[0]);

Sep 9 2019, 8:07 PM
elexis created P175 CTextRenderer::Render() possible leak.
Sep 9 2019, 8:07 PM
elexis created P174 CTextureManagerImpl::CTextureManagerImpl leak.
Sep 9 2019, 8:05 PM
elexis added a comment to P170 Conditional jump or move depends on uninitialised value IGUIObject::SendEvent IXmppClient::create JS_CallFunctionValue.

Affected JS_CallFunctionValue in IGUIObject::ScriptEvent:

	JS::AutoValueVector paramData(cx);
	paramData.append(mouse);
	JS::RootedObject obj(cx, GetJSObject());
	JS::RootedValue handlerVal(cx, JS::ObjectValue(*it->second));
	JS::RootedValue result(cx, JS::UndefinedValue());
	if (!JS_CallFunctionValue(cx, obj, handlerVal, paramData, &result))
	{
		// We have no way to propagate the script exception, so just ignore it
		// and hope the caller checks JS_IsExceptionPending
	}
Sep 9 2019, 8:03 PM
elexis added a comment to P173 GUIRenderer::Draw(DrawCalls& Calls, float Z) possible leak.

The affected line in GUIRenderer::Draw is glDrawArrays(GL_TRIANGLES, 0, 6);.

Sep 9 2019, 8:02 PM
elexis created P173 GUIRenderer::Draw(DrawCalls& Calls, float Z) possible leak.
Sep 9 2019, 7:59 PM
elexis added a comment to P172 CGUI::Draw() (CGUI.cpp:347) possible leak glClear(GL_DEPTH_BUFFER_BIT);.

The affected line is glClear(GL_DEPTH_BUFFER_BIT); from rP666, number of the beast:

Sep 9 2019, 7:54 PM
elexis created P172 CGUI::Draw() (CGUI.cpp:347) possible leak glClear(GL_DEPTH_BUFFER_BIT);.
Sep 9 2019, 7:52 PM
elexis changed the visibility for P170 Conditional jump or move depends on uninitialised value IGUIObject::SendEvent IXmppClient::create JS_CallFunctionValue.
Sep 9 2019, 7:29 PM
elexis changed the visibility for P171 HWDetect.cpp:502 ReportGLLimits INTEGER(SAMPLE_BUFFERS); possible memory leak.
Sep 9 2019, 7:29 PM
elexis created P171 HWDetect.cpp:502 ReportGLLimits INTEGER(SAMPLE_BUFFERS); possible memory leak.
Sep 9 2019, 7:29 PM
elexis created P170 Conditional jump or move depends on uninitialised value IGUIObject::SendEvent IXmppClient::create JS_CallFunctionValue.
Sep 9 2019, 7:08 PM
elexis created D2274: Pass lobby certificate status as a separate value and allow Xmpp error strings to become static.
Sep 9 2019, 6:14 PM
elexis created D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.
Sep 9 2019, 5:59 PM
elexis added a comment to D2221: [gui] use bullets in civ history window.

Why does that line have text=white but the lines before it don't have it?

Sep 9 2019, 5:45 PM
elexis committed rP22875: Translate lobby TLS certificate error strings following rP21901 and string….
Translate lobby TLS certificate error strings following rP21901 and string…
Sep 9 2019, 4:34 PM
elexis closed D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:34 PM
elexis updated the test plan for D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:32 PM
elexis updated the test plan for D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:23 PM
elexis updated the Trac tickets for D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:18 PM
elexis updated the summary of D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:18 PM
elexis added inline comments to D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:17 PM
Stan awarded D2272: Translate XmppClient::TLSErrorToString a 100 token.
Sep 9 2019, 4:12 PM
elexis created D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:07 PM
elexis added a comment to D2271: Fix lobby utf8 conversion following rP22856 / D2264.

(+ forgotton unrevisioned file)

Sep 9 2019, 3:49 PM
elexis planned changes to D2271: Fix lobby utf8 conversion following rP22856 / D2264.

This version includes D2128 and some other unrelated changes that I now may split.

Sep 9 2019, 3:46 PM
elexis created D2271: Fix lobby utf8 conversion following rP22856 / D2264.
Sep 9 2019, 3:45 PM
elexis added inline comments to rP22856: Support creating lobby GUI messages with arbitrary arguments instead of forcing….
Sep 9 2019, 3:38 PM
elexis accepted D2221: [gui] use bullets in civ history window.
In D2221#94390, @Nescio wrote:

If you have a better suggestion for the comment sentence, feel free to be bold and go ahead!

Perhaps one can make item relate more to the context; looking at civinfo.xml, I suppose each item is a civ bonus? whatever (just the translator audience to be considered in general when editing translated strings)

Sep 9 2019, 12:32 PM
elexis added a comment to D2221: [gui] use bullets in civ history window.

On the translation comment itself "insert an itemization symbol for each entry", the only information it adds to "• %(string)s" is the explanation that the symbol is about itemization.
The information that translators often lack is that they don't know the context it is used in.
They see the filename civinfo.js, so I guess that already restricts the possible interpretations

Sep 9 2019, 12:01 PM
elexis added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Sep 9 2019, 11:10 AM
elexis added inline comments to D2128: Use CreateObject in EngineScriptConversions.
Sep 9 2019, 11:03 AM
elexis added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Sep 9 2019, 10:59 AM
elexis added a comment to P169 Repairable class.

Class keyword discussion with Krinkle on:
http://irclogs.wildfiregames.com/2019-08/2019-08-31-QuakeNet-%230ad-dev.log

Sep 9 2019, 10:38 AM
elexis added inline comments to rP22856: Support creating lobby GUI messages with arbitrary arguments instead of forcing….
Sep 9 2019, 10:23 AM
elexis added a comment to D2221: [gui] use bullets in civ history window.

Yes, Translation: prefix is necessary, otherwise the python extract script won't notice it.
And this line needs to appear before the "translate" line. Multi-line comments are supported too.
And that mostly answers the question between context and comment. Context allows to translate differently depending on context, translation comment allows to tell long stories for the translators.

Sep 9 2019, 10:18 AM

Sep 8 2019

elexis added a comment to D2221: [gui] use bullets in civ history window.

Yessir this is what I meant! Isn't it beauty?

Sep 8 2019, 10:15 PM
elexis updated the diff for D2128: Use CreateObject in EngineScriptConversions.

Make CreateObject static, so that it can be used without the GetScriptInterfaceAndCBData call!

Sep 8 2019, 8:05 PM
elexis added a comment to D2021: Fix AtlasUI.dll windows autobuild.

As mentioned in the ticket, reported a month ago by AlexanderMB, the Atlas Actor Viewer doesn't work currently because the Atlas.dll is 18 months old.

Sep 8 2019, 7:57 PM
elexis added a comment to D2247: [gui] omit unnecessary decimals for resistance tooltip.
In D2247#94229, @Nescio wrote:

in practice all values (do a grep -r Armour in the simulation/data/ and simulation/templates/ ) are multiples of 1

Sep 8 2019, 3:04 PM
elexis added a comment to D2221: [gui] use bullets in civ history window.
In D2221#94243, @Nescio wrote:

Commas should also be translated, everything.

But the line-endings ('\n') don't seem to be translated either?

Sep 8 2019, 2:51 PM
elexis added a comment to D2036: hellenic_royal_stoa → stoa.

refs rP22871

Sep 8 2019, 2:42 PM
elexis added a comment to rP22335: Improve UTF-8 character handling in Atlas.

So it seems the animations don't play because the autobuild doesn't commit the Atlas dll!
Which means only the compile warning would be left over if we can confirm it to be working after that fix (#5574 / D2021).

Sep 8 2019, 2:25 PM
elexis updated the Trac tickets for D2021: Fix AtlasUI.dll windows autobuild.
Sep 8 2019, 2:23 PM

Sep 7 2019

elexis added a comment to D2221: [gui] use bullets in civ history window.

So you mean the bullets ought to be translated?

General rule of thumb, important, if it is a string that is displayed, it should be translated.
Even if it is only one symbol. Commas should also be translated, everything. Because everything can differ depending on language.
Same with the format, right-to-left languages for instance.
The only thing we dont have changeable easily is when multiple lines are concatenated (bottom to top).

Sep 7 2019, 9:30 PM
elexis added a comment to D2221: [gui] use bullets in civ history window.

Yes https://code.wildfiregames.com/D1377#72771 the same way like that what was committed https://code.wildfiregames.com/source/0ad/change/ps/trunk/binaries/data/mods/public/gui/loading/loading.js;22137
That will fix the first two points.
What do we do against the duplication?

Sep 7 2019, 9:21 PM
elexis added a comment to D2221: [gui] use bullets in civ history window.

Yep you got it.
One can find that by searching the codebase for the bullet symbol and then doing svn blame for that line.

Sep 7 2019, 9:03 PM
elexis committed rP22868: Fix previous (invalid Freeze rP22867)..
Fix previous (invalid Freeze rP22867).
Sep 7 2019, 7:04 PM
elexis committed rP22867: Implement NetClient PushGuiMessage using parameter pack and ScriptInterface….
Implement NetClient PushGuiMessage using parameter pack and ScriptInterface…
Sep 7 2019, 6:52 PM
elexis closed D2267: CNetClient::PushGuiMessage script template to remove remaining Eval calls.
Sep 7 2019, 6:52 PM
elexis updated the diff for D2267: CNetClient::PushGuiMessage script template to remove remaining Eval calls.

Implement char literal ToJSVal to remove explicit std::string ctor.

Sep 7 2019, 6:12 PM
elexis added a comment to rP22864: Move "PlayersToDamage" from calling functions to "CauseDamageOverArea" and….

Patch By: Freagarach

Sep 7 2019, 3:52 PM
elexis committed rP22863: Remove some unused Profiler.h and CLogger.h includes..
Remove some unused Profiler.h and CLogger.h includes.
Sep 7 2019, 3:36 PM
elexis closed D2268: Remove some unused Profiler.h CLogger.h includes.
Sep 7 2019, 3:36 PM
elexis created D2268: Remove some unused Profiler.h CLogger.h includes.
Sep 7 2019, 3:28 PM
elexis accepted rP18417: Header cleanup: profile.h is no longer unnecessarily included in….
Sep 7 2019, 3:05 PM
elexis added a comment to rP18417: Header cleanup: profile.h is no longer unnecessarily included in….

To me it seems like this should be fully reverted unless someone enlightens me with news.

So this was definitely wrong, it was good to remove it from ScriptInterface.h.

Sep 7 2019, 2:46 PM
elexis added a comment to rP18417: Header cleanup: profile.h is no longer unnecessarily included in….

This seems to have been a case of the auditor failing to read the letters printed in the patch.
I don't remember if I found something in another file, but what was posted was indeed false.

Sep 7 2019, 2:42 PM
elexis added a comment to P169 Repairable class.

As reported on the lobby yesterday, another feature of the class keyword is that it throws an error if one calls a constructor without new:

TypeError: class constructors must be invoked with |new|

Sep 7 2019, 1:04 PM
elexis added a comment to D2247: [gui] omit unnecessary decimals for resistance tooltip.

The according ticket of pain is #4099. It seems like a consistent philosophy or complete world view on rounding numbers in the GUI is missing. There is also the question as to how simulation templates and simulation components should do the rounding, so that the GUI doesnt have to round.
If it does use rounding, it's usually lying. You don't want to have 0 HP units walking around, and you don't want tradecarts with 0 trace, nor units with 1 trade that dont bump the resource counter if they finished their trip (just two random examples).

Sep 7 2019, 11:58 AM
elexis added a comment to D2221: [gui] use bullets in civ history window.

Agree it looks better.

Sep 7 2019, 11:42 AM
elexis added a comment to D2110: manual/intro.txt corrections.

@elexis May I merge?

Sep 7 2019, 11:27 AM
elexis added a comment to D2250: Silence uninitialized variable warnings on MakeGoalReachable and FindNearestNavcellInRegions in rP22817.

Somewhat sensible default-values

Somewhat sounds like partial. Is there a case where the return value is wrong if empty regions are passed? Like there not being a navcell at the target?
Should there be an early return, perhaps false returned on failure bool on success, or an ENSURE if it should never happen (not even in test setups or the extreme maps)?

Sep 7 2019, 11:11 AM
elexis removed 1 auditor(s) for rP22006: Clean up and speed up the water manager distance computations: elexis.

Thanks for the fix!

Sep 7 2019, 10:53 AM
elexis added inline comments to D2267: CNetClient::PushGuiMessage script template to remove remaining Eval calls.
Sep 7 2019, 2:43 AM
elexis added a comment to P169 Repairable class.

refs IRClogs yesterday and today, and lobby logs today.
The file contains the same code as currently committed, but uses the class syntax.

Sep 7 2019, 2:24 AM

Sep 6 2019

elexis changed the visibility for P169 Repairable class.
Sep 6 2019, 9:08 PM
elexis added a comment to D2265: Delete Lobby Presence Update messages altogether.

In particular I would need to know whether you liked rP20040.

Sep 6 2019, 7:59 PM
elexis added a comment to P169 Repairable class.

What do you think why I uploaded this paste?

Sep 6 2019, 7:38 PM
elexis added a comment to D2265: Delete Lobby Presence Update messages altogether.

Woah, give this one a minute for review. I think this is really the wrong approach and needs major rework before landing. I haven't had a chance to write up all my comments yet, but I wanted to quickly jump in and say that I think this should be rolled back until the review process can run its course.

Sep 6 2019, 7:35 PM
elexis committed rP22859: Fix wrong "player is not a moderator anymore" lobby chat message following….
Fix wrong "player is not a moderator anymore" lobby chat message following…
Sep 6 2019, 6:57 PM
elexis closed D2266: Fix wrong "player is not a moderator anymore" message.
Sep 6 2019, 6:56 PM
elexis updated the Trac tickets for D2264: Create lobby GUI messages with arbitrary arguments.
Sep 6 2019, 6:51 PM
elexis updated the test plan for D2266: Fix wrong "player is not a moderator anymore" message.
Sep 6 2019, 6:45 PM
elexis created D2267: CNetClient::PushGuiMessage script template to remove remaining Eval calls.
Sep 6 2019, 12:54 PM
elexis removed 1 auditor(s) for rP22304: Allow entities to be affected by Status Effects from ranged attacks.: elexis.
Sep 6 2019, 10:36 AM
elexis updated the Trac tickets for D2266: Fix wrong "player is not a moderator anymore" message.
Sep 6 2019, 7:58 AM
elexis created D2266: Fix wrong "player is not a moderator anymore" message.
Sep 6 2019, 7:57 AM
elexis committed rP22856: Support creating lobby GUI messages with arbitrary arguments instead of forcing….
Support creating lobby GUI messages with arbitrary arguments instead of forcing…
Sep 6 2019, 7:14 AM
elexis closed D2264: Create lobby GUI messages with arbitrary arguments.
Sep 6 2019, 7:14 AM
elexis updated the diff for D2264: Create lobby GUI messages with arbitrary arguments.

Do the above.

Sep 6 2019, 6:35 AM