- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Sep 10 2019
Sep 9 2019
I've tested more, I surrender.
Nope, that still doesn't fix the conditional jump.
Missing file, also init m_CertStatus
After commenting out the create XmppClient call, the conditional jump warning is gone.
Affected line:
glDrawElements(GL_TRIANGLES, indexes.size(), GL_UNSIGNED_SHORT, &indexes[0]);
Affected JS_CallFunctionValue in IGUIObject::ScriptEvent:
JS::AutoValueVector paramData(cx); paramData.append(mouse); JS::RootedObject obj(cx, GetJSObject()); JS::RootedValue handlerVal(cx, JS::ObjectValue(*it->second)); JS::RootedValue result(cx, JS::UndefinedValue()); if (!JS_CallFunctionValue(cx, obj, handlerVal, paramData, &result)) { // We have no way to propagate the script exception, so just ignore it // and hope the caller checks JS_IsExceptionPending }
The affected line in GUIRenderer::Draw is glDrawArrays(GL_TRIANGLES, 0, 6);.
The affected line is glClear(GL_DEPTH_BUFFER_BIT); from rP666, number of the beast:
Why does that line have text=white but the lines before it don't have it?
(+ forgotton unrevisioned file)
This version includes D2128 and some other unrelated changes that I now may split.
In D2221#94390, @Nescio wrote:If you have a better suggestion for the comment sentence, feel free to be bold and go ahead!
Perhaps one can make item relate more to the context; looking at civinfo.xml, I suppose each item is a civ bonus? whatever (just the translator audience to be considered in general when editing translated strings)
On the translation comment itself "insert an itemization symbol for each entry", the only information it adds to "• %(string)s" is the explanation that the symbol is about itemization.
The information that translators often lack is that they don't know the context it is used in.
They see the filename civinfo.js, so I guess that already restricts the possible interpretations
Class keyword discussion with Krinkle on:
http://irclogs.wildfiregames.com/2019-08/2019-08-31-QuakeNet-%230ad-dev.log
Yes, Translation: prefix is necessary, otherwise the python extract script won't notice it.
And this line needs to appear before the "translate" line. Multi-line comments are supported too.
And that mostly answers the question between context and comment. Context allows to translate differently depending on context, translation comment allows to tell long stories for the translators.
Sep 8 2019
Yessir this is what I meant! Isn't it beauty?
Make CreateObject static, so that it can be used without the GetScriptInterfaceAndCBData call!
As mentioned in the ticket, reported a month ago by AlexanderMB, the Atlas Actor Viewer doesn't work currently because the Atlas.dll is 18 months old.
In D2247#94229, @Nescio wrote:in practice all values (do a grep -r Armour in the simulation/data/ and simulation/templates/ ) are multiples of 1
In D2221#94243, @Nescio wrote:Commas should also be translated, everything.
But the line-endings ('\n') don't seem to be translated either?
Sep 7 2019
So you mean the bullets ought to be translated?
General rule of thumb, important, if it is a string that is displayed, it should be translated.
Even if it is only one symbol. Commas should also be translated, everything. Because everything can differ depending on language.
Same with the format, right-to-left languages for instance.
The only thing we dont have changeable easily is when multiple lines are concatenated (bottom to top).
Yes https://code.wildfiregames.com/D1377#72771 the same way like that what was committed https://code.wildfiregames.com/source/0ad/change/ps/trunk/binaries/data/mods/public/gui/loading/loading.js;22137
That will fix the first two points.
What do we do against the duplication?
Yep you got it.
One can find that by searching the codebase for the bullet symbol and then doing svn blame for that line.
Implement char literal ToJSVal to remove explicit std::string ctor.
Patch By: Freagarach
To me it seems like this should be fully reverted unless someone enlightens me with news.
So this was definitely wrong, it was good to remove it from ScriptInterface.h.
This seems to have been a case of the auditor failing to read the letters printed in the patch.
I don't remember if I found something in another file, but what was posted was indeed false.
As reported on the lobby yesterday, another feature of the class keyword is that it throws an error if one calls a constructor without new:
TypeError: class constructors must be invoked with |new|
The according ticket of pain is #4099. It seems like a consistent philosophy or complete world view on rounding numbers in the GUI is missing. There is also the question as to how simulation templates and simulation components should do the rounding, so that the GUI doesnt have to round.
If it does use rounding, it's usually lying. You don't want to have 0 HP units walking around, and you don't want tradecarts with 0 trace, nor units with 1 trade that dont bump the resource counter if they finished their trip (just two random examples).
Agree it looks better.
In D2110#93260, @Gallaecio wrote:@elexis May I merge?
Somewhat sensible default-values
Somewhat sounds like partial. Is there a case where the return value is wrong if empty regions are passed? Like there not being a navcell at the target?
Should there be an early return, perhaps false returned on failure bool on success, or an ENSURE if it should never happen (not even in test setups or the extreme maps)?
Thanks for the fix!
refs IRClogs yesterday and today, and lobby logs today.
The file contains the same code as currently committed, but uses the class syntax.
Sep 6 2019
In particular I would need to know whether you liked rP20040.
What do you think why I uploaded this paste?
In D2265#94134, @JoshuaJB wrote:Woah, give this one a minute for review. I think this is really the wrong approach and needs major rework before landing. I haven't had a chance to write up all my comments yet, but I wanted to quickly jump in and say that I think this should be rolled back until the review process can run its course.
Do the above.