Page MenuHomeWildfire Games
Feed Advanced Search

Nov 12 2017

fatherbushido abandoned D597: Don't early return in MissileHit when the main target has no position anymore..
Nov 12 2017, 5:33 PM

Nov 3 2017

fatherbushido added a comment to D1007: Template organization: the plane.
In D1007#39556, @leper wrote:

As for where to move things, I don't know. Everything not starting with template_ or special/ is placeable, how to organize things should be done according to some logic (that might be nice to describe in some readme file so people can find things more easily, and know where to place them) that might want to take being createable by a normal player, being specific to certain modes, nice layout for maybe the AI (though that should just construct the list of entities similarly to the structree), and possibly more.

Nov 3 2017, 7:41 PM
fatherbushido added a comment to D1007: Template organization: the plane.

Another input, for the eyes it's better to have civ_ files in units/
plane doesn't fit well that scheme (same for noldor, viking, samnite and so on things).

Nov 3 2017, 7:07 PM
fatherbushido added a comment to D1007: Template organization: the plane.
In D1007#39547, @Nescio wrote:

Furthermore, I understood (#4770) that units etc were to be removed from the other/ folder.

Nov 3 2017, 6:57 PM
fatherbushido added a comment to D1007: Template organization: the plane.

You are at least missing the cheat data file.

Sorry, I'm unaware of its existence. Which file?

Nov 3 2017, 6:56 PM
fatherbushido added a comment to D1007: Template organization: the plane.

something like structures/other/ or structures_other/ ?

Nov 3 2017, 6:55 PM
fatherbushido added a comment to D1007: Template organization: the plane.

Then again I somewhat consider moving certain templates to structures/ or units/ to be somewhat strange since those shouldn't be created by default.

Nov 3 2017, 6:46 PM
fatherbushido committed rP20404: Remove duplicated builder list..
Remove duplicated builder list.
Nov 3 2017, 6:24 PM
fatherbushido closed D1008: removed wonder duplicates from building lists.
Nov 3 2017, 6:24 PM
fatherbushido added a comment to D1008: removed wonder duplicates from building lists.

(thx for the patch)

Nov 3 2017, 6:24 PM
fatherbushido accepted D1008: removed wonder duplicates from building lists.
  • complete
  • tested (validation...)
Nov 3 2017, 6:20 PM
fatherbushido added a comment to D1008: removed wonder duplicates from building lists.
In D1008#39526, @Nescio wrote:

structures/{civ}_library for example

In A22 that still caused an error if the civ-specific template didn't exist. This is no longer the case in A23? Good to know!

Nov 3 2017, 6:13 PM
fatherbushido added a comment to D1006: Template organization: embassy.
In D1006#39518, @Nescio wrote:

Now you mention it, aren't the non-royal hellenic royal stoas actually embassies? (Limited to two per player; town phase; trains mercenaries; etc.) If so, maybe they could be merged into the embassy.

Nov 3 2017, 5:57 PM
fatherbushido added a comment to D1008: removed wonder duplicates from building lists.

following r19952

Nov 3 2017, 5:54 PM
fatherbushido planned changes to D924: {WIP]Add an option to checkrefs script to not list unused refs.
Nov 3 2017, 5:51 PM
fatherbushido added a comment to D1008: removed wonder duplicates from building lists.

Nice :)
(You can even use a builder list in top of all structures with the {civ} replacement. So you don't have to put things like (/sele_library) in all specific template.)

Nov 3 2017, 5:08 PM
fatherbushido added a comment to D1006: Template organization: embassy.
In D1006#39493, @Nescio wrote:

Furthermore, the Athenian gymnasion, Gaul tavern, Persian hall, and Spartan syssition are fundamentally one and the same structure: a structure which trains some of a faction's champions; so perhaps they could be merged and have a template_structure_military_hall.xml as their shared parent instead?

Nov 3 2017, 5:04 PM
fatherbushido added a comment to D989: template organization: treasures, ruins, and the plane (1/5).

Actually I wouldn't mind to move fauna_* to fauna/*, flora_* to flora/*, and geology_* to geology/* as well, such a patch would be easy to create.

Nov 3 2017, 4:58 PM
fatherbushido added a comment to D1006: Template organization: embassy.
In D1006#39489, @Nescio wrote:

Personally I don't think it's really needed, but that probably should be decided on a case by case basis per template.

Nov 3 2017, 4:52 PM
fatherbushido added a comment to D1006: Template organization: embassy.

You point out something, is the special template still needed? (before there was something like every civs had sb1 and sb2).

Nov 3 2017, 4:29 PM
fatherbushido added a comment to D597: Don't early return in MissileHit when the main target has no position anymore..

Anectdote:
in source/simulation/Collision.h?rev=4437

Nov 3 2017, 4:24 PM
fatherbushido committed rP20403: Template organization: move some structures from other/ to structures/.
Template organization: move some structures from other/ to structures/
Nov 3 2017, 12:00 PM
fatherbushido closed D1002: template organization: other/{civ}_* to structures/{civ}_*.
Nov 3 2017, 12:00 PM
fatherbushido accepted D1002: template organization: other/{civ}_* to structures/{civ}_*.

Makes sense.
I launch the maps.
I test validation of all templates.
I launch the checkrefs script.

Nov 3 2017, 11:58 AM
fatherbushido committed rP20402: Fix a typo..
Fix a typo.
Nov 3 2017, 11:22 AM
fatherbushido closed D1005: typo in rP20376.
Nov 3 2017, 11:22 AM
fatherbushido added a comment to rP20376: Consistently use utf8 instead of iso-8859-1 encoding in XML files..

(as I needed it locally, I uploaded it at D1005)

Nov 3 2017, 10:12 AM
fatherbushido created D1005: typo in rP20376.
Nov 3 2017, 10:11 AM

Nov 2 2017

fatherbushido added a comment to rP20376: Consistently use utf8 instead of iso-8859-1 encoding in XML files..

:-)

Nov 2 2017, 7:11 PM
fatherbushido added a comment to rP20376: Consistently use utf8 instead of iso-8859-1 encoding in XML files..

I don't know why but it break the checkrefs script on my config.

Nov 2 2017, 6:39 PM
fatherbushido added a comment to D989: template organization: treasures, ruins, and the plane (1/5).

@Nescio
you really don't make me thing easy ;-)
I will need hours to go with that and people will be mad :o
Moreover I really think the gaia/treasure/ and gaia/ruins/ should have been postponed in another patch. As now we get in the gaia folder things in a subfolder and things not in a subfolder.
The plane doesn't need to be in that patch :)
Don't bother with adressing those things it will be too much time consuming, I will try to split all that.

Nov 2 2017, 5:20 PM
fatherbushido added a comment to D924: {WIP]Add an option to checkrefs script to not list unused refs.
In D924#39409, @elexis wrote:

An option to not list unused refs as the patch does that I could possibly accept or planning some change?

Nov 2 2017, 5:00 PM
fatherbushido reclaimed D924: {WIP]Add an option to checkrefs script to not list unused refs.

(an option to not display them could be better in fact)

Nov 2 2017, 2:29 PM
fatherbushido retitled D924: {WIP]Add an option to checkrefs script to not list unused refs from Add an option to checkrefs script to not list unused refs to {WIP]Add an option to checkrefs script to not list unused refs.
Nov 2 2017, 2:29 PM
fatherbushido added a comment to D274: Handle modifications of technologies and auras in a system component.

What do you expect exactly of the review here?

Nov 2 2017, 2:25 PM
fatherbushido added a comment to rP20394: Remove wrong tension comment from rP20383 and mention that this functon can….

The only part I don't understand is the labeling, i.e. if tension != 0.5 is a Catmull Rom spline too (in their words, not ours) or only a cardinal spline.

Nov 2 2017, 9:34 AM

Nov 1 2017

fatherbushido added a comment to rP20394: Remove wrong tension comment from rP20383 and mention that this functon can….

(Its presumably well defined in the unavailable paper from 1974. Actually I didn't see a definition, just some incomplete property descriptions.)
(Besides every of these using a custom definition of "tension", it is not clear to me if the tension must be 0.5 in our implementation to be labeled a CR or if the splines with tension != 0.5 can be labeled as CR too according to a definition we can read)

Nov 1 2017, 10:30 PM
fatherbushido added a comment to rP20394: Remove wrong tension comment from rP20383 and mention that this functon can….

(it's not ambiguous ;-))

Nov 1 2017, 9:46 PM
fatherbushido added a comment to D268: Add "mul_round" op to template parsing to support multiplying with integer types..

(imul sounds better than mul_round.)
/me won the useless comment award.

Nov 1 2017, 5:21 PM
fatherbushido added a comment to D1001: template organization: elephant stables.

I've no strong feelings about that, so if other people have opinions, it's time to speak :)

Nov 1 2017, 5:14 PM
fatherbushido accepted D1003: Correct cubicInterpolation cardinal / Catmull-Rom spline comment.
Nov 1 2017, 4:52 PM
fatherbushido added inline comments to D1003: Correct cubicInterpolation cardinal / Catmull-Rom spline comment.
Nov 1 2017, 4:52 PM
fatherbushido added a comment to D1003: Correct cubicInterpolation cardinal / Catmull-Rom spline comment.
In D1003#39281, @elexis wrote:

(I took the statement that tension = 0 resluts in the Catmull-Rom spline and that the tension must be in the interval [0, 1] from here.
I guess if it is a mistake,

Nov 1 2017, 4:51 PM
fatherbushido added a comment to rP20393: Move out of world promoted, packed and upgraded entity as they are not….

(and fix a space issue noticed by elexis)

Nov 1 2017, 3:56 PM
fatherbushido committed rP20393: Move out of world promoted, packed and upgraded entity as they are not….
Move out of world promoted, packed and upgraded entity as they are not…
Nov 1 2017, 3:55 PM
fatherbushido closed D590: Move out world promoted, packed or upgraded before destroying..
Nov 1 2017, 3:55 PM
fatherbushido abandoned D961: Let some heros upgrade to mount or unmount..
Nov 1 2017, 3:37 PM
fatherbushido added inline comments to rP20383: Extend the cubicInterpolation function to consume a tension argument allowing….
Nov 1 2017, 3:15 PM
fatherbushido added a comment to D438: Change Run Speed into a Run multiplier.

(the atlas change is missing)
(edit: that's strange that the bot didn't notice, ?)

Nov 1 2017, 2:48 PM
fatherbushido added a comment to D1003: Correct cubicInterpolation cardinal / Catmull-Rom spline comment.

You can check straightly with the provided function defined by f(x)=((P * x + Q) * x + R) * x + S that:
f(0) = p1
f(1) = p2
df/dx (0) = tension * (p2-p0)
df/dx((1) = tension * (p3-p1)
Then one can understand that for tension = 1/2, the slope in p1 is well given by the slope of the line (p0,p2) and the slope in p2 is well given by the slope of the line (p1, p3), which are the requested things.
(tension 0 is something which should be rarely desirable)

Nov 1 2017, 2:16 PM
fatherbushido added inline comments to D1003: Correct cubicInterpolation cardinal / Catmull-Rom spline comment.
Nov 1 2017, 1:59 PM
fatherbushido added inline comments to rP20383: Extend the cubicInterpolation function to consume a tension argument allowing….
Nov 1 2017, 11:30 AM
fatherbushido added inline comments to rP20383: Extend the cubicInterpolation function to consume a tension argument allowing….
Nov 1 2017, 9:24 AM
fatherbushido added inline comments to rP20383: Extend the cubicInterpolation function to consume a tension argument allowing….
Nov 1 2017, 7:57 AM

Oct 31 2017

fatherbushido added inline comments to rP20383: Extend the cubicInterpolation function to consume a tension argument allowing….
Oct 31 2017, 10:12 AM
fatherbushido added inline comments to rP20383: Extend the cubicInterpolation function to consume a tension argument allowing….
Oct 31 2017, 9:01 AM
fatherbushido added a comment to D981: Make commutative behaviour in the IsInRange function family and migrate them to a better home.

Do not agree on that fully, since splitting the move and behaviour change will result in changing EVERY line that needs to be changed in the unitMotion twice. Also the public mod code is changed twice almost every line. So only those helpers in geometry and fixedVector stuff are not changed twice. As a result we change about 1.75 times as many lines as we need to. I don't mind splitting patches at all (especially since this is a split already), but this split doesn't seem to have clear benefit.
When the split is required however please let me know.

Oct 31 2017, 8:24 AM

Oct 30 2017

fatherbushido added a comment to D989: template organization: treasures, ruins, and the plane (1/5).
In D989#39075, @Nescio wrote:

1&3 are gaia/special_ruins_*xml -> gaia/ruins/*.xml

Let's wait tommorow :)

Ah, I see; but the special part was to removed anyway, right? I think I did not include or move any files which were not mentioned over there.

Oct 30 2017, 10:13 PM
fatherbushido added a comment to D989: template organization: treasures, ruins, and the plane (1/5).

Sorry, I don't think I understand your reply. I believe I basically did what you requested in #4770: “Organize treasures and ruins templates”. A few other oddities I encountered on the way (e.g. pegasus, plane, pyramid) were discussed there as well. What are your “1 & 3”? I'm a bit confused now.

Oct 30 2017, 8:09 PM
fatherbushido added inline comments to D438: Change Run Speed into a Run multiplier.
Oct 30 2017, 7:42 PM
fatherbushido added a comment to D438: Change Run Speed into a Run multiplier.

(I forgot to test a plane, but sadly the patch doesn't apply anymore it seems)

Oct 30 2017, 7:38 PM
fatherbushido added a comment to D994: template organization: catafalques.

@fatherbushido do you want to commit this or shall I?

Oct 30 2017, 7:27 PM
fatherbushido added a comment to D989: template organization: treasures, ruins, and the plane (1/5).

Thx for the sumup

Oct 30 2017, 7:24 PM
fatherbushido added a comment to rP18925: Split the 1D and 2D interpolation into 2 Functions. Renamed….

(Else no need to mention my name)

Oct 30 2017, 7:03 PM
fatherbushido added a comment to rP18925: Split the 1D and 2D interpolation into 2 Functions. Renamed….

Ah, you're right with regards to the ticket.
Thanks for the quick feedback!
Do you prefer to be mentioned in the commit message (and if yes, how) or avoided, or eager to review an according diff to interpolation.js?
(Should the tension become the first argument of the function?)

Oct 30 2017, 6:53 PM
fatherbushido added a comment to D989: template organization: treasures, ruins, and the plane (1/5).

Say when it's ok to review. All is in that diff now or there is still the 5 ones?

Oct 30 2017, 3:42 PM
fatherbushido added a comment to rP18925: Split the 1D and 2D interpolation into 2 Functions. Renamed….

(Well I didn't really speak of uniform iirc (2016-09-26-QuakeNet-#0ad-dev.log and #4278). But that's not the point.)

Oct 30 2017, 3:20 PM
fatherbushido added a comment to D985: corrected misleading unit icon names for consistency.

(I didn't read the whole discussion, perhaps the link has already been posted, in case: https://trac.wildfiregames.com/wiki/ArtDesignDocument#FileNamingConventions)

Oct 30 2017, 2:28 PM

Oct 29 2017

fatherbushido added inline comments to D987: Unit test for D960.
Oct 29 2017, 5:56 PM
fatherbushido added inline comments to D960: Fix an issue with Upgrade and training restriction..
Oct 29 2017, 5:54 PM
fatherbushido added a comment to D558: Update timer missileHits in case of entity renamed.

(I personally think it's a bit useless, at least in that specific case, as the Damage code can handle that)

Oct 29 2017, 5:42 PM
fatherbushido added a comment to D958: Silence build output with third-party libs on Unix.

(Perhaps we could add an OSX reviewer-tester group on phab)

Oct 29 2017, 5:37 PM
fatherbushido added a comment to D994: template organization: catafalques.

Is “contains” instead of “startsWith” allowed?

Oct 29 2017, 1:53 PM
fatherbushido added a comment to D961: Let some heros upgrade to mount or unmount..
In D961#38795, @wraitii wrote:

I'm not requesting changes - so you can commit it if you wish - but don't do this. I created https://code.wildfiregames.com/D281 explicitly for this kind of stuff.

Oct 29 2017, 11:16 AM
fatherbushido updated the summary of D961: Let some heros upgrade to mount or unmount..
Oct 29 2017, 10:27 AM
fatherbushido committed rP20373: Add a unit test to EntityLimits component. Refs rP20372..
Add a unit test to EntityLimits component. Refs rP20372.
Oct 29 2017, 9:08 AM
fatherbushido closed D987: Unit test for D960.
Oct 29 2017, 9:07 AM
fatherbushido committed rP20372: Fix an issue with upgrade and entity limits..
Fix an issue with upgrade and entity limits.
Oct 29 2017, 9:05 AM
fatherbushido closed D960: Fix an issue with Upgrade and training restriction..
Oct 29 2017, 9:04 AM
fatherbushido added inline comments to D960: Fix an issue with Upgrade and training restriction..
Oct 29 2017, 9:00 AM
fatherbushido added inline comments to rP19103: Fix identation issues, line endings and remove a not working entry in templates..
Oct 29 2017, 8:58 AM
fatherbushido added inline comments to rP19103: Fix identation issues, line endings and remove a not working entry in templates..
Oct 29 2017, 8:57 AM
fatherbushido added a comment to D989: template organization: treasures, ruins, and the plane (1/5).

@Nescio:

  • As we discussed together, the use of a subfolder is perhaps not needed. If you really want it || it really needed, you can do it in a future patch (sed as pointed out by leper above will do the job easilly).
  • see for example rP20244
Oct 29 2017, 8:39 AM

Oct 28 2017

fatherbushido added a comment to D988: Tweak melee cavalry and infantry max range.

(see with artists, but indeed sword < spear < pike)

Oct 28 2017, 7:13 PM
fatherbushido added a comment to D960: Fix an issue with Upgrade and training restriction..

(Waiting this night for potential leper's comment.)

Oct 28 2017, 6:37 PM
fatherbushido updated subscribers of D808: create elephant produce omnipresent sound.

(You can grab @Pureon input about that.)

Oct 28 2017, 6:16 PM
fatherbushido added a comment to D408: let technologies modify loot.

If you really want it included, split the templates part and the modifications part.
For roundings, you have to add the round just before calling the ApplyMod function (and also in Template.js).
You have to check that it doesn't break AI (that AI does the same thing) iirc.
At first glance, I would choose floor.

Oct 28 2017, 6:13 PM
fatherbushido removed a reviewer for D438: Change Run Speed into a Run multiplier: fatherbushido.
  • ./test is ok
  • All template validate.
  • I launched game ai vs ai, me vs ai. Checked different behavior.
  • I tried saving, loading games, with aura modifications. I checked tooltip.
  • I ran serialization test
  • I read all the code. Despite I have not a deep cpp knowledge, there is no complex things so it seems ok.
Oct 28 2017, 6:07 PM
fatherbushido added a reviewer for D438: Change Run Speed into a Run multiplier: fatherbushido.
Oct 28 2017, 6:07 PM
fatherbushido created D987: Unit test for D960.
Oct 28 2017, 3:57 PM
fatherbushido committed rP20363: Tweak a bit citizen cavalry costs. Follow the same infantry vs cavalry policy….
Tweak a bit citizen cavalry costs. Follow the same infantry vs cavalry policy…
Oct 28 2017, 12:34 PM
fatherbushido closed D983: Tweak a bit citizen cavalry cost.
Oct 28 2017, 12:34 PM
fatherbushido added a comment to D945: Projectile hit animation.
In D945#38483, @wraitii wrote:

Performance wise, this is probably a bad idea.

Oct 28 2017, 11:14 AM
fatherbushido added a comment to D945: Projectile hit animation.

@Mate-86: You can also go on the way suggested above by @wraitii. You just spawn a *local* entity at the impact location (as we do for corpse, see Health component for example) with the graphical effect. (Draft thoughts)

Oct 28 2017, 10:48 AM

Oct 27 2017

fatherbushido added inline comments to D960: Fix an issue with Upgrade and training restriction..
Oct 27 2017, 7:44 PM
fatherbushido updated the diff for D960: Fix an issue with Upgrade and training restriction..

leper's remarks

Oct 27 2017, 7:44 PM
fatherbushido added a comment to D960: Fix an issue with Upgrade and training restriction..

(thanks)

Oct 27 2017, 7:03 PM
fatherbushido updated the diff for D960: Fix an issue with Upgrade and training restriction..

wraitii's comments

Oct 27 2017, 7:00 PM
fatherbushido added inline comments to D960: Fix an issue with Upgrade and training restriction..
Oct 27 2017, 6:59 PM
fatherbushido added a reviewer for D983: Tweak a bit citizen cavalry cost: Nescio.
Oct 27 2017, 12:18 PM