@Freagarach Thanks for wrapping this up for me. I apologize for the delay from my end. I should've finished it long ago, but a broken PC and an extremely tight work schedule threw a wrench into the plans. I'll continue contributing when I'm able to in the future. Again, thanks for all the help throughout the entire process!

• Changes the order of calling RecalculateValues

@Freagarach I have made a few changes now, is this correct? If not, please let me know I will change it

• Fixes incorrect calculation of population bonus

Fixes population bonus issue when creating new foundation after research

Hi, I have almost managed to set everything up, except the below:

@Freagarach I still haven't completed dev set up on the new machine yet, but I downloaded and installed 0ad-0.0.23b-alpha-win32.exe from the official site, and I ran the following steps:

Hello @Freagarach ! I finally got a new PC, and I'm setting up the dev environment in this. I will be able to contribute properly now. I will check the required changes and make them! :)

Do you guys think OnValueModification is where the problem would be? Isn't that what is called whenever the population bonus value is updated?

Updates GUIInterface for Population component changes

Fixes test case failure, as well as missing Engine while calling QueryInterface in GUIInterface

Oops, looks like tests are failing, will fix them

In D2948#130226, @Freagarach wrote:

Oh, and if you want you can write a simple test for your new component.

Updates tooltips.js and GUIInterface for population bonus changes

Sorts the ordering of content in certain files

Removes unnecessary population bonus entry for units and updates a comment in Cost.js

Renames component from PopulationHolder to Population, and also updates GUIInterface.js

@Freagarach Yes, I'll be wrapping this up this weekend.

Thanks for the review, folks. It's been a busy few days at work. I'll get around to working on this someday this week ?

Refactors the code to follow conventions and also to improve performance (slightly)

@Freagarach The sorter did sort all the files, but it sorted all the comments in some of those files as well. I wasn't sure how to proceed with those, so I discarded them alone. Around 4-5 files I believe. No worries, I'll run the script again and push them with the rest of the changes.

In D2948#128534, @Freagarach wrote:

General comments about style (see also @wiki CC):

• We use let as much as possible as opposed to var to limit the scope of a variable.
• Comments start with a capital and end in a dot.
• We like to keep the templates in alphabetical order (there is a script for that in source/tools/templatessorter).

Regarding the name of the component, to me it seems that PopulationBonus would be more appropriate, then you can give it an Amount node in the template. PopulationHolder does not seem to cover what it does.

Another thought: Maybe all of the population ought to be moved to this new component, also the population "cost". Perhaps you would need for someone more experienced to answer this question. Then one can have the Population component with two possible entries Cost and Bonus (or Used and Provided).

Sorts template contents using the templatessorter script