Wed, Sep 13
Tue, Sep 12
Fri, Sep 8
Thanks as always, @Freagarach. In the end I've specified the classes of units affected, because otherwise the behavior is very confusing. Hopefully we're closer to the commit. :-)
Sun, Aug 27
Have you checked other languages? There is a script to generate a special localization with longest words: source/tools/i18n/generateDebugTranslation.py.
Sat, Aug 26
Fri, Aug 25
Aug 20 2023
Aug 19 2023
Aug 15 2023
Aug 14 2023
Useful feedback as well. Thanks!
Sounds better. Thanks!
Aug 9 2023
We may need to take into account that this leaks information to enemies.
While true, the borders reveal the same info already. Also AoE even sends a message to inform everyone of phase ups.
I'd argue that without being told it's hard to realize that this is supposed to indicate current phase, maybe take inspiration from AoE and boonGui on how to be more explicit if phase information is deemed worth showing.
Aug 8 2023
@Freagarach: Thanks! Now this is ready for review.
Aug 7 2023
Aug 5 2023
@Freagarach: I looked for ways to contact you privately but didn't found any (which is reasonable in any case). Where's the best place within the forums to ask about small changes like this?
Jul 22 2023
Sure! Added my nickname in the credits.
Jul 10 2023
All suggestions applied. Thank you!
Jul 9 2023
Apr 15 2023
Apr 5 2023
New changes in line with your comments:
- <DisabledTooltip>Infantry Hoplites only, requires at least 10.</DisabledTooltip> → <DisabledTooltip>Requires at least 10 Infantry Hoplites.</DisabledTooltip>, and similar cases in binaries/data/mods/public/simulation/templates/special/formations/*.xml.
- Insufficient resources → Requires more resources, in binaries/data/mods/public/simulation/components/Player.js.
- Removed all requirementsTooltips from binaries/data/mods/public/simulation/data/technologies/*.json. They'll now be generated automatically.
Mar 11 2023
Please don't hate me for this, but I do find the "Trained by" useful. The "Builds" is also useful to check for example if a unit that you haven't trained yet will be able to build a certain structure. I certainly wouldn't be happy with the format, as that brick of plain text doesn't make it easy to find the information you may be looking for.
Mar 8 2023
Jan 20 2023
I've renamed it to 'objection', I think 'warning' might be too general (not everything that could be considered a warning should appear in red), but I came up with the name thanks to your suggestion. I hope I have now changed the coloredText(..., "red") where needed. Thanks!
Jan 19 2023
Thank you for the patch! I have one comment, which should be easy to do because of the function you used. :)
Also, @Stan has added you to the contributors group, so next time you upload a patch our linter will be run against your diff.