@Stan @Dunedan I will work on it, Currently I am about to start my exams so I will be delayed for a bit of time.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 6 2019
Jan 3 2019
Hi @Itms I am available for any further modification needed.
Jun 12 2018
Jun 9 2018
Sorry for the delay. Testing on a custom server (ejabberd 18.04) is done and working as expected, patch should be ready to go.
May 31 2018
ejabberd Ubunut package for Xenial turned to be version 16.01-2
May 30 2018
May 28 2018
Initialize member variable to default value to avoid UB
May 26 2018
Oct 6 2017
Used the summaryArraySum and getPlayerValuesPerTeam instead of writing my own function
Sep 26 2017
@Imarok Please review my changes
Sep 15 2017
Avoid using g_TeamHelperData and calculate team bribes when requested. Also, show stats about successful and failed bribes.
Sep 4 2017
Sep 3 2017
Added team statistics in summary screen
@Imarok Okay I am working on it, sorry my laptop was broken.
Jul 23 2017
In D624#26388, @mimo wrote:There is still the comment on line 552. No need to make a new call to Engine.GetTemplate
Apart from that, looks good to me, but need to wait for after A22 is released to be commited as we are in feature freeze now.
Jun 16 2017
Jun 11 2017
Added the multiplier as a template. Update unit test for vision sharing.
Moved duplicate code into 1 function.
In D624#25567, @mimo wrote:Thanks, the patch looks much nicer (and simpler) now. There are still two possible enhancements if you are up to:
- put the 0.25 in a template if a mod want to change it. Most logical would look to me in VisionSharing where we already have the Bribable and Duration properties.
- addSpy and IncurUnsuccessfulBribeCost share some code for the bribe cost. Could be put in a common fonction.
Jun 10 2017
Reverted the multiplier and instead use a fixed value of 0.25 of the bribe cost.
Update tech bonus
In D624#25465, @elexis wrote:See menu.js of rP19357
Update the tooltip for the bribe button to show that a failed bribe will have a cost.
Also fixed a failed test case in test_player.js
Jun 9 2017
Jun 3 2017
unnecessary white spaces
Removed the hack used to reset the saved selection also fixed the styling issues.
Jun 2 2017
Okay, I will wait the refactoring then continue.