Page MenuHomeWildfire Games
Feed Advanced Search

Fri, Dec 2

phosit added inline comments to D4835: Fixes big screenshot after rP27256 and rP27184.
Fri, Dec 2, 9:51 PM
phosit accepted D4836: Fixes calling SDL functions after SDL_Quit.

That's sane

Fri, Dec 2, 9:39 PM
phosit abandoned D4668: Algorithms in renderer/WaterManager and iota_view.

I split this in to multiple smaller patches. a la D4798

Fri, Dec 2, 6:46 PM
phosit added a comment to D4834: Remove hidden dependency when subscribing to a message.
In D4834#206091, @Stan wrote:

Did you look at the generated assembly, or is it just a guess?

No, it's a guess and I also guess it does not has much evect since components do only subscriped once.

This patch also allows components to subscribe other components to messages. Is this wanted?

No, I think it is acceptable. IMO ClassInit should be replace by an array of MessageTypeIds and LoadComponentTypes would lookup thous. But more redesigneing is required and that is not the purpose of this patch.

Fri, Dec 2, 4:13 PM
phosit requested review of D4834: Remove hidden dependency when subscribing to a message.
Fri, Dec 2, 12:19 PM

Wed, Nov 30

phosit updated the summary of D4803: Replace SharedStateResult with std::optional.
Wed, Nov 30, 5:49 PM
phosit added a comment to D4730: Type-erased SharedState.

Lgtm, could probably bikeshed more on the existing futures code, but let's move this along :)

Wed, Nov 30, 5:27 PM

Sat, Nov 26

phosit added a comment to D4770: Multiplayer saved games.

@mbusy The feature freeze will start on 3. Jan. I (and many others) hope this will be commited until then.

Sat, Nov 26, 5:51 PM
phosit accepted D4830: Adds attachment load and store operations.
Sat, Nov 26, 3:53 PM
phosit added a comment to D4830: Adds attachment load and store operations.

Use initialization over assignement. -> more const.

I'd like to, but then it adds implicit relation for the order of arguments. So I'd prefer to leave as is until C++20 designated initializers.

Sat, Nov 26, 2:36 PM
phosit added a comment to D4718: Allocator and generator for component data..

I thaught about this a bit more:

  1. The standart does differentiate between allocator and memory resource. We schould follow that pattern to.
  2. I think the reason for the performance improvement is that all components are stored together -> less cache misses. To address this it would be bether(even more perf improvement and less error prone) to store the components in the container instead of a pointer.
Sat, Nov 26, 12:20 PM
phosit added a comment to D4830: Adds attachment load and store operations.

Use initialization over assignement. -> more const.

Sat, Nov 26, 11:40 AM

Fri, Nov 25

phosit added a comment to D4623: Fix quicksave not appearing in the menu.

Yes that is much cleaner :)

Fri, Nov 25, 9:08 PM

Tue, Nov 22

phosit updated the diff for D4831: CancelOrWait in pathfinder.

copyright-year

Tue, Nov 22, 5:25 PM
phosit requested review of D4831: CancelOrWait in pathfinder.
Tue, Nov 22, 12:55 PM

Mon, Nov 21

phosit added inline comments to D4623: Fix quicksave not appearing in the menu.
Mon, Nov 21, 5:16 PM
phosit accepted D4738: Allow other root XML than `entity`..

Now the function name is not the best. Something like GetSingleChild or GetOnlyChild.

Mon, Nov 21, 4:57 PM
phosit added inline comments to D4830: Adds attachment load and store operations.
Mon, Nov 21, 12:09 PM

Sun, Nov 20

phosit added a comment to D4830: Adds attachment load and store operations.
In D4830#205677, @Stan wrote:

Yeah that's what I meant :)

Ok, will do. I think @phosit meant the same.

Sun, Nov 20, 7:59 PM
phosit added a comment to D4830: Adds attachment load and store operations.

can you upgrade glad seperatly?

Sun, Nov 20, 4:22 PM

Sat, Nov 19

phosit updated the diff for D4829: async benchmark.

move to test

Sat, Nov 19, 5:05 PM
phosit updated the diff for D4829: async benchmark.

time the sleep duration there will be less fluctuation in the second test

Sat, Nov 19, 2:15 PM
phosit requested review of D4829: async benchmark.
Sat, Nov 19, 1:32 PM
phosit added a comment to D4730: Type-erased SharedState.

I made a benchmark: D4829
Before the patch:

Benchmark:
async cost:
enqueueing:     377ms
work done:      377ms
total:  384ms
async round-trip:
total:  3809ms

And after the patch:

Benchmark:
async cost:     
enqueueing:     360ms
work done:      360ms
total:  363ms
async round-trip:
total:  4088ms
Sat, Nov 19, 1:24 PM

Fri, Nov 18

phosit accepted D4827: Moves post processing out of scene rendering to avoid framebuffer pass duplicate.

LGTM
Silhouettes are as buggy as before :)

Fri, Nov 18, 8:03 PM
phosit added inline comments to D4667: Add JS bindings for in game camera attributes.
Fri, Nov 18, 3:53 PM

Wed, Nov 16

phosit updated the summary of D4828: Set `m_Kill` while holding the mutex.
Wed, Nov 16, 11:56 AM

Tue, Nov 15

phosit requested review of D4828: Set `m_Kill` while holding the mutex.
Tue, Nov 15, 7:14 PM

Mon, Nov 14

phosit added inline comments to D4827: Moves post processing out of scene rendering to avoid framebuffer pass duplicate.
Mon, Nov 14, 10:07 PM
phosit requested review of D4826: Remove unused member of TaskManager::Impl.
Mon, Nov 14, 7:39 PM
phosit updated the summary of D4730: Type-erased SharedState.
Mon, Nov 14, 5:01 PM

Sat, Nov 12

phosit updated the diff for D4790: Use atomic as buffer index in CProfiler2::ThreadStorage.

Put variables in a struct

Sat, Nov 12, 11:58 AM
phosit updated the diff for D4730: Type-erased SharedState.

Copyright Year

Sat, Nov 12, 10:54 AM

Wed, Nov 9

phosit requested review of D4825: Use override in classes derived from AbstractProfileTable.
Wed, Nov 9, 7:26 PM

Tue, Nov 8

phosit updated the diff for D4772: Remove some unnecesary string copy. related to substr.
Tue, Nov 8, 9:13 PM
phosit updated the diff for D4823: No owning raw pointer in L10n.cpp.

more unique_ptr / my own comments

Tue, Nov 8, 8:52 PM

Sun, Nov 6

phosit requested review of D4823: No owning raw pointer in L10n.cpp.
Sun, Nov 6, 5:07 PM

Fri, Nov 4

phosit accepted rP27192: Remove user.cfg from javascript.
Fri, Nov 4, 9:30 PM

Nov 3 2022

phosit added inline comments to D4820: Moves particles data uploading out of framebuffer pass.
Nov 3 2022, 10:49 PM
phosit added inline comments to D4820: Moves particles data uploading out of framebuffer pass.
Nov 3 2022, 4:45 PM
phosit raised a concern with rP27192: Remove user.cfg from javascript.
Nov 3 2022, 3:02 PM
phosit added a comment to D4820: Moves particles data uploading out of framebuffer pass.

The particle work again.
can you add context.

Nov 3 2022, 2:17 PM

Nov 2 2022

phosit updated the diff for D4730: Type-erased SharedState.

Make it independent from the optional patch.

Nov 2 2022, 7:19 PM
phosit updated the diff for D4808: Find a texture.

Implement a Find algorithm with projection. To avoid duplicate.

Nov 2 2022, 6:31 PM

Nov 1 2022

phosit added inline comments to D4616: Remove user.cfg from javascript.
Nov 1 2022, 9:20 PM

Oct 30 2022

phosit accepted D4617: Restrict access for Read/WriteFile functions.

It works.
I also tested the shiny mod.

Oct 30 2022, 2:00 PM
phosit updated the diff for D4803: Replace SharedStateResult with std::optional.

use this-> more consistently

Oct 30 2022, 12:13 PM
phosit requested review of D4817: Remove L10n::DictionaryDeleter.
Oct 30 2022, 12:10 PM
phosit updated the diff for D4425: Use the threadpool for texture conversion.

include order

Oct 30 2022, 10:39 AM
phosit added inline comments to D4803: Replace SharedStateResult with std::optional.
Oct 30 2022, 9:44 AM

Oct 29 2022

phosit updated the diff for D4425: Use the threadpool for texture conversion.

Changes to the queue and the constant.

Oct 29 2022, 12:44 PM
phosit added inline comments to D4772: Remove some unnecesary string copy. related to substr.
Oct 29 2022, 11:44 AM
phosit updated the diff for D4803: Replace SharedStateResult with std::optional.

fix apple clang

Oct 29 2022, 11:18 AM
phosit added inline comments to D4803: Replace SharedStateResult with std::optional.
Oct 29 2022, 11:05 AM

Oct 28 2022

phosit added a comment to D4815: Disallows backend buffer uploading inside framebuffer pass.

The game looks the same and I didn't notice a performance difference.

Oct 28 2022, 12:25 PM

Oct 27 2022

phosit added inline comments to D4425: Use the threadpool for texture conversion.
Oct 27 2022, 8:30 PM

Oct 26 2022

phosit updated the diff for D4764: vector of locale in L10n.

Move the initialization back

Oct 26 2022, 6:52 PM
phosit updated the diff for D4772: Remove some unnecesary string copy. related to substr.
Oct 26 2022, 5:18 PM
phosit updated subscribers of D4808: Find a texture.

@vladislavbelov is it ok if i implement ranges::find? It wold be neat if i can use projection.

Oct 26 2022, 4:18 PM

Oct 25 2022

phosit updated the diff for D4803: Replace SharedStateResult with std::optional.

Implement Vlads aproach and use inheratance (empty base optimization) again.

Oct 25 2022, 10:37 PM
phosit added inline comments to D4803: Replace SharedStateResult with std::optional.
Oct 25 2022, 10:32 PM
phosit planned changes to D4772: Remove some unnecesary string copy. related to substr.
Oct 25 2022, 10:09 PM
phosit added inline comments to D4803: Replace SharedStateResult with std::optional.
Oct 25 2022, 10:01 PM
phosit added inline comments to D4803: Replace SharedStateResult with std::optional.
Oct 25 2022, 8:04 PM
phosit accepted D4809: Moves Backend enum to backends.
Oct 25 2022, 6:55 PM
phosit added inline comments to D4772: Remove some unnecesary string copy. related to substr.
Oct 25 2022, 6:49 PM
phosit added a comment to D3552: Split the rendering WaterManager in a graphics/ and a renderer/ part..

In many files #include "renderer/WaterRenderer.h" is not required.

Oct 25 2022, 1:09 PM
phosit added a comment to D4813: Additional default colors after D4811.

Red and Auburn are not easy to distinguish.

Oct 25 2022, 12:54 PM
phosit added inline comments to D4803: Replace SharedStateResult with std::optional.
Oct 25 2022, 12:06 PM
phosit added inline comments to D4809: Moves Backend enum to backends.
Oct 25 2022, 11:53 AM

Oct 24 2022

phosit added a comment to D4812: Disallow conversion in Future return..

Could you rebased D4730 to only contain its own changes? Obviously the patch won't apply, but it'll make it easier to understand why e.g. this patch is necessary

Oct 24 2022, 10:02 PM
phosit updated the diff for D4730: Type-erased SharedState.

smaller patch, now only the std::function in the TaskManager is replaced.
rebased to D4803. (it will not compile alone)

Oct 24 2022, 9:58 PM
phosit added inline comments to D4803: Replace SharedStateResult with std::optional.
Oct 24 2022, 8:36 PM
phosit added a comment to D4803: Replace SharedStateResult with std::optional.

It is a clean up, since we now can use std::optional.
In the void case the optional needs some memory. Thats the only negative pervormance impact i can imagine.

Oct 24 2022, 8:21 PM
phosit updated the diff for D4812: Disallow conversion in Future return..

Copyringht year and comment

Oct 24 2022, 5:34 PM
phosit requested review of D4812: Disallow conversion in Future return..
Oct 24 2022, 1:27 PM
phosit added a comment to D4809: Moves Backend enum to backends.

The rest looks good and works

Oct 24 2022, 12:35 PM
phosit updated the summary of D4803: Replace SharedStateResult with std::optional.
Oct 24 2022, 11:56 AM
phosit updated the diff for D4798: Rewrite shore wave vertex creation.

Applied comments from Vladislav

Oct 24 2022, 11:49 AM
phosit added a comment to D4737: Allow setting biome in Atlas.

Generaly more things can be const.

Oct 24 2022, 11:17 AM

Oct 23 2022

phosit added inline comments to D4425: Use the threadpool for texture conversion.
Oct 23 2022, 3:56 PM
phosit added inline comments to D4764: vector of locale in L10n.
Oct 23 2022, 2:18 PM

Oct 22 2022

phosit planned changes to D4808: Find a texture.
Oct 22 2022, 8:36 PM
phosit accepted rP26915: Fix text alignment handling of spaces around wrapping..
Oct 22 2022, 8:31 PM
phosit added a comment to D4808: Find a texture.

I stay with this version with the 3 std::finds. It is to complex for to litle benefit.
I'll deduplicate the predicate.

Oct 22 2022, 8:15 PM
phosit added a comment to D4808: Find a texture.
In D4808#204716, @Stan wrote:

Maybe we could use a function where we pass CTexture::** to reduce duplication?

Yes, but...

EDIT maybe we could handle all cases in one iteration too not sure.

e.g sort states, look for HIGH_NEEDS_CONVERTING then PREFETCH_NEEDS_LOADING then PREFETCH_NEEDS_CONVERTING also check if converter busy to filter out

Oct 22 2022, 6:27 PM
phosit requested review of D4808: Find a texture.
Oct 22 2022, 3:59 PM

Oct 21 2022

phosit requested review of D4807: Automatic lifetime for m_Items and m_DeadItems.
Oct 21 2022, 9:26 PM

Oct 20 2022

phosit requested review of D4806: Reset m_EndsWithSpace.
Oct 20 2022, 8:40 PM
phosit added a comment to D4053: Random Maps: Echo Valley & Echo Shores.
  • on Echo Valley sometimes the cc's are covered in trees:
  • there is no preview picture. It's not in the map browser.
  • what does the team placement option do? I don't notice an effect.
  • probably i'm a bit late for this comment: It would look less artificial if it would be rotational symetry instead of miror symetry. Also a odd number of players currently doubles the repetition: 7 players -> 14 repetitions.
Oct 20 2022, 5:20 PM

Oct 18 2022

phosit added a comment to D4805: Update PageStack on demand.
In D4805#204608, @Stan wrote:

Is #5614 related to this?

Oct 18 2022, 5:01 PM
phosit updated the diff for D4805: Update PageStack on demand.

Call UpdatePages before iteration. This should fix the test.

Oct 18 2022, 12:37 PM

Oct 17 2022

phosit requested review of D4805: Update PageStack on demand.
Oct 17 2022, 10:49 PM
phosit added inline comments to D4764: vector of locale in L10n.
Oct 17 2022, 5:20 PM
phosit updated the diff for D4764: vector of locale in L10n.

Applied (most) comments from Vladislav

Oct 17 2022, 4:53 PM
phosit added inline comments to D4764: vector of locale in L10n.
Oct 17 2022, 4:48 PM
phosit added a comment to D4751: Fix the specialness of `FindTemplatesUnrestricted`..

I guess I'll wait then. ^^

Oct 17 2022, 4:14 PM
phosit added inline comments to D4425: Use the threadpool for texture conversion.
Oct 17 2022, 12:53 PM
phosit added inline comments to D4798: Rewrite shore wave vertex creation.
Oct 17 2022, 12:28 PM

Oct 16 2022

phosit updated the diff for D4772: Remove some unnecesary string copy. related to substr.

Add context

Oct 16 2022, 6:56 PM