Perfect, thank you guys, sorry for the waste of time :)

Gotta have to check those includes, lots are missing. Can we do without boost? We're trying to reduce the dependency on it where possible.

Some unsigned / signed mismatches. There might be more. Sorry for all the nitpicks.

Maybe I could just set unit to uncontrollable @Freagarach ? Since 1960 got merged.

Gotta check what this do to translations.

If SM allows to get a size of currently allocated memory it should be easy to write a unit test. We already have some unit tests for ScriptInterface.

Mmh I'm not sure this is a good idea. What are the advantages?
See rP25001 and #3752

Might want to check premake :)

Hey, thanks for another very promising patch. Is there a way you could add some tests for it?

LGTM.

@Mercury thanks for all the work on this so far. Can you address the not done inlines? Did you test in multiplayer? @vladislavbelov said he would look after Feature Freeze.

How does this new version perform with regards to performance?

@jprahman the issue is that the new patches applied on top of sm91 prevented it to build on Windows. We first need to address those before switching to 102.

Either accept or resign from the revision.

Question: Should we use a custom allocator for the std::vectors? Those in source/lib/allocators/*

So better than initial? Nice. Would be nice to compare a frame to see what's reduced.
Still 10% sounds almost too good to be true.
EDIT: Can't read.

@jprahman @Mercury
Some areas of improvement are probably the messaging system; For instance in late game, each entity that dies notifies all the entities on the map through a global message, while it's not really necessary, but we don't have dynamic subscription. All of that has to be copied to the AI too might be no longer relevant since the unthreading of the ai (D3769
);
frame of units combat (huge):

How does this new version perform with regards to performance?

@lyv

Works for me.

@Freagarach

@jprahman could you have a look at it?

Did you get a chance to look at it?

@asterix please don't accept for the sake of accepting it, and instead state the reasons of your acceptance. Else accepting has a very minimal value...

@Langbart can you test this?

Windows only fix.

Wait why would one have Researcher with no techs? Only tech removal?

I guess you can resign here too since it's the SDK bug.

Note there is also a sorter in https://code.wildfiregames.com/P238 . This one also sorts subcomponents which might not be wanted though. It was useful for hyrule since they have/had many duplicate subnodes.

LGTM.

I'm not sure about the last one since it's an external lib. Otherwise looks good. I wonder if DTDs give more useful messages than RNG.

A27

Sounds safer indeed. Sometimes I wonder if special buildings should not just all be named special_01 or something to remove duplication

Seems also to be a windows only issue. No problem with Ubuntu. @vladislavbelov is it acceptable to use the windows proprietary overload with an #ifdef?

Missing pers phase but should work

Dumb question. Aren't indexes of standard containers all size_t in C++?

In D4743#201738, @phosit wrote:

In D4743#201732, @Stan wrote:

They trigger Assertion popups. You're free to ignore suppress them. Except in Atlas where it goes south and crashes the entire game.

So what is the diference betwen WARN_ON_ERROR and ENSURE?

Might try filesystem if that works. I don't remember if nothing worked, or only a subset.

They trigger Assertion popups. You're free to ignore suppress them. Except in Atlas where it goes south and crashes the entire game.

On Windows in C:\Users\{username}\Documents\My Games\0ad\mods

https://github.com/0ad/0ad/blob/f314b5b9d2be852a4d25f4b9ef40ab4acf4f2002/source/lib/file/io/io.cpp#L29

No definitive guidelines.
First consider the gains and the losses of waiting to commit the patch, the current stage of release we're in, the urgency etc

Fix warning.

Rebase, use enum.

Another issue to me is that stuff that should be upgrades (stone walls, various towers) are not which make the panel fuller that needs be. But that's another topic.

@Freagarach @marder

I think you should ask balancing. I don't have a strong opinion.
I sometimes wonder if one should see all the buildings they can't build, or if they should be revealed when they become available.
Or if the UI is good at all, and it should not be more starcrafty (It's a gif)

Header date, the test has been lost,

In D4735#201547, @Langbart wrote:

• vlad is on windows also does not use arcanist and on his patches it works. (D4434)
• works for smiley too (D4611)

Superseeded by D4705

Maybe you can extract the js code that does that for the game settings and then call it?