Page MenuHomeWildfire Games
Feed Advanced Search

Feb 4 2023

Grapjas updated the diff for D4926: Expose BattleState to Gui.

Had forgot proper Init for a rejoining player. E.g. if player left / dc'ed while player had "BATTLE" music going on, the player will get "BATTLE" music again when rejoining. (same behavior as without patch)

Feb 4 2023, 12:57 PM

Feb 3 2023

Grapjas planned changes to D4926: Expose BattleState to Gui.
Feb 3 2023, 5:36 PM
Grapjas added a comment to D4926: Expose BattleState to Gui.

How does this go when changing perspective?

Feb 3 2023, 3:52 PM
Grapjas updated the diff for D4926: Expose BattleState to Gui.

use the already existing PostMessage instead of a new notification.

Feb 3 2023, 3:41 PM

Feb 2 2023

Grapjas planned changes to D4926: Expose BattleState to Gui.
Feb 2 2023, 3:41 PM
Grapjas requested review of D4926: Expose BattleState to Gui.
Feb 2 2023, 1:59 PM

Feb 1 2023

Grapjas added a comment to D4922: Improving music continuation.
In D4922#210139, @sera wrote:

If you switch to class syntax and change pretty much every line anyway, I suggest to use default method signature, static and private where appropriate and drop useless "this" refs. Maybe even switch to use doxy comments.

Feb 1 2023, 7:11 PM
Grapjas planned changes to D4922: Improving music continuation.
Feb 1 2023, 5:47 PM
Grapjas requested review of D4922: Improving music continuation.
Feb 1 2023, 5:22 PM

Jan 24 2023

Grapjas updated the diff for D4896: Improving corral tooltips / info.

Reducing the scope. Up to someone else to fancy it up after FF.

Jan 24 2023, 11:17 AM

Jan 19 2023

Grapjas added a comment to D4896: Improving corral tooltips / info.

yes, this can be implemented, if @elexis agrees, you can't argue against it.

Seems like you've got a patch to make after FF. Not sure about the latter though ^^

Jan 19 2023, 12:37 PM

Jan 18 2023

Grapjas updated the diff for D4896: Improving corral tooltips / info.

Had forgot to add the new 2 auras.

Jan 18 2023, 12:43 PM
Grapjas added a comment to D4896: Improving corral tooltips / info.

I don't like that certain values are hard coded text in an aura, if the value changes the text needs to change as well

Jan 18 2023, 12:38 PM
Grapjas added a comment to D4896: Improving corral tooltips / info.

It also maybe seems a bit out of scope for this patch to do all the garrisonHolder stuff, could be a seperate 'nice to have' patch after FF? Since it's also not just about corals in that case anymore. This is just an improvement to tooltips i guess. (or an attempt)

Jan 18 2023, 12:19 PM
Grapjas added a comment to D4896: Improving corral tooltips / info.

I'm split between either method. One is easier to manage because the values are in just 2 files. The other requires quite a bit of rework and values are split across multiple templates and will take longer to balance. But it does add more moddability.

Jan 18 2023, 12:17 PM

Jan 17 2023

Grapjas requested review of D4896: Improving corral tooltips / info.
Jan 17 2023, 9:00 PM

Jan 12 2023

Grapjas awarded rP27429: Bug fix: Use sort order asc by default instead of desc a Like token.
Jan 12 2023, 10:28 PM

Jan 11 2023

Grapjas updated the diff for D4385: Multiplayer lobby ui enchancements .
  • playerlist.sortValue fix
Jan 11 2023, 3:51 PM
Grapjas updated the summary of D4385: Multiplayer lobby ui enchancements .
Jan 11 2023, 3:18 PM
Grapjas added inline comments to D4385: Multiplayer lobby ui enchancements .
Jan 11 2023, 3:18 PM
Grapjas updated the diff for D4385: Multiplayer lobby ui enchancements .

Rebase rP27398 & rP27384

Jan 11 2023, 3:05 PM

Jan 9 2023

Grapjas updated the diff for D4859: optional column "sort_order" attribute support.

nuked useless code.

Jan 9 2023, 1:17 PM

Jan 8 2023

Grapjas updated the diff for D4859: optional column "sort_order" attribute support.

Attribute name change to "sort_order".

Jan 8 2023, 1:53 PM

Jan 7 2023

Grapjas added inline comments to D4859: optional column "sort_order" attribute support.
Jan 7 2023, 9:20 PM
Grapjas updated the diff for D4859: optional column "sort_order" attribute support.

rebase rP27384

Jan 7 2023, 8:18 PM
Grapjas added a comment to D4859: optional column "sort_order" attribute support.

@trompetin17 see inline comment, i took a different route because of error. Don't know if it's proper though.

Jan 7 2023, 2:34 PM
Grapjas updated the diff for D4859: optional column "sort_order" attribute support.
  • changed attribute name sort to sortOrder
  • changed accepted values from 1/-1 to asc/desc
Jan 7 2023, 2:26 PM
Grapjas updated the diff for D4857: add support to change column heading text.

based on suggestion by Phosit

Jan 7 2023, 12:39 PM

Jan 6 2023

Grapjas added a comment to D4859: optional column "sort_order" attribute support.

How does/should it behave if multiple collumns have a sort defined? which does get precedence?

Thats not how the current code works, only 1 column can be actively sorted at a time. The sort attribute is simply read and applied when it gets clicked only.

Jan 6 2023, 1:41 PM

Jan 5 2023

Grapjas updated the diff for D4857: add support to change column heading text.
Jan 5 2023, 10:32 PM
Grapjas abandoned D4858: sort lobby columns in ascended order initially .

with D4859 i'll take a different route

Jan 5 2023, 10:13 PM
Grapjas requested review of D4859: optional column "sort_order" attribute support.
Jan 5 2023, 10:04 PM
Grapjas requested review of D4858: sort lobby columns in ascended order initially .
Jan 5 2023, 9:41 PM
Grapjas updated the summary of D4385: Multiplayer lobby ui enchancements .
Jan 5 2023, 8:08 PM
Grapjas planned changes to D4385: Multiplayer lobby ui enchancements .
Jan 5 2023, 6:51 PM
Grapjas requested review of D4857: add support to change column heading text.
Jan 5 2023, 6:01 PM

Jan 4 2023

wowgetoffyourcellphone awarded D4187: Citizen soldiers attack gaia animals without provocation a Dat Boi token.
Jan 4 2023, 5:04 PM
Grapjas abandoned D4734: Change feedback button color when enabled/disabled.
Jan 4 2023, 12:55 PM · Contributors
Grapjas abandoned D4187: Citizen soldiers attack gaia animals without provocation.
Jan 4 2023, 12:54 PM
Grapjas added a comment to D4385: Multiplayer lobby ui enchancements .

So far this has been a huge waste of time (like all other patches), would something like this ever get committed even if the code would be perfect?

Jan 4 2023, 12:52 PM
Grapjas abandoned D4752: [WIP] - Rebuildable Structures.

No animo.

Jan 4 2023, 12:47 PM
Grapjas added a comment to D4189: Additional loading screen tips.

@marder or anyone else feel free to commandeer.

Jan 4 2023, 12:44 PM
Grapjas abandoned D3286: Allow removing player entities when starting a match.

Unmotivated.

Jan 4 2023, 12:40 PM
Grapjas abandoned D4847: Chat Profanity Filter - WIP.

Probably make it a mod or something sometime.

Jan 4 2023, 12:39 PM

Jan 3 2023

Grapjas added a comment to D4847: Chat Profanity Filter - WIP.

@Norse_Harold getting more tools for moderators is great, in the long run with more moderators - As long as these cases get manually looked at and not auto modded (getting a false positive ban/mute is bad). But that's also the problem, the team is too small and depending who are in it, it may even be flawed. For hosting i think the /ban or kick we have is sufficient enough tbh (and most hosters have autociv anyway).

Jan 3 2023, 11:48 PM
Grapjas added a comment to D4847: Chat Profanity Filter - WIP.

Data (word list) and code needs to be split.

Why?

Jan 3 2023, 10:34 PM

Dec 23 2022

Grapjas added inline comments to D4847: Chat Profanity Filter - WIP.
Dec 23 2022, 11:27 PM
Grapjas requested review of D4847: Chat Profanity Filter - WIP.
Dec 23 2022, 7:54 PM

Aug 21 2022

Grapjas added a comment to D4769: [WIP] unsync attacking / make attacking look more natural.

What did you originally have in mind for this patch? Because i'm only seeing ranged units in the vid and i doubt you will benefit melee soldiers / siege with this since they are already pretty unsynced with their attacks.

Aug 21 2022, 1:13 PM

Aug 20 2022

Grapjas added a comment to D4769: [WIP] unsync attacking / make attacking look more natural.

Yeah but what i suggested was simply a code difference, the behavior would be the same with what you have now. Unless i'm missing something.

Aug 20 2022, 2:42 PM
Grapjas added a comment to D4769: [WIP] unsync attacking / make attacking look more natural.

This idea is kind of growing on me tbh. You could also set the PrepareTime once on unit creation. I kind of dig the idea that not every soldier has the same reaction time.

Aug 20 2022, 2:25 PM
Grapjas awarded D4771: [WIP] Tree falling a Love token.
Aug 20 2022, 1:41 PM
Grapjas added a comment to D4769: [WIP] unsync attacking / make attacking look more natural.

that would also be an interesting option, although then it would only work for formations :)

Ah my bad, i thought that was the point ^^.

Aug 20 2022, 12:18 PM

Aug 19 2022

Grapjas added a comment to D4769: [WIP] unsync attacking / make attacking look more natural.

afaik PrepareTime is only used on the initial attack, didnt fact check though it's off the top of my head. In that case i think you can achieve the same result by making that gap for randomnization wider and leave the RepeatTime unaltered. Not sure about all the OOS stuff so i leave that to someone else.

Aug 19 2022, 8:39 PM
Grapjas added a comment to D4769: [WIP] unsync attacking / make attacking look more natural.

How often does GetTimers get called? On each attack?

Aug 19 2022, 11:53 AM

Aug 10 2022

Grapjas updated the diff for D4752: [WIP] - Rebuildable Structures.

Not too sure about the SetRebuildableFromEnt name but it's a WIP after all. Added get/set functions in Foundation.

Aug 10 2022, 12:43 PM

Aug 8 2022

Grapjas accepted rP27034: Revert r26956 / rP26956..

Units in formation respond fluently to new targets, as shown here. (Tested @ 27036)

Aug 8 2022, 7:33 PM
Grapjas resigned from rP26956: Make formations respond as one to threats..
Aug 8 2022, 7:28 PM
Grapjas added a comment to rP26956: Make formations respond as one to threats..

Yeah but isn't that on a different page? What do i need to do here?

Aug 8 2022, 7:20 PM
Grapjas added a comment to rP26956: Make formations respond as one to threats..

What is expected from "This commit now requires verification by auditors."?

Aug 8 2022, 4:20 PM
Grapjas added inline comments to D4187: Citizen soldiers attack gaia animals without provocation.
Aug 8 2022, 4:11 PM

Aug 7 2022

Grapjas updated the diff for D4752: [WIP] - Rebuildable Structures.

Patch based on comments. Hopefully fixed build issues too.

Aug 7 2022, 3:15 PM
Grapjas raised a concern with rP26956: Make formations respond as one to threats..

This unfortunately breaks units responding properly to enemy units while in formation. Reported on the forum (read from that point and onwards). Video of the behavior

Aug 7 2022, 1:42 PM

Aug 6 2022

Grapjas requested review of D4752: [WIP] - Rebuildable Structures.
Aug 6 2022, 3:02 PM

Aug 5 2022

Grapjas updated the diff for D4187: Citizen soldiers attack gaia animals without provocation.

Units respond to entities given their stance / occupation and go back to their orders after.

Aug 5 2022, 2:05 PM

Aug 2 2022

Grapjas abandoned D4186: Corrected hasDealtWithTech in TriggerHelper.
Aug 2 2022, 5:06 PM
Grapjas added a comment to D4187: Citizen soldiers attack gaia animals without provocation.
In D4187#202143, @lyv wrote:
  • Is the gaia animal UnitAI supposed to handle the behavior of the player entities being attacked?

Doesn't have to be but it saves me from setting the cmpUnitAI twice in the current code. EDIT: I could've done UnitAI.prototype.PingForHelp(this.target, this.entity); too.

  • Should cmpAttack actually care for this at all?

Haven't checked all functions in UnitAI, but the attack function there only reacts to manual input. But i agree that along with your 3rd point this is not required in that case.

  • Perhaps UnitAI should instead do this in INDIVIDUAL.ATTACKED state transition if the attacking entity is a dangerous animal and call nearby entities with the same owner.

sure but then it loses moddability / possibly other use cases.

Aug 2 2022, 4:56 PM
Grapjas updated the diff for D4187: Citizen soldiers attack gaia animals without provocation.

Moved to UnitAI as advised, added radius param.

Aug 2 2022, 4:13 PM
Grapjas added a comment to D4187: Citizen soldiers attack gaia animals without provocation.

@marder I was actually considering that too. I'm fine either way.

Aug 2 2022, 3:53 PM
Grapjas updated the diff for D4187: Citizen soldiers attack gaia animals without provocation.

Had forgot to remove some test code. Fixed.

Aug 2 2022, 3:48 PM
Grapjas updated the diff for D4187: Citizen soldiers attack gaia animals without provocation.

When an aggressive animal attacks a unit, it will send a ping in a 60 (up for discussion obv) radius to owned idle units. They will come to aid. This should also fix the issue that Sillier brought up.

Aug 2 2022, 3:42 PM

Jul 31 2022

Grapjas updated the diff for D4745: Espionage rework - Hide diplomacy and stats of enemy units.

Edited the espionage tech description to fit the new mechanic.

Jul 31 2022, 2:23 PM

Jul 30 2022

Grapjas updated the summary of D4745: Espionage rework - Hide diplomacy and stats of enemy units.
Jul 30 2022, 5:46 PM
Grapjas updated the diff for D4745: Espionage rework - Hide diplomacy and stats of enemy units.

Should fix most lint issues.

Jul 30 2022, 5:42 PM

Jul 29 2022

asterix awarded D4745: Espionage rework - Hide diplomacy and stats of enemy units a Love token.
Jul 29 2022, 8:44 PM
marder awarded D4745: Espionage rework - Hide diplomacy and stats of enemy units a Like token.
Jul 29 2022, 7:24 PM
Freagarach awarded D4745: Espionage rework - Hide diplomacy and stats of enemy units a Love token.
Jul 29 2022, 6:50 PM
Grapjas added inline comments to D4745: Espionage rework - Hide diplomacy and stats of enemy units.
Jul 29 2022, 2:24 PM
Grapjas requested review of D4745: Espionage rework - Hide diplomacy and stats of enemy units.
Jul 29 2022, 2:12 PM

Jul 24 2022

Grapjas updated subscribers of D4740: [WIP] - Allow to limit the structures a builder can construct..

As for your test plan (assuming you have SVN installed), you could do something like this ingame: Go to singleplayer -> matches. Make player 1 and player 2 allies, give player 1 The Athenians civ and player 2 the Carthaginians Civ. ingame in chat enter gift from the gods cheat. With ALT+D you can open dev console, you'll see a change perspective option, click it and next to the menu button on top right side you can change to player 2. Make a foundation for an Embassy building (but don't build it). Now change perspective back to player 1 and see what your check does.

Jul 24 2022, 1:57 PM

Jul 15 2022

Grapjas updated the diff for D4734: Change feedback button color when enabled/disabled.

Changed colors to: green to enable feedback, red to disable it.

Jul 15 2022, 2:16 PM · Contributors
Grapjas added a comment to D4734: Change feedback button color when enabled/disabled.

In retrospect, red makes it look like you can't interact with it, maybe green would be better. I'm not sure.

Jul 15 2022, 12:35 PM · Contributors
Grapjas requested review of D4734: Change feedback button color when enabled/disabled.
Jul 15 2022, 12:28 PM · Contributors

Apr 6 2022

Grapjas added a comment to D4385: Multiplayer lobby ui enchancements .

I agree with everything else, will fix it sometime. Thanks for reviewing.

Apr 6 2022, 6:36 PM

Jan 23 2022

Grapjas added a comment to D4450: texture update for polar sea.

Looks way better, i vote commit.

Jan 23 2022, 10:29 PM
Grapjas added a comment to D4385: Multiplayer lobby ui enchancements .

Also D4009 would be pretty great to have along this patch if @Langbart finds time/motivation for it. Because then users can change lobby colors / settings from within the lobby, too. And #6418 is kind of an issue too, with or without this patch (idk c++ so i can't)

Jan 23 2022, 10:17 PM
Grapjas updated the summary of D4385: Multiplayer lobby ui enchancements .
Jan 23 2022, 1:48 PM
Grapjas added a comment to D4385: Multiplayer lobby ui enchancements .

@Silier I don't have a strong opinion about it. It can now be explained in the new lobby colors menu, if it stays. Though it seems like my current explanation for it is wrong (options.json L639), and that still requires some steps before the user sees that. What do you prefer yourself?

Jan 23 2022, 12:22 PM

Jan 22 2022

Grapjas added a comment to D4385: Multiplayer lobby ui enchancements .

you can also ask users/players on forums for more feedback and testing

Jan 22 2022, 4:47 PM
Grapjas updated the diff for D4385: Multiplayer lobby ui enchancements .
  • Reduced max characters for a game name to 100 from 256.
  • Unrated players are not 1200 rating by default anymore but 0, and they are not included into calculating the avg. rating of the game (g_DefaultLobbyRating doesn't affect the actual rating afaik?).
  • Mods like "custom rating" caused wrong avg gamerating calculation. Fixed while keeping mods like that compatible.
  • Games in gamelist that only have unrated players will not show the avg rating.
  • Fix for playername tooltip in gamedetails in case of unknown civ.
  • Appended buddysymbol to playernames in chat if buddy.
  • Made chat messages text lightgray.
  • Users can disable/enable abbreviated mapsize names in the main menu -> lobby / networking options (visible in summary screenshot). Default mapsize values show no mapsize.
  • Users can customize the symbol of status and buddies to a letter/number/symbol of their choosing in the main menu -> networking / lobby.
  • Users can customize the colors of the following elements in the main menu -> lobby colors:

Jan 22 2022, 3:00 PM

Jan 17 2022

Grapjas added a comment to D4009: [WIP] - Adding some buttons to the lobby page.

Even though i really like the functionality (wanted to make an option button for D4385 but found this patch), i agree that there are too many buttons. Maybe just a single "Lobby Menu" button could do the trick, displaying a popup window where you can find the rest of the buttons.

Jan 17 2022, 3:49 PM
Grapjas requested review of D4383: Macedonian catafalque fixes.

It's actually working, was just looking with the wrong build. (sorry for spam)

Jan 17 2022, 1:22 PM
Grapjas planned changes to D4383: Macedonian catafalque fixes.

Second aura isn't showing up in the catafalque overview in the main menu.

Jan 17 2022, 12:43 PM
Grapjas requested review of D4383: Macedonian catafalque fixes.
Jan 17 2022, 12:38 PM

Jan 16 2022

Grapjas planned changes to D4383: Macedonian catafalque fixes.

I think changing the ResourceTrickle to a global aura is a step in the wrong direction, to be honest.

Jan 16 2022, 11:28 PM
Grapjas updated the summary of D4385: Multiplayer lobby ui enchancements .
Jan 16 2022, 11:08 PM
Grapjas updated the diff for D4385: Multiplayer lobby ui enchancements .
  • Added player tooltips when hovering over playernames in gamedetails. (and found a new bug: #6418)
Jan 16 2022, 5:39 PM

Jan 15 2022

Grapjas updated the diff for D4385: Multiplayer lobby ui enchancements .
  • All columns start with ascending order when clicked instead of descending order. Only playerrating column starts with descending order
Jan 15 2022, 8:10 PM

Jan 13 2022

Grapjas commandeered D3286: Allow removing player entities when starting a match.
Jan 13 2022, 5:30 PM

Jan 12 2022

Grapjas added a comment to D4383: Macedonian catafalque fixes.

@Freagarach If that's the case then all other catafalque's would need modification too. Would need some confirmation which way to go though.

Jan 12 2022, 6:39 PM