Page MenuHomeWildfire Games
Feed Advanced Search

Yesterday

Nescio added a comment to D2426: Allow world population..

Great improvements, thanks again!
Two minor things. Firstly, without the world cap the default is 300, so with it 600 would be a sensible default (so in a two-player game they still start with 300).
Secondly, perhaps instead of two lines:

or

it could be reduced to just one: “Individual Population Cap” vs “World Population Cap”. The more lines there are displayed, the less readable the information typically becomes.

Mon, Nov 18, 4:15 PM
Nescio added a comment to D2429: [gui] building → structure.

The patch is rather small when considering the amount of buildings that should be renamed to structure, but I reckon you've deliberately only changed non-code stuff.

Yes, I intentionally avoided code (my understanding is limited) and looked only inside the gui/ folder (to keep it reviewable).

Another thing: how about construction?

Maybe something for a future patch. Let's focus this one on building → structure.

Mon, Nov 18, 3:59 PM
Nescio updated the diff for D2429: [gui] building → structure.

Added some full stops per @Freagarach.

Mon, Nov 18, 3:53 PM
Nescio added a comment to rP23160: Bolt tower and ampitheater commit, updated ptolemaic sentry tower while I was….

Furthermore, “amphitheatre” (ἀμφιθέατρον) is written with a ph, not a p; please correct.

Mon, Nov 18, 11:21 AM

Sun, Nov 17

Nescio added a comment to D2430: list “Credits” above “Exit”.

Also, the licences are nowhere displayed in game; or am I mistaken?

Sun, Nov 17, 11:17 AM
Nescio updated the summary of D2430: list “Credits” above “Exit”.
Sun, Nov 17, 11:06 AM
Nescio created D2430: list “Credits” above “Exit”.
Sun, Nov 17, 11:05 AM
Nescio added a comment to rP23143: New bluefin tuna mesh and shoal..

gaia/fauna_fish_tuna.xml actually ought to be named gaia/fish/tuna.xml since it inherits from template_gaia_fish.xml, not from template_unit_fauna.xml. Just a reminder; it's out of scope of this patch, though.

Sun, Nov 17, 10:04 AM
Nescio updated the diff for D2312: Single Player → single-player.

Maintain title case in options.

Sun, Nov 17, 9:33 AM
Nescio added inline comments to D2312: Single Player → single-player.
Sun, Nov 17, 9:22 AM

Sat, Nov 16

Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

“building” → “structure” incorporated in D2429.

Sat, Nov 16, 8:52 PM
Nescio created D2429: [gui] building → structure.
Sat, Nov 16, 8:50 PM
Nescio added a comment to D2427: Alphabetize programming credits.

Also, credits look ugly. It would be much better if nick and name were listed in two columns, the left one aligned to the right, the right to the left.
(Again, outside the scope of this patch.)

Sat, Nov 16, 8:17 PM
Nescio created D2428: main menu item tooltip corrections..
Sat, Nov 16, 8:07 PM
Nescio updated subscribers of D2427: Alphabetize programming credits.

Also, @Stan is in the credits listed as stanislas69.

Sat, Nov 16, 7:59 PM
Nescio created D2427: Alphabetize programming credits.
Sat, Nov 16, 7:58 PM
Nescio added inline comments to D2106: Move hardcoded gain per garrisoned trader on ship to template.
Sat, Nov 16, 6:32 PM
Nescio added inline comments to D2312: Single Player → single-player.
Sat, Nov 16, 6:24 PM
Nescio updated the diff for D2312: Single Player → single-player.

Rebased. Please check.

Sat, Nov 16, 6:23 PM
Nescio added a comment to D2226: Use standarized phrasing and terminology for the Patriot aura description.

Capture attack is an attack, though; as is slaughter attack; e.g. template_unit_infantry.xml:

Sat, Nov 16, 1:43 PM
Nescio added a comment to D2312: Single Player → single-player.

Yes, single-player is an adjective, as is multiplayer; I don't think I claimed otherwise.
Please have a careful look at the affected lines and point out which ought to be changed.
I believe in none these cases the meaning is as in “He is a single player.”

Sat, Nov 16, 1:41 PM
Nescio added a comment to D2426: Allow world population..

Interestingly, the winning player (green) seems to remain active (bartering) after defeating its opponent (blue):


Replay:

Sat, Nov 16, 1:04 PM
Nescio added a comment to D2426: Allow world population..

Yeah, but it's unexpected. 300/1 is not 300/0.

Sat, Nov 16, 12:43 PM
Nescio added a comment to D2426: Allow world population..

Strange, this does not happen with me? Where did it show that? Is that on SVN or A23b?

svn, observer mode, after a player has won.

(Perhaps even nicer would be a slider?)

Personally I prefer discrete options.

Sat, Nov 16, 12:30 PM
Nescio added a comment to D2312: Single Player → single-player.

The hyphen is there to avoid ambiguity. I don't think in any of the lines changed here “single player” or “singeplayer” would be better than “single-player”.
Also, for what's worth:
https://www.lexico.com/en/definition/single-player
https://www.lexico.com/en/definition/multiplayer
https://en.wikipedia.org/wiki/Hyphen#Varied_meanings

Sat, Nov 16, 12:26 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

It's been a while since last time I looked at this. Whilst I agree this has become a large patch, it's not obvious to me which changes are straightforward and which are potentially controversial.
Feel free to commandeer and split or update as you see fit.

Sat, Nov 16, 12:04 PM
Nescio added a comment to D2426: Allow world population..

Great feature, thanks!
I tried one game with three AI players and a world population cap of 300. When one player was defeated, the population cap went up as expected (100→150), but when another was beaten, the surviving player was displayed as having a maximum population of “Infinity”, which is odd, because that didn't happen without this patch (i.e. always at 300).

Sat, Nov 16, 12:01 PM

Oct 3 2019

Nescio added a comment to D2348: Civ specific AI name numbers, don't hardcode roman numbers in the gamesetup.

Also, as @Stan pointed out, e.g Arsinoe II II looks weird.

Oct 3 2019, 7:40 PM
Nescio added a comment to D2348: Civ specific AI name numbers, don't hardcode roman numbers in the gamesetup.

All civilizations have at least eight different AI names, so why do we need these numerals?

Oct 3 2019, 10:55 AM

Sep 29 2019

Nescio added inline comments to D2222: {civ}.json style corrections.
Sep 29 2019, 7:26 PM
Nescio updated the diff for D2222: {civ}.json style corrections.

" :":

Sep 29 2019, 12:52 PM
Nescio updated the diff for D2222: {civ}.json style corrections.
Sep 29 2019, 10:02 AM

Sep 26 2019

Nescio added a comment to rP22748: Update outdated icons and last updated cavalry icons to use the new horse assets.

Wouldn't it be better if there were a one-on-one correspondence between icons and actors, i.e. a different portrait for each rank? (E.g. basic blue, advanced green, elite yellow, champion red.)

Sep 26 2019, 9:07 PM
Nescio added a comment to rP22527: Easier introduction of new damage types..

Either restore the order to H-P-C or alphabetize it to C-H-P, but make sure it's consistent throughout the entire game.

Sep 26 2019, 12:40 PM
Nescio added a comment to rP22995: Fix alphabetic template order using templatessorter.sh..

Nice catch!

Sep 26 2019, 12:37 PM

Sep 23 2019

Nescio added a comment to rP22982: Move palisades from other/ to structures/.

Though palisade without s would be more correct; wall, gate, fence are not pluralized either. And stables was finally corrected to stable a couple of months ago.

Sep 23 2019, 5:22 PM
Nescio created D2324: list heroes after champions and correct some structure tooltips.
Sep 23 2019, 11:41 AM
Nescio abandoned D1349: Enables new military structures.
Sep 23 2019, 11:21 AM
Nescio created D2323: Remove redundant macedonian workshop coding, template uses; follow up to rP22984.
Sep 23 2019, 11:17 AM
Nescio added a comment to rP22984: Enable workshops for all civilisations..

Thank you for committing this!

list champions before heroes in the production queues of fortresses

Where is this?

Meh, it's not in there, shouldn't have trusted the description.

It was there in https://code.wildfiregames.com/D1761?id=7871, but I didn't include it in https://code.wildfiregames.com/D1761?id=9552 and apparently forgot to update the summary, my mistake.

Sep 23 2019, 10:53 AM
Nescio added a comment to rP22982: Move palisades from other/ to structures/.

Out of curiosity, why did you decide to keep the final s? https://code.wildfiregames.com/D2234?id=9536 moved the templates to palisade_*, without s.

Sep 23 2019, 10:51 AM

Sep 22 2019

Nescio updated the diff for D2307: improve default.cfg comments.
Sep 22 2019, 9:30 PM
Nescio added inline comments to D2307: improve default.cfg comments.
Sep 22 2019, 9:28 PM
Nescio updated the diff for D2307: improve default.cfg comments.

End sentences with a full stop.

Sep 22 2019, 9:28 PM
Nescio added a comment to D2306: remove "Goods" from trade window stings.

By the way, why does it say <repeat count="10"> in line 35 but <repeat count="8"> in line 72?

Sep 22 2019, 9:08 PM
Nescio added inline comments to D2306: remove "Goods" from trade window stings.
Sep 22 2019, 9:05 PM
Nescio updated the diff for D2306: remove "Goods" from trade window stings.
Sep 22 2019, 9:05 PM
Nescio added inline comments to D2305: more gui/manual/intro.txt improvements.
Sep 22 2019, 9:54 AM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
Sep 22 2019, 9:53 AM
Nescio updated the diff for D2307: improve default.cfg comments.

"or replay"

Sep 22 2019, 9:49 AM

Sep 21 2019

Nescio added a comment to D1958: Turrets and/or sub-units..

Sentry?

https://www.lexico.com/en/definition/sentry

Sep 21 2019, 10:08 AM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

Another question, which of the following do you think is best?

  1. PgUp and PgDn
  2. PageUp and PageDown
  3. Page Up and Page Down
  4. PgUp (Page Up) and PgDn (Page Down)
Sep 21 2019, 9:44 AM
Nescio updated the summary of D2305: more gui/manual/intro.txt improvements.
Sep 21 2019, 9:41 AM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

Why no colons? It introduces a list, f.e. https://www.thepunctuationguide.com/colon.html

No colon because these are section headers. Cf. the following:

Sep 21 2019, 9:36 AM
Nescio added inline comments to D2309: Fix missing tooltip function in replay menu following loadgame and savegame unification rP22923 / D2290.
Sep 21 2019, 9:24 AM

Sep 20 2019

Nescio added inline comments to D2309: Fix missing tooltip function in replay menu following loadgame and savegame unification rP22923 / D2290.
Sep 20 2019, 6:46 PM
Nescio added inline comments to D2312: Single Player → single-player.
Sep 20 2019, 6:37 PM
Nescio updated the diff for D2312: Single Player → single-player.
Sep 20 2019, 6:32 PM
Nescio created D2312: Single Player → single-player.
Sep 20 2019, 6:21 PM
Nescio added inline comments to D2309: Fix missing tooltip function in replay menu following loadgame and savegame unification rP22923 / D2290.
Sep 20 2019, 6:10 PM
Nescio added inline comments to D2309: Fix missing tooltip function in replay menu following loadgame and savegame unification rP22923 / D2290.
Sep 20 2019, 6:08 PM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
Sep 20 2019, 6:07 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

Two very good points, thanks! Those section captions should have neither title case nor colons; I'll check and correct them all.

Sep 20 2019, 5:55 PM
Nescio added a comment to D2309: Fix missing tooltip function in replay menu following loadgame and savegame unification rP22923 / D2290.

Check whether the patch is complete (wink wink). Check the phrasing of the tooltip and Intro.txt advertizement [sic] of the hotkeys to reflect that they are used in both pages.

It's probably just a typo, but to advertise is written with -ise in all variaties of English, including American, never with -ize. (Likewise, to capsize is always written with -ize, never -ise. The -ise/-ize UK/US difference only applies to words going back to Greek -ιζ- verbs.)

Sep 20 2019, 5:49 PM
elexis awarded D2307: improve default.cfg comments a Like token.
Sep 20 2019, 1:25 PM

Sep 19 2019

Nescio added inline comments to D2305: more gui/manual/intro.txt improvements.
Sep 19 2019, 9:40 PM
Nescio added inline comments to D2305: more gui/manual/intro.txt improvements.
Sep 19 2019, 9:22 PM
Nescio added inline comments to D2305: more gui/manual/intro.txt improvements.
Sep 19 2019, 9:16 PM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
Sep 19 2019, 9:16 PM
Nescio created D2307: improve default.cfg comments.
Sep 19 2019, 9:00 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

The changes in this diff arent so worthy for concern if it wasnt a pattern to ignore default.cfg that had led to many mistakes before that would have been found if carefully compared and always cosidered.

Isn't it actually more of a problem that people change keys in the default.cfg file but forget to update the intro.txt file?

Sep 19 2019, 8:39 PM
Nescio added inline comments to D2305: more gui/manual/intro.txt improvements.
Sep 19 2019, 8:36 PM
Nescio added inline comments to D2305: more gui/manual/intro.txt improvements.
Sep 19 2019, 8:27 PM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
Sep 19 2019, 8:25 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

By the way, shouldn't there be a hotkey to open the Manual?

Sep 19 2019, 8:20 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

Why change anticlockwise to counterclockwise in one file but not in the other?
There actually was no argument provided why it was right to change the string in D1744, but I suppose it's because the word is more common, regardless whether you're a developer or player.

The reason is “anticlockwise” is English and “counterclockwise” is American. Spelling and vocabulary differences matter for translations, but not really for comments in code.

Why changing building to structure in one file but not the other?

Well, I suppose I could change that and similar things in the default.cfg too, but I still think it would be better to do that in a separate patch.

Why describe different behavior for the same hotkey in different places?

?

Sep 19 2019, 8:14 PM
Nescio created D2306: remove "Goods" from trade window stings.
Sep 19 2019, 7:34 PM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
  • put window names inside quotation marks
Sep 19 2019, 7:20 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

One example, default.cfg has:

screenshot = F2                          ; Take PNG screenshot
bigscreenshot = "Shift+F2"               ; Take large BMP screenshot

and intro.txt has:

F2 – Take screenshot (in .png format, location is displayed in the top left of the GUI after the file has been saved, and can also be seen in the console/logs if you miss it there)
Shift + F2 – Take huge screenshot (6400×4800 pixels, in .bmp format, location is displayed in the top left of the GUI after the file has been saved, and can also be seen in the console/logs if you miss it there)

In my honest opinion neither replacing the concise former with the verbose former nor vice versa would be an improvement.

Sep 19 2019, 7:13 PM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
Sep 19 2019, 7:11 PM
Nescio added inline comments to D2305: more gui/manual/intro.txt improvements.
Sep 19 2019, 6:36 PM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
Sep 19 2019, 6:29 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

That was the part that I was wondering about in D2273.

Yes, I saw your post there today, which prompted me to change it again in this patch.

Sep 19 2019, 6:08 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

The same changes should be applied to default.cfg in the same patch I suppose?

Actually I had a look at the binaries/data/config/default.cfg file, but quickly noticed it's too different from the gui/manual/intro.txt file:

  • it includes many other settings not in the manual
  • it doesn't list many of the manual entries (esp. those that involve clicking or specify multiple cases)
  • completely different order
  • different format ("code = key ; comment" instead of "key: function")
  • file is for developers, does not really contain user-facing text strings
  • already out of sync prior to D1719

Taking everything together, I concluded it's too much work and not really necessarily a good idea to update the default.cfg to match the intro.txt file.

Sep 19 2019, 5:57 PM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
Sep 19 2019, 2:57 PM
Nescio created D2305: more gui/manual/intro.txt improvements.
Sep 19 2019, 2:53 PM

Sep 17 2019

Nescio added a comment to D1960: Move the controllability of an entity to a component..

Good point! (e.g. “walking ships”)

Sep 17 2019, 10:18 AM
Nescio added a comment to rP22904: manual/intro.txt corrections.

Thanks, that explains why I couldn't find it in the public folder!

Sep 17 2019, 10:09 AM
Nescio added a comment to rP22904: manual/intro.txt corrections.

Where and what is default.cfg?

Sep 17 2019, 10:02 AM
Nescio created D2300: single walking speed for all citizen infantry.
Sep 17 2019, 10:00 AM
Nescio added a comment to D1960: Move the controllability of an entity to a component..

Thanks for the clarifications!

Sep 17 2019, 9:50 AM
Nescio added a comment to D1960: Move the controllability of an entity to a component..

template_bird.xml is not an unit.
How about structures? Those have neither <Controllable>false</Controllable> nor <Controllable>true</Controllable>? I know structures can't move, but they still can get orders (attack, set rally point, ungarrison)?

Sep 17 2019, 9:40 AM
Nescio added a comment to D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.

With this patch, the History and Structure Tree behaviour in A24 seems to be the same as it was in A23, both in pre-game main menu and in in-game session:

  • pressing Alt+Shift+H/T opens History/Structure Tree
  • pressing Alt+Shift+H/T again when History/Structure Tree is already open, closes it
  • clicking the Structure Tree button in History opens Structure Tree
  • clicking the History button in Structure Tree opens History
Sep 17 2019, 9:37 AM
Nescio added a comment to D1960: Move the controllability of an entity to a component..

Not necessarily, when a unit is not owned it can't be moved around, this patch allows any entity that is owned to be moved around, regardless of whether it is an animal or not.

So if I understand correctly, all units are now controllable? Is adding the <Controllable>true</Controllable> node then still necessary?

Sep 17 2019, 9:09 AM

Sep 15 2019

Nescio added a comment to D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.

gui/manual/intro.txt has to be redone because of D2110/rP22904.

Sep 15 2019, 7:37 PM
Nescio updated the diff for D2000: aura style corrections.

Rebased because of D1808/rP22905.

Sep 15 2019, 7:20 PM
Nescio added a comment to D2226: Use standarized phrasing and terminology for the Patriot aura description.

Still, the question remains whether using “attack speed” is indeed clearer and less confusing than “attack time”. Also, how about similar stats (e.g. entities' <Cost/BuildTime>, healers' <Heal/Rate>, siege engines' <Pack/Time>, etc.)?

Sep 15 2019, 7:09 PM
Nescio added a comment to D1808: standardized hero aura descriptions.

Thank you, I'm glad this one is finally committed!

Sep 15 2019, 6:34 PM

Sep 13 2019

Nescio added inline comments to D2286: Notify renamed entities about value modifications when created.
Sep 13 2019, 2:46 PM
Nescio added a comment to D1960: Move the controllability of an entity to a component..

Shouldn't template_unit_fauna.xml have <Controllable> set to false and template_unit_fauna_herd_domestic.xml and gaia/fauna_arctic_wolf_domestic.xml true?

Sep 13 2019, 1:00 PM