Page MenuHomeWildfire Games
Feed All Stories

Aug 9 2019

Nescio added inline comments to D1806: standardized structure aura descriptions.
Aug 9 2019, 9:42 AM
autobuild committed rP22634: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Aug 9 2019, 9:25 AM
autobuild committed rP22633: [Windows] Automated build..
[Windows] Automated build.
Aug 9 2019, 8:08 AM
Gallaecio committed rP22632: English review of cavalry unit references.
English review of cavalry unit references
Aug 9 2019, 7:49 AM
Gallaecio added a comment to D1614: English review of cavalry unit references.

https://code.wildfiregames.com/rP22632

Aug 9 2019, 7:49 AM
Gallaecio closed D1614: English review of cavalry unit references.
Aug 9 2019, 7:49 AM
Gallaecio closed D1805: acropolis → citadel (non-Greek fort), plateau (orography).

https://code.wildfiregames.com/rP22631

Aug 9 2019, 7:38 AM
Gallaecio committed rP22631: acropolis → citadel (non-Greek fort), plateau (orography).
acropolis → citadel (non-Greek fort), plateau (orography)
Aug 9 2019, 7:38 AM
Gallaecio added a comment to D1613: Improve the plural translation of the "<players> have won" string.
In D1613#75586, @bb wrote:

For me (as programmer) this isn't a bug in our code, but it is a bug in the translation

Aug 9 2019, 7:23 AM
Harbormaster failed remote builds in B8788: Diff 9273 for D1820: island → peninsula!
Aug 9 2019, 7:13 AM
Vulcan added a comment to D1820: island → peninsula.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 9 2019, 7:13 AM
Gallaecio updated the diff for D1820: island → peninsula.

Great idea!

Aug 9 2019, 7:13 AM
Gallaecio added inline comments to D1806: standardized structure aura descriptions.
Aug 9 2019, 7:10 AM

Aug 8 2019

autobuild committed rP22630: [Windows] Automated build..
[Windows] Automated build.
Aug 8 2019, 9:19 PM
Vulcan added a comment to D2162: Do not stack fleeing orders..

Successful build - Chance fights ever on the side of the prudent.

Aug 8 2019, 4:33 PM
Freagarach added inline comments to D2162: Do not stack fleeing orders..
Aug 8 2019, 4:30 PM
Freagarach created D2162: Do not stack fleeing orders..
Aug 8 2019, 4:28 PM
elexis added a comment to rP22629: Revert use of the `isRunOnce` flag after removal in rP22627 of compile'n go….

Why does the code count as !runOnce?

Aug 8 2019, 4:00 PM
Freagarach added a comment to D2160: Make sure entities do not damage entities out of range..

Yeah, I meant that a cavalry unit attacking is a turret on the horse or something. That the cavalry can move while attacking.

Aug 8 2019, 3:34 PM
Stan added a comment to D2160: Make sure entities do not damage entities out of range..

Also we do have turrets (just a subset) with visible garrisoning.

Aug 8 2019, 3:32 PM
Stan awarded rP22629: Revert use of the `isRunOnce` flag after removal in rP22627 of compile'n go… a Love token.
Aug 8 2019, 3:29 PM
Stan added a comment to rP22629: Revert use of the `isRunOnce` flag after removal in rP22627 of compile'n go….

Thanks for the fix ! I was about to report it
For the record, when running tests in debug (maybe release too) it triggered the following error.

Assertion failure: !options.isRunOnce, at ./libraries/source/spidermonkey/mozjs-45.0.2/js/src/frontend/BytecodeCompiler.cpp:846

(I removed the path with strangely linked to Itm's folders)

Aug 8 2019, 3:28 PM
elexis added a comment to D2020: Refactors Camera aspect ratio and calculation of plane points.

Fixes @elexis's notes from IRC (2019-07-03#0ad-dev):
I didn't fix 22:02 < elexis> Vladislav: quad[0] = { ... } ?, because I didn't check that the code have to be inlined. So probably later.

Aug 8 2019, 3:10 PM
elexis awarded rP7336: Support <repeat> in the GUI XML files, as a primitive mechanism to simplify the… a Orange Medal token.
Aug 8 2019, 2:33 PM
elexis added a comment to rP22629: Revert use of the `isRunOnce` flag after removal in rP22627 of compile'n go….

broke a SM assertion

Aug 8 2019, 1:23 PM
Freagarach created D2161: Also account for elevation for melee units..
Aug 8 2019, 12:46 PM
FeXoR raised a concern with rP22615: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb….

This seems to introduce #5554 so I raised a concern.

Aug 8 2019, 11:22 AM
Freagarach added a comment to D2160: Make sure entities do not damage entities out of range..

I couldn't find the ticket but you're right. We need turrets ;)
(For what it's worth: this does seem to fix #5541.)

Aug 8 2019, 11:16 AM
Itms committed rP22629: Revert use of the `isRunOnce` flag after removal in rP22627 of compile'n go….
Revert use of the `isRunOnce` flag after removal in rP22627 of compile'n go…
Aug 8 2019, 11:06 AM
Itms added a comment to rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893..

The setIsRunOnce addition must be reverted.

Aug 8 2019, 10:56 AM
FeXoR added a comment to rP22604: Implement IGUIObject settings as a template class and IGUIObject::AddSetting as….

I agree adding your "C++17 removing diff" would be the way to go here.
If you already created a Phabricator differential a link to that here would be nice.

Aug 8 2019, 10:40 AM
wraitii added a comment to D2160: Make sure entities do not damage entities out of range..

Hey, this is wrong in fact :) It's this way on purpose - probably from svn blame you can find the tickets where it was discussed.

Aug 8 2019, 10:36 AM
Vulcan added a comment to D2160: Make sure entities do not damage entities out of range..

Successful build - Chance fights ever on the side of the prudent.

Aug 8 2019, 10:12 AM
Freagarach created D2160: Make sure entities do not damage entities out of range..
Aug 8 2019, 10:06 AM
Harbormaster failed to build B8781: rP22628: Precompiled SpiderMonkey 45 and nspr 4.12 for Windows. for rP22628: Precompiled SpiderMonkey 45 and nspr 4.12 for Windows.!
Aug 8 2019, 1:33 AM
Harbormaster failed to build B8780: rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893. for rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893.!
Aug 8 2019, 1:06 AM
Itms committed rP22628: Precompiled SpiderMonkey 45 and nspr 4.12 for Windows..
Precompiled SpiderMonkey 45 and nspr 4.12 for Windows.
Aug 8 2019, 12:45 AM
elexis awarded rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893. a Party Time token.
Aug 8 2019, 12:39 AM
Itms committed rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893..
Upgrade SpiderMonkey to version 45.0.2, refs #4893.
Aug 8 2019, 12:38 AM
Itms closed D1510: Update to Spidermonkey 45.0.2.
Aug 8 2019, 12:38 AM

Aug 7 2019

elexis accepted D1510: Update to Spidermonkey 45.0.2.
  1. Verification of the SpiderMonkey zip:
sha256sum mozjs-45.0.2.tar.bz2
570530b1e551bf4a459d7cae875f33f99d5ef0c29ccc7742a1b6f588e5eadbee  mozjs-45.0.2.tar.bz2

https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Releases/45
Ack

Aug 7 2019, 8:59 PM
Freagarach planned changes to D2016: Rename "ElevationBonus" and "Delay" to "Origin" and "EffectDelay", respectively..

Rename ElevationRangeBonus to AttackHeightOffset and move it back from the projectile to the attack itself, since it is the the height from which the attack occurs. UnitAI already only adds parabolic range to "Projectile" attacks. When turrets are implemented, units on horses/chariots etc. can also have a HeightBonus. The horizontal range of "non-projectile" units should actually be smaller when there is a height difference.

Aug 7 2019, 8:30 PM
elexis committed rP22626: Fix gcc 8 compiler warning in FileIo.cpp about truncating use of strncpy….
Fix gcc 8 compiler warning in FileIo.cpp about truncating use of strncpy…
Aug 7 2019, 5:38 PM
elexis closed D2159: Fix FileIo.cpp gcc 8 compile warning about strncpy use without copying the null-termination [-Wstringop-truncation].
Aug 7 2019, 5:38 PM
Vulcan added a comment to D2159: Fix FileIo.cpp gcc 8 compile warning about strncpy use without copying the null-termination [-Wstringop-truncation].

Successful build - Chance fights ever on the side of the prudent.

Aug 7 2019, 5:30 PM
elexis created D2159: Fix FileIo.cpp gcc 8 compile warning about strncpy use without copying the null-termination [-Wstringop-truncation].
Aug 7 2019, 5:25 PM
Vulcan added a comment to D2140: Let players be able to choose a preferred attack type..

Successful build - Chance fights ever on the side of the prudent.

Aug 7 2019, 5:23 PM
Harbormaster failed remote builds in B8776: Diff 9263 for D1510: Update to Spidermonkey 45.0.2!
Aug 7 2019, 5:18 PM
Vulcan added a comment to D1510: Update to Spidermonkey 45.0.2.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 7 2019, 5:18 PM
Freagarach updated the diff for D2140: Let players be able to choose a preferred attack type..

Created a variable for unique templates in a selection, thus reducing the call time of g_SelectionPanels.PrefAttack.GetItems. This function can probably used for more functions, but that's out of scope.

Aug 7 2019, 5:04 PM
Itms updated the diff for D1510: Update to Spidermonkey 45.0.2.

Updated RC following comments by historic_bruno, wraitii and elexis.

Aug 7 2019, 5:04 PM
elexis committed rP22625: Add Profiler2 static const member definition, since the declaration itself is….
Add Profiler2 static const member definition, since the declaration itself is…
Aug 7 2019, 4:45 PM
elexis closed D2158: Fix Profiler2 gcc7 compiler warning about out of bounds access without breaking the debug build.
Aug 7 2019, 4:45 PM
elexis added a comment to D2158: Fix Profiler2 gcc7 compiler warning about out of bounds access without breaking the debug build.

The reason as to why this was broken is that std::min requires a const reference, but MAX_ATTRIBUTE_LENGTH is only declared in the header, which doesn't count as a definition, thus no reference.

Aug 7 2019, 4:40 PM
elexis updated the test plan for D2158: Fix Profiler2 gcc7 compiler warning about out of bounds access without breaking the debug build.
Aug 7 2019, 2:40 PM
elexis updated the test plan for D2158: Fix Profiler2 gcc7 compiler warning about out of bounds access without breaking the debug build.
Aug 7 2019, 2:32 PM
Vulcan added a comment to D2158: Fix Profiler2 gcc7 compiler warning about out of bounds access without breaking the debug build.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 7 2019, 2:10 PM
Harbormaster failed remote builds in B8773: Diff 9260 for D2158: Fix Profiler2 gcc7 compiler warning about out of bounds access without breaking the debug build!
Aug 7 2019, 2:10 PM
elexis created D2158: Fix Profiler2 gcc7 compiler warning about out of bounds access without breaking the debug build.
Aug 7 2019, 2:10 PM
Vulcan added a comment to D1806: standardized structure aura descriptions.

Successful build - Chance fights ever on the side of the prudent.

Aug 7 2019, 11:23 AM
Nescio updated the diff for D1806: standardized structure aura descriptions.
Aug 7 2019, 11:18 AM
Harbormaster failed to build B8771: rP22624: Fix Profiler2 gcc 8 compiler warning about possible out-of-bounds array access… for rP22624: Fix Profiler2 gcc 8 compiler warning about possible out-of-bounds array access…!
Aug 7 2019, 11:14 AM
elexis committed rP22624: Fix Profiler2 gcc 8 compiler warning about possible out-of-bounds array access….
Fix Profiler2 gcc 8 compiler warning about possible out-of-bounds array access…
Aug 7 2019, 11:12 AM
Nescio added a reviewer for D2110: manual/intro.txt corrections: Restricted Owners Package.
Aug 7 2019, 10:57 AM
Nescio added a comment to D1999: correct Roman specific names.

Thank you for committing this! Perhaps you could also have a look at D1935?

Aug 7 2019, 10:55 AM
Vulcan added a comment to D2157: Mauryas AINames corrections..

Successful build - Chance fights ever on the side of the prudent.

Aug 7 2019, 10:54 AM
Nescio created D2157: Mauryas AINames corrections..
Aug 7 2019, 10:49 AM
Nescio added a comment to D2156: hero templates regnal numbers.

(Spaces in map file names remain problematic (D1042).)

Aug 7 2019, 10:38 AM
Harbormaster failed remote builds in B8769: Diff 9257 for D2156: hero templates regnal numbers!
Aug 7 2019, 10:36 AM
Vulcan added a comment to D2156: hero templates regnal numbers.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 7 2019, 10:36 AM
Nescio created D2156: hero templates regnal numbers.
Aug 7 2019, 10:36 AM
Vulcan added a comment to D2155: healer names.

Successful build - Chance fights ever on the side of the prudent.

Aug 7 2019, 9:39 AM
Nescio created D2155: healer names.
Aug 7 2019, 9:34 AM
Freagarach added inline comments to D2140: Let players be able to choose a preferred attack type..
Aug 7 2019, 9:18 AM
autobuild committed rP22623: [Windows] Automated build..
[Windows] Automated build.
Aug 7 2019, 7:24 AM
Vulcan added a comment to D2015: Add formation CheckTarget-/MoveToTargetRange-functions..

Successful build - Chance fights ever on the side of the prudent.

Aug 7 2019, 7:14 AM
Freagarach updated the diff for D2015: Add formation CheckTarget-/MoveToTargetRange-functions..

Removed correction for formation depth since that made deep ranged formations behave weird.

Aug 7 2019, 7:08 AM
elexis committed rP22622: Replace ScriptInterface ErrorReporter layered hack from rP8063 with proper code….
Replace ScriptInterface ErrorReporter layered hack from rP8063 with proper code…
Aug 7 2019, 12:13 AM
elexis closed D2152: Remove erroneous ErrorReporter.
Aug 7 2019, 12:13 AM
Itms accepted D2152: Remove erroneous ErrorReporter.

This looks fine to me, works with SM38 and without any change with SM45, and so much hacky code is removed that I can only be happy ? The autorequest looks needed to me.

Aug 7 2019, 12:03 AM

Aug 6 2019

elexis committed rP22621: Remove unused texture test helper function obsolete since rP8094 and rP14836….
Remove unused texture test helper function obsolete since rP8094 and rP14836…
Aug 6 2019, 11:00 PM
elexis closed D2153: Fix test_tex.h gcc compiler warning about memset call against a class without trivial copy assignment (Wclass-memaccess).
Aug 6 2019, 11:00 PM
Vulcan added a comment to D2147: gui/gamesetup: Fix no-unmodified-loop-condition warning on 'g_IsNetworked'.

Successful build - Chance fights ever on the side of the prudent.

Aug 6 2019, 10:31 PM
Vulcan added a comment to D2146: gui/common: Fix ESLint code quality violations.

Successful build - Chance fights ever on the side of the prudent.

Aug 6 2019, 10:26 PM
Krinkle updated the diff for D2147: gui/gamesetup: Fix no-unmodified-loop-condition warning on 'g_IsNetworked'.

(Rebased)

Aug 6 2019, 10:21 PM
Krinkle updated the diff for D2146: gui/common: Fix ESLint code quality violations.

(Rebased)

Aug 6 2019, 10:20 PM
Freagarach added a comment to D2141: Fix checkrefs script following phenotype D1955/rP22586..

When running the checkrefs.pl I got:

Use of /g modifier is meaningless in split at checkrefs.pl line 141.
Use of /g modifier is meaningless in split at checkrefs.pl line 159.

and

Duplicate terrain name 'medit_city_tile' (from 'art/terrains/biome-mediterranean/medit_city_tile.xml' and 'art/terrains/road/medit_city_tile.xml')

Aug 6 2019, 9:53 PM
Freagarach raised a concern with rP22594: Remove unused horse sele_crest and straps_kush_base.xml from wrong folder..

The checkrefs.pl script found:

Missing file 'art/actors/props/units/horse/sele_crest.xml' referenced by: 'public/art/actors/units/seleucids/hero_cavalry_spearman_antiochus_the_great_m.xml'

Aug 6 2019, 9:48 PM
Vulcan added a comment to D2153: Fix test_tex.h gcc compiler warning about memset call against a class without trivial copy assignment (Wclass-memaccess).

Successful build - Chance fights ever on the side of the prudent.

Aug 6 2019, 9:41 PM
Vulcan added a comment to D2151: Use "setStringTags"-function more often..

Successful build - Chance fights ever on the side of the prudent.

Aug 6 2019, 9:36 PM
elexis updated the diff for D2153: Fix test_tex.h gcc compiler warning about memset call against a class without trivial copy assignment (Wclass-memaccess).

Actually it looks cleaner to not reuse a struct instance after having called the destructor without calling its constructor again, even if it happens to work.
Use a second class instance, and destroy the fist one regardless to express the intent that memset carried.

Aug 6 2019, 9:34 PM
Freagarach updated the diff for D2151: Use "setStringTags"-function more often..
  • Removed setStringTags on recource icon (Ref. rP12845, where the icons were introduced but the font not removed because a space was still needed between the icon and the amount of resources. In rP14954 the sprintf was introduced, which meant the font could be removed but was probably not done because the function referenced to names while in fact it returned icons. In rP18154 the function was properly named to icons but the font still withstood the test of time (and reviewers).)
  • insufficientX -> insufficient.
  • coloredText -> setStringTags.
  • Only use setStringTags when little performance impact is expected.
Aug 6 2019, 9:30 PM
Vulcan added a comment to D2153: Fix test_tex.h gcc compiler warning about memset call against a class without trivial copy assignment (Wclass-memaccess).

Successful build - Chance fights ever on the side of the prudent.

Aug 6 2019, 9:28 PM
Freagarach added a comment to D2151: Use "setStringTags"-function more often..

http://irclogs.wildfiregames.com/2019-08/2019-08-06-QuakeNet-%230ad-dev.log

Aug 6 2019, 9:27 PM
elexis requested verification of rP22511: Fix the -Wclass-memaccess compiler warning in the pathfinders Grid.h, refs….

Considering #5379.

Aug 6 2019, 9:24 PM
elexis created D2153: Fix test_tex.h gcc compiler warning about memset call against a class without trivial copy assignment (Wclass-memaccess).
Aug 6 2019, 9:22 PM
Vulcan added a comment to D2152: Remove erroneous ErrorReporter.

Successful build - Chance fights ever on the side of the prudent.

Aug 6 2019, 9:00 PM
elexis updated the diff for D2152: Remove erroneous ErrorReporter.

Indentation.

Aug 6 2019, 8:53 PM
elexis updated the test plan for D2152: Remove erroneous ErrorReporter.
Aug 6 2019, 8:17 PM
elexis updated the test plan for D2152: Remove erroneous ErrorReporter.
Aug 6 2019, 8:17 PM