- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Aug 9 2019
In D1613#75586, @bb wrote:For me (as programmer) this isn't a bug in our code, but it is a bug in the translation
Build failure - The Moirai have given mortals hearts that can endure.
Aug 8 2019
Successful build - Chance fights ever on the side of the prudent.
Why does the code count as !runOnce?
Yeah, I meant that a cavalry unit attacking is a turret on the horse or something. That the cavalry can move while attacking.
Also we do have turrets (just a subset) with visible garrisoning.
Thanks for the fix ! I was about to report it
For the record, when running tests in debug (maybe release too) it triggered the following error.
Assertion failure: !options.isRunOnce, at ./libraries/source/spidermonkey/mozjs-45.0.2/js/src/frontend/BytecodeCompiler.cpp:846
(I removed the path with strangely linked to Itm's folders)
In D2020#86251, @vladislavbelov wrote:Fixes @elexis's notes from IRC (2019-07-03#0ad-dev):
I didn't fix 22:02 < elexis> Vladislav: quad[0] = { ... } ?, because I didn't check that the code have to be inlined. So probably later.
broke a SM assertion
This seems to introduce #5554 so I raised a concern.
I couldn't find the ticket but you're right. We need turrets ;)
(For what it's worth: this does seem to fix #5541.)
The setIsRunOnce addition must be reverted.
I agree adding your "C++17 removing diff" would be the way to go here.
If you already created a Phabricator differential a link to that here would be nice.
Hey, this is wrong in fact :) It's this way on purpose - probably from svn blame you can find the tickets where it was discussed.
Successful build - Chance fights ever on the side of the prudent.
Aug 7 2019
- Verification of the SpiderMonkey zip:
sha256sum mozjs-45.0.2.tar.bz2 570530b1e551bf4a459d7cae875f33f99d5ef0c29ccc7742a1b6f588e5eadbee mozjs-45.0.2.tar.bz2
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Releases/45
Ack
Rename ElevationRangeBonus to AttackHeightOffset and move it back from the projectile to the attack itself, since it is the the height from which the attack occurs. UnitAI already only adds parabolic range to "Projectile" attacks. When turrets are implemented, units on horses/chariots etc. can also have a HeightBonus. The horizontal range of "non-projectile" units should actually be smaller when there is a height difference.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Build failure - The Moirai have given mortals hearts that can endure.
Created a variable for unique templates in a selection, thus reducing the call time of g_SelectionPanels.PrefAttack.GetItems. This function can probably used for more functions, but that's out of scope.
Updated RC following comments by historic_bruno, wraitii and elexis.
The reason as to why this was broken is that std::min requires a const reference, but MAX_ATTRIBUTE_LENGTH is only declared in the header, which doesn't count as a definition, thus no reference.
Build failure - The Moirai have given mortals hearts that can endure.
Successful build - Chance fights ever on the side of the prudent.
- capitalized classes
- removed trailing zeroes
- checked against https://trac.wildfiregames.com/wiki/EnglishStyleGuide#Stats
Thank you for committing this! Perhaps you could also have a look at D1935?
Successful build - Chance fights ever on the side of the prudent.
(Spaces in map file names remain problematic (D1042).)
Build failure - The Moirai have given mortals hearts that can endure.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Removed correction for formation depth since that made deep ranged formations behave weird.
This looks fine to me, works with SM38 and without any change with SM45, and so much hacky code is removed that I can only be happy ? The autorequest looks needed to me.
Aug 6 2019
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
(Rebased)
(Rebased)
When running the checkrefs.pl I got:
Use of /g modifier is meaningless in split at checkrefs.pl line 141.
Use of /g modifier is meaningless in split at checkrefs.pl line 159.
and
Duplicate terrain name 'medit_city_tile' (from 'art/terrains/biome-mediterranean/medit_city_tile.xml' and 'art/terrains/road/medit_city_tile.xml')
The checkrefs.pl script found:
Missing file 'art/actors/props/units/horse/sele_crest.xml' referenced by: 'public/art/actors/units/seleucids/hero_cavalry_spearman_antiochus_the_great_m.xml'
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Actually it looks cleaner to not reuse a struct instance after having called the destructor without calling its constructor again, even if it happens to work.
Use a second class instance, and destroy the fist one regardless to express the intent that memset carried.
- Removed setStringTags on recource icon (Ref. rP12845, where the icons were introduced but the font not removed because a space was still needed between the icon and the amount of resources. In rP14954 the sprintf was introduced, which meant the font could be removed but was probably not done because the function referenced to names while in fact it returned icons. In rP18154 the function was properly named to icons but the font still withstood the test of time (and reviewers).)
- insufficientX -> insufficient.
- coloredText -> setStringTags.
- Only use setStringTags when little performance impact is expected.
Successful build - Chance fights ever on the side of the prudent.
Considering #5379.
Successful build - Chance fights ever on the side of the prudent.