Successful build - Chance fights ever on the side of the prudent.

Added includes, missing const keyword

I did a benchmark test by calling the proposed constructor 5000 times in a row, and the previous function 5000 times, in the same program.

Build failure - The Moirai have given mortals hearts that can endure.

Remove the std::move preventing copy elision.

Same result with -O3:

CC="clang -Rpass=inline -O3" CXX="clang++ -Rpass=inline -O3" make -j4

Successful build - Chance fights ever on the side of the prudent.

@Mate-86 Sad to hear that but I hope you'll have fun with your new project. What is it called ?

In D1252#79375, @wraitii wrote:

@Mate-86 I would suggest working on a simple graphical icon next, so that this can actually be used in-game without looking super weird and confusing players.

There are a bunch of options, I would recommend have at least an icon in the top-row of the unit's portrait when it's selected.
Then you can think of adding:

• an icon on top of the unit when it's selected (like auras)
• actual graphical effects (I think the best thing here would be to spawn an actor of some kind?)

I got another

../../../source/gui/CButton.cpp:72:24: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
        m_GeneratedTexts[0] = std::move(CGUIText(m_pGUI, *caption, font, m_CachedActualSize.GetWidth(), buffer_zone, this));
                              ^
../../../source/gui/CButton.cpp:72:24: note: remove std::move call here
        m_GeneratedTexts[0] = std::move(CGUIText(m_pGUI, *caption, font, m_CachedActualSize.GetWidth(), buffer_zone, this));
                              ^~~~~~~~~~                                                                                  ~
../../../source/gui/CCheckBox.cpp:85:24: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
        m_GeneratedTexts[0] = std::move(CGUIText(m_pGUI, *caption, font, m_CachedActualSize.GetWidth() - square_side, 0.f, this));
                              ^
../../../source/gui/CCheckBox.cpp:85:24: note: remove std::move call here
        m_GeneratedTexts[0] = std::move(CGUIText(m_pGUI, *caption, font, m_CachedActualSize.GetWidth() - square_side, 0.f, this));
                              ^~~~~~~~~~                                                                                        ~

In rP22645#36034, @elexis wrote:

rP22594 introduced the issue, or whether both were bugged.

Solved by rP22645.

Just wondering whether rP22260 or rP22594 introduced the issue, or whether both were bugged.
rP22260 introducing a duplicate? (If so, are there more duplicates?)
(Is there some commit missing in the list that removed something?)

In rP22645#36029, @elexis wrote:

rP21038 introduced units/horse/sele_crest.xml correctly

rP21038 introduced units/horse/sele_crest.xml correctly
rP22260 did something
rP22594 did something more

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

No, I mean (see jenkins)=

@Itms It appears VM stability still isn't 100% ;)

(m_SameTurnMovesCount comes from rP9665)

Build failure - The Moirai have given mortals hearts that can endure.

I've done much profiling, and much testing, and here's a CRTP-ed version (comes in single key and dual-key mode).
Overall this container should be similar to EntityMap performance wise, bit slower at inserting but bit faster in other contexts and it works out similarly.

Successful build - Chance fights ever on the side of the prudent.

Rename Draw, floor, static_cast, whitespace, clang warning, restore a TODO

Found this with Clang, but not gcc / Jenkins:

../../../source/gui/CGUIText.h:48:1: warning: 'CGUIText' defined as a class here but previously declared as a struct; this is valid, but may result in linker
      errors under the Microsoft C++ ABI [-Wmismatched-tags]
class CGUIText
^
../../../source/gui/CGUI.h:57:1: note: did you mean class here?
struct CGUIText;
^~~~~~
class

Successful build - Chance fights ever on the side of the prudent.

+1 OOS concern

i tried doesnt work for me i watch pyrogenesis thread in top program of linux and have put general options number of thread to 3 but it doesnt show more than one thread at 100% cpu in top so i dont get it to work. any suggestions wut to do more to get them running? i put D1918 and D14 as diff on my a24 svn version r22642.

In D2033#84727, @Nescio wrote:

Separatedly, someone with more knowledge and experience of the art/ files should correct the following:

• "akin" [sic] into "akinakes"
• "gladus" [sic] into "gladius"
• "pillum" [sic] into "pilum"
• "tessalian" [sic] into "thessalian"

(involves file moves etc.).

Rename _GUItext

Why CGUIString, but _GUItext? Maybe rename that too?

Tested on VS2015, gcc 9.0.1. on arch

Successful build - Chance fights ever on the side of the prudent.

@Gallaecio, feel free to commit this and other patches that have been accepted. I can't.
Also, you might be interested in D2006 and D2110.

We can post-pone this discussion and merge as is.

If you mean whether or not classes should be capitalized, no, I don't think postponing that decision is wise. There are a few patches updating strings and there will be a couple more after this one is committed. Capitalization is a recurring question so we should settle one way or the other and have a clear decision for this and future patches.
I can see arguments both for and against. Excessive Capitalization Can Make Texts Harder to Read, besides, English isn't German, and having uncapitalized classes is aesthetically better. However, gameplay-wise capitalization of classes does make sense for added emphasis. Personally I don't mind either way, provided it is done consistently.

Successful build - Chance fights ever on the side of the prudent.

Siege Engines

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

The patch is a furtherance of the NONCOPYABLE MOVABLE use of rP22570 which is a progression of rP1518.

Have seen people copy too many things to grant this to endure any longer. Convince yourself that it is better to error on the side of caution than to keep "vulnerable" to unintentional copies on possibly every frame and that there is a benefit in enforcing this as a policy until the GUI was redesigned.

NONCOPYABLE CGUISpriteInstances DrawCall Cache: rP22570, rP1518, rP1507
NONCOPYABLE Image, Sprite data rP14493
NONCOPYABLE GUI page rP13419
NONCOPYABLE GUIManager rP7259

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

In D2016#90087, @Vulcan wrote:

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/344/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

ElevationRangeBonus -> AttackHeightOffset and back to attack itself.

Successful build - Chance fights ever on the side of the prudent.

Unused since rP18781, not noticed there, nor in rP20971, rP21000 and rP21001 until http://irclogs.wildfiregames.com/2019-08/2019-08-05-QuakeNet-%230ad-dev.log I didn't test, but the code must be correct or a hat is to be eaten.

I think it's reasonable to see this as fixed in rP22635 (as @smiley said himself in D2010) so I'm removing the audit.

For the record, it seems all classes are uncapitalized here.