Page MenuHomeWildfire Games
Feed All Stories

Aug 12 2019

Vulcan added a comment to D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.

Successful build - Chance fights ever on the side of the prudent.

Aug 12 2019, 2:04 AM
elexis updated the diff for D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.

Added includes, missing const keyword

Aug 12 2019, 1:54 AM
elexis added inline comments to D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.
Aug 12 2019, 1:51 AM
vladislavbelov added inline comments to D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.
Aug 12 2019, 1:35 AM
elexis added a comment to D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.

I did a benchmark test by calling the proposed constructor 5000 times in a row, and the previous function 5000 times, in the same program.

Aug 12 2019, 12:13 AM

Aug 11 2019

Harbormaster failed remote builds in B8813: Diff 9296 for D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions!
Aug 11 2019, 10:30 PM
Vulcan added a comment to D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 11 2019, 10:30 PM
elexis updated the diff for D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.

Remove the std::move preventing copy elision.

Aug 11 2019, 10:28 PM
elexis added a comment to D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.

Same result with -O3:

CC="clang -Rpass=inline -O3" CXX="clang++ -Rpass=inline -O3" make -j4

Aug 11 2019, 10:28 PM
Vulcan added a comment to D2170: --with-system-mozjs45.

Successful build - Chance fights ever on the side of the prudent.

Aug 11 2019, 10:19 PM
elexis created D2170: --with-system-mozjs45.
Aug 11 2019, 10:15 PM
Stan added a comment to D1252: Allow entities to be affected by Status Effects.

@Mate-86 Sad to hear that but I hope you'll have fun with your new project. What is it called ?

Aug 11 2019, 9:46 PM
Mate-86 added a comment to D1252: Allow entities to be affected by Status Effects.

@Mate-86 I would suggest working on a simple graphical icon next, so that this can actually be used in-game without looking super weird and confusing players.
There are a bunch of options, I would recommend have at least an icon in the top-row of the unit's portrait when it's selected.
Then you can think of adding:

  • an icon on top of the unit when it's selected (like auras)
  • actual graphical effects (I think the best thing here would be to spawn an actor of some kind?)
Aug 11 2019, 9:21 PM
elexis updated the test plan for D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.
Aug 11 2019, 9:18 PM
elexis added a comment to D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.

I got another

../../../source/gui/CButton.cpp:72:24: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
        m_GeneratedTexts[0] = std::move(CGUIText(m_pGUI, *caption, font, m_CachedActualSize.GetWidth(), buffer_zone, this));
                              ^
../../../source/gui/CButton.cpp:72:24: note: remove std::move call here
        m_GeneratedTexts[0] = std::move(CGUIText(m_pGUI, *caption, font, m_CachedActualSize.GetWidth(), buffer_zone, this));
                              ^~~~~~~~~~                                                                                  ~
../../../source/gui/CCheckBox.cpp:85:24: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
        m_GeneratedTexts[0] = std::move(CGUIText(m_pGUI, *caption, font, m_CachedActualSize.GetWidth() - square_side, 0.f, this));
                              ^
../../../source/gui/CCheckBox.cpp:85:24: note: remove std::move call here
        m_GeneratedTexts[0] = std::move(CGUIText(m_pGUI, *caption, font, m_CachedActualSize.GetWidth() - square_side, 0.f, this));
                              ^~~~~~~~~~                                                                                        ~
Aug 11 2019, 8:54 PM
Alexandermb added a comment to rP22645: Fix wrong sele_horse_crest on antiochus the great horse.

rP22594 introduced the issue, or whether both were bugged.

Aug 11 2019, 7:52 PM
Freagarach accepted rP22594: Remove unused horse sele_crest and straps_kush_base.xml from wrong folder..

Solved by rP22645.

Aug 11 2019, 7:27 PM
elexis added a comment to rP22645: Fix wrong sele_horse_crest on antiochus the great horse.

Just wondering whether rP22260 or rP22594 introduced the issue, or whether both were bugged.
rP22260 introducing a duplicate? (If so, are there more duplicates?)
(Is there some commit missing in the list that removed something?)

Aug 11 2019, 7:25 PM
Alexandermb added a comment to rP22645: Fix wrong sele_horse_crest on antiochus the great horse.

rP21038 introduced units/horse/sele_crest.xml correctly

Aug 11 2019, 7:23 PM
elexis added a comment to rP22645: Fix wrong sele_horse_crest on antiochus the great horse.

rP21038 introduced units/horse/sele_crest.xml correctly
rP22260 did something
rP22594 did something more

Aug 11 2019, 7:16 PM
Vulcan added a comment to D2141: Fix checkrefs script following phenotype D1955/rP22586..

Successful build - Chance fights ever on the side of the prudent.

Aug 11 2019, 7:10 PM
wraitii added inline comments to D1918: Move pathfinder work to a worker (not yet threaded - D14 prerequisite).
Aug 11 2019, 7:07 PM
Vulcan added a comment to D2169: Fix VisualActor OOS.

Successful build - Chance fights ever on the side of the prudent.

Aug 11 2019, 7:06 PM
Alexandermb committed rP22645: Fix wrong sele_horse_crest on antiochus the great horse.
Fix wrong sele_horse_crest on antiochus the great horse
Aug 11 2019, 7:06 PM
wraitii updated the diff for D2141: Fix checkrefs script following phenotype D1955/rP22586..

No, I mean (see jenkins)=

Aug 11 2019, 7:02 PM
wraitii updated subscribers of D1739: Introduce a replacement container for EntityMap, std::map, std::unordered_map and boost::unordered_map.

@Itms It appears VM stability still isn't 100% ;)

Aug 11 2019, 6:58 PM
wraitii created D2169: Fix VisualActor OOS.
Aug 11 2019, 6:57 PM
elexis added a comment to D1918: Move pathfinder work to a worker (not yet threaded - D14 prerequisite).

(m_SameTurnMovesCount comes from rP9665)

Aug 11 2019, 6:57 PM
Harbormaster failed remote builds in B8808: Diff 9292 for D1739: Introduce a replacement container for EntityMap, std::map, std::unordered_map and boost::unordered_map!
Aug 11 2019, 6:50 PM
Vulcan added a comment to D1739: Introduce a replacement container for EntityMap, std::map, std::unordered_map and boost::unordered_map.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 11 2019, 6:50 PM
wraitii updated the diff for D1739: Introduce a replacement container for EntityMap, std::map, std::unordered_map and boost::unordered_map.

I've done much profiling, and much testing, and here's a CRTP-ed version (comes in single key and dual-key mode).
Overall this container should be similar to EntityMap performance wise, bit slower at inserting but bit faster in other contexts and it works out similarly.

Aug 11 2019, 6:44 PM
Vulcan added a comment to D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.

Successful build - Chance fights ever on the side of the prudent.

Aug 11 2019, 6:19 PM
elexis updated the diff for D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.

Rename Draw, floor, static_cast, whitespace, clang warning, restore a TODO

Aug 11 2019, 6:12 PM
elexis added a comment to D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.

Found this with Clang, but not gcc / Jenkins:

../../../source/gui/CGUIText.h:48:1: warning: 'CGUIText' defined as a class here but previously declared as a struct; this is valid, but may result in linker
      errors under the Microsoft C++ ABI [-Wmismatched-tags]
class CGUIText
^
../../../source/gui/CGUI.h:57:1: note: did you mean class here?
struct CGUIText;
^~~~~~
class
Aug 11 2019, 6:10 PM
elexis planned changes to D2116: Avoid copying CChart m_Points following rP19027.
Aug 11 2019, 4:36 PM
elexis updated the summary of D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.
Aug 11 2019, 4:11 PM
Vulcan added a comment to D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.

Successful build - Chance fights ever on the side of the prudent.

Aug 11 2019, 4:11 PM
elexis created D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.
Aug 11 2019, 4:01 PM
elexis added a comment to rP22586: Replace {gender} by {phenotype} and support this tag in VisualActor..

+1 OOS concern

Aug 11 2019, 1:36 PM
ffffffff added a comment to D14: [RC] Thread the pathfinder computations.

i tried doesnt work for me i watch pyrogenesis thread in top program of linux and have put general options number of thread to 3 but it doesnt show more than one thread at 100% cpu in top so i dont get it to work. any suggestions wut to do more to get them running? i put D1918 and D14 as diff on my a24 svn version r22642.

Aug 11 2019, 8:55 AM
autobuild committed rP22644: [Windows] Automated build..
[Windows] Automated build.
Aug 11 2019, 7:29 AM
Alexandermb added a comment to D2033: Correct sword prop for three units.
In D2033#84727, @Nescio wrote:

Separatedly, someone with more knowledge and experience of the art/ files should correct the following:

  • "akin" [sic] into "akinakes"
  • "gladus" [sic] into "gladius"
  • "pillum" [sic] into "pilum"
  • "tessalian" [sic] into "thessalian"

(involves file moves etc.).

Aug 11 2019, 2:36 AM

Aug 10 2019

elexis committed rP22643: Split CGUIString.h from GUIText.h, so that one may have the SGUIText….
Split CGUIString.h from GUIText.h, so that one may have the SGUIText…
Aug 10 2019, 9:17 PM
elexis closed D2167: Split GUItext.h and CGUIString.h.
Aug 10 2019, 9:17 PM
vladislavbelov accepted D2167: Split GUItext.h and CGUIString.h.
Aug 10 2019, 9:09 PM
elexis added inline comments to D2167: Split GUItext.h and CGUIString.h.
Aug 10 2019, 9:05 PM
elexis added a comment to D2167: Split GUItext.h and CGUIString.h.

Rename _GUItext

Aug 10 2019, 9:02 PM
vladislavbelov added a comment to D2167: Split GUItext.h and CGUIString.h.

Why CGUIString, but _GUItext? Maybe rename that too?

Aug 10 2019, 8:45 PM
elexis added a comment to D2167: Split GUItext.h and CGUIString.h.

Tested on VS2015, gcc 9.0.1. on arch

Aug 10 2019, 8:42 PM
Vulcan added a comment to D2167: Split GUItext.h and CGUIString.h.

Successful build - Chance fights ever on the side of the prudent.

Aug 10 2019, 8:15 PM
elexis created D2167: Split GUItext.h and CGUIString.h.
Aug 10 2019, 8:06 PM
Nescio added a comment to D1547: typography corrections in quotes.

@Gallaecio, feel free to commit this and other patches that have been accepted. I can't.
Also, you might be interested in D2006 and D2110.

Aug 10 2019, 7:47 PM
Nescio added a comment to D1806: standardized structure aura descriptions.

We can post-pone this discussion and merge as is.

If you mean whether or not classes should be capitalized, no, I don't think postponing that decision is wise. There are a few patches updating strings and there will be a couple more after this one is committed. Capitalization is a recurring question so we should settle one way or the other and have a clear decision for this and future patches.
I can see arguments both for and against. Excessive Capitalization Can Make Texts Harder to Read, besides, English isn't German, and having uncapitalized classes is aesthetically better. However, gameplay-wise capitalization of classes does make sense for added emphasis. Personally I don't mind either way, provided it is done consistently.

Aug 10 2019, 7:22 PM
Vulcan added a comment to D1806: standardized structure aura descriptions.

Successful build - Chance fights ever on the side of the prudent.

Aug 10 2019, 7:16 PM
Nescio updated the diff for D1806: standardized structure aura descriptions.

Siege Engines

Aug 10 2019, 7:11 PM
Nescio accepted D2165: Upgrade into a %(name)s → Upgrade to %(name)s.
Aug 10 2019, 7:06 PM
autobuild committed rP22642: [Windows] Automated build..
[Windows] Automated build.
Aug 10 2019, 3:37 PM
elexis updated the summary of D2166: Unfriend IGUIObject from CGUI.
Aug 10 2019, 2:54 PM
elexis committed rP22641: Unfriend the 20 IGUIObject classes from CGUI..
Unfriend the 20 IGUIObject classes from CGUI.
Aug 10 2019, 2:51 PM
elexis closed D2166: Unfriend IGUIObject from CGUI.
Aug 10 2019, 2:51 PM
elexis updated the test plan for D2166: Unfriend IGUIObject from CGUI.
Aug 10 2019, 2:47 PM
Vulcan added a comment to D2166: Unfriend IGUIObject from CGUI.

Successful build - Chance fights ever on the side of the prudent.

Aug 10 2019, 2:33 PM
elexis created D2166: Unfriend IGUIObject from CGUI.
Aug 10 2019, 2:24 PM
Vulcan added a comment to D2165: Upgrade into a %(name)s → Upgrade to %(name)s.

Successful build - Chance fights ever on the side of the prudent.

Aug 10 2019, 12:04 PM
Gallaecio created D2165: Upgrade into a %(name)s → Upgrade to %(name)s.
Aug 10 2019, 12:00 PM
Gallaecio committed rP22640: Referring a path into an island: land → shallow water.
Referring a path into an island: land → shallow water
Aug 10 2019, 11:28 AM
Gallaecio closed D1820: island → peninsula.
Aug 10 2019, 11:28 AM
Gallaecio added inline comments to D1806: standardized structure aura descriptions.
Aug 10 2019, 11:25 AM
autobuild committed rP22639: [Windows] Automated build..
[Windows] Automated build.
Aug 10 2019, 7:29 AM
elexis committed rP22638: Use NONCOPYABLE for most GUI classes and structs to have the compiler indicate….
Use NONCOPYABLE for most GUI classes and structs to have the compiler indicate…
Aug 10 2019, 2:04 AM
elexis closed D2164: NONCOPYABLE GUI classes and structs.
Aug 10 2019, 2:04 AM
Vulcan added a comment to D2164: NONCOPYABLE GUI classes and structs.

Successful build - Chance fights ever on the side of the prudent.

Aug 10 2019, 1:25 AM
elexis created D2164: NONCOPYABLE GUI classes and structs.
Aug 10 2019, 1:13 AM

Aug 9 2019

Vulcan added a comment to D2016: Rename "ElevationBonus" and "Delay" to "AttackHeightOffset" and "DamageDelay", respectively..

Successful build - Chance fights ever on the side of the prudent.

Aug 9 2019, 11:52 PM
Angen updated subscribers of rP22608: Pthread -> std::thread (2/7) - Remove pthread in Profilers.
Aug 9 2019, 11:04 PM
elexis committed rP22637: MOVABLE idiom, const CGUI struct maps, in place move construction instead of….
MOVABLE idiom, const CGUI struct maps, in place move construction instead of…
Aug 9 2019, 7:26 PM
elexis closed D2163: MOVABLE idiom, const CGUI databases and avoid unintentional SGUIIcon, SGUIStyle copies.
Aug 9 2019, 7:26 PM
elexis added a comment to D2163: MOVABLE idiom, const CGUI databases and avoid unintentional SGUIIcon, SGUIStyle copies.

The patch is a furtherance of the NONCOPYABLE MOVABLE use of rP22570 which is a progression of rP1518.

Aug 9 2019, 7:26 PM
elexis added a comment to D2163: MOVABLE idiom, const CGUI databases and avoid unintentional SGUIIcon, SGUIStyle copies.

Have seen people copy too many things to grant this to endure any longer. Convince yourself that it is better to error on the side of caution than to keep "vulnerable" to unintentional copies on possibly every frame and that there is a benefit in enforcing this as a policy until the GUI was redesigned.

NONCOPYABLE CGUISpriteInstances DrawCall Cache: rP22570, rP1518, rP1507
NONCOPYABLE Image, Sprite data rP14493
NONCOPYABLE GUI page rP13419
NONCOPYABLE GUIManager rP7259

Aug 9 2019, 5:25 PM
Vulcan added a comment to D2016: Rename "ElevationBonus" and "Delay" to "AttackHeightOffset" and "DamageDelay", respectively..

Build failure - The Moirai have given mortals hearts that can endure.

Aug 9 2019, 4:57 PM
Vulcan added a comment to D2016: Rename "ElevationBonus" and "Delay" to "AttackHeightOffset" and "DamageDelay", respectively..

Build failure - The Moirai have given mortals hearts that can endure.

Aug 9 2019, 4:56 PM
Harbormaster failed to build B8794: rP22636: Fix failure of the CGUIColor constructor author to call the base constructor… for rP22636: Fix failure of the CGUIColor constructor author to call the base constructor…!
Aug 9 2019, 4:55 PM
elexis committed rP22636: Fix failure of the CGUIColor constructor author to call the base constructor….
Fix failure of the CGUIColor constructor author to call the base constructor…
Aug 9 2019, 4:54 PM
Freagarach added a comment to D2016: Rename "ElevationBonus" and "Delay" to "AttackHeightOffset" and "DamageDelay", respectively..
In D2016#90087, @Vulcan wrote:

Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/344/display/redirect

Aug 9 2019, 4:36 PM
Harbormaster failed remote builds in B8793: Diff 9278 for D2016: Rename "ElevationBonus" and "Delay" to "AttackHeightOffset" and "DamageDelay", respectively.!
Aug 9 2019, 4:34 PM
Vulcan added a comment to D2016: Rename "ElevationBonus" and "Delay" to "AttackHeightOffset" and "DamageDelay", respectively..

Build failure - The Moirai have given mortals hearts that can endure.

Aug 9 2019, 4:33 PM
Freagarach updated the diff for D2016: Rename "ElevationBonus" and "Delay" to "AttackHeightOffset" and "DamageDelay", respectively..

ElevationRangeBonus -> AttackHeightOffset and back to attack itself.

Aug 9 2019, 4:32 PM
elexis awarded rP22617: Call CGUIColor base constructor without C++17 using declaration following… a Burninate token.
Aug 9 2019, 3:57 PM
Vulcan added a comment to D2163: MOVABLE idiom, const CGUI databases and avoid unintentional SGUIIcon, SGUIStyle copies.

Successful build - Chance fights ever on the side of the prudent.

Aug 9 2019, 2:42 PM
elexis added a comment to D2149: Remove a tileclass from Caledonian Meadows.

Unused since rP18781, not noticed there, nor in rP20971, rP21000 and rP21001 until http://irclogs.wildfiregames.com/2019-08/2019-08-05-QuakeNet-%230ad-dev.log I didn't test, but the code must be correct or a hat is to be eaten.

Aug 9 2019, 2:16 PM
elexis created D2163: MOVABLE idiom, const CGUI databases and avoid unintentional SGUIIcon, SGUIStyle copies.
Aug 9 2019, 2:09 PM
FeXoR added a comment to rP21026: Cleanup TileClass prototype and use vector arguments for countInRadius….
Aug 9 2019, 1:46 PM
elexis removed 1 auditor(s) for rP21026: Cleanup TileClass prototype and use vector arguments for countInRadius…: wraitii.
Aug 9 2019, 1:42 PM
FeXoR accepted rP21026: Cleanup TileClass prototype and use vector arguments for countInRadius….

I think it's reasonable to see this as fixed in rP22635 (as @smiley said himself in D2010) so I'm removing the audit.

Aug 9 2019, 1:42 PM
FeXoR accepted rP22615: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb….
Aug 9 2019, 1:31 PM
FeXoR committed rP22635: Replace an incorrect math.max() by math.min() in tileclass.
Replace an incorrect math.max() by math.min() in tileclass
Aug 9 2019, 12:47 PM
FeXoR closed D2010: Replace an incorrect math.max() by math.min() in tileclass.
Aug 9 2019, 12:47 PM
FeXoR commandeered D2010: Replace an incorrect math.max() by math.min() in tileclass.
Aug 9 2019, 11:28 AM
Nescio added a comment to D1614: English review of cavalry unit references.

For the record, it seems all classes are uncapitalized here.

Aug 9 2019, 9:44 AM
Nescio accepted D1820: island → peninsula.
Aug 9 2019, 9:42 AM