Page MenuHomeWildfire Games
Feed All Stories

Sep 9 2019

wraitii added a reviewer for D2111: [PetraAI] - Do not try to attack entities which can't be attacked.: wraitii.
Sep 9 2019, 6:36 PM
Vulcan added a comment to D2274: Pass lobby certificate status as a separate value and allow Xmpp error strings to become static.

Build failure - The Moirai have given mortals hearts that can endure.

Sep 9 2019, 6:16 PM
Silier added inline comments to D2111: [PetraAI] - Do not try to attack entities which can't be attacked..
Sep 9 2019, 6:16 PM
Harbormaster failed remote builds in B9287: Diff 9684 for D2274: Pass lobby certificate status as a separate value and allow Xmpp error strings to become static!
Sep 9 2019, 6:15 PM
Vulcan added a comment to D2274: Pass lobby certificate status as a separate value and allow Xmpp error strings to become static.

Build failure - The Moirai have given mortals hearts that can endure.

Sep 9 2019, 6:15 PM
elexis created D2274: Pass lobby certificate status as a separate value and allow Xmpp error strings to become static.
Sep 9 2019, 6:14 PM
Vulcan added a comment to D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 6:04 PM
Silier added inline comments to D2175: Select formations as a whole by default..
Sep 9 2019, 6:03 PM
Vulcan added a comment to D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 6:00 PM
elexis created D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.
Sep 9 2019, 5:59 PM
elexis added a comment to D2221: [gui] use bullets in civ history window.

Why does that line have text=white but the lines before it don't have it?

Sep 9 2019, 5:45 PM
Freagarach added a comment to D2270: Allow area damages to have a minimum range..

Oh, I thought focus on the second part ;)
But I thought about adding that (upgradable) here also, but I don't want to spam diffs too much, there's a lot to do already and me creating more diffs is not good for review-morale (although I have a list of diffs I want to create ;) ) and it (upgradable) is out of scope for this one.

Sep 9 2019, 4:52 PM
Freagarach added inline comments to D2229: Elaborate Armour..
Sep 9 2019, 4:39 PM
Freagarach added inline comments to D2175: Select formations as a whole by default..
Sep 9 2019, 4:35 PM
elexis committed rP22875: Translate lobby TLS certificate error strings following rP21901 and string….
Translate lobby TLS certificate error strings following rP21901 and string…
Sep 9 2019, 4:34 PM
elexis closed D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:34 PM
elexis updated the test plan for D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:32 PM
Vulcan added a comment to D2162: Do not stack fleeing orders..

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 4:28 PM
Stan added a comment to D2270: Allow area damages to have a minimum range..
In D2270#94462, @Stan wrote:

Maybe this should be affectable by tech, (ie researching close combat weapon or whatever) ? Just an idea it would also work having #252

This patch enables a splash to have a minimum range: e.g. when the projectile lands and it has a minRange of 5 m, the first 5 m would not be damaged, only in the range between the minRange and the maxRange damage is dealt.

Sep 9 2019, 4:27 PM
Vulcan added a comment to D2162: Do not stack fleeing orders..

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 4:25 PM
Freagarach updated the diff for D2162: Do not stack fleeing orders..

Allow only one fleeing order.

Sep 9 2019, 4:23 PM
elexis updated the test plan for D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:23 PM
Freagarach added a comment to D1496: Combat Variant.
In D1496#94455, @Stan wrote:

But actually this seems to only set the units to use combat variant when in formation.

Yeah, the rest of the code is already there :) At least in SVN now.

Sep 9 2019, 4:20 PM
Vulcan added a comment to D2272: Translate XmppClient::TLSErrorToString.

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 4:19 PM
Freagarach added a comment to D2270: Allow area damages to have a minimum range..

This patch enables a splash to have a minimum range: e.g. when the projectile lands and it has a minRange of 5 m, the first 5 m would not be damaged, only in the range between the minRange and the maxRange damage is dealt.

Sep 9 2019, 4:19 PM
elexis updated the Trac tickets for D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:18 PM
elexis updated the summary of D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:18 PM
elexis added inline comments to D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:17 PM
Vulcan added a comment to D2272: Translate XmppClient::TLSErrorToString.

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 4:16 PM
Stan awarded D2272: Translate XmppClient::TLSErrorToString a 100 token.
Sep 9 2019, 4:12 PM
Stan added a comment to D2270: Allow area damages to have a minimum range..

Maybe this should be affectable by tech, (ie researching close combat weapon or whatever) ? Just an idea it would also work having #252

Sep 9 2019, 4:09 PM
elexis created D2272: Translate XmppClient::TLSErrorToString.
Sep 9 2019, 4:07 PM
Stan added a comment to D1496: Combat Variant.

Patch probably needs rebase now.

Sep 9 2019, 4:06 PM
Stan added inline comments to D2229: Elaborate Armour..
Sep 9 2019, 4:02 PM
Silier added inline comments to D2175: Select formations as a whole by default..
Sep 9 2019, 3:53 PM
Vulcan added a comment to D2271: Fix lobby utf8 conversion following rP22856 / D2264.

Build failure - The Moirai have given mortals hearts that can endure.

Sep 9 2019, 3:51 PM
elexis added a comment to D2271: Fix lobby utf8 conversion following rP22856 / D2264.

(+ forgotton unrevisioned file)

Sep 9 2019, 3:49 PM
Harbormaster failed remote builds in B9282: Diff 9679 for D2271: Fix lobby utf8 conversion following rP22856 / D2264!
Sep 9 2019, 3:49 PM
Vulcan added a comment to D2271: Fix lobby utf8 conversion following rP22856 / D2264.

Build failure - The Moirai have given mortals hearts that can endure.

Sep 9 2019, 3:49 PM
elexis planned changes to D2271: Fix lobby utf8 conversion following rP22856 / D2264.

This version includes D2128 and some other unrelated changes that I now may split.

Sep 9 2019, 3:46 PM
elexis created D2271: Fix lobby utf8 conversion following rP22856 / D2264.
Sep 9 2019, 3:45 PM
elexis added inline comments to rP22856: Support creating lobby GUI messages with arbitrary arguments instead of forcing….
Sep 9 2019, 3:38 PM
Freagarach updated the diff for D2161: Also account for elevation for melee units..

Fixed test.

Sep 9 2019, 3:22 PM
Silier added a comment to D1496: Combat Variant.

yes possibly but first it would be better just have this one as it is a lot faster than computing squares and this just changes unitai code in minimal scale

Sep 9 2019, 3:11 PM
Freagarach added a comment to D1496: Combat Variant.
In D1496#94055, @Stan wrote:

Yeah though instead of being relative to a range check it's relative to the state.

We'd probably want it to be related to the range right? For it is strange for a unit to be in the combat mood when tasked from the one end of a map to the other?

Sep 9 2019, 2:02 PM
Vulcan added a comment to D2229: Elaborate Armour..

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 1:54 PM
Vulcan added a comment to D2229: Elaborate Armour..

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 1:51 PM
Freagarach updated the diff for D2229: Elaborate Armour..

Forgot to revert previous patch,,,

Sep 9 2019, 1:49 PM
Vulcan added a comment to D2229: Elaborate Armour..

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 1:44 PM
Vulcan added a comment to D2229: Elaborate Armour..

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 1:41 PM
Freagarach updated the diff for D2229: Elaborate Armour..

Rebased and some minor correction.

Sep 9 2019, 1:38 PM
Freagarach added inline comments to rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
Sep 9 2019, 1:36 PM
wraitii added inline comments to rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
Sep 9 2019, 1:33 PM
Vulcan added a comment to D2270: Allow area damages to have a minimum range..

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 12:56 PM
Vulcan added a comment to D2270: Allow area damages to have a minimum range..

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 12:47 PM
Freagarach created D2270: Allow area damages to have a minimum range..
Sep 9 2019, 12:44 PM
Nescio added a comment to D2221: [gui] use bullets in civ history window.

I suppose each item is a civ bonus?

Each entry is a civilization bonus, team bonus, special technology, special building, or hero.

Sep 9 2019, 12:43 PM
elexis accepted D2221: [gui] use bullets in civ history window.
In D2221#94390, @Nescio wrote:

If you have a better suggestion for the comment sentence, feel free to be bold and go ahead!

Perhaps one can make item relate more to the context; looking at civinfo.xml, I suppose each item is a civ bonus? whatever (just the translator audience to be considered in general when editing translated strings)

Sep 9 2019, 12:32 PM
Nescio added a comment to D2221: [gui] use bullets in civ history window.

If you have a better suggestion for the comment sentence, feel free to be bold and go ahead!

So I wonder wheter that dot comes from.

Some of the {civ}.json use non-empty placeholder strings; they're removed in D2222.

Sep 9 2019, 12:24 PM
Freagarach added inline comments to rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
Sep 9 2019, 12:05 PM
wraitii added inline comments to rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
Sep 9 2019, 12:02 PM
elexis added a comment to D2221: [gui] use bullets in civ history window.

On the translation comment itself "insert an itemization symbol for each entry", the only information it adds to "• %(string)s" is the explanation that the symbol is about itemization.
The information that translators often lack is that they don't know the context it is used in.
They see the filename civinfo.js, so I guess that already restricts the possible interpretations

Sep 9 2019, 12:01 PM
Freagarach added inline comments to rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
Sep 9 2019, 11:58 AM
wraitii added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Sep 9 2019, 11:17 AM
elexis added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Sep 9 2019, 11:10 AM
wraitii added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Sep 9 2019, 11:07 AM
wraitii added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Sep 9 2019, 11:05 AM
elexis added inline comments to D2128: Use CreateObject in EngineScriptConversions.
Sep 9 2019, 11:03 AM
elexis added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Sep 9 2019, 10:59 AM
Stan added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Sep 9 2019, 10:52 AM
wraitii added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Sep 9 2019, 10:48 AM
Freagarach added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Sep 9 2019, 10:45 AM
elexis added a comment to P169 Repairable class.

Class keyword discussion with Krinkle on:
http://irclogs.wildfiregames.com/2019-08/2019-08-31-QuakeNet-%230ad-dev.log

Sep 9 2019, 10:38 AM
Vulcan added a comment to D2221: [gui] use bullets in civ history window.

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 10:38 AM
Stan added a comment to D2218: Status Effects v1 - GUI support and fix following rP22754.

If anybody has a good idea for a default 'status effect' icon, I'm a taker.

Sep 9 2019, 10:37 AM
Vulcan added a comment to D2221: [gui] use bullets in civ history window.

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 10:32 AM
Nescio updated the diff for D2221: [gui] use bullets in civ history window.

Thank you for that last explanation!

Sep 9 2019, 10:30 AM
elexis added inline comments to rP22856: Support creating lobby GUI messages with arbitrary arguments instead of forcing….
Sep 9 2019, 10:23 AM
elexis added a comment to D2221: [gui] use bullets in civ history window.

Yes, Translation: prefix is necessary, otherwise the python extract script won't notice it.
And this line needs to appear before the "translate" line. Multi-line comments are supported too.
And that mostly answers the question between context and comment. Context allows to translate differently depending on context, translation comment allows to tell long stories for the translators.

Sep 9 2019, 10:18 AM
wraitii added a comment to D2218: Status Effects v1 - GUI support and fix following rP22754.

If anybody has a good idea for a default 'status effect' icon, I'm a taker.

Sep 9 2019, 10:07 AM
Freagarach abandoned D2160: Make sure entities do not damage entities out of range..

Refs: rP14449, #1537.

Sep 9 2019, 10:00 AM
Vulcan added a comment to D2269: Combine attacker data in "data" in attack-related code..

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 9:57 AM
Vulcan added a comment to D2269: Combine attacker data in "data" in attack-related code..

Successful build - Chance fights ever on the side of the prudent.

Sep 9 2019, 9:47 AM
Freagarach added a comment to D781: [gameplay] - Elevation attack bonus for units..
In D781#93951, @wraitii wrote:

The 'AttackerData' change should be put in a different diff I think, if there's not one already.

D2269.

Sep 9 2019, 9:47 AM
autobuild committed rP22874: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Sep 9 2019, 9:44 AM
Freagarach updated the diff for D2269: Combine attacker data in "data" in attack-related code..

Always not nice when your test passes, you apply a last-minute-change and forget to test that...

Sep 9 2019, 9:43 AM
Freagarach added a comment to D2218: Status Effects v1 - GUI support and fix following rP22754.
In D2218#94255, @Angen wrote:

yes icons should have own folder

Refs: D1745?

Sep 9 2019, 9:36 AM
Freagarach added a comment to D294: Add catafalque to Structure Tree.
In D294#29869, @elexis wrote:

Might want to ask the art department on the public and/or staff forums.

Has there been any progress on this? For I definitively like the seperate catafalque page :D

Sep 9 2019, 9:23 AM
Freagarach added a comment to D2221: [gui] use bullets in civ history window.

Thanks for the in-depth explanation @elexis!
One more question: what is the difference between:
// Translate: context.
and the function translateWithContext("context", text)?

Sep 9 2019, 8:55 AM

Sep 8 2019

Vulcan added a comment to D2221: [gui] use bullets in civ history window.

Successful build - Chance fights ever on the side of the prudent.

Sep 8 2019, 10:42 PM
Vulcan added a comment to D2221: [gui] use bullets in civ history window.

Successful build - Chance fights ever on the side of the prudent.

Sep 8 2019, 10:39 PM
Nescio updated the diff for D2221: [gui] use bullets in civ history window.

comment

Sep 8 2019, 10:37 PM
elexis added a comment to D2221: [gui] use bullets in civ history window.

Yessir this is what I meant! Isn't it beauty?

Sep 8 2019, 10:15 PM
Nescio added a comment to D2247: [gui] omit unnecessary decimals for resistance tooltip.

@Krinkle, yes, I agree, the entire tooltip could use a critical look and perhaps a redesign; especially concerning the various resource stats.
However, what do you mean exactly with fractions? Display 1.2 as 6/5? Wouldn't that make comparing things harder for typical users?

Sep 8 2019, 10:10 PM
Nescio added a comment to D2247: [gui] omit unnecessary decimals for resistance tooltip.

Should also always account for mods.
The simulation templates are 0ad content, but the simulation components (even the GUI too) are meant to work with arbitrary game content (as far as I'm concerned).

The armour percentage for level x is 1 - 0.9^x; although it's theoretically possible for a mod to use decimal levels, I doubt people would really use e.g. x = 1.23.

Perhaps it was originally added because 3.0 crush (27%) looks more noble than 3 crush (27%) x)

Or perhaps it's just because attack damage has (and needs) a decimal?

But I wouldn't say there is no consistency, since the tooltip strings above and below the armor tooltip also uses one decimal place (Capture Attack, Melee Attack, Armor, Speed, Gather Rate)..

Health doesn't have decimals, whereas e.g. resource trickle can have numerous.

I don't have strong disagreement on the armor tooltip itself, so I suppose it's okay.

The current situation or the proposed patch?

(Shouldn't Melee attack come prior to Capture Attack?)

Why? Isn't capturing the default?
Speaking of which, I think it would be more logical to list armour between health and capture attack; but that discussion is beyond the scope of this patch.

(All techs and promotion and whatsoever also result in natural numbers for armor too?)

Yes; unlike attack damage, resource costs, health, etc., which typically use multiply modifications, the data/ files use only add for Armour.

Also perhaps it wouldnt hurt to remove the trailing 0 in the templates.

I suppose I could write a patch for that, if I were sure someone would review it; there is already quite a review backlog.

And perhaps even going further and making Armor a natural number in the simulation component Schema?

That wouldn't hurt, but is it necessary?

Sep 8 2019, 10:07 PM
Vulcan added a comment to D2221: [gui] use bullets in civ history window.

Successful build - Chance fights ever on the side of the prudent.

Sep 8 2019, 9:58 PM
Vulcan added a comment to D2221: [gui] use bullets in civ history window.

Successful build - Chance fights ever on the side of the prudent.

Sep 8 2019, 9:57 PM
Nescio updated the diff for D2221: [gui] use bullets in civ history window.

Hopefully this is what you meant.

Sep 8 2019, 9:53 PM
Vulcan added a comment to D2128: Use CreateObject in EngineScriptConversions.

Successful build - Chance fights ever on the side of the prudent.

Sep 8 2019, 8:12 PM
Harbormaster failed remote builds in B9273: Diff 9670 for D2128: Use CreateObject in EngineScriptConversions!
Sep 8 2019, 8:10 PM