Page MenuHomeWildfire Games
Feed All Stories

Tue, Sep 10

wraitii added inline comments to D2275: Fix units sometimes turning around when fleeing (introduced by D1987/rP22431).
Tue, Sep 10, 1:25 PM
Freagarach accepted D2275: Fix units sometimes turning around when fleeing (introduced by D1987/rP22431).

Works like a charm! Thanks @wraitii ;D
I've tried to break this in several occasions but failed to do so, however, code-wise I've little knowledge about this part.

Tue, Sep 10, 1:24 PM
Stan added inline comments to D2275: Fix units sometimes turning around when fleeing (introduced by D1987/rP22431).
Tue, Sep 10, 1:24 PM
wraitii added a comment to rP22878: Fix issues with MakeGoalReachable when the goal wasn't reachable following….

I think @wraitii found this by himself?

Tue, Sep 10, 1:23 PM
Stan added a comment to D2199: Add RPC interface for Reinforcement Learning.

Maybe you could split the gamesetup → gameconfig change to another patch ?

Tue, Sep 10, 1:19 PM
Nescio added a comment to D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.

And I've tested by doing the following:

  • svn up and deleted cache
  • rebuilt the game with clean-workspaces.sh then update-workspaces.sh
  • binaries/system/pyrogenesis

It turns out the problems I reported on the forums last Friday are still there:

  • when opening "Learn To Play/Structure Tree" from the main menu:
    • clicking the "History" button closes it and returns to the main menu (instead of opening History)
    • pressing Alt+Shift+H opens History as it should
    • pressing Alt+Shift+T re-opens the Structure Tree (when it's already open, it should close)
  • mutatis mutandis for "Learn To Play/History"

Then I did arc patch D2273 and tried again. Clicking the History/Structure Tree button opens the corresponding window, as it should, so this patch apparently solves that problem. However, pressing Alt+Shift+H/T still re-opens the corresponding window, even though it should actually close it when it's already open, so that problem is still there.

Tue, Sep 10, 11:59 AM
Freagarach added a comment to rP22878: Fix issues with MakeGoalReachable when the goal wasn't reachable following….

I think @wraitii found this by himself?

Tue, Sep 10, 11:55 AM
elexis added a comment to D2197: Add support for recording replay metadata when in nonvisual mode.

This patch should be good to go, but the problem is that it depends on Freezing that initattributes, at least it sounds very fragile if we already had many previous code that changed the simulation state unintentionally which was fixed by freezing.
So the patch depends on D2213, and for that one I dont know yet (A) if its a good idea (and even correct) to remove the second persistentrooted value, and (B) at which place to call the freeze function.
(I'm not so familiar with that code either, so it's something new to learn for any of us looking at that.)
It's actually quite annoying to not have this patch committed, because it fixes an important defect (removing g_Game && g_Game->IsGameStarted() && !g_Game->IsVisualReplay() && g_AtlasGameLoop && !g_AtlasGameLoop->running && CRenderer::IsInitialised())).

Tue, Sep 10, 11:45 AM
Nescio added inline comments to D2280: remove armour trailing zeroes from templates.
Tue, Sep 10, 11:38 AM
elexis added inline comments to D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.
Tue, Sep 10, 11:28 AM
Vulcan added a comment to D2280: remove armour trailing zeroes from templates.

Successful build - Chance fights ever on the side of the prudent.

Tue, Sep 10, 11:28 AM
Stan added inline comments to D2280: remove armour trailing zeroes from templates.
Tue, Sep 10, 11:26 AM
elexis added a comment to D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.

Don't worry, I was more wondering why you said that the cache erasure fixed it. Also why I said that I couldnt reproduce. Also why I was sure that I had tested this. I hope space time continuum isn't broken x)
https://wildfiregames.com/forum/index.php?/topic/26274-breaking-changes-following-22379/page/2/&tab=comments#comment-384668

Tue, Sep 10, 11:26 AM
Vulcan added a comment to D2280: remove armour trailing zeroes from templates.

Successful build - Chance fights ever on the side of the prudent.

Tue, Sep 10, 11:24 AM
Stan added a comment to D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.

@Nescio just check whether you get the errors described in the test case when doing the test case, and no longer errors after applying the patch :)

Tue, Sep 10, 11:24 AM
Nescio created D2280: remove armour trailing zeroes from templates.
Tue, Sep 10, 11:23 AM
elexis added a comment to rP22878: Fix issues with MakeGoalReachable when the goal wasn't reachable following….

Fixed issue reported by faction02 in a forum PM and analyzed by Freagarach, thank you!!
https://wildfiregames.com/forum/index.php?/messenger/10014/

Tue, Sep 10, 11:20 AM
elexis updated the summary of D2277: Fix issues with MakeGoalReachable when the goal wasn't reachable following D1882/rP22817.
Tue, Sep 10, 11:20 AM
Nescio added a comment to D2273: Fix structree / history civ button rebase error in D2240 / rP22854 and global hotekys triggering upon release in rP22851.

Unfortunately I don't understand these lines of codes, therefore I don't consider myself capable of properly reviewing this.

Tue, Sep 10, 11:19 AM
Nescio added a comment to D2221: use bullets in civ history window.

Thank you!

Tue, Sep 10, 11:18 AM
Freagarach added a comment to rP22878: Fix issues with MakeGoalReachable when the goal wasn't reachable following….
ERROR: JavaScript error: simulation/ai/common-api/map-module.js line 44
TypeError: p is undefined

at turn 1092 in replay (SVN 22882).
Not sure but it might be introduced here?

Tue, Sep 10, 10:56 AM
Stan added inline comments to D2175: [WIP] - Basic battalionish support..
Tue, Sep 10, 10:43 AM
Vulcan added a comment to D2175: [WIP] - Basic battalionish support..

Successful build - Chance fights ever on the side of the prudent.

Tue, Sep 10, 10:40 AM
Vulcan added a comment to D2175: [WIP] - Basic battalionish support..

Successful build - Chance fights ever on the side of the prudent.

Tue, Sep 10, 10:36 AM
Freagarach updated the diff for D2175: [WIP] - Basic battalionish support..

@Angen's inlines.

Tue, Sep 10, 10:34 AM
Stan added a reviewer for D1637: BoolArray array wrapper.: FeXoR.
Tue, Sep 10, 10:31 AM
Stan added a comment to D2199: Add RPC interface for Reinforcement Learning.

@wraitii @elexis any changes you'd like to be made for that patch ?

Tue, Sep 10, 10:25 AM
Stan added a comment to D2197: Add support for recording replay metadata when in nonvisual mode.

@wraitii @elexis any changes you'd like to be made for that patch ?

Tue, Sep 10, 10:25 AM
Stan committed rP22883: Fix the walk/feeding animation of the gazelle..
Fix the walk/feeding animation of the gazelle.
Tue, Sep 10, 9:54 AM
autobuild committed rP22882: [Windows] Automated build..
[Windows] Automated build.
Tue, Sep 10, 7:25 AM
Vulcan added a comment to D2279: UnitAI: Fix ESLint coding style warnings.

Successful build - Chance fights ever on the side of the prudent.

Tue, Sep 10, 3:42 AM
Vulcan added a comment to D2279: UnitAI: Fix ESLint coding style warnings.

Successful build - Chance fights ever on the side of the prudent.

Tue, Sep 10, 3:40 AM
Krinkle updated the summary of D2279: UnitAI: Fix ESLint coding style warnings.
Tue, Sep 10, 3:38 AM
Krinkle created D2279: UnitAI: Fix ESLint coding style warnings.
Tue, Sep 10, 3:38 AM
LordGood committed rP22881: ptolemy houses, Enrique's pines.
ptolemy houses, Enrique's pines
Tue, Sep 10, 1:21 AM
Vulcan added a comment to D2271: Fix lobby utf8 conversion following rP22856 / D2264.

Successful build - Chance fights ever on the side of the prudent.

Tue, Sep 10, 12:15 AM
Vulcan added a comment to D2271: Fix lobby utf8 conversion following rP22856 / D2264.

Successful build - Chance fights ever on the side of the prudent.

Tue, Sep 10, 12:12 AM
elexis updated the diff for D2271: Fix lobby utf8 conversion following rP22856 / D2264.

Update following rP22880, rP22875.

Tue, Sep 10, 12:11 AM

Mon, Sep 9

elexis committed rP22880: Pass XmppClient CertificateErrorToString independent of ConnectionErrorToString….
Pass XmppClient CertificateErrorToString independent of ConnectionErrorToString…
Mon, Sep 9, 11:27 PM
elexis closed D2274: Pass lobby certificate status as a separate value and allow Xmpp error strings to become static.
Mon, Sep 9, 11:27 PM
elexis committed rP22879: Fix missing XmppClient m_certStatus and m_PresenceUpdate member initialization….
Fix missing XmppClient m_certStatus and m_PresenceUpdate member initialization…
Mon, Sep 9, 10:50 PM
elexis closed D2278: Fix uninitialized XmppClient members.
Mon, Sep 9, 10:50 PM
elexis added inline comments to D2278: Fix uninitialized XmppClient members.
Mon, Sep 9, 10:44 PM
elexis added a comment to D2278: Fix uninitialized XmppClient members.

I've tested more, I surrender.

Mon, Sep 9, 10:40 PM
elexis updated the summary of D2278: Fix uninitialized XmppClient members.
Mon, Sep 9, 10:38 PM
elexis added a comment to P170 Conditional jump or move depends on uninitialised value IGUIObject::SendEvent IXmppClient::create JS_CallFunctionValue.

Nope, that still doesn't fix the conditional jump.

Mon, Sep 9, 10:20 PM
Vulcan added a comment to D2278: Fix uninitialized XmppClient members.

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 9:45 PM
elexis updated the summary of D2278: Fix uninitialized XmppClient members.
Mon, Sep 9, 9:43 PM
Vulcan added a comment to D2278: Fix uninitialized XmppClient members.

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 9:42 PM
elexis created D2278: Fix uninitialized XmppClient members.
Mon, Sep 9, 9:40 PM
elexis added a comment to P170 Conditional jump or move depends on uninitialised value IGUIObject::SendEvent IXmppClient::create JS_CallFunctionValue.

It seems this is my fault for not initializing XmppClient primitive members m_certStatus and m_PresenceUpdate in rP21901 and rP22855...
Good news is that valgrind reveals stupidity systematically.
The conditional jump warning is gone after initializing all members of XmppClient properly.

Mon, Sep 9, 9:31 PM
elexis updated subscribers of rP21901: Display lobby TLS certificate verification errors from gloox, refs #4705..
Mon, Sep 9, 9:27 PM
Vulcan added a comment to D2274: Pass lobby certificate status as a separate value and allow Xmpp error strings to become static.

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 9:01 PM
wraitii committed rP22878: Fix issues with MakeGoalReachable when the goal wasn't reachable following….
Fix issues with MakeGoalReachable when the goal wasn't reachable following…
Mon, Sep 9, 8:58 PM
wraitii closed D2277: Fix issues with MakeGoalReachable when the goal wasn't reachable following D1882/rP22817.
Mon, Sep 9, 8:58 PM
Vulcan added a comment to D2274: Pass lobby certificate status as a separate value and allow Xmpp error strings to become static.

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 8:57 PM
wraitii committed rP22877: Silence uninitialized variable warnings on MakeGoalReachable and….
Silence uninitialized variable warnings on MakeGoalReachable and…
Mon, Sep 9, 8:57 PM
wraitii closed D2250: Silence uninitialized variable warnings on MakeGoalReachable and FindNearestNavcellInRegions in rP22817.
Mon, Sep 9, 8:57 PM
elexis updated the diff for D2274: Pass lobby certificate status as a separate value and allow Xmpp error strings to become static.

Missing file, also init m_CertStatus

Mon, Sep 9, 8:56 PM
elexis updated the test plan for D2274: Pass lobby certificate status as a separate value and allow Xmpp error strings to become static.
Mon, Sep 9, 8:55 PM
Vulcan added a comment to D2277: Fix issues with MakeGoalReachable when the goal wasn't reachable following D1882/rP22817.

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 8:49 PM
Vulcan added a comment to D2277: Fix issues with MakeGoalReachable when the goal wasn't reachable following D1882/rP22817.

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 8:45 PM
wraitii created D2277: Fix issues with MakeGoalReachable when the goal wasn't reachable following D1882/rP22817.
Mon, Sep 9, 8:43 PM
elexis committed rP22876: Beautify civinfo page with bullet points..
Beautify civinfo page with bullet points.
Mon, Sep 9, 8:41 PM
elexis closed D2221: use bullets in civ history window.
Mon, Sep 9, 8:41 PM
Vulcan added a comment to D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 8:36 PM
elexis added a comment to P170 Conditional jump or move depends on uninitialised value IGUIObject::SendEvent IXmppClient::create JS_CallFunctionValue.

After commenting out the create XmppClient call, the conditional jump warning is gone.

Mon, Sep 9, 8:35 PM
Vulcan added a comment to D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 8:29 PM
bb updated the diff for D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.

Notice that mouseWheel and mouseButton events are never repeated (at least that is what testing says here)

Mon, Sep 9, 8:28 PM
elexis created P176 gloox::DNS::resolve leak.
Mon, Sep 9, 8:19 PM
Stan added a comment to P174 CTextureManagerImpl::CTextureManagerImpl leak.
		if (!m_DisableGL)
		{
			// Construct 1x1 24-bit texture
			shared_ptr<u8> data(new u8[3], ArrayDeleter());
			data.get()[0] = 255;
			data.get()[1] = 0;
			data.get()[2] = 255;
			Tex t;
			(void)t.wrap(1, 1, 24, 0, data, 0);
Mon, Sep 9, 8:08 PM
elexis added a comment to P175 CTextRenderer::Render() possible leak.

Affected line:

glDrawElements(GL_TRIANGLES, indexes.size(), GL_UNSIGNED_SHORT, &indexes[0]);

Mon, Sep 9, 8:07 PM
elexis created P175 CTextRenderer::Render() possible leak.
Mon, Sep 9, 8:07 PM
elexis created P174 CTextureManagerImpl::CTextureManagerImpl leak.
Mon, Sep 9, 8:05 PM
elexis added a comment to P170 Conditional jump or move depends on uninitialised value IGUIObject::SendEvent IXmppClient::create JS_CallFunctionValue.

Affected JS_CallFunctionValue in IGUIObject::ScriptEvent:

	JS::AutoValueVector paramData(cx);
	paramData.append(mouse);
	JS::RootedObject obj(cx, GetJSObject());
	JS::RootedValue handlerVal(cx, JS::ObjectValue(*it->second));
	JS::RootedValue result(cx, JS::UndefinedValue());
	if (!JS_CallFunctionValue(cx, obj, handlerVal, paramData, &result))
	{
		// We have no way to propagate the script exception, so just ignore it
		// and hope the caller checks JS_IsExceptionPending
	}
Mon, Sep 9, 8:03 PM
elexis added a comment to P173 GUIRenderer::Draw(DrawCalls& Calls, float Z) possible leak.

The affected line in GUIRenderer::Draw is glDrawArrays(GL_TRIANGLES, 0, 6);.

Mon, Sep 9, 8:02 PM
Stan added a comment to P170 Conditional jump or move depends on uninitialised value IGUIObject::SendEvent IXmppClient::create JS_CallFunctionValue.

Offending code ?

Mon, Sep 9, 7:59 PM
elexis created P173 GUIRenderer::Draw(DrawCalls& Calls, float Z) possible leak.
Mon, Sep 9, 7:59 PM
elexis added a comment to P172 CGUI::Draw() (CGUI.cpp:347) possible leak glClear(GL_DEPTH_BUFFER_BIT);.

The affected line is glClear(GL_DEPTH_BUFFER_BIT);:

Mon, Sep 9, 7:54 PM
elexis created P172 CGUI::Draw() (CGUI.cpp:347) possible leak glClear(GL_DEPTH_BUFFER_BIT);.
Mon, Sep 9, 7:52 PM
Vulcan added a comment to D2276: Add build order to unit commands to play different sounds for build and repair.

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 7:51 PM
Stan awarded D2276: Add build order to unit commands to play different sounds for build and repair a 100 token.
Mon, Sep 9, 7:50 PM
Vulcan added a comment to D2276: Add build order to unit commands to play different sounds for build and repair.

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 7:49 PM
Angen updated the diff for D2276: Add build order to unit commands to play different sounds for build and repair.

add entry to template, fix repair command back

Mon, Sep 9, 7:48 PM
Vulcan added a comment to D2276: Add build order to unit commands to play different sounds for build and repair.

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 7:39 PM
Vulcan added a comment to D2276: Add build order to unit commands to play different sounds for build and repair.

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 7:36 PM
Angen created D2276: Add build order to unit commands to play different sounds for build and repair.
Mon, Sep 9, 7:35 PM
elexis changed the visibility for P170 Conditional jump or move depends on uninitialised value IGUIObject::SendEvent IXmppClient::create JS_CallFunctionValue.
Mon, Sep 9, 7:29 PM
elexis changed the visibility for P171 HWDetect.cpp:502 ReportGLLimits INTEGER(SAMPLE_BUFFERS); possible memory leak.
Mon, Sep 9, 7:29 PM
elexis created P171 HWDetect.cpp:502 ReportGLLimits INTEGER(SAMPLE_BUFFERS); possible memory leak.
Mon, Sep 9, 7:29 PM
Vulcan added a comment to D2275: Fix units sometimes turning around when fleeing (introduced by D1987/rP22431).

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 7:18 PM
Vulcan added a comment to D2275: Fix units sometimes turning around when fleeing (introduced by D1987/rP22431).

Successful build - Chance fights ever on the side of the prudent.

Mon, Sep 9, 7:12 PM
wraitii created D2275: Fix units sometimes turning around when fleeing (introduced by D1987/rP22431).
Mon, Sep 9, 7:10 PM
elexis created P170 Conditional jump or move depends on uninitialised value IGUIObject::SendEvent IXmppClient::create JS_CallFunctionValue.
Mon, Sep 9, 7:08 PM
wraitii added a reviewer for D781: Elevation attack bonus for ranged units: wraitii.
Mon, Sep 9, 6:38 PM
wraitii added a reviewer for D2269: Combine attacker data in "attackerData" in attack-related code.: wraitii.
Mon, Sep 9, 6:38 PM
wraitii added a reviewer for D1838: Add proximity attack component.: wraitii.
Mon, Sep 9, 6:38 PM
wraitii added a reviewer for D2128: Use CreateObject in EngineScriptConversions: wraitii.
Mon, Sep 9, 6:37 PM
wraitii added a reviewer for D2229: Elaborate Armour.: wraitii.
Mon, Sep 9, 6:37 PM
wraitii added a reviewer for D2270: Allow area damages to have a minimum range.: wraitii.
Mon, Sep 9, 6:37 PM