Page MenuHomeWildfire Games
Feed All Stories

Sep 19 2019

elexis updated subscribers of D2304: Delete GUI.h umbrella include.
Sep 19 2019, 5:09 AM
elexis accepted D2295: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase issues..

Sorry that I was too lazy to review the original patch, one needs to know the circumstances of the hotkey code which takes some time to get back into again.
For the audit in rP22909 I looked all of that up again and the committed code indeed looks better than the previous code which called one event handler from the other handler.

Sep 19 2019, 4:53 AM
elexis added a comment to rP22904: manual/intro.txt corrections.

Here an example of how a default.cfg / intro.txt change is properly applied rP21173, rP22650.
Here an example where they are mostly similar but differ rP21339 that I wanted to fix in D2273.

Sep 19 2019, 4:49 AM
elexis added inline comments to rP22923: Unify loadgame and savegame dialog following rP13579, refs #2030..
Sep 19 2019, 4:30 AM
elexis requested changes to D1346: List multiselection.

Relax grammar:

In D1346#55260, @Angen wrote:

I know about this:
multiSelection_enabled as param in xml - need to fix varning from validator

Sep 19 2019, 2:08 AM
Vulcan added a comment to D1346: List multiselection.

Successful build - Chance fights ever on the side of the prudent.

Sep 19 2019, 1:20 AM
Vulcan added a comment to D1346: List multiselection.

Successful build - Chance fights ever on the side of the prudent.

Sep 19 2019, 1:15 AM
elexis updated the diff for D1346: List multiselection.

Rebase for september 2019.

Sep 19 2019, 1:13 AM
elexis updated the summary of D1346: List multiselection.
Sep 19 2019, 1:09 AM
nani awarded D2304: Delete GUI.h umbrella include a Like token.
Sep 19 2019, 12:08 AM
Vulcan added a comment to D2304: Delete GUI.h umbrella include.

Successful build - Chance fights ever on the side of the prudent.

Sep 19 2019, 12:00 AM

Sep 18 2019

elexis updated the test plan for D2304: Delete GUI.h umbrella include.
Sep 18 2019, 11:58 PM
Vulcan added a comment to D2304: Delete GUI.h umbrella include.

Build failure - The Moirai have given mortals hearts that can endure.

Sep 18 2019, 11:58 PM
Harbormaster failed remote builds in B9462: Diff 9847 for D2304: Delete GUI.h umbrella include!
Sep 18 2019, 11:58 PM
elexis created D2304: Delete GUI.h umbrella include.
Sep 18 2019, 11:57 PM
Harbormaster failed to build B9461: rP22931: Move CGUIDummyObject class used for empty GUI objects to a separate file, and… for rP22931: Move CGUIDummyObject class used for empty GUI objects to a separate file, and…!
Sep 18 2019, 10:53 PM
elexis committed rP22931: Move CGUIDummyObject class used for empty GUI objects to a separate file, and….
Move CGUIDummyObject class used for empty GUI objects to a separate file, and…
Sep 18 2019, 10:52 PM
elexis closed D2206: Put CGUI BaseObject / CGUIDummyObject on the stack.
Sep 18 2019, 10:51 PM
Harbormaster failed to build B9460: rP22930: Following rP22913 fix latest issues mentioned by @Stan in the hellenic helmets… for rP22930: Following rP22913 fix latest issues mentioned by @Stan in the hellenic helmets…!
Sep 18 2019, 9:59 PM
Alexandermb committed rP22930: Following rP22913 fix latest issues mentioned by @Stan in the hellenic helmets….
Following rP22913 fix latest issues mentioned by @Stan in the hellenic helmets…
Sep 18 2019, 9:57 PM
wraitii added a comment to D2303: Fix SetGarrisoned missed in rP22753..
In D2303#96116, @elexis wrote:

But is the patch correct and complete too? I remember seeing Autogarrison, refs D885, D1146, D1228, D1403

Sep 18 2019, 9:54 PM
elexis added a comment to D1674: Check translations for sprintf errors.

Recap: Gallaecio kindly run this script again to see if there are broken translations again found by this script. There are and they were fixed, thanks (see http://irclogs.wildfiregames.com/2019-09/2019-09-18-QuakeNet-%230ad-dev.log)!

Sep 18 2019, 9:49 PM
elexis added a comment to D2303: Fix SetGarrisoned missed in rP22753..

But is the patch correct and complete too? I remember seeing Autogarrison, refs D885, D1146, D1228, D1403

Sep 18 2019, 9:29 PM
Harbormaster failed to build B9459: rP22929: Fix SetGarrisoned() call when transforming an entity for rP22929: Fix SetGarrisoned() call when transforming an entity!
Sep 18 2019, 9:08 PM
wraitii committed rP22929: Fix SetGarrisoned() call when transforming an entity.
Fix SetGarrisoned() call when transforming an entity
Sep 18 2019, 9:07 PM
wraitii closed D2303: Fix SetGarrisoned missed in rP22753..
Sep 18 2019, 9:07 PM
wraitii accepted D2196: Fixes values of clip planes in PostProcManager.

Change is positive and this works on my machine -> Accept.

Sep 18 2019, 9:02 PM
wraitii accepted D2303: Fix SetGarrisoned missed in rP22753..

Pretty weird bug haha.

Sep 18 2019, 8:59 PM
Vulcan added a comment to D2295: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase issues..

Successful build - Chance fights ever on the side of the prudent.

Sep 18 2019, 8:58 PM
Harbormaster failed remote builds in B9458: Diff 9844 for D2295: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase issues.!
Sep 18 2019, 8:52 PM
Vulcan added a comment to D2295: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase issues..

Build failure - The Moirai have given mortals hearts that can endure.

Sep 18 2019, 8:52 PM
wraitii added inline comments to D2207: Adds a function to pick entities with obstructions on screen.
Sep 18 2019, 8:51 PM
wraitii updated the diff for D2295: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase issues..

Add missing autorequests.

Sep 18 2019, 8:49 PM
Vulcan added a comment to D2293: Allow code to register hooks which get called whenever a function value changes, use this to clean rendering options further..

Build failure - The Moirai have given mortals hearts that can endure.

Sep 18 2019, 8:46 PM
Harbormaster failed remote builds in B9457: Diff 9843 for D2293: Allow code to register hooks which get called whenever a function value changes, use this to clean rendering options further.!
Sep 18 2019, 8:44 PM
Vulcan added a comment to D2293: Allow code to register hooks which get called whenever a function value changes, use this to clean rendering options further..

Build failure - The Moirai have given mortals hearts that can endure.

Sep 18 2019, 8:44 PM
wraitii updated the diff for D2293: Allow code to register hooks which get called whenever a function value changes, use this to clean rendering options further..

Return an iterator when hooking, so we can safely erase it. This code didn't need that, but other code might, and it's cleaner to handle it just in case.

Sep 18 2019, 8:44 PM
Stan added a comment to D1619: Enable support for powerpc64 systems.

Needs to be fixed because of SM45.

Sep 18 2019, 7:40 PM
Harbormaster failed to build B9456: rP22928: Update translations after fixing sprintf issues for rP22928: Update translations after fixing sprintf issues!
Sep 18 2019, 7:14 PM
Gallaecio committed rP22928: Update translations after fixing sprintf issues.
Update translations after fixing sprintf issues
Sep 18 2019, 7:12 PM
Silier added inline comments to D1674: Check translations for sprintf errors.
Sep 18 2019, 7:07 PM
Gallaecio accepted D1674: Check translations for sprintf errors.
Sep 18 2019, 6:55 PM
Vulcan added a comment to D1763: Removes duplication of Clamp function.

Successful build - Chance fights ever on the side of the prudent.

Sep 18 2019, 6:03 PM
Harbormaster failed remote builds in B9455: Diff 9842 for D1763: Removes duplication of Clamp function!
Sep 18 2019, 5:59 PM
Vulcan added a comment to D1763: Removes duplication of Clamp function.

Build failure - The Moirai have given mortals hearts that can endure.

Sep 18 2019, 5:59 PM
vladislavbelov updated the diff for D1763: Removes duplication of Clamp function.

Updates after last commits.

Sep 18 2019, 5:56 PM
Vulcan added a comment to D2276: Add build order to unit commands to play different sounds for build and repair.

Successful build - Chance fights ever on the side of the prudent.

Sep 18 2019, 5:10 PM
Vulcan added a comment to D2276: Add build order to unit commands to play different sounds for build and repair.

Successful build - Chance fights ever on the side of the prudent.

Sep 18 2019, 5:10 PM
Silier updated the diff for D2276: Add build order to unit commands to play different sounds for build and repair.
Sep 18 2019, 5:06 PM
Harbormaster failed to build B9453: rP22927: Removes usages of duplication of Clamp function in simulation and atlas. Refs… for rP22927: Removes usages of duplication of Clamp function in simulation and atlas. Refs…!
Sep 18 2019, 5:06 PM
elexis added inline comments to D2288: XmppClient gloox message subtype specific JS message handlers.
Sep 18 2019, 5:05 PM
vladislavbelov committed rP22927: Removes usages of duplication of Clamp function in simulation and atlas. Refs….
Removes usages of duplication of Clamp function in simulation and atlas. Refs…
Sep 18 2019, 5:02 PM
Harbormaster failed to build B9452: rP22926: Removes usages of duplication of Clamp function in gui, ps and renderer. Refs… for rP22926: Removes usages of duplication of Clamp function in gui, ps and renderer. Refs…!
Sep 18 2019, 4:46 PM
vladislavbelov committed rP22926: Removes usages of duplication of Clamp function in gui, ps and renderer. Refs….
Removes usages of duplication of Clamp function in gui, ps and renderer. Refs…
Sep 18 2019, 4:45 PM
elexis added inline comments to D2276: Add build order to unit commands to play different sounds for build and repair.
Sep 18 2019, 4:45 PM
elexis updated subscribers of D1674: Check translations for sprintf errors.

Yet another case:
https://wildfiregames.com/forum/index.php?/topic/27034-save-game-eeror/

Sep 18 2019, 4:43 PM
Stan added a comment to D2207: Adds a function to pick entities with obstructions on screen.

It looks like there is only one entity with obstruction component processing in these lines, no?

Sep 18 2019, 3:07 PM
vladislavbelov added a comment to D2207: Adds a function to pick entities with obstructions on screen.
In D2207#96066, @Stan wrote:
Sep 18 2019, 3:06 PM
Stan added a comment to D2207: Adds a function to pick entities with obstructions on screen.

If you are looking for more things regarding obstructions that could be moved to cpp Have a look at (ping @wraitii):

Sep 18 2019, 2:49 PM
Stan added inline comments to D2207: Adds a function to pick entities with obstructions on screen.
Sep 18 2019, 2:39 PM
Stan added inline comments to D2207: Adds a function to pick entities with obstructions on screen.
Sep 18 2019, 2:36 PM
Stan added inline comments to D2288: XmppClient gloox message subtype specific JS message handlers.
Sep 18 2019, 2:26 PM
Vulcan added a comment to D2288: XmppClient gloox message subtype specific JS message handlers.

Successful build - Chance fights ever on the side of the prudent.

Sep 18 2019, 1:48 PM
vladislavbelov added inline comments to D2207: Adds a function to pick entities with obstructions on screen.
Sep 18 2019, 1:32 PM
Vulcan added a comment to D2206: Put CGUI BaseObject / CGUIDummyObject on the stack.

Successful build - Chance fights ever on the side of the prudent.

Sep 18 2019, 1:32 PM
Vulcan added a comment to D2206: Put CGUI BaseObject / CGUIDummyObject on the stack.

Successful build - Chance fights ever on the side of the prudent.

Sep 18 2019, 1:28 PM
elexis updated the diff for D2206: Put CGUI BaseObject / CGUIDummyObject on the stack.

Rebase

Sep 18 2019, 1:24 PM
Stan added inline comments to D14: Thread the pathfinder computations.
Sep 18 2019, 1:12 PM
elexis updated the summary of D2303: Fix SetGarrisoned missed in rP22753..
Sep 18 2019, 12:50 PM
Stan added inline comments to D2207: Adds a function to pick entities with obstructions on screen.
Sep 18 2019, 12:41 PM
vladislavbelov added inline comments to D2207: Adds a function to pick entities with obstructions on screen.
Sep 18 2019, 12:30 PM
Stan added inline comments to D2207: Adds a function to pick entities with obstructions on screen.
Sep 18 2019, 12:24 PM
Stan added inline comments to D2111: [PetraAI] - Do not try to attack entities which can't be attacked..
Sep 18 2019, 12:18 PM
Silier accepted D2111: [PetraAI] - Do not try to attack entities which can't be attacked..

looks good to me

Sep 18 2019, 11:42 AM
vladislavbelov committed rP22925: Removes usages of duplication of Clamp function in graphics. Refs D1763..
Removes usages of duplication of Clamp function in graphics. Refs D1763.
Sep 18 2019, 10:34 AM
Vulcan added a comment to D2207: Adds a function to pick entities with obstructions on screen.

Successful build - Chance fights ever on the side of the prudent.

Sep 18 2019, 9:48 AM
Harbormaster failed remote builds in B9449: Diff 9839 for D2207: Adds a function to pick entities with obstructions on screen!
Sep 18 2019, 9:47 AM
Vulcan added a comment to D2207: Adds a function to pick entities with obstructions on screen.

Build failure - The Moirai have given mortals hearts that can endure.

Sep 18 2019, 9:47 AM
vladislavbelov updated the diff for D2207: Adds a function to pick entities with obstructions on screen.

Adds template function.

Sep 18 2019, 9:45 AM
vladislavbelov added a comment to D1763: Removes duplication of Clamp function.

I will commit it in separate commits, grouped by folders.

Sep 18 2019, 9:39 AM
Vulcan added a comment to D2303: Fix SetGarrisoned missed in rP22753..

Successful build - Chance fights ever on the side of the prudent.

Sep 18 2019, 9:20 AM
Vulcan added a comment to D2303: Fix SetGarrisoned missed in rP22753..

Successful build - Chance fights ever on the side of the prudent.

Sep 18 2019, 9:17 AM
Freagarach added inline comments to rP22753: Make Promotion.js use the common Transform helper, add resource gatherer and….
Sep 18 2019, 9:14 AM
Freagarach created D2303: Fix SetGarrisoned missed in rP22753..
Sep 18 2019, 9:11 AM
Stan updated subscribers of D95: Atlas - Wonder Victory Timeout and Last Man Standing Checkbox.
Sep 18 2019, 8:04 AM
Silier added inline comments to D1946: Windows Differential testing.
Sep 18 2019, 7:28 AM
autobuild committed rP22924: [Windows] Automated build..
[Windows] Automated build.
Sep 18 2019, 7:26 AM
elexis committed rP22923: Unify loadgame and savegame dialog following rP13579, refs #2030..
Unify loadgame and savegame dialog following rP13579, refs #2030.
Sep 18 2019, 4:34 AM
elexis closed D2290: Unify load game and savegame screen.
Sep 18 2019, 4:34 AM
Vulcan added a comment to D2290: Unify load game and savegame screen.

Build failure - The Moirai have given mortals hearts that can endure.

Sep 18 2019, 2:52 AM
Harbormaster failed remote builds in B9446: Diff 9836 for D2290: Unify load game and savegame screen!
Sep 18 2019, 2:51 AM
Vulcan added a comment to D2290: Unify load game and savegame screen.

Build failure - The Moirai have given mortals hearts that can endure.

Sep 18 2019, 2:51 AM
elexis updated the diff for D2290: Unify load game and savegame screen.

Happily move over gui/common/functions_utility_loadsave.js.
That needed also to change the init call to updateSavegameList, otherwise it'd have broken rP19471 again.

Sep 18 2019, 2:51 AM
elexis committed rP22922: Happy savegame hack removal following rP13579, refs #2030..
Happy savegame hack removal following rP13579, refs #2030.
Sep 18 2019, 2:18 AM
elexis closed D2302: Remove savegame hack from rP13579.
Sep 18 2019, 2:18 AM
elexis added inline comments to D2302: Remove savegame hack from rP13579.
Sep 18 2019, 2:10 AM
elexis raised a concern with rP22909: Fix hotkey events synching with hotkey state..

Moving the GUI test page into a separate folder and the ScriptInterface cleanup would be good (D2295).
The missing JS_AutoRequest and the HotkeyInputHandler(ev); are strict defects, so I mark it that it's not forgotton (especially since its currently marked as green).
(The hotkey behavior change itself seemed correct from above analysis, thanks for that!)

Sep 18 2019, 2:01 AM
elexis updated the test plan for D2302: Remove savegame hack from rP13579.
Sep 18 2019, 1:54 AM
elexis added inline comments to D2302: Remove savegame hack from rP13579.
Sep 18 2019, 1:51 AM
elexis committed rP22921: Reliably report and reject invalid XML files following rP16733, refs #245….
Reliably report and reject invalid XML files following rP16733, refs #245…
Sep 18 2019, 1:00 AM