Page MenuHomeWildfire Games
Feed All Stories

Nov 26 2019

Stan added a comment to D1042: rename maps/ file names to use underscores (instead of spaces and capitalization).

Okay so I tried the script in the WSL (Windows Subsystem for Linux) As I expected it totally failed because Windows disks are not case sensitive.

Nov 26 2019, 12:02 PM
Stan edited reviewers for D1042: rename maps/ file names to use underscores (instead of spaces and capitalization), added: Stan; removed: elexis.
Nov 26 2019, 11:47 AM
Silier added inline comments to rP23160: Bolt tower and ampitheater commit, updated ptolemaic sentry tower while I was….
Nov 26 2019, 10:32 AM
elexis raised a concern with rP23160: Bolt tower and ampitheater commit, updated ptolemaic sentry tower while I was….
Nov 26 2019, 10:17 AM
elexis planned changes to D2410: Send NetClient GUIMessages to subscribing GUIObjects instead of pulling them onTick.

Botherthings:

  • XmppClient (edit: and UserReporter) equally pulls onTick but only receives messages occasionally, so it should receive the same treatment
  • One needs to subscribe to a GUI Object, but the GUI object itself is not involved at all in the processing of the event. So it would seem nicer to subscribe the event globally, perhaps similar to D2260/rP22851. (The event handlers must be destroyed when the GUI page is destroyed, yet CGUI should remain agnostic of NetClient and XmppClient)
  • To trigger a ScriptEvent, one needs to call RecurseObject. But that means on a GUI object page with 10k objects and only 1 object using the event, it will iterate over 10k objects with 10k function calls for no reason. (However not iterating using RecurseObject means iteration order will not be hierarchical anymore, which is sad, but appears that it can be assumed to be negligible. Secondly it means having to copy the pointers to iterate since that container can change while iterating).
Nov 26 2019, 9:32 AM
Silier accepted D2442: Show progress bar when upgrading..

good point

Nov 26 2019, 8:34 AM
Freagarach requested review of D2442: Show progress bar when upgrading..

I didn't reuse the "pack"-image because someone who wants to change the textures also needs to touch the StatusBars.js then. Which is not bad for base game, but *is* bad for modders.

Nov 26 2019, 8:31 AM
Silier added a reviewer for D2393: Use victory conditions json's in Atlas: Silier.
Nov 26 2019, 8:07 AM
Silier requested changes to D2442: Show progress bar when upgrading..

Since you just copy that textures, why just not to reuse the original directly?
If artists will want to add special texture for them, they will re-upload them anyway,

Nov 26 2019, 7:51 AM
autobuild committed rP23193: [Windows] Automated build..
[Windows] Automated build.
Nov 26 2019, 7:29 AM

Nov 25 2019

FeXoR added a comment to D1634: Fert random map..

I'd suggest adding a reviewer so someone gets notified of your work waiting to enter ;)

Nov 25 2019, 11:55 PM
FeXoR added a comment to D1634: Fert random map..

The 'raster' lib is only used by this map so far so I'd suggest to import it in the map rather than in library.js.
I didn't see this map before and so far it looks good!
Eager to test it ;)

Nov 25 2019, 11:48 PM
elexis committed rP23192: Fix warning about attempted empty batch train occurring if….
Fix warning about attempted empty batch train occurring if…
Nov 25 2019, 9:59 PM
Vulcan added a comment to D2443: Removes hard-coded clip planes from water shader.

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 9:24 PM
Vulcan added a comment to D2443: Removes hard-coded clip planes from water shader.

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 9:22 PM
Silier awarded D2443: Removes hard-coded clip planes from water shader a Like token.
Nov 25 2019, 9:16 PM
vladislavbelov created D2443: Removes hard-coded clip planes from water shader.
Nov 25 2019, 9:15 PM
Stan added a comment to D2442: Show progress bar when upgrading..

Yeah binary files and moving never works.

Nov 25 2019, 9:12 PM
Silier added a comment to D2442: Show progress bar when upgrading..

When I applied the patch, it failed to get pictures so i had to copy them manually.
Aside from that, looks good and works.

Nov 25 2019, 9:10 PM
Stan accepted D2244: Patch SM45 against bug 1266366.

I tested on my raspberry pi, and it fixes a segfault for me too.

Nov 25 2019, 8:43 PM
Stan added a comment to D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.

Thanks for the patch and the detailed answer. I just wanted to make sure we were not doing something wrong by replacing those.

Nov 25 2019, 3:38 PM
elexis committed rP23191: Replace boost::unordered_map, boost::unordered_set with std::unordered_map, std….
Replace boost::unordered_map, boost::unordered_set with std::unordered_map, std…
Nov 25 2019, 3:30 PM
elexis closed D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.
Nov 25 2019, 3:30 PM
elexis added a comment to D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.
In D2441#101896, @Stan wrote:

Any performance difference in using one of the other? I'm all for removing dependencies though.

(Just for the record I had written first half of the post already, I don't forget such a thing.)

Nov 25 2019, 2:39 PM
Stan added a comment to D2440: Per-Unit Discrete LOD using actor quality levels.

Lods should be in the template visual actor. Else actors will become a great mess. Also there will be warnings everywhere or missing props.

Nov 25 2019, 2:27 PM
elexis added inline comments to rP9961: cleanup and simplification of the really old h_mgr code..
Nov 25 2019, 12:26 PM
Vulcan added a comment to D2437: reduce excessive capitalization in game options.

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 12:21 PM
Vulcan added a comment to D2437: reduce excessive capitalization in game options.

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 12:17 PM
Nescio updated the diff for D2437: reduce excessive capitalization in game options.

LOS → vision

Nov 25 2019, 12:16 PM
Vulcan added a comment to D2437: reduce excessive capitalization in game options.

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 12:01 PM
Freagarach added a comment to D2437: reduce excessive capitalization in game options.

Sorry, a tad too late ;)

Nov 25 2019, 11:57 AM
Vulcan added a comment to D2437: reduce excessive capitalization in game options.

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 11:57 AM
Freagarach added inline comments to D2437: reduce excessive capitalization in game options.
Nov 25 2019, 11:57 AM
Nescio updated the diff for D2437: reduce excessive capitalization in game options.

Welcome Screen → welcome screen

Nov 25 2019, 11:55 AM
Vulcan added a comment to D2428: main menu item tooltip corrections..

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 11:55 AM
Stan added a comment to D2442: Show progress bar when upgrading..

I guess pack could have a visual animation at some point too. Would be fun to have a unit reading IKEA instructions.

Nov 25 2019, 11:54 AM
Freagarach added a comment to D2442: Show progress bar when upgrading..

I indeed considered that, but also "pack" does not have that option (probably because it is otherwise not visible whether the entity is packing or not). So I might indeed add an option for this.

Nov 25 2019, 11:52 AM
Stan added inline comments to D2428: main menu item tooltip corrections..
Nov 25 2019, 11:52 AM
Nescio added inline comments to D2437: reduce excessive capitalization in game options.
Nov 25 2019, 11:51 AM
Vulcan added a comment to D2428: main menu item tooltip corrections..

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 11:50 AM
Nescio added inline comments to D2428: main menu item tooltip corrections..
Nov 25 2019, 11:49 AM
Nescio updated the diff for D2428: main menu item tooltip corrections..

Corrected start new match tooltip.

Nov 25 2019, 11:49 AM
Silier removed a reviewer for D1595: Ranged units attacks melee when target in minimum ranged attack range: Restricted Owners Package.
Nov 25 2019, 11:36 AM
Silier added a reviewer for D2438: Fix formationmember not leaving walking state if offset cannot be reached: Restricted Owners Package.
Nov 25 2019, 11:34 AM
Silier added a reviewer for D2442: Show progress bar when upgrading.: Silier.
Nov 25 2019, 11:32 AM
Silier added a comment to D2442: Show progress bar when upgrading..

Code looks good, feature should work as intended by reading the code.
I see usage mainly in that player does not have to select entity, he can just hover over it to see progress.
I would maybe consider to add option into the settings or somehow toogle between show always and show default.

Nov 25 2019, 11:26 AM
Stan added a comment to D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.

Any performance difference in using one of the other? I'm all for removing dependencies though.

Nov 25 2019, 11:25 AM
elexis added a comment to D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.
Nov 25 2019, 11:23 AM
Freagarach added inline comments to D1960: Move the controllability of an entity to cmpIdentity..
Nov 25 2019, 10:55 AM
elexis added a comment to D2392: [gameplay] Team bonus balancing.

You mean something historically relatable which perhaps could be grasped from Sundiatas thread?

Nov 25 2019, 10:48 AM
Vulcan added a comment to D2442: Show progress bar when upgrading..

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 10:32 AM
Vulcan added a comment to D2442: Show progress bar when upgrading..

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 10:27 AM
Freagarach created D2442: Show progress bar when upgrading..
Nov 25 2019, 10:26 AM
Freagarach abandoned D1965: Allow instant-kill for attacks. (And use it for "Slaughter"-attack.).
Nov 25 2019, 9:45 AM
Vulcan added a comment to D2343: Combine "EntityCommand" and "AllyEntityCommand"..

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 9:38 AM
Vulcan added a comment to D2343: Combine "EntityCommand" and "AllyEntityCommand"..

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 9:36 AM
Freagarach planned changes to D2405: [WIP] - Show turrets separately from hidden entities in a garrisonHolder..
  • Do not use the middle mouse button.
  • It probably requires a GUI overhaul, since there is no logical place of showing this now.
Nov 25 2019, 9:36 AM
Freagarach abandoned D2397: Do not hardcode "delete" and "focus-rally" in whether a command button is active..

Merged in D2343.

Nov 25 2019, 9:28 AM
autobuild committed rP23190: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Nov 25 2019, 9:28 AM
Freagarach updated the diff for D2343: Combine "EntityCommand" and "AllyEntityCommand"..

Incorporated D2397.

Nov 25 2019, 9:28 AM
autobuild committed rP23189: [Windows] Automated build..
[Windows] Automated build.
Nov 25 2019, 7:25 AM
wowgetoffyourcellphone added a comment to D2371: Allow to play upgrade animations .

Looks good in-game. Great job.

Nov 25 2019, 1:59 AM
Vulcan added a comment to D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 12:55 AM
Vulcan added a comment to D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 12:30 AM
elexis updated the diff for D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.

ugly namespace for all std::hash.

Nov 25 2019, 12:23 AM
Vulcan added a comment to D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.

Successful build - Chance fights ever on the side of the prudent.

Nov 25 2019, 12:19 AM
Harbormaster failed remote builds in B10125: Diff 10415 for D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function!
Nov 25 2019, 12:14 AM
Vulcan added a comment to D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.

Build failure - The Moirai have given mortals hearts that can endure.

Nov 25 2019, 12:14 AM
elexis updated the diff for D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.

namespace for path.h

Nov 25 2019, 12:13 AM

Nov 24 2019

Vulcan added a comment to D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.

Successful build - Chance fights ever on the side of the prudent.

Nov 24 2019, 11:42 PM
Harbormaster failed remote builds in B10124: Diff 10414 for D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function!
Nov 24 2019, 11:36 PM
Vulcan added a comment to D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.

Build failure - The Moirai have given mortals hearts that can endure.

Nov 24 2019, 11:36 PM
elexis created D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.
Nov 24 2019, 11:35 PM
Freagarach requested changes to D1977: Cheer after no enemy entities left in range.

There also needs to be a formationmember-cheering state I think. (I get errors when using formations.)

Nov 24 2019, 10:35 PM
Vulcan added a comment to D2367: Move the ability to hold a turret to a separate file..

Successful build - Chance fights ever on the side of the prudent.

Nov 24 2019, 10:18 PM
Vulcan added a comment to D2367: Move the ability to hold a turret to a separate file..

Successful build - Chance fights ever on the side of the prudent.

Nov 24 2019, 10:14 PM
Freagarach updated the diff for D2367: Move the ability to hold a turret to a separate file..

Check for cmpTurretPosition and move inside if.

Nov 24 2019, 10:12 PM
Vulcan added a comment to D2343: Combine "EntityCommand" and "AllyEntityCommand"..

Successful build - Chance fights ever on the side of the prudent.

Nov 24 2019, 10:01 PM
Vulcan added a comment to D2343: Combine "EntityCommand" and "AllyEntityCommand"..

Successful build - Chance fights ever on the side of the prudent.

Nov 24 2019, 9:56 PM
Freagarach added inline comments to D2343: Combine "EntityCommand" and "AllyEntityCommand"..
Nov 24 2019, 9:56 PM
Freagarach updated the diff for D2343: Combine "EntityCommand" and "AllyEntityCommand"..
  • Replace controlsPlayer with more extendable check.
  • Remove g_IsObserver from "enabled".
Nov 24 2019, 9:54 PM
nani awarded D2440: Per-Unit Discrete LOD using actor quality levels a Like token.
Nov 24 2019, 9:28 PM
vladislavbelov added inline comments to D2440: Per-Unit Discrete LOD using actor quality levels.
Nov 24 2019, 9:01 PM
Silier added a comment to D2440: Per-Unit Discrete LOD using actor quality levels.

It would be a good feature, although I guess in the average case only high level of detail will be shown, since the camera is top down on average?

Nov 24 2019, 8:50 PM
Silier planned changes to D2440: Per-Unit Discrete LOD using actor quality levels.

move interval to each actor
check distance only if actor defines that it has lod versions
disable/enable lod from graphic options
remove projectile manager changes as not exactly related

Nov 24 2019, 8:49 PM
elexis added a comment to D2440: Per-Unit Discrete LOD using actor quality levels.

The intervals should probably not be buried in the code but specified somewhere, probably ideally in some model related art file or template (and ideally support more than two levels).
Perhaps std::pair<CStr, CStr>("lod", "low")) / selections can be constructed only once per program launch instead of once per call.
{ on a separate line.
Hiding projectiles after a set distance means it will fail for some projectiles of a given size, so it should be moved to data files as well.
It would be a good feature, although I guess in the average case only high level of detail will be shown, since the camera is top down on average?

Nov 24 2019, 8:27 PM
Vulcan added a comment to D2440: Per-Unit Discrete LOD using actor quality levels.

Successful build - Chance fights ever on the side of the prudent.

Nov 24 2019, 8:22 PM
Vulcan added a comment to D2440: Per-Unit Discrete LOD using actor quality levels.

Successful build - Chance fights ever on the side of the prudent.

Nov 24 2019, 8:16 PM
Stan awarded D2440: Per-Unit Discrete LOD using actor quality levels a Love token.
Nov 24 2019, 8:16 PM
Silier created D2440: Per-Unit Discrete LOD using actor quality levels.
Nov 24 2019, 8:14 PM
Stan committed rP23188: Add various blendfiles for backup and future usage. Delete obsolete blend.
Add various blendfiles for backup and future usage. Delete obsolete blend
Nov 24 2019, 7:04 PM
Stan committed rP23187: Remove cape redundant props..
Remove cape redundant props.
Nov 24 2019, 5:38 PM
Stan closed D2434: Remove props from cape animations.
Nov 24 2019, 5:37 PM
Stan accepted D2434: Remove props from cape animations.

Thanks for the patch.

Nov 24 2019, 5:36 PM
Stan committed rP23186: Add an orange firefly particle actor..
Add an orange firefly particle actor.
Nov 24 2019, 5:31 PM
LordGood added a comment to rP23179: Amphitheater name fix, Gladiator commit and amphitheater integration, Maurya….

If I didn't add the projectile limit to the Maurya tower it would have shot 21 building AI arrows on top of the 16 visible garrisoned archer arrows, and it IS an upgraded tower so giving it a small boost ungarrisoned is warranted. These were tested fairly throughly in the editor and don't feel unfair. 16 archers rooted to a single position do not quantify any disproportionate tactical or strategic bonus, and are quickly shot down by either counter archers or siege weapons, things that cannot be done to the Iberian tower's defenders. The absolute worst thing you could do though is try and rush it with non-siege melee units. Once all the archers are shot off the ramparts the tower is only a slightly beefier version of the standard defense tower, with one less soldier inside making it easier to capture.

Nov 24 2019, 3:51 PM
Vulcan added a comment to D2434: Remove props from cape animations.

Successful build - Chance fights ever on the side of the prudent.

Nov 24 2019, 3:10 PM
Vulcan added a comment to D2434: Remove props from cape animations.

Successful build - Chance fights ever on the side of the prudent.

Nov 24 2019, 3:06 PM
Silier updated the diff for D2434: Remove props from cape animations.

fix misstyped file name

Nov 24 2019, 3:04 PM
Vulcan added a comment to D1977: Cheer after no enemy entities left in range.

Successful build - Chance fights ever on the side of the prudent.

Nov 24 2019, 2:57 PM