In D2353#102192, @OptimusShepard wrote:

I currently have no time to write the patch, sorry. If someone else writes this patch I would test it.
Here are the required information which Imarok got from the AMD forum.

https://community.amd.com/thread/244207

I currently have no time to write the patch, sorry. If someone else writes this patch I would test it.
Here are the required information which Imarok got from the AMD forum.

Mostly good, please try to make the JSdoc phrases and comments more telling and check that last "type" check.

Fixes (again)

Seems I forgot add the possibility to customize the base height (was always 0 if ELEVATION_SET)

prototype -> class

Some coding convention notes to keep you waiting for FeXoR.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Fix verb

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

static_cast

I am against the use of the word time, at least alone.
rate is used mainly to talk about money or a pourcentage.
Here we are talking about a movement so the use of the word speed is more appropriate.

In rP23195#39836, @Alexandermb wrote:

In rP23195#39832, @minohaka wrote:

Was playing and got these errors:
ERROR: Mismatch between model's skeleton and animation's skeleton (46 model bones != 49 animation keys)
ERROR: CCacheLoader failed to find archived or source file for: "art/variants/quadraped/base_horse_trader.xml"
ERROR: Could not open path quadraped/base_horse_trader.xml
ERROR: CCacheLoader failed to find archived or source file for: "art/actors/props/units/helmets/hele_thracian_cart_hero_01.xml"
ERROR: CObjectManager::FindObjectBase(): Cannot find object 'props/units/helmets/hele_thracian_cart_hero_01.xml'
ERROR: Failed to build prop model "props/units/helmets/hele_thracian_cart_hero_01.xml" on actor "hero_elephantry_hannibal_d"

Fixed most of them but i can't recognize the mismatch model. Do you know where the model mismatch happens?

In rP23195#39832, @minohaka wrote:

Was playing and got these errors:
ERROR: Mismatch between model's skeleton and animation's skeleton (46 model bones != 49 animation keys)
ERROR: CCacheLoader failed to find archived or source file for: "art/variants/quadraped/base_horse_trader.xml"
ERROR: Could not open path quadraped/base_horse_trader.xml
ERROR: CCacheLoader failed to find archived or source file for: "art/actors/props/units/helmets/hele_thracian_cart_hero_01.xml"
ERROR: CObjectManager::FindObjectBase(): Cannot find object 'props/units/helmets/hele_thracian_cart_hero_01.xml'
ERROR: Failed to build prop model "props/units/helmets/hele_thracian_cart_hero_01.xml" on actor "hero_elephantry_hannibal_d"

Was playing and got these errors:
ERROR: Mismatch between model's skeleton and animation's skeleton (46 model bones != 49 animation keys)
ERROR: CCacheLoader failed to find archived or source file for: "art/variants/quadraped/base_horse_trader.xml"
ERROR: Could not open path quadraped/base_horse_trader.xml
ERROR: CCacheLoader failed to find archived or source file for: "art/actors/props/units/helmets/hele_thracian_cart_hero_01.xml"
ERROR: CObjectManager::FindObjectBase(): Cannot find object 'props/units/helmets/hele_thracian_cart_hero_01.xml'
ERROR: Failed to build prop model "props/units/helmets/hele_thracian_cart_hero_01.xml" on actor "hero_elephantry_hannibal_d"

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Straight from @wraitii's patch from the ticket.
[EDIT]: I've missed the template_unit_ship in changing the decays.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Current naming cases are heterogenous.
It seems most of the UNDERSCORE_UPPERCASE seems to come from C developers.
We notice that at least in source/gui/ there are no UNDERSCORE_UPPERCASE constants, so the folder is selfconsistent.

hmm yes, i wanted that mainly for player, because petra would have advantage as she see whole map.
but realistically, if you see someone runs on top of hill and then down, you dont see him anymore but you know where he went :)

I've been testing this and it is still awesome :)
I really like the feeling when peaking around a corner and what awaits you is a high density of bad guys, it feels so much more like it should.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

' -> "

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

remove debug printf
do profiling
build boost dlls

optional variant, have fun

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Use ints remove the changes.

@nani maybe a good occasion to use the new class syntax? VSCode can auto convert it.
Also missing newline at end of file and semicolons :)

In D1635#102030, @FeXoR wrote:

Could you add a screenshot as a showcase, please?
There was the rectangularSmoothToHight function that took an influence map of surrounding tiles that could also be used to create dunes. (looks like it has been removed in a cleanup frenzy though...)

Could you add a screenshot as a showcase, please?
There was the rectangularSmoothToHight function that took an influence map of surrounding tiles that could also be used to create dunes. (looks like it has been removed in a cleanup frenzy though...)

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Fixed in rP23141 and rP23187 also removing similar issue in rP23147

Still broken @Angen?

I tested it and couldn't break it ;)
Even when obstruction is removed, the formation members go to their correct position.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

This patch also fixes a Profiler2 crash when the userreporter is enabled.

Was missing Profiler2::SaveToFile() that's writing a file as well.

Then let's hope another team member (@elexis?) will eventually find time to review this.