In D2454#102824, @FeXoR wrote:I'm a bit confused about the seemingly random numbers in randomNoiseHashx and randomNoiseHashx.
(Is there a particular reason to chose them like this? Would it be useful to make them optional arguments?)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Dec 9 2019
Dec 9 2019
Vulcan added a comment to D2460: Implement placeholder text for input fields and get rid of hack with mod filter.
Successful build - Chance fights ever on the side of the prudent.
Vulcan added a comment to D2460: Implement placeholder text for input fields and get rid of hack with mod filter.
Successful build - Chance fights ever on the side of the prudent.
Silier added a reviewer for D2460: Implement placeholder text for input fields and get rid of hack with mod filter: Restricted Owners Package.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Fix notes. Add example.
Vulcan added a comment to D2438: Fix formationmember not leaving walking state if offset cannot be reached.
Successful build - Chance fights ever on the side of the prudent.
Vulcan added a comment to D2438: Fix formationmember not leaving walking state if offset cannot be reached.
Successful build - Chance fights ever on the side of the prudent.
Silier updated the diff for D2438: Fix formationmember not leaving walking state if offset cannot be reached.
simplify and rename
you missed some cases :)
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Move safeguard to top.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Stan added inline comments to D2438: Fix formationmember not leaving walking state if offset cannot be reached.
I would prefer to get D1520 in first then i finish this.
If enabled, condition
return m_Enabled || m_Shutdown;
is always true.
From specification of std::condition_variable::wait
void wait (unique_lock<mutex>& lck, Predicate pred);
If pred is specified (2), the function only blocks if pred returns false, and notifications can only unblock the thread when it becomes true
in current case mean that code will never enter wait when in state enabled.
I have no idea about math behind this but code looks good so nice job :)
In D2457#102995, @Angen wrote:Open question: Should we use class syntax while at it?
possibly yes, ideally we should move this to cpp
Open question: Should we use class syntax while at it?
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
- CanBeStationary → StationaryDistance
- nonNegativeDecimal → positiveDecimal
[i18n] Updated POT and PO files.
[Windows] Automated build.
Dec 8 2019
Dec 8 2019
you changed some logic by deleting this.pickup upon leave in approaching
Stan committed rP23225: Add a more explicit message when requested animation rig does not match rigged….
Add a more explicit message when requested animation rig does not match rigged…
Silier awarded rP23224: Fix missing arrow on top of the action-remove-guard.png icon. a Pterodactyl token.
Issue with current code is that it does not apply and removes auras when entity is renamed.
I confirmed by testing that this diff is solving that issue and auras are correctly updated upon e.g. promotion.
So I think we should commit this workaround.
Pros:
- It fixes the issue.
- It gets the correct result at least until zen3 comes out.
Cons:
- It is not the correct way to get the cache associativity from this CPUs.
Stan added a comment to D2285: Inform player that second market is too close to setup trade route and use disabled action.
cursors.zip7 KBDownload
Disabled cursor. There is a txt file with it. Not sure what the game use it for, but everyother icon has it so... Also don't forget to set EOL Native for that file.Fix missing arrow on top of the action-remove-guard.png icon.
Vulcan added a comment to D2285: Inform player that second market is too close to setup trade route and use disabled action.
Successful build - Chance fights ever on the side of the prudent.
Vulcan added a comment to D2285: Inform player that second market is too close to setup trade route and use disabled action.
Successful build - Chance fights ever on the side of the prudent.
Silier updated the diff for D2285: Inform player that second market is too close to setup trade route and use disabled action.
Had some walk so I eliminated something not needed.
If you use windows since the build is not 64 bits you have to pass --large-address-aware to premake. Else it'a limited to 2GB the flag allows it to use up to 4GB. If you play Corinthian Ismuth (4) with too many AIs it will crash after a while anyway...
I've made a mistake by testing procedure. So I didn't seen that the OOM only occurs when I used a version which I compiled myself. So the bug is related to my Visual Studio settings or something like that. Sorry for that.
Changed to class notation.
In D1630#102908, @FeXoR wrote:@"let weight = multiplier;":
Shouldn't waight start at 1 and then be reduced each iteration?
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Rebased.
Silier committed rP23223: ComputeMotionParameters correctly when formation member is added or removed.
ComputeMotionParameters correctly when formation member is added or removed
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Added comment with link.
Vulcan added a comment to D2285: Inform player that second market is too close to setup trade route and use disabled action.
Successful build - Chance fights ever on the side of the prudent.
Vulcan added a comment to D2285: Inform player that second market is too close to setup trade route and use disabled action.
Successful build - Chance fights ever on the side of the prudent.
Nope, this does not fix #5610. That has to be fixed differently.
Thanks for working on a fix! Does this also happen to fix #5610?
elexis awarded rP23219: Remove duplication of code from WaterManager a Like token.
elexis awarded rP23217: Fix formation-walking infinite loop introduced in rP22506 a Like token.
elexis removed 1 auditor(s) for rP22475: Fix IDLE-related infinite loops by moving stateful calls to IDLE.timer.: elexis.
Thanks for the fix!
Freagarach accepted rP22475: Fix IDLE-related infinite loops by moving stateful calls to IDLE.timer..
Freagarach accepted rP22506: Restore previous formation behaviour of targeting nearby enemies when idle /….
My concern was fixed in rP23217.
This is nice improvement for artists and moders so they get more detailed report about current error.
GetNumBones and GetNumKeys return both size_t what is unsigned int making it safe to convert to unsigned long.
@"let weight = multiplier;":
Shouldn't waight start at 1 and then be reduced each iteration?
Good to go I guess, thanks for the changes! :)
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Prevent moving enabled mods up and down (manual sorting) while filters are applied, because user would sort filtered mods and we need to sort not filtered version of them.
so no, still able to break it
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Wildfire Games · Phabricator