Page MenuHomeWildfire Games
Feed All Stories

Mon, Feb 10

elexis added a comment to D2629: Fix remote segfault when spamming chat.
In D2629#110106, @Stan wrote:

Can't we have an explicit message about message being too big?

There is "CNetMessage: Corrupt packet (incorrect size)" already.

Mon, Feb 10, 1:33 PM
vladislavbelov added inline comments to D2629: Fix remote segfault when spamming chat.
Mon, Feb 10, 1:05 PM
Vulcan added a comment to D2626: 3 → ȝ ; ‘ and ’ → ʿ.

Successful build - Chance fights ever on the side of the prudent.

Mon, Feb 10, 10:27 AM
Nescio updated the summary of D2626: 3 → ȝ ; ‘ and ’ → ʿ.
Mon, Feb 10, 10:20 AM
Nescio updated the diff for D2626: 3 → ȝ ; ‘ and ’ → ʿ.

Also replace quotation marks with proper ayin.

Mon, Feb 10, 10:18 AM
Nescio added a comment to D2626: 3 → ȝ ; ‘ and ’ → ʿ.

That's sad the correct symbol does not exist in the game's font though... I assume there isn't much we can do about that...

There is nothing wrong with the yogh, it is used in many publications. U+A723 is relatively new. If one really wants it, one could consider adding another font that has the character (e.g. Charis SIL, DejaVu Serif, Doulos SIL, Gentium Plus, Liberation Serif) or let 0 A.D. use font files directly (e.g. with pango) rather than as rendered images. However, that's a lot of work and far beyond the scope of this patch.

Mon, Feb 10, 10:05 AM
autobuild committed rP23491: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Mon, Feb 10, 9:27 AM
Stan added a comment to D2376: Store the garrisonHolder in cmpGarrisonable instead of iterating orders..

Shouldn't it be done in UnitMotionFlying as well?

Mon, Feb 10, 8:42 AM
Vulcan added a comment to D2453: Allow Flying objects to be stationary.

Successful build - Chance fights ever on the side of the prudent.

Mon, Feb 10, 8:37 AM
Stan updated the diff for D2453: Allow Flying objects to be stationary.

Fix typo.

Mon, Feb 10, 8:25 AM
Stan added a comment to D2629: Fix remote segfault when spamming chat.

Can't we have an explicit message about message being too big?

Mon, Feb 10, 7:55 AM
autobuild committed rP23490: [Windows] Automated build..
[Windows] Automated build.
Mon, Feb 10, 7:41 AM
elexis added inline comments to D2629: Fix remote segfault when spamming chat.
Mon, Feb 10, 12:36 AM
vladislavbelov added inline comments to D2629: Fix remote segfault when spamming chat.
Mon, Feb 10, 12:30 AM
Vulcan added a comment to D2629: Fix remote segfault when spamming chat.

Successful build - Chance fights ever on the side of the prudent.

Mon, Feb 10, 12:22 AM
elexis created D2629: Fix remote segfault when spamming chat.
Mon, Feb 10, 12:15 AM

Sun, Feb 9

Stan abandoned D2461: [WIP] Move Unitmotion flying to cpp.
Sun, Feb 9, 11:38 PM
Vulcan added a comment to D2453: Allow Flying objects to be stationary.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Feb 9, 11:37 PM
Vulcan added a comment to D2453: Allow Flying objects to be stationary.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Feb 9, 11:35 PM
Harbormaster failed remote builds in B11092: Diff 11315 for D2453: Allow Flying objects to be stationary!
Sun, Feb 9, 11:32 PM
Vulcan added a comment to D2453: Allow Flying objects to be stationary.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Feb 9, 11:32 PM
Stan updated the diff for D2453: Allow Flying objects to be stationary.

Use square distance instead.

Sun, Feb 9, 11:29 PM
Itms added a comment to D2613: Updated cppformat.

I propose to merge this changes into codebase (I can restore old cppformat name) and create another ticket to update fmt to version 6.x. Unfortunately I'm not sure how much time I will have in the future, so I think better option is to not "lock" this issue further.

I agree, and actually I think it's very nice to use this small upgrade to rename the lib, so you can leave it like this.

Sun, Feb 9, 10:24 PM
elexis committed rP23489: Implement a FixedVector2D::CompareLengthSquared function to provide a more….
Implement a FixedVector2D::CompareLengthSquared function to provide a more…
Sun, Feb 9, 10:01 PM
elexis closed D2058: FixedVector2D CompareLengthSquared.
Sun, Feb 9, 10:00 PM
Vulcan added a comment to D2058: FixedVector2D CompareLengthSquared.

Successful build - Chance fights ever on the side of the prudent.

Sun, Feb 9, 9:24 PM
adrian added a comment to D2613: Updated cppformat.

Thanks a lot for the comments!

Sun, Feb 9, 9:01 PM
elexis updated the diff for D2058: FixedVector2D CompareLengthSquared.

One abs less.

Sun, Feb 9, 8:54 PM
Harbormaster failed remote builds in B11089: Diff 11312 for D2376: Store the garrisonHolder in cmpGarrisonable instead of iterating orders.!
Sun, Feb 9, 8:32 PM
Vulcan added a comment to D2376: Store the garrisonHolder in cmpGarrisonable instead of iterating orders..

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Feb 9, 8:31 PM
Freagarach updated the diff for D2376: Store the garrisonHolder in cmpGarrisonable instead of iterating orders..

Make functions more specific.

Sun, Feb 9, 8:26 PM
Stan added a comment to D2626: 3 → ȝ ; ‘ and ’ → ʿ.

That's sad the correct symbol does not exist in the game's font though... I assume there isn't much we can do about that...

Sun, Feb 9, 7:41 PM
Stan accepted D2626: 3 → ȝ ; ‘ and ’ → ʿ.
Sun, Feb 9, 7:40 PM
Vulcan added a comment to D2058: FixedVector2D CompareLengthSquared.

Successful build - Chance fights ever on the side of the prudent.

Sun, Feb 9, 7:26 PM
Stan added inline comments to D2492: Allow buildings to autobuild themselves.
Sun, Feb 9, 7:00 PM
elexis updated the diff for D2058: FixedVector2D CompareLengthSquared.

More static cast, drop old tests, use macro more often, rename macro.

Sun, Feb 9, 6:57 PM
elexis added a comment to D2058: FixedVector2D CompareLengthSquared.

refs https://docs.microsoft.com/de-de/cpp/intrinsics/emul-emulu?view=vs-2019

Sun, Feb 9, 6:50 PM
Freagarach updated subscribers of D2492: Allow buildings to autobuild themselves.

I know that is a significant change again, but why make it the responsibility of cmpFoundation to autobuild? To me at least, it seems more the responsibility of cmpAutoBuildable?
Perhaps a more experienced programmer like @Angen or @elexis wants to shed their light on this?

Sun, Feb 9, 6:42 PM
Stan added a comment to D2492: Allow buildings to autobuild themselves.

I don't know, do you think it makes more sense? That means having to check for cmpFoundation and reversing the whole patch...

Sun, Feb 9, 4:37 PM
Freagarach added a comment to D2492: Allow buildings to autobuild themselves.

Shouldn't the StartTimer, StopTimer and AutoBuild (called PerformAutoBuild perhaps) be in the AutoBuilder component now?

Sun, Feb 9, 4:23 PM
Vulcan added a comment to D2492: Allow buildings to autobuild themselves.

Successful build - Chance fights ever on the side of the prudent.

Sun, Feb 9, 4:17 PM
Stan updated the diff for D2492: Allow buildings to autobuild themselves.

Remove useless template change.

Sun, Feb 9, 4:13 PM
Vulcan added a comment to D2492: Allow buildings to autobuild themselves.

Successful build - Chance fights ever on the side of the prudent.

Sun, Feb 9, 4:09 PM
Stan updated the diff for D2492: Allow buildings to autobuild themselves.

Fix !!check

Sun, Feb 9, 4:01 PM
Vulcan added a comment to D2492: Allow buildings to autobuild themselves.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Feb 9, 3:49 PM
Vulcan added a comment to D2492: Allow buildings to autobuild themselves.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Feb 9, 3:48 PM
Harbormaster failed remote builds in B11085: Diff 11308 for D2492: Allow buildings to autobuild themselves!
Sun, Feb 9, 3:47 PM
Vulcan added a comment to D2492: Allow buildings to autobuild themselves.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Feb 9, 3:47 PM
Stan updated the diff for D2492: Allow buildings to autobuild themselves.

Adapt test.

Sun, Feb 9, 3:42 PM
elexis added a comment to D1703: Map browser for gamesetup.
In D1703#110031, @nani wrote:
  • The missing scrolling is really bad. I didnt check your JS scrolling implementation, but a slider might also work as a workaround.

What scrolling implementation?

None.

Sun, Feb 9, 3:27 PM
Harbormaster failed to build B11084: rP23488: Replace Wrong visual actor being used in mace_siege_oxybeles_packed.xml for rP23488: Replace Wrong visual actor being used in mace_siege_oxybeles_packed.xml!
Sun, Feb 9, 3:22 PM
Vulcan added a comment to D2058: FixedVector2D CompareLengthSquared.

Successful build - Chance fights ever on the side of the prudent.

Sun, Feb 9, 3:17 PM
Alexandermb committed rP23488: Replace Wrong visual actor being used in mace_siege_oxybeles_packed.xml.
Replace Wrong visual actor being used in mace_siege_oxybeles_packed.xml
Sun, Feb 9, 3:15 PM
Gallaecio accepted D2620: use non-breaking space in 0 A.D..
Sun, Feb 9, 3:09 PM
nani added a comment to D1703: Map browser for gamesetup.
  • The missing scrolling is really bad. I didnt check your JS scrolling implementation, but a slider might also work as a workaround.

What scrolling implementation?

  • The code doesnt work as intended for clients (that aren't the host) unless I missed something reading the code

As the map browser was previously a different page the only host vs client check was on the callback handle in game setup page. Now the check should be on the the map browser code itself.

Sun, Feb 9, 3:09 PM
Gallaecio updated subscribers of D2620: use non-breaking space in 0 A.D..

@elexis Can we disable the “nonbsp” check in Vulcan? I don’t think it applies to us. I think the only non-UTF-8 part we have was the editor or some parts of it, and this check seems to be for JavaScript files.

Sun, Feb 9, 3:07 PM
Gallaecio accepted D2610: standardize bonus attack tooltips.
Sun, Feb 9, 3:03 PM
Harbormaster failed remote builds in B11083: Diff 11307 for D2058: FixedVector2D CompareLengthSquared!
Sun, Feb 9, 2:54 PM
Vulcan added a comment to D2058: FixedVector2D CompareLengthSquared.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Feb 9, 2:54 PM
elexis updated the diff for D2058: FixedVector2D CompareLengthSquared.

Ditch Fixed as an arugment and implement FIXED_SQUARE_I32 macro

Sun, Feb 9, 2:47 PM
elexis added a comment to D1703: Map browser for gamesetup.
  • TODO: If currently selected map is not part of this list, remove the selected index
  • The missing scrolling is really bad. I didnt check your JS scrolling implementation, but a slider might also work as a workaround.
  • The code doesnt work as intended for clients (that aren't the host) unless I missed something reading the code
Sun, Feb 9, 1:58 PM
Vulcan added a comment to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..

Successful build - Chance fights ever on the side of the prudent.

Sun, Feb 9, 1:57 PM
Freagarach updated the diff for D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..

Do not use 0 as default for multiplication.

Sun, Feb 9, 1:52 PM
Vulcan added a comment to D2492: Allow buildings to autobuild themselves.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Feb 9, 1:16 PM
Vulcan added a comment to D2492: Allow buildings to autobuild themselves.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Feb 9, 1:15 PM
Harbormaster failed remote builds in B11081: Diff 11305 for D2492: Allow buildings to autobuild themselves!
Sun, Feb 9, 1:14 PM
Vulcan added a comment to D2492: Allow buildings to autobuild themselves.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Feb 9, 1:14 PM
Stan updated the diff for D2492: Allow buildings to autobuild themselves.

Rebase, move buildable to autobuildable.

Sun, Feb 9, 1:13 PM
Freagarach abandoned D2381: Allow entities to retain order queue when (un)garrisoning..

I added a workaround in the mining diff (adding a gather order after ungarrisoning, just like with the AlertRaiser), but tried to make it more generic here. (Because for me it sounded logical that giving an entity on a wall an order to move somewhere and then ungarrisoning it would make the unit move to the somewhere.)

Sun, Feb 9, 12:44 PM
Vulcan added a comment to D2628: [gameplay] tweak champion infantry javelinist walk speed.

Successful build - Chance fights ever on the side of the prudent.

Sun, Feb 9, 10:32 AM
Nescio created D2628: [gameplay] tweak champion infantry javelinist walk speed.
Sun, Feb 9, 10:26 AM
Nescio added a comment to D2595: separate elephant archer from cavalry templates.

@ValihrAnt @borg- thoughts on elephant speed change?

(A difference of 2.5%, i.e. 9.0 instead of 8.8.)

Sun, Feb 9, 9:47 AM
Nescio added a comment to D2623: [gui]: increase label space in chat.

The size property of GUI objects can be changed to the value return by GetTextWidth, there is an example in termsdialog.js, or search for Engine.GetTextWidth. (I suppose it'd be better as a C++ snapping or alignment feature.)

Whilst I agree having the code automatically determine the correct space for translated texts, I believe implementing that is beyond my abilities. This patch may not be a perfect solution, but at least it's an improvement for most languages, and could help as a semi-temporary adjustment until someone else writes code to properly align things.

Sun, Feb 9, 9:44 AM
Angen updated subscribers of D2595: separate elephant archer from cavalry templates.

@ValihrAnt @borg- thoughts on elephant speed change?

Sun, Feb 9, 9:43 AM
Nescio added inline comments to D2595: separate elephant archer from cavalry templates.
Sun, Feb 9, 9:37 AM
Nescio added inline comments to D2595: separate elephant archer from cavalry templates.
Sun, Feb 9, 9:35 AM
Angen added inline comments to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..
Sun, Feb 9, 9:27 AM
Vulcan added a comment to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..

Successful build - Chance fights ever on the side of the prudent.

Sun, Feb 9, 8:07 AM
Freagarach updated the diff for D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..
  • i++.
  • No 1000 interval per se.
  • Allow people to start with 0 modification and increase it afterwards.
Sun, Feb 9, 7:54 AM
Freagarach added inline comments to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..
Sun, Feb 9, 7:54 AM

Sat, Feb 8

irishninja updated the diff for D2199: Add RPC interface for Reinforcement Learning.

Added --with-rlinterface to the script for building libraries on OSX (only built fiber if flag exists). Removed a condition which is always false (checking if on windows with the --with-rlinterface flag since it throws an unsupported error message earlier if so).

Sat, Feb 8, 6:55 PM
Vulcan added a comment to D2460: Implement placeholder text for input fields and get rid of hack with mod filter.

Successful build - Chance fights ever on the side of the prudent.

Sat, Feb 8, 5:38 PM
Stan added a comment to D2492: Allow buildings to autobuild themselves.

I'm open to suggestions on how to make it work with foundations.

Sat, Feb 8, 5:36 PM
Angen added a comment to D2492: Allow buildings to autobuild themselves.

before placing foundation or even in the gui when player clicks to structure to build, but i still do not like idea one need two components to be able to build something

Sat, Feb 8, 5:33 PM
Angen added a reviewer for D2460: Implement placeholder text for input fields and get rid of hack with mod filter: vladislavbelov.
Sat, Feb 8, 5:30 PM
Angen updated the diff for D2460: Implement placeholder text for input fields and get rid of hack with mod filter.

@vladislavbelov request

Sat, Feb 8, 5:28 PM
Stan added a comment to D2492: Allow buildings to autobuild themselves.
In D2492#109957, @Angen wrote:

If Defines whether the entity can be built is true, that needs to be in code, if it is not in the code, that description is false so needs to be removed.

Sat, Feb 8, 4:28 PM
elexis added a comment to D2623: [gui]: increase label space in chat.

The size property of GUI objects can be changed to the value return by GetTextWidth, there is an example in termsdialog.js, or search for Engine.GetTextWidth. (I suppose it'd be better as a C++ snapping or alignment feature.)

Sat, Feb 8, 3:54 PM
elexis added a comment to D1703: Map browser for gamesetup.
  • Item-Description: Should(n't) the map description be shown (maybe 3-5 lines + scrollbar) below the mappreview thumbnail, so that the player can make a more informed decision / comparison of maps? In fact the height of the description could vary, so that the unused vertical space would disappear as well (at the cost of perhaps one or two rows depending on zoom level)
  • Status-Bar: Should(n't) it display the "prev/next" + page counter data below the items in a status bar? (It could also display item count)
  • The mapbrwserpage button looks weird, we considered making this a regular button.
Sat, Feb 8, 3:03 PM
Angen requested changes to D2492: Allow buildings to autobuild themselves.

If Defines whether the entity can be built is true, that needs to be in code, if it is not in the code, that description is false so needs to be removed.

Sat, Feb 8, 2:47 PM
Angen updated the summary of D1940: UnitAI cleanup [GATHER].
Sat, Feb 8, 2:36 PM
elexis added a comment to D1703: Map browser for gamesetup.

New classes:

  • GridBrowser class (D1650) split from MapGridBrowser class to keep it more reusable.
  • GridBrowserItem and MapGridBrowserItem class, so that one may keep references, a local state, register events to handlers and specify functions per item (instead of only one function doing all of that locally).
Sat, Feb 8, 2:34 PM
Angen added inline comments to D2595: separate elephant archer from cavalry templates.
Sat, Feb 8, 2:27 PM
Angen added inline comments to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..
Sat, Feb 8, 1:39 PM
Vulcan added a comment to D2627: Report GUI object script handler error stack.

Successful build - Chance fights ever on the side of the prudent.

Sat, Feb 8, 12:21 AM
elexis created D2627: Report GUI object script handler error stack.
Sat, Feb 8, 12:14 AM

Fri, Feb 7

Vulcan added a comment to D2626: 3 → ȝ ; ‘ and ’ → ʿ.

Successful build - Chance fights ever on the side of the prudent.

Fri, Feb 7, 11:13 PM
Nescio created D2626: 3 → ȝ ; ‘ and ’ → ʿ.
Fri, Feb 7, 11:07 PM
Nescio updated subscribers of D2025: Technology specific names.

@Stan, interested in reviewing this one? It ought to be uncontroversial, just specific name strings.

Fri, Feb 7, 10:53 PM
Stan committed rP23487: Correct the contents of the kush_hero_harsiotef.xml template, which used to be….
Correct the contents of the kush_hero_harsiotef.xml template, which used to be…
Fri, Feb 7, 10:26 PM