There is "CNetMessage: Corrupt packet (incorrect size)" already.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Feb 10 2020
Successful build - Chance fights ever on the side of the prudent.
Also replace quotation marks with proper ayin.
That's sad the correct symbol does not exist in the game's font though... I assume there isn't much we can do about that...
There is nothing wrong with the yogh, it is used in many publications. U+A723 is relatively new. If one really wants it, one could consider adding another font that has the character (e.g. Charis SIL, DejaVu Serif, Doulos SIL, Gentium Plus, Liberation Serif) or let 0 A.D. use font files directly (e.g. with pango) rather than as rendered images. However, that's a lot of work and far beyond the scope of this patch.
Shouldn't it be done in UnitMotionFlying as well?
Successful build - Chance fights ever on the side of the prudent.
Fix typo.
Can't we have an explicit message about message being too big?
Successful build - Chance fights ever on the side of the prudent.
Feb 9 2020
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Use square distance instead.
In D2613#110077, @adrian wrote:I propose to merge this changes into codebase (I can restore old cppformat name) and create another ticket to update fmt to version 6.x. Unfortunately I'm not sure how much time I will have in the future, so I think better option is to not "lock" this issue further.
I agree, and actually I think it's very nice to use this small upgrade to rename the lib, so you can leave it like this.
Successful build - Chance fights ever on the side of the prudent.
Thanks a lot for the comments!
One abs less.
Build failure - The Moirai have given mortals hearts that can endure.
Make functions more specific.
That's sad the correct symbol does not exist in the game's font though... I assume there isn't much we can do about that...
Successful build - Chance fights ever on the side of the prudent.
More static cast, drop old tests, use macro more often, rename macro.
I know that is a significant change again, but why make it the responsibility of cmpFoundation to autobuild? To me at least, it seems more the responsibility of cmpAutoBuildable?
Perhaps a more experienced programmer like @Angen or @elexis wants to shed their light on this?
I don't know, do you think it makes more sense? That means having to check for cmpFoundation and reversing the whole patch...
Shouldn't the StartTimer, StopTimer and AutoBuild (called PerformAutoBuild perhaps) be in the AutoBuilder component now?
Successful build - Chance fights ever on the side of the prudent.
Remove useless template change.
Successful build - Chance fights ever on the side of the prudent.
Fix !!check
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Adapt test.
In D1703#110031, @nani wrote:In D1703#110019, @elexis wrote:
- The missing scrolling is really bad. I didnt check your JS scrolling implementation, but a slider might also work as a workaround.
What scrolling implementation?
None.
Successful build - Chance fights ever on the side of the prudent.
In D1703#110019, @elexis wrote:
- The missing scrolling is really bad. I didnt check your JS scrolling implementation, but a slider might also work as a workaround.
What scrolling implementation?
- The code doesnt work as intended for clients (that aren't the host) unless I missed something reading the code
As the map browser was previously a different page the only host vs client check was on the callback handle in game setup page. Now the check should be on the the map browser code itself.
@elexis Can we disable the “nonbsp” check in Vulcan? I don’t think it applies to us. I think the only non-UTF-8 part we have was the editor or some parts of it, and this check seems to be for JavaScript files.
Build failure - The Moirai have given mortals hearts that can endure.
Ditch Fixed as an arugment and implement FIXED_SQUARE_I32 macro
- TODO: If currently selected map is not part of this list, remove the selected index
- The missing scrolling is really bad. I didnt check your JS scrolling implementation, but a slider might also work as a workaround.
- The code doesnt work as intended for clients (that aren't the host) unless I missed something reading the code
Successful build - Chance fights ever on the side of the prudent.
Do not use 0 as default for multiplication.
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Rebase, move buildable to autobuildable.
I added a workaround in the mining diff (adding a gather order after ungarrisoning, just like with the AlertRaiser), but tried to make it more generic here. (Because for me it sounded logical that giving an entity on a wall an order to move somewhere and then ungarrisoning it would make the unit move to the somewhere.)
Successful build - Chance fights ever on the side of the prudent.
@ValihrAnt @borg- thoughts on elephant speed change?
(A difference of 2.5%, i.e. 9.0 instead of 8.8.)
The size property of GUI objects can be changed to the value return by GetTextWidth, there is an example in termsdialog.js, or search for Engine.GetTextWidth. (I suppose it'd be better as a C++ snapping or alignment feature.)
Whilst I agree having the code automatically determine the correct space for translated texts, I believe implementing that is beyond my abilities. This patch may not be a perfect solution, but at least it's an improvement for most languages, and could help as a semi-temporary adjustment until someone else writes code to properly align things.
@ValihrAnt @borg- thoughts on elephant speed change?
Successful build - Chance fights ever on the side of the prudent.
- i++.
- No 1000 interval per se.
- Allow people to start with 0 modification and increase it afterwards.
Feb 8 2020
Added --with-rlinterface to the script for building libraries on OSX (only built fiber if flag exists). Removed a condition which is always false (checking if on windows with the --with-rlinterface flag since it throws an unsupported error message earlier if so).
Successful build - Chance fights ever on the side of the prudent.
I'm open to suggestions on how to make it work with foundations.
before placing foundation or even in the gui when player clicks to structure to build, but i still do not like idea one need two components to be able to build something
@vladislavbelov request
In D2492#109957, @Angen wrote:If Defines whether the entity can be built is true, that needs to be in code, if it is not in the code, that description is false so needs to be removed.
The size property of GUI objects can be changed to the value return by GetTextWidth, there is an example in termsdialog.js, or search for Engine.GetTextWidth. (I suppose it'd be better as a C++ snapping or alignment feature.)
- Item-Description: Should(n't) the map description be shown (maybe 3-5 lines + scrollbar) below the mappreview thumbnail, so that the player can make a more informed decision / comparison of maps? In fact the height of the description could vary, so that the unused vertical space would disappear as well (at the cost of perhaps one or two rows depending on zoom level)
- Status-Bar: Should(n't) it display the "prev/next" + page counter data below the items in a status bar? (It could also display item count)
- The mapbrwserpage button looks weird, we considered making this a regular button.
If Defines whether the entity can be built is true, that needs to be in code, if it is not in the code, that description is false so needs to be removed.
New classes:
- GridBrowser class (D1650) split from MapGridBrowser class to keep it more reusable.
- GridBrowserItem and MapGridBrowserItem class, so that one may keep references, a local state, register events to handlers and specify functions per item (instead of only one function doing all of that locally).
Successful build - Chance fights ever on the side of the prudent.
Feb 7 2020
Successful build - Chance fights ever on the side of the prudent.
@Stan, interested in reviewing this one? It ought to be uncontroversial, just specific name strings.