Page MenuHomeWildfire Games
Feed All Stories

May 21 2020

Freagarach accepted rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….

All entities are now considered, which is an improvement and enough to lift my concern :)

May 21 2020, 3:41 PM
bb added a comment to D2662: Gather using ResourceGatherer instead of UnitAI..

The design I have in mind is the following:
UnitAI chooses "cleverly" what the unit is doing, other components perform the tasks.
UnitAI should be allowed to let several components perform different tasks (i.e. unitAI could allow a unit to attack and walk at the same moment).
UnitAI can be replaced by BuildingAI, turretAI and whatnot, but all those should be able to access the same "other components" and let them perform the tasks (otherAI components just choose differently what tasks are done)

May 21 2020, 3:27 PM
wraitii requested changes to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..

I think we have to accept the limited flexibility of tooltips for now. It's not like we support switching to a vertical writing system either, so I don't think we really need to think tooooo hard about ordering optional elements.
Fixing that would simply require a stronger translation system which we don't have right now.

May 21 2020, 3:19 PM
Silier added inline comments to D2111: [PetraAI] - Do not try to attack entities which can't be attacked..
May 21 2020, 3:18 PM
wraitii added a comment to rP23680: Fix EntitiesNearPoint range query.

So now trees *are* considered?

May 21 2020, 3:04 PM
Freagarach added a comment to D2738: Fix EntitiesNearPoint range query..

Are you referring to this concern: https://code.wildfiregames.com/rP22754#inline-3977 ?

https://code.wildfiregames.com/rP23680#42314 I guess?

May 21 2020, 2:59 PM
wraitii added a comment to D2738: Fix EntitiesNearPoint range query..

Thanks for giving this another look ?

May 21 2020, 2:56 PM
bb added a comment to D2425: Show number of builders besides (not in space) build time..

There are 3 types of information: number of builders, time remaining and speedup by extra worker. Currently the time remaining is on the front page, and the other two in the tooltip. IMO if we add the number of buildings to the front page, we should show all 3 in the tooltip (why would 1 piece of information be in 2 places otherwise?)

May 21 2020, 2:37 PM
wraitii requested changes to D2662: Gather using ResourceGatherer instead of UnitAI..

I like the idea of trying to make unitAI easier to reason about, and thanks for even trying this out :)
That being said, my initial reaction was "no, this isn' t it".
Then I wrote this review saying why, and now... Now I'm less sure. I think you do need to rework some of this, and I'd remove the timer & message thing from there for sure, at least for now.

May 21 2020, 2:36 PM
Palaxin added a comment to D2739: delete golden fleece.

I think this kind of stuff is something for cheats...

May 21 2020, 2:30 PM
Palaxin added a comment to D2721: improve animal footprints.

Great to see my work from #3786 continued :)

May 21 2020, 2:25 PM
Freagarach accepted D2748: Do not compute capture points for the invalid player on player defeat.

We don't really care about the CP of dead entities anyway (see L323). (Code introduced in rP21685.)
What is changed now is that there is no message sent that capture points have changed.

May 21 2020, 1:56 PM
Silier accepted rP21901: Display lobby TLS certificate verification errors from gloox, refs #4705..

Typo fixed in rP23685

May 21 2020, 12:58 PM
Silier added a comment to D2738: Fix EntitiesNearPoint range query..

Further, the previous code had a bug: GAIA entities would be returned twice. See tests.

May 21 2020, 12:54 PM
wraitii created D2754: Fix a rare case of units getting stuck.
May 21 2020, 12:47 PM
Freagarach added a comment to D2177: Allow to set the max selection size in user.cfg..

If the idea of the patch is to increase the nr 200 to a greater number, then the idea of the patch is correct, but it's time hasn't come yet if selecting many units is so slow that it delays the game (turn length time just for the selection).

Yeah I understand :) The idea of the patch was to make it a user choice, thus the idea is wrong, as you noticed :)

May 21 2020, 12:22 PM
elexis added a comment to D2177: Allow to set the max selection size in user.cfg..

If the idea of the patch is to increase the nr 200 to a greater number, then the idea of the patch is correct, but it's time hasn't come yet if selecting many units is so slow that it delays the game (turn length time just for the selection).

May 21 2020, 12:18 PM
elexis requested verification of rP21901: Display lobby TLS certificate verification errors from gloox, refs #4705..
May 21 2020, 12:15 PM
elexis committed rP23685: Fix typo (certifiacte -> certificate) imported from gloox in rP21901, reported….
Fix typo (certifiacte -> certificate) imported from gloox in rP21901, reported…
May 21 2020, 12:15 PM
elexis added inline comments to rP21901: Display lobby TLS certificate verification errors from gloox, refs #4705..
May 21 2020, 12:14 PM
Freagarach added a comment to D2329: Allow mods to insert or delete individual resource icons without hardcoding all resources at a time.

Anything holding this back? It looks good and still applies cleanly :)

May 21 2020, 11:37 AM
Freagarach added a comment to rP23680: Fix EntitiesNearPoint range query.

So now trees *are* considered?

May 21 2020, 11:16 AM
Freagarach added inline comments to D1958: Turrets and/or sub-units..
May 21 2020, 11:10 AM
wraitii updated the diff for D2746: Correctly serialize/deserialize user-defined JS objects..

Do the TODOs from the above comments.

May 21 2020, 10:59 AM
Freagarach added inline comments to D2111: [PetraAI] - Do not try to attack entities which can't be attacked..
May 21 2020, 10:58 AM
Freagarach updated the diff for D2111: [PetraAI] - Do not try to attack entities which can't be attacked..
  • Check whether we are allowed to capture.
  • Other inline by @Angen.
May 21 2020, 10:58 AM
Stan added inline comments to rP23684: Add help comments to WallPiece component schema .
May 21 2020, 10:56 AM
Nescio updated the Trac tickets for D2745: #5709 fcollada build fix for gcc 10 (WritePhysicsRigidBodyInstance) by @pcpa..
May 21 2020, 10:29 AM
Nescio updated subscribers of D2745: #5709 fcollada build fix for gcc 10 (WritePhysicsRigidBodyInstance) by @pcpa..

Thank you, @wraitii! I (gcc-10.1.1-1.fc32.x86_64) have just tried out your updated patch:

svn revert -R *
svn up
arc patch D2745
cd build/workspaces/
./update-workspaces.sh -j7
cd gcc
make -j7

and can confirm everything builds; the errors mentioned in https://wildfiregames.com/forum/index.php?/topic/28175-unable-to-build-0ad/ have all gone.
Afterwards I did the tests, no problems there:

[0ad]$ binaries/system/test
Running cxxtest tests (336 tests)................................................................................................................................................................................................................................................................................................................................................OK!
[0ad]$ binaries/system/pyrogenesis
May 21 2020, 10:23 AM
Freagarach abandoned D2177: Allow to set the max selection size in user.cfg..

Valid points ^^

May 21 2020, 10:13 AM
Freagarach requested review of D2702: Fix formations not queueing orders properly..
May 21 2020, 10:04 AM
Freagarach updated the diff for D1958: Turrets and/or sub-units..
  • Rebased.
  • Use TryMatchTargetSpeed from rP23682.
  • Follow at an explicit range.
May 21 2020, 10:00 AM
Nescio added inline comments to rP23684: Add help comments to WallPiece component schema .
May 21 2020, 9:54 AM
Nescio added a comment to rP23684: Add help comments to WallPiece component schema .

Thanks, I appreciate this!

May 21 2020, 9:48 AM
Nescio removed a reviewer for D2745: #5709 fcollada build fix for gcc 10 (WritePhysicsRigidBodyInstance) by @pcpa.: Nescio.
May 21 2020, 9:42 AM
Vulcan added a comment to D2746: Correctly serialize/deserialize user-defined JS objects..

Build failure - The Moirai have given mortals hearts that can endure.

May 21 2020, 8:43 AM
Vulcan added a comment to D2746: Correctly serialize/deserialize user-defined JS objects..

Build failure - The Moirai have given mortals hearts that can endure.

May 21 2020, 8:39 AM
Harbormaster failed remote builds in B11751: Diff 11947 for D2746: Correctly serialize/deserialize user-defined JS objects.!
May 21 2020, 8:39 AM
Vulcan added a comment to D2746: Correctly serialize/deserialize user-defined JS objects..

Build failure - The Moirai have given mortals hearts that can endure.

May 21 2020, 8:39 AM
Freagarach added a comment to D1977: Cheer after no enemy entities left in range.

Entities in a 1 vs. 1 won't cheer, because they're not in the IDLE state when the order to cheer is issued, thus discarding that order.

May 21 2020, 8:37 AM
wraitii updated the diff for D2746: Correctly serialize/deserialize user-defined JS objects..

Updated version. This lets us support Serialize/Deserialize (as in components) on any user-defined JS object (including, of course, components).

May 21 2020, 8:29 AM
Freagarach added a comment to D2425: Show number of builders besides (not in space) build time..

The tooltip also states how much you speed up construction when adding another builder, so it *does* show two things?

May 21 2020, 8:04 AM
Freagarach added a comment to D2731: Create function to match a target's speed..

Thanks for the review and commit @bb :)

May 21 2020, 8:01 AM
s0600204 committed rP23684: Add help comments to WallPiece component schema .
Add help comments to WallPiece component schema
May 21 2020, 6:34 AM
elexis added a comment to D2750: Hide "Control all units" checkbox in observer mode.
  • Engine.GetPlayerID() can change during the course of the game using the developer overlay "change player" option.
  • Other hypothetical enabled properties could change arbitrarily.
May 21 2020, 1:26 AM

May 20 2020

bb committed rP23683: Invert a case in rP23682.
Invert a case in rP23682
May 20 2020, 9:47 PM
bb added inline comments to D2731: Create function to match a target's speed..
May 20 2020, 9:47 PM
bb committed rP23682: Create unitAI function to match a target's speed..
Create unitAI function to match a target's speed.
May 20 2020, 9:39 PM
bb closed D2731: Create function to match a target's speed..
May 20 2020, 9:39 PM
bb added inline comments to D2731: Create function to match a target's speed..
May 20 2020, 9:37 PM
bb accepted D2731: Create function to match a target's speed..

Note that valuemodifications are equally broken.

May 20 2020, 9:36 PM
bb added a comment to D2425: Show number of builders besides (not in space) build time..

There was a bunch of discussion how to display it on the front page. Displaying both was proposed there too, and that seems a sane solution to me too. However to me it sounds odd to display 2 values on the front page and only 1 in the tooltip (the time left is not displayed), I rather have both in the tooltip then.

May 20 2020, 9:27 PM
Vulcan added a comment to D2745: #5709 fcollada build fix for gcc 10 (WritePhysicsRigidBodyInstance) by @pcpa..

Successful build - Chance fights ever on the side of the prudent.

May 20 2020, 8:31 PM
elexis removed 1 auditor(s) for rP22527: Easier introduction of new damage types.: elexis.
May 20 2020, 8:31 PM
wraitii abandoned D2749: Fix missing template instantiation in hierarchical pathfinder tests.

Merged inside D2745

May 20 2020, 8:24 PM
wraitii updated the diff for D2745: #5709 fcollada build fix for gcc 10 (WritePhysicsRigidBodyInstance) by @pcpa..

Incorporate D2749

May 20 2020, 8:23 PM
wraitii commandeered D2745: #5709 fcollada build fix for gcc 10 (WritePhysicsRigidBodyInstance) by @pcpa..
May 20 2020, 8:23 PM
Vulcan added a comment to D1977: Cheer after no enemy entities left in range.

Successful build - Chance fights ever on the side of the prudent.

May 20 2020, 8:15 PM
wraitii requested verification of rP22527: Easier introduction of new damage types..
May 20 2020, 8:10 PM
Vulcan added a comment to D1977: Cheer after no enemy entities left in range.

Successful build - Chance fights ever on the side of the prudent.

May 20 2020, 8:10 PM
Silier updated the diff for D1977: Cheer after no enemy entities left in range.

actually save file after renaming function

May 20 2020, 8:09 PM
Silier updated the diff for D1977: Cheer after no enemy entities left in range.

rebase and rename function

May 20 2020, 8:06 PM
elexis removed 1 auditor(s) for rP23012: Fix bonus multiplier issue in rP22754 (multiple attack effects) and consider…: elexis.
May 20 2020, 7:48 PM
Vulcan added a comment to D2707: Remove some variables from serialisation and update this.animations name to reflect what it actually holds [Formations.js].

Successful build - Chance fights ever on the side of the prudent.

May 20 2020, 7:39 PM
Silier updated the diff for D2707: Remove some variables from serialisation and update this.animations name to reflect what it actually holds [Formations.js].

move variablesToSerialize to prototype to avoid global as we do not like globals, locale variable as it would be recreated by every serialisation call and declaration in Init as it would be recreated for every entity.

May 20 2020, 7:34 PM
wraitii committed rP23681: Internationalise Damage Types and Status Effects using (optional) JSON files..
Internationalise Damage Types and Status Effects using (optional) JSON files.
May 20 2020, 7:27 PM
wraitii closed D2337: Internationalise Damage Types and Status Effects using (optional) JSON files..
May 20 2020, 7:26 PM
Dunedan added a comment to D2747: Make password hashing case-insensitive to comply with jabberd specification..

If it needs to be a breaking change anyway, why not to remove the whole logic for generating the actual password by hashing the username and password and instead just using the password as password? Wouldn't this result in the same logic as other XMPP clients use as well?

May 20 2020, 7:25 PM
wraitii requested verification of rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
May 20 2020, 7:08 PM
wraitii requested verification of rP23012: Fix bonus multiplier issue in rP22754 (multiple attack effects) and consider….
May 20 2020, 7:08 PM
wraitii committed rP23680: Fix EntitiesNearPoint range query.
Fix EntitiesNearPoint range query
May 20 2020, 7:04 PM
wraitii closed D2738: Fix EntitiesNearPoint range query..
May 20 2020, 7:03 PM
Vulcan added a comment to D2753: Look for foundations near the target.

Successful build - Chance fights ever on the side of the prudent.

May 20 2020, 7:00 PM
wraitii created D2753: Look for foundations near the target.
May 20 2020, 6:54 PM
wraitii added inline comments to D2735: Trigger an exit-reentry when the target entity of an order is renamed.
May 20 2020, 6:53 PM
Silier accepted rP23179: Amphitheater name fix, Gladiator commit and amphitheater integration, Maurya….

Missing dot fixed in rP23679.

May 20 2020, 6:52 PM
Silier committed rP23679: Add missing .(dot) in tooltip in maur_defense_tower.xml.
Add missing .(dot) in tooltip in maur_defense_tower.xml
May 20 2020, 6:51 PM
Vulcan added a comment to D2735: Trigger an exit-reentry when the target entity of an order is renamed.

Successful build - Chance fights ever on the side of the prudent.

May 20 2020, 6:45 PM
wraitii updated the diff for D2735: Trigger an exit-reentry when the target entity of an order is renamed.

This was a bit trickier than I thought.

May 20 2020, 6:41 PM
Freagarach planned changes to D2680: Heal using Heal.js instead of UnitAI..

Wait for learnings from D2662. (Oh and probably declassify, ought to be done separately if still desired.)

May 20 2020, 6:40 PM
OptimusShepard added a comment to D2726: AMD Ryzen fix.

I have tested with different setups.

May 20 2020, 6:40 PM
Vulcan added a comment to D2425: Show number of builders besides (not in space) build time..

Successful build - Chance fights ever on the side of the prudent.

May 20 2020, 6:06 PM
Freagarach added a comment to D2425: Show number of builders besides (not in space) build time..

As for the front page/tooltip thing, I thing there was quite a discussion about that and thus both would be not bad? Better yet obviously is user choice, shall I make this a config option?

May 20 2020, 6:05 PM
Freagarach updated the diff for D2425: Show number of builders besides (not in space) build time..

Swap position.

May 20 2020, 6:02 PM
Freagarach added a comment to D818: Reset attack timer if repeat time has changed (Cleopatra aura bug).

rP23678 can probably be used to fix this?

May 20 2020, 5:20 PM
Vulcan added a comment to D2731: Create function to match a target's speed..

Successful build - Chance fights ever on the side of the prudent.

May 20 2020, 5:08 PM
Freagarach updated the diff for D2731: Create function to match a target's speed..
  • Don't check for 0 speed (`Math.min(1/0, 1) == 1).
  • Set SpeedMultiplier also when it would be set to 1 (don't assume people reset it).
May 20 2020, 5:02 PM
Vulcan added a comment to D2731: Create function to match a target's speed..

Successful build - Chance fights ever on the side of the prudent.

May 20 2020, 4:57 PM
bb added inline comments to D2731: Create function to match a target's speed..
May 20 2020, 4:51 PM
Freagarach added a comment to D2666: Allow to update repeat time of running timer..

Thanks for the review and commit @bb!

May 20 2020, 4:51 PM
Freagarach updated the diff for D2731: Create function to match a target's speed..
  • Oneline new speed.
  • Protect against /0.
May 20 2020, 4:49 PM
Freagarach added inline comments to D2731: Create function to match a target's speed..
May 20 2020, 4:42 PM
Freagarach added a comment to D2750: Hide "Control all units" checkbox in observer mode.

First off, thank you for the patch! Don't hesitate to drop by on IRC if you have any questions.

May 20 2020, 4:37 PM
Stan requested changes to D2745: #5709 fcollada build fix for gcc 10 (WritePhysicsRigidBodyInstance) by @pcpa..

I believe another instance of the FArchiveXML.h file should be updated. Requesting changes so it's not forgotten.

May 20 2020, 2:54 PM
elexis added inline comments to rP21901: Display lobby TLS certificate verification errors from gloox, refs #4705..
May 20 2020, 2:41 PM
Silier raised a concern with rP21901: Display lobby TLS certificate verification errors from gloox, refs #4705..
May 20 2020, 1:52 PM
Silier raised a concern with rP23179: Amphitheater name fix, Gladiator commit and amphitheater integration, Maurya….
May 20 2020, 1:40 PM
wraitii updated the summary of D2752: Do not thread the game in Atlas.
May 20 2020, 8:54 AM
wraitii updated the summary of D2752: Do not thread the game in Atlas.
May 20 2020, 8:46 AM
wraitii updated subscribers of D2752: Do not thread the game in Atlas.

Edit: the below fixed by wik at https://wildfiregames.com/forum/index.php?/topic/28183-trunk23664-cant-open-atlas-editor-on-osx-catalina-10154/&tab=comments#comment-396649
somewhat. It's fixable anyways.

May 20 2020, 8:44 AM