Page MenuHomeWildfire Games
Feed All Stories

Fri, May 22

wraitii created D2759: Update range queries to account for entity size.
Fri, May 22, 1:03 PM
Stan added a comment to D2503: reorganize selection textures.

Those to be deleted files are used by delenda est and probably some other mods using auras. Will need an extra pr.
I guess i should write a regex for the change to make it easier for other mods.

Fri, May 22, 12:58 PM
Vulcan added a comment to D2758: Do not send Attacked message on entities that have no attack effects receiver.

Successful build - Chance fights ever on the side of the prudent.

Fri, May 22, 12:56 PM
wraitii created D2758: Do not send Attacked message on entities that have no attack effects receiver.
Fri, May 22, 12:52 PM
elexis added a comment to D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

(So still thanks and no objections for this iteration of this patch, just some thoughts and observations and this batch of inline comments may be ignored, and the one with parentheses even more so than the others)

Fri, May 22, 12:49 PM
Vulcan added a comment to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..

Successful build - Chance fights ever on the side of the prudent.

Fri, May 22, 12:30 PM
Freagarach updated the diff for D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..
  • for ... in in test.
Fri, May 22, 12:25 PM
Vulcan added a comment to D2757: i18n scripts - switch from pology to Babel for .POT generation and update to python3.

Successful build - Chance fights ever on the side of the prudent.

Fri, May 22, 12:23 PM
wraitii updated the summary of D2757: i18n scripts - switch from pology to Babel for .POT generation and update to python3.
Fri, May 22, 12:17 PM
wraitii created D2757: i18n scripts - switch from pology to Babel for .POT generation and update to python3.
Fri, May 22, 12:17 PM
Nescio added a comment to D2745: #5709 fcollada build fix for gcc 10 (WritePhysicsRigidBodyInstance) by @pcpa..

@elexis, could you test this to see if it solves your clang 10 errors?

Fri, May 22, 11:46 AM
Nescio added a comment to rP23687: Correct WallPiece schema help comments.

Thanks, these units make more sense! A few more questions, though:

  • <Orientation> of -1, 1, 3, etc. give the same result, right? Or are only values between 0 and 2 allowed?
  • Wouldn't it be better to normalize the <Orientation>, i.e. 1 is a full circle (360°) and 0.25 a quarter (90°).
  • Just to be clear, what do you mean with z-axis? In Blender z is the vertical position, but not in the simulation templates:
    • in the <GarrisonHolder/VisibleGarrisonPoints/*> node, <X> is the left-right position, <Y> the up-down position, <Z> the front-back position;
    • likewise, in the <Obstruction/Obstructions/*> node, x means the width offset and z the depth offset;
    • consistency matters, so looking at wall templates only, one would expect <Length> to be the x-length and <Indent> the z-offset.
  • Do orientation and bend operate in the same plane?
Fri, May 22, 11:40 AM
elexis requested changes to D2715: Fail test suite when map tests throw errors.

According to Stans test, on windows terminal, simulation tests show the filepath of the error, but not the JS exception thrown - unless using a debugger;
and with this patch it will not show the JS stack nor the JS filename of a failed rmgen test;
therefore it needs to show the filepath in a failed error message as with simulation tests
(if we want to support rmgen test development on windows without debugger).

Fri, May 22, 11:31 AM
Nescio added a comment to D2503: reorganize selection textures.
Unused file 'public/art/textures/selection/128x128/rectangle.png'
Unused file 'public/art/textures/selection/128x128/rectangle_mask.png'
Unused file 'public/art/textures/selection/128x128/rhombus.png'
Unused file 'public/art/textures/selection/128x128/rhombus_mask.png'
Unused file 'public/art/textures/selection/128x128/rounded_rectangle.png'
Unused file 'public/art/textures/selection/128x128/rounded_rectangle_mask.png'
Unused file 'public/art/textures/selection/128x256/rectangle.png'
Unused file 'public/art/textures/selection/128x256/rectangle_mask.png'
Unused file 'public/art/textures/selection/128x512/cartouche.png'
Unused file 'public/art/textures/selection/128x512/cartouche_mask.png'
Unused file 'public/art/textures/selection/128x512/rectangle.png'
Unused file 'public/art/textures/selection/128x512/rectangle_mask.png'
Unused file 'public/art/textures/selection/256x256/octagram.png'
Unused file 'public/art/textures/selection/256x256/octagram_mask.png'
Unused file 'public/art/textures/selection/256x256/plus.png'
Unused file 'public/art/textures/selection/256x256/plus_mask.png'
Unused file 'public/art/textures/selection/256x256/rectangle.png'
Unused file 'public/art/textures/selection/256x256/rectangle_mask.png'
Unused file 'public/art/textures/selection/256x256/rhombus.png'
Unused file 'public/art/textures/selection/256x256/rhombus_mask.png'

These are intended, yes, because these shapes are used in different sizes; e.g. 256x256/plus is unused, but the healer uses the 128x128 plus. These pngs are very cheap (only a few kb each) and if at some point someone wants to use an existing shape in a different size, it's best they are already there, to save time and prevent introducing inconsistencies.
Although none of the rectangle sizes is used (the rounded_rectangle is), I think it's best to keep them nonetheless, for testing etc., because they're the closest approximation of a unit's actual footprint.

Unused file 'public/art/textures/selection/auras/test/1024x1024_aura.png'
Unused file 'public/art/textures/selection/auras/test/1024x1024_aura_mask.png'
Unused file 'public/art/textures/selection/star/1024x1024_aura.png'
Unused file 'public/art/textures/selection/star/1024x1024_aura_mask.png'

These are to be deleted. However, they're sufficiently different, so you might want to move them into an old art repository, which is why I didn't remove them in this patch.

Also why is there still a star folder?

It's better to delete the obsolete folders (arrow, circle, etc.) only after they're emptied, to be safe, because it's possible patches are implemented in a different order than expected.
When this patch is committed, I'll update D2696 to delete the then empty folders (and those 1024x1024_aura* files).

Fri, May 22, 11:23 AM
Vulcan added a comment to D11: Implement Single-Player (SP) campaign interface.

Successful build - Chance fights ever on the side of the prudent.

Fri, May 22, 10:25 AM
Vulcan added a comment to D11: Implement Single-Player (SP) campaign interface.

Successful build - Chance fights ever on the side of the prudent.

Fri, May 22, 10:16 AM
wraitii updated the diff for D11: Implement Single-Player (SP) campaign interface.

Add the missing .tx file.

Fri, May 22, 10:13 AM
wraitii added inline comments to D11: Implement Single-Player (SP) campaign interface.
Fri, May 22, 10:04 AM
wraitii updated the summary of D11: Implement Single-Player (SP) campaign interface.
Fri, May 22, 10:02 AM
wraitii added inline comments to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..
Fri, May 22, 9:58 AM
Harbormaster failed remote builds in B11771: Diff 11967 for D11: Implement Single-Player (SP) campaign interface!
Fri, May 22, 9:58 AM
Vulcan added a comment to D11: Implement Single-Player (SP) campaign interface.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, May 22, 9:58 AM
wraitii updated the diff for D11: Implement Single-Player (SP) campaign interface.

Update with:

  • i18n support
  • Triggers can define a custom "OnCampaignGameEnd" trigger that processes custom user data
  • Moving some files around to clean up the interface.
Fri, May 22, 9:56 AM
Vulcan added a comment to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..

Successful build - Chance fights ever on the side of the prudent.

Fri, May 22, 9:52 AM
Harbormaster failed remote builds in B11770: Diff 11966 for D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades.!
Fri, May 22, 9:49 AM
Vulcan added a comment to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..

Build failure - The Moirai have given mortals hearts that can endure.

Fri, May 22, 9:48 AM
Freagarach added inline comments to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..
Fri, May 22, 9:46 AM
Freagarach updated the diff for D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..
  • Rebased.
  • Split StatusEffects stuff in Attacking.js.
  • Simplified translations in tooltips.js.
  • Simplified test.
Fri, May 22, 9:46 AM
Stan added a comment to D2503: reorganize selection textures.

I found these currently unused files

Fri, May 22, 9:37 AM
autobuild committed rP23689: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Fri, May 22, 9:29 AM
Stan added inline comments to D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.
Fri, May 22, 9:28 AM
Angen added a comment to D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

Hi, nice work :)

Fri, May 22, 8:45 AM
autobuild committed rP23688: [Windows] Automated build..
[Windows] Automated build.
Fri, May 22, 8:06 AM
Vulcan added a comment to D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

Successful build - Chance fights ever on the side of the prudent.

Fri, May 22, 6:09 AM
Harbormaster failed remote builds in B11769: Diff 11965 for D2734: Rewrite Structure Tree and Template Viewer to use OOP principles!
Fri, May 22, 6:01 AM
Vulcan added a comment to D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, May 22, 6:00 AM
s0600204 added a comment to D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

@elexis: I thank you for your thanks. I figured you would appreciate the intent of the proposed change, even if you disagreed with parts of the actual implementation. I acknowledge that you had not and do not request any changes, and I thank you for sharing your insight.

Fri, May 22, 5:59 AM
s0600204 updated the diff for D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

Break structree gui up further into separate files and classes

Fri, May 22, 5:58 AM
Vulcan added a comment to D11: Implement Single-Player (SP) campaign interface.

Successful build - Chance fights ever on the side of the prudent.

Fri, May 22, 12:14 AM
Harbormaster failed remote builds in B11768: Diff 11964 for D11: Implement Single-Player (SP) campaign interface!
Fri, May 22, 12:07 AM
Vulcan added a comment to D11: Implement Single-Player (SP) campaign interface.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, May 22, 12:07 AM
wraitii updated the diff for D11: Implement Single-Player (SP) campaign interface.

This implements some basic handling of game ends via a common file in session/campaigns.

Fri, May 22, 12:05 AM

Thu, May 21

Harbormaster failed remote builds in B11767: Diff 11963 for D11: Implement Single-Player (SP) campaign interface!
Thu, May 21, 11:36 PM
Vulcan added a comment to D11: Implement Single-Player (SP) campaign interface.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, May 21, 11:36 PM
Vulcan added a comment to D2563: NVTT build fixes.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, May 21, 11:35 PM
Vulcan added a comment to D11: Implement Single-Player (SP) campaign interface.

Successful build - Chance fights ever on the side of the prudent.

Thu, May 21, 10:48 PM
wraitii updated the summary of D11: Implement Single-Player (SP) campaign interface.
Thu, May 21, 10:40 PM
wraitii updated the summary of D11: Implement Single-Player (SP) campaign interface.
Thu, May 21, 10:38 PM
wraitii updated the diff for D11: Implement Single-Player (SP) campaign interface.

Complete rewrite of the patch (bar the simulation/session bit which I haven't looked at yet).

Thu, May 21, 10:36 PM
Vulcan added a comment to D2662: Gather using ResourceGatherer instead of UnitAI..

Successful build - Chance fights ever on the side of the prudent.

Thu, May 21, 9:27 PM
Freagarach updated the diff for D2662: Gather using ResourceGatherer instead of UnitAI..

Some sort of callback.

Thu, May 21, 9:22 PM
s0600204 committed rP23687: Correct WallPiece schema help comments.
Correct WallPiece schema help comments
Thu, May 21, 9:11 PM
s0600204 added a comment to rP23684: Add help comments to WallPiece component schema .

Ok, story time: I wrote this patch, and then sat on it for about a day. Read through it again, thought to myself "this looks ok: factually correct and all that", so committed it. Not half-an-hour later, I realised that I had made a mistake: orientation and bend weren't in radians[^1]. By this time, it was roughly six in the morning, I recognised I was way too tired to attempt to fix then, so resolved to do so after some sleep. I wake up, and find out I'd got the other unit of measurement wrong too... 🤦

Thu, May 21, 9:11 PM
Vulcan added a comment to D2662: Gather using ResourceGatherer instead of UnitAI..

Successful build - Chance fights ever on the side of the prudent.

Thu, May 21, 8:41 PM
Freagarach planned changes to D2662: Gather using ResourceGatherer instead of UnitAI..

Use a callback.

Thu, May 21, 8:37 PM
Freagarach updated the diff for D2662: Gather using ResourceGatherer instead of UnitAI..
  • Separate UnitAI-calls. (To be revised.)
  • Gather treasure in cmpResourceGatherer.
Thu, May 21, 8:36 PM
Vulcan added a comment to D2563: NVTT build fixes.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, May 21, 7:54 PM
Vulcan added a comment to D2721: improve animal footprints.

Successful build - Chance fights ever on the side of the prudent.

Thu, May 21, 7:44 PM
Nescio added a comment to D2721: improve animal footprints.

There might have been more changes and added animals in the last 3 years, did you check them all?

What I did is go through the current version of all fauna templates; 0 A.D. does not have that many animals. I didn't go through the svn file history of every file; only in the case when something seemed wrong (e.g. boar, peacock).

Thu, May 21, 7:41 PM
Harbormaster failed remote builds in B11763: Diff 11960 for D2721: improve animal footprints!
Thu, May 21, 7:41 PM
Vulcan added a comment to D2721: improve animal footprints.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, May 21, 7:40 PM
Nescio updated the diff for D2721: improve animal footprints.
  • Adjust rabbit footprint, as requested by @Palaxin.
Thu, May 21, 7:39 PM
Vulcan added a comment to D2563: NVTT build fixes.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, May 21, 7:30 PM
Vulcan added a comment to D2563: NVTT build fixes.

Successful build - Chance fights ever on the side of the prudent.

Thu, May 21, 7:26 PM
Nescio added a comment to D2739: delete golden fleece.

I think this kind of stuff is something for cheats...

If I recall correctly, Age of Mythology had a flying purple hippo cheat unit. Having a flying goat with golden fleece as a cheat unit could indeed be fun; however, 0 A.D.'s “golden fleece” is nowhere close to that.

What about fixing it instead?

Given that the dragon is still unfinished, I don't expect the golden fleece to be redone properly in the forseeable future.

Thu, May 21, 7:22 PM
Freagarach added a comment to D2662: Gather using ResourceGatherer instead of UnitAI..

First of all, both of you thanks for looking into this!

Thu, May 21, 7:22 PM
Harbormaster failed remote builds in B11760: Diff 11957 for D2563: NVTT build fixes!
Thu, May 21, 7:14 PM
Vulcan added a comment to D2563: NVTT build fixes.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, May 21, 7:13 PM
Itms updated the diff for D2563: NVTT build fixes.

Update after rP23686, so that the mac slave builds the new version.

Thu, May 21, 7:13 PM
Nescio added a comment to D1418: Enable garrisoning on gates / fix movement of units with visible garrison points.

@wraitii, this looks promising; any idea when it'll be finished? Being able to garrison units on gates without interfering with opening and closing would certainly be a great improvement.

Thu, May 21, 7:12 PM
Vulcan added a comment to D2756: workshop → arsenal.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, May 21, 7:10 PM
Nescio added inline comments to D2756: workshop → arsenal.
Thu, May 21, 7:09 PM
Nescio added a comment to D2756: workshop → arsenal.

And as usual, Vulcan can't handle maps with spaces in the file name; see D1042.

Thu, May 21, 7:07 PM
Vulcan added a comment to D2756: workshop → arsenal.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, May 21, 7:07 PM
Harbormaster failed remote builds in B11759: Diff 11955 for D2756: workshop → arsenal!
Thu, May 21, 7:06 PM
Vulcan added a comment to D2756: workshop → arsenal.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, May 21, 7:06 PM
Nescio created D2756: workshop → arsenal.
Thu, May 21, 7:05 PM
Vulcan added a comment to D1958: Turrets and/or sub-units..

Successful build - Chance fights ever on the side of the prudent.

Thu, May 21, 6:59 PM
wowka updated the diff for D2750: Hide "Control all units" checkbox in observer mode.
Thu, May 21, 6:57 PM
Vulcan added a comment to D2755: Do not pass owner when trying to add gatherer..

Successful build - Chance fights ever on the side of the prudent.

Thu, May 21, 6:48 PM
Angen added inline comments to D2750: Hide "Control all units" checkbox in observer mode.
Thu, May 21, 6:46 PM
wowka added inline comments to D2750: Hide "Control all units" checkbox in observer mode.
Thu, May 21, 6:45 PM
Vulcan added a comment to D2754: Fix a rare case of units getting stuck.

Successful build - Chance fights ever on the side of the prudent.

Thu, May 21, 6:43 PM
Freagarach added inline comments to D2755: Do not pass owner when trying to add gatherer..
Thu, May 21, 6:43 PM
Angen added inline comments to D2755: Do not pass owner when trying to add gatherer..
Thu, May 21, 6:42 PM
Freagarach added a comment to D2755: Do not pass owner when trying to add gatherer..

True, but I did ditch some Engine.QueryInterface-calls, so I do not know what is to be preferred ^^ (One can measure obviously.)

Thu, May 21, 6:39 PM
wowka updated the diff for D2750: Hide "Control all units" checkbox in observer mode.
Thu, May 21, 6:38 PM
Angen added a comment to D2755: Do not pass owner when trying to add gatherer..

just want to note that you just went from o(1*n) to o(m*n) where n is maximum from all this. gatherers[x]. length and m is number of players need to be checked what is 8 in worst case right now

Thu, May 21, 6:35 PM
Harbormaster failed to build B11755: rP23685: Fix typo (certifiacte -> certificate) imported from gloox in rP21901, reported… for rP23685: Fix typo (certifiacte -> certificate) imported from gloox in rP21901, reported…!
Thu, May 21, 6:34 PM
Harbormaster failed to build B11758: rP23686: Check the library version instead of the mtime of the already-built guard file… for rP23686: Check the library version instead of the mtime of the already-built guard file…!
Thu, May 21, 6:25 PM
Vulcan added a comment to D2746: Correctly serialize/deserialize user-defined JS objects..

Successful build - Chance fights ever on the side of the prudent.

Thu, May 21, 6:09 PM
Vulcan added a comment to D2111: [PetraAI] - Do not try to attack entities which can't be attacked..

Successful build - Chance fights ever on the side of the prudent.

Thu, May 21, 5:41 PM
Harbormaster failed remote builds in B11752: Diff 11948 for D1958: Turrets and/or sub-units.!
Thu, May 21, 5:32 PM
Vulcan added a comment to D1958: Turrets and/or sub-units..

Build was aborted.

Thu, May 21, 5:32 PM
Itms committed rP23686: Check the library version instead of the mtime of the already-built guard file….
Check the library version instead of the mtime of the already-built guard file…
Thu, May 21, 5:29 PM
Itms closed D2649: build-osx-libs: Compare lib version instead of dir mtime.
Thu, May 21, 5:29 PM · macOS Developers
Freagarach created D2755: Do not pass owner when trying to add gatherer..
Thu, May 21, 5:14 PM
Itms accepted D2649: build-osx-libs: Compare lib version instead of dir mtime.

I am going to commit this, but with a suffix for spidermonkey, as well as using numbers (instead of tentative dates) for the suffixes.

Thu, May 21, 5:06 PM · macOS Developers
wraitii added a comment to D2662: Gather using ResourceGatherer instead of UnitAI..

UnitAI should be allowed to let several components perform different tasks (i.e. unitAI could allow a unit to attack and walk at the same moment).

This is equivalent to switching unitAI to a multiple-state FSM, and running multiple timers there.

Thu, May 21, 3:54 PM
wraitii added a comment to D665: Make ship pickup nicer.

Overall I like this and it should indeed improve the behaviour. Think you can improve unitAI a tad more.

Thu, May 21, 3:47 PM