Page MenuHomeWildfire Games
Feed All Stories

Thu, Jul 30

Vulcan added a comment to D2496: tweak soldier footprints.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Jul 30, 11:03 PM
Nescio updated the diff for D2496: tweak soldier footprints.
  • make use of D2844/rP23900 by @Angen to give heroes the same footprints as their citizen counterparts.
Thu, Jul 30, 11:02 PM
Harbormaster failed remote builds in B12667: Diff 12970 for D2921: Adds ARB shaders for GUI materials to replace fixed ones!
Thu, Jul 30, 10:50 PM
Vulcan added a comment to D2921: Adds ARB shaders for GUI materials to replace fixed ones.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Jul 30, 10:50 PM
vladislavbelov created D2921: Adds ARB shaders for GUI materials to replace fixed ones.
Thu, Jul 30, 10:49 PM
Nescio updated subscribers of D2720: update information in {civ}.json files.

Owners added a subscriber: O11: Templates (Balancing).

@Itms, @Stan, the {civ}.json files don't actually affect gameplay balance.

Thu, Jul 30, 10:35 PM
Harbormaster failed remote builds in B12666: Diff 12969 for D2720: update information in {civ}.json files!
Thu, Jul 30, 10:28 PM
Vulcan added a comment to D2720: update information in {civ}.json files.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Jul 30, 10:28 PM
Nescio updated the diff for D2720: update information in {civ}.json files.
  • redone from scratch
Thu, Jul 30, 10:27 PM
Itms added inline comments to D2199: Add RL interface for Reinforcement Learning.
Thu, Jul 30, 10:10 PM
Harbormaster failed remote builds in B12664: Diff 12967 for D2199: Add RL interface for Reinforcement Learning!
Thu, Jul 30, 8:45 PM
Vulcan added a comment to D2199: Add RL interface for Reinforcement Learning.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Jul 30, 8:44 PM
Itms added a comment to D665: Make ship pickup nicer.

Fix the map!

Thu, Jul 30, 8:43 PM
Vulcan added a comment to D665: Make ship pickup nicer.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Jul 30, 8:41 PM
irishninja updated the diff for D2199: Add RL interface for Reinforcement Learning.

Style fixes mostly from the last round of feedback. I am still digging into the seg fault from earlier. I had a couple questions about some of the earlier comments that I made inline and will update the code after I have a clearer idea of the approach to take!

Thu, Jul 30, 8:35 PM
irishninja added inline comments to D2199: Add RL interface for Reinforcement Learning.
Thu, Jul 30, 8:33 PM
Nescio added a comment to D2852: [gameplay] Tweak maurya worker elephant stats.

Yes. Feel free to update the patch, like I did, or if you intend to make further changes, consider commandeering it.
I actually dislike this patch, but if others really think it's an improvement, I have no real objections, worker elephants are not that important.

Thu, Jul 30, 8:32 PM
Itms added a comment to D665: Make ship pickup nicer.

I do not know the current unit motion as well as wraitii and Freagarach do, so I'm trusting Freagarach's review here 🙂 The C++ changes do not seem problematic at first sight.

Thu, Jul 30, 8:25 PM
Vulcan added a comment to D888: Regrouped special technologies.

Successful build - Chance fights ever on the side of the prudent.

Thu, Jul 30, 8:24 PM
borg- added a comment to D2852: [gameplay] Tweak maurya worker elephant stats.
  • training time to 15, per @borg-
  • corrected <Loot>
Thu, Jul 30, 8:23 PM
Nescio updated the diff for D888: Regrouped special technologies.
  • forgot athen marines
Thu, Jul 30, 8:19 PM
Stan added a comment to D665: Make ship pickup nicer.

Shouldn't Itms look at it ?

Thu, Jul 30, 8:17 PM
Vulcan added a comment to D888: Regrouped special technologies.

Successful build - Chance fights ever on the side of the prudent.

Thu, Jul 30, 8:16 PM
Nescio updated the diff for D888: Regrouped special technologies.
Thu, Jul 30, 8:09 PM
Itms added inline comments to D2199: Add RL interface for Reinforcement Learning.
Thu, Jul 30, 7:44 PM
Nescio updated the diff for D2852: [gameplay] Tweak maurya worker elephant stats.
  • training time to 15, per @borg-
  • corrected <Loot>
Thu, Jul 30, 7:33 PM
borg- added a comment to D2852: [gameplay] Tweak maurya worker elephant stats.

Just change <BuildTime>10</BuildTime> to <BuildTime>15</BuildTime> cuz D2862.

Thu, Jul 30, 6:54 PM
asterix updated subscribers of D2852: [gameplay] Tweak maurya worker elephant stats.

@wraitii @Stan can you help?

Thu, Jul 30, 6:15 PM
borg- added a comment to D2852: [gameplay] Tweak maurya worker elephant stats.

Changes is good, i will like see this patch commited, but feldfeld offline for weaks.

Thu, Jul 30, 6:09 PM
asterix added a comment to D2852: [gameplay] Tweak maurya worker elephant stats.
In D2852#126518, @borg- wrote:

Can change author patch?

Thu, Jul 30, 5:57 PM
Nescio added a comment to rP23808: Rewrite Structure Tree and Template Viewer to use OOP principles.

@s0600204, there is something wrong with the values displayed in the structure tree when launched from the pre-game main menu. It worked correctly before, therefore my guess is the problem was introduced here.
For example, palisades have 200 to 1000 health. athen, mace, spart structures have +10% health as a civ bonus, so for them it is 220 to 1100 health, but not for the others. When opened from a game session, the structure tree displays the correct values, e.g. 200 to 1000 for pers. However, when launching the structure from the pre-game main menu, it displays 220 to 1100 health for all civs, which is wrong.

Thu, Jul 30, 5:44 PM
borg- added a comment to D665: Make ship pickup nicer.

Planning to commit this soon.

Thu, Jul 30, 5:42 PM
borg- added a comment to D2852: [gameplay] Tweak maurya worker elephant stats.

Can change author patch?

Thu, Jul 30, 5:21 PM
wraitii added a comment to D665: Make ship pickup nicer.

Planning to commit this soon.

Thu, Jul 30, 5:21 PM
wraitii removed a reviewer for D2182: Support training of groups of units.: wraitii.

Think I'm staying the mind that this might be worth for a mod but not the base game. I would vote towards abandoning.

Thu, Jul 30, 3:54 PM
wraitii removed a reviewer for D2016: Rename "ElevationBonus" and "Delay" to "AttackHeightOffset" and "DamageDelay", respectively.: wraitii.
Thu, Jul 30, 3:54 PM
wraitii removed a reviewer for D2213: Delete CSimulation2 m_MapSettings and redundant getters: wraitii.
Thu, Jul 30, 3:50 PM
wraitii removed a reviewer for D1838: Add proximity attack component.: wraitii.

I think this could be implemented better following unit pushing, which I do intend to get on someday, so I'm unsetting myself.

Thu, Jul 30, 3:50 PM
bb added inline comments to D2697: Do not let every entity with UnitAI listen to "OnGlobalConstructionFinished"..
Thu, Jul 30, 3:49 PM
wraitii accepted D2697: Do not let every entity with UnitAI listen to "OnGlobalConstructionFinished"..

@bb pointed out that you mean "400 units on the map", not actually building, so this easily seems worth doing to me.

Thu, Jul 30, 3:48 PM
wraitii added a comment to D781: Elevation attack bonus for units..

Care to rebase this one @Freagarach

Thu, Jul 30, 3:46 PM
wraitii removed a reviewer for D2269: Combine attacker data in "attackerData" in attack-related code.: wraitii.
Thu, Jul 30, 3:45 PM
wraitii removed a reviewer for D1473: Add SelectionGroupNames for siege engines.: wraitii.
Thu, Jul 30, 3:45 PM
wraitii added a comment to D2697: Do not let every entity with UnitAI listen to "OnGlobalConstructionFinished"..

Seems fine like this given the limited usage.

Thu, Jul 30, 3:41 PM
bb requested changes to D2229: Elaborate Armour..

Vulcan found some stuff in Resistance.js

Thu, Jul 30, 3:26 PM
Vulcan added a comment to D2199: Add RL interface for Reinforcement Learning.

Successful build - Chance fights ever on the side of the prudent.

Thu, Jul 30, 2:58 PM
wraitii requested changes to D2852: [gameplay] Tweak maurya worker elephant stats.

Think @Feldfeld failed to notice ;)

Thu, Jul 30, 2:49 PM
wraitii added a comment to D2495: [gameplay] disable artillery towers and bolt towers.

Will commit soon.

Thu, Jul 30, 2:48 PM
wraitii requested changes to D2270: Allow area damages to have a minimum range..

@bb 's comments

Thu, Jul 30, 2:44 PM
wraitii removed a reviewer for D1707: Generalise hard-counter tooltips.: wraitii.

I think I'm voting towards abandoning this, but I'll let you decide.

Thu, Jul 30, 2:44 PM
wraitii added a comment to D2791: Do not attempt to gather when full on that resource.

Giving this a longer look, I'm doubtful if it's not better in gathering.Enter or in a function somewhere called in APPROACHING/GATHERING. I guess it'll hardly ever happen without also passing through Order.Gather, which seems OK.
I pondered using a "FINDINGDROPSITE" state to regroup the different paths in which we find a dropside, but that doesn't really seem worth doing.

Thu, Jul 30, 2:42 PM
borg- added a comment to D2916: [gameplay] balance economy techs.

+25% means that city phase technologies are no longer as necessary to win as before, so you can choose to use these resources in another way, like champions if you prefer.

Thu, Jul 30, 2:40 PM
irishninja added inline comments to D2199: Add RL interface for Reinforcement Learning.
Thu, Jul 30, 2:39 PM
irishninja updated the diff for D2199: Add RL interface for Reinforcement Learning.

Updated the code following the review from Itms. I still need to check out the seg fault but everything else should be addressed!

Thu, Jul 30, 2:37 PM
Itms requested changes to D2199: Add RL interface for Reinforcement Learning.

Very fun tool to play with, great job! And the code looks pretty nice, it's self-contained and easy to read.

Thu, Jul 30, 12:23 PM
wraitii added a comment to D2916: [gameplay] balance economy techs.
In D2916#126445, @borg- wrote:

+25% seems really good mainly because with the proposed values, the techs cost more wood and metal, so a higher early gain seems better to me. Also makes the techs more attractive at the early of the game, for example, I prefer to make more soldiers than research a +15% tech, at least as long as I don't have a good amount of units.

Thu, Jul 30, 8:26 AM
Stan requested verification of rP23906: Fixes the broken animation of the persian champion_cavalry_archer.

Fixed in rP23912

Thu, Jul 30, 8:08 AM
Stan committed rP23912: Fix missing coma in rP23906..
Fix missing coma in rP23906.
Thu, Jul 30, 8:08 AM
vladislavbelov raised a concern with rP23906: Fixes the broken animation of the persian champion_cavalry_archer.

Any change should be tested whenever possible.

Thu, Jul 30, 3:59 AM
borg- added a comment to D2917: [gameplay] allow upgrading cart_house to cart_apartment.

@Nescio
What would be the appropriate values in:

Thu, Jul 30, 3:45 AM
borg- added a comment to D2916: [gameplay] balance economy techs.

+25% seems really good mainly because with the proposed values, the techs cost more wood and metal, so a higher early gain seems better to me. Also makes the techs more attractive at the early of the game, for example, I prefer to make more soldiers than research a +15% tech, at least as long as I don't have a good amount of units.

Thu, Jul 30, 3:41 AM
borg- added a comment to D2916: [gameplay] balance economy techs.

By the way, did you consider diminishing increases, e.g. +30%, +25%, +20% (village, town, city)? While the relative increase per technology would go down, the absolute gain would still go up slightly, but less pronounced than under the current proposal. It would also be a bit closer in spirit to @wraitii's point.
(Again, not a request, just something to think about.)

Thu, Jul 30, 3:33 AM

Wed, Jul 29

Stan committed rP23911: Remove stretching from the 5x8 and 5x9 decals.
Remove stretching from the 5x8 and 5x9 decals
Wed, Jul 29, 11:00 PM
Stan added inline comments to D2919: Make PlayerHasMarket event-based.
Wed, Jul 29, 4:44 PM
Stan removed 1 auditor(s) for rP22547: Refactors Camera aspect ratio and calculation of plane points.: Stan.
Wed, Jul 29, 4:38 PM
Stan resigned from rP22547: Refactors Camera aspect ratio and calculation of plane points..

Although the fix is correct (floats should generally not be checked for equality), I am still dubious about that GCC bug.
Camera precision doesn't matter that much, and the tests are fixed, so removing myself as auditor

Wed, Jul 29, 4:38 PM
Nescio added a comment to D2916: [gameplay] balance economy techs.

By the way, did you consider diminishing increases, e.g. +30%, +25%, +20% (village, town, city)? While the relative increase per technology would go down, the absolute gain would still go up slightly, but less pronounced than under the current proposal. It would also be a bit closer in spirit to @wraitii's point.
(Again, not a request, just something to think about.)

Wed, Jul 29, 4:08 PM
Nescio added a comment to D2916: [gameplay] balance economy techs.

If change to +15%, what you think about increase farm base gather rate like +5%?

You can keep 20% if you believe that's better. It would mean an effective increase, but 15% each would mean a reduction. I'm not requesting changes, I wrote my previous post to encourage you to critically think about the proposed changes another time.
As for base gather grain rates, infantry has 0.25, slave 0.35, female citizen 0.50, i.e. a 1 : √2 : 2. I'm not saying those values are great, but I think tweaking them would be outside the scope of this patch.

Wed, Jul 29, 3:46 PM
Freagarach added inline comments to D2919: Make PlayerHasMarket event-based.
Wed, Jul 29, 2:44 PM
borg- added a comment to D2916: [gameplay] balance economy techs.

For most resources the old (1.15 × 1.15 × 1.5 = 1.98, i.e. a 98% increase) and new (1.25^3 = 1.95, i.e. a 95% increase) are about the same, however, for food the numbers mean an increase, from +65% (i.e. 1.15 × 1.15 × 1.25 = 1.65) to +73% (i.e. 1.2^3 = 1.73). 15% each would mean a decrease, though, to +52% (i.e. 1.15^3 = 1.52). Nonetheless, I think lowering food gain would be better than raising it, though.

Wed, Jul 29, 2:35 PM
Vulcan added a comment to D2919: Make PlayerHasMarket event-based.

Successful build - Chance fights ever on the side of the prudent.

Wed, Jul 29, 2:16 PM
Itms updated the diff for D2919: Make PlayerHasMarket event-based.

Use CanBarter rather than HasMarket.
Test cmpPlayer and add a unit test for cmpPlayer.SetPlayerID while I'm at it.

Wed, Jul 29, 2:09 PM
wraitii added a comment to D1751: [WIP] Map flares.

(Also never used arc with git, so no idea how that would work…)

Wed, Jul 29, 1:41 PM
Imarok added a comment to D1751: [WIP] Map flares.

Code looks good, I failed to test this because patch doesn't include images (and arc-patch doesn't work on my git here apparently).

Wed, Jul 29, 1:23 PM
Nescio added a comment to D2916: [gameplay] balance economy techs.

Generally I like this patch, it's a clear improvement over the current situation. A few things to think about, though:

+25% gather rate (+20% to food tech)

For most resources the old (1.15 × 1.15 × 1.5 = 1.98, i.e. a 98% increase) and new (1.25^3 = 1.95, i.e. a 95% increase) are about the same, however, for food the numbers mean an increase, from +65% (i.e. 1.15 × 1.15 × 1.25 = 1.65) to +73% (i.e. 1.2^3 = 1.73). 15% each would mean a decrease, though, to +52% (i.e. 1.15^3 = 1.52). Nonetheless, I think lowering food gain would be better than raising it, though.

keep food + wood, because the metal will often not be available. The cost of metal has increased for other techs, so it seems fair to keep only food and wood.

Don't players practically always start with a stone quarry and metal mine adjacent to their starting centre, each worth 5000? I think making metal more important in early game won't harm. That said, if you believe food + wood is intrinsically better than wood + metal, I don't have serious objections.

Fishing Net, cost 100 food --> 200 food, 40 research time.
Salting Fish, research time 40 --> 50.
Stockbreeding, cost 50 food --> 100 food.

I never liked these technologies (I'd prefer to see them disabled, but that's a different discussion), however, why do they cost only food?

Market techs are not included, I will make a patch for all market technologies.

Fair enough.
gather_wicker_baskets.json did not need tweaking?

Wed, Jul 29, 1:15 PM
Nescio added a comment to D2905: Use all variants of the war dog.

According to Wikipedia there should be sources that attest of the armoring of dogs https://en.wikipedia.org/wiki/Dogs_in_warfare. Maybe in some of the classical sources there is mention.

You mean:

Gifts of war dog breeding stock between European royalty were seen as suitable tokens for exchange throughout the Middle Ages. Other civilizations used armored dogs to defend caravans or attack enemies.

and:

In ancient times, dogs, often large mastiff- or molosser-type breeds, would be strapped with armor or spiked collars and sent into battle to attack the enemy. This strategy was used by various civilizations, such as the Romans and the Greeks.

None of that is sourced. Moreover, armour does not necessarily mean chain mail. It's not even clear if Britons actually used body armour (ask @genava55), so why should their dogs?

Wed, Jul 29, 12:57 PM
Stan added a comment to D1751: [WIP] Map flares.

Wed, Jul 29, 12:07 PM
wraitii added a comment to D1751: [WIP] Map flares.

Code looks good, I failed to test this because patch doesn't include images (and arc-patch doesn't work on my git here apparently).

Wed, Jul 29, 12:00 PM
Vulcan added a comment to D2905: Use all variants of the war dog.

Build failure - The Moirai have given mortals hearts that can endure.

Wed, Jul 29, 11:58 AM
Harbormaster failed remote builds in B12656: Diff 12961 for D2905: Use all variants of the war dog!
Wed, Jul 29, 11:56 AM
Vulcan added a comment to D2905: Use all variants of the war dog.

Build failure - The Moirai have given mortals hearts that can endure.

Wed, Jul 29, 11:56 AM
Stan updated the diff for D2905: Use all variants of the war dog.

Rename file
Build will fail because of EOL props

Wed, Jul 29, 11:56 AM
Stan planned changes to D2905: Use all variants of the war dog.

According to Wikipedia there should be sources that attest of the armoring of dogs https://en.wikipedia.org/wiki/Dogs_in_warfare. Maybe in some of the classical sources there is mention.

Wed, Jul 29, 11:49 AM
wraitii committed rP23910: Fix warning with disabled templates in rP23843..
Fix warning with disabled templates in rP23843.
Wed, Jul 29, 11:46 AM
wraitii closed D2904: Fix warning with disabled templates in rP23843.
Wed, Jul 29, 11:46 AM
wraitii requested changes to D2905: Use all variants of the war dog.

Quick request changes over the _b thing that can be deleted now.

Wed, Jul 29, 11:42 AM
wraitii accepted D2919: Make PlayerHasMarket event-based.

This was actually reported a little over 2 years ago ;) : https://wildfiregames.com/forum/index.php?/topic/23518-alpha-23-planning/page/12/&tab=comments#comment-356440
(staff forum thread)

Wed, Jul 29, 10:13 AM
Vulcan added a comment to D2920: Fix gathering infinite loop when the gatherer is out of the world..

Successful build - Chance fights ever on the side of the prudent.

Wed, Jul 29, 10:05 AM
Stan added inline comments to D2920: Fix gathering infinite loop when the gatherer is out of the world..
Wed, Jul 29, 10:03 AM
wraitii created D2920: Fix gathering infinite loop when the gatherer is out of the world..
Wed, Jul 29, 9:59 AM
Vulcan added a comment to D761: Attempt to cleanup the scrollbar code..

Successful build - Chance fights ever on the side of the prudent.

Wed, Jul 29, 6:25 AM
s0600204 updated the diff for D761: Attempt to cleanup the scrollbar code..

A "serious" rebase.

Wed, Jul 29, 6:08 AM
borg- updated the summary of D2916: [gameplay] balance economy techs.
Wed, Jul 29, 2:14 AM
borg- updated the diff for D2916: [gameplay] balance economy techs.

Gather techs Standart values:

Wed, Jul 29, 2:13 AM
Harbormaster failed to build B12650: rP23909: Add missing gravel and normal files from previous commit for rP23909: Add missing gravel and normal files from previous commit !
Wed, Jul 29, 1:51 AM
Stan committed rP23909: Add missing gravel and normal files from previous commit .
Add missing gravel and normal files from previous commit
Wed, Jul 29, 1:49 AM
Stan added a comment to D2723: Add support for hotloading of sound-related files.

Hey, any news?

Wed, Jul 29, 1:17 AM
Vulcan added a comment to D1751: [WIP] Map flares.

Successful build - Chance fights ever on the side of the prudent.

Wed, Jul 29, 12:42 AM
Imarok updated the diff for D1751: [WIP] Map flares.

Use alarmally_1.ogg. Consistently name it flare.

Wed, Jul 29, 12:14 AM
Imarok retitled D1751: [WIP] Map flares from [WIP] Map ping to [WIP] Map flares.
Wed, Jul 29, 12:12 AM