The only reason I can see (now) to keep the per player storage is when ordering a unit to gather somewhere, where also enemies are gathering, the unit maybe should kill the enemies before gathering. However this can be considered player responsibility too, sine he should be able too see the enemies in this case. If he can't see them (very large resourcesupply ent or so), it is fine this way. So probably behavior we don't need want.

All cases of CMessageMotionUpdate::OBSTRUCTED got the treatment
Both issues seem fixed.

Successful build - Chance fights ever on the side of the prudent.

• rebased
• since the gui now supports more than 24 icons (rP24028), this patch is now committable

Since the alternative (D2875) has been committed (rP24028), this one (D2806) is no longer necessary.

Thank you, @Angen, for committing this! I'm sure @wowgetoffyourcellphone, @borg-, and others appreciate it too.

Thanks for taking care of this @Angen :)

inline :)
commas

Considering whether returning to many entities can cause a problem. These are the affected components:
BuildingAI: arrows can fire out of range now. Probably can get away with checking the proper range in the buildingAI (slightly bad that we compute the range twice, with increasing precision)
Auras: probably who cares in this case
Gate: ^^
buildrestiction: ranges got a bit modified => no problem, since the ranges are large compared to the obstructions, small nerf for fortresses and some other structures (they need to be placed further apart)
AlertRaiser: ranges modified => same story as buildrestrictions (small obstruction, large range).
unitAI => nothing really changes, we just respond to more entities, but we still move in range
Attacking/delayedDamaged => fixed by D2963
Trigger: Changed as they should.

Successful build - Chance fights ever on the side of the prudent.

• Add newline (and reorder)

stylistic issues can be fixed while committing

I did build of rP23924 and then rP23925. It was not present before this commit.

For what it's worth, javascript uses UTF-16 strings, so it's probably faster to use CStrW when interacting with JS code (fewer conversions). That being said, performance is not the utmost concern here, so using utf-8 strings is probably neater.

Hm, these reports are odd indeed, I'll investigate.

sure, if that diff makes it to a24, it would be great

Successful build - Chance fights ever on the side of the prudent.

• Formatting fixes, code cleanup

Thanks for the review! I am pushing an updated version now.

This patch allows buildings to be build too close to other buildings, outside territory and everything else that buildRestrictions forbids. We should somehow reuse that code here too.

Don't feel this is the correct way of approaching the issue. I rather have the buttons enabled for the right click.

Noted by elexis

Shouldn't we do something similar for all attackRange queries in the ai?

• fix generic name and player colour band conflict spotted by @Angen (there was indeed a 2 pixel overlap)

e.g. trees, braces are a bit inside the banner

action buttons in midle panel could be moved a bit lower,

See the summary:

Command icons (middle panel) have their centre vertically aligned with the bottom row of the left and right selection panels.

In a previous version I put them at the bottom, but it turned out it looks better if their centres are vertically aligned.

Also player/civilisation bar is too close to entity name in brackets, for some entities it overlaps a bit.

Which ones?

action buttons in midle panel could be moved a bit lower,
Also player/civilisation bar is too close to entity name in brackets, for some entities it overlaps a bit. Does not happen in a23b.

• address player name colour mistake spotted by @Angen:

more comments

Successful build - Chance fights ever on the side of the prudent.

rebase + animal state

Successful build - Chance fights ever on the side of the prudent.

Make sure you consider rP23994 when committing

Form formation at the start, it will never-ever move.
Formation controller is blocked by cc obstruction while stucked in it.

more jenkins

Successful build - Chance fights ever on the side of the prudent.

• correct tooltip

• change population cap from flat +50 to relative +20%, per @badosu and @borg-

• include special_hellenistic_metropolis.json
• include maur_tower_double.xml

Looks and works good.
IMO one should create diff to get guarding units closer if possible so they mostly ends up in guarding range then mostly not.

nice find

Ai works without errors.
As I think it would be good to make use of support elephant aura while building, mobile dropsite is more valuable moreover since ai has only one worker elephant.
Removing Champion class from siege unit check is ok-ish, as champion melee elephants are only melee elephant svn currently has.
Rest removals and changes to Unit class are ok.
I do not like unrelated style changes but idc too much.
Thank you for the patch.

Successful build - Chance fights ever on the side of the prudent.

Use Cstr, nuke boost