Page MenuHomeWildfire Games
Feed All Stories

Fri, Sep 11

Freagarach added a comment to D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..

It looks much better with only one second waiting time :)

Fri, Sep 11, 9:06 AM

Thu, Sep 10

Palaxin added a comment to D2956: [gameplay] tweak ship costs and tweak merchant ships.

currently 1.25:1

Currently merchant ships cost 100 metal and 0 wood.

Thu, Sep 10, 10:20 PM
Freagarach accepted D3005: Range safe buildingAI.

Idea and code is correct, adds ~50-150 microseconds per arrow.

Thu, Sep 10, 8:45 PM
Freagarach requested changes to D2652: Do not allow upgrading when entity is producing and vice versa..
  • Build two sentry towers.
  • Upgrade the first to a defence tower.
  • Select both towers.
  • Try to research sentries.
  • Notice the message that we can't start production.
Thu, Sep 10, 7:55 PM
Freagarach accepted D2990: split template_gaia_flora*.
  • Forest plant: Indeed unused, can be added later if deemed a necessity.
  • Effectively nothing has changed. Complete.
  • Change is nice, it clears it up nicely.
Thu, Sep 10, 7:30 PM
Angen updated the diff for D2652: Do not allow upgrading when entity is producing and vice versa..

check for cmpplayer and add test

Thu, Sep 10, 7:26 PM
Freagarach accepted D2982: Read correctly 0/false values from map files in gamesetup.

It is good read map data correctly. Stupid mapmakers should get stupid results.
Complete.

Thu, Sep 10, 6:44 PM
Freagarach added inline comments to D2982: Read correctly 0/false values from map files in gamesetup.
Thu, Sep 10, 6:40 PM
Angen committed rP24034: Cheer after combat when no enemy units are in range.
Cheer after combat when no enemy units are in range
Thu, Sep 10, 6:37 PM
Angen closed D1977: Cheer after no enemy entities left in range.
Thu, Sep 10, 6:37 PM
Angen updated the diff for D2982: Read correctly 0/false values from map files in gamesetup.

MapSize.js
WorldPopulationCap.js

Thu, Sep 10, 6:10 PM
Freagarach added a comment to D2997: Remove visibleclasses from guiinterface.

Or make it useful by using sim-information in the tooltip? Although I guess PetraAI would break if one changes classes in-game.

Thu, Sep 10, 5:40 PM
Freagarach requested changes to D2982: Read correctly 0/false values from map files in gamesetup.

gui/gamesetup/Pages/GameSetupPage/GameSettings/Single/Dropdowns

  • MapSize.js
  • WorldPopulationCap.js
Thu, Sep 10, 5:32 PM
Freagarach added a comment to D2161: Also account for elevation for melee units..

If you wield a sarissa it does matter whether your target is at exactly six meters away horizontally or six meters horizontally and two meters up (e.g. on top of an elephant).

Thu, Sep 10, 5:19 PM
Freagarach added inline comments to D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.
Thu, Sep 10, 5:10 PM
Angen added inline comments to D2661: Get attack effects from JSON..
Thu, Sep 10, 3:40 PM
Angen requested changes to D2661: Get attack effects from JSON..
a = class a { constructor() {console.log('constructor')} }
a = new a();
a = new a();

output

constructor
error: Uncaught TypeError: a is not a constructor
Thu, Sep 10, 3:36 PM
Angen added a comment to rP20622: Render the range visualization of auras, heal and attack component in a….

I missed in code where are m_EnabledRenderSubmit or m_EnabledInterpolate used?
Looks like they are here just for switch, they can be merged as always or are both enabled or both disabled.
Also that two ifs can be merged.

Thu, Sep 10, 3:24 PM
Freagarach added inline comments to D2661: Get attack effects from JSON..
Thu, Sep 10, 3:20 PM
Freagarach added a comment to D2661: Get attack effects from JSON..

These are attack effects, the effects an attack can have (attack types are melee and ranged etc. currently).

Thu, Sep 10, 2:40 PM
Angen added a comment to D2661: Get attack effects from JSON..

Is it attack effect or attack type ?

Thu, Sep 10, 2:35 PM
Freagarach added inline comments to D2661: Get attack effects from JSON..
Thu, Sep 10, 2:30 PM
Freagarach added inline comments to D2661: Get attack effects from JSON..
Thu, Sep 10, 2:28 PM
Freagarach updated the diff for D2661: Get attack effects from JSON..
  • Ditch temporary array
  • Don't hardcode attack sound.
  • Return {} in tests.
Thu, Sep 10, 2:28 PM
Freagarach added a comment to D2983: Reduces memory usage for fancy water.

Before:

Thu, Sep 10, 1:33 PM
Nescio added a comment to D2993: [gameplay] add visible garrison points to rome siege wall tower.

The garrison flag is not terribly important and could be kept, if you think that's better.
However, I believe the purpose of the garrison flag is to indicate an entity has a garrison inside. Actors of structures with visible garrison slots (e.g. long wall segments) don't have garrison flags, presumably because, well, their garrison is visible. Since this patch makes the garrsion visible, there no longer is a need for the garrison flag, and it's consistent to remove them.
Then there is also the fact that the emblem on the flag is the actor's civilization, not the owner's, but that's a separate issue.

Thu, Sep 10, 12:38 PM
Stan added a comment to D2993: [gameplay] add visible garrison points to rome siege wall tower.

(That's a tower)

Thu, Sep 10, 12:15 PM
Nescio added a comment to D2993: [gameplay] add visible garrison points to rome siege wall tower.

@Stan opinion on the flag removal? (I like the flags, but I'm no artist.)

(Other siege wall actors don't have garrison flags either.)

Thu, Sep 10, 11:52 AM
Nescio added a comment to D2956: [gameplay] tweak ship costs and tweak merchant ships.

currently 1.25:1

Currently merchant ships cost 100 metal and 0 wood. This patch proposes to keep the metal cost unchanged, adds a 200 wood cost, and increases health, resistance, and trade gain in compensation. That said, I don't feel strongly about particular values, and agree with you traders and merchant ships should have meaningful costs, since they basically generate free resources.

And, as mimo and I have tried to address in #3428 some years ago, garrisoning traders should be buffed (if this mechanic should actually be seen in game - right now it seems incredibly wasteful resource-wise and inefficient micro-wise).

Yes, I agree garrisoning traders in merchant ships is seldom worth it. However, #3428 proposes changing the mechanic, which I'm not sure is necessary, merely changing the current values could work too. But perhaps it should be abandoned altogether, constructing more merchant ships is better? It might be out of scope of this particular patch, though.

Thu, Sep 10, 11:51 AM
Freagarach updated subscribers of D2993: [gameplay] add visible garrison points to rome siege wall tower.

@Stan opinion on the flag removal? (I like the flags, but I'm no artist.)

Thu, Sep 10, 11:41 AM
Freagarach edited reviewers for D2990: split template_gaia_flora*, added: Freagarach; removed: Restricted Owners Package.
Thu, Sep 10, 11:39 AM
Nescio added a comment to D2999: [gameplay] make unlock_shared_dropsites independent from unlock_shared_los.

Yes, the

unlock_shared_dropsites.json
unlock_shared_los.json
unlock_spies.json

technologies are conceptually related, each of them enables a mechanic, rather than changing a value, like most technologies. However, I fail to see the need to enforce a particular order. In my opinion players ought to have the flexibility to pick and choose which ones they want to use, and ignore the others.
Moreover, there is a “Disable Spies” match setting and a mod that enables shared vision from start. Ideally all three ought to be treated similarly: { shared vision , shared dropsites , espionage } × { from game start , with technology , never }, but that's beyond the scope of this patch.

Thu, Sep 10, 11:34 AM
Nescio added a comment to D2991: split template_gaia_geo*.

(I assume specific templates are renamed in another diff?)

Yes, this is only cleaning up the lines inside; file moves will be done in a separate patch, to keep things reviewable. Same for D2990 and D2953.

Thu, Sep 10, 11:23 AM
Nescio updated the diff for D2993: [gameplay] add visible garrison points to rome siege wall tower.
  • clean up <BuildingAI> to define it only in structure templates with an <Attack>, per @Freagarach
Thu, Sep 10, 11:21 AM
Freagarach accepted D2991: split template_gaia_geo*.
Thu, Sep 10, 11:18 AM
Freagarach added a comment to D2991: split template_gaia_geo*.
  • Checkrefs says it is complete.
  • Playtesting reveals no errors.
  • UnitsDemo loads fine.
  • Change is for the better.
Thu, Sep 10, 11:18 AM
Nescio added a comment to D2774: gaia/fauna_fish* → gaia/fish/*.

Thank you!
Folders for other resource subtypes could make sense too, though the gaia/* files could use some clean-up first, hence D2953, D2990, D2991. Interested?

Thu, Sep 10, 11:10 AM
wraitii added a comment to D2362: Allow for building-specific build/repair animations and use seeding animation for fields.

My comment above remains valid, my status is "waiting on @Imarok to update the diff" ;)

Thu, Sep 10, 11:02 AM
wraitii added inline comments to D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..
Thu, Sep 10, 11:01 AM
wraitii updated the diff for D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..

Make formations walk again.

Thu, Sep 10, 11:00 AM
Stan updated subscribers of D2362: Allow for building-specific build/repair animations and use seeding animation for fields.

@wraitii @Freagarach can you have another look at this ?

Thu, Sep 10, 10:56 AM
Freagarach added a comment to D2989: Reuse "APPROACHING"-state in formation combat..

Thanks for the review @Angen and @bb :)

Thu, Sep 10, 10:54 AM
Freagarach added a comment to D2732: Allow to guard a guard..

Thanks for the review @Angen (and @bb) :)

Thu, Sep 10, 10:54 AM
wraitii added a comment to rP24032: Reuse "APPROACHING"-state in formation combat..

(The older way was made irrelevant by rP22313 which moved the "Move" call to states instead of orders.)

Thu, Sep 10, 10:45 AM
wraitii awarded rP24032: Reuse "APPROACHING"-state in formation combat. a Love token.
Thu, Sep 10, 10:43 AM
Freagarach added inline comments to D2980: Get dropsite resources from simulation..
Thu, Sep 10, 10:41 AM
Freagarach updated the diff for D2980: Get dropsite resources from simulation..
  • Remove redundant typeIcon in tooltip.
  • Remove tooltip from attackAndResistanceStats.
  • Show before health in reference page.
Thu, Sep 10, 10:41 AM
wraitii requested changes to D2368: Move movement logic from UnitAI's "Garrisoned"-state to approaching..

I think your previous diff had things in the wrong spot, and this one makes it obvious which.
Given the scope of things, I think you can get away with just "approaching" and "garrisoned", but you need to add some more code to "approaching" imo to not make it reliant on unit-motion.

Thu, Sep 10, 10:39 AM
Freagarach planned changes to D2368: Move movement logic from UnitAI's "Garrisoned"-state to approaching..

Point autogarrisoning to GARRISONING-state.

Thu, Sep 10, 10:31 AM
Vulcan added a comment to D2755: Don't store the gatherers per player..

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 10, 10:23 AM
Freagarach closed D2774: gaia/fauna_fish* → gaia/fish/*.
Thu, Sep 10, 10:21 AM
wraitii resigned from D2755: Don't store the gatherers per player..
Thu, Sep 10, 10:19 AM
Freagarach updated the diff for D2755: Don't store the gatherers per player..

@Angen, I'm keeping JSDOC anyway ;)

Thu, Sep 10, 10:16 AM
Palaxin added a comment to D2956: [gameplay] tweak ship costs and tweak merchant ships.

Land traders cost (80) metal too, and are much weaker and far less profitable (see previous post).

Thu, Sep 10, 10:04 AM
Freagarach committed rP24033: Allow guards to guard a guarding guard..
Allow guards to guard a guarding guard.
Thu, Sep 10, 10:01 AM
Freagarach closed D2732: Allow to guard a guard..
Thu, Sep 10, 10:01 AM
Freagarach committed rP24032: Reuse "APPROACHING"-state in formation combat..
Reuse "APPROACHING"-state in formation combat.
Thu, Sep 10, 9:52 AM
Freagarach closed D2989: Reuse "APPROACHING"-state in formation combat..
Thu, Sep 10, 9:51 AM
Stan added inline comments to D1977: Cheer after no enemy entities left in range.
Thu, Sep 10, 9:48 AM
Freagarach committed rP24031: Move "fauna_fish* -> "fish/*"..
Move "fauna_fish* -> "fish/*".
Thu, Sep 10, 9:41 AM
Freagarach accepted D1977: Cheer after no enemy entities left in range.
  • Code looks good.
  • PetraAI vs PetraAI matches give no oddities.
  • Dangerous animals don't error out.
  • Entities cheer when won a fight instead of after promoting, which is a big improvement!
Thu, Sep 10, 9:08 AM
Vulcan added a comment to D2961: Fix issues in RangeManager following rP23769.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 10, 8:46 AM
wraitii added a comment to D2752: Do not thread the game in Atlas.

Thanks for the comments @Itms , in that case I'll carry on investigating the FPS issue and move towards committing this :)

Thu, Sep 10, 8:42 AM
wraitii added a comment to D2967: Cache the model-animation maximum bounds..

@vladislavbelov Do you think the approach is acceptable? Indeed it works, but only by "coincidence" that CSkeletonAnimDef are long-lived. However it does bring a rather tangible improvement.

Thu, Sep 10, 8:42 AM
wraitii updated the diff for D2961: Fix issues in RangeManager following rP23769.

Updated, thanks for the look and thanks for reminding me I had uploaded this :p

Thu, Sep 10, 8:38 AM

Wed, Sep 9

borg- added a comment to rP24016: Debuff outpost and remove un-necessary technologies..

Outpost are almost not used in 2x2 games and
3x3 or 4x4. The current changes along with nescio pacth, outposts are more interesting and useful, as they do not need vision technology to have a considerable vision, they also lose territory slowly.
100% is not true.

Wed, Sep 9, 11:57 PM
wraitii added a comment to rP24016: Debuff outpost and remove un-necessary technologies..

This is 100% nonsense, in every competitive MP game I play, especially the vision tech is researched ALWAYS.

Wed, Sep 9, 10:07 PM
bb added a comment to rP24016: Debuff outpost and remove un-necessary technologies..

Technologies were not very potent and hardly ever researched.

Wed, Sep 9, 8:19 PM
Angen added a comment to D2652: Do not allow upgrading when entity is producing and vice versa..

disabled buttons

Wed, Sep 9, 6:35 PM
Freagarach added a comment to D2999: [gameplay] make unlock_shared_dropsites independent from unlock_shared_los.

Could you elaborate on why this ought to be an improvement? To me sharing dropsites follows naturally from sharing information.

Wed, Sep 9, 6:08 PM
Freagarach added inline comments to D2993: [gameplay] add visible garrison points to rome siege wall tower.
Wed, Sep 9, 6:04 PM
Stan added a comment to D2652: Do not allow upgrading when entity is producing and vice versa..

@Angen not sure what you mean? Can't you call it when you display the message ?

Wed, Sep 9, 5:59 PM
Freagarach added inline comments to D2661: Get attack effects from JSON..
Wed, Sep 9, 5:58 PM
Freagarach added a comment to D2652: Do not allow upgrading when entity is producing and vice versa..

(Also maybe add a test for this behaviour?)

Wed, Sep 9, 5:55 PM
Angen added a comment to D2652: Do not allow upgrading when entity is producing and vice versa..
In D2652#131397, @Stan wrote:

Can we support playing a sound ?

Wed, Sep 9, 5:49 PM
Stan added a comment to D2652: Do not allow upgrading when entity is producing and vice versa..

Can we support playing a sound ?

Wed, Sep 9, 5:44 PM
Freagarach added inline comments to D2652: Do not allow upgrading when entity is producing and vice versa..
Wed, Sep 9, 4:34 PM
Angen requested changes to D2161: Also account for elevation for melee units..

Right now,
range queries for melee units perfectly matches their range attacks,
range queries for ranged units does not because they use the same non-parabolic query as rest of units.
May be because performance or because no-one bothered to give them parabolic queries. I believe there is ticket for that. Anyway that causes ranged units to get targets which are actually out of range or not get targets that would be in parabolic range.

Wed, Sep 9, 4:27 PM
Angen accepted D2334: Fix restartColorFade being passed too many arguments.

missed in https://code.wildfiregames.com/rP14702

Wed, Sep 9, 4:12 PM
Angen added a reviewer for D2723: Add support for hotloading of sound-related files: Restricted Owners Package.
Wed, Sep 9, 3:57 PM
Angen added inline comments to D2961: Fix issues in RangeManager following rP23769.
Wed, Sep 9, 3:49 PM
Angen added inline comments to D2980: Get dropsite resources from simulation..
Wed, Sep 9, 3:41 PM
Angen requested changes to D2980: Get dropsite resources from simulation..
Wed, Sep 9, 3:37 PM
Stan updated the Trac tickets for D1739: Introduce a replacement container for EntityMap, std::map, std::unordered_map and boost::unordered_map.
Wed, Sep 9, 1:13 PM
Stan added a comment to rP23592: Add a C++ interface for CCmpAttack..

Now D2998

Wed, Sep 9, 11:44 AM
Angen updated the summary of D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Wed, Sep 9, 10:48 AM
Angen added a comment to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.

no, thats just my english, thank you

Wed, Sep 9, 10:48 AM
Nescio added a comment to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.

loose

Is this some kind of sociolect? I'm asking because I've also observed other team members write ‘loose’ (i.e. set free, release) instead of ‘lose’ (i.e. be deprived of, cease to have) more than once.

Wed, Sep 9, 10:46 AM
gameboy added a comment to D2382: [WIP] - Building Sockets..

Has the ghost been cleared?

Wed, Sep 9, 10:22 AM
Angen added inline comments to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Wed, Sep 9, 8:59 AM
Stan added inline comments to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Wed, Sep 9, 8:46 AM
Angen added inline comments to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Wed, Sep 9, 8:34 AM
autobuild committed rP24030: [Windows] Automated build..
[Windows] Automated build.
Wed, Sep 9, 7:27 AM

Tue, Sep 8

Angen planned changes to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.

dummy
(a+b)*(a+b) != a*a + b*b

Tue, Sep 8, 10:58 PM
Angen updated the diff for D2652: Do not allow upgrading when entity is producing and vice versa..

let jenkins complain about intendation

Tue, Sep 8, 10:43 PM
Angen updated the test plan for D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Tue, Sep 8, 10:39 PM
Angen updated the diff for D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Tue, Sep 8, 10:37 PM
Angen planned changes to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Tue, Sep 8, 10:30 PM
Vulcan added a comment to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.

Successful build - Chance fights ever on the side of the prudent.

Tue, Sep 8, 10:30 PM
Angen updated the diff for D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.

use correct elevation range calculation

Tue, Sep 8, 10:24 PM