Rebased on top of D2768.

Build failure - The Moirai have given mortals hearts that can endure.

(They _are_ in the game already.)

@badosu, @borg-, @ValihrAnt, any opinions on the proposed values?
For comparison:

pierce damage / reload time = damage per second ; maximum range
champion archer (unchange): 6.5 / 0.5 = 13 ; 76
current champion crossbowman: 6.5 / 3 = 2.2 ; 76
proposed champion crossbowman: 40 / 3 = 13.3 ; 60

I think having their dps be about the same as archers is fine for now. When they are in the game we will be able to see how their lower fire rate plays out and adjust accordingly from there.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Build was aborted.

*weeooweeoo* It's the idiot police and I'm under arrest *weeooweeoo*

My build-osx-libs is upstreamed

Buildings giving loot is rarely a factor due to buildings generally being destroyed by siege weapons.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

More include

Fix for the sharedArrayRefs thing included in here. Specify MS15.

Successful build - Chance fights ever on the side of the prudent.

Can you request review?

Fix warnings about non virtual destructor in GUIProxy.h

Successful build - Chance fights ever on the side of the prudent.

@badosu, @borg-, @ValihrAnt, any opinions on the proposed values?
For comparison:

 pierce damage / reload time = damage per second ; maximum range
champion archer (unchange):     6.5 / 0.5 = 13   ; 76
current champion crossbowman:   6.5 / 3   =  2.2 ; 76
proposed champion crossbowman: 40   / 3   = 13.3 ; 60

@ValihrAnt, any opinions on this?

• remove structure <Loot/xp>, per @ValihrAnt

Should changes be requested? Or should we go with this first?

I'm happy either way. Though, I think it would be better to remove xp from buildings entirely rather than increase it, due to how rarely it comes into play.

Successful build - Chance fights ever on the side of the prudent.

FastRand() behind defines as noted by Stan

Successful build - Chance fights ever on the side of the prudent.

Should changes be requested? Or should we go with this first?

Correct regex

It's an improvement.

One could say this patch does two things:

• remove experience from structures that are unable to shoot projectiles
• make experience proportional to health for structures that can attack

The latter is a bit simplistic, since structures can have quite different resistance and attack values.

Could probably even increase the amount of xp by multiple times,

I opted for 10% to stay close to the current values, however, it could be changed to 20% or some other number, if you think that's better.
Or we could just remove experience from all structures altogether.

In D2768#137548, @Angen wrote:

Is there strong reason why it cannot have h and cpp parts?

Compilation-time efficiency. As GUIProxy is templated, all instantiations must have access to the definitions. I could put them directly in the .h, as is usually done, but that would require including more headers in that file, and that's bad.
However, since all usages of GUIProxy are explicit instantiations, I can just put the definitions in a separate "template" file, and include that in TUs that need it. This is basically a ".tpp" or ".ipp" file, as talked about here. It's relatively common. I didn't name it .tpp or .ipp as that would make it less recognisable as a c++ file, but I added _impl for that.

Why is source/gui/Scripting/JSInterface_GUIProxy_impl.h h file ?
Is there strong reason why it cannot have h and cpp parts?

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Failed to realize that SoundGroup.cpp still needed rand.h

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Fix tests. In the spirit of coherence, I'm also moving the class to SoundGroup.cpp as its only user, a refactoring of randomness usage should decide what to do with it later.

(Elephantine map was broken hereafter: D3122.)

Successfully builds on my end :)

Build failure - The Moirai have given mortals hearts that can endure.

Same of @ValihrAnt .

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

It's an interesting change and will be good to see how it plays out in multiplayer.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

It's an improvement. While it's rare that any unit which benefits from experience will attack buildings it still happens occasionally. Could probably even increase the amount of xp by multiple times, because players will only try to destroy buildings with units when they have an overwhelming mass, so each unit getting an average of 5 experience for destroying a fortress seems very negligible.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Vlad's comments.

Successful build - Chance fights ever on the side of the prudent.

This ought to make linux and macos compile. I'm trying with C++11, we'll see.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Fix compilation and remove some additional proxy changes that I ought to do after the migration, not within.

Fix typo. Hopefully runs.

I don't think it is necessary to create new models. as gaul and brit are extremely poor in water maps, putting trireme early can be interesting. we can lower the attack a bit (original design idea), or even increase the cost of the gaul / brit / (iber too?) triremes in proportion to their largest hp.

Meh

Fix typo noticed by @Angen

Build failure - The Moirai have given mortals hearts that can endure.