Page MenuHomeWildfire Games
Feed All Stories

Fri, Nov 20

wraitii updated the diff for D1781: Fix lobby chat performance issue..

Rebased on top of D2768.

Fri, Nov 20, 4:55 PM
Vulcan added a comment to D3125: Fix broken assertion in rP24217.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Nov 20, 4:43 PM
Freagarach added a comment to D2886: [gameplay] introduce crossbowman templates.

(They _are_ in the game already.)

Fri, Nov 20, 4:41 PM
ValihrAnt added a comment to D2886: [gameplay] introduce crossbowman templates.

@badosu, @borg-, @ValihrAnt, any opinions on the proposed values?
For comparison:

pierce damage / reload time = damage per second ; maximum range
champion archer (unchange): 6.5 / 0.5 = 13 ; 76
current champion crossbowman: 6.5 / 3 = 2.2 ; 76
proposed champion crossbowman: 40 / 3 = 13.3 ; 60

I think having their dps be about the same as archers is fine for now. When they are in the game we will be able to see how their lower fire rate plays out and adjust accordingly from there.

Fri, Nov 20, 4:38 PM
Freagarach added inline comments to D3124: Switch to C++14.
Fri, Nov 20, 4:38 PM
wraitii requested review of D3124: Switch to C++14.
Fri, Nov 20, 4:34 PM
wraitii committed rP24223: Fix broken assertion in rP24217.
Fix broken assertion in rP24217
Fri, Nov 20, 4:31 PM
wraitii closed D3125: Fix broken assertion in rP24217.
Fri, Nov 20, 4:31 PM
Vulcan added a comment to D3124: Switch to C++14.

Successful build - Chance fights ever on the side of the prudent.

Fri, Nov 20, 4:28 PM
Vulcan requested changes to D3124: Switch to C++14.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Nov 20, 4:11 PM
Vulcan resigned from D3124: Switch to C++14.

Successful build - Chance fights ever on the side of the prudent.

Fri, Nov 20, 3:28 PM
Stan added inline comments to D3124: Switch to C++14.
Fri, Nov 20, 3:25 PM
Vulcan requested changes to D3124: Switch to C++14.

Build was aborted.

Fri, Nov 20, 3:23 PM
wraitii updated the diff for D3124: Switch to C++14.

*weeooweeoo* It's the idiot police and I'm under arrest *weeooweeoo*

Fri, Nov 20, 3:23 PM
wraitii updated the diff for D3124: Switch to C++14.

My build-osx-libs is upstreamed

Fri, Nov 20, 3:06 PM
wraitii requested review of D3124: Switch to C++14.
Fri, Nov 20, 2:54 PM
ValihrAnt accepted D2992: [gameplay] remove structure <Loot/xp>.

Buildings giving loot is rarely a factor due to buildings generally being destroyed by siege weapons.

Fri, Nov 20, 1:23 PM
Harbormaster failed to build B13837: rP24222: Fix no-PCH builds and checkrefs following rP24215 for rP24222: Fix no-PCH builds and checkrefs following rP24215!
Fri, Nov 20, 12:44 PM
wraitii committed rP24222: Fix no-PCH builds and checkrefs following rP24215.
Fix no-PCH builds and checkrefs following rP24215
Fri, Nov 20, 12:42 PM
wraitii closed D3123: Fix PCH and chekrefs following rP24215.
Fri, Nov 20, 12:42 PM
Vulcan requested changes to D613: Remove UniqueRange custom code in favour of unique_ptr.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Nov 20, 12:01 PM
Vulcan added a comment to D3123: Fix PCH and chekrefs following rP24215.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Nov 20, 11:52 AM
Vulcan added a comment to D3115: [SM60] Build system changes.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Nov 20, 11:49 AM
Vulcan added a comment to D3123: Fix PCH and chekrefs following rP24215.

Successful build - Chance fights ever on the side of the prudent.

Fri, Nov 20, 11:32 AM
Vulcan added a comment to D3115: [SM60] Build system changes.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Nov 20, 11:01 AM
Nescio requested review of D2992: [gameplay] remove structure <Loot/xp>.
Fri, Nov 20, 10:50 AM
Vulcan added a comment to D3115: [SM60] Build system changes.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Nov 20, 10:49 AM
wraitii updated the diff for D3123: Fix PCH and chekrefs following rP24215.

More include

Fri, Nov 20, 10:47 AM
wraitii updated the diff for D3115: [SM60] Build system changes.

Fix for the sharedArrayRefs thing included in here. Specify MS15.

Fri, Nov 20, 10:44 AM
Vulcan added a comment to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Successful build - Chance fights ever on the side of the prudent.

Fri, Nov 20, 10:42 AM
Stan added a comment to D2992: [gameplay] remove structure <Loot/xp>.

Can you request review?

Fri, Nov 20, 10:39 AM
wraitii updated the diff for D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Fix warnings about non virtual destructor in GUIProxy.h

Fri, Nov 20, 10:31 AM
Vulcan added a comment to D2992: [gameplay] remove structure <Loot/xp>.

Successful build - Chance fights ever on the side of the prudent.

Fri, Nov 20, 10:31 AM
Nescio updated subscribers of D2886: [gameplay] introduce crossbowman templates.

@badosu, @borg-, @ValihrAnt, any opinions on the proposed values?
For comparison:

 pierce damage / reload time = damage per second ; maximum range
champion archer (unchange):     6.5 / 0.5 = 13   ; 76
current champion crossbowman:   6.5 / 3   =  2.2 ; 76
proposed champion crossbowman: 40   / 3   = 13.3 ; 60
Fri, Nov 20, 10:30 AM
Nescio updated subscribers of D2950: [gameplay] keep population for houses.

@ValihrAnt, any opinions on this?

Fri, Nov 20, 10:25 AM
Nescio updated the diff for D2992: [gameplay] remove structure <Loot/xp>.
Fri, Nov 20, 10:24 AM
ValihrAnt added a comment to D2992: [gameplay] remove structure <Loot/xp>.

Should changes be requested? Or should we go with this first?

I'm happy either way. Though, I think it would be better to remove xp from buildings entirely rather than increase it, due to how rarely it comes into play.

Fri, Nov 20, 10:18 AM
wraitii retitled D3123: Fix PCH and chekrefs following rP24215 from Fix PCH and chekrefs following rP24215 D2814 / rP24215 broke PCH builds, and broke checkrefs by including a GUI page not at GUI root. This is supported by the game, seems rather convenient to me as it moves pages where they are used, and is... to Fix PCH and chekrefs following rP24215.
Fri, Nov 20, 9:55 AM
Vulcan added a comment to D3107: Update random_shuffle usage for C++17.

Successful build - Chance fights ever on the side of the prudent.

Fri, Nov 20, 9:43 AM
autobuild committed rP24221: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Fri, Nov 20, 9:40 AM
wraitii updated the diff for D3107: Update random_shuffle usage for C++17.

FastRand() behind defines as noted by Stan

Fri, Nov 20, 9:32 AM
wraitii committed rP24220: Fix .dae files with Windows paths inside..
Fix .dae files with Windows paths inside.
Fri, Nov 20, 9:27 AM
wraitii closed D3120: Fix .dae files with paths inside..
Fri, Nov 20, 9:27 AM
Vulcan added a comment to D3123: Fix PCH and chekrefs following rP24215.

Successful build - Chance fights ever on the side of the prudent.

Fri, Nov 20, 9:24 AM
Stan added inline comments to D2849: tools/entity/checkref perl to python.
Fri, Nov 20, 9:22 AM
Stan added a comment to D2992: [gameplay] remove structure <Loot/xp>.

Should changes be requested?

Fri, Nov 20, 9:17 AM
wraitii updated the diff for D3123: Fix PCH and chekrefs following rP24215.

Correct regex

Fri, Nov 20, 9:17 AM
Nescio added a comment to D2992: [gameplay] remove structure <Loot/xp>.

It's an improvement.

One could say this patch does two things:

  • remove experience from structures that are unable to shoot projectiles
  • make experience proportional to health for structures that can attack

The latter is a bit simplistic, since structures can have quite different resistance and attack values.

Could probably even increase the amount of xp by multiple times,

I opted for 10% to stay close to the current values, however, it could be changed to 20% or some other number, if you think that's better.
Or we could just remove experience from all structures altogether.

Fri, Nov 20, 9:15 AM
wraitii added inline comments to D3115: [SM60] Build system changes.
Fri, Nov 20, 9:10 AM
wraitii added a comment to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..
In D2768#137548, @Angen wrote:

Is there strong reason why it cannot have h and cpp parts?

Compilation-time efficiency. As GUIProxy is templated, all instantiations must have access to the definitions. I could put them directly in the .h, as is usually done, but that would require including more headers in that file, and that's bad.
However, since all usages of GUIProxy are explicit instantiations, I can just put the definitions in a separate "template" file, and include that in TUs that need it. This is basically a ".tpp" or ".ipp" file, as talked about here. It's relatively common. I didn't name it .tpp or .ipp as that would make it less recognisable as a c++ file, but I added _impl for that.

Fri, Nov 20, 9:06 AM
Stan added inline comments to D3115: [SM60] Build system changes.
Fri, Nov 20, 9:02 AM
wraitii requested review of D3123: Fix PCH and chekrefs following rP24215.
Fri, Nov 20, 8:56 AM
Angen added a comment to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Why is source/gui/Scripting/JSInterface_GUIProxy_impl.h h file ?
Is there strong reason why it cannot have h and cpp parts?

Fri, Nov 20, 8:38 AM
Vulcan added a comment to D3107: Update random_shuffle usage for C++17.

Successful build - Chance fights ever on the side of the prudent.

Fri, Nov 20, 8:34 AM
Vulcan added a comment to D3107: Update random_shuffle usage for C++17.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Nov 20, 8:31 AM
Freagarach requested review of D3122: Fixes after rP24216..
Fri, Nov 20, 8:30 AM
wraitii updated the diff for D3107: Update random_shuffle usage for C++17.

Failed to realize that SoundGroup.cpp still needed rand.h

Fri, Nov 20, 8:29 AM
Vulcan added a comment to D3107: Update random_shuffle usage for C++17.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Nov 20, 8:25 AM
Vulcan added a comment to D3107: Update random_shuffle usage for C++17.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Nov 20, 8:23 AM
wraitii updated the diff for D3107: Update random_shuffle usage for C++17.

Fix tests. In the spirit of coherence, I'm also moving the class to SoundGroup.cpp as its only user, a refactoring of randomness usage should decide what to do with it later.

Fri, Nov 20, 8:22 AM
Freagarach added a comment to rP24216: Move civ-specific templates to subfolders..

(Elephantine map was broken hereafter: D3122.)

Fri, Nov 20, 8:05 AM
autobuild committed rP24219: [Windows] Automated build..
[Windows] Automated build.
Fri, Nov 20, 7:43 AM
Freagarach added inline comments to D3115: [SM60] Build system changes.
Fri, Nov 20, 7:32 AM
Freagarach added a comment to D3115: [SM60] Build system changes.

Successfully builds on my end :)

Fri, Nov 20, 7:30 AM

Thu, Nov 19

Vulcan added a comment to D3107: Update random_shuffle usage for C++17.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Nov 19, 11:40 PM
borg- accepted D2992: [gameplay] remove structure <Loot/xp>.

Even thought of @ValihrAnt .

Thu, Nov 19, 10:38 PM
Vulcan added a comment to D3115: [SM60] Build system changes.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Nov 19, 10:37 PM
Vulcan added a comment to D3107: Update random_shuffle usage for C++17.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Nov 19, 9:42 PM
Vulcan added a comment to D3107: Update random_shuffle usage for C++17.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Nov 19, 9:39 PM
Vulcan added a comment to D3116: [SM60] API changes.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Nov 19, 9:39 PM
Vulcan added a comment to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Successful build - Chance fights ever on the side of the prudent.

Thu, Nov 19, 9:36 PM
ValihrAnt accepted D1762: [gameplay] give Fortress a territory root.

It's an interesting change and will be good to see how it plays out in multiplayer.

Thu, Nov 19, 9:32 PM
Vulcan added a comment to D2959: deprecate template_unit_cavalry_melee.xml and *_ranged.xml.

Successful build - Chance fights ever on the side of the prudent.

Thu, Nov 19, 9:25 PM
Vulcan added a comment to D3115: [SM60] Build system changes.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Nov 19, 9:24 PM
Vulcan added a comment to D3109: Fix tab buttons not playing sounds.

Successful build - Chance fights ever on the side of the prudent.

Thu, Nov 19, 9:17 PM
ValihrAnt accepted D2992: [gameplay] remove structure <Loot/xp>.

It's an improvement. While it's rare that any unit which benefits from experience will attack buildings it still happens occasionally. Could probably even increase the amount of xp by multiple times, because players will only try to destroy buildings with units when they have an overwhelming mass, so each unit getting an average of 5 experience for destroying a fortress seems very negligible.

Thu, Nov 19, 9:14 PM
Vulcan added a comment to D3115: [SM60] Build system changes.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Nov 19, 9:11 PM
Vulcan added a comment to D3109: Fix tab buttons not playing sounds.

Successful build - Chance fights ever on the side of the prudent.

Thu, Nov 19, 9:09 PM
Vulcan added a comment to D3116: [SM60] API changes.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Nov 19, 9:07 PM
Vulcan added a comment to D2646: Remove special Animal state..

Successful build - Chance fights ever on the side of the prudent.

Thu, Nov 19, 8:58 PM
wraitii updated the diff for D3107: Update random_shuffle usage for C++17.

Vlad's comments.

Thu, Nov 19, 8:56 PM
wraitii added inline comments to D3107: Update random_shuffle usage for C++17.
Thu, Nov 19, 8:51 PM
Vulcan added a comment to D3109: Fix tab buttons not playing sounds.

Successful build - Chance fights ever on the side of the prudent.

Thu, Nov 19, 8:49 PM
wraitii updated the diff for D3115: [SM60] Build system changes.

This ought to make linux and macos compile. I'm trying with C++11, we'll see.

Thu, Nov 19, 8:46 PM
Vulcan added a comment to D3116: [SM60] API changes.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Nov 19, 8:46 PM
Vulcan added a comment to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Successful build - Chance fights ever on the side of the prudent.

Thu, Nov 19, 8:45 PM
Vulcan added a comment to D3109: Fix tab buttons not playing sounds.

Successful build - Chance fights ever on the side of the prudent.

Thu, Nov 19, 8:39 PM
wraitii updated the diff for D3116: [SM60] API changes.

Fix compilation and remove some additional proxy changes that I ought to do after the migration, not within.

Thu, Nov 19, 8:37 PM
wraitii updated the diff for D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Fix typo. Hopefully runs.

Thu, Nov 19, 8:08 PM
Nescio updated the diff for D2959: deprecate template_unit_cavalry_melee.xml and *_ranged.xml.
Thu, Nov 19, 8:00 PM
borg- added a comment to D2996: [gameplay] Move bireme to village phase and balance..

I don't think it is necessary to create new models. as gaul and brit are extremely poor in water maps, putting trireme early can be interesting. we can lower the attack a bit (original design idea), or even increase the value of the gaul / brit / (iber too?) triremes in proportion to their largest hp.

Thu, Nov 19, 7:53 PM
Stan updated the diff for D3109: Fix tab buttons not playing sounds.

Meh

Thu, Nov 19, 7:32 PM
Angen added inline comments to D3109: Fix tab buttons not playing sounds.
Thu, Nov 19, 7:30 PM
Angen added inline comments to D2646: Remove special Animal state..
Thu, Nov 19, 7:26 PM
Stan updated the diff for D3109: Fix tab buttons not playing sounds.

Fix typo noticed by @Angen

Thu, Nov 19, 7:24 PM
wraitii requested review of D3116: [SM60] API changes.
Thu, Nov 19, 7:23 PM
Vulcan added a comment to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Nov 19, 7:22 PM
wraitii requested review of D3115: [SM60] Build system changes.
Thu, Nov 19, 7:16 PM
Angen added inline comments to D3109: Fix tab buttons not playing sounds.
Thu, Nov 19, 7:16 PM
Freagarach planned changes to D2646: Remove special Animal state..
Thu, Nov 19, 7:15 PM