- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 13 2021
- Succeeded.
- No oddities found.
- Grepping for cpuLighting didn't find any occurences ;)
I would say "Intimidation" was a more interesting aura.
I can ping you if I find some time/motivation for this. I want to merge D2646 first anyway ;)
In D3344#148545, @borg- wrote:I prefer only wood cost, 450.
Why? It is a hall for princes, so it needs some blingbling ;)
Build is green
Build is green
Icons after D3320.
Notes
For me the bonus is good (use the same as my mod), not dangerous for balance and has a historical accuracy, so I accept, but we need something for brit.
I still think the two techs together are very strong. I would just stay with "Encouragement".
Cost reduction for ram is fair
Standardizing the loot is fair.
Shouldn't the xp loot of ram and siege_tower be bigger since in theory you need fight with the soldiers inside?
Fireraiser should be included?
Rebase
Thanks for the feedback! I have made a few of the changes and left a question about the last remaining ones.
Fix minor C++ issues around type and unique_ptr creation
Is it good now?
Build is green
Should h files get copyright headers?
This patch makes the code much cleaner at least.
Fixes notes.
Jan 12 2021
Well technically it's the assembly of "princes" so heroes and warchiefs make sense maybe even standard bearers, not so much naked fanatics
I don't have a strong opinion on that. Bit more in favor of the patch. It seems to make sense in both buildings, more to cc.
Choose between the two I choose in cc.
That said, the patch has my yes.
I prefer only wood cost, 450. Make Sense add infantry champions?
I am in favor. It doesn't make historical sense or realism but for gameplay it is fair and it also avoids a possible snowball on maps with a lot of hunting (elephants).
Ranged units are supposed to die quickly and avoid melee, so I think they should no longer get resistance increases, but I'm unsure whether to include it in this patch.
In D2830#148457, @Feldfeld wrote:Well probably not actually otherwise the deprecated functions placeholder wouldn't be needed. Plus I just reread the ticket so indeed there is no equivalence. I'll adjust the values if necessary
Animals belong on the countryside, so I don't think adding a city requirement makes much sense.
If it's to be done, you can do it simply by inserting a line into template_unit_fauna_herd_domestic_cattle.xml.
Adjusted values in previously deprecated functions
Build is green
Ah, okay :) (D3320)
In rP24566#47243, @Freagarach wrote:Those values were not changed. (Otherwise I would have waited for a balancing review.)
I like the idea of %10% attack and increase accuracy, but a nerf for ranged units like 5% / 10% is necessary.
For me a value addition makes a lot more sense than 0 costs.
Hi @s0600204 ,
when unit with gaia civ has required phase, it is not in correct row.
Does not happen in a23b.
Those values were not changed. (Otherwise I would have waited for a balancing review.)
@Nescio gaul has a cost standard of only wood for this type of construction, I don't see any sense in stone and metal.
(Maps in folders also allows for easier distribution. #5984)
Well probably not actually otherwise the deprecated functions placeholder wouldn't be needed. Plus I just reread the ticket so indeed there is no equivalence. I'll adjust the values if necessary
If I recall from my whacky memories, createObjectGroupsDeprecated is equivalent to a createObjectGroups call with a retryFactor of 0, is that correct?
I guess we could add an integration_tests folder? I'm also really looking forward to hearing about @Krinkle's POC with QUnit
Is only an issue when resizing the window while in gamesetup.
So it is still kind of a bug but not as severe as thought.
Build is green
- Nice change.
- Incomplete (I'll change the map), but almost.
Build is green
- iber monument sounds, per @Freagarach
- restore foundation resistance, per @Freagarach
Build is green