In D3575#156310, @Stan wrote:Well your patch does it anyway :)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Feb 17 2021
Feb 17 2021
Successful build - Chance fights ever on the side of the prudent.
Well your patch does it anyway :)
And not for all only for x86_x64::Family() == 6 if IA32 is detected
In D3575#156260, @Stan wrote:Hey thanks for the patch ! You might want to move that into the check for IsHyperThreading capable.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
(with stan's permission).
I feel like you might have an easier time with "Enable"/"Disable" instead of Toggle, but otherwise this looks OK :)
Jeez we've forgotten a lot of stuff in messages.json . Refs D3535 (should be merged independently to close the revision)
Should be merged once A24 is released :)
Feb 16 2021
Feb 16 2021
Hey thanks for the patch ! You might want to move that into the check for IsHyperThreading capable.
I agree, but that is not what the code says ;)
In D3113#151609, @Freagarach wrote:
- The projectile tries to hit an invulnerable target next to a vulnerable -> The former plays the blocked sound whilst the latter plays the hit sound.
so if they dont use parabolic query, then query they use is wrong compared to the range checks in js
- Added nickname to credits
Can you add yourself to the credits? :)
Silier added a reviewer for D3574: Prevent using privileged ports on *nix from the GUI: Restricted Owners Package.
- Added TODO
For me it's A25 material. I will ask maintainers about it but so far the people I asked were really mitigated about it.
For my end, I think distributions/maintainers are free to patch if they want to (this seems something they could be concerned with). Not planning to merge this for A24.
Could you add tests for this bug? (So that we prevent regressions ;)
Ofc not for A24.
any news or decision?
i18n issues: Spanish manual & gamesetup tips text.
I no longer get error codes for Spanish (or any other language) when I open the "Manual".
D3520 says it's complete
Freagarach added inline comments to D3573: [A24] i18n issues: Spanish manual & gamesetup tips text..
This is a correct fix for the issue at hand. As written in the updated summary, we probably should check that there are no variant name collisions (not that having _no_ name at all works still), but that's further work.
Obviously it won't work if the game compiles on Windows with multiple compilers.
Sorry, what do you call the manifest file?
Defining it in premake might be a good idea. I could set those define there yes I suppose.
True and we don't explicitly query y earlier. So it is indeed okay.
Shouldn't some/most/all of this be in the manifest file? In that case, you can set these stuff in premake.
Feb 15 2021
Feb 15 2021
Imarok added a comment to D3569: The `SetCameraTarget` script function should not change the orientation.
In D3569#156168, @Freagarach wrote:Nice :)
Just one question, shouldn't you use the function above?
Freagarach added a comment to D3569: The `SetCameraTarget` script function should not change the orientation.
Just one question, shouldn't you use the function above?
sorry then
Imarok added a comment to D3569: The `SetCameraTarget` script function should not change the orientation.
In D3569#156102, @Freagarach wrote:Are there more occurences that use this function?
"Rebase Will commit after release and updating to A25"
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Rebase Will commit after release and updating to A25
Nice, thanks for the patch
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Refs: #4763
Refs: #4763
Silier added a comment to rP24728: Hide ip and port from users until they want to join, add optional password.
Fixes: #4763
Langbart added a comment to D3569: The `SetCameraTarget` script function should not change the orientation.
Rotate the view and change the zoom. Then click on the attack notification of a building or a dead unit. The orientation and zoom should not change.
Yeah, although we usually use full context, e.g. =9999 ;) Or any arbitrary high number.
In D3570#156099, @Freagarach wrote:Thanks for the patch! You don't need to modify the *.pot files, since that will be automatically generated.
Also reference/ needs to be added.
it looks like translatable attribute catafaulque bonuses is not picked up by translation scripts #6026
Freagarach added a comment to D3569: The `SetCameraTarget` script function should not change the orientation.
One thing I dislike is the target/position thing. IMHO A target is an entity and not a location. But out of scope ;)
Stan added a comment to D3569: The `SetCameraTarget` script function should not change the orientation.
Seems to be only three
Freagarach added a comment to D3569: The `SetCameraTarget` script function should not change the orientation.
Are there more occurences that use this function?
Thanks for the patch! You don't need to modify the *.pot files, since that will be automatically generated.
Also, could you upload your patch with context, please?
Feb 14 2021
Feb 14 2021
Imarok requested review of D3569: The `SetCameraTarget` script function should not change the orientation.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
In D3566#156068, @Imarok wrote:In D3566#155958, @Langbart wrote:Yes, it works. Now its the same for when someone attacks my units. Thanks for noticing and fixing it.
Clicking on the notification takes me to the action hotspot, it changes my camera perspective to the way it was when spawning into the game, if you never change the camera perspective or you press "R" (camera.reset) before clicking on the notification, you won't notice it. It is the same when some of my units are attacked.Haven't noticed any bad effects otherwise.
Hmm, Good point about the change of the camera perspective. Wanna create a ticket for that?
In D3566#155958, @Langbart wrote:Yes, it works. Now its the same for when someone attacks my units. Thanks for noticing and fixing it.
Clicking on the notification takes me to the action hotspot, it changes my camera perspective to the way it was when spawning into the game, if you never change the camera perspective or you press "R" (camera.reset) before clicking on the notification, you won't notice it. It is the same when some of my units are attacked.Haven't noticed any bad effects otherwise.
Successful build - Chance fights ever on the side of the prudent.
- purge trailing .0 from <Projectile> speed, spread, and gravity lines
Successful build - Chance fights ever on the side of the prudent.
- animal attack range
Wildfire Games ยท Phabricator