Irrelevant.
What if someone writes !Siege into classes.
Then it will break
Feed All Stories
Jun 30 2021
Jun 30 2021
Silier added a comment to D4184: Fix PetraAI building a lot of siege and not using it..
Freagarach added a comment to D4184: Fix PetraAI building a lot of siege and not using it..
Because we try to match a more general condition (Siege) on a more specific class (Siege+Melee).
So MatchesClassList _was_ working. This condition checks string presence, so that will work.
Silier added a comment to D4184: Fix PetraAI building a lot of siege and not using it..
So you are trying to match .classes from untistats.
But there are + variants and for that reason even this conditions will not work correctly at all.
I mean it will for now but just by the luck.
Damn I should have seen it.
Silier added a comment to D4184: Fix PetraAI building a lot of siege and not using it..
But why was Matchclasslist not working?
It is supposed to do the same as the conditions in if.
Its or siege or the rest classes.
Vulcan added a comment to D4184: Fix PetraAI building a lot of siege and not using it..
Successful build - Chance fights ever on the side of the prudent.
Vulcan added a comment to D4184: Fix PetraAI building a lot of siege and not using it..
Successful build - Chance fights ever on the side of the prudent.
Freagarach updated the diff for D4184: Fix PetraAI building a lot of siege and not using it..
Siege was built in the wrong queue.
Freagarach requested review of D4184: Fix PetraAI building a lot of siege and not using it..
Freagarach added a comment to rP25584: Improve support for classes in PetraAI..
D4184, but there is more, since she keeps constructing siege without using it.
autobuild committed rP25817: [Windows] Automated build..
[Windows] Automated build.
Jun 29 2021
Jun 29 2021
Move wild lake biome specific entities to a json file like hellas.
Freagarach added inline comments to rP25584: Improve support for classes in PetraAI..
Fix unicode build for Atlas on OpenSuse.
Freagarach added a comment to rP25584: Improve support for classes in PetraAI..
Either causes or exposes https://wildfiregames.com/forum/topic/45178-a25-svn-version-25810-not-playable/.
I guess a concern would be in place.
Give picking up treasures back its sound.
Don't show turreted entities as idle.
Freagarach added a comment to D4180: Give picking up treasures a sound..
Well, ideally not, I guess, but for now, yes.
Good change.
Freagarach added a comment to rP25216: Move function to perform trade to substate..
(May or may not be worth a concern.)
My concern is fixed in rP25811.
Jun 28 2021
Jun 28 2021
[i18n] Updated POT and PO files.
Jun 26 2021
Jun 26 2021
Imarok added inline comments to D4183: Fix rare crash when opening dropdowns..
Vulcan added a comment to D4183: Fix rare crash when opening dropdowns..
Successful build - Chance fights ever on the side of the prudent.
wraitii published D4183: Fix rare crash when opening dropdowns. for review.
wraitii published D4182: Fix gamesetup crash when Daytime resets. for review.
Fix incorrect comment/default parameter introduced in rP25772
wraitii accepted D4178: Fix Atlas build on OpenSuse.
Seems to work fine. On mac, we compile with --enable-unicode and I suspect most distros do too. OpenSUSE might well be an exception.
Ceres added a comment to D4179: Don't show turreted entities as idle..
@wraitii
For my personal education: What is RB?
Langbart added a comment to D4180: Give picking up treasures a sound..
Tested it only with a woman and a soldier on the Median Oases(2) map for the Persian civilization and I got the sound when clicking on the treasure.
PS: The actual act of picking up the treasure makes no sound, only when I command the person via mouse to pick up the treasure is a sound omitted. That's how it should be, right?
wraitii added a comment to D3930: [Gameplay] Make Athenian Marines and Merc Archers accessible from the Town Phase and in the Barrack.
I almost merged this one but ended up being unsure how people actually wanted it to look. Tech? No tech? Which case should it go in? Which building?
wraitii added a comment to D4176: Fixup rP25772.
Added some detail. Comment & default values are invalid for the function as it ended up being
wraitii updated the summary of D4176: Fixup rP25772.
wraitii added a comment to D4179: Don't show turreted entities as idle..
Mh, this actually seems annoying enough to me that we might want to RB it.
Langbart requested review of D4181: Do not require restart when chaning `Background pause` option.
s0600204 updated the Trac tickets for D3646: Debundle Valgrind and make it optional.
Jun 25 2021
Jun 25 2021
[i18n] Updated POT and PO files.
Ceres added a comment to D4179: Don't show turreted entities as idle..
Is there anything to be changed with regard to this warning?
Jun 24 2021
Jun 24 2021
Freagarach requested changes to D2772: Prevent Upgrading units from moving.
Taking it out of the queue, but I might take this over some day (TM).
Freagarach added a comment to D4123: Fix some gaia units having incorrect players.
For fauna: I guess, yes. Though you can also train e.g. zebu?
Flora: Certainly, they should be owned by GAIA.
Ruins: Not sure, for those can be player owned?
Freagarach published D4180: Give picking up treasures a sound. for review.
Freagarach published D4179: Don't show turreted entities as idle. for review.
chrstgtr updated subscribers of D3930: [Gameplay] Make Athenian Marines and Merc Archers accessible from the Town Phase and in the Barrack.
I was asked by @Palaiologos about this and realized that we forgot to implement this popular patch. I still support it.
Jun 22 2021
Jun 22 2021
nani added inline comments to D3243: Gamesetup cleanup - Separate Game Settings from the GUI Gamesetup.
nani awarded D3243: Gamesetup cleanup - Separate Game Settings from the GUI Gamesetup a Like token.
Vulcan added a comment to D3998: [PetraAI] - Implement an emergency mode in case of huge losses..
Successful build - Chance fights ever on the side of the prudent.
Vulcan added a comment to D3998: [PetraAI] - Implement an emergency mode in case of huge losses..
Successful build - Chance fights ever on the side of the prudent.
JCWasmx86 updated the diff for D3998: [PetraAI] - Implement an emergency mode in case of huge losses..
JCWasmx86 updated the diff for D3998: [PetraAI] - Implement an emergency mode in case of huge losses..
-Fixed bug, when the collect point is unreachable, all units try forever to go to the point
-Ships now don't count, if they can't reach a collect point
-If defensive+cooperative: If all neutrality requests were accepted and at least territory root is still available, then the state of emergency is lifted.
Freagarach updated subscribers of D3958: Add an extra button for seeing the summary page when quitting a session.
Jun 21 2021
Jun 21 2021
Langbart added a comment to D3958: Add an extra button for seeing the summary page when quitting a session.
Vulcan added a comment to D3958: Add an extra button for seeing the summary page when quitting a session.
Successful build - Chance fights ever on the side of the prudent.
Schweini added a comment to D3958: Add an extra button for seeing the summary page when quitting a session.
@Langbart, if you could test the changes I just made, that would be great!
I sadly don't have 2 machines ready right now (or could I just open up another account ?), so I can't test it, but I think it's right.
Schweini updated the diff for D3958: Add an extra button for seeing the summary page when quitting a session.
- Fix bug reported by @Langbart
Freagarach updated subscribers of rP25151: Refuse to serialize NaN values..
I just had a discussion with @elexis, it would be good if we can't crash from JS (might have been a thing in the past). So it would be nice if we could reliably serialise NaN and error, or just don't serialise but do error.
[i18n] Updated POT and PO files.
Freagarach added a comment to rP25381: Enable production entities to autoqueue..
I agree, but the concern seemed to be a matter of preference, so hence the way I asked the question. But I guess it is not enough, since @nani did not resign from this commit yet.
Langbart added a comment to D3958: Add an extra button for seeing the summary page when quitting a session.
I have noticed a problem in the lobby.
If I have two instances and the one instance that joined the game resigns first and presses "Quit", it is transported to the main page and not the lobby page.
chrstgtr added a comment to D3994: [Gameplay] Expand Experience trickle to stables and elephant stables.
Too late for a25, but it probably makes sense to expand this to merc buildings, such as embassies, too.
Jun 20 2021
Jun 20 2021
vladislavbelov requested verification of rP25711: Implements configurable cascade shadows..
Fixed in rP25794.
nani added a comment to rP25381: Enable production entities to autoqueue..
Tried it, I think it behaves as it should now. As I said before, we could add some negative characteristics like a % extra time to train an unit or something similar but that can be added with ease in the next alpha if in this one we detect the function is too overpowered (personally I think is not, but I like it because I have to click less and thus don't get my wrist all work up, see https://en.wikipedia.org/wiki/Carpal_tunnel_syndrome )
Silier added a comment to D3719: GameSetup GUI cleanup - renaming & moving stuff around..
I agree with @nani
Silier added a comment to D4176: Fixup rP25772.
I know i don't write best summaries and test plans, but could it tell more than just pointing to the commit it is fixing?
Silier added a comment to rP25789: Update some MR map previews..
This removes the fancy mainland biome switch because it was the only map to do that and we lack the tools to automate it
To automate what exactly?
You mean it was only map to have multiple biomes or only map to actually have completed previewes for the biomes?
And you did not remove the switch at all, at least not in this patch.
You just removed art and I still don't understand why it was bad to have this there.
My concern was fixed in rP25804.
Freagarach added a comment to rP25381: Enable production entities to autoqueue..
@nani has the autoqueue been adapted enough to your liking?
Freagarach updated the summary of D4178: Fix Atlas build on OpenSuse.
Jun 19 2021
Jun 19 2021
Stan requested review of D4178: Fix Atlas build on OpenSuse.
nani added a comment to D3687: Color incompatible mods and add filter.
A commit changed the name of the class.
nani added a comment to D3719: GameSetup GUI cleanup - renaming & moving stuff around..
Why are the files names different from the class names? Makes search twice difficult.
Jun 18 2021
Jun 18 2021
Freagarach added a comment to rP24366: Add support for HAIKU detection by the SDL..
libsdl.cpp
../../../source/lib/external_libraries/libsdl.cpp: In function ‘const char* GetSDLSubsystem(SDL_Window*)’:
../../../source/lib/external_libraries/libsdl.cpp:89:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
89 | subsystem = "Haiku";
| ~~~~~~~~~~^~~~~~~~~
../../../source/lib/external_libraries/libsdl.cpp:92:2: note: here
92 | default:
| ^~~~~~~autobuild committed rP25808: [Windows] Automated build..
[Windows] Automated build.
[i18n] Updated POT and PO files.
autobuild committed rP25806: [Windows] Automated build..
[Windows] Automated build.
Jun 17 2021
Jun 17 2021
Fix hotloading making models disappear.
Fix serialisation crash when patrolling.
Freagarach requested review of D4177: Fix crash when patrolling in MP..
Freagarach raised a concern with rP24360: Make units wait a few seconds at waypoints during Patrol..
autobuild committed rP25803: [Windows] Automated build..
[Windows] Automated build.
Jun 16 2021
Jun 16 2021
Langbart added a comment to D4175: Fix hotloading making models disappear..
Just played the tutorial at rP25799 + D4175 and in the end all objects remained visible.
https://pasteall.org/media/1/1/11c4d7568a39cf0360620e119606b3f4.png
wraitii requested review of D4176: Fixup rP25772.
wraitii committed rP25802: Fix options occasionally thinking they've been modified when they haven't..
Fix options occasionally thinking they've been modified when they haven't.
wraitii committed rP25801: Reset the campaigns previews.
Reset the campaigns previews