Successful build - Chance fights ever on the side of the prudent.

version control fail.

Build failure - The Moirai have given mortals hearts that can endure.

Changed uint_32 types for vector indices to size_t. Supposedly the type should be std::vector<std::byte*>>::size_type, but I haven't been able to get that to work.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

More specific names and types, use for_each in CComponentDataHolder::ResetState.

In D3601#201827, @chrstgtr wrote:

I would personally just make it 1.25x each phase, but this works.

Relatedly, I think there should be a CC/colony cost reduction patch to try to encourage building CCs.

These were the values that @ValihrAnt used in his patch that worked well when I played it.

https://wildfiregames.com/forum/topic/68499-territory-mod/#comment-474946

I would personally just make it 1.25x each phase, but this works.

I particularly think that for p2 it's ok as it is now, sometimes it's even hard to notice just looking at the minimap. The problem in my opinion is in phase 3. However, giving less gains to phase 3 than phase 2 sounds strange.
Anyway, I don't see any problems with the current patch.

Missing pers phase but should work

Acording to https://trac.wildfiregames.com/wiki/Coding_Conventions#Errorreporting we should not use LOGWARNING:
"only use things defined in source/lib/"

Hi everyone! Here is a mod for A25 so that you can see how this change looks.

@LetswaveaBook thoughts?

In D4722#201413, @borg- wrote:

ok, i'm finishing the sparta patch and today i updated this one.

I understand about the horizon, but the earth is not a perfect sphere, hills, trees etc block vision. For all practical (in game) purposes, cavalry and infantry vision should be the same.

In D4744#201812, @real_tabasco_sauce wrote:

In D4744#201811, @chrstgtr wrote:

Personally, I would unify all vision ranges for units (women, siege, CS, champs, etc.).

If any unit deserves to have slightly longer vision it would be cav for "realism" but even then I don't think it makes a ton of sense.

on the "realism": Sitting on a horse should only improve your sight nearby (seeing over bushes and tall grass)

no it doesn't make much sense: currently cavalry can see 12 meters more than infantry. It's such a massive advantage considering they can already move faster to avoid fights. My thought is it could help solve the late game cavalry death balls.

catas need large vision range because of their large attack range. I do think support units could use a little more vision.

I just think they are strong enough without the aura. And, given the effect of auras on performance, I think the patch is better off without this aura.

In D4736#201809, @borg- wrote:

About the aura I would like to clarify some points.

Champions are not affected by the Spartan current bonus (civ bonus), so they no longer receive 10% health.

Othismos aura only affects spartiate champions.

Yes, although the formation is much better than it used to be, it's still not perfect, but I don't think it's "forcing" the player to choose formation, can still be buffed side by side during fights without formation.

Anyway, if you really think it's necessary I would remove it.

In D4744#201811, @chrstgtr wrote:

Personally, I would unify all vision ranges for units (women, siege, CS, champs, etc.).

If any unit deserves to have slightly longer vision it would be cav for "realism" but even then I don't think it makes a ton of sense.

Personally, I would unify all vision ranges for units (women, siege, CS, champs, etc.).

About the aura I would like to clarify some points.

Is this patch still working? Should we consider it for a26? It seemed everyone agreed in the above discussion.

Lets see what forum has to say https://wildfiregames.com/forum/topic/87325-building-panel-order/

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Dumb question. Aren't indexes of standard containers all size_t in C++?

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Changed the data type of SComponentDataGenerator::m_LastIndex from bool to uint_32,

This is how we say a patch is WIP. :) (By prefixing the title.)
Regarding the "cannot repair structures not known", it means that once captured a barracks of the enemy, we cannot repair it. Be aware of that. :) (One can check around that, using the hint provided inline.)

It is nice that we have some larger steps at the end.

Well, the one committing this needs to be absolutely sure this is an inteded side effect:

Notice formations will (...) not [reform] after their members starts to do orders by themselves.

In D4735#201714, @marder wrote:

but @Freagarach (...) prefer grouping by function first.

Don't hold something back on my account, I'm merely saying something that seems logical to me. :) I haven't actually tried any order so am not qualified to speak over what I like more. ;)

I'll write you some tests when I have some more time on my hands. Feel free to do it yourself though.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Previous upload was a mistake, this one is better hopefully.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Allocator is now able to expand to arbitrary capacity.

In D4743#201740, @Stan wrote:

Might try filesystem if that works. I don't remember if nothing worked, or only a subset.

In D4743#201738, @phosit wrote:

In D4743#201732, @Stan wrote:

They trigger Assertion popups. You're free to ignore suppress them. Except in Atlas where it goes south and crashes the entire game.

So what is the diference betwen WARN_ON_ERROR and ENSURE?

Might try filesystem if that works. I don't remember if nothing worked, or only a subset.

Successful build - Chance fights ever on the side of the prudent.

In D4743#201732, @Stan wrote:

They trigger Assertion popups. You're free to ignore suppress them. Except in Atlas where it goes south and crashes the entire game.

Successful build - Chance fights ever on the side of the prudent.

Handle error also on windows (hopefully i can't test ^^)

They trigger Assertion popups. You're free to ignore suppress them. Except in Atlas where it goes south and crashes the entire game.

Why do WARN_ON_ERROR and WARN_RETURN abort the program? shouldn't they warn as the name says?

In D4736#201586, @borg- wrote:

• Neomadoes cost 30 food 20 metal
• Syssiton no build limits
• Promote to olympic instead of upgrade
• Tyrtean paeans now affects all melee infantry (no hero)

In D4736#201677, @chrstgtr wrote:

I have concerns about

New aura:
Othismos: Spartiates next to each other +1 armor. Works perfectly with phalanx formation. The other formations do not affect due to the aura range.

That is a big buff on top of the spear civ bonus, which is already very good (for Sparta and allies). Personally, I’m not a fan of formations as they’re bugging. Formations should be useful in and of themselves and I also don’t like trying to force players to use a feature that they apparently don’t find useful. I would just keep the spear bonus as it is now.

On Windows in C:\Users\{username}\Documents\My Games\0ad\mods

https://github.com/0ad/0ad/blob/f314b5b9d2be852a4d25f4b9ef40ab4acf4f2002/source/lib/file/io/io.cpp#L29

In D4743#201709, @Langbart wrote:

Before applying the patch I would get the following output

Terminal output

❯ pyrogenesis
TIMER| InitVfs: 2.513 ms
FILES| Main log written to '/Users/paria/Library/Application Support/0ad/logs/mainlog.html'
FILES| Interesting log written to '/Users/paria/Library/Application Support/0ad/logs/interestinglog.html'
TIMER| CONFIG_Init: 6.691 ms
Function call failed: return value was -110301 (Error during IO)
Location: file_system.cpp:123 (GetDirectoryEntries)

Call stack:

(error while dumping stack: Function not supported)
errno = 2 (Error during IO)
OS error = ?

I also got an "Error during IO" but why? it is not EIO?

No definitive guidelines.
First consider the gains and the losses of waiting to commit the patch, the current stage of release we're in, the urgency etc

If it works it's good enough for me, but since @Freagarach and @wraitii both made comments suggesting something different I would like to hear their opinion again.

Ok so it seems there is a slight minority for grouping by phase consisting of me, @Langbart and @chrstgtr but @Freagarach and @phosit prefer grouping by function first.

Fixed what suggested on the comments.

make a dangling symlink ...

❯ ln -s ~/ThisFolderDoesNotExist ~/Library/Application\ Support/0ad/mods/ThisFolderDoesNotExist
❯ ls -la ~/Library/Application\ Support/0ad/mods/ | grep ThisFolderDoesNotExist
lrwxr-xr-x   1 paria  staff     35 Jul 24 22:55 ThisFolderDoesNotExist -> /Users/paria/ThisFolderDoesNotExist

start 0ad

Modified the subString condition to be more specific about the regex.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Include logger

I have made some changes to removing the 'warns' and this is correctly comparing the buildList with the entityName. I don't like how this looks yet because of the subString im doing, will need to fix that.

I have concerns about

The overload for wchar is proprietary, so likely only available with msvc. Needs some ifdef here. Or better yet move to <filesystem>.

Thanks for your comments on this diff.
I'll continue working on it and will add that test plan as soon as i can reproduce it.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Fix warning.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.