Build failure - The Moirai have given mortals hearts that can endure.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Mar 26 2020
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Successful build - Chance fights ever on the side of the prudent.
- Linter issues.
- Handle message in default.
- Store target as INVALID_ENTITY when unused.
No. That was the case in the initial version, but not anymore (patch was updated on 8 March): {civ}_champion_chariot.xml can be recruited at maur and sele fortresses, but not {civ}_chariot.xml.
In D2530#112328, @Nescio wrote:
(pers_chariot.xml is untrainable, hence this patch does not affect gameplay balance. Horse archer actors are moved to the persians folder, similar to D2636.)
Successful build - Chance fights ever on the side of the prudent.
Please linter.
Successful build - Chance fights ever on the side of the prudent.
Also test promotion itself.
Does this require further testing?
It's always best to playtest changes. In general 4v4s are the most played and so 3 players would be getting the bonus. If none of the players decide to be more creative and go for the usual ranged infantry upgrades then the resources saved would be 1800W, 600F, 300S, 630M and 72 seconds. As blacksmith techs are generally researched after reaching Phase 3 then the teambonus doesn't come into play for a while. I suppose if we want to stay more on the side of safety then 15% would be better.
Successful build - Chance fights ever on the side of the prudent.
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Re-add a couple of files inadvertently missed from earlier update
Previous revision D1662.
Mar 25 2020
Forgot accept message again (wink @Freagarach) Patch is good, and I agree that iberian units belong to the iberian folder. There is no gameplay change, rather it's an organisational one, therefore it has little impact. Might ping @wowgetoffyourcellphone so he can update his mod accordingly.
Nice! Might be good to check one can also promote a unit using that. Mayb unify the test dunno.
Maybe TestExperienceTrickle?
In D2669#112281, @ValihrAnt wrote:Looking at it from a balancing POV the value of 20% seems to be pretty good. The average blacksmith researches include infantry armor and ranged infantry attack and this teambonus would save 600W, 200F, 100S, 210M and 24 seconds. So overall I think it would be a very useful teambonus, but also not overwhelming.
I wanted to avoid copying the same function to another two classes.
That line was not intentional. I planed to remove it in next update or commit.
Looking at it from a balancing POV the value of 20% seems to be pretty good. The average blacksmith researches include infantry armor and ranged infantry attack and this teambonus would save 600W, 200F, 100S, 210M and 24 seconds. So overall I think it would be a very useful teambonus, but also not overwhelming.
Following functions already checked if unitmotion exists.
Successful build - Chance fights ever on the side of the prudent.
Sounds good for me, is the same move i've done with gauls mercenaries before when updated those.
Successful build - Chance fights ever on the side of the prudent.
food, wood, stone, metal
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
((Side node Documenting the use case / intention / objectives of the commit allows readers (including future self) to not have to guess that and to become able to search for use cases and find the commits implementing them.
Thats typically done in a summary of a revision proposal - if that is skipped it would be good to mention that briefly in the commit message to yield those benefits.)
@elexis, it would be great if you could continue your review of this patch at some point. Spaces etc. in map file names still cause problems with Vulcan when uploading patches to phabricator.
Thank you for picking up nani's report and writing a patch for it!
@borg-, @Feldfeld, @Stockfish0ad, @ValihrAnt, any opinions on this?
@Angen?
@Angen?
@borg-, @Feldfeld, @Stockfish0ad, @ValihrAnt, any opinions on this?
@borg-, @Feldfeld, @Stockfish0ad, @ValihrAnt, any opinions on this?
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Re-upload existing patch, with moved files marked as such
Successful build - Chance fights ever on the side of the prudent.
Fix test.
me neither.
Don't have any problems with this.
Refs rP23298. But not enough fixed for a resign, I guess?
For the record, not only fleeing is affected, every movement update which bails on msg.likelyFailure.
(rP22526#38783)
A tad late, but my concern was fixed by rP23449.
Mar 24 2020
Successful build - Chance fights ever on the side of the prudent.
Check for timer existence.
Successful build - Chance fights ever on the side of the prudent.
"Fixed" in rP22904.
Successful build - Chance fights ever on the side of the prudent.
- Rebased.
- Remove unnecessary spaces in JSDoc in Attacking.js.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
- CanAnySubUnitPerform.
- Added @param.
- Check for order length.
- Reset speed when have been chasing.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Update possible values.