Page MenuHomeWildfire Games
Feed All Stories

Mar 27 2020

Angen added a comment to D2682: [gameplay] unify hero health.

it shouldn't really matter whether they are on foot or ride a horse, chariot, camel, or elephant.
Well it matter for citizen-soldiers and champions.
Maybe they could start at 500 hp and use the same scaling as champions for example.

Mar 27 2020, 2:24 PM
Freagarach added a reviewer for D2496: tweak citizen cavalry and elephant footprints: Restricted Owners Package.
Mar 27 2020, 2:23 PM
Nescio added a comment to D2673: [art/actors] separate actor files for deprecated ptol structures.

cf. rP22977

Mar 27 2020, 2:23 PM
Freagarach added a comment to D2685: simplify mercenary cost.

Is that in-game or at the structure tree from the main menu?

Mar 27 2020, 2:22 PM
Nescio added inline comments to D2684: [gameplay] make rams less effective vs organic units.
Mar 27 2020, 2:21 PM
Nescio added a comment to D2685: simplify mercenary cost.

Also it would not be shown in structure tree and right clicking to trainable unit. (Side note, I think you need to put that technology somewhere to work if I am not mistaken)

Actually it works:

Mar 27 2020, 2:20 PM
Freagarach added a reviewer for D2628: [gameplay] tweak champion infantry javelinist walk speed: Restricted Owners Package.
Mar 27 2020, 2:19 PM
Freagarach added inline comments to D2684: [gameplay] make rams less effective vs organic units.
Mar 27 2020, 2:18 PM
Angen added inline comments to D2684: [gameplay] make rams less effective vs organic units.
Mar 27 2020, 2:11 PM
Angen added a comment to D2685: simplify mercenary cost.

At first sight it looks good because it removes bunch of duplication, however it hides cost change from templates. Also it would not be shown in structure tree and right clicking to trainable unit. (Side note, I think you need to put that technology somewhere to work if I am not mistaken)

Mar 27 2020, 2:09 PM
Freagarach added a comment to D2532: [gameplay] train champion cavalry at stable.

@ValihrAnt please accept if you (still) agree and have verified this patch :)

Mar 27 2020, 1:41 PM
Vulcan added a comment to D2685: simplify mercenary cost.

Successful build - Chance fights ever on the side of the prudent.

Mar 27 2020, 1:15 PM
Nescio created D2685: simplify mercenary cost.
Mar 27 2020, 1:11 PM
Vulcan added a comment to D2684: [gameplay] make rams less effective vs organic units.

Successful build - Chance fights ever on the side of the prudent.

Mar 27 2020, 12:45 PM
Nescio added inline comments to D2684: [gameplay] make rams less effective vs organic units.
Mar 27 2020, 12:41 PM
Nescio created D2684: [gameplay] make rams less effective vs organic units.
Mar 27 2020, 12:40 PM
Vulcan added a comment to D2683: [gameplay] enable pers champion chariot.

Successful build - Chance fights ever on the side of the prudent.

Mar 27 2020, 12:36 PM
Nescio added a comment to D2530: [art/actors] change pers_cavalry_archer_* actor.

Thank you!

the chariot currently cannot be trained, and will be up to the balancers to include or not.

D2683

Mar 27 2020, 12:33 PM
Nescio created D2683: [gameplay] enable pers champion chariot.
Mar 27 2020, 12:32 PM
Vulcan added a comment to D2682: [gameplay] unify hero health.

Successful build - Chance fights ever on the side of the prudent.

Mar 27 2020, 12:31 PM
Nescio created D2682: [gameplay] unify hero health.
Mar 27 2020, 12:26 PM
Vulcan added a comment to D2681: hero selection group.

Successful build - Chance fights ever on the side of the prudent.

Mar 27 2020, 12:17 PM
Nescio created D2681: hero selection group.
Mar 27 2020, 12:11 PM
Nescio updated the summary of D2674: [gameplay] make foundations not ConquestCritical.
Mar 27 2020, 12:04 PM
Nescio added a comment to D2674: [gameplay] make foundations not ConquestCritical.

Without this patch:

  • Conquest games are won by destroying all enemy structures and units
  • Conquest Structures games are won by destroying all enemy structures; units are ignored
  • Conquest Units games are won by destroying all enemy units; structures are ignored

Expected behaviour with this patch:

  • Conquest and Conquest Structures games: foundations are ignored
  • Conquest Units and non-Conquest games: unchanged

That should be easy to verify by running some test games.

Mar 27 2020, 11:59 AM
asterix added a comment to D2613: Updated cppformat.

Do to recent comment https://trac.wildfiregames.com/ticket/3190#comment:13 I suggest @Itms after this is commited to upgrade it straight to recent versions as done https://github.com/s0600204/0ad/tree/fmt .

Mar 27 2020, 10:54 AM
asterix updated the Trac tickets for D2613: Updated cppformat.
Mar 27 2020, 10:50 AM
Stan committed rP23555: Ignore unversionned files in the wxwidgets folder, as they should never be….
Ignore unversionned files in the wxwidgets folder, as they should never be…
Mar 27 2020, 10:38 AM
Freagarach updated the test plan for D2662: Gather using ResourceGatherer instead of UnitAI..
Mar 27 2020, 9:42 AM
Vulcan added a comment to D2662: Gather using ResourceGatherer instead of UnitAI..

Successful build - Chance fights ever on the side of the prudent.

Mar 27 2020, 9:41 AM
Freagarach updated the diff for D2662: Gather using ResourceGatherer instead of UnitAI..

Send the stopped message only after invalidating the target.

Mar 27 2020, 9:32 AM
autobuild committed rP23554: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Mar 27 2020, 9:30 AM
Stan committed rP23553: Move Persian cavalry to the persian folder..
Move Persian cavalry to the persian folder.
Mar 27 2020, 9:30 AM
Stan closed D2530: [art/actors] change pers_cavalry_archer_* actor.
Mar 27 2020, 9:30 AM
Stan accepted D2530: [art/actors] change pers_cavalry_archer_* actor.

I agree with moving persians to the persian folders, I guess if they were indeed using more horse archers than chariots then they should use that, I agree about the icon change, the specific name change, and the chariot currently cannot be trained, and will be up to the balancers to include or not.

Mar 27 2020, 9:26 AM
Stan added a comment to D2680: Heal using Heal.js instead of UnitAI..

Strings in tests?

Mar 27 2020, 8:30 AM
Freagarach updated the summary of D2679: Remove unnecessary argument of Pack-timer..
Mar 27 2020, 8:20 AM
Vulcan added a comment to D2680: Heal using Heal.js instead of UnitAI..

Successful build - Chance fights ever on the side of the prudent.

Mar 27 2020, 8:08 AM
Freagarach updated the diff for D2680: Heal using Heal.js instead of UnitAI..
  • Add test for stopping.
  • Use proper prepare time when starting to heal.
Mar 27 2020, 7:59 AM

Mar 26 2020

nephele added a comment to D2674: [gameplay] make foundations not ConquestCritical.

I've never player Conquest only units or only structures, so no clue what is supposed to happen there.

Mar 26 2020, 10:59 PM
Angen accepted D2679: Remove unnecessary argument of Pack-timer..

data passed inside timer are not used so removal is ok and it eliminates object creation.
SelecAnimation takes only 3 parameters DEFINE_INTERFACE_METHOD_3("SelectAnimation", void, ICmpVisual, SelectAnimation, std::string, bool, fixed)

Mar 26 2020, 10:53 PM
Angen added a comment to D2667: Upgrade engine to handle up to 30 players.

Did not have time to get into it yet, so pointing only style.

Mar 26 2020, 10:50 PM
Vulcan added a comment to D2679: Remove unnecessary argument of Pack-timer..

Successful build - Chance fights ever on the side of the prudent.

Mar 26 2020, 10:41 PM
Freagarach updated the diff for D2679: Remove unnecessary argument of Pack-timer..

Also remove duplicate/depraced "pack" in SetAnimation.
Missed in rP21359.

Mar 26 2020, 10:36 PM
Freagarach updated the summary of D2680: Heal using Heal.js instead of UnitAI..
Mar 26 2020, 10:35 PM
Vulcan added a comment to D2680: Heal using Heal.js instead of UnitAI..

Successful build - Chance fights ever on the side of the prudent.

Mar 26 2020, 10:32 PM
Freagarach created D2680: Heal using Heal.js instead of UnitAI..
Mar 26 2020, 10:28 PM
Vulcan added a comment to D2659: [gameplay] standardize structure loot.

Successful build - Chance fights ever on the side of the prudent.

Mar 26 2020, 10:10 PM
Angen accepted D2659: [gameplay] standardize structure loot.

Complete

Mar 26 2020, 10:10 PM
Angen edited reviewers for D2679: Remove unnecessary argument of Pack-timer., added: Angen; removed: Restricted Owners Package.

Nice catch :)

Mar 26 2020, 10:06 PM
Nescio updated the diff for D2659: [gameplay] standardize structure loot.

maur_wall_gate.xml, pers_stable.xml

Mar 26 2020, 10:05 PM
Nescio added a comment to D2000: aura style corrections.

Thanks. D2222 is a similar patch for the {civ}.json data files.

Mar 26 2020, 9:55 PM
Nescio added a comment to D2659: [gameplay] standardize structure loot.

Thanks for reviewing this, I appreciate it!
As for gates, the <Cost> component determines how expensive it is to repair the structure, and loot is 20% of the cost. The cost is indeed lower than building a long segment and upgrading it to a gate, but I think that's justifiable and the lesser evil.
Likewise, building a village tower and upgrading it to a town tower is more expensive than waiting and building a town tower directly.

Remaining pers_stable

Oops, missed that one, will correct, thanks for pointing that out!

Mar 26 2020, 9:53 PM
Angen accepted D2000: aura style corrections.

Changes are complete.
Changes are good following similar cleaning patches and keeping CC for json.

Mar 26 2020, 9:45 PM
Vulcan added a comment to D2000: aura style corrections.

Successful build - Chance fights ever on the side of the prudent.

Mar 26 2020, 9:38 PM
Nescio added a comment to D2674: [gameplay] make foundations not ConquestCritical.

The new patch looks to work fine, just tested it.

No errors, warnings, or unexpected AI behaviour? Could you describe what you tested and how exactly? Also maybe update this patch's summary and test plan.
At the very least one should verify it works as intended on:

  • Conquest games
  • Conquest Units games
  • Conquest Structures games
  • non-Conquest games

As I wrote earlier, I expect this to work, but didn't test it myself.

Mar 26 2020, 9:37 PM
Nescio updated the diff for D2000: aura style corrections.
Mar 26 2020, 9:33 PM
Angen added a comment to D2659: [gameplay] standardize structure loot.

Remaining
pers_stable

Mar 26 2020, 9:31 PM
Angen requested changes to D2659: [gameplay] standardize structure loot.
Mar 26 2020, 9:26 PM
Angen requested changes to D2000: aura style corrections.

Remaining
iber_player_teambonus.json

Mar 26 2020, 8:39 PM
nani updated the diff for D2667: Upgrade engine to handle up to 30 players.

Removed const and gave the child template parameter a different name so it wont complain in gcc.

Mar 26 2020, 8:34 PM
Freagarach updated the summary of D2679: Remove unnecessary argument of Pack-timer..
Mar 26 2020, 8:27 PM
nephele abandoned D2678: [simulation2] remove warning in removing token in xml via filter.

Not needed with the differing aproach in D2674.

Mar 26 2020, 8:23 PM
nephele added a comment to D2674: [gameplay] make foundations not ConquestCritical.

The new patch looks to work fine, just tested it.

Mar 26 2020, 8:20 PM
ValihrAnt accepted D2675: structure selection groups.

This is a great improvement. When I'm trying to select all my barracks or Civic Centers I don't care from whom I captured something, I care about getting those buildings in the same selection.

Mar 26 2020, 8:19 PM
Vulcan added a comment to D2679: Remove unnecessary argument of Pack-timer..

Successful build - Chance fights ever on the side of the prudent.

Mar 26 2020, 8:14 PM
Freagarach created D2679: Remove unnecessary argument of Pack-timer..
Mar 26 2020, 8:09 PM
Nescio added a comment to D2674: [gameplay] make foundations not ConquestCritical.

Try the patch as is (arc patch D2674).
The only unrelated change is I added full stops at the end of the comments in the xml file, but that doesn't make any difference.

Mar 26 2020, 7:38 PM
nephele commandeered D2674: [gameplay] make foundations not ConquestCritical.

This looks to be unrelated changes aswell? Should i just test the ConquestCritical -> ConquestCritical+!Foundation part?

Mar 26 2020, 7:36 PM
Vulcan added a comment to D2674: [gameplay] make foundations not ConquestCritical.

Successful build - Chance fights ever on the side of the prudent.

Mar 26 2020, 7:35 PM
Nescio updated the diff for D2674: [gameplay] make foundations not ConquestCritical.

Try this instead, I think it should work, but haven't tested.
@nephele, please take back (commandeer) this patch.

Mar 26 2020, 7:30 PM
nephele added a comment to D2678: [simulation2] remove warning in removing token in xml via filter.

The only other option I see would be to introduce a new token that can be removed without a warning, The commit that introduced the warning fixed a crash when removing the token anyhow.

Mar 26 2020, 7:30 PM
Nescio commandeered D2674: [gameplay] make foundations not ConquestCritical.
Mar 26 2020, 7:29 PM
Nescio requested changes to D2678: [simulation2] remove warning in removing token in xml via filter.

This is bad. The warning is there for a reason: it is meaningful and helpful. It should be kept, not removed. Instead, find a way to make an exception for foundations.

Mar 26 2020, 7:27 PM
Vulcan added a comment to D2678: [simulation2] remove warning in removing token in xml via filter.

Successful build - Chance fights ever on the side of the prudent.

Mar 26 2020, 6:58 PM
Freagarach added a comment to D2676: Move common functionality of Foundation and Repairable to Buildable..

I'm not sure how (and if) this inheritance is properly used in the test.
Help is appreciated!

Mar 26 2020, 6:55 PM
nephele added a comment to D2674: [gameplay] make foundations not ConquestCritical.

Please see D2678 for the patch to remove the warning.

Mar 26 2020, 6:53 PM
nephele created D2678: [simulation2] remove warning in removing token in xml via filter.
Mar 26 2020, 6:52 PM
Vulcan added a comment to D2676: Move common functionality of Foundation and Repairable to Buildable..

Build failure - The Moirai have given mortals hearts that can endure.

Mar 26 2020, 6:26 PM
Vulcan added a comment to D2677: selection groups for support units.

Successful build - Chance fights ever on the side of the prudent.

Mar 26 2020, 6:19 PM
Nescio added a comment to D2674: [gameplay] make foundations not ConquestCritical.

Great idea, thanks!

This patch will currently trigger a warning I will adress in my next diff.

It can only be committed if it works without errors, warnings, or problems for the AI (Petra).

Mar 26 2020, 6:18 PM
Nescio retitled D2674: [gameplay] make foundations not ConquestCritical from Gameplay: make foundations not conquest critical to [gameplay]: make foundations not ConquestCritical.
Mar 26 2020, 6:17 PM
Nescio added inline comments to D2677: selection groups for support units.
Mar 26 2020, 6:15 PM
Nescio created D2677: selection groups for support units.
Mar 26 2020, 6:15 PM
Nescio added a comment to D2672: [art/actors] move siege tower and ram actors from structures to units.

Technically isn't a siege tower a "structure"?

It is an object constructed from several parts, so yes, that means it qualifies as structure, and it has a roof and walls, so it qualifies as a building too.
However, in 0 A.D. all siege entities are considered to be units (inherit from template_unit.xml, have the “Unit” class, and can move), not structures (inherit from template_structures.xml, have the “Structure” class, and can't move).
Moreover, having most siege actors in the units folder (e.g. Roman ram) but some in the structures folder (e.g. Persian ram) is both inconsistent and confusing.

Mar 26 2020, 6:06 PM
Vulcan added a comment to D2676: Move common functionality of Foundation and Repairable to Buildable..

Build failure - The Moirai have given mortals hearts that can endure.

Mar 26 2020, 6:04 PM
Vulcan added a comment to D2675: structure selection groups.

Successful build - Chance fights ever on the side of the prudent.

Mar 26 2020, 6:03 PM
Harbormaster failed remote builds in B11335: Diff 11564 for D2676: Move common functionality of Foundation and Repairable to Buildable.!
Mar 26 2020, 6:02 PM
Vulcan added a comment to D2676: Move common functionality of Foundation and Repairable to Buildable..

Build failure - The Moirai have given mortals hearts that can endure.

Mar 26 2020, 6:02 PM
Freagarach created D2676: Move common functionality of Foundation and Repairable to Buildable..
Mar 26 2020, 6:01 PM
Nescio created D2675: structure selection groups.
Mar 26 2020, 5:58 PM
nephele created D2674: [gameplay] make foundations not ConquestCritical.
Mar 26 2020, 5:38 PM
Stan added a comment to D2672: [art/actors] move siege tower and ram actors from structures to units.

Technically isn't a siege tower a "structure"?

Mar 26 2020, 5:35 PM
Nescio added inline comments to D2633: [art/actors] remove frequency="0" variants from brit structure actors.
Mar 26 2020, 4:53 PM
Harbormaster failed remote builds in B11333: Diff 11561 for D2633: [art/actors] remove frequency="0" variants from brit structure actors!
Mar 26 2020, 4:48 PM
Vulcan added a comment to D2633: [art/actors] remove frequency="0" variants from brit structure actors.

Build failure - The Moirai have given mortals hearts that can endure.

Mar 26 2020, 4:48 PM
Nescio updated the diff for D2633: [art/actors] remove frequency="0" variants from brit structure actors.

only brit now

Mar 26 2020, 4:43 PM
Vulcan added a comment to D2673: [art/actors] separate actor files for deprecated ptol structures.

Successful build - Chance fights ever on the side of the prudent.

Mar 26 2020, 4:34 PM
Nescio added inline comments to D2673: [art/actors] separate actor files for deprecated ptol structures.
Mar 26 2020, 4:30 PM
Nescio created D2673: [art/actors] separate actor files for deprecated ptol structures.
Mar 26 2020, 4:29 PM