Get the macOS CI to rebuild spidermonkey so I have a comparison build log to compare to.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 15 2022
After applying the patch to my working copy, the problem described in the referenced ticket can no longer be reproduced; the problem is solved.
Test and confirm that the bundled spidermonkey can now be built with python 3.10, whilst remaining buildable with previous python versions.
- Patch applied successfully
- Spidermoneky was successfully built
- Game successfully compiled and started
Jan 14 2022
Hey @alre if you don't have time at the moment to continue working on this, I could take over if that's ok with you :) I would really like to see this in the game rather sooner than later.
Seems to work for me
Jan 13 2022
I sadly haven't made much progress no.
Atlas is still broken AFAIR.
I believe this is still useful
Linux x32/Clang 11
build, start game, save-load, atlas, js-console: all successfull, found no errors
Successful build - Chance fights ever on the side of the prudent.
Build is unstable, some tests have failed - The Moirai have given mortals hearts that can endure.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Just ran a 4v4 MP match with AI and it seemed to work and to offer better performance. Unfortunately the replay is too big to be parsed by the profiler2. Patch doesn't apply because of ScriptInterface.cpp.
Changes the hash too.
Removes material usages.
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Patch by: @OptimusShepard
Successful build - Chance fights ever on the side of the prudent.
Build failure - The Moirai have given mortals hearts that can endure.
any update on this?
since hyrule conquest is going full node based mode I believe this will be a very desired feature
this will be nice to add
unit pushing is in vanilla so this will be reworked?
any update on this?
Accepting Revision for functionality.
I think changing the ResourceTrickle to a global aura is a step in the wrong direction, to be honest.
Jan 12 2022
Seems to work.
Build failure - The Moirai have given mortals hearts that can endure.
In D4424#189057, @wraitii wrote:This should go green on CI. If so, I'll merge.
Build failure - The Moirai have given mortals hearts that can endure.
Rebase slight tweak.
I think this passes the smoke test of "being a good idea" in my head still after 2-3 years.
Successful build - Chance fights ever on the side of the prudent.
@Freagarach If that's the case then all other catafalque's would need modification too. Would need some confirmation which way to go though.
Readme update https://pastebin.com/bE7bbkeP
Build failure - The Moirai have given mortals hearts that can endure.
This should go green on CI. If so, I'll merge.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.
Line endings...
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Rebase.
Accepting Revision for functionality. I cannot review the code. Though, the change looks minimal.
This works as requested. The right-click removal feature for mixed selection of non-battalion units is extended successfully to battalion units as well. It even has a nice side benefit of the "kicked" or deselected units forming their own battalion. This right-click removal is a nice continuation of behavior players are used to from (pre-battalion) A25.
Jan 11 2022
Rebased.
Successful build - Chance fights ever on the side of the prudent.
Successful build - Chance fights ever on the side of the prudent.