Page MenuHomeWildfire Games
Feed All Stories

Aug 5 2022

Grapjas updated the diff for D4187: Citizen soldiers attack gaia animals without provocation.

Units respond to entities given their stance / occupation and go back to their orders after.

Aug 5 2022, 2:05 PM
Stan added inline comments to D4751: Fix the specialness of `FindTemplatesUnrestricted`..
Aug 5 2022, 12:38 PM
Stan added a reviewer for D4718: Allocator and generator for component data.: jprahman.

@jprahman could you have a look at it?

Aug 5 2022, 11:47 AM
Stan added a comment to D4719: graph2.html and graph2.js.

Did you get a chance to look at it?

Aug 5 2022, 11:46 AM
Stan added a comment to D4736: [Gameplay] Differentiating Sparta.

@asterix please don't accept for the sake of accepting it, and instead state the reasons of your acceptance. Else accepting has a very minimal value...

Aug 5 2022, 11:41 AM · Balancing
Stan updated subscribers of D4751: Fix the specialness of `FindTemplatesUnrestricted`..
Aug 5 2022, 11:40 AM
autobuild committed rP27030: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Aug 5 2022, 9:14 AM
asterix accepted D4736: [Gameplay] Differentiating Sparta.
Aug 5 2022, 8:38 AM · Balancing
Freagarach requested review of D4751: Fix the specialness of `FindTemplatesUnrestricted`..
Aug 5 2022, 8:05 AM
Freagarach added a comment to D4744: [Gameplay] Cavalry vision range 92m -> 80m.

Another team member will do the commit. I don’t think you even have the authorization abilities to do so

Correct. :)
@wowgetoffyourcellphone do you have the time to commit this?

Aug 5 2022, 6:37 AM
Freagarach added a comment to D4736: [Gameplay] Differentiating Sparta.

Okay, so that may need JS changes (or you need to have a regicide hero that cannot be trained for Sparta). As we are in FeatureFreeze, we're reluctant to changing code, as it may have unintended side-effects. Hence I propose leaving the two heroes concept out, sadly. One can introduce it in the next version of the game, though.

Aug 5 2022, 6:20 AM · Balancing
chrstgtr added a comment to D4744: [Gameplay] Cavalry vision range 92m -> 80m.

so how do we commit? Or should it not be done?

Aug 5 2022, 4:52 AM
breakfastburrito_007 accepted D4744: [Gameplay] Cavalry vision range 92m -> 80m.

Seems like a no brainer for balance and I think it will help players use surprise when fighting.

Aug 5 2022, 2:33 AM
real_tabasco_sauce added a comment to D4744: [Gameplay] Cavalry vision range 92m -> 80m.

so how do we commit? Or should it not be done?

Aug 5 2022, 2:17 AM

Aug 4 2022

Vulcan added a comment to D4732: Fix crash in Atlas when switching from the Actor viewer.

Successful build - Chance fights ever on the side of the prudent.

Aug 4 2022, 11:02 PM
Vulcan added a comment to D4732: Fix crash in Atlas when switching from the Actor viewer.

Successful build - Chance fights ever on the side of the prudent.

Aug 4 2022, 11:01 PM
Stan updated subscribers of D4732: Fix crash in Atlas when switching from the Actor viewer.

@Langbart can you test this?

Aug 4 2022, 10:49 PM
vladislavbelov updated the summary of D4732: Fix crash in Atlas when switching from the Actor viewer.
Aug 4 2022, 10:36 PM
vladislavbelov updated the diff for D4732: Fix crash in Atlas when switching from the Actor viewer.
Aug 4 2022, 10:34 PM
vladislavbelov commandeered D4732: Fix crash in Atlas when switching from the Actor viewer.
Aug 4 2022, 10:34 PM
s0600204 added a comment to D4750: possible hotfix for wrong tech tooltips and structure tree.

A globalscript fix would be [...] way more work with added chances of breakage.

Aug 4 2022, 7:53 PM
s0600204 added a comment to D4750: possible hotfix for wrong tech tooltips and structure tree.
In D4750#202208, @Stan wrote:

Wait why would one have Researcher with no techs? Only tech removal?

Aug 4 2022, 7:02 PM
wowgetoffyourcellphone awarded D840: Use walking distance to calculate territories a Dat Boi token.
Aug 4 2022, 6:16 PM
wowgetoffyourcellphone added a comment to D840: Use walking distance to calculate territories.
In D840#40885, @wraitii wrote:

@temple I think you need to reduce the scope of this patch, it will never get committed in its current incarnation imo.

Aug 4 2022, 6:16 PM
vladislavbelov added inline comments to D4705: Remove sys_generate_random_bytes.
Aug 4 2022, 5:59 PM
vladislavbelov accepted D4677: span and string_view for CmdLineArgs.

LGTM.

Aug 4 2022, 5:54 PM
real_tabasco_sauce added a comment to D4736: [Gameplay] Differentiating Sparta.
// Attempt to spawn one hero per player
let cmpRangeManager = Engine.QueryInterface(SYSTEM_ENTITY, IID_RangeManager);
for (let playerID = 1; playerID < TriggerHelper.GetNumberOfPlayers(); ++playerID)
{
        let spawnPoints = cmpRangeManager.GetEntitiesByPlayer(playerID).sort((entity1, entity2) =>
                getSpawnPreference(entity2) - getSpawnPreference(entity1));
Aug 4 2022, 5:52 PM · Balancing
wowgetoffyourcellphone committed rP27029: [Alpha 26] [Fix] Restore the Kushite fisherman actor .
[Alpha 26] [Fix] Restore the Kushite fisherman actor
Aug 4 2022, 5:37 PM
vladislavbelov accepted D4741: Fix writing mod.json with non latin chars in path..
Aug 4 2022, 5:30 PM
borg- added a comment to D4736: [Gameplay] Differentiating Sparta.

@Freagarach maybe you can help here. Two heroes at the same time doesn't work well for regecide mode. You can train the starting hero again, getting two of the same heroes. What could be done to resolve this?

Aug 4 2022, 4:52 PM · Balancing
Vulcan added a comment to D4741: Fix writing mod.json with non latin chars in path..

Successful build - Chance fights ever on the side of the prudent.

Aug 4 2022, 3:18 PM
Vulcan added a comment to D4741: Fix writing mod.json with non latin chars in path..

Successful build - Chance fights ever on the side of the prudent.

Aug 4 2022, 2:38 PM
Vulcan added a comment to D4741: Fix writing mod.json with non latin chars in path..

Successful build - Chance fights ever on the side of the prudent.

Aug 4 2022, 2:33 PM
Stan updated the diff for D4741: Fix writing mod.json with non latin chars in path..

Windows only fix.

Aug 4 2022, 2:05 PM
Stan added a comment to D4750: possible hotfix for wrong tech tooltips and structure tree.

Wait why would one have Researcher with no techs? Only tech removal?

Aug 4 2022, 11:09 AM
marder added a comment to D4750: possible hotfix for wrong tech tooltips and structure tree.

P277 complains as well. (There should be more template files listed, but after the first entry it stops.)
@s0600204 is the one who wrote the structure tree and recommends to do the fix via globalscripts.

Well that was what I tried at the beginning, but I got an annoying error that ApplyValueModificationsToTemplate() is not a function and had no time to investigate further.

Aug 4 2022, 10:13 AM
Freagarach accepted D4750: possible hotfix for wrong tech tooltips and structure tree.

Fix the indent, add it only to structures doing actual research (fixes the checkrefs) and ship it, I'd say. A globalscript fix would be much more correct, but also way more work with added chances of breakage.

Aug 4 2022, 8:10 AM
Freagarach added a comment to D4380: [Gameplay] - Garrison Domestic Animals into the Corral to get a <ResourceTrickle> of Food.
In D4380#202145, @borg- wrote:

An aura to fatten garrisoned animals.

The problem would be PetraAI, I guess. She will slaughter the animals before fattening, which would make her significantly worse.

Aug 4 2022, 8:04 AM
Freagarach added a comment to D4187: Citizen soldiers attack gaia animals without provocation.
In D4187#202143, @lyv wrote:

General high level observations. Maybe wrong, I have not dabbled in this code enough to say with certainty.

  • Is the gaia animal UnitAI supposed to handle the behavior of the player entities being attacked?
  • Should cmpAttack actually care for this at all?
  • Perhaps UnitAI should instead do this in INDIVIDUAL.ATTACKED state transition if the attacking entity is a dangerous animal and call nearby entities with the same owner.

+1

Aug 4 2022, 8:01 AM
Freagarach added a comment to D4740: [WIP] - Allow to limit the structures a builder can construct..

A bit more explanation seems in place.
You use now the template of the foundation (foundation|<sometemplatename>). However, Foundation.js has a property called finalTemplateName, which is the truth about what the foundation will become when finished. E.g. foundation|<sometemplatename> may become foundation|<someothertemplatename> when finished.
As such, when cmpFoundation is present, it ought to be used. Else one can use the current template name (no need for the includes then).

Aug 4 2022, 7:42 AM
Freagarach added inline comments to D4740: [WIP] - Allow to limit the structures a builder can construct..
Aug 4 2022, 7:33 AM
Freagarach added a comment to rP26956: Make formations respond as one to threats..

https://trac.wildfiregames.com/ticket/6598

Aug 4 2022, 7:28 AM
Freagarach added inline comments to D4736: [Gameplay] Differentiating Sparta.
Aug 4 2022, 7:24 AM · Balancing
Langbart updated subscribers of D4750: possible hotfix for wrong tech tooltips and structure tree.

P277 complains as well. (There should be more template files listed, but after the first entry it stops.)

Production Queue Validator
❯ python3 Production.py -v -r .
INFO - Launching 0.A.D with the following command binaries/system/pyrogenesis -mod="mod" -mod="public" --rl-interface="127.0.0.1:9090" --autostart-nonvisual --autostart="skirmishes/acropolis_bay_2p"
INFO - Calling http://127.0.0.1:9090/evaluate to get data
INFO - Killing 0 A.D.
INFO - Looking for templates with missing production queue.
ERROR - structures/generic_field has no production queue.
Aug 4 2022, 6:48 AM
Freagarach added a comment to D4750: possible hotfix for wrong tech tooltips and structure tree.

I thought of this just yesterday. ^^' I guess I'm too busy to think clearly.
Thanks for the patch!

Aug 4 2022, 6:16 AM
Micfild added a comment to D4380: [Gameplay] - Garrison Domestic Animals into the Corral to get a <ResourceTrickle> of Food.

If you don't mind them fattening even while not garrisoned then maybe you could use the Change/Growth attributes, like this:

Aug 4 2022, 2:43 AM
marder added inline comments to D4750: possible hotfix for wrong tech tooltips and structure tree.
Aug 4 2022, 1:26 AM
Vulcan added a comment to D4750: possible hotfix for wrong tech tooltips and structure tree.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 4 2022, 1:17 AM
marder added a comment to D4750: possible hotfix for wrong tech tooltips and structure tree.

Note that: python checkrefs.py -tax still gives me locally the following error:

Aug 4 2022, 1:07 AM
Vulcan added a comment to D4750: possible hotfix for wrong tech tooltips and structure tree.

Successful build - Chance fights ever on the side of the prudent.

Aug 4 2022, 1:06 AM
marder updated the diff for D4750: possible hotfix for wrong tech tooltips and structure tree.

checkrefs was complaining again:

Aug 4 2022, 1:01 AM

Aug 3 2022

marder updated the summary of D4750: possible hotfix for wrong tech tooltips and structure tree.
Aug 3 2022, 10:29 PM
marder requested review of D4750: possible hotfix for wrong tech tooltips and structure tree.
Aug 3 2022, 10:26 PM
Stan added a comment to rP26859: Fixes dynamic GL buffer orphaning forgotten in rP26406. Fixes #6533.

I guess you can resign here too since it's the SDK bug.

Aug 3 2022, 6:45 PM
Langbart resigned from rP27009: [Gameplay] Han unit roster restructure and other balancing adjustments.
Aug 3 2022, 6:02 PM
Stan committed rP27028: Fix issues with the sandbox_han.xml map in Phab:rP27009..
Fix issues with the sandbox_han.xml map in Phab:rP27009.
Aug 3 2022, 5:56 PM
Langbart resigned from rP27012: Use the new crossbow for han champion units..
Aug 3 2022, 5:47 PM
Langbart resigned from rP27011: New crossbow model for the han champion units..
Aug 3 2022, 5:46 PM
Stan committed rP27027: Fix false positive missing file in checkrefs.py in Phab:rP27011 (Game ignores….
Fix false positive missing file in checkrefs.py in Phab:rP27011 (Game ignores…
Aug 3 2022, 5:43 PM
Stan committed rP27026: Fix material not using spectex in Phab:rP27012.
Fix material not using spectex in Phab:rP27012
Aug 3 2022, 5:42 PM
Langbart added a comment to P265 Fix D4514..
  • The execution of the script from the public folder worked.
    • Testing if comments will be removed from the .xml file.
  • The comment was still there after running the script.
  • The only negative side effect is that the comment did not move with the renamed component.
Aug 3 2022, 5:15 PM
Langbart raised a concern with rP27009: [Gameplay] Han unit roster restructure and other balancing adjustments.
  • Try to start the sandbox map from the Han, many errors.
  • Bisecting lead to this commit.
Aug 3 2022, 4:28 PM
Langbart raised a concern with rP27012: Use the new crossbow for han champion units..
checkrefs
python3 checkrefs.py -a
...
INFO - Collecting actors...
INFO - Validating textures...
WARNING - "public/art/actors/units/han/infantry_crossbowman_c.xml": actor contains unnecessary texture(s) "specTex" from "player_trans.xml"
Aug 3 2022, 4:16 PM
Langbart raised a concern with rP27011: New crossbow model for the han champion units..
Aug 3 2022, 4:11 PM
Langbart added a comment to P238 A23 to A24 components.

Only bad side effect is the comments are thrown under the bus.

Aug 3 2022, 3:41 PM
Langbart added a comment to P238 A23 to A24 components.

i was missing lxml

Aug 3 2022, 3:29 PM
Langbart added a comment to P238 A23 to A24 components.

I could not get it to work.

Aug 3 2022, 2:59 PM
Stan added a comment to D4749: Apply stylesheet to template files.

Note there is also a sorter in https://code.wildfiregames.com/P238 . This one also sorts subcomponents which might not be wanted though. It was useful for hyrule since they have/had many duplicate subnodes.

Aug 3 2022, 11:11 AM
Langbart updated the summary of D4749: Apply stylesheet to template files.
Aug 3 2022, 7:49 AM
real_tabasco_sauce accepted D4736: [Gameplay] Differentiating Sparta.
In D4736#202149, @borg- wrote:

Grammar adjustment.

I'll keep it with default armor for now, in case this patch is committed and tested in gameplay, we can modify it if necessary.

Aug 3 2022, 3:28 AM · Balancing
borg- added a comment to D4736: [Gameplay] Differentiating Sparta.

@Langbart everything ok?

Aug 3 2022, 1:09 AM · Balancing
borg- updated the diff for D4736: [Gameplay] Differentiating Sparta.
Aug 3 2022, 1:06 AM · Balancing
borg- updated the diff for D4736: [Gameplay] Differentiating Sparta.

Grammar adjustment.

Aug 3 2022, 1:02 AM · Balancing

Aug 2 2022

real_tabasco_sauce added a comment to D4744: [Gameplay] Cavalry vision range 92m -> 80m.
In D4744#202144, @borg- wrote:

When you open a discussion on the forum you have to be prepared to hear all kinds of opinions, ideas and suggestions. Each person wants 0 a.d to take the course he prefers. There will always be people with a view opposite to yours who tried to oppose the idea, but if there is no valid argument then you have nothing to worry about. Anyway the patch is going well here.

Aug 2 2022, 10:11 PM
Grapjas abandoned D4186: Corrected hasDealtWithTech in TriggerHelper.
Aug 2 2022, 5:06 PM
Grapjas added a comment to D4187: Citizen soldiers attack gaia animals without provocation.
In D4187#202143, @lyv wrote:
  • Is the gaia animal UnitAI supposed to handle the behavior of the player entities being attacked?

Doesn't have to be but it saves me from setting the cmpUnitAI twice in the current code. EDIT: I could've done UnitAI.prototype.PingForHelp(this.target, this.entity); too.

  • Should cmpAttack actually care for this at all?

Haven't checked all functions in UnitAI, but the attack function there only reacts to manual input. But i agree that along with your 3rd point this is not required in that case.

  • Perhaps UnitAI should instead do this in INDIVIDUAL.ATTACKED state transition if the attacking entity is a dangerous animal and call nearby entities with the same owner.

sure but then it loses moddability / possibly other use cases.

Aug 2 2022, 4:56 PM
borg- added a comment to D4380: [Gameplay] - Garrison Domestic Animals into the Corral to get a <ResourceTrickle> of Food.

I guess an aura is (currently) suboptimal, as the animals may wander outside of the aura.

Aug 2 2022, 4:53 PM
borg- added a comment to D4744: [Gameplay] Cavalry vision range 92m -> 80m.

When you open a discussion on the forum you have to be prepared to hear all kinds of opinions, ideas and suggestions. Each person wants 0 a.d to take the course he prefers. There will always be people with a view opposite to yours who tried to oppose the idea, but if there is no valid argument then you have nothing to worry about. Anyway the patch is going well here.

Aug 2 2022, 4:51 PM
lyv added a comment to D4187: Citizen soldiers attack gaia animals without provocation.

General high level observations. Maybe wrong, I have not dabbled in this code enough to say with certainty.

  • Is the gaia animal UnitAI supposed to handle the behavior of the player entities being attacked?
  • Should cmpAttack actually care for this at all?
  • Perhaps UnitAI should instead do this in INDIVIDUAL.ATTACKED state transition if the attacking entity is a dangerous animal and call nearby entities with the same owner.
Aug 2 2022, 4:33 PM
Vulcan added a comment to D4187: Citizen soldiers attack gaia animals without provocation.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 2 2022, 4:29 PM
Vulcan added a comment to D4187: Citizen soldiers attack gaia animals without provocation.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 2 2022, 4:21 PM
Vulcan added a comment to D4187: Citizen soldiers attack gaia animals without provocation.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 2 2022, 4:19 PM
Grapjas updated the diff for D4187: Citizen soldiers attack gaia animals without provocation.

Moved to UnitAI as advised, added radius param.

Aug 2 2022, 4:13 PM
lyv added a comment to D4749: Apply stylesheet to template files.

I don't understand the purpose of the standalone="no" tag, below some related IRC conversations about it. Can I remove them?

Yes you can remove it, its only relevant when DTD is used to make sure its only used for validation. standalone is by default considered as no, so its doubly unnecessary.

Aug 2 2022, 4:12 PM
Vulcan added a comment to D4187: Citizen soldiers attack gaia animals without provocation.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 2 2022, 3:57 PM
Grapjas added a comment to D4187: Citizen soldiers attack gaia animals without provocation.

@marder I was actually considering that too. I'm fine either way.

Aug 2 2022, 3:53 PM
marder added a comment to D4187: Citizen soldiers attack gaia animals without provocation.

nice idea! sound good

Aug 2 2022, 3:52 PM
Vulcan added a comment to D4187: Citizen soldiers attack gaia animals without provocation.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 2 2022, 3:50 PM
Vulcan added a comment to D4187: Citizen soldiers attack gaia animals without provocation.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 2 2022, 3:48 PM
Grapjas updated the diff for D4187: Citizen soldiers attack gaia animals without provocation.

Had forgot to remove some test code. Fixed.

Aug 2 2022, 3:48 PM
Grapjas updated the diff for D4187: Citizen soldiers attack gaia animals without provocation.

When an aggressive animal attacks a unit, it will send a ping in a 60 (up for discussion obv) radius to owned idle units. They will come to aid. This should also fix the issue that Sillier brought up.

Aug 2 2022, 3:42 PM
Langbart requested review of D4749: Apply stylesheet to template files.
Aug 2 2022, 3:15 PM
Vulcan added a comment to D4748: Remove redundant references to deleted .dtd files.

Build failure - The Moirai have given mortals hearts that can endure.

Aug 2 2022, 12:55 PM
Vulcan added a comment to D4748: Remove redundant references to deleted .dtd files.

Successful build - Chance fights ever on the side of the prudent.

Aug 2 2022, 12:44 PM
Stan accepted D4748: Remove redundant references to deleted .dtd files.

LGTM.

Aug 2 2022, 12:42 PM
Langbart updated the diff for D4748: Remove redundant references to deleted .dtd files.

Restore catalog.xml

Aug 2 2022, 12:39 PM
Stan added a comment to D4748: Remove redundant references to deleted .dtd files.

I'm not sure about the last one since it's an external lib. Otherwise looks good. I wonder if DTDs give more useful messages than RNG.

Aug 2 2022, 11:13 AM
Freagarach added a comment to D4380: [Gameplay] - Garrison Domestic Animals into the Corral to get a <ResourceTrickle> of Food.

I guess an aura is (currently) suboptimal, as the animals may wander outside of the aura.

Aug 2 2022, 7:01 AM
Langbart updated the summary of D4748: Remove redundant references to deleted .dtd files.
Aug 2 2022, 6:30 AM
Langbart requested review of D4748: Remove redundant references to deleted .dtd files.
Aug 2 2022, 6:20 AM