http://irclogs.wildfiregames.com/%230ad-dev/2021-05-11-QuakeNet-%230ad-dev.log

first fly, I may miss something

windows build is broken

fix tests

generally i dont like this file at all, it is defining class TerrainAnalysis and on top of that it is defining another class Accessibility what is kind of ok because it inherits but also defining functions from sharedscript ?
resource maps arent even related to terrain analysing
so i would advice to move sharedscript to sharedscript file and then happily move back things to init

I guess thats why it is required property of mod definition

final touches

rebase

fix tests

dock could be but you require to have shore for that and find best dropsite location does not count with that possibility

In D3876#168261, @Stan wrote:

In D3876#168259, @Angen wrote:

what if it picks cc or doc?

It has to, no, if it's the closest?

what if it picks cc or doc?

I don't have currently solution to this, I feel like something else would need to be done so I reverted original patch

yes

thank you
https://code.wildfiregames.com/D3890

I agree with the change, I did not check the code.

1.) find out why strength switch to distance was added, if not needed or useful, remove it
2.) fix passed values of 0 strength in callers, even if resources would have amount less than normalisation factor (what can be anything), it is still amount which should affect resource map, else you can end up with bunch of "low" amount resources on the map totally ignored when picking where to build dropsite
3.) check out why strength is floored, probably ceil could be used anyway

so you are saying multiplying by 0 is good idea?
why do you need to accept use case for 0 strength in the first place?

if you would have different values for cc yes, from current code, no

ok

how troublesome it would be to have one trigger function for it?
so triggers just pass templates for units and where to garrison in one go instead of modder needed to distinguish between turretholder and garrisonholder since essentially they both do the same thing.

Also you should check map scripts if some does want to garrison turretholders by old function

yes it would be good to have files mods cannot change, but I am not sure where do you see workaround here or how calling js from c++ would be better.

I tested this and looks working

rebase

fix previous update

apply comments

apply comments

I did not find major flaw in the code.
Female citizens are displayed as trainable from all structures and their costs are now correct.
D3341 now works without civ element hack.

can you say more please in description of diff, why is this good idea?