try to use members as implementation classes

Fixed in rP22965

jenkins silently builded the changed code here:
https://jenkins.wildfiregames.com/blue/organizations/jenkins/vs2015-differential/detail/vs2015-differential/277/pipeline

ERROR: CCacheLoader failed to find archived or source file for: "gui/hotkey.xml"

#5600

working version

There are at least two m_ItemsYPositions and maybe more variables
one from COList
second from CListSingle

something is wrong with olistsingle, olistmultiple

Single, Multiple class design
Not synchronised with js
OList is Single for now

Builds, tests passed, jenkins tests are ok, feature looks good, I do not see more problems in code

builds in debug and without pch release

From Debug build

I see two cases when to add header to precompiled.

1. It is included in a lot of files ( what means more than 15 with small files)
2. It is big file in terms of code and other includes and is used more than 5 times.

looks good to me

try to fail after timeout

add timeout
fix robocopy

fix robocopy

robocopy

broke test.exe build with --jenkins-tests and so jenkins

no, but might be interesting improvement

add flags for gloox and collada
split testing so release tests follow right after build of release version so in case they do not pass, there will be no build of debug version

Tests passed

file: source\ps\CStr.cpp
line 195 : [C-style cast]: 		return (long)Pos;
line 206 : [C-style cast]: 		return (long)Pos;
line 217 : [C-style cast]: 		return (long)Pos;
line 232 : [C-style cast]: 		return (long)Pos;
line 242 : [a++ -> ++a]: 	for (size_t i = 0; i < length(); i++)
line 243 : [C-style cast]: 		NewString[i] = (tchar)_totlower((*this)[i]);
line 251 : [a++ -> ++a]: 	for (size_t i = 0; i < length(); i++)
line 252 : [C-style cast]: 		NewString[i] = (tchar)_totupper((*this)[i]);
line 349 : [a++ -> ++a]: 	for (size_t i = 0; i < length(); i++)
line 365 : [C-style cast]: 			ss << "\\u" << std::hex << std::setfill('0') << std::setw(4) << (int)(unsigned char)ch;
line 381 : [a++ -> ++a]: 			for (Left = 0; Left < length(); Left++)
line 396 : [a++ -> ++a]: 			for (Left = 0; Left < length(); Left++)
line 447 : [C-style cast]: 	return (size_t)fnv_hash(data(), length()*sizeof(value_type));
line 448 : Comments should start with capital: 		// janwas 2005-03-18: now use 32-bit version; 64 is slower and
line 461 : [a++ -> ++a]: 	for (i = 0; i < len; i++)
line 483 : [C-style cast]: 		*(str++) = (tchar)native;
line 503 : [C-style cast]: 	Serialize_int_4(buffer, (u32)len);
line 505 : [a++ -> ++a]: 	for (i = 0; i < len; i++)
file: source\ps\tests\test_CStr.h
line 82 : a+ -> a +: 		u8* buf = new u8[len+1];
line 158 : [WARNING]: File is missing include guard

In D2287#95144, @Vulcan wrote:

Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/154/display/redirect

less code

address comment by wraitii so this fixes also scenario where unit changes ownership and technologies change Health values based on player

Do we want only one type of units in a battalion?

yes, that is one of the basic idea of batalions, but there would be allowed special units like banner carrier, hero, commander.

fixed in rP22892

static cast to ensure u16 result

add entry to template, fix repair command back

yes possibly but first it would be better just have this one as it is a lot faster than computing squares and this just changes unitai code in minimal scale

yes icons should have own folder

@Stan
units have different sound for order_repair and order_build at least in templates
issue is that i unit_actions.js is only command repair and so always is used and played order_repair even if target is just foundation and not damaged building

builds without-pch

Fixed in rP22567

@Stan can you please check if it works for you?

just for record there is already similar logic:
Hero Elephant = Hero or Elephant
Hero+Elephant = Hero and Elephant
!Hero = no Hero

In rP22511#35467, @elexis wrote:

In rP22511#35454, @Angen wrote:

This introduced Access violation reading from ticket: https://trac.wildfiregames.com/ticket/5539 not fixed by later patch.

Sure it was this commit? As I understand it's the placement new in rP22545 that is not supported by VS2013?

Reason for this issue with VS2013 is that memset was removed and looks like vs13 does not do default initialisation of that values.
If vs13 is only compiler having that problem, then we should cut off vs13 build already with D1396 since this is making vs13 builds not functional at all.

Grid.h(234): Assertion failed: "0 <= i && i < m_W && 0 <= j && j < m_H"

This introduced Access violation reading from ticket: https://trac.wildfiregames.com/ticket/5539 not fixed by later patch.

Fixed in rP22544

Build on windows is green, no crashes related to glsl or postprocessing, sound plays in atlas as should.