I broke minimum range for units with bigger passability classes #5864 here.
Looks like fix of the bug worked just because they treated it as stucked so ships stopped dancing around.
After reading the huge TODO comment above affected lines, one cannot pass minrage = maxrange, so for now I just should force Petra to dont do it.

I think I like units ambient colour more, with terrain ambient it is a bit blue-ish.

chickens will not move away from foundation

#3299

why are you removing size_t ?

Why is source/gui/Scripting/JSInterface_GUIProxy_impl.h h file ?
Is there strong reason why it cannot have h and cpp parts?

ok, one can use disable=""
changes are good, allowing to disable cheer completle for certain units if needed
modability from template is also good addition

as far as I know one can disable just components but I may be mistaken, need to try it

One issue, one cannot disable cheeringtime in children templates.

if I recall correctly there should be at least one more order.cheer

rP24184

I have no actual knowledge about these linux scripts.
Having this established, does diff run on the same workspace as svn?
I thought they are different.

For the purpose of showing templates with right click on disabled buttons, this looks good.
There is small difference with sound, but we would need to add variable to every button and enable right click with it if disabled from js and we would have just one rightclick event as now. On the other hand we would have separate varaibles deciding if specific button actions are enabled.
If someone really wants that click sound fix, one should change the approach.

agree with bb, you need to discard order now when cheering time is 0

then make it just template value and unitai will not serialised it

it is using random as biome so we should have mainland_random preview file, and because we do not have, it keeps one currently set and when opening first time, it keeps default one

your locale copy or jenkins is outdated, it fails to apply patch

I might blunder but it looks correct to me:

Just proof that inParabolicRange computation here and in UnitAi is the same

I tested it and it works good on all my keyboard layouts. I did not test atlas.
I once noticed it wrote,,, in key editor but I am not sure how I triggered it.

did it fix https://trac.wildfiregames.com/ticket/5760?

It broke zooming with mouse wheel

1.) disabled icons are clickable
2.) there is sound difference when clicking with right click enabled and disabled, there is no release sound for disabled button but dont know if it id doable and to not brake current sound state

add landscape as it has similar issue, notice for unknown map, if biome map would exists, it would need to be unknown_{biome} and would be
currently displayed for any type of landscape if biome would be switched, now with this diff the landscape stays selected

well. i have got the replay and found when it happens but i cant reproduce it outside the replay with entity promotion, entity death or ownership change.

lol i had no idea this exists :D
although i do not know if this would be helpful for dev overlay, but some mods may want to use it for any reason so i would not just remove it as it could be interesting to have

I reproduced it once from 6 runs and even that one case was non visual so I do not have replay

@vladislavbelov thank you, you can mark this red, I try to check this evening

more linter

dropdown, 100%, 125%, 150%, 175%, 200% (1, 1.25, 1.5, 1.75, 2)
show nothing when custom value in config ?

make linter and Freagarach happy

maybe windowed option could be moved somewhere else, e.g. general ?

Because what title says, and comment above, I have to request changes.

For continue removal completeness, one can still ignore error window on windows using x when application continues execution.

I tested it with renderpath = "fixed" in combination with preferglsl = "true" and preferglsl = "false".
In both cases, error window appeared and application closed successfully.
Only break and exit actions have been available.
Codewise implementation looks reasonable.

After pressing continue and application closing, I got this: