Fixes: #5823

Addition of splash damage story
http://irclogs.wildfiregames.com/2012-02/2012-02-06-QuakeNet-%230ad-dev.log

instead of removing this information, maybe it could be moved to extended version of tooltip

I do not see ai getting any valueable information knowing that some was defined as null instead of undefined.
metal: null equals to not including that line at all from simulation point of view so should be the same as `undefined'.

Fix research.
O (2*n) for filter so O (n).

thank you

refactor
@vladislavbelov thnx

removing visibleclasses from guiinterface is reasonable
tooltips get data directly from template
petra does not call guiinterface
I did not check usefulness of other things in getentitystate

anyway

1.) Looks fine
2.) I think dropsite types could be displayed somewhere for already build structure, just like gather rates are

1.) At first look it is good
2.) In my opinion unit should try to store current resource if they differ as well, but that may be another diff
3.) If there is no dropsite, it would fail after moving to resource anyway, but it would be near point where player expects it to go when gives that order, I think it could be confusing why it is not moving, maybe we could inform player that unit failed to find dropsite for given resource (just idea)

Left diff, right svn. Looks good by me.

check for cmpplayer and add test

MapSize.js
WorldPopulationCap.js

a = class a { constructor() {console.log('constructor')} }
a = new a();
a = new a();

output

constructor
error: Uncaught TypeError: a is not a constructor

I missed in code where are m_EnabledRenderSubmit or m_EnabledInterpolate used?
Looks like they are here just for switch, they can be merged as always or are both enabled or both disabled.
Also that two ifs can be merged.

Is it attack effect or attack type ?

disabled buttons

In D2652#131397, @Stan wrote:

Can we support playing a sound ?

Right now,
range queries for melee units perfectly matches their range attacks,
range queries for ranged units does not because they use the same non-parabolic query as rest of units.
May be because performance or because no-one bothered to give them parabolic queries. I believe there is ticket for that. Anyway that causes ranged units to get targets which are actually out of range or not get targets that would be in parabolic range.

missed in https://code.wildfiregames.com/rP14702

no, thats just my english, thank you

dummy
(a+b)*(a+b) != a*a + b*b

let jenkins complain about intendation

use correct elevation range calculation

inline :)
commas

I did build of rP23924 and then rP23925. It was not present before this commit.

sure, if that diff makes it to a24, it would be great

e.g. trees

action buttons in midle panel could be moved a bit lower,
Also player/civilisation bar is too close to entity name in brackets, for some entities it overlaps a bit. Does not happen in a23b.

more comments

rebase + animal state

Form formation at the start, it will never-ever move.
Formation controller is blocked by cc obstruction while stucked in it.

more jenkins

Looks and works good.
IMO one should create diff to get guarding units closer if possible so they mostly ends up in guarding range then mostly not.

nice find

Ai works without errors.
As I think it would be good to make use of support elephant aura while building, mobile dropsite is more valuable moreover since ai has only one worker elephant.
Removing Champion class from siege unit check is ok-ish, as champion melee elephants are only melee elephant svn currently has.
Rest removals and changes to Unit class are ok.
I do not like unrelated style changes but idc too much.
Thank you for the patch.

rest for true/false