Page MenuHomeWildfire Games

Angen
wolf

User Details

User Since
Jul 28 2017, 4:19 PM (208 w, 6 d)

Recent Activity

Yesterday

Angen accepted D285: Lobby player search input.
Wed, Jul 28, 9:57 PM
Angen published D4202: Fix wrong number in tooltip for phase requirements for review.
Wed, Jul 28, 9:47 PM
Angen added inline comments to rP25133: Exclude Towers from Town->City phase requirements..
Wed, Jul 28, 9:47 PM
Angen requested review of D4195: [AI] Simplify getMetadata in sharedscript.
Wed, Jul 28, 6:13 PM
Angen updated the diff for D4195: [AI] Simplify getMetadata in sharedscript.

be fancy UwU

Wed, Jul 28, 6:13 PM
Angen added a comment to D4195: [AI] Simplify getMetadata in sharedscript.
Wed, Jul 28, 6:10 PM
Angen updated the diff for D4200: [PetraAI] inline in DefenseManager.

more inline, remove comment

Wed, Jul 28, 6:03 PM

Tue, Jul 27

Angen added a comment to rP25841: Prevent formation members to run when they should not.

rP25708

Tue, Jul 27, 8:22 PM
Angen committed rP25841: Prevent formation members to run when they should not.
Prevent formation members to run when they should not
Tue, Jul 27, 8:21 PM
Angen closed D4201: Prevent formation members to run when they should not.
Tue, Jul 27, 8:21 PM
Angen planned changes to D4200: [PetraAI] inline in DefenseManager.
Tue, Jul 27, 8:10 PM
Angen added inline comments to D4200: [PetraAI] inline in DefenseManager.
Tue, Jul 27, 8:05 PM
Angen published D4201: Prevent formation members to run when they should not for review.
Tue, Jul 27, 8:03 PM
Angen published D4200: [PetraAI] inline in DefenseManager for review.
Tue, Jul 27, 7:38 PM

Sat, Jul 24

Angen added a comment to D4199: Update translation checks to check pluralised strings.

What do you mean to fix an output?

Sat, Jul 24, 6:20 PM
Angen updated the Trac tickets for D4199: Update translation checks to check pluralised strings.
Sat, Jul 24, 11:48 AM
Angen added a comment to D4199: Update translation checks to check pluralised strings.

they are all in pluralised form picked based on rules defined in po files, just first index in pluralised form is translation of singular form rest is translation of plural, no idea how transifex determines which index goes where for other, few and so on

Sat, Jul 24, 10:04 AM
Angen published D4199: Update translation checks to check pluralised strings for review.
Sat, Jul 24, 9:24 AM

Wed, Jul 21

Angen raised a concern with rP25634: Allow mods to say they should be ignored in replay/MP compatibility checks.
Wed, Jul 21, 7:52 PM

Mon, Jul 19

Angen accepted D4193: Fix PetraAI training ships as ordinary units..

Ships are fixed

Mon, Jul 19, 10:09 PM
Angen updated the diff for D4195: [AI] Simplify getMetadata in sharedscript.

fix typo

Mon, Jul 19, 9:38 PM
Angen published D4195: [AI] Simplify getMetadata in sharedscript for review.
Mon, Jul 19, 9:36 PM
Angen added a comment to D4193: Fix PetraAI training ships as ordinary units..

Why does Ship need to be excluded? Does not that mean somewhere are still wrong classes passed?

Mon, Jul 19, 3:37 PM

Sun, Jul 18

Angen added a comment to D4191: Enable Cartography at Start of Game Option.

At first you would need to get separate code for library and build it,
Adding option itself is C++, but mostly it would be copy pasting of existing code, if C++ would be concidered issue.
https://trac.wildfiregames.com/wiki/BuildInstructions?version=416#BuildingAtlas

Sun, Jul 18, 7:47 PM
Angen accepted D4191: Enable Cartography at Start of Game Option.
Sun, Jul 18, 12:23 PM
Angen added a comment to D4191: Enable Cartography at Start of Game Option.

Some minor comments.
Patch is overall working as expected.

Sun, Jul 18, 12:23 PM
Angen requested changes to D4193: Fix PetraAI training ships as ordinary units..

Or use another notation which means and among classes

Sun, Jul 18, 11:44 AM

Sat, Jul 17

Angen added a comment to D4192: [PetraAI] - Manage bases in separate BaseManager..

yes i do

Sat, Jul 17, 8:17 PM

Thu, Jul 15

Angen added inline comments to D4191: Enable Cartography at Start of Game Option.
Thu, Jul 15, 4:47 PM
Angen added inline comments to D4191: Enable Cartography at Start of Game Option.
Thu, Jul 15, 10:26 AM

Wed, Jul 14

Angen added inline comments to D2709: Fix Let certain formations stay in formation while attacking.
Wed, Jul 14, 4:59 PM
Angen added inline comments to D3037: Add gui scale to options.
Wed, Jul 14, 10:47 AM
Angen updated the summary of D3037: Add gui scale to options.
Wed, Jul 14, 7:29 AM

Tue, Jul 13

Angen planned changes to D3037: Add gui scale to options.

Crap, i need to go back to float.
I broke scale when starting the game.

Tue, Jul 13, 11:27 PM
Angen updated the diff for D3037: Add gui scale to options.

update with timeout

Tue, Jul 13, 11:07 PM
Angen abandoned D3890: Lower contrast for player colour on minimap.
Tue, Jul 13, 8:07 PM
Angen removed 1 auditor(s) for rP23753: Make rams less effective by reducing speed and preventing attacks on organics.: Angen.
Tue, Jul 13, 8:06 PM
Angen resigned from rP23753: Make rams less effective by reducing speed and preventing attacks on organics..
Tue, Jul 13, 8:05 PM
Angen accepted D4183: Fix rare crash when opening dropdowns..

Works for me.
Now I actually even see selected colour in dropdown.
However PlayerColor.js should be rewriten at some point. It should not update list and selection on every render call.

Tue, Jul 13, 7:46 PM
Angen added a comment to D4182: Fix gamesetup crash when Daytime resets..
Index: Daytime.js
===================================================================
--- Daytime.js	(revision 25824)
+++ Daytime.js	(working copy)
@@ -2,8 +2,7 @@
 {
 	init()
 	{
-		this.data = undefined;
-		this.value = undefined;
+		this.setDataValueHelper(undefined, undefined);
 		this.settings.map.watch(() => this.onMapChange(), ["map"]);
 	}
Tue, Jul 13, 7:16 PM
Angen accepted rP24989: Split treasures from ResourceSupply..

rP25824

Tue, Jul 13, 6:51 PM
Angen committed rP25824: Fix treasure in statistics.
Fix treasure in statistics
Tue, Jul 13, 6:48 PM
Angen raised a concern with rP24989: Split treasures from ResourceSupply..
Tue, Jul 13, 10:36 AM
Angen added inline comments to D4191: Enable Cartography at Start of Game Option.
Tue, Jul 13, 10:07 AM

Sun, Jul 11

Angen added a comment to D4192: [PetraAI] - Manage bases in separate BaseManager..

I have one general remark into this.
If we are going to separate it into another class, I would suggest to not access data of that class directly.
For cases where only base at index 0 is used I would create specific geter for that matter and return that base directly maybe something like getPrimaryBase so it would be more cleaner to reader why asking for index 0 without need to read somewhere in comments what base on index 0 means.

Sun, Jul 11, 12:08 PM
Angen accepted D4184: Fix PetraAI building a lot of siege and not using it..

Solution looks ok for now

Sun, Jul 11, 11:56 AM

Sat, Jul 10

Angen requested changes to D4192: [PetraAI] - Manage bases in separate BaseManager..
Sat, Jul 10, 10:54 PM
Angen added inline comments to D4191: Enable Cartography at Start of Game Option.
Sat, Jul 10, 5:41 PM
Angen added inline comments to D4191: Enable Cartography at Start of Game Option.
Sat, Jul 10, 5:24 PM
Angen added inline comments to D4191: Enable Cartography at Start of Game Option.
Sat, Jul 10, 5:14 PM
Angen requested changes to D4191: Enable Cartography at Start of Game Option.
Sat, Jul 10, 12:37 PM

Sat, Jul 3

Angen added a member for Contributors: Grapjas.
Sat, Jul 3, 9:18 AM

Fri, Jul 2

Angen added a comment to D4186: Corrected hasDealtWithTech in TriggerHelper.

I dont see where name of the function suggest that technology is researched.
I queued this technology so I dealt with it and now I dont need to care about it.

Fri, Jul 2, 9:15 AM

Wed, Jun 30

Angen added a comment to D4184: Fix PetraAI building a lot of siege and not using it..

Irrelevant.
What if someone writes !Siege into classes.
Then it will break

Wed, Jun 30, 11:22 AM
Angen added a comment to D4184: Fix PetraAI building a lot of siege and not using it..

So you are trying to match .classes from untistats.
But there are + variants and for that reason even this conditions will not work correctly at all.
Damn I should have seen it.

Wed, Jun 30, 11:00 AM
Angen added a comment to D4184: Fix PetraAI building a lot of siege and not using it..

But why was Matchclasslist not working?
It is supposed to do the same as the conditions in if.
Its or siege or the rest classes.

Wed, Jun 30, 10:53 AM

Jun 25 2021

Angen added a comment to D4179: Don't show turreted entities as idle..

:)

Jun 25 2021, 3:48 PM

Jun 21 2021

Angen removed 1 auditor(s) for rP25151: Refuse to serialize NaN values.: Langbart.
Jun 21 2021, 9:07 PM

Jun 20 2021

Angen added a comment to D3719: GameSetup GUI cleanup - renaming & moving stuff around..

I agree with @nani

Jun 20 2021, 8:24 PM
Angen added a comment to rP25381: Enable production entities to autoqueue..

@nani has the autoqueue been adapted enough to your liking?

Jun 20 2021, 8:23 PM
Angen added a comment to D4176: Fixup rP25772.

I know i don't write best summaries and test plans, but could it tell more than just pointing to the commit it is fixing?

Jun 20 2021, 8:20 PM
Angen added a comment to rP25789: Update some MR map previews..

This removes the fancy mainland biome switch because it was the only map to do that and we lack the tools to automate it

To automate what exactly?
You mean it was only map to have multiple biomes or only map to actually have completed previewes for the biomes?
And you did not remove the switch at all, at least not in this patch.
You just removed art and I still don't understand why it was bad to have this there.

Jun 20 2021, 8:17 PM

Jun 14 2021

Angen added inline comments to rP25023: Customize hotkey categories & ordering, prepare for translation..
Jun 14 2021, 6:33 PM

Jun 9 2021

Angen added a comment to D4122: Struct Tree: better handle failures to load templates..

So it will not scream at me when i make an error anymore?

Jun 9 2021, 2:27 PM

Jun 3 2021

Angen added a comment to rP25418: Ensure rated game and cheat won't be enabled at the same time..

Possibly https://wildfiregames.com/forum/topic/41939-a25cheats-enabled-no-option-to-toggle/

Jun 3 2021, 7:15 AM

Jun 2 2021

Angen added inline comments to rP25634: Allow mods to say they should be ignored in replay/MP compatibility checks.
Jun 2 2021, 8:32 PM
Angen added inline comments to rP25634: Allow mods to say they should be ignored in replay/MP compatibility checks.
Jun 2 2021, 8:29 PM
Angen retitled D4028: [Mod] Fix list and filter in mod selection breaking page when mod is missing some attribute from [Mod] Fix mod page failing when mod was missing important attribute to [Mod] Fix list and filter in mod selection breaking page when mod is missing some attribute.
Jun 2 2021, 7:59 PM
Angen committed rP25639: [Mod] Fix list and filter in mod selection breaking page when mod is missing….
[Mod] Fix list and filter in mod selection breaking page when mod is missing…
Jun 2 2021, 7:59 PM
Angen closed D4028: [Mod] Fix list and filter in mod selection breaking page when mod is missing some attribute.
Jun 2 2021, 7:58 PM
Angen added a comment to D4028: [Mod] Fix list and filter in mod selection breaking page when mod is missing some attribute.

could but may require more work like that,
last time i tried i could not set dependencies
also will make getAvailable mods slower as it would need to parse the json, check and replace everything and i dont want to be stuck there for time being

Jun 2 2021, 7:53 PM
Angen committed rP25638: Fix areFilters.
Fix areFilters
Jun 2 2021, 7:45 PM
Angen closed D4041: Fix rP25601.
Jun 2 2021, 7:45 PM
Angen awarded D4053: Random Maps: Echo Valley & Echo Shores a Evil Spooky Haunted Tree token.
Jun 2 2021, 5:31 AM
Angen added a comment to D4053: Random Maps: Echo Valley & Echo Shores.

Looks interesting

Jun 2 2021, 5:31 AM

Jun 1 2021

Angen added a comment to D4049: Improve 'incompatible mods' splash screen.

Looks ok

Jun 1 2021, 7:05 PM
Angen updated the diff for D4041: Fix rP25601.

rename

Jun 1 2021, 7:01 PM
Angen added a comment to rP24927: Update credits again. I failed to notice not all languages were included..

https://trac.wildfiregames.com/ticket/6023

Jun 1 2021, 11:11 AM
Angen added a comment to rP25512: Add rated game information to the objectives dialog..

One of the diffs linked above did that

Jun 1 2021, 9:08 AM

May 31 2021

Angen added inline comments to rP25601: Fix and simplify areFilters functions.
May 31 2021, 8:06 PM
Angen published D4041: Fix rP25601 for review.
May 31 2021, 8:05 PM
Angen awarded rP25618: Fix broken SP persisted settings a Yellow Medal token.
May 31 2021, 7:27 PM

May 30 2021

Angen committed rP25602: Add missing credits in rP25600.
Add missing credits in rP25600
May 30 2021, 12:45 PM
Angen added a comment to rP25512: Add rated game information to the objectives dialog..

@Freagarach did you test if it cover replays?

May 30 2021, 12:39 PM
Angen added a comment to rP25600: [PetraAI] - Make easy difficulties of AI weaker.

ah yeah,
@marder do you want to have your real name in credits or just your nickname ?

May 30 2021, 11:34 AM
Angen committed rP25601: Fix and simplify areFilters functions.
Fix and simplify areFilters functions
May 30 2021, 11:32 AM
Angen added a comment to rP25573: Mod selector: "start mods" saves the configuration..

you should update splaschscreen when invalid mods are on

May 30 2021, 11:27 AM
Angen committed rP25600: [PetraAI] - Make easy difficulties of AI weaker.
[PetraAI] - Make easy difficulties of AI weaker
May 30 2021, 11:08 AM
Angen closed D3997: [PetraAI] - Make very easy AI weaker.
May 30 2021, 11:07 AM
Angen accepted D3997: [PetraAI] - Make very easy AI weaker.

Easy versions of ai now send army of lower numbers and will waste resources on II phase structures earlier, what will slow down their developement a bit too.
To answer question that numbers in attacks grow by time: there are several types of attacks which naturally grow in numbers to not drag the match forever.
Thank you for the patch.

May 30 2021, 10:59 AM

May 29 2021

Angen published D4028: [Mod] Fix list and filter in mod selection breaking page when mod is missing some attribute for review.
May 29 2021, 1:35 PM
Angen updated the diff for D3478: Add "Invalid signature" reason to modio.

translate

May 29 2021, 1:20 PM
Angen requested changes to D3997: [PetraAI] - Make very easy AI weaker.
May 29 2021, 1:14 PM

May 27 2021

Angen added a comment to D3997: [PetraAI] - Make very easy AI weaker.

If you dont touch the line with your changes, you can ignore linter

May 27 2021, 5:19 PM
Angen accepted D3838: Minor fixes after Gathering refactoring..

Hmm appearantly accepting as group does not mark it as accepted

May 27 2021, 3:55 PM
Angen accepted D3838: Minor fixes after Gathering refactoring..

So you can close it

May 27 2021, 3:54 PM
Angen added a comment to rP25512: Add rated game information to the objectives dialog..

Another relevant diff https://code.wildfiregames.com/D682

May 27 2021, 3:34 PM
Angen added a comment to rP25512: Add rated game information to the objectives dialog..

https://code.wildfiregames.com/D1234

May 27 2021, 3:33 PM
Angen removed reviewers for D1545: Provide AI json description files with ID tag to tell them apart from other JSON files: mimo, Angen.
May 27 2021, 3:21 PM
Angen resigned from D1545: Provide AI json description files with ID tag to tell them apart from other JSON files.
May 27 2021, 3:20 PM