- User Since
- Jul 28 2017, 4:19 PM (116 w, 1 d)
Mon, Oct 14
Thu, Oct 10
Wed, Oct 9
Tue, Oct 8
Thu, Oct 3
Sat, Sep 28
Thu, Sep 26
Mon, Sep 23
Sun, Sep 22
try to use members as implementation classes
Fixed in rP22965
jenkins silently builded the changed code here:
ERROR: CCacheLoader failed to find archived or source file for: "gui/hotkey.xml"
Fri, Sep 20
There are at least two m_ItemsYPositions and maybe more variables
one from COList
second from CListSingle
Sep 19 2019
something is wrong with olistsingle, olistmultiple
Single, Multiple class design
Not synchronised with js
OList is Single for now
Builds, tests passed, jenkins tests are ok, feature looks good, I do not see more problems in code
builds in debug and without pch release
From Debug build
I see two cases when to add header to precompiled.
- It is included in a lot of files ( what means more than 15 with small files)
- It is big file in terms of code and other includes and is used more than 5 times.
Sep 18 2019
looks good to me
Sep 17 2019
try to fail after timeout
Sep 16 2019
broke test.exe build with --jenkins-tests and so jenkins
Sep 15 2019
no, but might be interesting improvement
add flags for gloox and collada
split testing so release tests follow right after build of release version so in case they do not pass, there will be no build of debug version
file: source\ps\CStr.cpp line 195 : [C-style cast]: return (long)Pos; line 206 : [C-style cast]: return (long)Pos; line 217 : [C-style cast]: return (long)Pos; line 232 : [C-style cast]: return (long)Pos; line 242 : [a++ -> ++a]: for (size_t i = 0; i < length(); i++) line 243 : [C-style cast]: NewString[i] = (tchar)_totlower((*this)[i]); line 251 : [a++ -> ++a]: for (size_t i = 0; i < length(); i++) line 252 : [C-style cast]: NewString[i] = (tchar)_totupper((*this)[i]); line 349 : [a++ -> ++a]: for (size_t i = 0; i < length(); i++) line 365 : [C-style cast]: ss << "\\u" << std::hex << std::setfill('0') << std::setw(4) << (int)(unsigned char)ch; line 381 : [a++ -> ++a]: for (Left = 0; Left < length(); Left++) line 396 : [a++ -> ++a]: for (Left = 0; Left < length(); Left++) line 447 : [C-style cast]: return (size_t)fnv_hash(data(), length()*sizeof(value_type)); line 448 : Comments should start with capital: // janwas 2005-03-18: now use 32-bit version; 64 is slower and line 461 : [a++ -> ++a]: for (i = 0; i < len; i++) line 483 : [C-style cast]: *(str++) = (tchar)native; line 503 : [C-style cast]: Serialize_int_4(buffer, (u32)len); line 505 : [a++ -> ++a]: for (i = 0; i < len; i++) file: source\ps\tests\test_CStr.h line 82 : a+ -> a +: u8* buf = new u8[len+1]; line 158 : [WARNING]: File is missing include guard
Sep 14 2019
Sep 13 2019
address comment by wraitii so this fixes also scenario where unit changes ownership and technologies change Health values based on player
Do we want only one type of units in a battalion?
yes, that is one of the basic idea of batalions, but there would be allowed special units like banner carrier, hero, commander.
Sep 12 2019
fixed in rP22892
static cast to ensure u16 result
Sep 11 2019
Sep 10 2019
Sep 9 2019
add entry to template, fix repair command back
yes possibly but first it would be better just have this one as it is a lot faster than computing squares and this just changes unitai code in minimal scale
Sep 8 2019
yes icons should have own folder
Sep 6 2019
units have different sound for order_repair and order_build at least in templates
issue is that i unit_actions.js is only command repair and so always is used and played order_repair even if target is just foundation and not damaged building
Sep 3 2019
Aug 27 2019
Aug 17 2019
Aug 16 2019
Aug 15 2019
Aug 9 2019
Jul 28 2019
Fixed in rP22567
@Stan can you please check if it works for you?
Jul 27 2019
just for record there is already similar logic:
Hero Elephant = Hero or Elephant
Hero+Elephant = Hero and Elephant
!Hero = no Hero
Jul 26 2019
Jul 25 2019
Reason for this issue with VS2013 is that memset was removed and looks like vs13 does not do default initialisation of that values.
If vs13 is only compiler having that problem, then we should cut off vs13 build already with D1396 since this is making vs13 builds not functional at all.
Grid.h(234): Assertion failed: "0 <= i && i < m_W && 0 <= j && j < m_H"
This introduced Access violation reading from ticket: https://trac.wildfiregames.com/ticket/5539 not fixed by later patch.
Jul 24 2019
Fixed in rP22544
Build on windows is green, no crashes related to glsl or postprocessing, sound plays in atlas as should.