Page MenuHomeWildfire Games

Angen
User

User Details

User Since
Jul 28 2017, 4:19 PM (164 w, 6 d)

Recent Activity

Mon, Sep 21

Angen updated subscribers of D3009: Refactor UpdateMessageSubscriptions in CCmpRangeOverlayRenderer.
Mon, Sep 21, 2:16 PM

Sun, Sep 20

Angen added a comment to rP24053: [Petra/AI]Handle 0 case for template parsing.

Fixes: #5823

Sun, Sep 20, 11:50 AM
Angen committed rP24053: [Petra/AI]Handle 0 case for template parsing.
[Petra/AI]Handle 0 case for template parsing
Sun, Sep 20, 11:49 AM
Angen closed D3010: Handle 0 case for template parsing.
Sun, Sep 20, 11:49 AM
Angen accepted rP23847: Use victory conditions json's in Atlas.
Sun, Sep 20, 11:41 AM

Sat, Sep 19

Krinkle awarded D3004: Do not display right click tooltip when it is not supported right now a Orange Medal token.
Sat, Sep 19, 3:51 AM
Krinkle awarded rP24024: Clean Formation.js a Love token.
Sat, Sep 19, 3:48 AM

Thu, Sep 17

Angen added a comment to D2494: [gameplay] overhaul artillery attacks.

Addition of splash damage story
http://irclogs.wildfiregames.com/2012-02/2012-02-06-QuakeNet-%230ad-dev.log

Thu, Sep 17, 5:20 PM
Angen added a comment to D2985: [gui] omit resource trickle and loot from attack & resistance tooltip.

instead of removing this information, maybe it could be moved to extended version of tooltip

Thu, Sep 17, 1:27 PM
Angen added inline comments to D2652: Do not allow upgrading when entity is producing and vice versa..
Thu, Sep 17, 8:55 AM
Angen added inline comments to D2652: Do not allow upgrading when entity is producing and vice versa..
Thu, Sep 17, 8:29 AM

Wed, Sep 16

Angen added a comment to D3010: Handle 0 case for template parsing.

I do not see ai getting any valueable information knowing that some was defined as null instead of undefined.
metal: null equals to not including that line at all from simulation point of view so should be the same as `undefined'.

Wed, Sep 16, 8:18 PM
Angen added inline comments to D3010: Handle 0 case for template parsing.
Wed, Sep 16, 7:58 PM
Angen updated the diff for D2652: Do not allow upgrading when entity is producing and vice versa..

Fix research.
O (2*n) for filter so O (n).

Wed, Sep 16, 7:41 PM
Angen accepted D3010: Handle 0 case for template parsing.

thank you

Wed, Sep 16, 5:55 PM

Tue, Sep 15

Angen added a reviewer for D3009: Refactor UpdateMessageSubscriptions in CCmpRangeOverlayRenderer: Restricted Owners Package.
Tue, Sep 15, 12:51 PM
Angen published D3009: Refactor UpdateMessageSubscriptions in CCmpRangeOverlayRenderer for review.
Tue, Sep 15, 12:51 PM
Angen committed rP24041: Remove branch from InParabolicRange.
Remove branch from InParabolicRange
Tue, Sep 15, 12:12 PM
Angen awarded D3008: Correctize cost tooltip for upgrades a Like token.
Tue, Sep 15, 11:54 AM

Sat, Sep 12

Angen updated the diff for D2460: Implement placeholder text for input fields and get rid of hack with mod filter.

refactor
@vladislavbelov thnx

Sat, Sep 12, 3:05 PM

Fri, Sep 11

Angen accepted D2997: Remove visibleclasses from guiinterface.

removing visibleclasses from guiinterface is reasonable
tooltips get data directly from template
petra does not call guiinterface
I did not check usefulness of other things in getentitystate

Fri, Sep 11, 9:58 PM
Angen accepted D2980: Get dropsite resources from simulation..

anyway

Fri, Sep 11, 9:37 PM
Angen added a comment to D2980: Get dropsite resources from simulation..

1.) Looks fine
2.) I think dropsite types could be displayed somewhere for already build structure, just like gather rates are

Fri, Sep 11, 9:33 PM
Angen accepted rP23374: Gamesetup class rewrite, fixes #5322, refs #5387..
Fri, Sep 11, 9:25 PM
Angen committed rP24037: Read correctly 0/false values from map files in gamesetup.
Read correctly 0/false values from map files in gamesetup
Fri, Sep 11, 9:24 PM
Angen closed D2982: Read correctly 0/false values from map files in gamesetup.
Fri, Sep 11, 9:24 PM
Angen added a comment to D2791: Do not attempt to gather when full on that resource.

1.) At first look it is good
2.) In my opinion unit should try to store current resource if they differ as well, but that may be another diff
3.) If there is no dropsite, it would fail after moving to resource anyway, but it would be near point where player expects it to go when gives that order, I think it could be confusing why it is not moving, maybe we could inform player that unit failed to find dropsite for given resource (just idea)

Fri, Sep 11, 9:04 PM
Angen requested changes to D3005: Range safe buildingAI.
Fri, Sep 11, 8:40 PM
Angen added a comment to D2983: Reduces memory usage for fancy water.

Left diff, right svn. Looks good by me.

Fri, Sep 11, 8:20 PM
wraitii awarded rP24034: Cheer after combat when no enemy units are in range a 100 token.
Fri, Sep 11, 9:24 AM

Thu, Sep 10

Angen updated the diff for D2652: Do not allow upgrading when entity is producing and vice versa..

check for cmpplayer and add test

Thu, Sep 10, 7:26 PM
Angen committed rP24034: Cheer after combat when no enemy units are in range.
Cheer after combat when no enemy units are in range
Thu, Sep 10, 6:37 PM
Angen closed D1977: Cheer after no enemy entities left in range.
Thu, Sep 10, 6:37 PM
Angen updated the diff for D2982: Read correctly 0/false values from map files in gamesetup.

MapSize.js
WorldPopulationCap.js

Thu, Sep 10, 6:10 PM
Angen added inline comments to D2661: Get attack effects from JSON..
Thu, Sep 10, 3:40 PM
Angen requested changes to D2661: Get attack effects from JSON..
a = class a { constructor() {console.log('constructor')} }
a = new a();
a = new a();

output

constructor
error: Uncaught TypeError: a is not a constructor
Thu, Sep 10, 3:36 PM
Angen added a comment to rP20622: Render the range visualization of auras, heal and attack component in a….

I missed in code where are m_EnabledRenderSubmit or m_EnabledInterpolate used?
Looks like they are here just for switch, they can be merged as always or are both enabled or both disabled.
Also that two ifs can be merged.

Thu, Sep 10, 3:24 PM
Angen added a comment to D2661: Get attack effects from JSON..

Is it attack effect or attack type ?

Thu, Sep 10, 2:35 PM

Wed, Sep 9

Angen added a comment to D2652: Do not allow upgrading when entity is producing and vice versa..

disabled buttons

Wed, Sep 9, 6:35 PM
Angen added a comment to D2652: Do not allow upgrading when entity is producing and vice versa..
In D2652#131397, @Stan wrote:

Can we support playing a sound ?

Wed, Sep 9, 5:49 PM
Angen requested changes to D2161: Also account for elevation for melee units..

Right now,
range queries for melee units perfectly matches their range attacks,
range queries for ranged units does not because they use the same non-parabolic query as rest of units.
May be because performance or because no-one bothered to give them parabolic queries. I believe there is ticket for that. Anyway that causes ranged units to get targets which are actually out of range or not get targets that would be in parabolic range.

Wed, Sep 9, 4:27 PM
Angen accepted D2334: Fix restartColorFade being passed too many arguments.

missed in https://code.wildfiregames.com/rP14702

Wed, Sep 9, 4:12 PM
Angen added a reviewer for D2723: Add support for hotloading of sound-related files: Restricted Owners Package.
Wed, Sep 9, 3:57 PM
Angen added inline comments to D2961: Fix issues in RangeManager following rP23769.
Wed, Sep 9, 3:49 PM
Angen added inline comments to D2980: Get dropsite resources from simulation..
Wed, Sep 9, 3:41 PM
Angen requested changes to D2980: Get dropsite resources from simulation..
Wed, Sep 9, 3:37 PM
Angen updated the summary of D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Wed, Sep 9, 10:48 AM
Angen added a comment to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.

no, thats just my english, thank you

Wed, Sep 9, 10:48 AM
Angen added inline comments to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Wed, Sep 9, 8:59 AM
Angen added inline comments to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Wed, Sep 9, 8:34 AM

Tue, Sep 8

Angen planned changes to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.

dummy
(a+b)*(a+b) != a*a + b*b

Tue, Sep 8, 10:58 PM
Angen updated the diff for D2652: Do not allow upgrading when entity is producing and vice versa..

let jenkins complain about intendation

Tue, Sep 8, 10:43 PM
Angen updated the test plan for D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Tue, Sep 8, 10:39 PM
Angen updated the diff for D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Tue, Sep 8, 10:37 PM
Angen planned changes to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Tue, Sep 8, 10:30 PM
Angen updated the diff for D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.

use correct elevation range calculation

Tue, Sep 8, 10:24 PM
Angen accepted rP23925: Improve ship pickup..
Tue, Sep 8, 7:29 PM
Angen added inline comments to D2755: Don't store the gatherers per player..
Tue, Sep 8, 4:17 PM
Angen added inline comments to D2652: Do not allow upgrading when entity is producing and vice versa..
Tue, Sep 8, 2:19 PM

Mon, Sep 7

Angen requested review of D2652: Do not allow upgrading when entity is producing and vice versa..
Mon, Sep 7, 7:53 PM
Angen updated the diff for D2652: Do not allow upgrading when entity is producing and vice versa..

inline :)
commas

Mon, Sep 7, 7:52 PM
Angen committed rP24028: Shrink selection panel icons.
Shrink selection panel icons
Mon, Sep 7, 7:37 PM
Angen closed D2875: [gui] shrink selection panel icons.
Mon, Sep 7, 7:36 PM
Angen committed rP24027: [Petra] update usage of Elephant class.
[Petra] update usage of Elephant class
Mon, Sep 7, 7:25 PM
Angen closed D2964: [ai/petra] improve elephant class usage.
Mon, Sep 7, 7:25 PM
Angen added inline comments to D2652: Do not allow upgrading when entity is producing and vice versa..
Mon, Sep 7, 2:59 PM
Angen added a comment to rP23925: Improve ship pickup..

I did build of rP23924 and then rP23925. It was not present before this commit.

Mon, Sep 7, 10:38 AM
Angen added a comment to D3004: Do not display right click tooltip when it is not supported right now.

sure, if that diff makes it to a24, it would be great

Mon, Sep 7, 8:29 AM

Sun, Sep 6

Angen accepted D2875: [gui] shrink selection panel icons.
Sun, Sep 6, 5:01 PM
Angen requested review of D3004: Do not display right click tooltip when it is not supported right now.
Sun, Sep 6, 4:45 PM
Angen added a comment to D2875: [gui] shrink selection panel icons.

e.g. trees

Sun, Sep 6, 4:38 PM
Angen added a comment to D2875: [gui] shrink selection panel icons.

action buttons in midle panel could be moved a bit lower,
Also player/civilisation bar is too close to entity name in brackets, for some entities it overlaps a bit. Does not happen in a23b.

Sun, Sep 6, 4:19 PM
Angen committed rP24024: Clean Formation.js.
Clean Formation.js
Sun, Sep 6, 4:09 PM
Angen closed D3001: Clean Formation.js.
Sun, Sep 6, 4:09 PM
Angen added inline comments to D3001: Clean Formation.js.
Sun, Sep 6, 4:01 PM
Angen requested review of D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.
Sun, Sep 6, 3:58 PM
Angen added inline comments to D3001: Clean Formation.js.
Sun, Sep 6, 3:44 PM
Angen updated subscribers of D3001: Clean Formation.js.
Sun, Sep 6, 3:25 PM
Angen updated the diff for D3001: Clean Formation.js.
Sun, Sep 6, 3:24 PM
Angen updated subscribers of D3001: Clean Formation.js.
Sun, Sep 6, 3:11 PM
Angen updated the diff for D3001: Clean Formation.js.
Sun, Sep 6, 1:58 PM
Angen added a comment to D2875: [gui] shrink selection panel icons.

Sun, Sep 6, 1:45 PM
Angen requested changes to D2875: [gui] shrink selection panel icons.
Sun, Sep 6, 1:41 PM
Angen planned changes to D3001: Clean Formation.js.
Sun, Sep 6, 1:32 PM
Angen updated the diff for D3001: Clean Formation.js.

more comments

Sun, Sep 6, 1:30 PM
Angen added inline comments to D3001: Clean Formation.js.
Sun, Sep 6, 1:28 PM
Angen updated the diff for D1977: Cheer after no enemy entities left in range.

rebase + animal state

Sun, Sep 6, 1:14 PM
Angen added a reviewer for D3001: Clean Formation.js: Restricted Owners Package.
Sun, Sep 6, 12:58 PM
Angen abandoned D2414: Do not send Screen height, width to shader if not needed [On Hold].
Sun, Sep 6, 12:56 PM
Angen updated the diff for D3001: Clean Formation.js.
Sun, Sep 6, 12:45 PM
Angen raised a concern with rP23925: Improve ship pickup..

Form formation at the start, it will never-ever move.
Formation controller is blocked by cc obstruction while stucked in it.

Sun, Sep 6, 12:38 PM
Angen planned changes to D3001: Clean Formation.js.

more jenkins

Sun, Sep 6, 12:37 PM
Angen requested review of D3001: Clean Formation.js.
Sun, Sep 6, 12:35 PM
Angen committed rP24023: [UnitAI] inline last if in ShouldChaseTargetedEntity.
[UnitAI] inline last if in ShouldChaseTargetedEntity
Sun, Sep 6, 11:19 AM
Angen accepted D2732: Allow to guard a guard..

Looks and works good.
IMO one should create diff to get guarding units closer if possible so they mostly ends up in guarding range then mostly not.

Sun, Sep 6, 11:06 AM
Angen accepted D2989: Reuse "APPROACHING"-state in formation combat..

nice find

Sun, Sep 6, 10:45 AM
Angen accepted D2964: [ai/petra] improve elephant class usage.

Ai works without errors.
As I think it would be good to make use of support elephant aura while building, mobile dropsite is more valuable moreover since ai has only one worker elephant.
Removing Champion class from siege unit check is ok-ish, as champion melee elephants are only melee elephant svn currently has.
Rest removals and changes to Unit class are ok.
I do not like unrelated style changes but idc too much.
Thank you for the patch.

Sun, Sep 6, 10:38 AM
Angen resigned from D2998: Do not hardcode attacktypes in the engine/Atlas.
Sun, Sep 6, 10:01 AM

Sat, Sep 5

Angen updated the diff for D2982: Read correctly 0/false values from map files in gamesetup.
Sat, Sep 5, 7:07 PM
Angen updated the diff for D2982: Read correctly 0/false values from map files in gamesetup.

rest for true/false

Sat, Sep 5, 6:46 PM