Page MenuHomeWildfire Games

Angen
User

User Details

User Since
Jul 28 2017, 4:19 PM (130 w, 4 d)

Recent Activity

Yesterday

Angen committed rP23454: Disband formation instead destroying.
Disband formation instead destroying
Tue, Jan 28, 8:31 PM
Angen created D2602: Rephrase formation disabled tooltip after rP23450.
Tue, Jan 28, 8:21 PM
Angen updated the summary of D2601: Do not create range query with no enemies.
Tue, Jan 28, 7:37 PM
Angen updated subscribers of D2601: Do not create range query with no enemies.
Tue, Jan 28, 7:35 PM
Angen updated the diff for D2601: Do not create range query with no enemies.
Tue, Jan 28, 7:34 PM
Angen added a comment to D1674: Check translations for sprintf errors.

can it be done that only approved translations are pulled from transifex?

Tue, Jan 28, 4:32 PM
Angen added inline comments to rP23450: Enforce formation required member count.
Tue, Jan 28, 12:14 PM
Angen added inline comments to rP23450: Enforce formation required member count.
Tue, Jan 28, 11:24 AM

Mon, Jan 27

Angen added inline comments to D2601: Do not create range query with no enemies.
Mon, Jan 27, 8:27 PM
Angen planned changes to D2601: Do not create range query with no enemies.
Mon, Jan 27, 8:26 PM
Angen updated the diff for D2601: Do not create range query with no enemies.

tests + one more relevant case

Mon, Jan 27, 8:23 PM
Angen created D2601: Do not create range query with no enemies.
Mon, Jan 27, 7:43 PM
Angen committed rP23450: Enforce formation required member count.
Enforce formation required member count
Mon, Jan 27, 6:49 PM
Angen closed D1462: Enforce formation required member count.
Mon, Jan 27, 6:49 PM
Angen requested changes to D1768: Formations: GetClosestMember passes wrong entity to filter function.

Since several svn changes in unitAi, I still can see broken behaviour when the same target can be chosen in infinite loop because stance is not taken into account. Think about hold ground and last reachable formation member just died, so even closest formation member exists, it will be refused to chase over and over again, mainly because that part done by state switch and no passing new attack order.

Mon, Jan 27, 6:40 PM
Angen accepted D2328: Unify GetRange calls in UnitAI..

Changes are correct by code.
Removing some code changes needed for D1958, so that one is easier to review.

Mon, Jan 27, 6:19 PM
Angen added a comment to D2360: Fix entities not retaining repair order after target transforms..

Thank you for patch :)

Mon, Jan 27, 6:16 PM
Angen committed rP23449: Fix entities not retaining repair order after target transforms.
Fix entities not retaining repair order after target transforms
Mon, Jan 27, 6:14 PM
Angen closed D2360: Fix entities not retaining repair order after target transforms..
Mon, Jan 27, 6:14 PM
Angen added a comment to D2281: Status Effects v2 - More cleanup, allow modifiers..

Thank you for patch :)

Mon, Jan 27, 5:54 PM
Angen accepted rP22901: GUI support for Status Effects and extend their functionality to all attack….

Fixed in rP23448

Mon, Jan 27, 5:52 PM
Angen committed rP23448: Allow status effect to apply modifiers and fix rP22901.
Allow status effect to apply modifiers and fix rP22901
Mon, Jan 27, 5:52 PM
Angen closed D2281: Status Effects v2 - More cleanup, allow modifiers..
Mon, Jan 27, 5:52 PM

Thu, Jan 23

Angen accepted D2281: Status Effects v2 - More cleanup, allow modifiers..

Classic StatusEffect applies.
StatusEffect with modifiers applies modifiers to target.
When effect has duration, it is removed after duration ends.
StatusEffect with interval deals damage correctly to target.
Tooltip with effect for attack is displayed correctly when hovering over attack details.
Tooltip with applied effect is displayed correctly when hovering over effect icon.

Thu, Jan 23, 7:25 PM
Angen accepted D2360: Fix entities not retaining repair order after target transforms..

Changed code is good.
Number of builders is correctly updated when repaired entity is transformed.
Builders continue to repair/construct when target is renamed.

Thu, Jan 23, 6:52 PM

Wed, Jan 22

Angen added inline comments to D2360: Fix entities not retaining repair order after target transforms..
Wed, Jan 22, 8:57 AM

Sun, Jan 19

Angen added inline comments to D2328: Unify GetRange calls in UnitAI..
Sun, Jan 19, 9:46 PM
Angen committed rP23416: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].
Remove not needed checks and code for VS2015 [VS2013 -> VS2015]
Sun, Jan 19, 1:44 PM
Angen closed D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].
Sun, Jan 19, 1:44 PM
Angen added inline comments to D2328: Unify GetRange calls in UnitAI..
Sun, Jan 19, 1:39 PM
Angen added inline comments to D2360: Fix entities not retaining repair order after target transforms..
Sun, Jan 19, 1:32 PM

Fri, Jan 17

Angen updated the diff for D1462: Enforce formation required member count.

rebase

Fri, Jan 17, 11:40 AM
Angen committed rP23409: Allow to garrison animals..
Allow to garrison animals.
Fri, Jan 17, 10:41 AM
Angen closed D1961: Let animals be able to garrison..
Fri, Jan 17, 10:40 AM
Angen added a comment to D1727: Update auras when a formation member renames..

Thank you for patch.

Fri, Jan 17, 10:35 AM
Angen committed rP23408: Update auras when a formation member renames.
Update auras when a formation member renames
Fri, Jan 17, 10:33 AM
Angen closed D1727: Update auras when a formation member renames..
Fri, Jan 17, 10:33 AM
Angen updated the diff for D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].

rebase

Fri, Jan 17, 10:02 AM
Angen added inline comments to D2453: Allow Flying objects to be stationnary.
Fri, Jan 17, 9:21 AM
Angen requested changes to D2360: Fix entities not retaining repair order after target transforms..

some small things

Fri, Jan 17, 9:12 AM

Thu, Jan 16

Angen added a comment to D2510: [gameplay] change phase requirements.

maybe it would be worth to take a look how much time and res it would cost ptol to reach next phase compared to some civ with most expensive required buildings with taking time to gather needed resources into account.

Thu, Jan 16, 3:16 PM
Angen added inline comments to D2453: Allow Flying objects to be stationnary.
Thu, Jan 16, 1:41 PM
elexis awarded D2573: Fix AI OOS on rejoin related to random calls a Dat Boi token.
Thu, Jan 16, 12:32 PM
Angen added a comment to D1997: Make resource entities keep their visibility when converted to resources..

Personally I think fauna shouldn't be visible in fog-of-war

agree

Thu, Jan 16, 10:39 AM
Angen added a comment to D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].

Those are wrong
source/lib/pch/pch_warnings.h:#if MSC_VERSION <= 140
source/lib/pch/pch_warnings.h:#if MSC_VERSION <= 140

Thu, Jan 16, 10:02 AM
Angen added a comment to D2360: Fix entities not retaining repair order after target transforms..

It would be better to write new function SetBuilders and pass whole array at once.
Next advantage is that all builders would be added at once and there will be just one message send.

Thu, Jan 16, 9:57 AM
Angen added a comment to D2510: [gameplay] change phase requirements.

I am not sure that forcing to build corral is good idea, maybe add house. Player should have some freedom when it comes to choosing how he wants to gather food. This way that would mean wasted resources if player does not plan to train animals. (just my point of view)

Thu, Jan 16, 9:35 AM
Angen added a comment to D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].
Thu, Jan 16, 8:31 AM
Angen raised a concern with rP22901: GUI support for Status Effects and extend their functionality to all attack….
Thu, Jan 16, 8:14 AM

Wed, Jan 15

Angen updated the summary of D2573: Fix AI OOS on rejoin related to random calls.
Wed, Jan 15, 8:37 PM
Angen updated the Trac tickets for D2573: Fix AI OOS on rejoin related to random calls.
Wed, Jan 15, 8:35 PM
Angen created D2573: Fix AI OOS on rejoin related to random calls.
Wed, Jan 15, 8:33 PM

Tue, Jan 14

Angen accepted D1961: Let animals be able to garrison..

Code changes are good and code works as expected.
Animal does not enter INDIVIDUAL state from GARRISON state.

Tue, Jan 14, 7:14 PM
Angen added a comment to D1634: Fert random map..
In D1634#107361, @nani wrote:
  • What is a fert?

Nothing. Made up. I initially wanted to name it "King of the hill" but sounded too cheesy. An alternative would be to translate it to Latin or such. Google tells me "king of the hill" in Latin is "Rex Monte" which sounds OK.

Tue, Jan 14, 3:53 PM

Mon, Jan 13

Angen created D2565: Lower number of setdefaultanimation calls in gathering state.
Mon, Jan 13, 6:26 PM
Angen added inline comments to D2453: Allow Flying objects to be stationnary.
Mon, Jan 13, 10:06 AM
Angen added a comment to rP23267: Fix promoted entities not retaining order queue after rP22753..

Fixes bug reported as comment in ticket: https://trac.wildfiregames.com/ticket/5610#comment:2

Mon, Jan 13, 9:53 AM
Angen requested changes to D2328: Unify GetRange calls in UnitAI..

I can see why that would be wanted for IID_Attack or IID_Heal but IID_Vision should be excluded from this.

Mon, Jan 13, 9:37 AM
Angen added a reviewer for D2328: Unify GetRange calls in UnitAI.: Angen.
Mon, Jan 13, 8:54 AM
Angen requested changes to D2453: Allow Flying objects to be stationnary.

+ rotation of entity needs to be fixed as pointed above

Mon, Jan 13, 8:21 AM
Angen planned changes to D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].

needs rebase

Mon, Jan 13, 8:18 AM
Angen requested changes to D1961: Let animals be able to garrison..

You missed one case, else should be good i ll test tonight.

Mon, Jan 13, 8:15 AM
Angen accepted D2524: Drop Visual Studio 2013 support.

workspace and premake script updates are correct
workaround explicitly for vs2013 removal is ok
(planed to accept earlier but kind of forgot, sry)

Mon, Jan 13, 8:03 AM

Sun, Jan 12

Angen accepted D1727: Update auras when a formation member renames..

Ah, yes. Thank you for reporting that. Position of unit is invalidated so animation is not setup based on position until next rearrange. We should also check against renaming entities to ones which cannot keep this formation but that is another problem.

Sun, Jan 12, 3:13 PM
Angen committed rP23378: Let splash radius be affected by modifications and rename GetSplashDamage to….
Let splash radius be affected by modifications and rename GetSplashDamage to…
Sun, Jan 12, 2:37 PM
Angen closed D2370: Let splash radius be affected by "ApplyValueModificationsToEntity"..
Sun, Jan 12, 2:37 PM
Angen committed rP23377: Use specific walking variants when approaching gathering.
Use specific walking variants when approaching gathering
Sun, Jan 12, 2:21 PM
Angen closed D2518: Use specific walking variants when approaching gathering.
Sun, Jan 12, 2:21 PM
Angen updated the diff for D2518: Use specific walking variants when approaching gathering.

use idle animations

Sun, Jan 12, 2:09 PM
Angen added a comment to D2370: Let splash radius be affected by "ApplyValueModificationsToEntity"..

It would be good to add splash radius into tooltips, @Freagarach ping me if you want to do it here or in another diff.

Sun, Jan 12, 1:20 PM
Angen requested changes to D1727: Update auras when a formation member renames..

phalanx
move
promote using dev overlay
wrong animation

Sun, Jan 12, 1:00 PM

Sat, Jan 11

Angen awarded rP23371: Tool idle animations, and improvement of cape movement on walking with tools. a Love token.
Sat, Jan 11, 7:37 PM

Fri, Jan 10

Angen added a comment to rP22718: Animations re-export "Variant Update".

Fixed in rP23358.

Fri, Jan 10, 11:36 AM
Angen accepted rP22718: Animations re-export "Variant Update".
Fri, Jan 10, 11:36 AM
Angen planned changes to D2518: Use specific walking variants when approaching gathering.

Needs idle variants of approaching animtions because units sometimes stops while walking due obstructions.

Fri, Jan 10, 11:27 AM
Angen committed rP23359: Do not allow to override formation animation variants chosen when walking and….
Do not allow to override formation animation variants chosen when walking and…
Fri, Jan 10, 11:03 AM
Angen closed D2556: Do not allow to override formation animation variants chosen when walking and define remaining combat variants.
Fri, Jan 10, 11:03 AM
Angen committed rP23358: Fix missing phalanx animations.
Fix missing phalanx animations
Fri, Jan 10, 10:33 AM
Angen closed D2555: Fix missing phalanx animations.
Fri, Jan 10, 10:33 AM
Angen committed rP23357: Fix units not reentering FORMATIONMEMBER.IDLE when no orders left.
Fix units not reentering FORMATIONMEMBER.IDLE when no orders left
Fri, Jan 10, 10:31 AM
Angen closed D2558: Fix units not reentering FORMATIONMEMBER.IDLE when no orders left.
Fri, Jan 10, 10:31 AM
Angen updated the summary of D2558: Fix units not reentering FORMATIONMEMBER.IDLE when no orders left.
Fri, Jan 10, 10:22 AM
Angen created D2558: Fix units not reentering FORMATIONMEMBER.IDLE when no orders left.
Fri, Jan 10, 10:17 AM
Angen created D2556: Do not allow to override formation animation variants chosen when walking and define remaining combat variants.
Fri, Jan 10, 9:46 AM

Thu, Jan 9

Angen accepted D2370: Let splash radius be affected by "ApplyValueModificationsToEntity"..

Patch looks good, it is removing one code duplicity, Damage -> Data is correct since return type is object with more information than damage values.
Idea itself adds option for techs and auras in mods to change radius of splash damage what is generally good.

Thu, Jan 9, 11:24 PM
Angen created D2555: Fix missing phalanx animations.
Thu, Jan 9, 11:08 PM
Angen committed rP23353: Set last carried resource after promotion/transformation.
Set last carried resource after promotion/transformation
Thu, Jan 9, 10:21 PM
Angen closed D2471: Set last carried resource after promotion.
Thu, Jan 9, 10:21 PM
Angen updated the summary of D2471: Set last carried resource after promotion.
Thu, Jan 9, 10:06 PM
Angen updated the diff for D2471: Set last carried resource after promotion.
Thu, Jan 9, 10:02 PM
Angen committed rP23352: Support order defined animation variants for formation.
Support order defined animation variants for formation
Thu, Jan 9, 9:53 PM
Angen closed D2550: Support order defined animation variats for formation.
Thu, Jan 9, 9:53 PM
Angen updated the diff for D2550: Support order defined animation variats for formation.

comment cleanup

Thu, Jan 9, 9:26 PM
Angen added a comment to D2416: Simplify conditions in SetAnimation.

setting invalid animation to entity without bones. Failed to find use case for that one and logical reasoning. Do you know why that would be usefull?

Thu, Jan 9, 6:08 PM
Angen added a comment to rP15677: Add mod selection mod..

@elexis your last concern was fixed in rP23269, can you confirm and remove it or do you have something else here?

Thu, Jan 9, 2:28 PM
Angen added a comment to rP14115: Move ship to shoreline when tasking units to garrison inside, fixes #1391.

@Freagarach is rP23268 fixing your concern ?

Thu, Jan 9, 2:25 PM
Angen added inline comments to rP23124: Standarize Capes for make them easier to handle..
Thu, Jan 9, 12:26 PM
Angen raised a concern with rP22718: Animations re-export "Variant Update".
Thu, Jan 9, 12:24 PM
Angen added inline comments to rP23124: Standarize Capes for make them easier to handle..
Thu, Jan 9, 11:59 AM
Angen raised a concern with rP23124: Standarize Capes for make them easier to handle..
Thu, Jan 9, 10:27 AM