Page MenuHomeWildfire Games

Angen
User

Projects

User Details

User Since
Jul 28 2017, 4:19 PM (116 w, 1 d)

Recent Activity

Mon, Oct 14

Angen awarded D2372: [WIP] - Support for mining. a Love token.
Mon, Oct 14, 2:07 PM

Thu, Oct 10

Angen added inline comments to D2364: Add an option to display ranges when pressing the showstatusbars hotkey.
Thu, Oct 10, 8:07 AM

Wed, Oct 9

Angen added inline comments to D1958: Turrets and/or sub-units..
Wed, Oct 9, 9:26 AM

Tue, Oct 8

Angen added inline comments to D1958: Turrets and/or sub-units..
Tue, Oct 8, 2:24 PM

Thu, Oct 3

Angen added inline comments to rP23031: Splits Camera control from CGameView to separate file..
Thu, Oct 3, 12:56 PM
Angen added inline comments to rP23031: Splits Camera control from CGameView to separate file..
Thu, Oct 3, 12:55 PM
Angen added inline comments to rP23031: Splits Camera control from CGameView to separate file..
Thu, Oct 3, 8:36 AM
Angen awarded rP23024: New idle relax animations for the hoplite. a Like token.
Thu, Oct 3, 8:28 AM
Angen awarded rP23030: More lifelike idle animations and some new sword attacking animations for… a Love token.
Thu, Oct 3, 8:26 AM

Sat, Sep 28

Angen added inline comments to D1958: Turrets and/or sub-units..
Sat, Sep 28, 1:02 PM

Thu, Sep 26

Angen abandoned D1604: Make capturing optional.
Thu, Sep 26, 5:45 PM

Mon, Sep 23

Angen awarded rP22987: Fix blood sometimes appearing below cattle, because of a variant having a… a Evil Spooky Haunted Tree token.
Mon, Sep 23, 4:52 PM

Sun, Sep 22

Angen updated the diff for D1346: List multiselection.

try to use members as implementation classes

Sun, Sep 22, 8:41 PM
Angen accepted rP22963: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase….

Fixed in rP22965

Sun, Sep 22, 12:19 PM
Angen added a comment to rP22963: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase….

jenkins silently builded the changed code here:
https://jenkins.wildfiregames.com/blue/organizations/jenkins/vs2015-differential/detail/vs2015-differential/277/pipeline

Sun, Sep 22, 11:53 AM
Angen raised a concern with rP22963: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase….

ERROR: CCacheLoader failed to find archived or source file for: "gui/hotkey.xml"

Sun, Sep 22, 10:09 AM

Fri, Sep 20

Angen added a comment to rP22942: Fix latest issues of the old helmets files merge..

#5600

Fri, Sep 20, 6:11 PM
Angen added inline comments to D2308: Extend the visible garrisoning schema to allow specific units on specific turrets..
Fri, Sep 20, 4:53 PM
Angen added inline comments to D2308: Extend the visible garrisoning schema to allow specific units on specific turrets..
Fri, Sep 20, 4:27 PM
Angen updated the diff for D1346: List multiselection.

working version

Fri, Sep 20, 10:21 AM
Angen added a comment to D1346: List multiselection.

There are at least two m_ItemsYPositions and maybe more variables
one from COList
second from CListSingle

Fri, Sep 20, 9:30 AM
Angen planned changes to D1346: List multiselection.
Fri, Sep 20, 7:41 AM

Sep 19 2019

Angen updated the diff for D1346: List multiselection.

something is wrong with olistsingle, olistmultiple

Sep 19 2019, 10:22 PM
Angen planned changes to D1346: List multiselection.
Sep 19 2019, 7:11 PM
Angen updated the diff for D1346: List multiselection.

Single, Multiple class design
Not synchronised with js
OList is Single for now

Sep 19 2019, 7:10 PM
Angen accepted D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

Builds, tests passed, jenkins tests are ok, feature looks good, I do not see more problems in code

Sep 19 2019, 5:06 PM
Angen added a comment to D2304: Delete GUI.h umbrella include.

builds in debug and without pch release

Sep 19 2019, 2:56 PM
Angen added a comment to D825: Atlas: Allow map to recenter during resize.

From Debug build

Sep 19 2019, 1:57 PM
Angen added a comment to D2304: Delete GUI.h umbrella include.

I see two cases when to add header to precompiled.

  1. It is included in a lot of files ( what means more than 15 with small files)
  2. It is big file in terms of code and other includes and is used more than 5 times.
Sep 19 2019, 11:45 AM

Sep 18 2019

Angen added inline comments to D1674: Check translations for sprintf errors.
Sep 18 2019, 7:07 PM
Angen updated the diff for D2276: Add build order to unit commands to play different sounds for build and repair.
Sep 18 2019, 5:06 PM
Angen accepted D2111: [PetraAI] - Do not try to attack entities which can't be attacked..

looks good to me

Sep 18 2019, 11:42 AM
Angen added inline comments to D1946: Windows Differential testing.
Sep 18 2019, 7:28 AM

Sep 17 2019

Angen planned changes to D1946: Windows Differential testing.

try to fail after timeout

Sep 17 2019, 10:33 PM
Angen updated the diff for D1946: Windows Differential testing.

add timeout
fix robocopy

Sep 17 2019, 10:32 PM
Angen updated the diff for D2021: Fix AtlasUI.dll windows autobuild.

fix robocopy

Sep 17 2019, 10:26 PM
Angen accepted rP22909: Fix hotkey events synching with hotkey state..
Sep 17 2019, 9:59 PM
Angen updated the diff for D1946: Windows Differential testing.

robocopy

Sep 17 2019, 9:06 PM
Angen added inline comments to D2281: Status Effects v2 - More cleanup, allow modifiers..
Sep 17 2019, 9:41 AM
Angen updated the Trac tickets for D2276: Add build order to unit commands to play different sounds for build and repair.
Sep 17 2019, 7:12 AM
Angen updated the summary of D2299: Fix test.exe build failing with --jenkins-tests flag.
Sep 17 2019, 6:33 AM

Sep 16 2019

Angen created D2299: Fix test.exe build failing with --jenkins-tests flag.
Sep 16 2019, 9:25 PM
Angen raised a concern with rP22909: Fix hotkey events synching with hotkey state..

broke test.exe build with --jenkins-tests and so jenkins

Sep 16 2019, 9:01 PM
Angen requested changes to D2111: [PetraAI] - Do not try to attack entities which can't be attacked..
Sep 16 2019, 12:04 PM
Angen updated the diff for D2286: Notify renamed entities about value modifications when created.
Sep 16 2019, 10:00 AM

Sep 15 2019

Angen added a comment to D1946: Windows Differential testing.

no, but might be interesting improvement

Sep 15 2019, 6:53 PM
Angen requested changes to D2111: [PetraAI] - Do not try to attack entities which can't be attacked..
Sep 15 2019, 2:43 PM
Angen updated the diff for D2286: Notify renamed entities about value modifications when created.
Sep 15 2019, 1:44 PM
Angen changed the visibility for D1946: Windows Differential testing.
Sep 15 2019, 1:34 PM
Angen updated the diff for D1946: Windows Differential testing.

add flags for gloox and collada
split testing so release tests follow right after build of release version so in case they do not pass, there will be no build of debug version

Sep 15 2019, 1:32 PM
Angen added a comment to D1988: Workaround differences between libc and libstd string stream parsing of float/doubles.

Tests passed

file: source\ps\CStr.cpp
line 195 : [C-style cast]: 		return (long)Pos;
line 206 : [C-style cast]: 		return (long)Pos;
line 217 : [C-style cast]: 		return (long)Pos;
line 232 : [C-style cast]: 		return (long)Pos;
line 242 : [a++ -> ++a]: 	for (size_t i = 0; i < length(); i++)
line 243 : [C-style cast]: 		NewString[i] = (tchar)_totlower((*this)[i]);
line 251 : [a++ -> ++a]: 	for (size_t i = 0; i < length(); i++)
line 252 : [C-style cast]: 		NewString[i] = (tchar)_totupper((*this)[i]);
line 349 : [a++ -> ++a]: 	for (size_t i = 0; i < length(); i++)
line 365 : [C-style cast]: 			ss << "\\u" << std::hex << std::setfill('0') << std::setw(4) << (int)(unsigned char)ch;
line 381 : [a++ -> ++a]: 			for (Left = 0; Left < length(); Left++)
line 396 : [a++ -> ++a]: 			for (Left = 0; Left < length(); Left++)
line 447 : [C-style cast]: 	return (size_t)fnv_hash(data(), length()*sizeof(value_type));
line 448 : Comments should start with capital: 		// janwas 2005-03-18: now use 32-bit version; 64 is slower and
line 461 : [a++ -> ++a]: 	for (i = 0; i < len; i++)
line 483 : [C-style cast]: 		*(str++) = (tchar)native;
line 503 : [C-style cast]: 	Serialize_int_4(buffer, (u32)len);
line 505 : [a++ -> ++a]: 	for (i = 0; i < len; i++)
file: source\ps\tests\test_CStr.h
line 82 : a+ -> a +: 		u8* buf = new u8[len+1];
line 158 : [WARNING]: File is missing include guard
Sep 15 2019, 1:10 PM

Sep 14 2019

Angen added inline comments to D2290: Unify load game and savegame screen.
Sep 14 2019, 6:16 PM

Sep 13 2019

Angen updated the summary of D2286: Notify renamed entities about value modifications when created.
Sep 13 2019, 5:55 PM
Angen added inline comments to rP22767: Add a system component to handle stat modifiers, make technologies and auras….
Sep 13 2019, 5:55 PM
Angen updated subscribers of D2287: Support glooxwrapper::MUCRoom for muc events.
In D2287#95144, @Vulcan wrote:

Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/154/display/redirect

Sep 13 2019, 5:32 PM
Angen updated the diff for D2286: Notify renamed entities about value modifications when created.

less code

Sep 13 2019, 5:26 PM
Angen updated the diff for D2286: Notify renamed entities about value modifications when created.

address comment by wraitii so this fixes also scenario where unit changes ownership and technologies change Health values based on player

Sep 13 2019, 2:27 PM
Angen added a comment to D2175: [WIP] - Basic battalionish support..

Do we want only one type of units in a battalion?

yes, that is one of the basic idea of batalions, but there would be allowed special units like banner carrier, hero, commander.

Sep 13 2019, 2:20 PM
Angen updated the test plan for D2286: Notify renamed entities about value modifications when created.
Sep 13 2019, 2:09 PM
Angen created D2286: Notify renamed entities about value modifications when created.
Sep 13 2019, 2:03 PM

Sep 12 2019

Angen accepted rP21113: Allow random map scripts to load heightmap image files, fixes #5018..

fixed in rP22892

Sep 12 2019, 9:48 PM
Angen updated the diff for D1816: Use all three color channels when loading heightmaps following rP21113.

static cast to ensure u16 result

Sep 12 2019, 9:19 PM
Angen added inline comments to D2285: Inform player that second market is too close to setup trade route.
Sep 12 2019, 7:50 AM

Sep 11 2019

Angen created D2285: Inform player that second market is too close to setup trade route.
Sep 11 2019, 9:18 PM
Angen added inline comments to D2284: Actually dont compile lobby code if building --without-lobby.
Sep 11 2019, 7:58 PM

Sep 10 2019

Angen added inline comments to D2281: Status Effects v2 - More cleanup, allow modifiers..
Sep 10 2019, 7:32 PM
Angen added inline comments to D2281: Status Effects v2 - More cleanup, allow modifiers..
Sep 10 2019, 7:28 PM
Angen added inline comments to D2188: Allow Promotion to add arbitrary modifiers when a unit reaches the next rank instead of changing entities.
Sep 10 2019, 7:06 PM

Sep 9 2019

Stan awarded D2276: Add build order to unit commands to play different sounds for build and repair a 100 token.
Sep 9 2019, 7:50 PM
Angen updated the diff for D2276: Add build order to unit commands to play different sounds for build and repair.

add entry to template, fix repair command back

Sep 9 2019, 7:48 PM
Angen created D2276: Add build order to unit commands to play different sounds for build and repair.
Sep 9 2019, 7:35 PM
Angen added inline comments to D2111: [PetraAI] - Do not try to attack entities which can't be attacked..
Sep 9 2019, 6:16 PM
Angen added inline comments to D2175: [WIP] - Basic battalionish support..
Sep 9 2019, 6:03 PM
Angen added inline comments to D2175: [WIP] - Basic battalionish support..
Sep 9 2019, 3:53 PM
Angen added a comment to D1496: Combat Variant.

yes possibly but first it would be better just have this one as it is a lot faster than computing squares and this just changes unitai code in minimal scale

Sep 9 2019, 3:11 PM

Sep 8 2019

Angen added a comment to D2218: Status Effects v1 - GUI support and fix following rP22754.

yes icons should have own folder

Sep 8 2019, 9:19 AM
Angen awarded D2218: Status Effects v1 - GUI support and fix following rP22754 a Love token.
Sep 8 2019, 9:08 AM

Sep 6 2019

Angen added a comment to P169 Repairable class.

@Stan
units have different sound for order_repair and order_build at least in templates
issue is that i unit_actions.js is only command repair and so always is used and played order_repair even if target is just foundation and not damaged building

Sep 6 2019, 7:13 PM

Sep 3 2019

Angen added inline comments to D2251: AI: replace Cavalry with new Mounted class.
Sep 3 2019, 9:46 AM

Aug 27 2019

Angen awarded rP22773: Fix L10n::FormatMillisecondsIntoDateString memory leak following rP18725, refs… a Like token.
Aug 27 2019, 10:04 AM

Aug 17 2019

Angen awarded rP22682: Use shared_ptr to avoid copying and deleting SGUIImageEffects, 2.5x faster in a… a Love token.
Aug 17 2019, 3:59 PM

Aug 16 2019

Angen added a comment to D1921: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.

builds without-pch

Aug 16 2019, 12:03 PM

Aug 15 2019

Angen added inline comments to D1721: Wind speed computation speed-up.
Aug 15 2019, 10:58 AM
Angen added inline comments to D2176: Give an option to allow multiple controls groups share same entities..
Aug 15 2019, 8:57 AM

Aug 9 2019

Angen updated subscribers of rP22608: Pthread -> std::thread (2/7) - Remove pthread in Profilers.
Aug 9 2019, 11:04 PM

Jul 28 2019

Angen added a comment to rP22425: UnitMotion - Explicit handling of movement errors (such as target death) in….

Fixed in rP22567

Jul 28 2019, 2:08 PM
Angen accepted rP22425: UnitMotion - Explicit handling of movement errors (such as target death) in….
Jul 28 2019, 2:08 PM
Angen added a comment to rP22314: Fix a crash on some system when Alt-tabbing during game setup..

@Stan can you please check if it works for you?

Jul 28 2019, 9:44 AM

Jul 27 2019

Angen added a comment to D2115: Improve support of classes of bonuses..

just for record there is already similar logic:
Hero Elephant = Hero or Elephant
Hero+Elephant = Hero and Elephant
!Hero = no Hero

Jul 27 2019, 6:50 PM

Jul 26 2019

Angen added inline comments to D2115: Improve support of classes of bonuses..
Jul 26 2019, 9:23 AM
Angen added inline comments to D2125: VS2013 Grid.h memset fallback.
Jul 26 2019, 7:15 AM
Angen added a comment to rP22511: Fix the -Wclass-memaccess compiler warning in the pathfinders Grid.h, refs….

This introduced Access violation reading from ticket: https://trac.wildfiregames.com/ticket/5539 not fixed by later patch.

Sure it was this commit? As I understand it's the placement new in rP22545 that is not supported by VS2013?

Jul 26 2019, 7:05 AM

Jul 25 2019

Angen added a comment to rP22511: Fix the -Wclass-memaccess compiler warning in the pathfinders Grid.h, refs….

Reason for this issue with VS2013 is that memset was removed and looks like vs13 does not do default initialisation of that values.
If vs13 is only compiler having that problem, then we should cut off vs13 build already with D1396 since this is making vs13 builds not functional at all.

Jul 25 2019, 4:02 PM
Angen added a comment to rP22511: Fix the -Wclass-memaccess compiler warning in the pathfinders Grid.h, refs….

Grid.h(234): Assertion failed: "0 <= i && i < m_W && 0 <= j && j < m_H"

Jul 25 2019, 3:16 PM
Angen raised a concern with rP22511: Fix the -Wclass-memaccess compiler warning in the pathfinders Grid.h, refs….

This introduced Access violation reading from ticket: https://trac.wildfiregames.com/ticket/5539 not fixed by later patch.

Jul 25 2019, 3:08 PM

Jul 24 2019

Angen added inline comments to D1961: Let animals be able to garrison..
Jul 24 2019, 7:34 PM
Angen added a comment to rP22314: Fix a crash on some system when Alt-tabbing during game setup..

Fixed in rP22544

Jul 24 2019, 6:43 PM
Angen accepted rP22314: Fix a crash on some system when Alt-tabbing during game setup..
Jul 24 2019, 6:42 PM
Angen added inline comments to D2029: Alt+tab fix for rP22314 - call IdleTask in Atlas and swap buffers only once.
Jul 24 2019, 6:35 PM
Angen accepted D2029: Alt+tab fix for rP22314 - call IdleTask in Atlas and swap buffers only once.

Build on windows is green, no crashes related to glsl or postprocessing, sound plays in atlas as should.

Jul 24 2019, 6:30 PM