Page MenuHomeWildfire Games

Angen
User

Projects

User Details

User Since
Jul 28 2017, 4:19 PM (99 w, 3 d)

Recent Activity

Today

Angen added a comment to rP22314: Fix a crash on some system when Alt-tabbing during game setup..

Bug n 1.
Run game with postprocessing on in fullscreen, alt tab and go back (solved by D1212)
Bug n 2.
Postprocessing on in fullscreen, alt tab while loading match, return back after match started ( original solution https://code.wildfiregames.com/D1495?id=7570) commited version (this)

Tue, Jun 25, 3:21 PM

Thu, Jun 20

Angen added a comment to D1396: Silence C4351.

as we are now compiling game with vs15, this is not needed

Thu, Jun 20, 5:05 PM

Wed, Jun 19

Angen updated the diff for D2001: [AI] Small cleanup in defenseManager.

comments

Wed, Jun 19, 7:07 PM
Angen updated the diff for D2001: [AI] Small cleanup in defenseManager.
Wed, Jun 19, 3:31 PM
Angen updated the summary of D2001: [AI] Small cleanup in defenseManager.
Wed, Jun 19, 7:55 AM
Angen added a comment to D1938: Easier introduction of new damage types..

some comments

Wed, Jun 19, 7:44 AM

Tue, Jun 18

Angen added a reviewer for D2001: [AI] Small cleanup in defenseManager: Restricted Owners Package.
Tue, Jun 18, 8:51 PM
Angen created D2001: [AI] Small cleanup in defenseManager.
Tue, Jun 18, 8:29 PM
Angen added a comment to D1938: Easier introduction of new damage types..

common-ai is supposed to be independent from any ai created upon it.

Tue, Jun 18, 8:16 PM
Angen added a reviewer for D1994: Fix missing slash in common-api: Restricted Owners Package.
Tue, Jun 18, 9:11 AM

Mon, Jun 17

Angen updated the summary of D1994: Fix missing slash in common-api.
Mon, Jun 17, 5:28 PM
Stan awarded D1994: Fix missing slash in common-api a Like token.
Mon, Jun 17, 3:37 PM
Angen created D1994: Fix missing slash in common-api.
Mon, Jun 17, 3:34 PM
Angen added a comment to rP22314: Fix a crash on some system when Alt-tabbing during game setup..
In rP22314#34004, @Stan wrote:

This breaks sounds for me. I believe that maybe g_SoundManager->IdleTask(); gets called too often ?

Does it break sound always? Or only if you minimised?
Can you try:

  • Putting SwapBuffers()s in the main loop after Render();
  • Putting the same if for the sound manager as for Render();

It has to be one of these two.

Mon, Jun 17, 9:05 AM

Sun, Jun 16

Angen added a comment to D1977: Change Cheering.

A lot actually depends on stance which defines LOS of unit which dictates if it will find new targets or not.
Unit will probably not cheer if is in defensive stance and will move back to held position.

Sun, Jun 16, 11:09 AM
Angen updated the diff for D1977: Change Cheering.

forgot to remove part of condition related to cheering at line 3235

Sun, Jun 16, 10:31 AM
Angen updated the diff for D1977: Change Cheering.
Sun, Jun 16, 10:27 AM

Sat, Jun 15

Angen planned changes to D1977: Change Cheering.

cheering after won combat, removing cheering on promotion

Sat, Jun 15, 9:09 PM
Angen updated the diff for D1977: Change Cheering.
Sat, Jun 15, 8:51 PM
Angen added inline comments to D1977: Change Cheering.
Sat, Jun 15, 8:06 PM
Angen created D1977: Change Cheering.
Sat, Jun 15, 7:31 PM
Angen updated the diff for D1879: Fix limit restriction for training units in ProductionQueue .

final changes

Sat, Jun 15, 6:46 PM
Angen updated the diff for D1879: Fix limit restriction for training units in ProductionQueue .

one more comment

Sat, Jun 15, 12:52 PM
Angen updated the diff for D1879: Fix limit restriction for training units in ProductionQueue .
Sat, Jun 15, 12:07 PM
Angen updated the diff for D1879: Fix limit restriction for training units in ProductionQueue .

removed one not needed comment ( I think it is easy to see from if what is going on there)

Sat, Jun 15, 12:05 PM
Angen added inline comments to D1973: Enable support for friendly fire for normal ranged attacks..
Sat, Jun 15, 10:55 AM

Mon, Jun 10

Angen created D1967: Fix wrong actor file for persian cavalry javelinist when gathering meat.
Mon, Jun 10, 10:10 AM
Angen retitled D1966: Remove duplication of attack variant from actor file from Remove duplicate of attack variant from actor file to Remove duplication of attack variant from actor file.
Mon, Jun 10, 8:49 AM
Angen created D1966: Remove duplication of attack variant from actor file.
Mon, Jun 10, 8:48 AM

Sun, Jun 9

Angen updated the diff for D1964: Fix chasing behaviour.

check in update move is not needed as ATTACKING.enter does the decision what to do if cannot reach or can reach or go to idle

Sun, Jun 9, 9:23 PM
Angen added a comment to rP22345: Move "IsInRange" family of functions to the Obstruction Manager and make the….

@Freagarach test D1964, some bugs may be resolved

Sun, Jun 9, 9:03 PM
Angen created D1964: Fix chasing behaviour.
Sun, Jun 9, 8:49 PM
Angen added inline comments to D1897: UnitMotion - Split Move() into several functions.
Sun, Jun 9, 7:10 PM
Angen added inline comments to D1893: Drop an indentation level in UnitMotion.
Sun, Jun 9, 6:47 PM
Angen added a comment to rP22345: Move "IsInRange" family of functions to the Obstruction Manager and make the….

next:
animals walking on place after feeling
ranged units not responding on attack commands

Sun, Jun 9, 9:55 AM
Angen added a comment to rP22345: Move "IsInRange" family of functions to the Obstruction Manager and make the….

I am not sure if it was this but some commit with unitmotion and range check.
When any unit is tasked to attack animal which flee (or anything which will flee) it follows it but does not stop to attack when target is in range but keeps following until target does not stop and then attacks.

Sun, Jun 9, 9:20 AM

Sat, Jun 8

Angen updated the diff for D1959: Show helmets and capes while gathering and carrying meat.

missed one

Sat, Jun 8, 1:41 PM
Angen created D1959: Show helmets and capes while gathering and carrying meat.
Sat, Jun 8, 1:39 PM
Angen added a comment to D1954: Do not send Reflection and Refraction matrices to shader when not needed.

Vladislav told he will look into his older patch, I tried to but cannot solve it, unless we remove something but it might lower performance.

Sat, Jun 8, 11:17 AM
Angen added a comment to D1954: Do not send Reflection and Refraction matrices to shader when not needed.

@gameboy not related to water problem

Sat, Jun 8, 10:37 AM

Fri, Jun 7

Angen added a comment to D1958: [PATCH] Turrets and/or sub-units.

attack animation does not play

Fri, Jun 7, 9:57 PM
Angen added inline comments to D1958: [PATCH] Turrets and/or sub-units.
Fri, Jun 7, 9:16 PM
Angen added a comment to D1958: [PATCH] Turrets and/or sub-units.

some comments

Fri, Jun 7, 9:08 PM
Angen added a comment to D1955: Support for phenotype-tag in VisualActor..

yes, needs to be serialised

Fri, Jun 7, 8:32 PM
Angen added inline comments to D1851: First try of an automated exploring method..
Fri, Jun 7, 8:19 PM
Angen updated the diff for D1943: UnitAI fix return value on "enter" according to FSM logic.
Fri, Jun 7, 1:46 PM

Wed, Jun 5

Angen planned changes to D1940: UnitAI cleanup [GATHER].

needs rebase

Wed, Jun 5, 10:51 PM
Angen planned changes to D1943: UnitAI fix return value on "enter" according to FSM logic.

needs rebase

Wed, Jun 5, 10:51 PM
Angen added a comment to D1915: pthread -> std::thread (1/?) - Clean up ThreadUtil.

builds, tests passed (Release, Debug)

Wed, Jun 5, 10:02 PM
Angen added inline comments to D1956: Additional fixes following rP22313 - units no longer return to gather nearby resources when depleting a chicken/tree/....
Wed, Jun 5, 9:38 PM
Angen added inline comments to D1915: pthread -> std::thread (1/?) - Clean up ThreadUtil.
Wed, Jun 5, 8:08 PM
Angen added a comment to D1915: pthread -> std::thread (1/?) - Clean up ThreadUtil.

I got these
Profiler2.h(454): error C3646: 'm_TLS': unknown override specifier
Profiler2.h(454): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int

Wed, Jun 5, 8:02 PM
Angen added inline comments to D1954: Do not send Reflection and Refraction matrices to shader when not needed.
Wed, Jun 5, 5:44 PM
Angen updated the diff for D1954: Do not send Reflection and Refraction matrices to shader when not needed.
Wed, Jun 5, 5:44 PM
Angen added inline comments to D1851: First try of an automated exploring method..
Wed, Jun 5, 5:12 PM
Angen commandeered D1954: Do not send Reflection and Refraction matrices to shader when not needed.
Wed, Jun 5, 4:26 PM
Angen added inline comments to D1938: Easier introduction of new damage types..
Wed, Jun 5, 2:27 PM
Angen added a comment to D1954: Do not send Reflection and Refraction matrices to shader when not needed.

I would leave intendation, because it is easier to read.
Used already in this file and some others: terrain_common.vs, terrain_common.fs, model_waterfall.vs, model_waterfall.fs, model_water.fs::get_shadow, model_common.*

Wed, Jun 5, 2:18 PM
Angen added a comment to D1938: Easier introduction of new damage types..

I guess because Resources = new Resources(); in resources.js

Wed, Jun 5, 1:07 PM
Angen added a comment to D1938: Easier introduction of new damage types..

I think you cannot directly. Probably you would need to define some function in aiinterface or aiproxy. At least for now please fix that armour thing for ai so if someone will remove some armour damage from template it will not bug.

Wed, Jun 5, 12:36 PM
Angen created D1954: Do not send Reflection and Refraction matrices to shader when not needed.
Wed, Jun 5, 11:43 AM
Angen added inline comments to D1938: Easier introduction of new damage types..
Wed, Jun 5, 9:27 AM
Angen added a comment to D1938: Easier introduction of new damage types..
let attackStrength = ent.attackStrengths(type);

get values from this

Wed, Jun 5, 9:00 AM

Tue, Jun 4

Angen accepted D1909: Version and update the Windows autobuilder script.
Tue, Jun 4, 4:41 PM
Angen added a comment to D1948: Adds Camera test for ortho projection.

All tests passed

Tue, Jun 4, 1:07 PM

Mon, Jun 3

Angen accepted rP21612: A little cleanup of the PatchRData.cpp..

Fixed in rP22334

Mon, Jun 3, 10:28 PM
Angen accepted D1949: Fixes mistypes introduced in rP21612.

Cannot reproduce water refraction bug and water looks cool -> accept

Mon, Jun 3, 9:48 PM
Angen raised a concern with rP21612: A little cleanup of the PatchRData.cpp..

now I found it

Mon, Jun 3, 8:04 PM
Angen added a comment to rP22023: Always leave/reenter the top-most FSM state when SetNextState is called with….

yes the problem is fixed for me

Mon, Jun 3, 7:44 PM
Angen added a comment to rP22039: Remove hardcoded SkyBox sizes and use the infinity sky. No we render.

I followed history of changes of water_high.fs and this was the first time I got water refraction issue, but looks like it is not the problem of shader as I thought

Mon, Jun 3, 6:52 PM
Angen accepted rP22039: Remove hardcoded SkyBox sizes and use the infinity sky. No we render.
Mon, Jun 3, 6:51 PM
Angen raised a concern with rP22039: Remove hardcoded SkyBox sizes and use the infinity sky. No we render.
Mon, Jun 3, 6:04 PM
Angen accepted rP22310: Fix red squares on some maps when using HQ water effects.

This is making my reported problem only more visible (refraction water effect). Adding screenshot before this commit. Not sure which cause it.

Mon, Jun 3, 3:07 PM
Angen updated the diff for D1462: Enforce formation required member count.

do not display formation when no unit is allowed to use it
(leaving older checks so it would be easier to revert if this would be rejected)

Mon, Jun 3, 2:28 PM
Angen added a reviewer for D1944: Fix mod list not enabling/disabling correct mod when applied filter: Restricted Owners Package.
Mon, Jun 3, 1:24 PM
Angen requested changes to D1851: First try of an automated exploring method..

aside from comments needs rebase

Mon, Jun 3, 12:37 PM
Angen updated the diff for D1909: Version and update the Windows autobuilder script.

fix robocopy return code

Mon, Jun 3, 9:08 AM

Sun, Jun 2

Angen added inline comments to D1909: Version and update the Windows autobuilder script.
Sun, Jun 2, 11:32 PM
Angen added a comment to D1936: Load damageTypes from "simulation/data/damagetypes"-files..

please fix unit tests

Sun, Jun 2, 8:45 PM
Angen added a comment to D1943: UnitAI fix return value on "enter" according to FSM logic.
In D1943#80577, @Stan wrote:

Can you write a test for this ? :) Dunno how hard it is.

I think test for this would be too complex to make correctly and maybe impossible as there are so many cases when state could be changed

Sun, Jun 2, 5:32 PM
Angen updated the diff for D1909: Version and update the Windows autobuilder script.

commit debuged gloox, remove some tests

Sun, Jun 2, 10:06 AM

Sat, Jun 1

Angen added a reviewer for D1943: UnitAI fix return value on "enter" according to FSM logic: Restricted Owners Package.
Sat, Jun 1, 10:47 PM
Angen added a comment to D1944: Fix mod list not enabling/disabling correct mod when applied filter.

fixing problem in rP15677

Sat, Jun 1, 10:38 PM
Angen added inline comments to D1944: Fix mod list not enabling/disabling correct mod when applied filter.
Sat, Jun 1, 10:35 PM
Angen created D1944: Fix mod list not enabling/disabling correct mod when applied filter.
Sat, Jun 1, 10:28 PM
Angen created D1943: UnitAI fix return value on "enter" according to FSM logic.
Sat, Jun 1, 9:00 PM
Angen updated the diff for D1909: Version and update the Windows autobuilder script.

thnx to @Stan testing stage works ( like worked before but now I know it works )

Sat, Jun 1, 6:50 PM
Angen updated the diff for D1940: UnitAI cleanup [GATHER].

Acording to FSM return false = return (void) or no return
Only found behaviour was that if return true somethings happen or return true and discard order

Sat, Jun 1, 11:07 AM

Fri, May 31

Angen added inline comments to D1940: UnitAI cleanup [GATHER].
Fri, May 31, 11:41 PM
Angen retitled D1940: UnitAI cleanup [GATHER] from UnitAI cleanup [Gathering] to UnitAI cleanup [GATHER].
Fri, May 31, 10:54 PM
Angen updated the diff for D1940: UnitAI cleanup [GATHER].

extend

Fri, May 31, 10:54 PM
Angen accepted rP22280: Make the ai aware ranges no longer have the barracks class.
Fri, May 31, 10:51 PM
Angen planned changes to D1909: Version and update the Windows autobuilder script.
Fri, May 31, 10:16 PM
Angen updated the diff for D1909: Version and update the Windows autobuilder script.

move output to script thnx @Stan

Fri, May 31, 10:16 PM
Angen added a comment to rP21751: petra: allow the ai to use ranges for mod who support them, and add Archery….

Before this commit:
let numStables = this.canBuild(gameState, "structures/{civ}_stables") ? gameState.getOwnEntitiesByClass("Stables", true).length : -1;
other civs than pers could not build it so numStables = -1 nothing happens for them

Fri, May 31, 9:58 PM
Angen added inline comments to D1940: UnitAI cleanup [GATHER].
Fri, May 31, 9:27 PM
Angen updated the diff for D1940: UnitAI cleanup [GATHER].

upercase and one more rename

Fri, May 31, 9:26 PM
Angen planned changes to D1909: Version and update the Windows autobuilder script.
Fri, May 31, 9:11 PM
Angen updated the diff for D1909: Version and update the Windows autobuilder script.

fix

Fri, May 31, 9:11 PM
Angen added a comment to rP21751: petra: allow the ai to use ranges for mod who support them, and add Archery….
In rP21751#33686, @mimo wrote:

Could you explain what is the point of raising a concern on a commit when the problem is created by a posterior commit? maybe just give some feeling of activity?

Fri, May 31, 8:56 PM