@wraitii extend this diff or make another one?

We should realise that current behaviour returns only INVALID ENTITY if filter is passed what is cmpAttack. CanAttack and there is check if target is enemy esle returns false. So clearly unit cannot attack itself as is not enemy of itself.

In unitAi healer filters possible targets with injured mark using Health.prototype.IsUnhealable function (and another checks) so unit with maxed health is not healed and stays injured and checked in next search if still in range.

If it marked as injured, healers get it as unit to heal. So if unit with maxed health would be marked as as injured, healers would waist their time for unit that does not need it. I think, can someone think that this is not good change and disagree ?

Simple change, which is correct so can be committed.

In D1752#70510, @ffffffff wrote:

for what u need it

1900 is msc version for VS2015

some suggestions

fix manual comments (checking comments later)

fix spy, AI _string, palisade and structure tree

can someone take look at this ?

removed not implemented and other comments

It goes -> enter IDLE -> Find Targets -> Order.Attack -> cannot reach -> finishorder -> leave and enter IDLE -> ...

@Itms no logs no dump files, no errors. Just crash. Btw build date is messed up.

Adding replays. I had no luck to reproduce bug itself by playing on this revision, but replays keep crashing after pressing No and waiting some time.
What does not uppon 22022

Atlas loads, generates, saves maps -> ok
no error or crash in game starting different maps

@s0600204 can be commited ?

Fix tooltip for upgrade as that component is still using exactly one technology, and some comments.

missing renaming

Make getRequiredTechnologyTooltip nicer and update AI.

yes it is fixed

Also, if you place rally point and you click onto building to remove it, it stays visible.

I think there is side bar on the left on unit picture when selected and this one is above the head of unit.

So a bit of research and test builds as well.
https://docs.microsoft.com/en-us/previous-versions/1ywe7hcy(v=vs.140)

It is down there as Add Action choice

So far I can tell that warnings are solved. I did not try to run game with this patch yet.

The sprintf argument %(trained)s used by the translation “Štatistika jednotiek (%(trained)s / %(killed)s / %(captured)s / %(lost)s)” isn't a present in the template string “Siege” “”

s0600204 comments

Update years and revert third party files

Or another idea for geters upon pointers like g_Game is that if called upon null, throw exception and remove unneded checks in code. So getGame should never be called when is not initialised.

Fix Capital Letters

Renaming did not applied another files

->backlog

missing files

fix missing ;

move functionality for possible formation check to entity state

why do I have to read terms of services every single time I want to connect? It is annoying and time consuming.

Show formations when someone can be part of it.

In D1262 have been added version check for warning C4351, which was not correct and because of that, warning have been enabled again for VS2013. I have no idea how VS2015 managed to not display this warning since version did not satisfy needed version check to disable this warning.

small update

Key up, key down

new variant, that tries to match @vladislavbelov comment

ok, so @wraitii and @vladislavbelov make decision. I do not care what exactly will be in comment.

moving condition into render function and comment change

update wnuma.cpp because year in file have changed

In D1495#61322, @elexis wrote:

So should this not become an early return in Render() rather than having the condition twice (if one needs fixing the other will be forgotton) and possibly missing in a third place?