Bug n 1.
Run game with postprocessing on in fullscreen, alt tab and go back (solved by D1212)
Bug n 2.
Postprocessing on in fullscreen, alt tab while loading match, return back after match started ( original solution https://code.wildfiregames.com/D1495?id=7570) commited version (this)

as we are now compiling game with vs15, this is not needed

comments

some comments

common-ai is supposed to be independent from any ai created upon it.

In rP22314#34010, @wraitii wrote:

In rP22314#34004, @Stan wrote:

This breaks sounds for me. I believe that maybe g_SoundManager->IdleTask(); gets called too often ?

Does it break sound always? Or only if you minimised?
Can you try:

• Putting SwapBuffers()s in the main loop after Render();
• Putting the same if for the sound manager as for Render();

It has to be one of these two.

A lot actually depends on stance which defines LOS of unit which dictates if it will find new targets or not.
Unit will probably not cheer if is in defensive stance and will move back to held position.

forgot to remove part of condition related to cheering at line 3235

cheering after won combat, removing cheering on promotion

final changes

one more comment

removed one not needed comment ( I think it is easy to see from if what is going on there)

check in update move is not needed as ATTACKING.enter does the decision what to do if cannot reach or can reach or go to idle

@Freagarach test D1964, some bugs may be resolved

next:
animals walking on place after feeling
ranged units not responding on attack commands

I am not sure if it was this but some commit with unitmotion and range check.
When any unit is tasked to attack animal which flee (or anything which will flee) it follows it but does not stop to attack when target is in range but keeps following until target does not stop and then attacks.

missed one

Vladislav told he will look into his older patch, I tried to but cannot solve it, unless we remove something but it might lower performance.

@gameboy not related to water problem

attack animation does not play

some comments

yes, needs to be serialised

needs rebase

needs rebase

builds, tests passed (Release, Debug)

I got these
Profiler2.h(454): error C3646: 'm_TLS': unknown override specifier
Profiler2.h(454): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int

I would leave intendation, because it is easier to read.
Used already in this file and some others: terrain_common.vs, terrain_common.fs, model_waterfall.vs, model_waterfall.fs, model_water.fs::get_shadow, model_common.*

I guess because Resources = new Resources(); in resources.js

I think you cannot directly. Probably you would need to define some function in aiinterface or aiproxy. At least for now please fix that armour thing for ai so if someone will remove some armour damage from template it will not bug.

let attackStrength = ent.attackStrengths(type);

get values from this

All tests passed

Fixed in rP22334

Cannot reproduce water refraction bug and water looks cool -> accept

now I found it

yes the problem is fixed for me

I followed history of changes of water_high.fs and this was the first time I got water refraction issue, but looks like it is not the problem of shader as I thought

This is making my reported problem only more visible (refraction water effect). Adding screenshot before this commit. Not sure which cause it.

do not display formation when no unit is allowed to use it
(leaving older checks so it would be easier to revert if this would be rejected)

aside from comments needs rebase

fix robocopy return code

please fix unit tests

In D1943#80577, @Stan wrote:

Can you write a test for this ? :) Dunno how hard it is.

I think test for this would be too complex to make correctly and maybe impossible as there are so many cases when state could be changed

commit debuged gloox, remove some tests

fixing problem in rP15677

thnx to @Stan testing stage works ( like worked before but now I know it works )

Acording to FSM return false = return (void) or no return
Only found behaviour was that if return true somethings happen or return true and discard order

extend

move output to script thnx @Stan

Before this commit:
let numStables = this.canBuild(gameState, "structures/{civ}_stables") ? gameState.getOwnEntitiesByClass("Stables", true).length : -1;
other civs than pers could not build it so numStables = -1 nothing happens for them

upercase and one more rename

fix

In rP21751#33686, @mimo wrote:

Could you explain what is the point of raising a concern on a commit when the problem is created by a posterior commit? maybe just give some feeling of activity?