Update message

All user chosen settings are persisted when changing the selected map or maptype, except where the selected map overwrites the setting value and except for Scenario maps which still use the default value where the map doesn't specify the setting value.

In D4305#183896, @Jammyjamjamman wrote:

In D4305#183890, @Angen wrote:

There is still issue.
If map does not define attribute and you switch maps, the attribute from previous map will carry over so you will end up with 2 and possibly more settings for the same scenario map depending from which one you switch.

As far as I can tell, this bug exists in A25, but I've fixed it in this patch :).

The original logic done by elexis was as follows as far as i remember:
If map defines some property, that property should be set and locked from changes.
If map does not define property, preciously set property by player or one from persistent match settings should be used.
Current issue with scenario maps is, even if property is missing from the map, value cannot be changed by player.
Notice we have this issue only with scenarios because they are locked by default.
Other maps should not get values reset.
This probably happens with other settings, will need to check that.

There is still issue.
If map does not define attribute and you switch maps, the attribute from previous map will carry over so you will end up with 2 and possibly more settings for the same scenario map depending from which one you switch.

Or generated placeholderText could get valign parameter and adjust position internally.
If someone would want to adjust such a position on another places.

@Freagarach do you plan to commit this as it is right now?

hmm, yes, but thats again /mod dependent on /public
probably would need to move it to /mod
also, need a way to get remaining time

Ok, i get it now

Wait, didn't you say they are promoted to next rank?

Yes, but you can see in tooltip that required is 150, so why calculation above produces trash

Anyway why is req 0

Put brakets around req || 1, its faster than doing max

More like req || 1 but if entity is promoted, division by 0 should not happen

Looks like code tries to devide by 0.
experienceSize.rtop = 100 - (100 * Math.max(0, Math.min(1, 1.0 * +entState.promotion.curr / +entState.promotion.req)));
Another question is, if someone places _b rank but required promotion is 0, shouldnt that entity be promoted on the start of the match?

what happens when you place basic mercenary on map and runs it normally in game?
Maybe would be worth to check also the code.

I would not obstruct main icon, make the pause thing small and move it to the corner

They cannot be repaired, damaged, constructed, do not provide any resource or aura. There is curently no value letiting player to select the bridges. It can even make selecting/commanding units near these entities a bit complicated, so i would just keep it as is in this diff with only actors and not entities.

small changes, also trigger bots

In D3544#183142, @Freagarach wrote:

Or even move the responsibility of keeping the correct position to the members. (And get back into formation when we become idle.)

There was this commit:
https://code.wildfiregames.com/rP24037
negated by
https://code.wildfiregames.com/rP25077

why

damn, forgot linter

Thank you for the patch

It allows to recruit also another units than mercenaries.
It should be investigated what is actually goal here.
Because now it looks like regular barracks with additional merc units for specific civ.
So tooltip is wrong anyway.

rebase and some cleaning

the functions don't do what they were expected to do?
Looks to me like getEntsByKeyInverse returned something wrong?

Why not to fix getEntsByKeyInverse instead?

Only issue with number as string being key in dropdown is that it depends how is written in config 1.0 and 1.00 or 1 will dispay as 100% in dropdown now, but will not work with dropdown having string as keys

https://wildfiregames.com/forum/topic/56568-petra-having-problems-with-fishing-on-maps-with-water-available/?do=findComment&comment=454690

open trade card from top menu
switch to observer, go back to player, missing buttons

You mean after inserting erease code rP25634

while doing it you could merge branches

Looks better

I have to dissagree, openPage is called when you open profile page, not on its creation

Do you mean setguiscale to take string and parse number from it?

I wanted to add new line and it send it instead. So here we go:

When @Ceres want to be in credits, they can make differential, from last info I know they did not want to be there

get it out of queue again

Thanks for the patch

@Langbart can you close this?
thanks

Yes, you need to re-upload the diff, phabricator does not support direct editing.

You could fix the spacing around { } as comment says, but if no, commiter will do it

@Ceres no big deal, i am just wondering why it is not starting with ps/trunk/
patch applies, so dont worry about it too much

Message is translated correctly.
Issue was sprintf replaced %(unit)s before message was going to be translated so string was never found in dictionary.
Introduced in rP24148