Page MenuHomeWildfire Games

Angen
User

User Details

User Since
Jul 28 2017, 4:19 PM (173 w, 6 d)

Recent Activity

Yesterday

Angen added a reverting change for rP23283: Treat min range in the same manner as max range when computing goal: rP24264: Revert rP23283.
Thu, Nov 26, 4:52 PM
Angen added a reverting change for D2512: Treat min range in the same manner as max range when computing goal: rP24264: Revert rP23283.
Thu, Nov 26, 4:52 PM
Angen committed rP24264: Revert rP23283.
Revert rP23283
Thu, Nov 26, 4:52 PM
Angen closed D3148: Revert rP23283.
Thu, Nov 26, 4:52 PM
Angen resigned from D3126: Fix MSVC 2015 Warnings for C++14.
Thu, Nov 26, 3:48 PM
Angen updated the summary of D3149: [Petra] do not pass min == max range in moveToRange.
Thu, Nov 26, 1:44 PM
Angen published D3149: [Petra] do not pass min == max range in moveToRange for review.
Thu, Nov 26, 1:42 PM
Angen published D3148: Revert rP23283 for review.
Thu, Nov 26, 1:21 PM

Wed, Nov 25

Angen added a comment to rP23283: Treat min range in the same manner as max range when computing goal.

I broke minimum range for units with bigger passability classes #5864 here.
Looks like fix of the bug worked just because they treated it as stucked so ships stopped dancing around.
After reading the huge TODO comment above affected lines, one cannot pass minrage = maxrange, so for now I just should force Petra to dont do it.

Wed, Nov 25, 2:05 PM
Angen added a comment to D3142: Using same value for unit and terrain ambient colors #2: skirmishes maps..

I think I like units ambient colour more, with terrain ambient it is a bit blue-ish.

Wed, Nov 25, 1:32 PM

Tue, Nov 24

Angen added a reviewer for D3141: Approach build animation: Restricted Owners Package.
Tue, Nov 24, 9:16 PM
Angen published D3141: Approach build animation for review.
Tue, Nov 24, 9:12 PM
Angen added inline comments to D3126: Fix MSVC 2015 Warnings for C++14.
Tue, Nov 24, 8:21 PM

Mon, Nov 23

Angen requested changes to D2646: Remove special Animal state..

chickens will not move away from foundation

Mon, Nov 23, 8:31 PM
Angen added a comment to rP24238: Fix OS detection on Windows 10..

#3299

Mon, Nov 23, 1:17 PM
Angen added inline comments to D3129: More header tweaks.
Mon, Nov 23, 10:31 AM

Sat, Nov 21

Angen added inline comments to D3130: Updates for compiling with VS2017.
Sat, Nov 21, 7:09 PM
Angen added inline comments to D3126: Fix MSVC 2015 Warnings for C++14.
Sat, Nov 21, 4:27 PM
Angen added inline comments to D3126: Fix MSVC 2015 Warnings for C++14.
Sat, Nov 21, 4:21 PM

Fri, Nov 20

Angen requested changes to D3126: Fix MSVC 2015 Warnings for C++14.

why are you removing size_t ?

Fri, Nov 20, 7:40 PM
Angen added a comment to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Why is source/gui/Scripting/JSInterface_GUIProxy_impl.h h file ?
Is there strong reason why it cannot have h and cpp parts?

Fri, Nov 20, 8:38 AM

Thu, Nov 19

Angen added inline comments to D3109: Fix tab buttons not playing sounds.
Thu, Nov 19, 7:30 PM
Angen added inline comments to D2646: Remove special Animal state..
Thu, Nov 19, 7:26 PM
Angen added inline comments to D3109: Fix tab buttons not playing sounds.
Thu, Nov 19, 7:16 PM
Angen requested changes to D2646: Remove special Animal state..
Thu, Nov 19, 7:10 PM

Wed, Nov 18

Angen added inline comments to rP24200: Fix building without precompiled headers..
Wed, Nov 18, 12:41 PM
Angen resigned from D2860: Notify players with a sound when a player is defeated.
Wed, Nov 18, 7:50 AM

Mon, Nov 16

Angen accepted D3081: Make cheering time moddable.

ok, one can use disable=""
changes are good, allowing to disable cheer completle for certain units if needed
modability from template is also good addition

Mon, Nov 16, 3:18 PM
Angen added a comment to D3081: Make cheering time moddable.

as far as I know one can disable just components but I may be mistaken, need to try it

Mon, Nov 16, 2:19 PM
Angen added a comment to D3081: Make cheering time moddable.

One issue, one cannot disable cheeringtime in children templates.

Mon, Nov 16, 12:24 PM
Angen committed rP24191: Cancel packing orders by Stop command.
Cancel packing orders by Stop command
Mon, Nov 16, 10:33 AM
Angen closed D3105: Allow to cancel (un)packing with H.
Mon, Nov 16, 10:33 AM
Angen added a comment to D3081: Make cheering time moddable.

if I recall correctly there should be at least one more order.cheer

Mon, Nov 16, 9:41 AM

Sun, Nov 15

Angen updated the Trac tickets for D3105: Allow to cancel (un)packing with H.
Sun, Nov 15, 5:20 PM
Angen published D3105: Allow to cancel (un)packing with H for review.
Sun, Nov 15, 5:07 PM

Sat, Nov 14

Angen abandoned D3004: Do not display right click tooltip when it is not supported right now.

rP24184

Sat, Nov 14, 7:27 PM
Angen resigned from D3100: Jenkins autobuild fixes.

I have no actual knowledge about these linux scripts.
Having this established, does diff run on the same workspace as svn?
I thought they are different.

Sat, Nov 14, 7:24 PM
Angen accepted D2651: Allow right-click on disabled buttons..

For the purpose of showing templates with right click on disabled buttons, this looks good.
There is small difference with sound, but we would need to add variable to every button and enable right click with it if disabled from js and we would have just one rightclick event as now. On the other hand we would have separate varaibles deciding if specific button actions are enabled.
If someone really wants that click sound fix, one should change the approach.

Sat, Nov 14, 7:03 PM
Angen added inline comments to D3081: Make cheering time moddable.
Sat, Nov 14, 6:46 PM
Angen added inline comments to D3081: Make cheering time moddable.
Sat, Nov 14, 6:32 PM
Angen added inline comments to D3081: Make cheering time moddable.
Sat, Nov 14, 5:00 PM
Angen requested changes to D3081: Make cheering time moddable.
Sat, Nov 14, 4:31 PM
Angen requested changes to D3081: Make cheering time moddable.

agree with bb, you need to discard order now when cheering time is 0

Sat, Nov 14, 3:16 PM

Tue, Nov 10

Angen added a comment to D3081: Make cheering time moddable.

then make it just template value and unitai will not serialised it

Tue, Nov 10, 11:57 AM

Mon, Nov 9

Angen added a comment to rP24139: Always update preview in biome and landscape.

it is using random as biome so we should have mainland_random preview file, and because we do not have, it keeps one currently set and when opening first time, it keeps default one

Mon, Nov 9, 5:28 PM
Angen added inline comments to D3076: Decouple LOS resolution from terrain resolution.
Mon, Nov 9, 4:37 PM
Angen added a comment to D3075: Identify host session via being on the same process..

your locale copy or jenkins is outdated, it fails to apply patch

Mon, Nov 9, 1:05 PM
Angen added inline comments to D3075: Identify host session via being on the same process..
Mon, Nov 9, 1:03 PM

Sun, Nov 8

Angen awarded D3073: Use player color for rally point lines in SOW a Like token.
Sun, Nov 8, 7:38 PM
Angen added inline comments to D2814: Allow remapping hotkeys from inside the game / fix QWERTY hotkeys.
Sun, Nov 8, 12:38 PM
Angen added inline comments to D2814: Allow remapping hotkeys from inside the game / fix QWERTY hotkeys.
Sun, Nov 8, 12:36 PM

Sat, Nov 7

Angen added a comment to rP24137: Fix the random slowdowns and speedups on AMD CPUs for Windows.
Sat, Nov 7, 4:33 PM
Angen accepted rP23392: Landscape and Daytime gamesetup options for the Unknown, Danubius and Polar Sea….
Sat, Nov 7, 4:31 PM
Angen committed rP24139: Always update preview in biome and landscape.
Always update preview in biome and landscape
Sat, Nov 7, 4:26 PM
Angen closed D3041: Always update preview in biome and landscape.
Sat, Nov 7, 4:26 PM
Angen added a comment to D2759: Update range queries to account for entity size.

I might blunder but it looks correct to me:

Sat, Nov 7, 2:55 PM
Angen added a comment to rP24041: Remove branch from InParabolicRange.

Just proof that inParabolicRange computation here and in UnitAi is the same

Sat, Nov 7, 1:51 PM
Angen added a comment to D2814: Allow remapping hotkeys from inside the game / fix QWERTY hotkeys.

I tested it and it works good on all my keyboard layouts. I did not test atlas.
I once noticed it wrote,,, in key editor but I am not sure how I triggered it.

Sat, Nov 7, 11:28 AM
Angen added a comment to rP24137: Fix the random slowdowns and speedups on AMD CPUs for Windows.

did it fix https://trac.wildfiregames.com/ticket/5760?

Sat, Nov 7, 9:17 AM

Fri, Nov 6

Angen added inline comments to D2814: Allow remapping hotkeys from inside the game / fix QWERTY hotkeys.
Fri, Nov 6, 6:35 PM
Angen added inline comments to D2614: Also store turret position in map file..
Fri, Nov 6, 5:32 PM

Thu, Nov 5

Angen added inline comments to D2814: Allow remapping hotkeys from inside the game / fix QWERTY hotkeys.
Thu, Nov 5, 4:26 PM

Wed, Nov 4

Angen added inline comments to rP19432: Fix the aiming code when performing an attack. Reviewed by wraitii..
Wed, Nov 4, 10:08 PM
Angen added inline comments to D2940: Move some position-related functions to PositionHelper..
Wed, Nov 4, 9:57 PM
Angen added inline comments to D2940: Move some position-related functions to PositionHelper..
Wed, Nov 4, 8:10 PM
Angen added inline comments to D2940: Move some position-related functions to PositionHelper..
Wed, Nov 4, 8:03 PM

Tue, Nov 3

Angen requested changes to D2814: Allow remapping hotkeys from inside the game / fix QWERTY hotkeys.

It broke zooming with mouse wheel

Tue, Nov 3, 7:19 PM

Sun, Nov 1

Angen added a comment to D2651: Allow right-click on disabled buttons..

1.) disabled icons are clickable
2.) there is sound difference when clicking with right click enabled and disabled, there is no release sound for disabled button but dont know if it id doable and to not brake current sound state

Sun, Nov 1, 11:29 AM

Sat, Oct 31

Angen added inline comments to D2651: Allow right-click on disabled buttons..
Sat, Oct 31, 4:53 PM

Wed, Oct 28

Angen added inline comments to D3049: Allow disabling error messages.
Wed, Oct 28, 6:13 PM

Oct 26 2020

Angen updated the diff for D3041: Always update preview in biome and landscape.

add landscape as it has similar issue, notice for unknown map, if biome map would exists, it would need to be unknown_{biome} and would be
currently displayed for any type of landscape if biome would be switched, now with this diff the landscape stays selected

Oct 26 2020, 8:02 PM

Oct 24 2020

Angen committed rP24109: Fix handling of fixed ai defined by map after rP23419.
Fix handling of fixed ai defined by map after rP23419
Oct 24 2020, 2:19 PM
Angen closed D3038: Fix handling of fixed ai defined by map after rP23419.
Oct 24 2020, 2:14 PM
Angen added a comment to rP23566: React to target death properly when chasing.

well. i have got the replay and found when it happens but i cant reproduce it outside the replay with entity promotion, entity death or ownership change.

Oct 24 2020, 2:08 PM
Angen added a comment to D3046: Add FPV to dev-panel..

lol i had no idea this exists :D
although i do not know if this would be helpful for dev overlay, but some mods may want to use it for any reason so i would not just remove it as it could be interesting to have

Oct 24 2020, 12:33 PM

Oct 23 2020

Angen added a comment to rP23566: React to target death properly when chasing.

I reproduced it once from 6 runs and even that one case was non visual so I do not have replay

Oct 23 2020, 12:11 PM

Oct 22 2020

Angen added inline comments to D2411: Allow to limit unit count per match..
Oct 22 2020, 6:42 PM
Angen added a comment to rP23566: React to target death properly when chasing.

@vladislavbelov thank you, you can mark this red, I try to check this evening

Oct 22 2020, 12:07 PM

Oct 19 2020

Angen added inline comments to D2646: Remove special Animal state..
Oct 19 2020, 5:13 PM
Angen planned changes to D3041: Always update preview in biome and landscape.
Oct 19 2020, 1:46 PM
Angen added inline comments to rP23392: Landscape and Daytime gamesetup options for the Unknown, Danubius and Polar Sea….
Oct 19 2020, 1:30 PM

Oct 17 2020

Angen published D3041: Always update preview in biome and landscape for review.
Oct 17 2020, 2:51 PM
Angen added inline comments to D3040: Refactors water shader and move normal and specular calculations into separate functions.
Oct 17 2020, 1:24 PM
Angen updated the diff for D3038: Fix handling of fixed ai defined by map after rP23419.

more linter

Oct 17 2020, 12:53 PM
Angen planned changes to D3038: Fix handling of fixed ai defined by map after rP23419.
Oct 17 2020, 10:13 AM

Oct 16 2020

Angen updated the diff for D3037: Add gui scale to options.

dropdown, 100%, 125%, 150%, 175%, 200% (1, 1.25, 1.5, 1.75, 2)
show nothing when custom value in config ?

Oct 16 2020, 5:59 PM
Angen updated the diff for D3038: Fix handling of fixed ai defined by map after rP23419.

make linter and Freagarach happy

Oct 16 2020, 5:46 PM

Oct 15 2020

Angen updated the summary of D3038: Fix handling of fixed ai defined by map after rP23419.
Oct 15 2020, 8:16 PM
Angen published D3038: Fix handling of fixed ai defined by map after rP23419 for review.
Oct 15 2020, 8:13 PM
Angen added inline comments to rP23419: Rewrite Gamesetup AIConfig page to use class syntax, decouple settings and move….
Oct 15 2020, 7:44 PM
Angen added a comment to D3034: un-crowdify graphics options panel.

maybe windowed option could be moved somewhere else, e.g. general ?

Oct 15 2020, 5:56 PM
Angen published D3037: Add gui scale to options for review.
Oct 15 2020, 5:49 PM

Oct 13 2020

Angen committed rP24101: Do not use GPUSkinning without glsl [Crash fix].
Do not use GPUSkinning without glsl [Crash fix]
Oct 13 2020, 6:50 PM
Angen closed D2423: Do not use GPUSkinning without glsl [Crash fix].
Oct 13 2020, 6:50 PM

Oct 11 2020

Angen awarded rP24096: Improved patrol icon. Much less like the recycling logo a Like token.
Oct 11 2020, 3:54 PM

Oct 7 2020

Angen accepted D2908: Deny to run the game with Fixed rendering pipeline.
Oct 7 2020, 6:40 PM

Oct 6 2020

Angen requested changes to D2908: Deny to run the game with Fixed rendering pipeline.

Because what title says, and comment above, I have to request changes.

Oct 6 2020, 6:39 PM
Angen added a comment to D2908: Deny to run the game with Fixed rendering pipeline.

For continue removal completeness, one can still ignore error window on windows using x when application continues execution.

Oct 6 2020, 6:33 PM
Angen accepted D2908: Deny to run the game with Fixed rendering pipeline.

I tested it with renderpath = "fixed" in combination with preferglsl = "true" and preferglsl = "false".
In both cases, error window appeared and application closed successfully.
Only break and exit actions have been available.
Codewise implementation looks reasonable.

Oct 6 2020, 6:19 PM

Oct 4 2020

Angen added a comment to D2908: Deny to run the game with Fixed rendering pipeline.

After pressing continue and application closing, I got this:

Oct 4 2020, 12:42 PM