Reason of this diff is to move Preprocessor file to third party files, what is completed and moving a file does not break its functionality.

This patch does step 1 "moving" and the next one will do the "update part"

Tests are passing.
Shader errors are reported.
From what I have seen shaders do work as without patch.
If it is third party file it should be in that folder.

This might work now, but it will not with D1462 or if we disband formation with less than 2 members as that is done anyway after lonely units in formation gets order. In that cases formation cannot be disbanded because member was renamed.

Unit packs and unpacks as expected. Unit correctly cancels unpacking or continue packing when is ordered to move somewhere.
Issue when player cannot move unpacked siege unit because enemy is in range and unit keeps unpacking have been solved in this diff in the way, player does not have to click to cancel unpacking manually but just gives order to move.
LeaveFoundation works as expected for packable units and stays the same for other.

Unit packs and unpacks as expected. Unit correctly cancels unpacking or continue packing when is ordered to move somewhere.
Issue when player cannot move unpacked siege unit because enemy is in range and unit keeps unpacking have been solved in this diff in the way, player does not have to click to cancel unpacking manually but just gives order to move.

code that takes care about renamed entities is shorter, cleaner and mostly correct.

Some more comments before i forget.

moved to subdirectory
moving revert ahead of deletions so ugly spamming like in https://code.wildfiregames.com/differential/diff/10454/ will not happen

what i said above

I did not test it yet nor looked into replace order function.
I ll do later (just dont want to loose my notes)

MoveToGarrisonRange should not contain pickup logic.
It is expected from function to move unit to target range and return true/false.

It works nice, but there is problem aside small styling.

hmm yes, i wanted that mainly for player, because petra would have advantage as she see whole map.
but realistically, if you see someone runs on top of hill and then down, you dont see him anymore but you know where he went :)

' -> "

remove debug printf
do profiling

optional variant, have fun

Fixed in rP23141 and rP23187 also removing similar issue in rP23147

good point

Since you just copy that textures, why just not to reuse the original directly?
If artists will want to add special texture for them, they will re-upload them anyway,

When I applied the patch, it failed to get pictures so i had to copy them manually.
Aside from that, looks good and works.

Code looks good, feature should work as intended by reading the code.
I see usage mainly in that player does not have to select entity, he can just hover over it to see progress.
I would maybe consider to add option into the settings or somehow toogle between show always and show default.

In D2440#101799, @elexis wrote:

It would be a good feature, although I guess in the average case only high level of detail will be shown, since the camera is top down on average?

move interval to each actor
check distance only if actor defines that it has lod versions
disable/enable lod from graphic options

fix misstyped file name

Let Cheer surrounding units only if are IDLE, do not cheer if last target was animal or unit has building ai.

one more thing aside inline before ok, I just noticed that cart defense tower should not use specific cart scaf because it has its own stairs and they are doubled, looks weird.

I think it would need to go closer a bit too to look good. Now there is a pretty big gap.

Notes:
ptolemies/defense_tower: pls add <prop actor="props/structures/decals/spart_1x1.xml" attachpoint="root"/>
romans/scout_tower pls add <prop actor="props/structures/romans/rome_tower_wood.xml" attachpoint="root"/>
actually roman siege wall is about the size of palisade in height, maybe scaf should go off there too, I think it is a bit off by height and width

The feature looks good and it is nice visual update. Before accepting it I found two bigger problems and some smaller.
So this needs to be fixed:
Mace sentry and defence towers loose their windows, doors and other important props while in upgrade animations.
Rome defence tower is loosing also some wooden props which changes its overall look significantly.

With this patched applied, I confirm formationmember in IDLE state now correctly reaches this.isIdle = true, which is important information for AI (Petra) and GUI.
As this is fixing reported issue and do not introduce invalid behaviour (no such was noticed while testing) I accept this patch and agree on to be committed.

Missing animations:
brit_sentry_tower
gaul_sentry_tower

Description says, it is setting variant, but code is selecting animation.
So it should call SetVariant instead :)

see inline comment

Expected behaviour:
entity in IDLE state will always try to attack best suitable (closest and preferred or any closest, not including ignored) target in its range based on stance

I would not create more files just to have special prefix for them
Same I would not mix this diff with file renaming for death_cape, or cape_gather_*

missed attack_slaughter

xml headers + cape_ prefix

Fixed in rP23171, thnx that was fast :)

queued or pushorderfront

how do i have cmpVision there 🗡

Fix discard order
Change comment
Use classic for instead for of, because speed

rebased, something was kicked out from diff

I ll update this but no idea when

Needs rebase, not sure it is worth to do at this state of reviews. Ping me if you want to review this I ll rebase.

Looks like will not get into code anyway so backlog.

I might rewrite it in way it can be set as option before starting of match so one can choose if wants classic or new behaviour of vision.