Page MenuHomeWildfire Games

Angen
User

Projects

User Details

User Since
Jul 28 2017, 4:19 PM (90 w, 12 h)

Recent Activity

Wed, Apr 17

Angen added inline comments to D1769: Do not mark unit as injured when receives 0 damage.
Wed, Apr 17, 3:37 PM

Tue, Apr 16

Angen awarded rP22192: Add missing parenthesis in the Petra diplomacyManager. Else the requested… a Like token.
Tue, Apr 16, 7:41 PM
Angen updated the diff for D1769: Do not mark unit as injured when receives 0 damage.

move comment to better place

Tue, Apr 16, 7:34 PM

Mon, Apr 15

Angen updated the diff for D1769: Do not mark unit as injured when receives 0 damage.

some white spaces and comments

Mon, Apr 15, 9:57 PM
Angen added a comment to D1769: Do not mark unit as injured when receives 0 damage.

I can do separate patch for injured function and to unify this.hittpoints calling but I do not see reason for this diff to wait for it :)

Mon, Apr 15, 9:15 PM
Angen added inline comments to D1769: Do not mark unit as injured when receives 0 damage.
Mon, Apr 15, 2:43 PM

Sun, Apr 14

Angen updated the diff for D1769: Do not mark unit as injured when receives 0 damage.

move some code back to Reduce and rename function

Sun, Apr 14, 4:27 PM

Fri, Apr 12

Angen updated subscribers of D1796: create template_defensive_palisade.xml.
Fri, Apr 12, 9:55 PM
Angen added inline comments to D1796: create template_defensive_palisade.xml.
Fri, Apr 12, 9:50 PM
Angen added inline comments to D1796: create template_defensive_palisade.xml.
Fri, Apr 12, 9:41 PM
Angen added a comment to D1822: Handle hotkey to order only one unit on minimap.

I tried in game and one unit command works on minimap

Fri, Apr 12, 9:37 PM · Contributors
Angen updated the summary of D1380: Build: precompiled logic update.
Fri, Apr 12, 8:32 PM
Angen updated the diff for D1380: Build: precompiled logic update.
Fri, Apr 12, 8:26 PM
Angen updated the diff for D1462: Enforce formation required member count.

fix tests

Fri, Apr 12, 6:52 PM
Angen updated the diff for D1462: Enforce formation required member count.

rebase

Fri, Apr 12, 6:32 PM
Angen updated the diff for D1769: Do not mark unit as injured when receives 0 damage.

fix

Fri, Apr 12, 5:32 PM
Angen planned changes to D1769: Do not mark unit as injured when receives 0 damage.

found flaw

Fri, Apr 12, 5:27 PM
Angen updated the diff for D1769: Do not mark unit as injured when receives 0 damage.

refactor

Fri, Apr 12, 5:18 PM
Angen added inline comments to D1822: Handle hotkey to order only one unit on minimap.
Fri, Apr 12, 2:36 PM · Contributors
Angen updated the diff for D1190: Allow restoring lost wall turrets.

New implementation based on comments above.

Fri, Apr 12, 11:31 AM
Angen reclaimed D1190: Allow restoring lost wall turrets.
Fri, Apr 12, 11:10 AM

Wed, Apr 10

Angen accepted D1823: Replace includes uniform_foo with uniform_foo_distribution.

builds, deprecated variants are replaced by valid equivalents

Wed, Apr 10, 9:55 PM
Angen awarded D1763: Removes duplication of Clamp function a Like token.
Wed, Apr 10, 9:36 PM
Angen updated the diff for D1816: Remove wrong assignment introduced in rP21113.

remove not needed clamp
mapdata is u8 (0 - 255), maxed value we can get here is 65280 what is in range of u16 (0 - 65535)

Wed, Apr 10, 9:33 PM
Angen accepted rP22175: Remove useless class, test class and use boost instead of it in….
Wed, Apr 10, 5:05 PM
Angen added a comment to D14: Thread the pathfinder computations to reduce latency.

just for record: Corinthian Ismuth (4) 4 ai very hard still out of memory

Wed, Apr 10, 4:50 PM
Angen raised a concern with rP22175: Remove useless class, test class and use boost instead of it in….

wrong diff link, include should be replaced, gameboy reported broken build on forum ( I wonder how Harbormaster passed, I dont have time now to test build), from his report looks that uniform_real_distribution' : is not a member of 'boost'

Wed, Apr 10, 6:18 AM

Tue, Apr 9

Angen accepted D1821: Remove useless Random class.

I accept this because:

Tue, Apr 9, 9:03 PM

Sun, Apr 7

Angen added inline comments to D1819: Make capture attack work with units with BuildingAI..
Sun, Apr 7, 4:34 PM
Angen added inline comments to D1819: Make capture attack work with units with BuildingAI..
Sun, Apr 7, 3:21 PM
Angen added inline comments to D1819: Make capture attack work with units with BuildingAI..
Sun, Apr 7, 12:59 PM

Sat, Apr 6

Angen updated the summary of D1814: Unused iterator in Xeromyces.
Sat, Apr 6, 6:22 PM
Angen updated the summary of D1814: Unused iterator in Xeromyces.
Sat, Apr 6, 6:21 PM
Angen added a comment to D1813: Remove unused variable from CInput.
In D1813#74338, @elexis wrote:

15:34 < bb> just leaving it accepted for a short while (till tonight) in case someone wants to add something

  • One may check for other unused vars in the same file (the compiler should already be checking for that)
  • One may want to find the revision (for referencing, possible audit, revision of the underlying feature design, discovery of forgotton implementation ideas etc)

    may = may chose not to
Sat, Apr 6, 6:00 PM

Fri, Apr 5

Angen updated the diff for D1816: Remove wrong assignment introduced in rP21113.

Pictures are white-black or white-gray-black.
Maps looks good I think.

Fri, Apr 5, 10:43 AM

Thu, Apr 4

Angen updated the diff for D1333: Precompiled update.

windows builds with no pch settings

Thu, Apr 4, 11:15 PM
Angen created D1817: Remove not needed variable and conversion to object.
Thu, Apr 4, 9:25 PM
Angen created D1816: Remove wrong assignment introduced in rP21113.
Thu, Apr 4, 9:04 PM
Angen added a reviewer for D1814: Unused iterator in Xeromyces: vladislavbelov.
Thu, Apr 4, 7:12 AM

Wed, Apr 3

Angen added inline comments to rP14877: Second (main) commit for the SpiderMonkey upgrade..
Wed, Apr 3, 10:47 PM
Angen added a comment to D1799: [Windows] Add information about data paths to error window.

I am on windows so as you want :)

Wed, Apr 3, 9:45 PM
Angen added inline comments to rP14877: Second (main) commit for the SpiderMonkey upgrade..
Wed, Apr 3, 9:44 PM
Angen created D1814: Unused iterator in Xeromyces.
Wed, Apr 3, 9:28 PM
Angen created D1813: Remove unused variable from CInput.
Wed, Apr 3, 9:14 PM
Angen raised a concern with rP21113: Allow random map scripts to load heightmap image files, fixes #5018..
Wed, Apr 3, 8:54 PM
Angen added inline comments to D1812: Remove unused variable from ModelRenderer.
Wed, Apr 3, 8:42 PM
Angen added inline comments to rP15483: Optimise silhouette rendering..
Wed, Apr 3, 8:33 PM
Angen created D1812: Remove unused variable from ModelRenderer.
Wed, Apr 3, 7:30 PM
Angen updated the diff for D1799: [Windows] Add information about data paths to error window.

Wed, Apr 3, 7:14 PM
Angen added a comment to D1603: Allow {native} and {civ} in auras.

Looking closer this does not work.

Wed, Apr 3, 10:43 AM

Wed, Mar 27

Angen updated subscribers of D1803: Communicate field diminishing returns to the player.

@Nescio would not be better to change vegetables to grain?

Wed, Mar 27, 10:56 PM
Angen added a comment to D14: Thread the pathfinder computations to reduce latency.
Wed, Mar 27, 12:10 PM
Angen added inline comments to D14: Thread the pathfinder computations to reduce latency.
Wed, Mar 27, 6:18 AM
Angen added a comment to D1800: Display correct ranged attack overlay for structures.

it is 5ms for all currently selected (200) units. I called this update from updateGUIObjects in sesson.js

Wed, Mar 27, 5:46 AM

Tue, Mar 26

Angen added a comment to D1800: Display correct ranged attack overlay for structures.

Yes, one would assume that when computation takes from 0 to 1 ms for one unit, it will take around x ms for x units but ( i was surprised ) it does not

Tue, Mar 26, 8:35 PM

Mon, Mar 25

Angen retitled D1800: Display correct ranged attack overlay for structures from Display correct ranged overlay for maximum range of structures to Display correct ranged attack overlay for structures.
Mon, Mar 25, 7:34 PM
Angen added a comment to D1800: Display correct ranged attack overlay for structures.

Looped 100 times and 200 times and did not got bigger than 5 ms if recall correctly. But when I tried to update this overlay for placement, it was 1 ms for that building so I think it would not be wise update ranged overlay for units if they move. Thats why given information would be incorrect for them and more misleading as it would depend on the position they were spawned.

Mon, Mar 25, 7:33 PM
Angen retitled D1800: Display correct ranged attack overlay for structures from Display correct ranged overlay for maximum range to Display correct ranged overlay for maximum range of structures.
Mon, Mar 25, 6:53 PM
Angen updated the diff for D1800: Display correct ranged attack overlay for structures.

Restricting this update to buildings. For units this to work it needs to enable recomputing range overlay on unit motion what could become expensive.

Mon, Mar 25, 6:05 PM

Sat, Mar 23

Angen updated the Trac tickets for D1800: Display correct ranged attack overlay for structures.
Sat, Mar 23, 10:33 PM
Angen added a comment to D1800: Display correct ranged attack overlay for structures.

It is recomputed just if object changes owner, is created or some modification comes. Overlay for units is not updated white moving even when they get elevation bonus. Using let now = Date.now() and logging Date.now() - now at the end of GetElevationAdaptedRange returns 0 or 1 depending on range, bigger maximum range and elevationbonus longer it gets to compute. However with 1000 loop it freezes. But is it actually such problem if range overlay is not updated on movement ? We could restrict this computation just for buildings and make TODO to solve it for units.

Sat, Mar 23, 10:15 PM
Angen updated the diff for D1800: Display correct ranged attack overlay for structures.

added missing check for change in elevation bonus

Sat, Mar 23, 6:58 PM
Angen added a comment to D1800: Display correct ranged attack overlay for structures.

Right, elevationBonus is number based on which is added range corresponding to how high is current terrain.
It is based on GuiInterface.js lines 410 - 426 which result is used to display (+x) in toolip for range attack.

Sat, Mar 23, 6:22 PM
Angen created D1800: Display correct ranged attack overlay for structures.
Sat, Mar 23, 1:03 PM

Mar 20 2019

Angen planned changes to D1603: Allow {native} and {civ} in auras.
Mar 20 2019, 10:27 PM
Angen updated the diff for D1603: Allow {native} and {civ} in auras.

sele ptol civ tag revert

Mar 20 2019, 10:02 PM
Angen updated the diff for D1603: Allow {native} and {civ} in auras.

Identity for player entity have been in game before this patch. See special/player/player.xml

Mar 20 2019, 9:58 PM
Angen added a comment to D1377: Loading Tips update.

should not be result of && operation boolean and not string ? But somehow (well javascript) it is string if first is true else it is nothing

Mar 20 2019, 8:13 PM
Angen updated the diff for D1377: Loading Tips update.

simplify map function

just still dont get this javascript features somehow, there is return text && sprintf("..."), and aside from that the result of this expresion should be true, but it is replaced string

Mar 20 2019, 2:55 PM

Mar 19 2019

Angen created D1799: [Windows] Add information about data paths to error window.
Mar 19 2019, 8:47 PM
Angen added a comment to D1768: Formations: GetClosestMember passes wrong entity to filter function.

Uses of Formation.prototype.GetClosestMember
UnitAI.js
Line 184 - called without filter
Line 1920 - called with filter UnitAi.CanAttack(entity)
Line 4303 - called without filter
Line 4405 - called without fiter

Mar 19 2019, 7:54 PM

Mar 17 2019

Angen added a comment to D1784: Fixed assert fails in Actor Editor.

I can confirm this is fixing assertion error in both cases described in ticket.

Mar 17 2019, 8:22 PM · Windows Developers
Angen accepted D1741: Fix some warning for vs2015 in Atlas.

C4458 and C4456 not displayed while building project with --atlas. Project builds without errors. It is good for me.

Mar 17 2019, 7:48 PM
Angen added inline comments to D1707: Hard-counter tooltips.
Mar 17 2019, 5:28 PM
Angen updated the diff for D1792: X units required -> At least X units required.

periods

Mar 17 2019, 4:56 PM
Angen created D1792: X units required -> At least X units required.
Mar 17 2019, 4:49 PM
Angen updated the diff for D1495: Alt + Tab during loading in fullscreen mode crash.

years

Mar 17 2019, 4:38 PM
Angen updated the diff for D1509: Page Down / Page Up Rotates Entities in Editor Even Without Focus.

less lines

Mar 17 2019, 4:31 PM
Angen updated the diff for D1509: Page Down / Page Up Rotates Entities in Editor Even Without Focus.

missing dir

Mar 17 2019, 4:13 PM
Angen updated the diff for D1509: Page Down / Page Up Rotates Entities in Editor Even Without Focus.

2 variables -> one

Mar 17 2019, 4:11 PM
Angen updated the diff for D1495: Alt + Tab during loading in fullscreen mode crash.

ready to go

Mar 17 2019, 12:39 PM
Angen updated the diff for D1377: Loading Tips update.

forgot 2 comments, sorry

Mar 17 2019, 11:20 AM
Angen updated the diff for D1377: Loading Tips update.

fix translate

Mar 17 2019, 11:15 AM

Mar 16 2019

Angen added a comment to D1217: Pause renderer option for unfocused window.

D1945 moves fullscreen crash avoid handling inside render function and removes from frame function,so there can be optional do not render as it applies to every situation window and fullscreen.

Mar 16 2019, 4:49 PM

Mar 14 2019

Angen updated the diff for D1377: Loading Tips update.

forgot to translate :)

Mar 14 2019, 9:28 PM
Angen updated the diff for D1377: Loading Tips update.
Mar 14 2019, 7:00 PM

Mar 13 2019

Angen added inline comments to D1377: Loading Tips update.
Mar 13 2019, 1:17 PM

Mar 10 2019

Angen updated the diff for D1377: Loading Tips update.

remove wrong dots

Mar 10 2019, 1:27 PM
Angen added a comment to D1377: Loading Tips update.

oh sorry, I did not meant to do that :) I just used replacement

Mar 10 2019, 1:17 PM
Angen updated the diff for D1377: Loading Tips update.

dots :)

Mar 10 2019, 12:47 PM
Angen updated the diff for D1346: List multiselection.

rebase
@vladislavbelov chance to look into this? I would like to finish it :)

Mar 10 2019, 12:38 PM
Angen updated the diff for D1377: Loading Tips update.

should be everything

Mar 10 2019, 11:03 AM

Feb 6 2019

Angen awarded rP22081: Rome Testudo & Anti-Cavalry formations animations: a Love token.
Feb 6 2019, 6:13 PM

Feb 3 2019

Angen added a comment to D1769: Do not mark unit as injured when receives 0 damage.

@wraitii extend this diff or make another one?

Feb 3 2019, 3:30 PM
Angen added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Feb 3 2019, 3:27 PM
Angen added a comment to D1768: Formations: GetClosestMember passes wrong entity to filter function.

We should realise that current behaviour returns only INVALID ENTITY if filter is passed what is cmpAttack. CanAttack and there is check if target is enemy esle returns false. So clearly unit cannot attack itself as is not enemy of itself.

Feb 3 2019, 3:17 PM

Jan 29 2019

Angen added a comment to D1769: Do not mark unit as injured when receives 0 damage.

In unitAi healer filters possible targets with injured mark using Health.prototype.IsUnhealable function (and another checks) so unit with maxed health is not healed and stays injured and checked in next search if still in range.

Jan 29 2019, 9:06 PM
Angen added a comment to D1769: Do not mark unit as injured when receives 0 damage.

If unit is marked as injured, healers get it as unit to heal. So if unit with maxed health would be marked as as injured, healers would waist their time for unit that does not need it. I think, can someone think that this is not good change and disagree ?

Jan 29 2019, 8:14 PM
Angen added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Jan 29 2019, 8:01 AM

Jan 28 2019

Stan awarded D1769: Do not mark unit as injured when receives 0 damage a Burninate token.
Jan 28 2019, 9:38 PM