User Details
- User Since
- Jul 28 2017, 4:19 PM (107 w, 1 d)
Yesterday
Fri, Aug 16
builds without-pch
Thu, Aug 15
Fri, Aug 9
Sun, Jul 28
Fixed in rP22567
@Stan can you please check if it works for you?
Sat, Jul 27
just for record there is already similar logic:
Hero Elephant = Hero or Elephant
Hero+Elephant = Hero and Elephant
!Hero = no Hero
Fri, Jul 26
Thu, Jul 25
Reason for this issue with VS2013 is that memset was removed and looks like vs13 does not do default initialisation of that values.
If vs13 is only compiler having that problem, then we should cut off vs13 build already with D1396 since this is making vs13 builds not functional at all.
Grid.h(234): Assertion failed: "0 <= i && i < m_W && 0 <= j && j < m_H"
This introduced Access violation reading from ticket: https://trac.wildfiregames.com/ticket/5539 not fixed by later patch.
Wed, Jul 24
Fixed in rP22544
Build on windows is green, no crashes related to glsl or postprocessing, sound plays in atlas as should.
My RAM usage for replay from https://trac.wildfiregames.com/ticket/5530
Tue, Jul 23
I think we should never fail in case some mod has wrong data anyway, unless it is fail of whole mod io.
After that, I try to come with some not downlandable mod line for mods with wrong data.
Also do not forget \public\gui\reference\viewer\viewer.js for right click window (encyclopedia or whatever is it name)
I think it would.
At first: Users should not be able to download not signed mods or mods with outdated signature.
And they cannot do much about it, so spamming them with the messages about all unsigned mods would not be kind.
If you mean that there is no information about signature, what means there is no object, it is error, because that metadata contains information also about dependencies.
But in the first place ingame downloander permits users to downloand not - signed mods, because that means that mod is not trusted.
also remove test assert as we ignore mod silently
Builds and tests are green on windows.
I do not fully agree with restricted classes for splash damage. As was said restricted classes and preferred classes are something for unitai and petra to choose better target and do not waist attack at something it should not attack.
If there will be in future real time detection for projectiles collision, the fact if that projectile or splash damage, death damage will deal some damage to the given entity should be based on damage type vs armour type and not restricted classes. But this is just my personal opinion. :)
if we allow left and right how would one cancel preselected action?
Mon, Jul 22
selection details that part i posted is when you hover over that sword and shield when selected entity, it takes data from entity state so uses cmpGarrisonHolder
@Nescio
in selection_details
Engine.GetGUIObjectByName("attackAndArmorStats").tooltip = [
getAttackTooltip,
getSplashDamageTooltip,
getHealerTooltip,
getArmorTooltip,
getGatherTooltip,
getSpeedTooltip,
getGarrisonTooltip,
getProjectilesTooltip,
getConsumerTooltip,
getPayedTooltip,
getResourceTrickleTooltip,
getLootTooltip
].map(func => func(entState)).filter(tip => tip).join("\n");vs
selection_panels
let template = GetTemplateData(data.item); let tooltips = [ getEntityNamesFormatted, getVisibleEntityClassesFormatted, getAurasTooltip, getEntityTooltip, getEntityCostTooltip, getGarrisonTooltip, getPopulationBonusTooltip, showTemplateViewerOnRightClickTooltip ].map(func => func(template));
it displays chosen tooltip and formulate it based on data it gets. It does not gets data by itslef, data are given to it.
tooltip in game takes information from guiinterface entity state, tooltip in tech tree, structure tree, encyclopedia takes information from template itself not from cmpGarrisonHolder.
use early returns
lets keep it this way, I dont know if I want to start balancing changes
trample should be mass vs mass, if something is bigger enough than you, you get trampled. Not class dependend.
Sun, Jul 21
++, space, also removes not needed else branching because if before use return, and inlines one variable
var is global declaration of variable
if you do var once in some function, that variable exists outside the scope
you can do multiple var with the same name and variable gets redeclared
@Nescio But you can achieve the same effect with current state of the patch giving the numbers to ships. Current approach could be considered not fully satisfying if one could capture trader or merchant ship, what currently as I know can not. If it would be decided as better solution I would move it to another patch anyway as not everyone could agree with that change.
As jenkins is kind of broken, tests passed:
It looks like gameplay change so I cannot decide
fix typo
tab to spaces and revert var -> let
I cannot agree on that we swapped buffers when we did not render
As you can see here https://code.wildfiregames.com/D1495?vs=on&id=7570#toc
If we were minimised we would not swap buffers, but other than that I have no strong opinion on this part
Fri, Jul 19
Here is current list of places in gui section where roof, ceil or round are used, filtered out not relevant results and splitted as I am
not sure about some cases
common\tooltips.js:177: "current": Math.round(entState.hitpoints),
common\tooltips.js:178: "max": Math.round(entState.maxHitpoints)
common\tooltips.js:210: "percentage": (100 - Math.round(Math.pow(0.9, level) * 100))
common\tooltips.js:283: let minRange = Math.round(template.attack[type].minRange);
common\tooltips.js:284: let maxRange = Math.round(template.attack[type].maxRange);
common\tooltips.js:286: let relativeRange = realRange ? Math.round(realRange - maxRange) : 0;
common\tooltips.js:350: "value": Math.round(template.garrisonHolder.buffHeal),
common\tooltips.js:367: Math.round(template.buildingAI.garrisonArrowMultiplier *
common\tooltips.js:401: Math.round(entState.repairable.buildTime.timeRemaining - entState.repairable.buildTime.timeRemainingNew)),
common\tooltips.js:403: "second": Math.round(entState.repairable.buildTime.timeRemaining - entState.repairable.buildTime.timeRemainingNew)
common\tooltips.js:408: Math.round(entState.repairable.buildTime.timeRemainingNew)),
common\tooltips.js:410: "second": Math.round(entState.repairable.buildTime.timeRemainingNew)
common\tooltips.js:423: Math.round(entState.foundation.buildTime.timeRemaining - entState.foundation.buildTime.timeRemainingNew)),
common\tooltips.js:425: "second": Math.round(entState.foundation.buildTime.timeRemaining - entState.foundation.buildTime.timeRemainingNew)
common\tooltips.js:430: Math.round(entState.foundation.buildTime.timeRemainingNew)),
common\tooltips.js:432: "second": Math.round(entState.foundation.buildTime.timeRemainingNew)
common\tooltips.js:444: totalCosts[r] = Math.floor(template.cost[r] * trainNum);
common\tooltips.js:456: totalCosts.time = Math.ceil(template.cost.time * (entity ? Engine.GuiInterfaceCall("GetBatchTime", {D:\A.0.Development\binaries\data\mods\public\gui>findstr /s /n "Math.round" *
common\color.js:156: return [r, g, b].map(n => Math.round(n * 255));
common\colorFades.js:201: rgb.g += Math.round(g_FadeAttackUnit.gbcolorChangeRate * Math.sqrt(data.tickCounter - g_FadeAttackUnit.blinkingTicks));
common\tooltips.js:177: "current": Math.round(entState.hitpoints),
common\tooltips.js:178: "max": Math.round(entState.maxHitpoints)
common\tooltips.js:210: "percentage": (100 - Math.round(Math.pow(0.9, level) * 100))
common\tooltips.js:283: let minRange = Math.round(template.attack[type].minRange);
common\tooltips.js:284: let maxRange = Math.round(template.attack[type].maxRange);
common\tooltips.js:286: let relativeRange = realRange ? Math.round(realRange - maxRange) : 0;
common\tooltips.js:350: "value": Math.round(template.garrisonHolder.buffHeal),
common\tooltips.js:367: Math.round(template.buildingAI.garrisonArrowMultiplier *
common\tooltips.js:401: Math.round(entState.repairable.buildTime.timeRemaining - entState.repairable.buildTime.timeRemainingNew)),
common\tooltips.js:403: "second": Math.round(entState.repairable.buildTime.timeRemaining - entState.repairable.buildTime.timeRemainingNew)
common\tooltips.js:408: Math.round(entState.repairable.buildTime.timeRemainingNew)),
common\tooltips.js:410: "second": Math.round(entState.repairable.buildTime.timeRemainingNew)
common\tooltips.js:423: Math.round(entState.foundation.buildTime.timeRemaining - entState.foundation.buildTime.timeRemainingNew)),
common\tooltips.js:425: "second": Math.round(entState.foundation.buildTime.timeRemaining - entState.foundation.buildTime.timeRemainingNew)
common\tooltips.js:430: Math.round(entState.foundation.buildTime.timeRemainingNew)),
common\tooltips.js:432: "second": Math.round(entState.foundation.buildTime.timeRemainingNew)
loading\loading.js:86: let increment = Math.round(progress * middleLength / 100);
lobby\lobby.js:1017: Math.round(playerRatings.reduce((sum, current) => sum + current) / playerRatings.length) :
session\input.js:175: var averageRange = Math.round(Engine.GuiInterfaceCall("GetAverageRangeForBuildings", cmd) - cmd.range);
session\input.js:176: var range = Math.round(cmd.range);
session\input.js:1363: return Math.max(Math.round(g_BatchSize), 1);
session\menu.js:847: barterAmount.Buy.caption = "+" + Math.round(prices.sell[g_BarterSell] / prices.buy[resourceCode] * amountToSell);
session\selection_panels.js:602: size.top = size.left + Math.round(queuedItem.progress * (size.right - size.left));
session\selection_panels.js:1124: size.top = size.left + Math.round(progress * (size.right - size.left));
session\selection_panels_helpers.js:48: return "color:255 0 0 " + Math.min(125, Math.round(+totalCost / 10) + 50);
session\session.js:1167: Math.round(playerStates[player].resourceCounts[resource]),
session\session.js:1169: Math.round(playerStates[player].resourceCounts[resource])
session\session.js:1281: size.top = size.left + Math.round(researchStarted[tech].progress * (size.right - size.left));
session\session.js:1655: playerStatistics.militaryScore += Math.round((player.sequences.enemyUnitsKilledValue[maxIndex] +
session\session.js:1657: playerStatistics.totalScore += (total + Math.round((player.sequences.enemyUnitsKilledValue[maxIndex] +
summary\counters.js:130: return Math.round(total / 10);
summary\counters.js:135: return Math.round((playerState.sequences.enemyUnitsKilledValue[index] +builds windows vs2015 release and debug
sure it would :) hardcoded number is bad number :) wanna do patch ?
yes it is, see Trader.js calculateGain
I just tested it and does not work. They do not even move to that location / unit I order them to attack with this command.
yes, you are correct, my bad, internationbonus is used as multiplier
Jul 18 2019
Formation units where not allowed to be in individual idle before, not sure who made it possible
https://code.wildfiregames.com/rP14581
Jul 17 2019
revert wxw sln version
@Itms whit which version did you build wxWidgets 3.0.4 ?
Jul 16 2019
at least
Jul 15 2019
Jul 14 2019
inline
builds, saves, loads without error or crash
Here is source of crash reported by gameboy on forum reproducible with vs2013 build https://wildfiregames.com/forum/index.php?/topic/26498-game-crash/