Page MenuHomeWildfire Games

Angen
User

User Details

User Since
Jul 28 2017, 4:19 PM (122 w, 6 d)

Recent Activity

Yesterday

Angen added a comment to D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Reason of this diff is to move Preprocessor file to third party files, what is completed and moving a file does not break its functionality.

This patch does step 1 "moving" and the next one will do the "update part"

Thu, Dec 5, 7:20 PM

Wed, Dec 4

Angen added inline comments to D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.
Wed, Dec 4, 9:47 PM
Angen accepted D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Tests are passing.
Shader errors are reported.
From what I have seen shaders do work as without patch.
If it is third party file it should be in that folder.

Wed, Dec 4, 9:45 PM
Angen committed rP23205: Remove forgot return from refactoring in rP20631.
Remove forgot return from refactoring in rP20631
Wed, Dec 4, 7:42 PM
Angen added inline comments to D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.
Wed, Dec 4, 10:03 AM
Angen requested changes to D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.
Wed, Dec 4, 10:02 AM

Tue, Dec 3

Angen added a comment to D1727: Update auras when a formation member renames..

This might work now, but it will not with D1462 or if we disband formation with less than 2 members as that is done anyway after lonely units in formation gets order. In that cases formation cannot be disbanded because member was renamed.

Tue, Dec 3, 9:09 PM
Angen accepted D1520: Automatically cancel unpacking when units are ordered to move.
Tue, Dec 3, 7:20 PM
Angen added a comment to D1520: Automatically cancel unpacking when units are ordered to move.

Unit packs and unpacks as expected. Unit correctly cancels unpacking or continue packing when is ordered to move somewhere.
Issue when player cannot move unpacked siege unit because enemy is in range and unit keeps unpacking have been solved in this diff in the way, player does not have to click to cancel unpacking manually but just gives order to move.
LeaveFoundation works as expected for packable units and stays the same for other.

Tue, Dec 3, 7:20 PM
Angen added a reviewer for D2450: Fix UnitmotionFlying and implement CMessageMotionUpdate::FromJSVal: Restricted Owners Package.
Tue, Dec 3, 2:02 PM
Angen created D2450: Fix UnitmotionFlying and implement CMessageMotionUpdate::FromJSVal.
Tue, Dec 3, 2:00 PM
Angen requested changes to D1520: Automatically cancel unpacking when units are ordered to move.
Tue, Dec 3, 12:25 PM
Angen added a comment to D1520: Automatically cancel unpacking when units are ordered to move.

Unit packs and unpacks as expected. Unit correctly cancels unpacking or continue packing when is ordered to move somewhere.
Issue when player cannot move unpacked siege unit because enemy is in range and unit keeps unpacking have been solved in this diff in the way, player does not have to click to cancel unpacking manually but just gives order to move.

Tue, Dec 3, 11:21 AM

Mon, Dec 2

Angen added inline comments to D2413: Remove duplication of code from WaterManager.
Mon, Dec 2, 2:06 PM
Angen requested changes to D1727: Update auras when a formation member renames..

code that takes care about renamed entities is shorter, cleaner and mostly correct.

Mon, Dec 2, 1:27 PM
Angen added inline comments to rP22985: Rewrite Savegame page to use class syntax, enabled by rP22923 / D2290, refs….
Mon, Dec 2, 8:27 AM
Angen added inline comments to rP22985: Rewrite Savegame page to use class syntax, enabled by rP22923 / D2290, refs….
Mon, Dec 2, 8:13 AM

Sun, Dec 1

Angen added inline comments to D1520: Automatically cancel unpacking when units are ordered to move.
Sun, Dec 1, 9:32 PM
Angen added a comment to D1520: Automatically cancel unpacking when units are ordered to move.

Some more comments before i forget.

Sun, Dec 1, 9:31 PM
Angen updated the diff for D1946: Windows Differential testing.

moved to subdirectory
moving revert ahead of deletions so ugly spamming like in https://code.wildfiregames.com/differential/diff/10454/ will not happen

Sun, Dec 1, 8:42 PM
Angen planned changes to D1946: Windows Differential testing.

what i said above

Sun, Dec 1, 6:49 PM
Angen added inline comments to D1520: Automatically cancel unpacking when units are ordered to move.
Sun, Dec 1, 6:17 PM
Angen requested changes to D1520: Automatically cancel unpacking when units are ordered to move.

I did not test it yet nor looked into replace order function.
I ll do later (just dont want to loose my notes)

Sun, Dec 1, 5:46 PM
Angen requested changes to D2174: Split garrison abort bug noticed in D665..

MoveToGarrisonRange should not contain pickup logic.
It is expected from function to move unit to target range and return true/false.

Sun, Dec 1, 4:24 PM
Angen created D2449: ComputeMotionParameters correctly when formation member is added or removed.
Sun, Dec 1, 12:54 PM
Angen requested changes to D2393: Use victory conditions json's in Atlas.

It works nice, but there is problem aside small styling.

Sun, Dec 1, 11:52 AM

Fri, Nov 29

Angen added inline comments to D2447: Give a more explicit message when anim mismatches models.
Fri, Nov 29, 7:20 PM
Angen added inline comments to D1727: Update auras when a formation member renames..
Fri, Nov 29, 10:57 AM
Angen added inline comments to rP11934: Stop rearranging formations for orders carried out individually. Fixes #1476..
Fri, Nov 29, 10:54 AM
Angen added a reviewer for D1727: Update auras when a formation member renames.: Angen.
Fri, Nov 29, 10:32 AM
Angen added inline comments to D2446: [WIP] - Fake physics..
Fri, Nov 29, 8:35 AM

Thu, Nov 28

Angen added a comment to D1905: Vision Blocking by Terrain while exploring.

hmm yes, i wanted that mainly for player, because petra would have advantage as she see whole map.
but realistically, if you see someone runs on top of hill and then down, you dont see him anymore but you know where he went :)

Thu, Nov 28, 8:51 AM

Wed, Nov 27

Angen updated the diff for D2021: Fix AtlasUI.dll windows autobuild.

' -> "

Wed, Nov 27, 9:45 PM
Angen added a reviewer for D1905: Vision Blocking by Terrain while exploring: Restricted Owners Package.
Wed, Nov 27, 9:38 PM
Angen planned changes to D1905: Vision Blocking by Terrain while exploring.

remove debug printf
do profiling

Wed, Nov 27, 9:28 PM
Angen updated the diff for D1905: Vision Blocking by Terrain while exploring.

optional variant, have fun

Wed, Nov 27, 9:27 PM
Angen planned changes to D2021: Fix AtlasUI.dll windows autobuild.
Wed, Nov 27, 10:17 AM

Tue, Nov 26

Angen accepted rP23124: Standarize Capes for make them easier to handle..

Fixed in rP23141 and rP23187 also removing similar issue in rP23147

Tue, Nov 26, 6:26 PM
Stan awarded D2438: Fix formationmember not leaving walking state if offset cannot be reached a 100 token.
Tue, Nov 26, 5:44 PM
Angen added inline comments to rP23160: Bolt tower and ampitheater commit, updated ptolemaic sentry tower while I was….
Tue, Nov 26, 10:32 AM
Angen accepted D2442: Show progress bar when upgrading..

good point

Tue, Nov 26, 8:34 AM
Angen added a reviewer for D2393: Use victory conditions json's in Atlas: Angen.
Tue, Nov 26, 8:07 AM
Angen requested changes to D2442: Show progress bar when upgrading..

Since you just copy that textures, why just not to reuse the original directly?
If artists will want to add special texture for them, they will re-upload them anyway,

Tue, Nov 26, 7:51 AM

Mon, Nov 25

Angen awarded D2443: Removes hard-coded clip planes from water shader a Like token.
Mon, Nov 25, 9:16 PM
Angen added a comment to D2442: Show progress bar when upgrading..

When I applied the patch, it failed to get pictures so i had to copy them manually.
Aside from that, looks good and works.

Mon, Nov 25, 9:10 PM
Angen removed a reviewer for D1595: Ranged units attacks melee when target in minimum ranged attack range: Restricted Owners Package.
Mon, Nov 25, 11:36 AM
Angen added a reviewer for D2438: Fix formationmember not leaving walking state if offset cannot be reached: Restricted Owners Package.
Mon, Nov 25, 11:34 AM
Angen added a reviewer for D2442: Show progress bar when upgrading.: Angen.
Mon, Nov 25, 11:32 AM
Angen added a comment to D2442: Show progress bar when upgrading..

Code looks good, feature should work as intended by reading the code.
I see usage mainly in that player does not have to select entity, he can just hover over it to see progress.
I would maybe consider to add option into the settings or somehow toogle between show always and show default.

Mon, Nov 25, 11:26 AM

Sun, Nov 24

nani awarded D2440: Discrete LOD a Like token.
Sun, Nov 24, 9:28 PM
Angen added a comment to D2440: Discrete LOD.

It would be a good feature, although I guess in the average case only high level of detail will be shown, since the camera is top down on average?

Sun, Nov 24, 8:50 PM
Angen planned changes to D2440: Discrete LOD.

move interval to each actor
check distance only if actor defines that it has lod versions
disable/enable lod from graphic options

Sun, Nov 24, 8:49 PM
Stan awarded D2440: Discrete LOD a Love token.
Sun, Nov 24, 8:16 PM
Angen created D2440: Discrete LOD.
Sun, Nov 24, 8:14 PM
Angen updated the diff for D2434: Remove props from cape animations.

fix misstyped file name

Sun, Nov 24, 3:04 PM
Angen updated the diff for D1977: Change Cheering.

Let Cheer surrounding units only if are IDLE, do not cheer if last target was animal or unit has building ai.

Sun, Nov 24, 2:51 PM
Angen accepted D2371: Allow to play upgrade animations .
Sun, Nov 24, 12:19 PM
Angen requested changes to D2371: Allow to play upgrade animations .

one more thing aside inline before ok, I just noticed that cart defense tower should not use specific cart scaf because it has its own stairs and they are doubled, looks weird.


Sun, Nov 24, 11:16 AM

Sat, Nov 23

Angen added a comment to D2371: Allow to play upgrade animations .

I think it would need to go closer a bit too to look good. Now there is a pretty big gap.

Sat, Nov 23, 9:51 PM
Angen added a comment to D2371: Allow to play upgrade animations .

Notes:
ptolemies/defense_tower: pls add <prop actor="props/structures/decals/spart_1x1.xml" attachpoint="root"/>
romans/scout_tower pls add <prop actor="props/structures/romans/rome_tower_wood.xml" attachpoint="root"/>
actually roman siege wall is about the size of palisade in height, maybe scaf should go off there too, I think it is a bit off by height and width

Sat, Nov 23, 8:42 PM
Angen updated the summary of D2438: Fix formationmember not leaving walking state if offset cannot be reached.
Sat, Nov 23, 1:41 PM
Angen created D2438: Fix formationmember not leaving walking state if offset cannot be reached.
Sat, Nov 23, 1:33 PM
Angen requested changes to D2371: Allow to play upgrade animations .

The feature looks good and it is nice visual update. Before accepting it I found two bigger problems and some smaller.
So this needs to be fixed:
Mace sentry and defence towers loose their windows, doors and other important props while in upgrade animations.
Rome defence tower is loosing also some wooden props which changes its overall look significantly.

Sat, Nov 23, 12:30 PM

Fri, Nov 22

Angen accepted D2424: Fix formation-walking infinite loop introduced in rP22506..

With this patched applied, I confirm formationmember in IDLE state now correctly reaches this.isIdle = true, which is important information for AI (Petra) and GUI.
As this is fixing reported issue and do not introduce invalid behaviour (no such was noticed while testing) I accept this patch and agree on to be committed.

Fri, Nov 22, 8:37 PM
Angen requested changes to D2371: Allow to play upgrade animations .

Missing animations:
brit_sentry_tower
gaul_sentry_tower

Fri, Nov 22, 8:13 PM
Angen requested changes to D2371: Allow to play upgrade animations .
Fri, Nov 22, 3:07 PM
Angen requested changes to D2371: Allow to play upgrade animations .

Description says, it is setting variant, but code is selecting animation.
So it should call SetVariant instead :)

Fri, Nov 22, 8:14 AM

Thu, Nov 21

Angen requested changes to D2424: Fix formation-walking infinite loop introduced in rP22506..

see inline comment

Thu, Nov 21, 8:58 PM
Angen accepted D2422: Fix idle unit not attacking nearest unit..

Expected behaviour:
entity in IDLE state will always try to attack best suitable (closest and preferred or any closest, not including ignored) target in its range based on stance

Thu, Nov 21, 8:20 PM
Angen added a reviewer for D2422: Fix idle unit not attacking nearest unit.: Angen.
Thu, Nov 21, 7:10 PM
Angen added a reviewer for D2424: Fix formation-walking infinite loop introduced in rP22506.: Angen.
Thu, Nov 21, 7:06 PM
Angen updated the diff for D2434: Remove props from cape animations.
Thu, Nov 21, 6:19 PM
Angen added a comment to D2434: Remove props from cape animations.

I would not create more files just to have special prefix for them
Same I would not mix this diff with file renaming for death_cape, or cape_gather_*

Thu, Nov 21, 11:18 AM
Angen planned changes to D2434: Remove props from cape animations.

missed attack_slaughter

Thu, Nov 21, 10:36 AM
Angen added inline comments to D2412: Lobby class implementation.
Thu, Nov 21, 8:51 AM

Wed, Nov 20

Angen updated the diff for D2434: Remove props from cape animations.

xml headers + cape_ prefix

Wed, Nov 20, 9:19 PM
Angen accepted rP23170: Remove bow from praise animation and display helmets as for other gather….

Fixed in rP23171, thnx that was fast :)

Wed, Nov 20, 8:55 PM
Angen added inline comments to D2434: Remove props from cape animations.
Wed, Nov 20, 8:47 PM
Angen raised a concern with rP23170: Remove bow from praise animation and display helmets as for other gather….
Wed, Nov 20, 8:43 PM
Angen added a reviewer for D2434: Remove props from cape animations: Stan.
Wed, Nov 20, 5:40 PM
Angen created D2435: Remove bow from praise animation and display helmets as for other gather animations.
Wed, Nov 20, 5:39 PM
Angen created D2434: Remove props from cape animations.
Wed, Nov 20, 5:25 PM
Angen updated the diff for D2433: Remove messy projectile from siege operator animations.
Wed, Nov 20, 11:06 AM
Angen updated the summary of D2433: Remove messy projectile from siege operator animations.
Wed, Nov 20, 10:49 AM
Angen added a reviewer for D2433: Remove messy projectile from siege operator animations: Stan.
Wed, Nov 20, 10:42 AM
Angen created D2433: Remove messy projectile from siege operator animations.
Wed, Nov 20, 10:41 AM

Mon, Nov 18

Angen awarded D2412: Lobby class implementation a Love token.
Mon, Nov 18, 5:59 PM

Sun, Nov 17

Angen planned changes to D1977: Change Cheering.

queued or pushorderfront

Sun, Nov 17, 9:30 PM
nani awarded D1977: Change Cheering a Like token.
Sun, Nov 17, 8:24 PM
Angen updated the diff for D1977: Change Cheering.
Sun, Nov 17, 8:02 PM
Angen planned changes to D1977: Change Cheering.

how do i have cmpVision there 🗡

Sun, Nov 17, 7:21 PM
Angen updated the diff for D1977: Change Cheering.

Fix discard order
Change comment
Use classic for instead for of, because speed

Sun, Nov 17, 6:56 PM
Angen updated the diff for D1940: UnitAI cleanup [GATHER].

rebased, something was kicked out from diff

Sun, Nov 17, 6:41 PM
Angen abandoned D1670: Singleton g_Game and g_SoundManager.
Sun, Nov 17, 6:24 PM
Angen planned changes to D1346: List multiselection.

I ll update this but no idea when

Sun, Nov 17, 6:18 PM
Angen planned changes to D1462: Enforce formation required member count.

Needs rebase, not sure it is worth to do at this state of reviews. Ping me if you want to review this I ll rebase.

Sun, Nov 17, 6:02 PM
Angen abandoned D1673: Update NULL to nullptr.

Looks like will not get into code anyway so backlog.

Sun, Nov 17, 5:57 PM
Angen planned changes to D1905: Vision Blocking by Terrain while exploring.

I might rewrite it in way it can be set as option before starting of match so one can choose if wants classic or new behaviour of vision.

Sun, Nov 17, 5:54 PM
Angen removed a reviewer for D2053: Round value of capture attack: Restricted Owners Package.
Sun, Nov 17, 5:51 PM
Angen added a reviewer for D2415: Refactor ColorActivateFastImpl function: Restricted Owners Package.
Sun, Nov 17, 5:50 PM