Page MenuHomeWildfire Games

Angen
User

User Details

User Since
Jul 28 2017, 4:19 PM (139 w, 1 d)

Recent Activity

Today

Angen added a comment to D2667: Upgrade engine to handle up to 30 players.

Aside from this I got idea how this could be unlimited number of players.
You would need to store inside PlayerData an array of m_data and work with the value based on index you get.
Lets say you store m_data as u32. So if you get index 0 - 16 you get first item from array. If you get index from 17 - 32 you get second item from array and substract 16 from index.

Sun, Mar 29, 1:19 PM
Angen requested changes to D2667: Upgrade engine to handle up to 30 players.
Sun, Mar 29, 1:10 PM

Yesterday

Angen updated subscribers of D2640: adjust trader footprints.

@Feldfeld anything against? If yes do we agree that camel traders need to have the same footprint, one or another?

Sat, Mar 28, 10:19 AM

Fri, Mar 27

Angen added a comment to D2667: Upgrade engine to handle up to 30 players.

some more comments

Fri, Mar 27, 11:41 PM
Angen accepted rP23558: Remove deprecated variants from Brit structures actors..

Fixed in rP23560

Fri, Mar 27, 9:37 PM
Angen raised a concern with rP23558: Remove deprecated variants from Brit structures actors..
Fri, Mar 27, 9:26 PM
Angen committed rP23559: [gameplay-a24] Standardize structure loot to 20%.
[gameplay-a24] Standardize structure loot to 20%
Fri, Mar 27, 9:14 PM
Angen closed D2659: [gameplay] standardize structure loot.
Fri, Mar 27, 9:14 PM
Angen committed rP23557: Remove unnecessary arguments in Pack.js.
Remove unnecessary arguments in Pack.js
Fri, Mar 27, 9:00 PM
Angen closed D2679: Remove unnecessary argument of Pack-timer..
Fri, Mar 27, 9:00 PM
Angen committed rP23556: Standardizes formating style of aura json files.
Standardizes formating style of aura json files
Fri, Mar 27, 8:55 PM
Angen closed D2000: aura style corrections.
Fri, Mar 27, 8:55 PM
Angen added inline comments to D2667: Upgrade engine to handle up to 30 players.
Fri, Mar 27, 4:02 PM
Angen added inline comments to D2667: Upgrade engine to handle up to 30 players.
Fri, Mar 27, 3:47 PM
Angen added a reviewer for D2667: Upgrade engine to handle up to 30 players: Restricted Owners Package.
Fri, Mar 27, 3:08 PM
Angen requested changes to D2640: adjust trader footprints.

please split footprint changes from name changes
else I agree, footprints should not be smaller than entity

Fri, Mar 27, 3:01 PM
Angen added inline comments to D2684: [gameplay] make rams less effective vs units.
Fri, Mar 27, 2:32 PM
Angen added a comment to D2682: [gameplay] unify hero health.

it shouldn't really matter whether they are on foot or ride a horse, chariot, camel, or elephant.
Well it matter for citizen-soldiers and champions.
Maybe they could start at 500 hp and use the same scaling as champions for example.

Fri, Mar 27, 2:24 PM
Angen added inline comments to D2684: [gameplay] make rams less effective vs units.
Fri, Mar 27, 2:11 PM
Angen added a comment to D2685: simplify mercenary cost.

At first sight it looks good because it removes bunch of duplication, however it hides cost change from templates. Also it would not be shown in structure tree and right clicking to trainable unit. (Side note, I think you need to put that technology somewhere to work if I am not mistaken)

Fri, Mar 27, 2:09 PM

Thu, Mar 26

Angen accepted D2679: Remove unnecessary argument of Pack-timer..

data passed inside timer are not used so removal is ok and it eliminates object creation.
SelecAnimation takes only 3 parameters DEFINE_INTERFACE_METHOD_3("SelectAnimation", void, ICmpVisual, SelectAnimation, std::string, bool, fixed)

Thu, Mar 26, 10:53 PM
Angen added a comment to D2667: Upgrade engine to handle up to 30 players.

Did not have time to get into it yet, so pointing only style.

Thu, Mar 26, 10:50 PM
Angen accepted D2659: [gameplay] standardize structure loot.

Complete

Thu, Mar 26, 10:10 PM
Angen edited reviewers for D2679: Remove unnecessary argument of Pack-timer., added: Angen; removed: Restricted Owners Package.

Nice catch :)

Thu, Mar 26, 10:06 PM
Angen accepted D2000: aura style corrections.

Changes are complete.
Changes are good following similar cleaning patches and keeping CC for json.

Thu, Mar 26, 9:45 PM
Angen added a comment to D2659: [gameplay] standardize structure loot.

Remaining
pers_stable

Thu, Mar 26, 9:31 PM
Angen requested changes to D2659: [gameplay] standardize structure loot.
Thu, Mar 26, 9:26 PM
Angen requested changes to D2000: aura style corrections.

Remaining
iber_player_teambonus.json

Thu, Mar 26, 8:39 PM

Wed, Mar 25

Angen added a comment to D2663: Colorize username in chat when is ready and leaves match.

I wanted to avoid copying the same function to another two classes.
That line was not intentional. I planed to remove it in next update or commit.

Wed, Mar 25, 9:47 PM
Angen added a comment to rP23540: Check for UnitMotion component [UnitAI].

Following functions already checked if unitmotion exists.

Wed, Mar 25, 8:52 PM

Mon, Mar 23

Angen created D2663: Colorize username in chat when is ready and leaves match.
Mon, Mar 23, 10:15 PM
Angen added inline comments to rP23374: Gamesetup class rewrite, fixes #5322, refs #5387..
Mon, Mar 23, 10:01 PM
Angen committed rP23547: [gameplay-a24] Reduce Blemmye and Nuba camp building time.
[gameplay-a24] Reduce Blemmye and Nuba camp building time
Mon, Mar 23, 7:50 PM
Angen closed D1863: [gameplay] reduce Blemmye and Nuba camp building time.
Mon, Mar 23, 7:50 PM
Angen added inline comments to D2517: React to target death properly when chasing.
Mon, Mar 23, 7:25 PM
Angen requested changes to D2015: Add formation CheckTarget-/MoveToTargetRange-functions..
Mon, Mar 23, 4:20 PM
Angen requested changes to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..

moving out of queue

Mon, Mar 23, 4:16 PM

Sat, Mar 21

Angen removed a reviewer for D2104: Unify usage of mouse buttons for preselected action and hotkey modifications: Restricted Owners Package.
Sat, Mar 21, 11:21 PM
Angen committed rP23543: [gameplay-a24] Balance ranged infantry citizen soldiers.
[gameplay-a24] Balance ranged infantry citizen soldiers
Sat, Mar 21, 11:03 PM
Angen closed D2612: [gameplay] Balance ranged infantry citizen soldiers.
Sat, Mar 21, 11:03 PM
Angen updated the diff for D2517: React to target death properly when chasing.

remove comments

Sat, Mar 21, 6:11 PM
Angen added a comment to D2517: React to target death properly when chasing.

Petra does not use Chasing string in her codebase -> ok.

Sat, Mar 21, 5:20 PM
Angen updated subscribers of D2511: [gameplay] give worker elephants an aura instead.

@Feldfeld whats your opinion ?

Sat, Mar 21, 5:17 PM
Angen added a comment to D1245: Experience trickle.

Dunno if we need it in vanilla. It rewards players to not use their units directly?

Only citizen soldiers are able to promote so having them garrisoned for most time will hurt economy of the player. And experience gain is not so fast as in combat.

Sat, Mar 21, 4:59 PM
Angen committed rP23541: Experience trickle.
Experience trickle
Sat, Mar 21, 4:56 PM
Angen closed D1245: Experience trickle.
Sat, Mar 21, 4:55 PM
Angen added a comment to D1245: Experience trickle.

[16:18] <Freagarach> One could perhaps check the timer every time the rate is computed?
[16:19] <Stan`> could be delete this.trickleTimer
[16:20] <Freagarach> That too, and var -> let ;)

(http://irclogs.wildfiregames.com/2020-03/2020-03-21-QuakeNet-%230ad-dev.log)

Sat, Mar 21, 4:53 PM
Angen updated subscribers of D2612: [gameplay] Balance ranged infantry citizen soldiers.

@Feldfeld any objections ?

Sat, Mar 21, 4:03 PM

Fri, Mar 20

Angen committed rP23540: Check for UnitMotion component [UnitAI].
Check for UnitMotion component [UnitAI]
Fri, Mar 20, 9:13 PM
Angen added a comment to D2517: React to target death properly when chasing.

the former will stop in its tracks

Fri, Mar 20, 8:05 PM
Angen added inline comments to D2015: Add formation CheckTarget-/MoveToTargetRange-functions..
Fri, Mar 20, 7:40 PM
Angen planned changes to D2652: Do not allow upgrading when entity is producing and vice versa..

Need to fix tests.

Fri, Mar 20, 6:26 PM

Tue, Mar 17

Angen committed rP23536: Remove duplication in AttackPlan [Petra].
Remove duplication in AttackPlan [Petra]
Tue, Mar 17, 8:30 PM
Angen closed D2655: Remove duplication in AttackPlan [Petra].
Tue, Mar 17, 8:30 PM
Angen updated the diff for D2655: Remove duplication in AttackPlan [Petra].

fix linter comments

Tue, Mar 17, 8:17 PM
Angen created D2655: Remove duplication in AttackPlan [Petra].
Tue, Mar 17, 8:03 PM

Mon, Mar 16

Angen removed a reviewer for D2460: Implement placeholder text for input fields and get rid of hack with mod filter: Restricted Owners Package.
Mon, Mar 16, 7:06 PM
Angen planned changes to D2460: Implement placeholder text for input fields and get rid of hack with mod filter.

Needs rework,
caption change event is triggering rebuild, so solution would be possibly override.

Mon, Mar 16, 7:06 PM
Angen removed a reviewer for D2517: React to target death properly when chasing: Restricted Owners Package.
Mon, Mar 16, 6:17 PM
Angen edited reviewers for D2015: Add formation CheckTarget-/MoveToTargetRange-functions., added: Angen; removed: Restricted Owners Package.
Mon, Mar 16, 9:56 AM

Sun, Mar 15

Angen committed rP23529: Support garrisoned enitites defined in map files..
Support garrisoned enitites defined in map files.
Sun, Mar 15, 3:04 PM
Angen added inline comments to D2394: Fix compiler warning (comparison against a string literal) in the ActorEditor following rP22335.
Sun, Mar 15, 1:58 PM
Angen accepted D2394: Fix compiler warning (comparison against a string literal) in the ActorEditor following rP22335.

Comparison to number is done correctly.

Sun, Mar 15, 1:54 PM
Angen created D2652: Do not allow upgrading when entity is producing and vice versa..
Sun, Mar 15, 12:51 PM
Angen updated the diff for D2517: React to target death properly when chasing.

cancel CHASING timer

Sun, Mar 15, 11:21 AM
Angen planned changes to D2517: React to target death properly when chasing.

warnings

Sun, Mar 15, 11:11 AM
Angen added a comment to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..

What could be done is to have %(statusName)s: %(tooltip)s, %(effects)s, %(interval)s, %(duration)s %(stackability)s defined in template.
But duration and interval can be changed through aura or technology, what makes 4 options defined in template and 4 ifs in code what will make it easier to read.
Downside is 4 strings for every template.

Sun, Mar 15, 11:05 AM
Angen updated the diff for D2517: React to target death properly when chasing.

better approach

Sun, Mar 15, 10:09 AM

Mon, Mar 9

Angen added inline comments to D2308: Extend the visible garrisoning schema to allow specific units on specific turrets..
Mon, Mar 9, 8:36 PM
Angen added a member for Contributors: norsnor.
Mon, Mar 9, 8:33 PM
Angen added inline comments to D1971: Support attack-ground for ranged units..
Mon, Mar 9, 1:36 PM
Angen added a comment to D2308: Extend the visible garrisoning schema to allow specific units on specific turrets..

nothing braking i can find just by reading the code

Mon, Mar 9, 1:26 PM

Sat, Mar 7

Angen added a reviewer for D2394: Fix compiler warning (comparison against a string literal) in the ActorEditor following rP22335: Angen.
Sat, Mar 7, 1:07 PM
Angen committed rP23521: Allow to cancel trade route setup.
Allow to cancel trade route setup
Sat, Mar 7, 12:35 PM
Angen closed D2643: Allow to cancel trade route setup.
Sat, Mar 7, 12:35 PM
Angen added a comment to D2643: Allow to cancel trade route setup.

http://irclogs.wildfiregames.com/2020-03/2020-03-06-QuakeNet-%230ad-dev.log

16:02 < elexis> I dont know why forEach was used there other than consistency, with the function above, perhaps there is a reason, but if there is, its not clear to me
16:03 < elexis> otherwise I dont see any syntax error
16:03 < elexis> no objections that is
16:04 < elexis> (performance doesnt matter here since its only one call per click, but the difference might be relevant in areas that are called per entity per turn)
16:06 < elexis> (for (let cmpUnitAI of GetFormationUnitAIs(data.entities, player)) would be the alternative)

mainly for that, whole file is using .forEach with GetFormationUnitAIs

Sat, Mar 7, 12:31 PM
Angen committed rP23519: Support friendly fire for projectile attacks..
Support friendly fire for projectile attacks.
Sat, Mar 7, 11:58 AM
Angen closed D1973: Support friendly fire for projectile attacks..
Sat, Mar 7, 11:58 AM
Angen removed a reviewer for D2597: Store Garrison(Holder) in map file.: Restricted Owners Package.
Sat, Mar 7, 11:32 AM
Angen accepted D2597: Store Garrison(Holder) in map file..

Minimal code.
Starting entities are garrisoned correctly.
Saving map in atlas again does not rewrite Garrison element.
There is no other map to be updated.
Single way how to define garrisoned entities in map file.

Sat, Mar 7, 11:31 AM

Sun, Mar 1

Angen requested changes to D2597: Store Garrison(Holder) in map file..
Sun, Mar 1, 1:46 PM
Angen added inline comments to D2597: Store Garrison(Holder) in map file..
Sun, Mar 1, 1:45 PM
Angen requested changes to D2647: Explicitly check for undefined when applying Auras and Technologies..

desired effect by "multiply": 0 sounds like "replace": 0

Sun, Mar 1, 11:52 AM
Angen added a comment to D2597: Store Garrison(Holder) in map file..

It would be nice to solve the whole ticket here. Are you up to that task?

Sun, Mar 1, 10:35 AM
Angen updated the diff for D2643: Allow to cancel trade route setup.

add .
reformulate comment
use new icon

Sun, Mar 1, 10:17 AM
Angen committed rP23517: Add cursor icon for canceling trade route setup.
Add cursor icon for canceling trade route setup
Sun, Mar 1, 9:51 AM
Angen added inline comments to D2647: Explicitly check for undefined when applying Auras and Technologies..
Sun, Mar 1, 9:18 AM
Angen added inline comments to D2453: Allow Flying objects to be stationary.
Sun, Mar 1, 9:00 AM

Feb 27 2020

Angen added inline comments to D2643: Allow to cancel trade route setup.
Feb 27 2020, 9:15 PM
Angen added inline comments to D2643: Allow to cancel trade route setup.
Feb 27 2020, 9:00 PM

Feb 26 2020

Angen added a comment to D2573: Fix AI OOS on rejoin related to random calls.

+1

Feb 26 2020, 6:55 PM

Feb 25 2020

Angen accepted D2492: Allow buildings to autobuild themselves.
Feb 25 2020, 9:39 PM
Angen accepted D1973: Support friendly fire for projectile attacks..

It is correct to allow templates decide if friendly fire is enabled instead hardcoding it.
Changes to code are complete and correct.
All required templates have been updated.
Test are passing.

Feb 25 2020, 9:16 PM
Angen added inline comments to D2642: Contrast-Adaptiv-Sharpening pass.
Feb 25 2020, 8:31 PM
Angen added inline comments to D2492: Allow buildings to autobuild themselves.
Feb 25 2020, 11:56 AM
Angen added a comment to D2492: Allow buildings to autobuild themselves.

can you request review ?

Feb 25 2020, 7:48 AM

Feb 24 2020

Angen resigned from D2476: Remove obsolete clipboard and GetVideoMode platform-specifics.

windows build was fixed

Feb 24 2020, 9:00 PM
Angen requested changes to D1973: Support friendly fire for projectile attacks..
Feb 24 2020, 8:46 PM
Angen added a reviewer for D2517: React to target death properly when chasing: Restricted Owners Package.
Feb 24 2020, 3:43 PM
Angen added a reviewer for D2643: Allow to cancel trade route setup: Restricted Owners Package.
Feb 24 2020, 1:42 PM