Page MenuHomeWildfire Games

Angen
wolf

User Details

User Since
Jul 28 2017, 4:19 PM (221 w, 4 d)

Recent Activity

Mon, Oct 25

Angen planned changes to D4318: Fix timeout confirmation box.

Update message

Mon, Oct 25, 3:18 PM
Angen added inline comments to D4318: Fix timeout confirmation box.
Mon, Oct 25, 2:08 PM
Angen added inline comments to D4318: Fix timeout confirmation box.
Mon, Oct 25, 2:06 PM
Angen added a reviewer for D1729: Missing tileclass in archipelago: Restricted Owners Package.
Mon, Oct 25, 12:17 PM
Angen added inline comments to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..
Mon, Oct 25, 11:22 AM
Angen added a comment to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

All user chosen settings are persisted when changing the selected map or maptype, except where the selected map overwrites the setting value and except for Scenario maps which still use the default value where the map doesn't specify the setting value.

Mon, Oct 25, 11:14 AM
Angen added a comment to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..
In D4305#183890, @Angen wrote:

There is still issue.
If map does not define attribute and you switch maps, the attribute from previous map will carry over so you will end up with 2 and possibly more settings for the same scenario map depending from which one you switch.

As far as I can tell, this bug exists in A25, but I've fixed it in this patch :).

Mon, Oct 25, 10:41 AM
Angen added a comment to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

The original logic done by elexis was as follows as far as i remember:
If map defines some property, that property should be set and locked from changes.
If map does not define property, preciously set property by player or one from persistent match settings should be used.
Current issue with scenario maps is, even if property is missing from the map, value cannot be changed by player.
Notice we have this issue only with scenarios because they are locked by default.
Other maps should not get values reset.
This probably happens with other settings, will need to check that.

Mon, Oct 25, 10:39 AM

Sun, Oct 24

Angen requested changes to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

There is still issue.
If map does not define attribute and you switch maps, the attribute from previous map will carry over so you will end up with 2 and possibly more settings for the same scenario map depending from which one you switch.

Sun, Oct 24, 4:42 PM

Sat, Oct 23

Angen added a comment to D4256: Adjusting the placeholder text for inputs.

Or generated placeholderText could get valign parameter and adjust position internally.
If someone would want to adjust such a position on another places.

Sat, Oct 23, 7:04 PM
Angen added a comment to D4297: Fixing a problem where the AI attacked bridges.

@Freagarach do you plan to commit this as it is right now?

Sat, Oct 23, 6:01 PM
Angen added inline comments to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..
Sat, Oct 23, 6:00 PM
Angen published D4318: Fix timeout confirmation box for review.
Sat, Oct 23, 12:42 PM
Angen added a comment to rP25966: There have been quite a bit of number of questions how to change scale of the….

hmm, yes, but thats again /mod dependent on /public
probably would need to move it to /mod
also, need a way to get remaining time

Sat, Oct 23, 12:02 PM
Angen accepted D4317: [atlas] Limit the mercenary experience bar for the basic rank.

Ok, i get it now

Sat, Oct 23, 9:19 AM
Angen added a comment to D4317: [atlas] Limit the mercenary experience bar for the basic rank.

Wait, didn't you say they are promoted to next rank?

Sat, Oct 23, 9:14 AM
Angen added a comment to D4317: [atlas] Limit the mercenary experience bar for the basic rank.

Yes, but you can see in tooltip that required is 150, so why calculation above produces trash

Sat, Oct 23, 9:02 AM
Angen added a comment to D4317: [atlas] Limit the mercenary experience bar for the basic rank.

Anyway why is req 0

Sat, Oct 23, 8:43 AM
Angen added a comment to D4317: [atlas] Limit the mercenary experience bar for the basic rank.

Put brakets around req || 1, its faster than doing max

Sat, Oct 23, 8:42 AM
Angen added a comment to D4317: [atlas] Limit the mercenary experience bar for the basic rank.

More like req || 1 but if entity is promoted, division by 0 should not happen

Sat, Oct 23, 8:05 AM

Fri, Oct 22

Angen added a comment to D4317: [atlas] Limit the mercenary experience bar for the basic rank.

Looks like code tries to devide by 0.
experienceSize.rtop = 100 - (100 * Math.max(0, Math.min(1, 1.0 * +entState.promotion.curr / +entState.promotion.req)));
Another question is, if someone places _b rank but required promotion is 0, shouldnt that entity be promoted on the start of the match?

Fri, Oct 22, 9:08 PM
Angen added inline comments to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..
Fri, Oct 22, 4:40 PM
Angen added a comment to D4317: [atlas] Limit the mercenary experience bar for the basic rank.

what happens when you place basic mercenary on map and runs it normally in game?
Maybe would be worth to check also the code.

Fri, Oct 22, 4:34 PM

Tue, Oct 19

Angen added inline comments to D4291: [gameplay] camouflaged ambush camp.
Tue, Oct 19, 9:20 PM
Angen added inline comments to D4291: [gameplay] camouflaged ambush camp.
Tue, Oct 19, 7:52 PM
Angen added inline comments to rP25966: There have been quite a bit of number of questions how to change scale of the….
Tue, Oct 19, 10:13 AM

Sun, Oct 17

Angen committed rP25966: There have been quite a bit of number of questions how to change scale of the….
There have been quite a bit of number of questions how to change scale of the…
Sun, Oct 17, 1:00 PM
Angen closed D3037: Add gui scale to options.
Sun, Oct 17, 12:59 PM
Angen added a comment to D4308: Fix pop indications of paused items..

I would not obstruct main icon, make the pause thing small and move it to the corner

Sun, Oct 17, 12:45 PM
Angen added a comment to D4297: Fixing a problem where the AI attacked bridges.

They cannot be repaired, damaged, constructed, do not provide any resource or aura. There is curently no value letiting player to select the bridges. It can even make selecting/commanding units near these entities a bit complicated, so i would just keep it as is in this diff with only actors and not entities.

Sun, Oct 17, 12:39 PM
Angen updated the diff for D3037: Add gui scale to options.

small changes, also trigger bots

Sun, Oct 17, 11:56 AM
Angen added a comment to D3544: Regroup members at most once when formation and its members get idle.

Or even move the responsibility of keeping the correct position to the members. (And get back into formation when we become idle.)

Sun, Oct 17, 10:59 AM
Angen added a comment to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

There was this commit:
https://code.wildfiregames.com/rP24037
negated by
https://code.wildfiregames.com/rP25077

Sun, Oct 17, 10:46 AM

Fri, Oct 15

Angen added inline comments to D4291: [gameplay] camouflaged ambush camp.
Fri, Oct 15, 9:30 PM

Wed, Oct 13

Angen added a comment to D4307: Renaming of map size options.

why

Wed, Oct 13, 7:51 PM
Angen added inline comments to D4291: [gameplay] camouflaged ambush camp.
Wed, Oct 13, 7:50 PM

Sun, Oct 10

Angen added a comment to rP25957: [Petra] Remove global constant from queueplanBuilding.js.

damn, forgot linter

Sun, Oct 10, 9:07 PM
Angen committed rP25957: [Petra] Remove global constant from queueplanBuilding.js.
[Petra] Remove global constant from queueplanBuilding.js
Sun, Oct 10, 9:02 PM
Angen closed D4301: [Petra] Remove global constant from queueplanBuilding.js.
Sun, Oct 10, 9:02 PM
Angen added a comment to D4299: Changing a single word in the Introductory Tutorial.

Thank you for the patch

Sun, Oct 10, 2:50 PM
Angen committed rP25955: Fix mention of 'farm' instead of 'field' in tutorial.
Fix mention of 'farm' instead of 'field' in tutorial
Sun, Oct 10, 2:49 PM
Angen closed D4299: Changing a single word in the Introductory Tutorial.
Sun, Oct 10, 2:49 PM
Angen published D4301: [Petra] Remove global constant from queueplanBuilding.js for review.
Sun, Oct 10, 2:03 PM
Angen requested changes to D4056: [gameplay] Mercenary camp tooltip correction .

It allows to recruit also another units than mercenaries.
It should be investigated what is actually goal here.
Because now it looks like regular barracks with additional merc units for specific civ.
So tooltip is wrong anyway.

Sun, Oct 10, 1:55 PM
Angen accepted rP25927: Fix black buttons as observer on a GAIA market..
Sun, Oct 10, 11:48 AM
Angen committed rP25954: Fix missing sell buttons.
Fix missing sell buttons
Sun, Oct 10, 11:33 AM
Angen closed D4298: Fix missing sell buttons.
Sun, Oct 10, 11:33 AM

Sat, Oct 9

Angen raised a concern with rP25691: Map flares.
Sat, Oct 9, 10:29 PM
Angen raised a concern with rP25927: Fix black buttons as observer on a GAIA market..
Sat, Oct 9, 7:49 PM
Angen published D4298: Fix missing sell buttons for review.
Sat, Oct 9, 3:52 PM

Fri, Oct 8

Angen updated the diff for D3037: Add gui scale to options.

rebase and some cleaning

Fri, Oct 8, 9:29 PM

Sat, Oct 2

Angen requested changes to D4287: [WIP] Add the possibility to start a game with a random civ from the command line..
Sat, Oct 2, 11:53 AM
Angen added inline comments to D4287: [WIP] Add the possibility to start a game with a random civ from the command line..
Sat, Oct 2, 11:46 AM
Angen added inline comments to D4286: Check for visibility on treasures in UnitAI..
Sat, Oct 2, 11:42 AM

Wed, Sep 29

Angen added a comment to D4285: Clarify (de)selection functions..

the functions don't do what they were expected to do?
Looks to me like getEntsByKeyInverse returned something wrong?

Wed, Sep 29, 6:17 PM
Angen added a comment to D4285: Clarify (de)selection functions..

Why not to fix getEntsByKeyInverse instead?

Wed, Sep 29, 5:50 PM

Sep 22 2021

Angen added a comment to D3037: Add gui scale to options.

Only issue with number as string being key in dropdown is that it depends how is written in config 1.0 and 1.00 or 1 will dispay as 100% in dropdown now, but will not work with dropdown having string as keys

Sep 22 2021, 6:20 PM

Sep 18 2021

Angen added a comment to rP25927: Fix black buttons as observer on a GAIA market..

https://wildfiregames.com/forum/topic/56568-petra-having-problems-with-fishing-on-maps-with-water-available/?do=findComment&comment=454690

Sep 18 2021, 9:06 PM
Angen added a comment to rP25927: Fix black buttons as observer on a GAIA market..

open trade card from top menu
switch to observer, go back to player, missing buttons

Sep 18 2021, 9:06 PM
Angen added inline comments to D4272: Use Transform for changing a formation template..
Sep 18 2021, 7:07 PM
Angen added inline comments to D4277: Rename misnamed lastGatheredType in ResourceGatherer..
Sep 18 2021, 6:51 PM

Sep 17 2021

Angen added a comment to rP25926: Fix duplicate insertion error when detecting incompatible mods..

You mean after inserting erease code rP25634

Sep 17 2021, 7:26 PM
Angen accepted D4276: Fix potential crash when parsing incompatible mods since rP25410.

while doing it you could merge branches

Sep 17 2021, 12:37 PM
Angen requested changes to D4216: [PetraAI] - Reduce duplication when trying to research a specific technology..
Sep 17 2021, 11:14 AM

Sep 16 2021

Angen added inline comments to D4216: [PetraAI] - Reduce duplication when trying to research a specific technology..
Sep 16 2021, 9:43 PM

Sep 15 2021

Angen accepted D4218: [PetraAI] - Disable some useless techs..

Looks better

Sep 15 2021, 10:48 AM

Sep 14 2021

Angen added a comment to D4262: Restoring the colored profile name with the ranking and using the leaderboard names for autocompletion in the profile player search field..
Sep 14 2021, 3:42 PM
Angen added a comment to D4262: Restoring the colored profile name with the ranking and using the leaderboard names for autocompletion in the profile player search field..

I have to dissagree, openPage is called when you open profile page, not on its creation

Sep 14 2021, 3:41 PM
Angen added a comment to D3037: Add gui scale to options.

Do you mean setguiscale to take string and parse number from it?

Sep 14 2021, 11:35 AM
Angen added inline comments to D3037: Add gui scale to options.
Sep 14 2021, 10:45 AM
Angen added inline comments to D2175: Select formations as a whole by default..
Sep 14 2021, 10:32 AM

Sep 13 2021

Angen updated the diff for D3341: [gameplay] move some trainable animals to higher phases.
Sep 13 2021, 8:22 PM
Angen updated subscribers of rP25921: [AI] Remove code duplication from map component.

I wanted to add new line and it send it instead. So here we go:

Sep 13 2021, 8:12 PM
Angen committed rP25921: [AI] Remove code duplication from map component.
[AI] Remove code duplication from map component
Sep 13 2021, 8:08 PM
Angen closed D4235: [AI] Remove code duplication from map component.
Sep 13 2021, 8:08 PM
Angen removed a reviewer for D4262: Restoring the colored profile name with the ranking and using the leaderboard names for autocompletion in the profile player search field.: Angen.
Sep 13 2021, 5:34 PM
Angen requested changes to D4262: Restoring the colored profile name with the ranking and using the leaderboard names for autocompletion in the profile player search field..
Sep 13 2021, 5:08 PM
Angen added inline comments to D4262: Restoring the colored profile name with the ranking and using the leaderboard names for autocompletion in the profile player search field..
Sep 13 2021, 5:08 PM
Angen awarded rP25917: Remove executable bit on some source files. a Like token.
Sep 13 2021, 9:57 AM

Sep 12 2021

Angen added a comment to rP25916: Fix translation of "%(unit)s can't be controlled'.

When @Ceres want to be in credits, they can make differential, from last info I know they did not want to be there

Sep 12 2021, 4:36 PM

Sep 11 2021

Angen updated the diff for D4235: [AI] Remove code duplication from map component.
Sep 11 2021, 11:46 AM
Angen added inline comments to D4216: [PetraAI] - Reduce duplication when trying to research a specific technology..
Sep 11 2021, 11:39 AM
Angen removed a reviewer for D4214: Popup Choice Message Boxes: Angen.
Sep 11 2021, 11:35 AM · Contributors
Angen removed a reviewer for D3353: Move population cost outside of cost component.: Angen.
Sep 11 2021, 11:33 AM
Angen requested changes to D4218: [PetraAI] - Disable some useless techs..
Sep 11 2021, 11:32 AM
Angen requested changes to D4249: [Gameplay] The Mauryan working elephant is building again.

get it out of queue again

Sep 11 2021, 11:30 AM
Angen edited reviewers for D4256: Adjusting the placeholder text for inputs, added: Restricted Owners Package; removed: Angen.
Sep 11 2021, 11:29 AM
Angen planned changes to D4235: [AI] Remove code duplication from map component.
Sep 11 2021, 11:28 AM
Angen added a comment to D4254: Added translatability of message "%(unit)s can't be controlled.".

Thanks for the patch

Sep 11 2021, 11:24 AM
Angen committed rP25916: Fix translation of "%(unit)s can't be controlled'.
Fix translation of "%(unit)s can't be controlled'
Sep 11 2021, 11:24 AM
Angen closed D4254: Added translatability of message "%(unit)s can't be controlled.".
Sep 11 2021, 11:24 AM
Angen added a comment to D4255: Typo correction for gui/modmod/validatemod.js.

@Langbart can you close this?
thanks

Sep 11 2021, 11:20 AM
Angen committed rP25915: Fix typo in validatemods introduced in rP20637.
Fix typo in validatemods introduced in rP20637
Sep 11 2021, 11:17 AM

Sep 10 2021

Angen added inline comments to D3478: Add "Invalid signature" reason to modio.
Sep 10 2021, 3:46 PM

Sep 6 2021

Angen added a comment to D4254: Added translatability of message "%(unit)s can't be controlled.".

Yes, you need to re-upload the diff, phabricator does not support direct editing.

Sep 6 2021, 5:01 PM
Angen added a comment to D4254: Added translatability of message "%(unit)s can't be controlled.".

You could fix the spacing around { } as comment says, but if no, commiter will do it

Sep 6 2021, 11:28 AM

Sep 5 2021

Angen accepted D4255: Typo correction for gui/modmod/validatemod.js.
Sep 5 2021, 5:55 PM
Angen added a comment to D4254: Added translatability of message "%(unit)s can't be controlled.".

@Ceres no big deal, i am just wondering why it is not starting with ps/trunk/
patch applies, so dont worry about it too much

Sep 5 2021, 2:54 PM
Angen accepted D4254: Added translatability of message "%(unit)s can't be controlled.".

Message is translated correctly.
Issue was sprintf replaced %(unit)s before message was going to be translated so string was never found in dictionary.
Introduced in rP24148

Sep 5 2021, 9:19 AM
Angen set the repository for D4254: Added translatability of message "%(unit)s can't be controlled." to rP 0 A.D. Public Repository.
Sep 5 2021, 9:13 AM