- User Since
- Jan 8 2017, 1:48 PM (148 w, 4 d)
Sat, Nov 2
I agree with @Polakrity here, I think “attack” should not be used to refer to capture in user-visible strings, and assuming melee and ranged attacks are the only possible attack types of potentially affected units, removing the attack type mention makes sense. I’m not sure is that assumption is correct, though. Can someone confirm that?
Use a more flexible approach which also make the code more readable
Rename ‘attack speed’ to ‘attack rate’ based on community feedback
I’m worried that discussing so many different changes may take some time. @Nescio what would you think about creating separate patches instead? Some of the changes should be pretty straightforward to apply that way.
Where can I find the run time logs of https://trac.wildfiregames.com/browser/ps/trunk/build/jenkins/lint-translations.sh?
Sun, Oct 20
Should we get this script merged, to make it easier to use it next time?
I’ve just posted https://wildfiregames.com/forum/index.php?/topic/27150-wording-attack-repeat-time-vs-attack-time-vs-time-between-attacks-vs-attack-speed/ to discuss this, and CC’d people both from here and from https://trac.wildfiregames.com/ticket/3600
Restore the previous tooltip wording
Reload → Rebuild
I’m not against the use of ‘goods’ in the context of trade, where it’s the right word to refer to “tradeable resources”, but since in 0 A.D. all resources are tradeable, I’m OK with the change.
Single-player is proper English, single player and singleplayer are less correct.
Sep 18 2019
Sep 17 2019
I’m just looking for using the same wording. If “Rebuild” works on both strings, I’ll switch both to “Rebuild”.
Sep 15 2019
Sep 1 2019
I’ve just restored the file with its previous content in https://code.wildfiregames.com/rP22830
@Freagarach May I merge?
@elexis May I merge?
Note: Patching was a bit messy due to the renaming and spaces in files. I ended up having to push a second commit that deleted the renamed files.
Aug 25 2019
I assume the example I added to the English style guide, that 0.5 attack repeat time would mean (1/0.5=2) +100% attack speed, will make it more obvious that the math works: half the time = twice the speed.
Aug 24 2019
@Stan Is the rebasing the only issue, or something that should be done before the review may continue? If it’s the only remaining issue, I can probably take care of that manually while merging.
Aug 18 2019
Then let’s add quotes to those similar lines missing them.
OK, I think we can merge once the + in +40 is back
What about squad, squadron, battalion, brigade, party, company, or regiment?