Page MenuHomeWildfire Games

Gallaecio (Adrián Chaves)
User

Projects

User Details

User Since
Jan 8 2017, 1:48 PM (148 w, 4 d)

Recent Activity

Sat, Nov 2

Gallaecio added a comment to D2226: Use standarized phrasing and terminology for the Patriot aura description.

I agree with @Polakrity here, I think “attack” should not be used to refer to capture in user-visible strings, and assuming melee and ranged attacks are the only possible attack types of potentially affected units, removing the attack type mention makes sense. I’m not sure is that assumption is correct, though. Can someone confirm that?

Sat, Nov 2, 3:59 PM
Gallaecio updated the diff for D1613: Improve the plural translation of the "<players> have won" string.

Use a more flexible approach which also make the code more readable

Sat, Nov 2, 8:01 AM
Gallaecio added reviewers for D2226: Use standarized phrasing and terminology for the Patriot aura description: Freagarach, Polakrity, fatherbushido.
Sat, Nov 2, 7:33 AM
Gallaecio updated the diff for D2226: Use standarized phrasing and terminology for the Patriot aura description.

Rename ‘attack speed’ to ‘attack rate’ based on community feedback

Sat, Nov 2, 7:30 AM
Gallaecio added a comment to D2305: more gui/manual/intro.txt improvements.

I’m worried that discussing so many different changes may take some time. @Nescio what would you think about creating separate patches instead? Some of the changes should be pretty straightforward to apply that way.

Sat, Nov 2, 7:26 AM
Gallaecio added a comment to D1674: Check translations for sprintf errors.

Where can I find the run time logs of https://trac.wildfiregames.com/browser/ps/trunk/build/jenkins/lint-translations.sh?

Sat, Nov 2, 7:20 AM

Sun, Oct 20

Gallaecio added a comment to D1674: Check translations for sprintf errors.

Should we get this script merged, to make it easier to use it next time?

Sun, Oct 20, 1:50 PM
Gallaecio added a comment to D2226: Use standarized phrasing and terminology for the Patriot aura description.

I’ve just posted https://wildfiregames.com/forum/index.php?/topic/27150-wording-attack-repeat-time-vs-attack-time-vs-time-between-attacks-vs-attack-speed/ to discuss this, and CC’d people both from here and from https://trac.wildfiregames.com/ticket/3600

Sun, Oct 20, 1:41 PM
Gallaecio committed rP23083: Rephrase the tooltip of Reload Cache to avoid confusion.
Rephrase the tooltip of Reload Cache to avoid confusion
Sun, Oct 20, 1:21 PM
Gallaecio closed D2294: Rephrase the tooltip of Reload Cache to avoid confusion.
Sun, Oct 20, 1:21 PM
Gallaecio retitled D2294: Rephrase the tooltip of Reload Cache to avoid confusion from [WIP] Rephrase the tooltip of Reload Cache to avoid confusion to Rephrase the tooltip of Reload Cache to avoid confusion.
Sun, Oct 20, 1:20 PM
Gallaecio updated the diff for D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

Restore the previous tooltip wording

Sun, Oct 20, 1:19 PM
Gallaecio updated the diff for D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

Reload → Rebuild

Sun, Oct 20, 1:18 PM
Gallaecio added inline comments to D2306: remove "Goods" from trade window stings.
Sun, Oct 20, 1:11 PM
Gallaecio accepted D2306: remove "Goods" from trade window stings.

I’m not against the use of ‘goods’ in the context of trade, where it’s the right word to refer to “tradeable resources”, but since in 0 A.D. all resources are tradeable, I’m OK with the change.

Sun, Oct 20, 1:09 PM
Gallaecio added a comment to D2312: Single Player → single-player.

Single-player is proper English, single player and singleplayer are less correct.

Sun, Oct 20, 1:04 PM
Gallaecio committed rP23082: list heroes after champions and correct some structure tooltips.
list heroes after champions and correct some structure tooltips
Sun, Oct 20, 12:57 PM
Gallaecio closed D2324: list heroes after champions and correct some structure tooltips.
Sun, Oct 20, 12:57 PM
Gallaecio accepted D2324: list heroes after champions and correct some structure tooltips.
Sun, Oct 20, 12:56 PM

Sep 18 2019

Gallaecio committed rP22928: Update translations after fixing sprintf issues.
Update translations after fixing sprintf issues
Sep 18 2019, 7:12 PM
Gallaecio accepted D1674: Check translations for sprintf errors.
Sep 18 2019, 6:55 PM

Sep 17 2019

Gallaecio retitled D2294: Rephrase the tooltip of Reload Cache to avoid confusion from Rephrase the tooltip of Reload Cache to avoid confusion to [WIP] Rephrase the tooltip of Reload Cache to avoid confusion.
Sep 17 2019, 10:02 AM
Gallaecio added a comment to D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

I’m just looking for using the same wording. If “Rebuild” works on both strings, I’ll switch both to “Rebuild”.

Sep 17 2019, 10:02 AM

Sep 15 2019

Gallaecio created D2294: Rephrase the tooltip of Reload Cache to avoid confusion.
Sep 15 2019, 2:16 PM
Gallaecio retitled D2226: Use standarized phrasing and terminology for the Patriot aura description from [WIP] Use standarized phrasing and terminology for the Patriot aura description to Use standarized phrasing and terminology for the Patriot aura description.
Sep 15 2019, 1:57 PM
Gallaecio updated the diff for D2226: Use standarized phrasing and terminology for the Patriot aura description.

Rebased

Sep 15 2019, 1:57 PM
Gallaecio committed rP22907: -ise → -ize.
-ise → -ize
Sep 15 2019, 1:53 PM
Gallaecio closed D2246: -ise → -ize.
Sep 15 2019, 1:53 PM
Gallaecio committed rP22906: standardize gather technology tooltips.
standardize gather technology tooltips
Sep 15 2019, 1:52 PM
Gallaecio closed D2253: standardize gather technology tooltips.
Sep 15 2019, 1:52 PM
Gallaecio committed rP22905: standardized hero aura descriptions.
standardized hero aura descriptions
Sep 15 2019, 1:49 PM
Gallaecio closed D1808: standardized hero aura descriptions.
Sep 15 2019, 1:49 PM
Gallaecio accepted D1808: standardized hero aura descriptions.
Sep 15 2019, 1:48 PM
Gallaecio committed rP22904: manual/intro.txt corrections.
manual/intro.txt corrections
Sep 15 2019, 1:45 PM
Gallaecio closed D2110: manual/intro.txt corrections.
Sep 15 2019, 1:45 PM
Gallaecio accepted D2246: -ise → -ize.
Sep 15 2019, 1:35 PM
Gallaecio accepted D2253: standardize gather technology tooltips.
Sep 15 2019, 1:34 PM

Sep 1 2019

Gallaecio added a comment to D2248: restore legionary scutum.

I’ve just restored the file with its previous content in https://code.wildfiregames.com/rP22830

Sep 1 2019, 9:29 PM
Gallaecio committed rP22830: legionnaire → legionary (4).
legionnaire → legionary (4)
Sep 1 2019, 9:24 PM
Gallaecio added a comment to rP22818: legionnaire → legionary.

art/actors/props/shields/rome_scutum_legionnaire.xml should have been moved to rome_scutum_legionary.xml but wasn't.

Sep 1 2019, 2:00 PM
Gallaecio committed rP22823: legionnaire → legionary (3).
legionnaire → legionary (3)
Sep 1 2019, 2:00 PM
Gallaecio added a comment to D1808: standardized hero aura descriptions.

@Freagarach May I merge?

Sep 1 2019, 12:58 PM
Gallaecio committed rP22821: standardize resource tooltips.
standardize resource tooltips
Sep 1 2019, 12:58 PM
Gallaecio closed D2006: standardize resource tooltips.
Sep 1 2019, 12:58 PM
Gallaecio added a comment to D2110: manual/intro.txt corrections.

@elexis May I merge?

Sep 1 2019, 12:57 PM
Gallaecio committed rP22820: standardize civ bonus technology tooltips.
standardize civ bonus technology tooltips
Sep 1 2019, 12:57 PM
Gallaecio closed D2187: standardize civ bonus technology tooltips.
Sep 1 2019, 12:56 PM
Gallaecio added a comment to D1780: legionnaire → legionary.

Note: Patching was a bit messy due to the renaming and spaces in files. I ended up having to push a second commit that deleted the renamed files.

Sep 1 2019, 12:54 PM
Gallaecio committed rP22819: legionnaire → legionary (2).
legionnaire → legionary (2)
Sep 1 2019, 12:54 PM
Gallaecio committed rP22818: legionnaire → legionary.
legionnaire → legionary
Sep 1 2019, 12:53 PM
Gallaecio closed D1780: legionnaire → legionary.
Sep 1 2019, 12:53 PM
Gallaecio accepted D2006: standardize resource tooltips.
Sep 1 2019, 12:28 PM

Aug 25 2019

Gallaecio retitled D2226: Use standarized phrasing and terminology for the Patriot aura description from Use standarized phrasing and terminology for the Patriot aura description to [WIP] Use standarized phrasing and terminology for the Patriot aura description.
Aug 25 2019, 12:59 PM
Gallaecio added a comment to D2226: Use standarized phrasing and terminology for the Patriot aura description.
In D2226#92500, @Nescio wrote:

However, I strongly believe D1808 should be committed first; afterwards this one could change time to speed, if deemed necessary.

Aug 25 2019, 12:58 PM
Gallaecio added a comment to D2226: Use standarized phrasing and terminology for the Patriot aura description.

I assume the example I added to the English style guide, that 0.5 attack repeat time would mean (1/0.5=2) +100% attack speed, will make it more obvious that the math works: half the time = twice the speed.

Aug 25 2019, 12:44 PM
Gallaecio updated the summary of D2226: Use standarized phrasing and terminology for the Patriot aura description.
Aug 25 2019, 12:21 PM
Gallaecio created D2226: Use standarized phrasing and terminology for the Patriot aura description.
Aug 25 2019, 12:17 PM
Gallaecio committed rP22784: standardized structure aura descriptions.
standardized structure aura descriptions
Aug 25 2019, 11:21 AM
Gallaecio closed D1806: standardized structure aura descriptions.
Aug 25 2019, 11:21 AM
Gallaecio committed rP22783: correct descriptions and tooltips of siege technologies.
correct descriptions and tooltips of siege technologies
Aug 25 2019, 11:19 AM
Gallaecio closed D2186: correct descriptions and tooltips of siege technologies.
Aug 25 2019, 11:19 AM
Gallaecio committed rP22782: update fortress tooltips.
update fortress tooltips
Aug 25 2019, 11:18 AM
Gallaecio closed D2189: update fortress tooltips.
Aug 25 2019, 11:18 AM
Gallaecio committed rP22781: update workshop tooltip.
update workshop tooltip
Aug 25 2019, 11:17 AM
Gallaecio closed D2190: update workshop tooltip.
Aug 25 2019, 11:17 AM
Gallaecio committed rP22780: remove incorrect book numbers from Plutarch Moralia.
remove incorrect book numbers from Plutarch Moralia
Aug 25 2019, 11:15 AM
Gallaecio closed D2191: remove incorrect book numbers from Plutarch Moralia.
Aug 25 2019, 11:15 AM
Gallaecio updated subscribers of D1613: Improve the plural translation of the "<players> have won" string.
Aug 25 2019, 11:05 AM
Gallaecio accepted D1780: legionnaire → legionary.
Aug 25 2019, 11:04 AM
Gallaecio accepted D1808: standardized hero aura descriptions.
In D1808#92243, @Nescio wrote:

How about “When in a formation, Spearmen ...”?

Aug 25 2019, 11:02 AM
Gallaecio accepted D2187: standardize civ bonus technology tooltips.
Aug 25 2019, 10:51 AM

Aug 24 2019

Gallaecio added inline comments to D2178: Do not quote philosopher names in quotes.txt.
Aug 24 2019, 11:24 AM
Gallaecio committed rP22771: Quote all book names in quotes.txt.
Quote all book names in quotes.txt
Aug 24 2019, 11:24 AM
Gallaecio closed D2178: Do not quote philosopher names in quotes.txt.
Aug 24 2019, 11:24 AM
Gallaecio added a comment to D1780: legionnaire → legionary.

@Stan Is the rebasing the only issue, or something that should be done before the review may continue? If it’s the only remaining issue, I can probably take care of that manually while merging.

Aug 24 2019, 11:22 AM
Gallaecio accepted D1806: standardized structure aura descriptions.
Aug 24 2019, 11:18 AM
Gallaecio added a comment to D1808: standardized hero aura descriptions.
In D1808#91032, @Nescio wrote:

What about squad, squadron, battalion, brigade, party, company, or regiment?

Those have the same problem as "formation" and potentially add more confusion.

Aug 24 2019, 11:17 AM
Gallaecio accepted D2186: correct descriptions and tooltips of siege technologies.
Aug 24 2019, 10:57 AM
Gallaecio added inline comments to D2187: standardize civ bonus technology tooltips.
Aug 24 2019, 10:53 AM
Gallaecio accepted D2189: update fortress tooltips.
Aug 24 2019, 10:44 AM
Gallaecio accepted D2190: update workshop tooltip.
Aug 24 2019, 10:36 AM
Gallaecio accepted D2191: remove incorrect book numbers from Plutarch Moralia.
Aug 24 2019, 10:36 AM

Aug 18 2019

Gallaecio committed rP22688: Scipio Aeminialus → Scipio Aemilianus.
Scipio Aeminialus → Scipio Aemilianus
Aug 18 2019, 3:45 PM
Gallaecio committed rP22687: Standardized catafalque aura descriptions.
Standardized catafalque aura descriptions
Aug 18 2019, 3:26 PM
Gallaecio closed D1807: standardized catafalque aura descriptions.
Aug 18 2019, 3:26 PM
Gallaecio added a comment to D2110: manual/intro.txt corrections.
In D2110#91004, @elexis wrote:

as a translator this will reduce to a half the number of strings that contain tags

But if tags were all on the same line, it would reduce it even further, so that the font only has to be translated once per font?

Aug 18 2019, 3:23 PM
Gallaecio committed rP22686: Capitalize classes in team bonus descriptions.
Capitalize classes in team bonus descriptions
Aug 18 2019, 3:13 PM
Gallaecio closed D2179: capitalize classes in team bonus descriptions.
Aug 18 2019, 3:13 PM
Gallaecio updated the diff for D2178: Do not quote philosopher names in quotes.txt.

Then let’s add quotes to those similar lines missing them.

Aug 18 2019, 3:11 PM
Gallaecio committed rP22685: Upgrade into a %(name)s → Upgrade to %(name)s.
Upgrade into a %(name)s → Upgrade to %(name)s
Aug 18 2019, 3:03 PM
Gallaecio closed D2165: Upgrade into a %(name)s → Upgrade to %(name)s.
Aug 18 2019, 3:03 PM
Gallaecio added a comment to D1806: standardized structure aura descriptions.

OK, I think we can merge once the + in +40 is back

Aug 18 2019, 3:02 PM
Gallaecio added a comment to D1808: standardized hero aura descriptions.

What about squad, squadron, battalion, brigade, party, company, or regiment?

Aug 18 2019, 2:59 PM
Gallaecio added a comment to D2006: standardize resource tooltips.
In D2006#90946, @Nescio wrote:

Units have different gather rates for resource subtypes, therefore it makes sense to mention both the subtype (what you gather) and the resource (what you gather) in the tooltip.

Aug 18 2019, 2:47 PM
Gallaecio accepted D2110: manual/intro.txt corrections.
In D2110#90945, @Nescio wrote:

I have no strong opinion on the tag changes; if someone else agrees with them, let’s go ahead. Otherwise, let’s keep them as before to minimize string changes.

In mark-up languages it's customary to close tags on the same line, e.g. LaTeX \textbf{lorem}, HTML <b>ipsum</b>, MarkDown **dolor**, hence my preference for [font="sans-bold-14"]sit[font="sans-14"] in this text file, which also makes it easier to see if a tag is forgotten.

Aug 18 2019, 2:43 PM

Aug 16 2019

Gallaecio added reviewers for D2165: Upgrade into a %(name)s → Upgrade to %(name)s: Itms, Stan.
Aug 16 2019, 9:39 PM
Gallaecio added inline comments to D1806: standardized structure aura descriptions.
Aug 16 2019, 9:36 PM
Gallaecio added reviewers for D1807: standardized catafalque aura descriptions: Itms, elexis.
Aug 16 2019, 9:29 PM
Gallaecio accepted D1807: standardized catafalque aura descriptions.
Aug 16 2019, 9:29 PM
Gallaecio added a comment to D1808: standardized hero aura descriptions.
In D1808#90733, @Nescio wrote:

Before I can update this, we still need to find a proper format for the formation and garrison aura types.

Maybe what we need first is to have two completely different words to refer to (1) formation as in a way a group of units can organize themselves and (2) formation as in a specific group of units. For example, if we used ‘group’ for the latter, “Same group [class] [change] [attributes]” may work.

A group is an arbitrary selection of entities, which can be defined by e.g. Ctrl+1 and selected by pressing 1 or clicking on the group panel at the left of the screen.

Aug 16 2019, 9:27 PM