Page MenuHomeWildfire Games

Gallaecio (Adrián Chaves)
User

Projects

User Details

User Since
Jan 8 2017, 1:48 PM (131 w, 2 d)

Recent Activity

Sun, Jul 14

Gallaecio awarded D1808: standardized hero aura descriptions a Love token.
Sun, Jul 14, 1:59 PM
Gallaecio added a comment to D1808: standardized hero aura descriptions.

I’ve left a few comments, but I must say I love these changes overall.

Sun, Jul 14, 1:58 PM

Mon, Jun 24

Gallaecio added inline comments to rP22081: Rome Testudo & Anti-Cavalry formations animations:.
Mon, Jun 24, 9:29 AM

Apr 7 2019

Gallaecio created D1820: island → peninsula.
Apr 7 2019, 5:54 PM

Apr 1 2019

Gallaecio committed rP22149: Improve team bonus descriptions consistency.
Improve team bonus descriptions consistency
Apr 1 2019, 12:14 AM
Gallaecio closed D1720: team bonus descriptions consistency.
Apr 1 2019, 12:14 AM
Gallaecio committed rP22148: centre → center.
centre → center
Apr 1 2019, 12:12 AM
Gallaecio closed D1802: centre → center.
Apr 1 2019, 12:12 AM
Gallaecio updated the diff for D1805: acropolis → citadel (non-Greek fort), plateau (orography).

Updated not to touch titles, and include the requested ‘4 → Four’ change.

Apr 1 2019, 12:06 AM

Mar 31 2019

Gallaecio updated the diff for D1614: English review of cavalry unit references.

Feedback applied.

Mar 31 2019, 11:56 PM
Gallaecio created D1805: acropolis → citadel (non-Greek fort), plateau (orography).
Mar 31 2019, 4:36 PM
Gallaecio updated the diff for D1614: English review of cavalry unit references.
Mar 31 2019, 1:46 PM
Gallaecio committed rP22147: can be bought → could be bought.
can be bought → could be bought
Mar 31 2019, 1:35 PM
Gallaecio closed D1801: can be brought → could be brought.
Mar 31 2019, 1:35 PM
Gallaecio accepted D1802: centre → center.
Mar 31 2019, 1:26 PM
Gallaecio accepted D1720: team bonus descriptions consistency.
Mar 31 2019, 1:24 PM

Mar 24 2019

Gallaecio requested changes to D1720: team bonus descriptions consistency.

I really like the change, I just have some minor feedback for specific lines.

Mar 24 2019, 2:26 PM
Gallaecio updated the diff for D1614: English review of cavalry unit references.

In order to move things forward, I’ve simplified the diff to change only ‘cavalry soldiers → cavalry’, which was the scope of the original report.

Mar 24 2019, 1:22 PM
Gallaecio created D1801: can be brought → could be brought.
Mar 24 2019, 1:16 PM
Gallaecio added a comment to D1780: legionnaire → legionary.

I agree with the word change. However, since this change affects filenames beyond the specific word change suggested, I’ll let people more familiar with unit filename conventions give their approval.

Mar 24 2019, 12:49 PM
Gallaecio committed rP22140: Reword the tooltip of the Disable Treasures option.
Reword the tooltip of the Disable Treasures option
Mar 24 2019, 12:35 PM
Gallaecio closed D1532: Reword the tooltip of the Disable Treasures option.
Mar 24 2019, 12:34 PM

Mar 17 2019

Gallaecio updated the diff for D1613: Improve the plural translation of the "<players> have won" string.

Fixed the plural call by repeating the English string. Notice that the first parameter of the function will never be used in English.

Mar 17 2019, 9:18 PM
Gallaecio added a comment to D1613: Improve the plural translation of the "<players> have won" string.

markForPluralTranslation is for when strings have the same content, and only change for grammatical number (e.g. singular words become plural).

Mar 17 2019, 9:12 PM
Gallaecio added a comment to D1613: Improve the plural translation of the "<players> have won" string.

Damn, you have a point in that the markForPluralTranslation function in the new code needs to have the first parameter also passed as second parameter. So the patch requires changes for sure.

Mar 17 2019, 7:57 PM
Gallaecio added a comment to D1613: Improve the plural translation of the "<players> have won" string.

I think a comment is necessary to prevent someone from accidentally reverting to something in the lines of the original code to "simplify" it.

Mar 17 2019, 6:32 PM
Gallaecio committed rP22128: rally-point → rally point.
rally-point → rally point
Mar 17 2019, 6:03 PM
Gallaecio closed D1527: rally-point → rally point.
Mar 17 2019, 6:03 PM
Gallaecio closed D1535: Remove quotes made unnecessary by capitalization.

Fixed in https://code.wildfiregames.com/rP22127

Mar 17 2019, 6:00 PM
Gallaecio committed rP22127: Remove quotes made unnecessary by capitalization.
Remove quotes made unnecessary by capitalization
Mar 17 2019, 5:56 PM
Gallaecio updated the diff for D1527: rally-point → rally point.

Rebased against the latest commit from trunk.

Mar 17 2019, 5:51 PM
Gallaecio updated the diff for D1535: Remove quotes made unnecessary by capitalization.

Rebased against the latest commit from trunk.

Mar 17 2019, 5:49 PM
Gallaecio updated the diff for D1613: Improve the plural translation of the "<players> have won" string.

Removed the note prefix, and added the ternary operator syntax to avoid declaring a variable.

Mar 17 2019, 5:45 PM
Gallaecio committed rP22123: playername → player name.
playername → player name
Mar 17 2019, 3:16 PM
Gallaecio closed D1537: playername → player name.
Mar 17 2019, 3:15 PM
Gallaecio committed rP22122: Rephrase the description of the wonder victory condition.
Rephrase the description of the wonder victory condition
Mar 17 2019, 3:13 PM
Gallaecio closed D1550: Rephrase the description of the wonder victory condition.
Mar 17 2019, 3:13 PM
Gallaecio committed rP22121: Do not generate duplicate biome strings for translation.
Do not generate duplicate biome strings for translation
Mar 17 2019, 3:08 PM
Gallaecio closed D1579: Do not generate duplicate biome strings for translation.
Mar 17 2019, 3:08 PM

Jan 4 2019

Gallaecio added a comment to D1537: playername → player name.
In D1537#69096, @bb wrote:

Isn't that what I say too? (notice the capital letter N)

Jan 4 2019, 10:28 PM

Dec 28 2018

Gallaecio added a comment to D1551: slaugther → slaughter.
In D1551#67522, @Stan wrote:

@Gallaecio Do you want me to commit this, or will you do it ?

Dec 28 2018, 7:10 PM

Aug 22 2018

Gallaecio added a comment to D1614: English review of cavalry unit references.

OK, so please state your suggested replacements for the cavalry unit names I added to the English style guide (https://trac.wildfiregames.com/wiki/EnglishStyleGuide , Units section), and lets wait for feedback.

Aug 22 2018, 6:23 AM

Aug 21 2018

Gallaecio added a comment to D1614: English review of cavalry unit references.

How would you phrase “If you accidentally select a Cavalry Citizen Soldier, hold Ctrl and click on the Cavalry Citizen Soldier icon of the selection panel at the bottom of the screen to remove the Cavalry Citizen Soldier from the current selection.”?

Aug 21 2018, 10:35 PM
Gallaecio updated subscribers of D1614: English review of cavalry unit references.

That was my initial idea, but when I went to update the English style guide (https://trac.wildfiregames.com/wiki/EnglishStyleGuide) accordingly, I though that rather than having "Cavalry" for uncountable plural (e.g. +10% attack against Cavalry) and "Cavalry Unit" for countable scenarios (e.g. train 1 Cavalry Unit, train 6 Cavalry Units) it was better to keep it simple and use Cavalry Units also for the former scenario.

Aug 21 2018, 8:41 PM

Aug 18 2018

Gallaecio added reviewers for D1614: English review of cavalry unit references: Itms, Nescio.
Aug 18 2018, 10:22 PM
Gallaecio created D1614: English review of cavalry unit references.
Aug 18 2018, 10:20 PM
Gallaecio created D1613: Improve the plural translation of the "<players> have won" string.
Aug 18 2018, 7:55 PM
Gallaecio created D1612: north-west africa → Northwest Africa.
Aug 18 2018, 6:45 PM

Jul 26 2018

Gallaecio updated the diff for D1535: Remove quotes made unnecessary by capitalization.

Add an additional change reported by @bb.

Jul 26 2018, 7:29 PM
Gallaecio updated the diff for D1550: Rephrase the description of the wonder victory condition.

game mode → mode, as suggested by @elexis.

Jul 26 2018, 7:24 PM
Gallaecio added a comment to D1527: rally-point → rally point.
In D1527#63495, @bb wrote:

binaries/data/mods/public/gui/session/unit_actions.js has one too

Jul 26 2018, 7:19 PM

Jun 20 2018

Gallaecio added a comment to D1579: Do not generate duplicate biome strings for translation.
In D1579#63499, @elexis wrote:

It still ends up as the same string on transifex, right? So people didn't have to do twice the work, just the public-maps.pot file was unclean?

Jun 20 2018, 11:10 PM

Jun 16 2018

Gallaecio added a comment to D1579: Do not generate duplicate biome strings for translation.

Not a problem. In fact, I was the one that should have been watching Transifex, but instead I abandoned the project without a word. I’ll try to make it up.

Jun 16 2018, 12:26 PM
Gallaecio added a comment to D1580: Improve the description of the Teacher aura.

For consistency and readability, I think that is it better the way it is.

Jun 16 2018, 12:12 PM
elexis awarded D1579: Do not generate duplicate biome strings for translation a Like token.
Jun 16 2018, 12:09 PM
Gallaecio created D1580: Improve the description of the Teacher aura.
Jun 16 2018, 11:46 AM
Gallaecio created D1579: Do not generate duplicate biome strings for translation.
Jun 16 2018, 11:38 AM
Gallaecio abandoned D1552: Druides → Druid.

I’ve just realized that we are dealing with the SpecificName, the one that is not in English, but localized to the corresponding civilization.

Jun 16 2018, 7:35 AM

Jun 13 2018

Gallaecio updated the diff for D1569: <word> , <word> → <word>, <word>.

Indeed, thanks!

Jun 13 2018, 7:21 PM

Jun 9 2018

Gallaecio updated the diff for D1550: Rephrase the description of the wonder victory condition.

Switched ‘owners’ to ‘owner’, as reported by @bb.

Jun 9 2018, 3:52 PM
Gallaecio created D1569: <word> , <word> → <word>, <word>.
Jun 9 2018, 3:49 PM

Jun 2 2018

Gallaecio created D1553: multi-coloured → multi-colored.
Jun 2 2018, 12:25 PM
Gallaecio created D1552: Druides → Druid.
Jun 2 2018, 12:18 PM
Gallaecio added a reviewer for D1551: slaugther → slaughter: Stan.
Jun 2 2018, 12:15 PM
Gallaecio created D1551: slaugther → slaughter.
Jun 2 2018, 11:59 AM
Gallaecio created D1550: Rephrase the description of the wonder victory condition.
Jun 2 2018, 11:50 AM
Gallaecio created D1549: Slightly rephrase the description of fishing nets.
Jun 2 2018, 11:39 AM
Gallaecio updated the diff for D1536: barracks → Barracks.

Updated according to @bb’s feedback.

Jun 2 2018, 9:08 AM
Gallaecio added a comment to D1528: Chose → Choose (imperative).
In D1528#62663, @bb wrote:

(Don't we have some inline in another revision about this?)

Jun 2 2018, 9:00 AM
Gallaecio updated the diff for D1528: Chose → Choose (imperative).

Updated according to @bb’s feedback.

Jun 2 2018, 8:58 AM

May 29 2018

Gallaecio abandoned D1542: Replace periods with semicolons in network error reasons.

Nice, I’ll close this one then.

May 29 2018, 1:24 PM

May 28 2018

Gallaecio created D1542: Replace periods with semicolons in network error reasons.
May 28 2018, 11:07 PM
Gallaecio created D1541: Temple for Athena → Temple of Athena Nike.
May 28 2018, 10:47 PM
Gallaecio created D1540: Selecus → Seleucus.
May 28 2018, 10:22 PM
Gallaecio created D1539: <sentence> and <long sentence> and <long sentence> → <sentence> and <long sentence>. <long sentence>.
May 28 2018, 10:17 PM

May 27 2018

Gallaecio created D1537: playername → player name.
May 27 2018, 8:12 PM
Gallaecio created D1536: barracks → Barracks.
May 27 2018, 7:57 PM
Gallaecio created D1535: Remove quotes made unnecessary by capitalization.
May 27 2018, 7:54 PM
Gallaecio created D1534: constructed → ready (a field).
May 27 2018, 7:42 PM
Gallaecio created D1533: Reword the description of the Temple at Naqa aura.
May 27 2018, 7:37 PM
Gallaecio created D1532: Reword the tooltip of the Disable Treasures option.
May 27 2018, 7:07 PM
Gallaecio created D1531: aide → aid.
May 27 2018, 6:52 PM
Gallaecio created D1530: cit-states → city-states.
May 27 2018, 6:46 PM
Gallaecio created D1529: BackSlash → Backslash.
May 27 2018, 6:37 PM

May 26 2018

Gallaecio created D1528: Chose → Choose (imperative).
May 26 2018, 9:23 PM
Gallaecio created D1527: rally-point → rally point.
May 26 2018, 9:09 PM
Gallaecio created D1526: reaffect → reassign.
May 26 2018, 8:35 PM
Gallaecio committed rP21826: Revert 21825, it violates current freezes.
Revert 21825, it violates current freezes
May 26 2018, 8:26 PM
Gallaecio added a reverting change for rP21825: reaffect → reassign: rP21826: Revert 21825, it violates current freezes.
May 26 2018, 8:26 PM
Gallaecio committed rP21825: reaffect → reassign.
reaffect → reassign
May 26 2018, 8:22 PM
Gallaecio abandoned D1265: Mark tribute messages for plural translation.

I’ve lost interest in working on this for the time being. I will look into internalization issues that are easier to fix.

May 26 2018, 7:31 PM

Mar 12 2018

Gallaecio added a comment to D1265: Mark tribute messages for plural translation.

I am having trouble verifying that it works, as I am not familiar with Petra. Originally, I tried to ask for an alliance to all 7 players in a game, hoping that at least one would ask for tributes, but n luck. Now I have edited handleDiplomacyRequest(), commenting out part of its content to force the last case of the if/else statement to occur, but I still could not get an AI player to request tributes. I will have to look deeper into the Petra AI code to try and get the AI to send one of those plural messages.

Mar 12 2018, 2:53 PM

Jan 29 2018

Gallaecio added a comment to D1265: Mark tribute messages for plural translation.

I found the #4597 ticket by chance in one of the Transifex reports, it was not my intention to fix it, I just thought I had fixed it with these changes.

Jan 29 2018, 6:33 PM

Jan 28 2018

Gallaecio created D1265: Mark tribute messages for plural translation.
Jan 28 2018, 10:20 AM
Gallaecio committed rP21043: Fix bad plural reported by safaalfulaij at Transifex.
Fix bad plural reported by safaalfulaij at Transifex
Jan 28 2018, 6:32 AM

Jan 27 2018

Gallaecio committed rP21034: build (human units) → train, build (siege weapons) → construct.
build (human units) → train, build (siege weapons) → construct
Jan 27 2018, 2:54 PM
Gallaecio committed rP21032: Rephrase Druids aura description.
Rephrase Druids aura description
Jan 27 2018, 1:07 PM

Jan 17 2018

elexis awarded D1123: Build with the "read-only relocation" hardening linker flag a Like token.
Jan 17 2018, 8:26 PM · Contributors
Gallaecio committed rP20896: Build with the "read-only relocation" hardening linker flag.
Build with the "read-only relocation" hardening linker flag
Jan 17 2018, 7:02 PM
Gallaecio closed D1123: Build with the "read-only relocation" hardening linker flag.
Jan 17 2018, 7:02 PM · Contributors