- User Since
- Jan 8 2017, 1:48 PM (100 w, 4 d)
Aug 22 2018
OK, so please state your suggested replacements for the cavalry unit names I added to the English style guide (https://trac.wildfiregames.com/wiki/EnglishStyleGuide , Units section), and lets wait for feedback.
Aug 21 2018
How would you phrase “If you accidentally select a Cavalry Citizen Soldier, hold Ctrl and click on the Cavalry Citizen Soldier icon of the selection panel at the bottom of the screen to remove the Cavalry Citizen Soldier from the current selection.”?
That was my initial idea, but when I went to update the English style guide (https://trac.wildfiregames.com/wiki/EnglishStyleGuide) accordingly, I though that rather than having "Cavalry" for uncountable plural (e.g. +10% attack against Cavalry) and "Cavalry Unit" for countable scenarios (e.g. train 1 Cavalry Unit, train 6 Cavalry Units) it was better to keep it simple and use Cavalry Units also for the former scenario.
Aug 18 2018
Jul 26 2018
Add an additional change reported by @bb.
game mode → mode, as suggested by @elexis.
Jun 20 2018
Jun 16 2018
Not a problem. In fact, I was the one that should have been watching Transifex, but instead I abandoned the project without a word. I’ll try to make it up.
For consistency and readability, I think that is it better the way it is.
I’ve just realized that we are dealing with the SpecificName, the one that is not in English, but localized to the corresponding civilization.
Jun 13 2018
Jun 9 2018
Switched ‘owners’ to ‘owner’, as reported by @bb.
Jun 2 2018
Updated according to @bb’s feedback.
Updated according to @bb’s feedback.
May 29 2018
Nice, I’ll close this one then.
May 28 2018
May 27 2018
May 26 2018
I’ve lost interest in working on this for the time being. I will look into internalization issues that are easier to fix.
Mar 12 2018
I am having trouble verifying that it works, as I am not familiar with Petra. Originally, I tried to ask for an alliance to all 7 players in a game, hoping that at least one would ask for tributes, but n luck. Now I have edited handleDiplomacyRequest(), commenting out part of its content to force the last case of the if/else statement to occur, but I still could not get an AI player to request tributes. I will have to look deeper into the Petra AI code to try and get the AI to send one of those plural messages.
Jan 29 2018
I found the #4597 ticket by chance in one of the Transifex reports, it was not my intention to fix it, I just thought I had fixed it with these changes.
Jan 28 2018
Jan 27 2018
Jan 17 2018
Jan 16 2018
Changes applied to both premake files, and attribution to Vincent added as well.
Jan 9 2018
Jan 8 2018
Jan 7 2018
Jan 6 2018
Fix Misc / Bribes as well, as requested by elexis on IRC
Use || instead of if/else, as suggested by elexis on IRC
Fix the indentation of new code
Dec 31 2017
May 1 2017
All new quotes seem to come from external, reliable sources (i.e. not translated by the patch author himself), so while I may not totally agree with some of them, I expect them to be widely accepted nonetheless. +1 for me.
Apr 2 2017
I’ve added some inline comments about description contents. Most of them are mere subjective suggestions, but I would like to at least enforce the “defence” → “defense” change (assuming that the rest of the game uses US spelling).
Mar 28 2017
I’ve added some text suggestions, but the current proposal seems good nonetheless.
Mar 22 2017
There is not much I can say here, sorry. Once implemented, I would like to see how it integrates with our CI, how the output is handled and presented, and what types of issues it manages to find.
Feb 28 2017
Your last suggestion works for me.
Assuming that there is a single type of goods of origin and a single target type of goods, and assuming also that only the type of goods of origin (but not the target type of goods) can be set to 100% by pressing the hotkey while selecting that resource, I agree with the change.