- User Since
- Jan 8 2017, 1:48 PM (186 w, 5 d)
Feb 9 2020
Jan 27 2020
Jan 26 2020
Jan 22 2020
Jan 19 2020
I’ve left one more comment, but overall this is an amazing change for the better, great work!
Jan 18 2020
Jan 15 2020
Jan 11 2020
Nov 24 2019
Nov 23 2019
Shall I merge the changes as is, then?
Nov 16 2019
You are right, it looks like i18n-aware list-building is more complex than I though. On the bright side, it looks like ICU 50 provides a function for this, so we should be able to solve the issue without exposing any list-building string to our translators. I’ll try to work on this next weekend, and improve Player.prototype.SubtractResourcesOrNotify as well as part of these changes.
Yeah, you are right. It’s just that I’m not used to seing “Single-player” on its own in a button, but it’s correct, the noun (game mode) is just omitted. I’ve left a couple of suggestions, but I’m OK with merging as is. I’ll probably merge it next weekend.
Nov 2 2019
I agree with @Polakrity here, I think “attack” should not be used to refer to capture in user-visible strings, and assuming melee and ranged attacks are the only possible attack types of potentially affected units, removing the attack type mention makes sense. I’m not sure is that assumption is correct, though. Can someone confirm that?
Use a more flexible approach which also make the code more readable
Rename ‘attack speed’ to ‘attack rate’ based on community feedback
I’m worried that discussing so many different changes may take some time. @Nescio what would you think about creating separate patches instead? Some of the changes should be pretty straightforward to apply that way.
Where can I find the run time logs of https://trac.wildfiregames.com/browser/ps/trunk/build/jenkins/lint-translations.sh?
Oct 20 2019
Should we get this script merged, to make it easier to use it next time?
I’ve just posted https://wildfiregames.com/forum/index.php?/topic/27150-wording-attack-repeat-time-vs-attack-time-vs-time-between-attacks-vs-attack-speed/ to discuss this, and CC’d people both from here and from https://trac.wildfiregames.com/ticket/3600
Restore the previous tooltip wording
Reload → Rebuild
I’m not against the use of ‘goods’ in the context of trade, where it’s the right word to refer to “tradeable resources”, but since in 0 A.D. all resources are tradeable, I’m OK with the change.
Single-player is proper English, single player and singleplayer are less correct.
Sep 18 2019
Sep 17 2019
I’m just looking for using the same wording. If “Rebuild” works on both strings, I’ll switch both to “Rebuild”.
Sep 15 2019
Sep 1 2019
I’ve just restored the file with its previous content in https://code.wildfiregames.com/rP22830
@Freagarach May I merge?
@elexis May I merge?
Note: Patching was a bit messy due to the renaming and spaces in files. I ended up having to push a second commit that deleted the renamed files.
Aug 25 2019
I assume the example I added to the English style guide, that 0.5 attack repeat time would mean (1/0.5=2) +100% attack speed, will make it more obvious that the math works: half the time = twice the speed.