Removed comments

Minor bug fix

Addressed the reviews, implemented a very rudimentary "back to normal" mode

Fixed warnings arc lint didn't show me locally

Addressed all reviews, except implemeting a rudimental "Back-to-normal"-Mode and the question where to store it

One thing, I think this lacks is recovering, we stay in the emergency state forever, even if we'd win.

I will redo this, as the code here is an unreadable mess, same for the commit history

@nwtour Sadly I couldn't reproduce it. Can you really pinpoint it to this change? Theoretically the behavior should stay the same, as I just replace some magic numbers with constants

Addressed the code review comments; rebased

Replaced the "=="/"!=" with "===" or "!==".

Added some constants that weren't replaced

Addressed code review

Addressed nearly every code comment. (Doesn't work at the moment)

Move the constants back between constructor and "init"/"update"

Reverted the move of the constants to the top. They will now live between the constructor and "init"/"update".

I broke it:

ERROR: Error in timer on entity 10, IID90, function UpdateSequences: TypeError: this.sequences is undefined
  StatisticsTracker.prototype.UpdateSequences@simulation/components/StatisticsTracker.js:549:2
  Timer.prototype.OnUpdate@simulation/components/Timer.js:139:44

Addressed review comments from D4343 for consistency

Fixed diff

Addressed review comments.

Removed duplicate newline that was added by accident

Addressed comments

Reordered the constants

Fixed some linter warnings

Emergency bugfix ;D

Removed my logging, cleaned up the code. Ready for review

1. Cleaned up the code.
2. Added some messages that the AI will say.
3. Removed some minor bugs

After an hour I destroyed all her four CC and she started to retreat to a central point in the middle of the map, after a short time the Ai committed suicide and I won.

@Langbart I wasn't able to reproduce it. (The red ones won at the end, the blue one did nearly nothing). But if the AI kills itself instantly this means either:

I think I fixed "army is undefined" and "undefined has no properties".

"army is undefined" still happens. Minor tweaks

I think I fixed the error in defenseManager.js (army is undefined). Only Petra error in incrementBuilderCounters for structures/kush/camp_noba with count < 0 and unknown type in garrisonManager undefined for Athenian Hoplite id 13212 inside Barracks id 12541 remain.

Minor bugfixes.
Ungarrisoning still doesn't work. Found another error message after returning from emergency mode

*Maybe* fixed the ungarrisoning.(Worked twice, but I have to test it more) Furthermore I was able to fix some errors, that occur after returning from emergency state.

Fixed some bugs and errors.

Fixed the sending/expiring of neutrality requests. The aggressive AI will destroy every building it has. (Maybe it should retain all buildings that make damage)

Cleaned up the code, added several corrections. The code still has to be cleaned up a lot.

No review necessary at the moment, as still WIP.

Code works as advertised and is clear/understandable

(Not ready for review)

Sync between repo and phabricator. (Review is not necessary at the moment)

Fixed the patch ^^

Implemented majority of corrections, the other will follow

Added correction.

Added corrections

-Fixed bug, when the collect point is unreachable, all units try forever to go to the point
-Ships now don't count, if they can't reach a collect point
-If defensive+cooperative: If all neutrality requests were accepted and at least territory root is still available, then the state of emergency is lifted.

Added corrections

Just for my information, what is your reasoning behind putting it in Commands.js (the simulation) as opposed to in unit_actions.js (the GUI)?

Relics and ruins don't show the button anymore

Button is not shown anymore, if the unit wouldn't be moved anyway

Freagarach, I disagree with you.