Page MenuHomeWildfire Games

Kuba386 (J K)
User

Projects

User Details

User Since
Dec 18 2018, 5:32 PM (39 w, 2 d)

Recent Activity

Jul 24 2019

Kuba386 accepted D1918: Move pathfinder work to a worker (not yet threaded - D14 prerequisite).

Tested on Jebel Barkal, Mainland, Lake, Snowflake, with AI and multiplayer.
Everything seems to work.

Jul 24 2019, 12:22 PM

Jul 13 2019

Kuba386 added inline comments to D1918: Move pathfinder work to a worker (not yet threaded - D14 prerequisite).
Jul 13 2019, 2:13 PM

Jul 6 2019

Kuba386 added inline comments to D1918: Move pathfinder work to a worker (not yet threaded - D14 prerequisite).
Jul 6 2019, 9:52 PM

May 19 2019

Kuba386 accepted D1854: Remove 'Async' from short/long path requests names.
May 19 2019, 4:54 PM

Jan 5 2019

Kuba386 planned changes to D14: [RC] Thread the pathfinder computations.

Using 255 threads was not the reason. I still get segfault. I will have to take a closer look at this bug...

Jan 5 2019, 8:33 PM
Kuba386 added a comment to D14: [RC] Thread the pathfinder computations.

Ok, I've figured it out. I got stack overflow because I've once set 255 threads and forgot to set it back to 6.

Jan 5 2019, 7:13 PM
Kuba386 added a comment to D14: [RC] Thread the pathfinder computations.

It was linux. I always use linux. And I've never had problems with RAM, and it is not what caused crash.

Jan 5 2019, 5:07 PM
Kuba386 added a comment to D14: [RC] Thread the pathfinder computations.

This is what callgrind told me about the crash:

Jan 5 2019, 5:05 PM
Kuba386 added a comment to D14: [RC] Thread the pathfinder computations.

Well, it's not ready. I get segmentation fault on Jebel Barkal. It's unclear why. It happened after 4 minutes of playing and wasn't caused directly by any of my actions. It happened while my units were fighting against gaia.

Jan 5 2019, 5:01 PM
Kuba386 commandeered D14: [RC] Thread the pathfinder computations.

In that case, you should use "Commandeer Revision", which will mark you as author and will automatically put @wraitii as reviewer. ๐Ÿ™‚

Jan 5 2019, 1:35 PM
Kuba386 updated the diff for D14: [RC] Thread the pathfinder computations.

Maybe fixed issue with tests.
Well, button said "resign as reviewer". I've only intended to cancel my old review that is not correct anymore.
I'm still working on this.

Jan 5 2019, 10:17 AM

Jan 4 2019

Kuba386 resigned from D14: [RC] Thread the pathfinder computations.
Jan 4 2019, 6:38 PM
Kuba386 updated the diff for D14: [RC] Thread the pathfinder computations.

Changed thread number limit from 64 to 255

Jan 4 2019, 6:33 PM
Kuba386 added inline comments to D14: [RC] Thread the pathfinder computations.
Jan 4 2019, 3:56 PM
Kuba386 updated the diff for D14: [RC] Thread the pathfinder computations.

Reupload

Jan 4 2019, 2:49 PM

Jan 3 2019

Kuba386 added a comment to D14: [RC] Thread the pathfinder computations.
In D14#68885, @Stan wrote:

Did you manage to get people on the lobby to try using my packages ?

Jan 3 2019, 8:44 PM
Kuba386 updated the diff for D14: [RC] Thread the pathfinder computations.

Some changes according to comments.

Jan 3 2019, 8:39 PM
Kuba386 added inline comments to D14: [RC] Thread the pathfinder computations.
Jan 3 2019, 7:21 PM
Kuba386 added inline comments to D14: [RC] Thread the pathfinder computations.
Jan 3 2019, 7:14 PM
Kuba386 added inline comments to D14: [RC] Thread the pathfinder computations.
Jan 3 2019, 7:11 PM
Kuba386 added inline comments to D14: [RC] Thread the pathfinder computations.
Jan 3 2019, 5:35 PM

Dec 30 2018

Kuba386 added inline comments to D14: [RC] Thread the pathfinder computations.
Dec 30 2018, 10:02 PM
Kuba386 added a comment to D14: [RC] Thread the pathfinder computations.

@Stan
Thank you for response, I've already fixed all of issues you mentioned in inline comments except the one in test_Pathfinder.h

Dec 30 2018, 8:20 PM
Kuba386 updated the diff for D14: [RC] Thread the pathfinder computations.

Added myself to programming.json

Dec 30 2018, 3:23 PM
Kuba386 updated the diff for D14: [RC] Thread the pathfinder computations.

Some small changes. Updated years to 2018 in copyright headers.
I think it's ready or almost ready to commit.

Dec 30 2018, 3:14 PM

Dec 29 2018

Kuba386 updated the diff for D14: [RC] Thread the pathfinder computations.

Patch now does pass unit tests.

Dec 29 2018, 9:52 PM
Kuba386 updated the diff for D14: [RC] Thread the pathfinder computations.

Updated to be compatibile with lates commit.

Dec 29 2018, 8:58 PM

Dec 28 2018

Kuba386 added a comment to D14: [RC] Thread the pathfinder computations.

Sorry for whitespace differences again... This has to be an issue with my editor... :(

Dec 28 2018, 6:48 PM
Kuba386 updated the diff for D14: [RC] Thread the pathfinder computations.

Fixed (some of) reported memory leaks. Merged with D53.
I've fixed reperted memory leaks (maybe not all of them but memory usage is significantly lower).
Some time ago I merged this with D53 on my computer and uploaded patch to forum. I'm not sure if it's ok to upload merged version here, but I only have merged version on my computer.
Uploading non-merged version would mean downloading latest version and applying all of my changes again, manually.
D53 is also about upgrading pathfinder and probably would be commited anyway so I think it's not bad to upload merged version.

Dec 28 2018, 6:45 PM
Kuba386 added inline comments to D14: [RC] Thread the pathfinder computations.
Dec 28 2018, 5:17 PM

Dec 26 2018

Kuba386 added a comment to D14: [RC] Thread the pathfinder computations.

I am working on some bugfixes (see topic in forum). I had no time during christmas but now I will start working again.

Dec 26 2018, 10:02 PM
Kuba386 requested changes to D14: [RC] Thread the pathfinder computations.
Dec 26 2018, 10:01 PM

Dec 23 2018

Kuba386 added a comment to D14: [RC] Thread the pathfinder computations.

@FeXoR

I guess playing a game fluent is more important than a replay being nice and smooth on all machines...

So I think, and that is why I suggested choosing optimal game parameters for players. Saving it in replay is only necessary for other players to play the replay correctly.
I think choosing optimal value of MaxSaneTurnMoves is important because it has large influence on gameplay quality. It's optimal value is different for different players so we can't just hardcode it like it is currently.
I will start working on this now.

Dec 23 2018, 8:18 PM

Dec 22 2018

Kuba386 added a comment to D14: [RC] Thread the pathfinder computations.

@elexis

One could also run a match (set it to multiplayer, so that it records the simulation hash to the replay) and then replay that match. The replay mode tests the hashes and complains with an out-of-sync error if the simulation state differs somewhere.

I've already done that before submitting this patch :)

Dec 22 2018, 12:00 PM

Dec 21 2018

Kuba386 added a comment to D14: [RC] Thread the pathfinder computations.

@elexis

In multiplayer matches, the 7 players with quadcores will always wait for the 1 player with a single core laptop. This can lead to the exclusion of players with less than average CPUs from multiplayer matches.

Players with slower hardware will always slow down players with faster hardware. This issue also exists without multithreaded pathfinder.

The CPU will heat up more. The cores are not available to other processes anymore. pyrogenesis will even consume more CPU power if players increase the population limits.

That's why I've added option to manually choose number of worker threads. If player experiences such problems he can set number of threads to smaller one.

Dec 21 2018, 6:03 PM

Dec 18 2018

Kuba386 added a comment to D14: [RC] Thread the pathfinder computations.

Debugger launch failed: No such file or directory

Dec 18 2018, 7:41 PM
Kuba386 updated the diff for D14: [RC] Thread the pathfinder computations.

Updated to latest 0 A.D. version, added settings entry for selecting worker thread count.
Compiles (at least on my machine), and drastically reduces amount of lags in game. Seems to work for multiplayer.

Dec 18 2018, 6:42 PM