Page MenuHomeWildfire Games

LukeV1
User

Projects

User Details

User Since
Jan 29 2018, 2:39 PM (97 w, 3 d)

Recent Activity

Aug 20 2019

LukeV1 added inline comments to D2088: Fix uncaught nullptr exception in TextureManager.
Aug 20 2019, 3:09 PM

Aug 19 2019

LukeV1 added inline comments to D2088: Fix uncaught nullptr exception in TextureManager.
Aug 19 2019, 5:44 PM
LukeV1 added a comment to D2088: Fix uncaught nullptr exception in TextureManager.

Thanks for looking into this and giving such detailed info!!

Aug 19 2019, 5:11 PM

Aug 4 2019

LukeV1 added a comment to D2088: Fix uncaught nullptr exception in TextureManager.

I'm not sure it works on every platform, maybe @Itms would know.

It won't since clip.exe is a windows tool...
But on the other hand the current solution in the wiki isn't working at all on windows with TortoiseSVN installed. So just adding this shouldn't be that bad :)

Aug 4 2019, 2:49 PM
LukeV1 updated the diff for D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.

Upload patch again with new master revision and full file context.

Aug 4 2019, 2:40 PM · Windows Developers

Aug 1 2019

LukeV1 updated the diff for D2088: Fix uncaught nullptr exception in TextureManager.
Aug 1 2019, 10:19 AM
LukeV1 updated the diff for D2088: Fix uncaught nullptr exception in TextureManager.

Ahh! Thanks a lot. This did the trick - here is the full patch with context.
Maybe your cmd command could be added to the wiki page so others don't run in this trouble too?

Aug 1 2019, 10:10 AM

Jul 31 2019

LukeV1 added a comment to D2088: Fix uncaught nullptr exception in TextureManager.

Could you add a context to the patch?

Jul 31 2019, 11:38 AM

Jul 16 2019

LukeV1 updated the summary of D2088: Fix uncaught nullptr exception in TextureManager.
Jul 16 2019, 9:50 PM
LukeV1 created D2088: Fix uncaught nullptr exception in TextureManager.
Jul 16 2019, 9:49 PM

Feb 22 2018

LukeV1 added a comment to D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.

Regarding the use of GetLastError() for a more detailed error info there are several issues that should be considered first:

Feb 22 2018, 10:53 PM · Windows Developers
LukeV1 added inline comments to D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.
Feb 22 2018, 5:32 PM · Windows Developers
LukeV1 updated the diff for D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.

Moved the include statement. Using the win fuction GetLastError() isn't that easy in this context, see code comment

Feb 22 2018, 5:14 PM · Windows Developers

Feb 11 2018

LukeV1 added inline comments to D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.
Feb 11 2018, 11:16 PM · Windows Developers
LukeV1 updated the diff for D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.

Fixed typo

Feb 11 2018, 11:14 PM · Windows Developers
LukeV1 updated the diff for D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.

Changed comments and macro name. Works on Windows, logs error correctly.
In many cases pyrogenesis is still crashing afterwards because other components try to read non-existent files. Therefore passing the error to the caller isn't enough and we should keep the LOGERROR line there to preserve the crash information.

Feb 11 2018, 11:12 PM · Windows Developers

Feb 10 2018

LukeV1 added a comment to D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.
In D1274#52775, @elexis wrote:

Sure about this? We have these things that allow multiple inclusions of header files

...
#ifndef INCLUDED_XEROMYCES
#define INCLUDED_XEROMYCES

Yes, I know about these preprocessor constructs. But I think this will not work because ifndef can't be used for macros (since they contain a #define statement). I did some basic test but couldn't get it working.

Feb 10 2018, 4:16 PM · Windows Developers

Feb 9 2018

LukeV1 added a comment to D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.

Unfortunately I couldn't fully test this revision since I stumbled across a quite strange problem:
(it stopped at the breakpoint and I klicked on "step into" once)

Feb 9 2018, 8:31 PM · Windows Developers
LukeV1 updated the diff for D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.

Changed the error return value.
Unfortunately I had to include FileIo.h to be able to use PSRETURN_File_WriteFailed. Couldn't define it in Xeromyces.h since FileIo.h and Xeromyces.h are included simultaneously in some other files which would then lead to a redefinition of ERROR_GROUP(File);.

Feb 9 2018, 8:24 PM · Windows Developers

Feb 8 2018

LukeV1 updated the test plan for D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.
Feb 8 2018, 9:06 PM · Windows Developers

Feb 7 2018

LukeV1 updated the diff for D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.

Complete rework. Had to introduce a new macro to convert the "+1" error to a "-1" error.

Feb 7 2018, 10:08 PM · Windows Developers

Feb 6 2018

LukeV1 added a comment to D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.

Ok, now this makes sense, thanks for the links. And yes, my diff is absolutely useless because I just ignore the error now...

Feb 6 2018, 6:05 PM · Windows Developers

Jan 31 2018

LukeV1 added a comment to D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.

Thanks for pointing me to status.cpp - now i've realized the status is just a 64 bit signed int. Interestingly enough the status isn't negative but plus 1 most of the time (and sometimes - quite rarely - it is actually zero). I've used debug_prtinf with %I64d for output what should be working?!
To be more specific: The status of SetFilePointerEx and SetEndOfFile are 1 most of the times, but while WARN_IF_FALSE(SetFilePointerEx( don't cause a crash WARN_IF_FALSE(SetEndOfFile( does. Replacing this line with the diff or just entirely removing the Macro (which doesn't sound that good) avoids crashing and the game is working then.

Jan 31 2018, 10:01 PM · Windows Developers
LukeV1 updated the diff for D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.

Diff update: Using WARN_IF_ERR instead of RETURN_STATUS_IF_ERR as suggested by elexis

Jan 31 2018, 9:40 PM · Windows Developers

Jan 30 2018

LukeV1 added a comment to D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.
In D1274#51517, @elexis wrote:

To clarify, you're saying it loads all files successfully despite the anti-virus scanner?

Yes, it seems so. But something is going wrong with the the "old" error handling for the handle, because the process dies spontaneously somewhere in the WARN_IF_FALSE-makro - when the anti-virus scanner is active.
With the macro RETURN_STATUS_IF_ERR however it is fully working...

Jan 30 2018, 7:48 PM · Windows Developers

Jan 29 2018

elexis awarded D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security a Like token.
Jan 29 2018, 6:36 PM · Windows Developers
LukeV1 updated the summary of D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.
Jan 29 2018, 3:17 PM · Windows Developers
LukeV1 created D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.
Jan 29 2018, 3:15 PM · Windows Developers