Page MenuHomeWildfire Games

Mercury (Mercury)
User

Projects

User Details

User Since
Tue, May 10, 1:35 AM (1 w, 5 d)

Recent Activity

Fri, May 13

Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

formatting whitespace, change some let to const.

Fri, May 13, 7:58 AM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Default arguments for EjectOrKill, removed VIM from .gitignore

Fri, May 13, 7:15 AM

Thu, May 12

Mercury added inline comments to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.
Thu, May 12, 7:07 PM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

generated with git diff -U9999 instead of git diff --no-prefix -U9999

Thu, May 12, 7:46 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

I don't know what Vulcan is trying to tell me here.

Thu, May 12, 7:41 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Diff has context now I hope.

Thu, May 12, 7:30 AM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

renamed attacker and attackerOwner parameters to changeSource and changeSourceOwner in Health.RegisterHealthChanged and throughout GarisonHolder.

Thu, May 12, 7:29 AM

Wed, May 11

Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Potential optimization to the event listener?

Wed, May 11, 9:11 PM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

git diff --no-prefix -U9999

Wed, May 11, 8:40 PM

Tue, May 10

Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@wraitii Ok, thanks for the help :)

Tue, May 10, 12:47 PM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

style conformity changes, no semantic change.

Tue, May 10, 12:39 PM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Remove DamageTaken, add attacker and attackerOwner to HealthChanged

Tue, May 10, 12:14 PM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

HealthChanged is fired in RegisterHealthChanged
RegisterHealthChanged is called in Reduce
Reduce is called in TakeDamage
TakeDamage has attacker

Tue, May 10, 11:35 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@wraitii Another issue with storing which entity they died trying to get out of is that the entity might not be destroyed at that moment.

Tue, May 10, 10:58 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@wraitii Storing in the stats tracker and integrating at the end sounds ok. It won't assign loot.

Tue, May 10, 10:01 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

oh wait, the last line of
void CComponentManager::PostMessage(entity_id_t ent, const CMessage& msg)
is
SendGlobalMessage(ent, msg);

Tue, May 10, 9:18 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Looking at source/simulation2/system/ComponentManager.cpp line 974 it seems to be saying that when you provide an entity to PostMessage only the components of that entity will be notified.

Tue, May 10, 9:11 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@Stan would something like

Tue, May 10, 9:01 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@Stan Is that true when the event is targeting a single entity as well?

Tue, May 10, 8:55 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

I put some time into thinking about how to do this without a message but didn't come up with anything better. JS event emitters are generally kinda cheap I thought? Just a hash table lookup with a JIT symbol and a run through an array of callbacks. Should cost almost nothing if there are no listeners. O(1)?

Tue, May 10, 8:44 AM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

included previously unincluded files

Tue, May 10, 7:56 AM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

fixing which files are included hopefully

Tue, May 10, 7:37 AM
Mercury requested review of D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.
Tue, May 10, 7:34 AM